]> granicus.if.org Git - postgresql/log
postgresql
15 years agoUpdate UTF-8 <--> EUC_KR, JOHAB, UHC mappings.
Tatsuo Ishii [Sun, 3 May 2009 01:17:41 +0000 (01:17 +0000)]
Update UTF-8 <--> EUC_KR, JOHAB, UHC mappings.
Patch contributed by Chuck McDevitt

15 years agoInstall some simple defenses in postmaster startup to help ensure a useful
Tom Lane [Sat, 2 May 2009 22:02:37 +0000 (22:02 +0000)]
Install some simple defenses in postmaster startup to help ensure a useful
error message if the installation directory layout is messed up (or at least,
something more useful than the behavior exhibited in bug #4787).  During
postmaster startup, check that get_pkglib_path resolves as a readable
directory; and if ParseTzFile() fails to open the expected timezone
abbreviation file, check the possibility that the directory is missing rather
than just the specified file.  In case of either failure, issue a hint
suggesting that the installation is broken.  These two checks cover the lib/
and share/ trees of a full installation, which should take care of most
scenarios where a sysadmin decides to get cute.

15 years agoWe don't need major_release_split any more.
Tom Lane [Sat, 2 May 2009 20:28:17 +0000 (20:28 +0000)]
We don't need major_release_split any more.

15 years agoSplit the release notes into a separate file for each (active) major branch,
Tom Lane [Sat, 2 May 2009 20:17:19 +0000 (20:17 +0000)]
Split the release notes into a separate file for each (active) major branch,
as per my recent proposal.  release.sgml itself is now just a stub that should
change rarely; ideally, only once per major release to add a new include line.
Most editing work will occur in the release-N.N.sgml files.  To update a back
branch for a minor release, just copy the appropriate release-N.N.sgml
file(s) into the back branch.

This commit doesn't change the end-product documentation at all, only the
source layout.  However, it makes it easy to start omitting ancient information
from newer branches' documentation, should we ever decide to do that.

15 years agoFix plpgsql's EXIT so that an EXIT without a label only matches a loop,
Tom Lane [Sat, 2 May 2009 17:27:57 +0000 (17:27 +0000)]
Fix plpgsql's EXIT so that an EXIT without a label only matches a loop,
never a BEGIN block.  This is required for Oracle compatibility and is
also plainly stated to be the behavior by our original documentation
(up until 8.1, in which the docs were adjusted to match the code's behavior;
but actually the old docs said the correct thing and the code was wrong).

Not back-patched because this introduces an incompatibility that could
break working applications.  Requires release note.

15 years agoFix a couple of cases where the plpgsql grammar looked for T_WORD and
Tom Lane [Fri, 1 May 2009 23:57:34 +0000 (23:57 +0000)]
Fix a couple of cases where the plpgsql grammar looked for T_WORD and
failed to consider the possibility that it would get T_SCALAR, T_RECORD,
or T_ROW instead because the word happens to match a plpgsql variable name.
In particular, give "duplicate declaration" rather than generic "syntax error"
if the same identifier is declared twice in the same block, as per my recent
complaint.  Also behave more sanely when decl_aliasitem or proc_condition or
opt_lblname is coincidentally not T_WORD.  Refactor the related productions a
bit to reduce duplication.

This is a longstanding bug, but it doesn't seem critical enough to
back-patch.

15 years agoWhen checking for datetime field overflow, we should allow a fractional-second
Tom Lane [Fri, 1 May 2009 19:29:07 +0000 (19:29 +0000)]
When checking for datetime field overflow, we should allow a fractional-second
part that rounds up to exactly 1.0 second.  The previous coding rejected input
like "00:12:57.9999999999999999999999999999", with the exact number of nines
needed to cause failure varying depending on float-timestamp option and
possibly on platform.  Obviously this should round up to the next integral
second, if we don't have enough precision to distinguish the value from that.
Per bug #4789 from Robert Kruus.

In passing, fix a missed check for fractional seconds in one copy of the
"is it greater than 24:00:00" code.

Broken all the way back, so patch all the way back.

15 years agoClean up check_keywords.pl script, making it 'strict' and removing a few
Heikki Linnakangas [Thu, 30 Apr 2009 10:26:35 +0000 (10:26 +0000)]
Clean up check_keywords.pl script, making it 'strict' and removing a few
leftover unused variables.

Laurent Laborde

15 years agoAdd check_keyword.pl script to perform some basic sanity checks to the
Heikki Linnakangas [Wed, 29 Apr 2009 05:05:57 +0000 (05:05 +0000)]
Add check_keyword.pl script to perform some basic sanity checks to the
keyword lists in gram.y and kwlist.h. It checks that all lists are in
alphabetical order, and that all keywords present in gram.y are listed
in kwlist.h in the right category, and that all keywords in kwlist.h are
also in gram.y. What's still missing is to check that all keywords
defined  with "%token <keyword>" in gram.y are present in one of the
keyword lists in gram.y.

15 years agoImprove pull_up_subqueries logic so that it doesn't insert unnecessary
Tom Lane [Tue, 28 Apr 2009 21:31:16 +0000 (21:31 +0000)]
Improve pull_up_subqueries logic so that it doesn't insert unnecessary
PlaceHolderVar nodes in join quals appearing in or below the lowest
outer join that could null the subquery being pulled up.  This improves
the planner's ability to recognize constant join quals, and probably
helps with detection of common sort keys (equivalence classes) as well.

15 years agoBlank line Makefile cleanups.
Bruce Momjian [Tue, 28 Apr 2009 17:07:50 +0000 (17:07 +0000)]
Blank line Makefile cleanups.

15 years agoMove SERVER to the right place in the alphabetically sorted keyword list.
Heikki Linnakangas [Tue, 28 Apr 2009 09:09:41 +0000 (09:09 +0000)]
Move SERVER to the right place in the alphabetically sorted keyword list.

15 years agoIn VACUUM, FREEZE must be before ANALYZE; fix this in vacuumdb. Docs
Bruce Momjian [Tue, 28 Apr 2009 02:37:09 +0000 (02:37 +0000)]
In VACUUM, FREEZE must be before ANALYZE;  fix this in vacuumdb.  Docs
are already correct.

15 years agoProofreading adjustments for first two parts of documentation (Tutorial
Bruce Momjian [Mon, 27 Apr 2009 16:27:36 +0000 (16:27 +0000)]
Proofreading adjustments for first two parts of documentation (Tutorial
and SQL).

15 years agoSome more work on the 8.4 release notes. Document a few changes that Bruce
Tom Lane [Sun, 26 Apr 2009 20:08:30 +0000 (20:08 +0000)]
Some more work on the 8.4 release notes.  Document a few changes that Bruce
apparently found uninteresting, and do minor wordsmithing on a number of
the existing entries.

15 years agoRemove Windows-specific definition of S_ISDIR(). This should not be here;
Tom Lane [Sun, 26 Apr 2009 15:31:50 +0000 (15:31 +0000)]
Remove Windows-specific definition of S_ISDIR().  This should not be here;
if there are any Windows configurations where port/win32.h fails to
provide the macro, it should be fixed in the latter file not here.

15 years agoTypo fix.
Tom Lane [Sun, 26 Apr 2009 02:56:52 +0000 (02:56 +0000)]
Typo fix.

15 years agoUpdate citext expected output to exactly match the real output, rather
Tom Lane [Sun, 26 Apr 2009 02:47:05 +0000 (02:47 +0000)]
Update citext expected output to exactly match the real output, rather
than having some whitespace discrepancy.  Although whitespace is supposed
to be ignored in our regression tests, for some reason buildfarm member
spoonbill doesn't like it.

15 years agoFix the handling of sub-SELECTs appearing in the arguments of an outer-level
Tom Lane [Sat, 25 Apr 2009 16:44:56 +0000 (16:44 +0000)]
Fix the handling of sub-SELECTs appearing in the arguments of an outer-level
aggregate function.  By definition, such a sub-SELECT cannot reference any
variables of query levels between itself and the aggregate's semantic level
(else the aggregate would've been assigned to that lower level instead).
So the correct, most efficient implementation is to treat the sub-SELECT as
being a sub-select of that outer query level, not the level the aggregate
syntactically appears in.  Not doing so also confuses the heck out of our
parameter-passing logic, as illustrated in bug report from Daniel Grace.

Fortunately, we were already copying the whole Aggref expression up to the
outer query level, so all that's needed is to delay SS_process_sublinks
processing of the sub-SELECT until control returns to the outer level.

This has been broken since we introduced spec-compliant treatment of
outer aggregates in 7.4; so patch all the way back.

15 years agoImprove server spoofing wording, per request from Magnus.
Bruce Momjian [Fri, 24 Apr 2009 20:46:16 +0000 (20:46 +0000)]
Improve server spoofing wording, per request from Magnus.

15 years agoFix some more 'variable may be used uninitialized' warnings from gcc 4.4.
Tom Lane [Fri, 24 Apr 2009 16:09:50 +0000 (16:09 +0000)]
Fix some more 'variable may be used uninitialized' warnings from gcc 4.4.

15 years agoMore clearly document what the different sslmode options mean, both the new
Magnus Hagander [Fri, 24 Apr 2009 14:10:41 +0000 (14:10 +0000)]
More clearly document what the different sslmode options mean, both the new
and the old ones.

Consistently talk about certificate verification, and not validation.

15 years agoRemove sslverify parameter from release notes, mention that sslmode is
Magnus Hagander [Fri, 24 Apr 2009 13:01:30 +0000 (13:01 +0000)]
Remove sslverify parameter from release notes, mention that sslmode is
used instead.

15 years agoRemove sslverify parameter again, replacing it with two new sslmode values:
Magnus Hagander [Fri, 24 Apr 2009 09:43:10 +0000 (09:43 +0000)]
Remove sslverify parameter again, replacing it with two new sslmode values:
"verify-ca" and "verify-full".

Since "prefer" remains the default, this will make certificate validation
off by default, which should lead to less upgrade issues.

15 years agoMove gettext encoding names into encnames.c, so we only have one place to update.
Magnus Hagander [Fri, 24 Apr 2009 08:43:51 +0000 (08:43 +0000)]
Move gettext encoding names into encnames.c, so we only have one place to update.

Per discussion.

15 years agoSuppress some 'variable may be used uninitialized' warnings from gcc 4.4.
Tom Lane [Thu, 23 Apr 2009 23:25:13 +0000 (23:25 +0000)]
Suppress some 'variable may be used uninitialized' warnings from gcc 4.4.

15 years agoDon't use the result of strcmp as if it were a boolean.
Tom Lane [Thu, 23 Apr 2009 17:39:21 +0000 (17:39 +0000)]
Don't use the result of strcmp as if it were a boolean.
A service of your local coding style police.

15 years agoMention that tables have a visibility map fork alongside the main fork
Heikki Linnakangas [Thu, 23 Apr 2009 10:20:27 +0000 (10:20 +0000)]
Mention that tables have a visibility map fork alongside the main fork
and FSM.

15 years agoImprove the documentation on 8.4 visibility map related VACUUM changes.
Heikki Linnakangas [Thu, 23 Apr 2009 10:09:11 +0000 (10:09 +0000)]
Improve the documentation on 8.4 visibility map related VACUUM changes.
Explain how vacuum_freeze_table_age should be tuned, and how it relates
to the other settings. Mention that vacuum_freeze_table_age also affects
when autovacuum scans the whole table.

15 years agovarstr_cmp and any comparison function that piggybacks on it can return
Heikki Linnakangas [Thu, 23 Apr 2009 07:19:09 +0000 (07:19 +0000)]
varstr_cmp and any comparison function that piggybacks on it can return
any negative or positive number, not just -1 or 1. Fix comment on
varstr_cmp and citext test case accordingly.

As pointed out by Zdenek Kotala, and buildfarm member gothic moth.

15 years agoChange the default value of max_prepared_transactions to zero, and add
Tom Lane [Thu, 23 Apr 2009 00:23:46 +0000 (00:23 +0000)]
Change the default value of max_prepared_transactions to zero, and add
documentation warnings against setting it nonzero unless active use of
prepared transactions is intended and a suitable transaction manager has been
installed.  This should help to prevent the type of scenario we've seen
several times now where a prepared transaction is forgotten and eventually
causes severe maintenance problems (or even anti-wraparound shutdown).

The only real reason we had the default be nonzero in the first place was to
support regression testing of the feature.  To still be able to do that,
tweak pg_regress to force a nonzero value during "make check".  Since we
cannot force a nonzero value in "make installcheck", add a variant regression
test "expected" file that shows the results that will be obtained when
max_prepared_transactions is zero.

Also, extend the HINT messages for transaction wraparound warnings to mention
the possibility that old prepared transactions are causing the problem.

All per today's discussion.

15 years agoAfter archive recovery, mark the last WAL segment from the parent timeline
Heikki Linnakangas [Wed, 22 Apr 2009 19:51:12 +0000 (19:51 +0000)]
After archive recovery, mark the last WAL segment from the parent timeline
ready for archival. It was marked at the next checkpoint anyway, but
waiting for the next checkpoint is an unnecessary delay.

Fujii Masao

15 years agoUse brackets in psql \df \? help.
Bruce Momjian [Wed, 22 Apr 2009 14:58:48 +0000 (14:58 +0000)]
Use brackets in psql \df \? help.

15 years agoRemove the long-obsolete homebrew dl*() functions for AIX, in favor of just
Tom Lane [Tue, 21 Apr 2009 21:15:50 +0000 (21:15 +0000)]
Remove the long-obsolete homebrew dl*() functions for AIX, in favor of just
using the system functions all the time.  (These files are now just copies
of the osf.* files.)  The homebrew functions were not getting used anyway
on AIX versions that have dlopen(), that is 4.3 and up, so they are not
needed on any AIX that is even remotely supported by the vendor anymore.
We'd have probably left them here anyway, except some questions were
raised about the copyright.

15 years agoFix obsolete cross-reference (this file isn't called alpha.c anymore)
Tom Lane [Tue, 21 Apr 2009 21:05:25 +0000 (21:05 +0000)]
Fix obsolete cross-reference (this file isn't called alpha.c anymore)

15 years agoImprove psql \df error handling.
Bruce Momjian [Tue, 21 Apr 2009 17:28:01 +0000 (17:28 +0000)]
Improve psql \df error handling.

David Fetter

15 years agoMerge psql \df options into a single \? line, and update docs.
Bruce Momjian [Tue, 21 Apr 2009 17:23:05 +0000 (17:23 +0000)]
Merge psql \df options into a single \? line, and update docs.

15 years agoAdd agg/normal/trigger/window flags for psql \df and in \df output.
Bruce Momjian [Tue, 21 Apr 2009 15:49:06 +0000 (15:49 +0000)]
Add agg/normal/trigger/window flags for psql \df and in \df output.

David Fetter

15 years agoRead nls.nk files to determine the proper name of NLS catalogs to install.
Magnus Hagander [Mon, 20 Apr 2009 08:38:00 +0000 (08:38 +0000)]
Read nls.nk files to determine the proper name of NLS catalogs to install.

Hiroshi Inoue, with minor modifications by me

15 years agoAssorted portability fixes for Borland C, from Pavel Golub.
Tom Lane [Sun, 19 Apr 2009 22:37:13 +0000 (22:37 +0000)]
Assorted portability fixes for Borland C, from Pavel Golub.

15 years agoRethink the idea of having plpgsql depend on parser/gram.h. Aside from the
Tom Lane [Sun, 19 Apr 2009 21:50:09 +0000 (21:50 +0000)]
Rethink the idea of having plpgsql depend on parser/gram.h.  Aside from the
fact that this is breaking the MSVC build, it's probably not really a good
idea to expand the dependencies of gram.h any further than the core parser;
for instance the value of SCONST might depend on which bison version you'd
built with.  Better to expose an additional call point in parser.c, so
move what I had put into pl_funcs.c into parser.c.  Also PGDLLIMPORT'ify
the reference to standard_conforming_strings, per buildfarm results.

15 years agoFix de-escaping checks so that we will reject \000 as well as other invalidly
Tom Lane [Sun, 19 Apr 2009 21:08:54 +0000 (21:08 +0000)]
Fix de-escaping checks so that we will reject \000 as well as other invalidly
encoded sequences.  Per discussion of a couple of days ago.

15 years agoFix textsearch documentation examples to not recommend concatenating separate
Tom Lane [Sun, 19 Apr 2009 20:36:06 +0000 (20:36 +0000)]
Fix textsearch documentation examples to not recommend concatenating separate
fields without putting a space between.  Per gripe from Rick Schumeyer.

15 years agoFix estimate_num_groups() to not fail on PlaceHolderVars, per report from
Tom Lane [Sun, 19 Apr 2009 19:46:33 +0000 (19:46 +0000)]
Fix estimate_num_groups() to not fail on PlaceHolderVars, per report from
Stefan Kaltenbrunner.  The most reasonable behavior (at least for the near
term) seems to be to ignore the PlaceHolderVar and examine its argument
instead.  In support of this, change the API of pull_var_clause() to allow
callers to request recursion into PlaceHolderVars.  Currently
estimate_num_groups() is the only customer for that behavior, but where
there's one there may be others.

15 years agoRevise plpgsql's scanner to process comments and string literals in a way
Tom Lane [Sun, 19 Apr 2009 18:52:58 +0000 (18:52 +0000)]
Revise plpgsql's scanner to process comments and string literals in a way
more nearly matching the core SQL scanner.  The user-visible effects are:

* Block comments (slash-star comments) now nest, as per SQL spec.

* In standard_conforming_strings mode, backslash as the last character of a
  non-E string literal is now correctly taken as an ordinary character;
  formerly it was misinterpreted as escaping the ending quote.  (Since the
  string also had to pass through the core scanner, this invariably led
  to syntax errors.)

* Formerly, backslashes in the format string of RAISE were always treated as
  quoting the next character, regardless of mode.  Now, they are ordinary
  characters with standard_conforming_strings on, while with it off, they
  introduce the same set of escapes as in the core SQL scanner.  Also,
  escape_string_warning is now effective for RAISE format strings.  These
  changes make RAISE format strings work just like any other string literal.

This is implemented by copying and pasting a lot of logic from the core
scanner.  It would be a good idea to look into getting rid of plpgsql's
scanner entirely in favor of using the core scanner.  However, that involves
more change than I can justify making during beta --- in particular, the core
scanner would have to become re-entrant.

In passing, remove the kluge that made the plpgsql scanner emit T_FUNCTION or
T_TRIGGER as a made-up first token.  That presumably had some value once upon
a time, but now it's just useless complication for both the scanner and the
grammar.

15 years agoMention as a potential incompatibility the fact that SELECT DISTINCT, UNION,
Tom Lane [Sun, 19 Apr 2009 15:49:34 +0000 (15:49 +0000)]
Mention as a potential incompatibility the fact that SELECT DISTINCT, UNION,
etc are no longer guaranteed to produce sorted output; per gripe from Ian
Barwick.  Also improve the release note entries about to_timestamp(), per
Brendan Jurd.

15 years agoAdd Ron Mayer as primary contributor for:
Bruce Momjian [Sat, 18 Apr 2009 00:01:01 +0000 (00:01 +0000)]
Add Ron Mayer as primary contributor for:

      Support the <acronym>IS0 8601</> <type>interval</> syntax

based on private email from Ron.

15 years agoBump disable_cost up from 1e8 to 1e10, per gripe from Kris Jurka.
Tom Lane [Fri, 17 Apr 2009 15:33:33 +0000 (15:33 +0000)]
Bump disable_cost up from 1e8 to 1e10, per gripe from Kris Jurka.

15 years agoFix planner to restore its previous level of intelligence about pushing
Tom Lane [Thu, 16 Apr 2009 20:42:16 +0000 (20:42 +0000)]
Fix planner to restore its previous level of intelligence about pushing
constants through full joins, as in

select * from tenk1 a full join tenk1 b using (unique1)
where unique1 = 42;

which should generate a fairly cheap plan where we apply the constraint
unique1 = 42 in each relation scan.  This had been broken by my patch of
2008-06-27, which is now reverted in favor of a more invasive but hopefully
less incorrect approach.  That patch was meant to prevent incorrect extraction
of OR'd indexclauses from OR conditions above an outer join.  To do that
correctly we need more information than the outerjoin_delay flag can provide,
so add a nullable_relids field to RestrictInfo that records exactly which
relations are nulled by outer joins that are underneath a particular qual
clause.  A side benefit is that we can make the test in create_or_index_quals
more specific: it is now smart enough to extract an OR'd indexclause into the
outer side of an outer join, even though it must not do so in the inner side.
The old coding couldn't distinguish these cases so it could not do either.

15 years agoFix the regression test error message for array_fill, too.
Alvaro Herrera [Thu, 16 Apr 2009 14:43:39 +0000 (14:43 +0000)]
Fix the regression test error message for array_fill, too.
Per note from Andrew Dunstan.

15 years agoSubstitute extraneous underscores with spaces.
Alvaro Herrera [Wed, 15 Apr 2009 23:30:33 +0000 (23:30 +0000)]
Substitute extraneous underscores with spaces.

15 years agoRemove mention of pre-7.1 inheritance behavior from /ref pages; keep
Bruce Momjian [Wed, 15 Apr 2009 22:42:50 +0000 (22:42 +0000)]
Remove mention of pre-7.1 inheritance behavior from /ref pages;  keep
mentions in main documentation.

15 years agoAdd missing gettext calls around some strings. Also remove quotes around the
Alvaro Herrera [Wed, 15 Apr 2009 21:42:50 +0000 (21:42 +0000)]
Add missing gettext calls around some strings.  Also remove quotes around the
%s that they expand to, per comment from Tom.

15 years agoAdd missing periods.
Alvaro Herrera [Wed, 15 Apr 2009 21:36:12 +0000 (21:36 +0000)]
Add missing periods.

15 years agoRemove beer-ware license from crypt-md5.c, per
Magnus Hagander [Wed, 15 Apr 2009 18:58:24 +0000 (18:58 +0000)]
Remove beer-ware license from crypt-md5.c, per
approval from Poul-Henning Kamp.

This makes the file the same standard 2-clause BSD as the
rest of PostgreSQL.

15 years agoFix SGML markup I broke yesterday.
Bruce Momjian [Wed, 15 Apr 2009 13:03:11 +0000 (13:03 +0000)]
Fix SGML markup I broke yesterday.

15 years agoFix broken {xufailed} production that made HEAD fail on
Tom Lane [Tue, 14 Apr 2009 22:18:47 +0000 (22:18 +0000)]
Fix broken {xufailed} production that made HEAD fail on
select u&42 from table-with-a-u-column;
Also fix missing SET_YYLLOC() in the {dolqfailed} production that I suppose
this was based on.  The latter is a pre-existing bug, but the only effect
is to misplace the error cursor by one token, so probably not worth
backpatching.

15 years agoReformat 'sslmode' options into an SGML table; improve wording.
Bruce Momjian [Tue, 14 Apr 2009 20:42:48 +0000 (20:42 +0000)]
Reformat 'sslmode' options into an SGML table;  improve wording.

15 years agoAdd libpq error message text on how to handle missing root.crt file.
Bruce Momjian [Tue, 14 Apr 2009 17:30:16 +0000 (17:30 +0000)]
Add libpq error message text on how to handle missing root.crt file.

15 years agoDo some copy-editing on description of ts_headline().
Tom Lane [Tue, 14 Apr 2009 00:49:56 +0000 (00:49 +0000)]
Do some copy-editing on description of ts_headline().

15 years agopg_restore -jN does not equate "multiple jobs", so partly revert the
Alvaro Herrera [Tue, 14 Apr 2009 00:06:35 +0000 (00:06 +0000)]
pg_restore -jN does not equate "multiple jobs", so partly revert the
previous patch.

Per note from Tom.

15 years agoMake new strings more alike previously existing messages.
Alvaro Herrera [Mon, 13 Apr 2009 21:03:36 +0000 (21:03 +0000)]
Make new strings more alike previously existing messages.

15 years agoMake a copy-editing pass over the 8.4 release notes.
Tom Lane [Mon, 13 Apr 2009 06:05:12 +0000 (06:05 +0000)]
Make a copy-editing pass over the 8.4 release notes.

15 years agoFix logic to detect conflicts or blocks involving exclusive locks in parallel restore...
Andrew Dunstan [Sun, 12 Apr 2009 21:02:44 +0000 (21:02 +0000)]
Fix logic to detect conflicts or blocks involving exclusive locks in parallel restore items.
If a currently running item needs an exclusive lock on any item that the candidate items needs
any sort of lock on, or vice versa, then the candidate item is not allowed to run now, and
must wait till later.

15 years agoFix pg_dumpall so that when --clean is specified, it drops roles and
Tom Lane [Sat, 11 Apr 2009 20:23:05 +0000 (20:23 +0000)]
Fix pg_dumpall so that when --clean is specified, it drops roles and
tablespaces in an order that has some chance of working.
Per a complaint from Kevin Bailey.

This is a pre-existing bug, but given the lack of prior complaints I'm
not sure it's worth back-patching.  In most cases failure of the DROP
commands wouldn't be that important anyway.

In passing, fix syntax errors in dumpCreateDB()'s queries for old servers;
these were apparently introduced in recent binary_upgrade patch.

15 years agoMake string more alike other similar messages.
Alvaro Herrera [Sat, 11 Apr 2009 18:38:54 +0000 (18:38 +0000)]
Make string more alike other similar messages.

15 years agoMore wording clarification of sslverify setting.
Bruce Momjian [Sat, 11 Apr 2009 16:46:54 +0000 (16:46 +0000)]
More wording clarification of sslverify setting.

15 years agoMessage fix
Peter Eisentraut [Sat, 11 Apr 2009 14:11:45 +0000 (14:11 +0000)]
Message fix
(I guess this was a cruise replace mistake.)

15 years agoMessage improvement
Peter Eisentraut [Sat, 11 Apr 2009 14:11:21 +0000 (14:11 +0000)]
Message improvement

15 years agoBetter document libpq sslverify behavior as requiring root.crt.
Bruce Momjian [Sat, 11 Apr 2009 12:27:53 +0000 (12:27 +0000)]
Better document libpq sslverify behavior as requiring root.crt.

15 years agoWording improvement.
Bruce Momjian [Sat, 11 Apr 2009 02:08:34 +0000 (02:08 +0000)]
Wording improvement.

15 years agoWording improvement for SSL user certificate authentication.
Bruce Momjian [Sat, 11 Apr 2009 02:07:25 +0000 (02:07 +0000)]
Wording improvement for SSL user certificate authentication.

15 years agoClarify SSL _user_ authentication in release notes.
Bruce Momjian [Sat, 11 Apr 2009 02:06:16 +0000 (02:06 +0000)]
Clarify SSL _user_ authentication in release notes.

15 years agoAdd cross-references from the DECLARE and FETCH reference pages to
Tom Lane [Fri, 10 Apr 2009 17:56:21 +0000 (17:56 +0000)]
Add cross-references from the DECLARE and FETCH reference pages to
the plpgsql documentation about cursors.  Per a suggestion from
Matthew Wakeling.

15 years agoDocument how *_blks_read statistics columns are computed.
Bruce Momjian [Fri, 10 Apr 2009 03:13:36 +0000 (03:13 +0000)]
Document how *_blks_read statistics columns are computed.

15 years agocommit and tag beta1 REL8_4_BETA1
Marc G. Fournier [Fri, 10 Apr 2009 00:20:10 +0000 (00:20 +0000)]
commit and tag beta1

15 years agoUpdate release notes through yesterday; some minor wordsmithing.
Tom Lane [Thu, 9 Apr 2009 23:22:49 +0000 (23:22 +0000)]
Update release notes through yesterday; some minor wordsmithing.

15 years agoClarify documentation references to pg_stat_get_blocks_fetched and
Bruce Momjian [Thu, 9 Apr 2009 22:32:02 +0000 (22:32 +0000)]
Clarify documentation references to pg_stat_get_blocks_fetched and
pg_stat_get_blocks_hit, per suggestion from Robert Haas.

15 years agoNo more need to update FAQs.
Bruce Momjian [Thu, 9 Apr 2009 21:50:31 +0000 (21:50 +0000)]
No more need to update FAQs.

15 years agoAdd URL for config.guess/sub updates
Peter Eisentraut [Thu, 9 Apr 2009 21:35:33 +0000 (21:35 +0000)]
Add URL for config.guess/sub updates

15 years agoUpdate config.guess and config.sub
Peter Eisentraut [Thu, 9 Apr 2009 21:33:02 +0000 (21:33 +0000)]
Update config.guess and config.sub

15 years agoUpdate time zone data files to tzdata release 2009e: DST law changes in
Tom Lane [Thu, 9 Apr 2009 20:50:42 +0000 (20:50 +0000)]
Update time zone data files to tzdata release 2009e: DST law changes in
Argentina/San_Luis, Cuba, Jordan (historical correction only), Morocco,
Palestine, Syria, Tunisia.

15 years agoTranslation updates for 8.4 beta
Peter Eisentraut [Thu, 9 Apr 2009 19:38:53 +0000 (19:38 +0000)]
Translation updates for 8.4 beta

15 years agoUpdate GIN limitations documentation to match current reality.
Tom Lane [Thu, 9 Apr 2009 19:07:44 +0000 (19:07 +0000)]
Update GIN limitations documentation to match current reality.

15 years agoRemove SQL-compatibility function cardinality(). It is not exactly clear
Tom Lane [Thu, 9 Apr 2009 17:39:50 +0000 (17:39 +0000)]
Remove SQL-compatibility function cardinality().  It is not exactly clear
how this ought to behave for multi-dimensional arrays.  Per discussion,
not having it at all seems better than having it with what might prove
to be the wrong behavior.  We can always add it later when we have consensus
on the correct behavior.

15 years agoImprove documentation about how checkpoint spreads I/O activity.
Bruce Momjian [Thu, 9 Apr 2009 16:20:50 +0000 (16:20 +0000)]
Improve documentation about how checkpoint spreads I/O activity.

15 years agoTreat EOF like \n for line-counting purposes in ParseConfigFile,
Tom Lane [Thu, 9 Apr 2009 14:21:02 +0000 (14:21 +0000)]
Treat EOF like \n for line-counting purposes in ParseConfigFile,
per bug #4752.  Fujii Masao

15 years agoFix the plpgsql memory leak exhibited in bug #4677. That leak was introduced
Tom Lane [Thu, 9 Apr 2009 02:57:53 +0000 (02:57 +0000)]
Fix the plpgsql memory leak exhibited in bug #4677.  That leak was introduced
by my patch of 2007-01-28 to use per-subtransaction ExprContexts/EStates:
since we re-prepared any expression tree when the current subtransaction ID
changed, we'd accumulate more and more leaked expression state trees in the
outermost subtransaction if the same function was executed at multiple levels
of subtransaction nesting.  To fix, go back to the previous scheme where
there was only one EState per transaction for simple plpgsql expressions.
We really only need an ExprContext per subtransaction, not a whole EState,
so it's possible to keep prepared expression state trees in the one EState
throughout the transaction.  This should be more efficient as well as not
leaking memory for cases involving lots of subtransactions.

The added regression test is the case that inspired the 2007-01-28 patch in
the first place, just to make sure we didn't go backwards.  The current
memory leak complaint is unfortunately hard to test for in the regression
test framework, though manual testing shows it's fixed.

Although this is a pre-existing bug, I'm not back-patching because I'd like to
see this method get some field testing first.  Consider back-patching if it
gets through 8.4beta unscathed.

15 years agoRemove psql's ancient hack that suppressed functions taking or returning
Tom Lane [Wed, 8 Apr 2009 22:29:30 +0000 (22:29 +0000)]
Remove psql's ancient hack that suppressed functions taking or returning
cstring from the output of \df.  Now that the default behavior is to
exclude all system functions, the de-cluttering rationale for this behavior
seems pretty weak; and it was always quite confusing/unhelpful if you were
actually looking for I/O functions.  (Not to mention if you were looking
for encoding converters or other cases that might take or return cstring.)

15 years agoAllow leading and trailing spaces around NaN in numeric_in.
Tom Lane [Wed, 8 Apr 2009 22:08:40 +0000 (22:08 +0000)]
Allow leading and trailing spaces around NaN in numeric_in.

Sam Mason, rewritten a bit by Tom.

15 years agoXMLATTRIBUTES() should send the attribute values through
Peter Eisentraut [Wed, 8 Apr 2009 21:51:38 +0000 (21:51 +0000)]
XMLATTRIBUTES() should send the attribute values through
map_sql_value_to_xml_value() instead of directly through the data type output
function.  This is per SQL standard, and consistent with XMLELEMENT().

15 years agoQuote string literals correctly in the new CREATE SERVER statements
Heikki Linnakangas [Wed, 8 Apr 2009 19:02:37 +0000 (19:02 +0000)]
Quote string literals correctly in the new CREATE SERVER statements
and binary upgrade UPDATE statements.

15 years agoOops, mustn't call textdomain() when compiling without --enable-nls
Heikki Linnakangas [Wed, 8 Apr 2009 13:08:09 +0000 (13:08 +0000)]
Oops, mustn't call textdomain() when compiling without --enable-nls

15 years agoTell gettext which codeset to use by calling bind_textdomain_codeset(). We
Heikki Linnakangas [Wed, 8 Apr 2009 09:50:48 +0000 (09:50 +0000)]
Tell gettext which codeset to use by calling bind_textdomain_codeset(). We
already did that on Windows, but it's needed on other platforms too when
LC_CTYPE=C. With other locales, we enforce (or trust) that the codeset of
the locale matches the server encoding so we don't need to bind it
explicitly. It should do no harm in that case either, but I don't have
full faith in the PG encoding -> OS codeset mapping table yet. Per recent
discussion on pgsql-hackers.

15 years agoImprove tab completion for \ef.
Bruce Momjian [Wed, 8 Apr 2009 04:05:16 +0000 (04:05 +0000)]
Improve tab completion for \ef.

Andrew Gierth

15 years agoRevert addition of units to GUC descriptions; doesn't affect
Bruce Momjian [Tue, 7 Apr 2009 23:27:34 +0000 (23:27 +0000)]
Revert addition of units to GUC descriptions;  doesn't affect
postgresql.conf.

15 years agoDisable effective_io_concurrency on Solaris because posix_fadvise() is
Bruce Momjian [Tue, 7 Apr 2009 22:48:30 +0000 (22:48 +0000)]
Disable effective_io_concurrency on Solaris because posix_fadvise() is
no-op on that platform.

15 years agoMore GUC units doc updates.
Bruce Momjian [Tue, 7 Apr 2009 22:22:19 +0000 (22:22 +0000)]
More GUC units doc updates.

Euler Taveira de Oliveira

15 years agoAdd attribution for:
Bruce Momjian [Tue, 7 Apr 2009 21:30:01 +0000 (21:30 +0000)]
Add attribution for:

       Add Japanese message translations (Japan PostgreSQL Users Group)

15 years agoAdd release note item:
Bruce Momjian [Tue, 7 Apr 2009 21:29:02 +0000 (21:29 +0000)]
Add release note item:

       Add Japanese message translations