Tom Lane [Sat, 15 Nov 2003 17:24:07 +0000 (17:24 +0000)]
Make creation of statistics collection socket more robust, by allowing it
to try additional addresses returned from getaddrinfo() if the first one
fails at the bind() or connect() steps. Per yesterday's discussion.
Tom Lane [Fri, 14 Nov 2003 22:56:11 +0000 (22:56 +0000)]
Repair error in syntax documentation for CREATE TABLE: one does not put
a comma between multiple column_constraint's for a single column.
Per report from Tomislaw Kitynski.
Tom Lane [Fri, 14 Nov 2003 17:19:35 +0000 (17:19 +0000)]
Add missing logic to handle fixing permissions on an already-existing
data directory. Also fix handling of error conditions associated with
data directory checking step (can't use a boolean to distinguish four
possible result states...)
Tom Lane [Fri, 14 Nov 2003 15:43:22 +0000 (15:43 +0000)]
Fix misstatement about the required value of SEMVMX. Given our current
usage of PGSemaMagic, the minimum required value is actually 537, but
say 1000 just to use a round number. 255 is *not* good enough.
Jan Wieck [Fri, 14 Nov 2003 04:32:11 +0000 (04:32 +0000)]
Added documentation for the new interface between the buffer manager
and the cache replacement strategy as well as a description of the
ARC algorithm and the special tailoring of that done for PostgreSQL.
Tom Lane [Thu, 13 Nov 2003 23:46:31 +0000 (23:46 +0000)]
Preliminary code review for C version of initdb. Re-centralize handling
of option switches for backend, fix handling of COPY from data files so
that we won't have the newline-after-\. issue back again, add back some
comments and printouts lost from the shell script, etc. Still needs work
for error handling; in particular the shell version worked much more
nicely for the case of a postgres executable that fails on invocation.
Tom Lane [Wed, 12 Nov 2003 22:53:16 +0000 (22:53 +0000)]
AcceptResult() was missing a case for PGRES_EMPTY_QUERY --- probably
my fault. Adding it fixes bogus message display when reading a block
comment at the end of a script file.
Tom Lane [Wed, 12 Nov 2003 21:15:59 +0000 (21:15 +0000)]
Cross-data-type comparisons are now indexable by btrees, pursuant to my
pghackers proposal of 8-Nov. All the existing cross-type comparison
operators (int2/int4/int8 and float4/float8) have appropriate support.
The original proposal of storing the right-hand-side datatype as part of
the primary key for pg_amop and pg_amproc got modified a bit in the event;
it is easier to store zero as the 'default' case and only store a nonzero
when the operator is actually cross-type. Along the way, remove the
long-since-defunct bigbox_ops operator class.
Tom Lane [Sun, 9 Nov 2003 21:30:38 +0000 (21:30 +0000)]
Add operator strategy and comparison-value datatype fields to ScanKey.
Remove the 'strategy map' code, which was a large amount of mechanism
that no longer had any use except reverse-mapping from procedure OID to
strategy number. Passing the strategy number to the index AM in the
first place is simpler and faster.
This is a preliminary step in planned support for cross-datatype index
operations. I'm committing it now since the ScanKeyEntryInitialize()
API change touches quite a lot of files, and I want to commit those
changes before the tree drifts under me.
Bruce Momjian [Sun, 9 Nov 2003 03:47:51 +0000 (03:47 +0000)]
I have attached a more comprehensive MSWIN FAQ patch. Basically, the
instructions were way out of date and incorrect. Installing Postgres
from Cygwin is easier these days than the FAQ would imply.
This patch already includes Andrew's previous patch.
Tom Lane [Fri, 7 Nov 2003 21:55:50 +0000 (21:55 +0000)]
Cause stats processes to detach from shared memory when started, so that
they do not prevent the postmaster from deleting the shmem segment during
a post-backend-crash restart cycle. Per recent discussion.
Tom Lane [Fri, 7 Nov 2003 21:27:38 +0000 (21:27 +0000)]
zero_damaged_pages must absolutely NOT be marked GUC_DISALLOW_IN_FILE,
else it cannot be used to handle failures detected during WAL replay.
Fortunately this flag isn't actually enforced yet, but get it right.
Bruce Momjian [Fri, 7 Nov 2003 15:31:14 +0000 (15:31 +0000)]
Add:
> * Allow CREATE TABLE foo (f1 INT CHECK (f1 > 0) CHECK (f1 < 10)) to work
> by searching for non-conflicting constraint names, and prefix with table name
Tom Lane [Wed, 5 Nov 2003 22:00:46 +0000 (22:00 +0000)]
Fix for this problem:
regression=# select 1 from tenk1 ta cross join tenk1 tb for update;
ERROR: no relation entry for relid 3
7.3 said "SELECT FOR UPDATE cannot be applied to a join", which was better
but still wrong, considering that 7.2 took the query just fine. Fix by
making transformForUpdate() ignore JOIN and other special RTE types,
rather than trying to mark them FOR UPDATE. The actual error message now
only appears if you explicitly name the join in FOR UPDATE.
Tom Lane [Sun, 2 Nov 2003 21:56:15 +0000 (21:56 +0000)]
Provide a way to run the parallel regression tests with a user-specified
limit on the number of simultaneous connections. Andrew Dunstan, with
review by Tom Lane.