Thomas Roessler [Wed, 8 Oct 2003 19:55:39 +0000 (19:55 +0000)]
KeyTable is pgp_uid_t **, not pgp_key_t *. Fix some sizeof
statements accordingly. Note that pgp_key_t is also a pointer,
though, so this should not have broken things.
As the ones of you who compile with new gcc's probably have noticed,
there's a lot of type-punning in Mutt. With help from Philipp
Thomas, I've fixed all I could find in CVS (please double-check, one
might have slipped through the cracks), I can make one for 1.4 CVS
branch as well if wanted.
Jon Miles [Wed, 10 Sep 2003 13:20:49 +0000 (13:20 +0000)]
In pop_auth.c:pop_auth_sasl(), if the main loop received anything
back from the server that didnt begin with '+ ', it was bailing out
and skipping the checks to see if there was a +OK response.
Dan Born [Wed, 3 Sep 2003 17:22:09 +0000 (17:22 +0000)]
I've attached a patch for bug number 1036, as reported at
http://bugs.guug.de/db/pa/lmutt.html ("segfault when more than one
msg is postponed"). This is a patch against mutt 1.4.1.
As it was previously left, no one could reproduce it. The problem
occurs because sorting is disabled when opening the postponed
folder, but the Sort global variable still tells mutt to use
whatever sorting algorithm the $sort config option indicates.
Eventually, the code would get to mutt_messages_in_thread and try to
dereference a NULL thread object, causing the segfault.
The commands "read-thread" (^R) and "read-subthread" (Esc-R) do not
honor the resolve variable (don't advance cursor after marking the
thread/subthread as read), which, to me at least, is a nuisance.
Brendan Cully [Mon, 11 Aug 2003 14:06:08 +0000 (14:06 +0000)]
1595: My guess is this bug is caused by mlarson@verisign.com's patch
to check for UNSEEN rather than RECENT messages. This means that as
long as there are messages in a mailbox either new or old, mutt will
think it has new mail.
The attached patch reverts that change. Let me know if it solves the
problem.
It seems that Solaris has an incorrect implementation of mbrtowc: when
there is an encoding error and mbrtowc returns (size_t)(-1) no value
should be stored in *pwc (the first argument), as I understand it, but
here mbrtowc is storing 8 when presented with the bytes "\xc8\x4d".
However, relying on mbrtowc not to store anything in *pwc when there
is an error is a bit silly; it makes sense to look at the return
value. So, the following patch should be applied if Pawel can confirm
that it fixes the problem. I've tested it and it worked for me with
glibc's mbrtowc.
Vincent Lefevre [Thu, 24 Jul 2003 18:40:50 +0000 (18:40 +0000)]
Some functions/macros like isspace take an int and require the
argument to have the value of an unsigned char (or EOF). Under
Solaris, gcc complains when the argument is a char (as this is a
possible bug, on platforms where char is signed, like Solaris). The
attached patch fixes such problems (well, perhaps I've changed more
than necessary, but this doesn't hurt).
David Shaw [Tue, 22 Jul 2003 12:56:38 +0000 (12:56 +0000)]
When encrypting a message to a user that has more than one subkey,
at least one of which is revoked or expired, mutt treats the entire
key as unusable rather than just the subkey(s) in question.