]> granicus.if.org Git - icinga2/log
icinga2
6 years agoImprove logging for disconnected HTTP clients 6655/head
Michael Friedrich [Tue, 9 Oct 2018 10:22:19 +0000 (12:22 +0200)]
Improve logging for disconnected HTTP clients

Previously this was inside the debug log, with the
new socket printers we can enhance checking for proper
connects and disconnects.

refs #6514

6 years agoMerge pull request #6503 from peteeckel/fix/reduce-loglevel-plugin-env-6460
Michael Friedrich [Mon, 8 Oct 2018 12:09:18 +0000 (14:09 +0200)]
Merge pull request #6503 from peteeckel/fix/reduce-loglevel-plugin-env-6460

Reduce the log level for missing env macros to debug

6 years agoMerge pull request #6652 from Icinga/bugfix/check-memory-used-thresholds
Michael Friedrich [Mon, 8 Oct 2018 11:18:26 +0000 (13:18 +0200)]
Merge pull request #6652 from Icinga/bugfix/check-memory-used-thresholds

Fix check_memory thresholds in 'used' mode

6 years agoMerge pull request #6647 from Icinga/bugfix/node-setup-master-accept-config-commands
Michael Friedrich [Mon, 8 Oct 2018 11:12:02 +0000 (13:12 +0200)]
Merge pull request #6647 from Icinga/bugfix/node-setup-master-accept-config-commands

node setup: always respect --accept-config and --accept-commands

6 years agoFix check_memory thresholds in 'used' mode 6652/head
Michael Insel [Thu, 4 Oct 2018 09:06:27 +0000 (11:06 +0200)]
Fix check_memory thresholds in 'used' mode

The thresholds in the used mode now breaks if the value is bigger than
the threshold.

6 years agonode setup: always respect --accept-config and --accept-commands 6647/head
Alexander A. Klimov [Mon, 1 Oct 2018 14:24:37 +0000 (16:24 +0200)]
node setup: always respect --accept-config and --accept-commands

6 years agoMerge pull request #6643 from Icinga/bugfix/command-timeout-notifications
Michael Friedrich [Fri, 28 Sep 2018 14:21:05 +0000 (16:21 +0200)]
Merge pull request #6643 from Icinga/bugfix/command-timeout-notifications

Fix that check_timeout was used for Event/Notification commands too

6 years agoFix that check_timeout was used for Event/Notification commands too 6643/head
Michael Friedrich [Fri, 28 Sep 2018 12:32:57 +0000 (14:32 +0200)]
Fix that check_timeout was used for Event/Notification commands too

We may add specific timeouts for event/notification commands
later, for now the original timeout inside the EventCommand/NotificationCommand
is used.

fixes #6304

6 years agoMerge pull request #6642 from Icinga/bugfix/concurrent-checks-constant
Michael Friedrich [Fri, 28 Sep 2018 07:34:53 +0000 (09:34 +0200)]
Merge pull request #6642 from Icinga/bugfix/concurrent-checks-constant

Allow to override MaxConcurrentChecks constant

6 years agoMerge pull request #6546 from WuerthPhoenix/fix/define-switches-not-passed-during...
Michael Friedrich [Fri, 28 Sep 2018 07:31:07 +0000 (09:31 +0200)]
Merge pull request #6546 from WuerthPhoenix/fix/define-switches-not-passed-during-config-test

Overridden path constants not passed to config validation in /v1/config/stages API call

6 years agoDon't inherit daemonize parameter from parent process 6546/head
Michael Friedrich [Thu, 27 Sep 2018 18:30:19 +0000 (20:30 +0200)]
Don't inherit daemonize parameter from parent process

6 years agoFix config validation problem (startup.log) during /v1/config/stages API call
Thomas Forrer [Wed, 22 Aug 2018 12:47:57 +0000 (14:47 +0200)]
Fix config validation problem (startup.log) during /v1/config/stages API call

copy all arguments of parent process in AsyncTryActivateStage

6 years agoAllow to override MaxConcurrentChecks constant 6642/head
Michael Friedrich [Thu, 27 Sep 2018 18:23:00 +0000 (20:23 +0200)]
Allow to override MaxConcurrentChecks constant

6 years agoMerge pull request #6313 from Icinga/fix/win-check-swap
Michael Friedrich [Thu, 27 Sep 2018 08:08:47 +0000 (10:08 +0200)]
Merge pull request #6313 from Icinga/fix/win-check-swap

Fix wrong calculation of check_swap windows plugin

6 years agoMerge pull request #6639 from Icinga/fix/windows-api-log-rename
Michael Friedrich [Thu, 27 Sep 2018 06:02:00 +0000 (08:02 +0200)]
Merge pull request #6639 from Icinga/fix/windows-api-log-rename

Ensure to _unlink before renaming replay log on Windows

6 years agoFix issue 5022
Jordi van Scheijen [Thu, 22 Jun 2017 10:31:32 +0000 (12:31 +0200)]
Fix issue 5022

6 years agoMerge branch 'support/2.9'
Michael Friedrich [Wed, 26 Sep 2018 08:47:41 +0000 (10:47 +0200)]
Merge branch 'support/2.9'

6 years agoRelease version 2.9.2
Michael Friedrich [Tue, 25 Sep 2018 15:29:23 +0000 (17:29 +0200)]
Release version 2.9.2

6 years agoRelease version 2.9.2 v2.9.2
Michael Friedrich [Tue, 25 Sep 2018 15:29:23 +0000 (17:29 +0200)]
Release version 2.9.2

6 years agoMerge pull request #6632 from Icinga/feature/cluster-faster-reconnect
Michael Friedrich [Tue, 25 Sep 2018 15:07:01 +0000 (17:07 +0200)]
Merge pull request #6632 from Icinga/feature/cluster-faster-reconnect

Increase the cluster reconnect frequency to 10s

6 years agoMerge pull request #6633 from Icinga/feature/apilistener-conn-thread-pool
Michael Friedrich [Tue, 25 Sep 2018 15:06:40 +0000 (17:06 +0200)]
Merge pull request #6633 from Icinga/feature/apilistener-conn-thread-pool

Use a dynamic thread pool for API connections

6 years agoUse a dynamic thread pool for API connections 6633/head
Michael Friedrich [Mon, 24 Sep 2018 14:38:48 +0000 (16:38 +0200)]
Use a dynamic thread pool for API connections

The full analysis is located in #6517.

fixes #6517

6 years agoIncrease the cluster reconnect frequency to 10s 6632/head
Michael Friedrich [Mon, 24 Sep 2018 15:28:27 +0000 (17:28 +0200)]
Increase the cluster reconnect frequency to 10s

This is blocked by #6517.

refs #6234

6 years agoMerge pull request #6630 from Icinga/bugfix/socket-events-init
Michael Friedrich [Tue, 25 Sep 2018 09:57:35 +0000 (11:57 +0200)]
Merge pull request #6630 from Icinga/bugfix/socket-events-init

Initialize Socket Event Engine on application startup

6 years agoInitialize Socket Event Engine on application startup 6630/head
Michael Friedrich [Mon, 24 Sep 2018 13:50:59 +0000 (15:50 +0200)]
Initialize Socket Event Engine on application startup

Previously this happened inside the TlsStream constructor
during the first connection attempt.

6 years agoUpdate variable names
Jean Flach [Wed, 22 Aug 2018 13:12:47 +0000 (15:12 +0200)]
Update variable names

refs #6568

6 years agoEnsure that config object types are committed in dependent load order
Markus Frosch [Thu, 9 Aug 2018 09:55:20 +0000 (11:55 +0200)]
Ensure that config object types are committed in dependent load order

refs #6568

6 years agoShuffle items before config validation
Jean Flach [Fri, 31 Aug 2018 11:11:50 +0000 (13:11 +0200)]
Shuffle items before config validation

refs #6581

6 years agoFix crash on API queries with Fedora 28 hardening and GCC 8
Michael Friedrich [Wed, 5 Sep 2018 18:42:55 +0000 (20:42 +0200)]
Fix crash on API queries with Fedora 28 hardening and GCC 8

The actual fix is to handle nullptr references differently
for an empty filter expression. The other changes include
oob checks not necesarily involved.

fixes #6533
refs #6596

6 years agoMerge pull request #6622 from Icinga/bugfix/ido-pgsql-cleanup-timestamp-utc
Michael Friedrich [Mon, 17 Sep 2018 09:20:49 +0000 (11:20 +0200)]
Merge pull request #6622 from Icinga/bugfix/ido-pgsql-cleanup-timestamp-utc

Ensure to use UTC timestamps for IDO PgSQL cleanup queries

6 years agoMerge pull request #6616 from Icinga/feature/tls-handshake-timeout-config
Michael Friedrich [Mon, 17 Sep 2018 09:20:12 +0000 (11:20 +0200)]
Merge pull request #6616 from Icinga/feature/tls-handshake-timeout-config

Add ApiListener#tls_handshake_timeout option

6 years agoAdd a note about tls_handshake_timeout to upgrading docs 6616/head
Michael Friedrich [Mon, 17 Sep 2018 09:19:18 +0000 (11:19 +0200)]
Add a note about tls_handshake_timeout to upgrading docs

6 years agoMerge pull request #6621 from Icinga/bugfix/ido-remove-unused-timestamp-function
Michael Friedrich [Mon, 17 Sep 2018 09:16:47 +0000 (11:16 +0200)]
Merge pull request #6621 from Icinga/bugfix/ido-remove-unused-timestamp-function

Remove unused timestamp function in DB IDO

6 years agoMerge pull request #6618 from Icinga/bugfix/nice-compiler-warning
Michael Friedrich [Mon, 17 Sep 2018 09:16:29 +0000 (11:16 +0200)]
Merge pull request #6618 from Icinga/bugfix/nice-compiler-warning

Silence compiler warning for nice()

6 years agoEnsure to use UTC timestamps for IDO PgSQL cleanup queries 6622/head
Michael Friedrich [Mon, 17 Sep 2018 07:51:20 +0000 (09:51 +0200)]
Ensure to use UTC timestamps for IDO PgSQL cleanup queries

refs #6584

6 years agoRemove unused timestamp function in DB IDO 6621/head
Michael Friedrich [Mon, 17 Sep 2018 08:06:30 +0000 (10:06 +0200)]
Remove unused timestamp function in DB IDO

refs #6584

6 years agoSilence compiler warning for nice() 6618/head
Michael Friedrich [Fri, 14 Sep 2018 12:29:52 +0000 (14:29 +0200)]
Silence compiler warning for nice()

6 years agoAdd ApiListener#tls_handshake_timeout option
Michael Friedrich [Thu, 13 Sep 2018 16:05:31 +0000 (18:05 +0200)]
Add ApiListener#tls_handshake_timeout option

This allows to specify the previously hardcoded
timeout of 10s.

refs #6517

6 years agoMerge pull request #6615 from Icinga/feature/docs-distributed-monitoring
Michael Friedrich [Thu, 13 Sep 2018 16:37:45 +0000 (18:37 +0200)]
Merge pull request #6615 from Icinga/feature/docs-distributed-monitoring

Update distributed monitoring docs for 2.10

6 years agoDrop older than 2.8 references in distributed monitoring docs 6615/head
Michael Friedrich [Thu, 13 Sep 2018 14:33:27 +0000 (16:33 +0200)]
Drop older than 2.8 references in distributed monitoring docs

With 2.10, 2.8 will be the least supported version, older doc
versions can still be found on GH if needed.

6 years agoDistributed Monitoring Docs: Adopt three level scenario for CA proxy
Michael Friedrich [Thu, 13 Sep 2018 14:19:38 +0000 (16:19 +0200)]
Distributed Monitoring Docs: Adopt three level scenario for CA proxy

fixes #6593

6 years agoDistributed Monitoring Docs: Add versions and upgrade
Michael Friedrich [Thu, 13 Sep 2018 13:13:03 +0000 (15:13 +0200)]
Distributed Monitoring Docs: Add versions and upgrade

refs #6612

6 years agoMerge pull request #6519 from Icinga/fix/erroneous-console-exit
Michael Friedrich [Thu, 13 Sep 2018 11:34:58 +0000 (13:34 +0200)]
Merge pull request #6519 from Icinga/fix/erroneous-console-exit

Reset terminal on erroneous console exit

6 years agoMerge pull request #6610 from Icinga/feature/docs-technical-concepts-tls-network-io
Michael Friedrich [Thu, 13 Sep 2018 11:10:35 +0000 (13:10 +0200)]
Merge pull request #6610 from Icinga/feature/docs-technical-concepts-tls-network-io

Add "TLS Network IO" into technical concepts docs

6 years agoUpdate workaround for custom vars
Jean Flach [Tue, 4 Sep 2018 11:33:48 +0000 (13:33 +0200)]
Update workaround for custom vars

This updates #6572 which did not work

refs #6590

6 years agoAdd note about workaround for broken custom vars
Jean Flach [Fri, 24 Aug 2018 09:03:29 +0000 (11:03 +0200)]
Add note about workaround for broken custom vars

refs #6572

6 years agoImprove error logging for match/regex/cidr_match functions and unsupported dictionary...
Michael Friedrich [Fri, 27 Jul 2018 14:34:50 +0000 (16:34 +0200)]
Improve error logging for match/regex/cidr_match functions and unsupported dictionary usage

fixes #6442
refs #6497

6 years agoImprove TLS handshake exception logging
Noah Hilverling [Thu, 6 Sep 2018 13:58:42 +0000 (15:58 +0200)]
Improve TLS handshake exception logging

refs #6602

6 years agoMerge pull request #6527 from Icinga/feature/acknowledgment-notifications-6047
Michael Friedrich [Wed, 12 Sep 2018 15:27:19 +0000 (17:27 +0200)]
Merge pull request #6527 from Icinga/feature/acknowledgment-notifications-6047

Acknowledgment notifications should only be send if problem notification has been send

6 years agoUpdate notification and upgrading docs for recovery/acknowledgement handling 6527/head
Michael Friedrich [Wed, 12 Sep 2018 15:08:32 +0000 (17:08 +0200)]
Update notification and upgrading docs for recovery/acknowledgement handling

refs #6047

6 years agoOnly check for Problem types in user filers for Recovery/Acknowledgement notifications
Michael Friedrich [Wed, 12 Sep 2018 15:04:11 +0000 (17:04 +0200)]
Only check for Problem types in user filers for Recovery/Acknowledgement notifications

refs #6047

6 years agoStill notify on acknowledgement and recovery if user does not get problem notificatio...
Noah Hilverling [Tue, 4 Sep 2018 11:11:28 +0000 (13:11 +0200)]
Still notify on acknowledgement and recovery if user does not get problem notifications at all

refs #6047

6 years agoOnly send acknowledgement notification if user received a problem notification
Noah Hilverling [Tue, 7 Aug 2018 08:02:13 +0000 (10:02 +0200)]
Only send acknowledgement notification if user received a problem notification

refs #6047

6 years agoAdd "TLS Network IO" into technical concepts docs 6610/head
Michael Friedrich [Wed, 12 Sep 2018 12:45:11 +0000 (14:45 +0200)]
Add "TLS Network IO" into technical concepts docs

refs #6517

6 years agoMerge pull request #6607 from Icinga/feature/docs-dev-gdb-running-process
Michael Friedrich [Wed, 12 Sep 2018 10:40:17 +0000 (12:40 +0200)]
Merge pull request #6607 from Icinga/feature/docs-dev-gdb-running-process

Enhance development docs with GDB backtrace and thread list

6 years agoEnhance development docs with GDB backtrace and thread list 6607/head
Michael Friedrich [Wed, 12 Sep 2018 10:32:00 +0000 (12:32 +0200)]
Enhance development docs with GDB backtrace and thread list

6 years agoMerge pull request #6596 from Icinga/bugfix/gcc-8-f28-hardening-crash
Michael Friedrich [Tue, 11 Sep 2018 18:44:12 +0000 (20:44 +0200)]
Merge pull request #6596 from Icinga/bugfix/gcc-8-f28-hardening-crash

Fix crash on API queries with Fedora 28 hardening and GCC 8

6 years agoMerge pull request #6606 from Icinga/feature/enhance-contributing-docs
Michael Friedrich [Tue, 11 Sep 2018 08:55:35 +0000 (10:55 +0200)]
Merge pull request #6606 from Icinga/feature/enhance-contributing-docs

Enhance contributing docs

6 years agoMention 'help wanted' and 'good first issue' in contributing docs 6606/head
Michael Friedrich [Tue, 11 Sep 2018 07:30:33 +0000 (09:30 +0200)]
Mention 'help wanted' and 'good first issue' in contributing docs

6 years agoRename branch schema from `fix/` to `bugfix/`
Michael Friedrich [Tue, 11 Sep 2018 07:23:28 +0000 (09:23 +0200)]
Rename branch schema from `fix/` to `bugfix/`

6 years agoMerge pull request #6573 from Icinga/bugfix/operator-docs-1
Michael Friedrich [Tue, 11 Sep 2018 07:12:15 +0000 (09:12 +0200)]
Merge pull request #6573 from Icinga/bugfix/operator-docs-1

Fix operator precedence table

6 years agoFix operator precedence table 6573/head
Jean Flach [Fri, 24 Aug 2018 12:50:16 +0000 (14:50 +0200)]
Fix operator precedence table

Fixes #5573

6 years agoMerge pull request #6602 from Icinga/fix/improve-tls-handshake-exception-logging
Michael Friedrich [Thu, 6 Sep 2018 15:01:22 +0000 (17:01 +0200)]
Merge pull request #6602 from Icinga/fix/improve-tls-handshake-exception-logging

Improve TLS handshake exception logging

6 years agoImprove TLS handshake exception logging 6602/head
Noah Hilverling [Thu, 6 Sep 2018 13:58:42 +0000 (15:58 +0200)]
Improve TLS handshake exception logging

6 years agoMerge pull request #6595 from Icinga/feature/limit-anonymous-rpc-connections
Michael Friedrich [Thu, 6 Sep 2018 11:26:46 +0000 (13:26 +0200)]
Merge pull request #6595 from Icinga/feature/limit-anonymous-rpc-connections

Allow to configure anonymous clients limit inside the ApiListener object

6 years agoMerge pull request #6598 from dominik-r-s/patch-1
Michael Friedrich [Thu, 6 Sep 2018 08:40:39 +0000 (10:40 +0200)]
Merge pull request #6598 from dominik-r-s/patch-1

doc/09-object-types: states filter ignored for Acknowledgements

6 years agoMerge pull request #6597 from Icinga/feature/docs-development-fedora-debuginfos
Michael Friedrich [Thu, 6 Sep 2018 08:40:11 +0000 (10:40 +0200)]
Merge pull request #6597 from Icinga/feature/docs-development-fedora-debuginfos

Add Fedora to development docs for debuginfo packages

6 years agoAdd Fedora to development docs for debuginfo packages 6597/head
Michael Friedrich [Wed, 5 Sep 2018 18:44:44 +0000 (20:44 +0200)]
Add Fedora to development docs for debuginfo packages

6 years agoFix crash on API queries with Fedora 28 hardening and GCC 8 6596/head
Michael Friedrich [Wed, 5 Sep 2018 18:42:55 +0000 (20:42 +0200)]
Fix crash on API queries with Fedora 28 hardening and GCC 8

The actual fix is to handle nullptr references differently
for an empty filter expression. The other changes include
oob checks not necesarily involved.

fixes #6533

6 years agoAllow to configure anonymous clients limit inside the ApiListener object 6595/head
Michael Friedrich [Wed, 5 Sep 2018 15:45:35 +0000 (17:45 +0200)]
Allow to configure anonymous clients limit inside the ApiListener object

Previously this was hardcoded, and for security reasons users might want
to adjust this value. This affects CSR signing requests as well as
clients which have not yet been configured as endpoints on the current
node.

refs #6566

6 years agoRaise the message size for anonymous client and pki request calls to 1MB
Michael Friedrich [Wed, 5 Sep 2018 15:44:05 +0000 (17:44 +0200)]
Raise the message size for anonymous client and pki request calls to 1MB

If one sends the full certificate chain, this previous limit of 64KB
could be hit.

6 years ago09-object-types: notifications: states filter ignored for Acknowledgements! 6598/head
dominik-r-s [Wed, 5 Sep 2018 14:46:36 +0000 (16:46 +0200)]
09-object-types: notifications: states filter ignored for Acknowledgements!

6 years agoMerge pull request #6591 from Icinga/bugfix/lto-builds-static-initialize-namespaces
Michael Friedrich [Tue, 4 Sep 2018 14:54:30 +0000 (16:54 +0200)]
Merge pull request #6591 from Icinga/bugfix/lto-builds-static-initialize-namespaces

Fix static initializer priority for namespaces in LTO builds

6 years agoMerge pull request #6590 from Icinga/fix/custom-var-workaround
Michael Friedrich [Tue, 4 Sep 2018 14:41:55 +0000 (16:41 +0200)]
Merge pull request #6590 from Icinga/fix/custom-var-workaround

Update workaround for custom vars

6 years agoFix static initializer priority for namespaces in LTO builds 6591/head
Michael Friedrich [Tue, 4 Sep 2018 13:17:34 +0000 (13:17 +0000)]
Fix static initializer priority for namespaces in LTO builds

fixes #6575

6 years agoMerge pull request #6356 from sourcejedi/fix/systemd
Jean Flach [Tue, 4 Sep 2018 13:24:43 +0000 (15:24 +0200)]
Merge pull request #6356 from sourcejedi/fix/systemd

Fix logging under systemd

6 years agoMerge pull request #6568 from Icinga/feature/commit-order
Michael Friedrich [Tue, 4 Sep 2018 11:39:40 +0000 (13:39 +0200)]
Merge pull request #6568 from Icinga/feature/commit-order

Ensure that config object types are committed in dependent load order

6 years agoUpdate workaround for custom vars 6590/head
Jean Flach [Tue, 4 Sep 2018 11:33:48 +0000 (13:33 +0200)]
Update workaround for custom vars

This updates #6572 which did not work

6 years agoUpdate variable names 6568/head
Jean Flach [Wed, 22 Aug 2018 13:12:47 +0000 (15:12 +0200)]
Update variable names

6 years agoEnsure that config object types are committed in dependent load order
Markus Frosch [Thu, 9 Aug 2018 09:55:20 +0000 (11:55 +0200)]
Ensure that config object types are committed in dependent load order

6 years agoMerge pull request #6581 from Icinga/fix/speedup-config
Michael Friedrich [Tue, 4 Sep 2018 09:15:13 +0000 (11:15 +0200)]
Merge pull request #6581 from Icinga/fix/speedup-config

Shuffle items before config validation

6 years agoShuffle items before config validation 6581/head
Jean Flach [Fri, 31 Aug 2018 11:11:50 +0000 (13:11 +0200)]
Shuffle items before config validation

6 years agoMerge pull request #6588 from Icinga/bugfix/prepare-dirs-safe-reload-full-path
Michael Friedrich [Tue, 4 Sep 2018 09:04:02 +0000 (11:04 +0200)]
Merge pull request #6588 from Icinga/bugfix/prepare-dirs-safe-reload-full-path

Fix using full path in prepare-dirs/safe-reload scripts

6 years agoFix using full path in prepare-dirs/safe-reload scripts 6588/head
Michael Friedrich [Mon, 3 Sep 2018 14:47:38 +0000 (16:47 +0200)]
Fix using full path in prepare-dirs/safe-reload scripts

This won't be visible with packages and overridden paths,
just source builds which invoke the scripts manually.

refs #6506

6 years agoMerge pull request #6583 from maxswjeon/master
Michael Friedrich [Mon, 3 Sep 2018 13:48:55 +0000 (15:48 +0200)]
Merge pull request #6583 from maxswjeon/master

Update PostgreSQL library path variable in INSTALL.md

6 years agoMerge pull request #6586 from Icinga/bugfix/centos-7-buildfix-non-unity-builds
Michael Friedrich [Mon, 3 Sep 2018 13:47:45 +0000 (15:47 +0200)]
Merge pull request #6586 from Icinga/bugfix/centos-7-buildfix-non-unity-builds

Fix non-unity builds on CentOS 7 with std::shared_ptr

6 years agoFix non-unity builds on CentOS 7 with std::shared_ptr 6586/head
Michael Friedrich [Mon, 3 Sep 2018 13:32:28 +0000 (15:32 +0200)]
Fix non-unity builds on CentOS 7 with std::shared_ptr

refs #6509

6 years agoMerge pull request #6574 from gunnarbeutner/fix/move-downtime-constants
Michael Friedrich [Mon, 3 Sep 2018 07:28:16 +0000 (09:28 +0200)]
Merge pull request #6574 from gunnarbeutner/fix/move-downtime-constants

Move new downtime constants into the Icinga namespace

6 years agoEdited INSTALL.md File 6583/head
Jeon Sang Wan [Sun, 2 Sep 2018 13:11:19 +0000 (22:11 +0900)]
Edited INSTALL.md File

Edited the Mistake of the PostgreSQL_LIBRARY_DIR comment error.
#6582

6 years agoMove new downtime constants into the Icinga namespace 6574/head
Gunnar Beutner [Sat, 25 Aug 2018 17:35:01 +0000 (19:35 +0200)]
Move new downtime constants into the Icinga namespace

6 years agoFix logging under systemd 6356/head
Alan Jenkins [Tue, 29 May 2018 16:24:05 +0000 (17:24 +0100)]
Fix logging under systemd

icinga2.service used `-e ${ICINGA2_ERROR_LOG}`, but this is documented
as having no effect without `-d`.  Furthermore, icinga2 under systemd
unconditionally logged everything to the system log (but without setting
the log level etc), which contradicted the documentation.  (Issue #6339)

Stop icinga2 on systemd from logging to stdout - and hence the system log -
once it has finished starting up.  Just like when you start icinga2 from a
terminal using `-d`.  And just like -d, we stop logging fatal errors to
stderr, and instead write to the log file passed with `-e`.

As per docs, mainlog (icinga2.log) is already enabled by default.  And
pre-startup messages including config errors will still appear in the
system log.

This uses a new option --close-stdio, which has the same effect on logging as
--daemonize, but does not fork or call setsid().

For this purpose, I moved setsid() up and into Daemonize().

Consequence of that last point: if anyone is weird enough to specify a TTY
device file as the fatal error log (-e option), that will become icinga's
controlling terminal, which you generally don't want as a daemon.  This
makes it consistent with the existing behaviour for icinga mainlog.  For
this reason you're supposed to use O_NOCTTY in Linux daemons.  But I wasn't
sure where icinga would want to put the ugly `#ifdef _WIN32 ... #else ...`.

6 years agoDaemonize(): use one error convention, not three
Alan Jenkins [Wed, 30 May 2018 11:21:39 +0000 (12:21 +0100)]
Daemonize(): use one error convention, not three

Standardize on exit() / _exit() (this depends whether we are considered
to be the "main" fork, which should run anything registered with atexit()).
Exclude `return false` and throwing exceptions.

This fixes the error path for fork().  Daemonize() would return false, but
the `return false` error convention was not tested in the caller.

It also fixes the error message for fork() to show the error code.
Everyone loves `strace`, but sysadmins should not have to rerun their
daemons under it just to see an error code.

Also in case an exception is thrown, show its diagnostic information
instead of dropping it on the floor.  In the log message, I mention why we
are uninitializing and then initializing the app at this point.

For the reader, it pushes all the weirdness into the error convention of
Daemonize().  This comes back to the exit() / _exit() distinction.  Once
we have forked, we technically don't want to allow the parent process to
exit(), so we don't want to return to the caller.

6 years agofix "Console" log to flush
Alan Jenkins [Mon, 28 May 2018 20:08:57 +0000 (21:08 +0100)]
fix "Console" log to flush

It's called "Console", which would be line-buffered anyway.  But, it's
implemented as std::cout.  This might be piped to a logger, as in
daemontools or systemd.  In this case it will not be a TTY, and log lines
should be flushed without too much delay.  Let's just flush each message.

Let's not introduce a static instance of StreamLogger (flushed by interval
timer).  That's too stressful to read, because static instances are really
annoying to order.  Example citation: "Yay, our static destructors are
pretty much beyond repair at this point." -- application.cpp.

I don't know if there will be any need to optimize logging syscalls.  The
init script uses `--daemonize`.  I think the systemd service should also
avoid using the "Console" log after startup (see next commit).  The
documentation does not warn that the syslog feature is less efficient
in system calls than mainlog; deferred flusing does not seem to be a highly
prominent feature.  There's no cool comment in the code about how much the
syscalls were slowing down some use case (or qualifying that this
optimization can only eliminate syscalls on platforms with both mutexes and
clocks that can work without syscalls).

6 years agoMerge pull request #6532 from Icinga/feature/allow-down-times-to-apply-on-child-hosts...
Michael Friedrich [Fri, 24 Aug 2018 13:14:58 +0000 (15:14 +0200)]
Merge pull request #6532 from Icinga/feature/allow-down-times-to-apply-on-child-hosts-3935

Add child_options to ScheduledDowntime

6 years agoAdd upgrading docs for API schedule-downtime 'child_options' 6532/head
Michael Friedrich [Fri, 24 Aug 2018 12:56:04 +0000 (14:56 +0200)]
Add upgrading docs for API schedule-downtime 'child_options'

6 years agoMerge pull request #6502 from jenslink/patch-2
Jean Flach [Fri, 24 Aug 2018 12:37:00 +0000 (14:37 +0200)]
Merge pull request #6502 from jenslink/patch-2

Update 17-language-reference.md

6 years agoMerge pull request #6501 from jenslink/patch-1
Jean Flach [Fri, 24 Aug 2018 12:36:45 +0000 (14:36 +0200)]
Merge pull request #6501 from jenslink/patch-1

Update 03-monitoring-basics.md

6 years agoMerge pull request #6510 from Icinga/feature/windows-build-scripts
Jean Flach [Fri, 24 Aug 2018 12:31:57 +0000 (14:31 +0200)]
Merge pull request #6510 from Icinga/feature/windows-build-scripts

Update Appveyor build scripts

6 years agoAdd child_options to ScheduledDowntime
Noah Hilverling [Wed, 8 Aug 2018 12:42:18 +0000 (14:42 +0200)]
Add child_options to ScheduledDowntime

refs #3935

6 years agoMerge pull request #6509 from gunnarbeutner/feature/real-constants
Michael Friedrich [Fri, 24 Aug 2018 10:10:10 +0000 (12:10 +0200)]
Merge pull request #6509 from gunnarbeutner/feature/real-constants

Implement support for namespaces