]>
granicus.if.org Git - esp-idf/log
Hrishikesh Dhayagude [Wed, 24 Oct 2018 03:24:07 +0000 (08:54 +0530)]
examples/bluetooth: Miscellaneous fixes in some of the examples
This closes:
https://github.com/espressif/esp-idf/issues/2617
https://github.com/espressif/esp-idf/issues/2622
Signed-off-by: Hrishikesh Dhayagude <hrishi@espressif.com>
Angus Gratton [Fri, 26 Oct 2018 05:45:19 +0000 (13:45 +0800)]
Merge branch 'bugfix/py3_ci' into 'master'
Fix Python3 compatibility issues
See merge request idf/esp-idf!3487
Angus Gratton [Fri, 26 Oct 2018 05:14:19 +0000 (13:14 +0800)]
Merge branch 'feature/esp_event_loop_library' into 'master'
event: Implement event loop library
See merge request idf/esp-idf!2881
Renz Christian Bagaporo [Fri, 26 Oct 2018 05:14:19 +0000 (13:14 +0800)]
event: Implement event loop library
Angus Gratton [Fri, 26 Oct 2018 04:59:38 +0000 (12:59 +0800)]
Merge branch 'bugfix/rename_http_server' into 'master'
Rename http_server component to esp_http_server
See merge request idf/esp-idf!3553
Angus Gratton [Fri, 26 Oct 2018 04:58:03 +0000 (12:58 +0800)]
Merge branch 'bugfix/idf_pyserial_error' into 'master'
idf.py: Import from pyserial after packages have been checked
See merge request idf/esp-idf!3519
Angus Gratton [Fri, 26 Oct 2018 04:41:00 +0000 (12:41 +0800)]
Merge branch 'fix/spi_polling_speed_test' into 'master'
spi: speed up polling performance and fix several tests
Closes #33
See merge request idf/esp-idf!3530
Angus Gratton [Fri, 26 Oct 2018 04:19:50 +0000 (12:19 +0800)]
Merge branch 'bugfix/missing_header_file' into 'master'
esp32: Add missing header file in esp_task.h
See merge request idf/esp-idf!3353
Ivan Grokhotkov [Fri, 26 Oct 2018 03:56:22 +0000 (11:56 +0800)]
Merge branch 'ci/only_create_required_jobs_in_pipeline' into 'master'
CI: only create required jobs when use bot to trigger test
See merge request idf/esp-idf!3404
Jiang Jiang Jian [Fri, 26 Oct 2018 03:50:44 +0000 (11:50 +0800)]
Merge branch 'bugfix/fix_some_wifi_bugs_1022' into 'master'
esp32: fix some wifi bugs
See merge request idf/esp-idf!3539
Jiang Jiang Jian [Fri, 26 Oct 2018 03:41:18 +0000 (11:41 +0800)]
Merge branch 'bugfix/btdm_read_multiple_return_callback_status_ESP_GATT_STACK_RSP' into 'master'
Component/bt: fix read multiple return callback status: ESP_GATT_STACK_RSP
See merge request idf/esp-idf!3437
Jiang Jiang Jian [Fri, 26 Oct 2018 03:38:50 +0000 (11:38 +0800)]
Merge branch 'bugfix/btdm_add_sniff_mode_to_spp' into 'master'
components/bt: Add sniff mode to SPP
See merge request idf/esp-idf!3472
Jiang Jiang Jian [Fri, 26 Oct 2018 03:34:26 +0000 (11:34 +0800)]
Merge branch 'bugfix/btdm_disconnect_ble_when_ESP_BLE_SM_ONLY_ACCEPT_SPECIFIED_SEC_AUTH_failed' into 'master'
Component/bt: add ble disconnect when ACCEPT_SPECIFIED_SEC_AUTH failed
See merge request idf/esp-idf!3465
Liu Zhi Fu [Thu, 25 Oct 2018 08:47:57 +0000 (16:47 +0800)]
esp32: fix some wifi bugs
Fix following WiFi bugs:
1. Fix the bug that MIC verification fails on soft-AP mode
2. Modify mesh root to have same behavior as normal WiFi STA in state change
3. Fix the bug that sniffer can't catch control packets
4. Fix crash bug in soft-AP mode
5. Fix ACM(Admission Control Management) bug
Jiang Jiang Jian [Thu, 25 Oct 2018 07:14:14 +0000 (15:14 +0800)]
Merge branch 'bugfix/btdm_fix_remove_bond_list_failed' into 'master'
component/bt: fix remove bond list failed
See merge request idf/esp-idf!3475
Roland Dobai [Thu, 25 Oct 2018 06:16:30 +0000 (08:16 +0200)]
idf.py: Import from pyserial after packages have been checked
Closes https://github.com/espressif/esp-idf/issues/2573
zhiweijian [Thu, 11 Oct 2018 03:25:45 +0000 (11:25 +0800)]
Component/bt: add ble disconnect when ACCEPT_SPECIFIED_SEC_AUTH failed
Michael (XIAO Xufeng) [Mon, 22 Oct 2018 07:25:41 +0000 (15:25 +0800)]
spi_master: speed up polling performance by putting into IRAM
Michael (XIAO Xufeng) [Fri, 19 Oct 2018 04:00:16 +0000 (12:00 +0800)]
test: fix the IRAM type conflict issue using heap_caps_malloc
zwj [Fri, 12 Oct 2018 02:48:46 +0000 (10:48 +0800)]
component/bt: fix remove bond list failed
Anurag Kar [Wed, 24 Oct 2018 10:09:43 +0000 (15:39 +0530)]
Protocomm : Use esp_http_server instead of http_server
Anurag Kar [Wed, 24 Oct 2018 09:55:04 +0000 (15:25 +0530)]
HTTP Server Docs : Replace http_server with esp_http_server
Anurag Kar [Wed, 24 Oct 2018 09:52:15 +0000 (15:22 +0530)]
HTTP Server Examples : Include header esp_http_server.h
Anurag Kar [Wed, 24 Oct 2018 09:42:50 +0000 (15:12 +0530)]
HTTP Server : Added esp_ prefix to http_server component files
Roland Dobai [Wed, 10 Oct 2018 11:19:31 +0000 (13:19 +0200)]
Fix Python 3 compatibility issues
He Yin Ling [Sat, 29 Sep 2018 06:51:43 +0000 (14:51 +0800)]
CI: only create required jobs when use bot to trigger test:
Gitlab CI now allow us to define if a job need to be created by
varialbes. This commit add label to CI jobs, so we can make some jobs
not created in certain scenarios when we trigger pipeline with @bot.
Angus Gratton [Wed, 24 Oct 2018 09:00:38 +0000 (17:00 +0800)]
Merge branch 'feature/ci_multi_python' into 'master'
CI: Support switching between various versions of Python
See merge request idf/esp-idf!3520
Jiang Jiang Jian [Mon, 22 Oct 2018 13:20:14 +0000 (21:20 +0800)]
Merge branch 'bugfix/tw26711_fix_wifi_memory' into 'master'
esp32: fix wifi memory leak
See merge request idf/esp-idf!3523
Angus Gratton [Mon, 22 Oct 2018 08:29:15 +0000 (16:29 +0800)]
Merge branch 'feature/cmake-unit-test' into 'master'
cmake: add unit tests build support
See merge request idf/esp-idf!3003
Angus Gratton [Mon, 22 Oct 2018 03:11:04 +0000 (11:11 +0800)]
Merge branch 'bugfix/gcc8_compatibility' into 'master'
gcc8 compatibility for master branch
See merge request idf/esp-idf!3481
Angus Gratton [Mon, 22 Oct 2018 01:10:58 +0000 (09:10 +0800)]
Merge branch 'feature/docs_getting_started_guides_cn' into 'master'
Added CN version of 'Getting Started' guides for 'ESP32-DevKitC' and 'ESP-WROVER-KIT'
See merge request idf/esp-idf!3408
Krzysztof Budzynski [Mon, 22 Oct 2018 01:10:58 +0000 (09:10 +0800)]
Added CN version of 'Getting Started' guides for 'ESP32-DevKitC' and 'ESP-WROVER-KIT'
Liu Zhi Fu [Sun, 21 Oct 2018 12:37:08 +0000 (20:37 +0800)]
esp32: fix wifi memory leak
Fix a WiFi memory leak bug
Anton Maklakov [Sat, 13 Oct 2018 08:26:11 +0000 (16:26 +0800)]
tcp_transport: Remove the ignore warning because we had idf/esp-idf!3359
Anton Maklakov [Sat, 13 Oct 2018 07:26:59 +0000 (15:26 +0800)]
docs: Correct Linux port names for more relevance
Anton Maklakov [Sat, 13 Oct 2018 07:13:02 +0000 (15:13 +0800)]
test_spi_slave: fix warnings about unused identifiers
Anton Maklakov [Sat, 13 Oct 2018 06:38:48 +0000 (14:38 +0800)]
intr: fix a type mismatch warning
Anton Maklakov [Tue, 25 Sep 2018 06:10:03 +0000 (14:10 +0800)]
pthread: fix a type mismatch warning
Renz Bagaporo [Mon, 27 Aug 2018 02:48:16 +0000 (10:48 +0800)]
cmake: Add support for test build
Roland Dobai [Tue, 25 Sep 2018 12:43:07 +0000 (14:43 +0200)]
CI: Support switching between various versions of Python
Jiang Jiang Jian [Fri, 19 Oct 2018 07:29:58 +0000 (15:29 +0800)]
Merge branch 'feature/add_ping_packet_len_and_QoS' into 'master'
ping: add length and QoS
See merge request idf/esp-idf!3379
Ivan Grokhotkov [Fri, 19 Oct 2018 05:05:55 +0000 (13:05 +0800)]
Merge branch 'feature/uart_rs485_test' into 'master'
driver: rs485 test support
See merge request idf/esp-idf!2701
Ivan Grokhotkov [Fri, 19 Oct 2018 04:42:32 +0000 (12:42 +0800)]
Merge branch 'feature/simple_sniffer' into 'master'
wifi sniffer example
See merge request idf/esp-idf!3412
Ivan Grokhotkov [Fri, 19 Oct 2018 04:35:00 +0000 (12:35 +0800)]
Merge branch 'feature/freemodbus_slave_support_upd' into 'feature/uart_rs485_test'
examples: freemodbus port slave basic implementation
See merge request idf/esp-idf!3468
Ivan Grokhotkov [Fri, 19 Oct 2018 04:33:09 +0000 (12:33 +0800)]
Merge branch 'bugfix/unit_tests_tcpip_adapter' into 'master'
unit tests: Only initialise tcpip_adapter() when needed by the test
See merge request idf/esp-idf!3364
Ivan Grokhotkov [Fri, 19 Oct 2018 03:55:37 +0000 (11:55 +0800)]
Merge branch 'bugfix/ndebug_build' into 'master'
soc,sdmmc: fix build failures when NDEBUG is used
See merge request idf/esp-idf!3352
morris [Thu, 27 Sep 2018 03:24:12 +0000 (11:24 +0800)]
example: add console command for wifi sniffer
1. add mount/unmount command
2. add sniffer command, supporting options
3. make pcap a component
Ivan Grokhotkov [Fri, 19 Oct 2018 02:25:47 +0000 (10:25 +0800)]
Merge branch 'bugfix/asio_consistent_example_names' into 'master'
Renamed examples to be consistent no matter which build system used
See merge request idf/esp-idf!3257
Ivan Grokhotkov [Thu, 18 Oct 2018 14:57:46 +0000 (22:57 +0800)]
Merge branch 'bugfix/move_ringbuf_lib_to_iram' into 'master'
esp_ringbuf: fix default placement from flash to IRAM
See merge request idf/esp-idf!3452
Ivan Grokhotkov [Thu, 18 Oct 2018 14:41:48 +0000 (22:41 +0800)]
Merge branch 'bugfix/ci_missing_outputs' into 'master'
Tiny-test-fw: Fix string comparison which cases ignore of test cases
See merge request idf/esp-idf!3458
Ivan Grokhotkov [Thu, 18 Oct 2018 14:32:33 +0000 (22:32 +0800)]
Merge branch 'bugfix/fix_random_failure_with_ota_updates' into 'master'
app_update: fix intermittent failure with firmware updates
See merge request idf/esp-idf!3401
Jiang Jiang Jian [Thu, 18 Oct 2018 13:25:24 +0000 (21:25 +0800)]
Merge branch 'bugfix/coex_hw_blocking_2nd' into 'master'
coexist : fix coexist bugs related to coex hw blocking
See merge request idf/esp-idf!3414
Jiang Jiang Jian [Thu, 18 Oct 2018 06:55:34 +0000 (14:55 +0800)]
Merge branch 'bugfix/fix_autoip_bug' into 'master'
fix the compile bug for autoip
See merge request idf/esp-idf!3450
Angus Gratton [Thu, 18 Oct 2018 06:22:15 +0000 (14:22 +0800)]
Merge branch 'bugfix/idf_tools_installer' into 'master'
IDF Tools Installer for Windows: Python requirements, ULP & openocd, signed installer
See merge request idf/esp-idf!3428
Mahavir Jain [Sat, 29 Sep 2018 05:12:40 +0000 (10:42 +0530)]
app_update: remove unrequired static attribute from mmap handle
Mahavir Jain [Fri, 28 Sep 2018 10:29:52 +0000 (15:59 +0530)]
app_update: fix intermittent failure with firmware updates
Routine `spi_flash_cache2phys` sometimes return incorrect value,
resulting in failure in getting currently running ota partition.
This in turn aborts firmware update process.This issue was more
prominent with SPIRAM enabled cases.
Fix ensures proper cache guards during `spi_flash_cache2phys`, and
also for few other similar APIs.
In addition, `esp_ota_get_running_partition` has also been optimized
to save currently running partition for subsequent invocations.
Fixes https://github.com/espressif/esp-idf/issues/2451
Mahavir Jain [Tue, 9 Oct 2018 11:56:14 +0000 (17:26 +0530)]
esp_ringbuf: fix default placement from flash to IRAM
In earlier change this component was decoupled from freertos and hence
regression was introduced which changed default placement to flash. Some
device drivers make use of ringbuffer while flash cache is being disabled
and hence default placement should instead be internal memory.
Closes: https://github.com/espressif/esp-idf/issues/2517
Ivan Grokhotkov [Tue, 16 Oct 2018 04:46:17 +0000 (12:46 +0800)]
unit test: split psram config into two configs to free up IRAM
Tian Hao [Sun, 30 Sep 2018 09:26:04 +0000 (17:26 +0800)]
coexist : fix coexist bugs related to coex hw blocking
1. fix some bugs by previous coex hw blocking bugfix,
such like, rwble.c (64, 0) line 222
2. fix bug that ble scan performance is very low when software coexist
is working.
3. update libcoexist version to v1.1.0
Ivan Grokhotkov [Thu, 18 Oct 2018 03:25:59 +0000 (11:25 +0800)]
Merge branch 'bugfix/uart_wait_idle' into 'master'
uart: fix uart_tx_wait_idle to wait for fifo empty
See merge request idf/esp-idf!3489
Jiang Jiang Jian [Thu, 18 Oct 2018 03:10:10 +0000 (11:10 +0800)]
Merge branch 'bugfix/wpa2_fixes' into 'master'
wpa2_enterprise fixes from Github
See merge request idf/esp-idf!3166
Jiang Jiang Jian [Thu, 18 Oct 2018 03:06:44 +0000 (11:06 +0800)]
Merge branch 'mesh/bugfix_esp_ssid_ie' into 'master'
mesh: fix a bug in generating ESP-SSID IE
See merge request idf/esp-idf!3382
Angus Gratton [Wed, 17 Oct 2018 22:59:47 +0000 (06:59 +0800)]
Merge branch 'feature/httpd_sock_err' into 'master'
HTTP Server : Return HTTPD_SOCK_ERR_ based on errno set during send / recv
See merge request idf/esp-idf!3445
Angus Gratton [Wed, 17 Oct 2018 07:15:41 +0000 (18:15 +1100)]
cmake: Fix Windows issue running menuconfig in Command Prompt if winpty on Path
Previous version assumed having winpty on the Path meant that it would be needed,
but some tools (like Atlassian Sourcetree) permanently add winpty to the path.
Symptom is arrow keys not working in menuconfig dialog.
Angus Gratton [Mon, 1 Oct 2018 06:22:07 +0000 (16:22 +1000)]
Sign IDF Tools installer with 'osslsigncode', update to V1.2
Uninstaller is still unsigned, as currently building and signing in 'wine'
and running Linux osslsigncode inside Inno Setup inside wine is awkward.
Closes https://github.com/espressif/esp-idf/issues/1909
TW20810
Angus Gratton [Thu, 4 Oct 2018 03:30:47 +0000 (13:30 +1000)]
windows: Add License (GPL) display to IDF Tools installer
Angus Gratton [Mon, 1 Oct 2018 06:21:30 +0000 (16:21 +1000)]
windows: Add Python dependencies, openocd, and ULP to installer
Angus Gratton [Mon, 1 Oct 2018 06:19:37 +0000 (16:19 +1000)]
docs: Recommend native 'cryptography' package on Linux as well
Angus Gratton [Wed, 26 Sep 2018 00:17:46 +0000 (10:17 +1000)]
unit tests: Only initialise tcpip_adapter() when needed by the test
Prevents unexpected memory allocations when running tests which
don't require tcpip_adapter.
David Cermak [Wed, 12 Sep 2018 13:52:38 +0000 (15:52 +0200)]
asio: examples renamed to have consistent binary names when build in make and CMake
zhiweijian [Mon, 8 Oct 2018 03:55:57 +0000 (11:55 +0800)]
Component/bt: read multiple return callback status: ESP_GATT_STACK_RSP
Anurag Kar [Tue, 9 Oct 2018 14:47:26 +0000 (20:17 +0530)]
HTTP Server Docs : Updated to demonstrate handling of timeout errors
Anurag Kar [Tue, 9 Oct 2018 12:37:38 +0000 (18:07 +0530)]
HTTP Server Examples : Updated examples to manually return 408 and 500 errors
Anurag Kar [Tue, 9 Oct 2018 12:34:37 +0000 (18:04 +0530)]
HTTP Server : Automated 408 error response restricted to timeout in receiving packet header
Anurag Kar [Tue, 9 Oct 2018 12:33:41 +0000 (18:03 +0530)]
HTTP Server : Added helper functions for sending HTTP error 408 and 500
Anurag Kar [Tue, 9 Oct 2018 12:24:33 +0000 (17:54 +0530)]
HTTP Server : Bug fixed in httpd_recv logic and updated function descriptions
Anurag Kar [Tue, 9 Oct 2018 06:12:23 +0000 (11:42 +0530)]
HTTP Server : Use getsockopt instead of errno
Anurag Kar [Mon, 8 Oct 2018 11:15:45 +0000 (16:45 +0530)]
HTTP Server : Return HTTPD_SOCK_ERR_ based on errno set during send / recv
This feature allows `httpd_req_recv()` and `httpd_send()` functions to return
specific `HTTPD_SOCK_ERR_` codes in case of socket errors. This is useful
in case of errors like `EAGAIN`, `EINTR`, etc. when the user may want to
retry `httpd_req_recv()` / `httpd_send()` function call.
Alex Lisitsyn [Thu, 28 Jun 2018 15:45:41 +0000 (17:45 +0200)]
examples: freemodbus port slave basic implementation
This example adds functionality to support basic communication in RS485 networks using Modbus protocol.
This example uses FreeModbus stack and regular UART driver API to communicate in RS485 half duplex mode.
Added initial support of modbus controller pure C api to access device parameters over Modbus transport.
Move freemodbus stack and port files into components folder
Move the modbus_controller interface into components idf folder
Source files updated after review.
Add modbus interface documentation docs/en/api-reference/protocols/modbus.rst
porttimer.c: fix bug with timer1 selected in the Kconfig
Add support of cmake system (added cmake files)
Closes https://github.com/espressif/esp-idf/issues/858
Alex Lisitsyn [Wed, 11 Jul 2018 08:39:25 +0000 (10:39 +0200)]
driver: rs485 test support (remove timeout tag)
Adds test functionality with TEST_CASE_MULTIPLE_DEVICES() macro for RS485 test support.
Alex Lisitsyn [Tue, 3 Jul 2018 14:17:03 +0000 (16:17 +0200)]
driver: rs485 test support
Adds test functionality with TEST_CASE_MULTIPLE_DEVICES() macro for RS485 test support.
qiyueixa [Wed, 17 Oct 2018 09:52:29 +0000 (17:52 +0800)]
mesh: fix a bug in generating ESP-SSID IE
1. wifi: if Wi-Fi is not scanning, ignore beacons from different channels.
zhangyanjiao [Wed, 5 Sep 2018 13:02:38 +0000 (21:02 +0800)]
add ping length and QoS
zhangyanjiao [Tue, 9 Oct 2018 07:21:38 +0000 (15:21 +0800)]
fix the compile bug for autoip
Roland Dobai [Wed, 10 Oct 2018 06:24:42 +0000 (08:24 +0200)]
Tiny-test-fw: Fix string comparison which cases ignore of test cases
Example tests from examples/protocols/http_server/ were silently ignored
because of incompatible string comparisons.
Angus Gratton [Wed, 17 Oct 2018 08:41:28 +0000 (16:41 +0800)]
Merge branch 'docs/freertos_words_to_bytes' into 'master'
FreeRTOS: Update API reference from words to bytes
See merge request idf/esp-idf!3453
Ivan Grokhotkov [Wed, 17 Oct 2018 08:37:22 +0000 (16:37 +0800)]
Merge branch 'bugfix/tw26696_fix_wifi_timer' into 'master'
esp32: fix WiFi timer inaccurate bug
See merge request idf/esp-idf!3471
Angus Gratton [Wed, 17 Oct 2018 07:24:38 +0000 (15:24 +0800)]
Merge branch 'feature/sockets_example' into 'master'
Feature/sockets example
See merge request idf/esp-idf!3447
Angus Gratton [Wed, 17 Oct 2018 07:23:48 +0000 (15:23 +0800)]
Merge branch 'feature/i2c-tools' into 'master'
add i2c-tools example
See merge request idf/esp-idf!3483
Angus Gratton [Wed, 17 Oct 2018 07:23:27 +0000 (15:23 +0800)]
Merge branch 'update/mfg_gen' into 'master'
Update mfg utility and nvs partition utility to make Python2 and Python3 compatible
See merge request idf/esp-idf!3243
Liu Zhi Fu [Thu, 11 Oct 2018 12:57:15 +0000 (20:57 +0800)]
esp32: fix WiFi timer inaccurate bug
Fix the bug that WiFi timer is not accurate when sleep is on
Angus Gratton [Wed, 17 Oct 2018 00:14:20 +0000 (08:14 +0800)]
Merge branch 'bugfix/run_esptool_espport' into 'master'
cmake: Handle ESPPORT environment variable correctly
See merge request idf/esp-idf!3482
morris [Mon, 15 Oct 2018 02:19:02 +0000 (10:19 +0800)]
i2c/i2c-tools: add i2c-tools example
1. add command i2cconfig
2. add command i2cdetect
3. add command i2cget
4. add command i2cset
5. add command i2cdump
6. add README.md
MartinValik [Tue, 2 Oct 2018 14:33:16 +0000 (16:33 +0200)]
BSD Socket examples
Angus Gratton [Tue, 16 Oct 2018 07:07:43 +0000 (15:07 +0800)]
Merge branch 'feature/34_coding_scheme' into 'master'
bootloader: 3/4 Coding Scheme support
See merge request idf/esp-idf!3430
Angus Gratton [Tue, 2 Oct 2018 05:15:32 +0000 (15:15 +1000)]
Secure Boot & Flash encryption: Support 3/4 Coding Scheme
Includes esptool update to v2.6-beta1
Angus Gratton [Tue, 16 Oct 2018 00:01:00 +0000 (08:01 +0800)]
Merge branch 'bugfix/fuzzer_ci_tests_to_new_lwip' into 'master'
LWIP Fuzzer: updated fuzzer tests to be compatible with new lwip module
See merge request idf/esp-idf!3278
Ivan Grokhotkov [Mon, 15 Oct 2018 12:08:16 +0000 (20:08 +0800)]
uart: fix uart_tx_wait_idle to wait for fifo empty
In some cases, when data was just written into UART FIFO, transmitter
state could be still zero while the FIFO did contain some data.
This resulted in uart_tx_wait_idle occasionally returning before all
the data was sent out.
Fix by checking both UART transmitter state and TX FIFO count.
Angus Gratton [Mon, 15 Oct 2018 08:27:44 +0000 (16:27 +0800)]
Merge branch 'bugfix/guide-download' into 'master'
Docs: Renamed download links to clearly state they are to download documentation.…
See merge request idf/esp-idf!3271
Jeroen Domburg [Mon, 15 Oct 2018 07:54:10 +0000 (15:54 +0800)]
Merge branch 'feature/64mb_psram_support_base' into 'master'
Feature/64mb psram support base
See merge request idf/esp-idf!2887