Problem: Saving/restoring search patterns share saved last_idx.
Solution: Use a separate saved last_idx for saving search patterns for
functions and incremental search.
Bram Moolenaar [Sat, 1 Dec 2018 12:14:45 +0000 (13:14 +0100)]
patch 8.1.0555: crash when last search pat is set but not last substitute pat
Problem: Crash when last search pat is set but not last substitute pat.
Solution: Do not mix up last search pattern and last subtitute pattern.
(closes #3647)
Bram Moolenaar [Fri, 30 Nov 2018 21:48:32 +0000 (22:48 +0100)]
patch 8.1.0553: it is not easy to edit a script that was sourced
Problem: It is not easy to edit a script that was sourced.
Solution: Add a count to ":scriptnames", so that ":script 40" edits the
script with script ID 40.
Bram Moolenaar [Fri, 30 Nov 2018 20:57:55 +0000 (21:57 +0100)]
patch 8.1.0552: saved last search pattern may not be restored
Problem: Saved last search pattern may not be restored.
Solution: Call restore_last_search_pattern(). Add a check for balancing
saving and restoring the last search pattern.
Bram Moolenaar [Wed, 28 Nov 2018 20:20:38 +0000 (21:20 +0100)]
patch 8.1.0551: expression evaluation may repeat an error message
Problem: Expression evaluation may repeat an error message. (Jason
Franklin)
Solution: Check for the value of did_emsg when giving an error
for the :execute command.
Bram Moolenaar [Wed, 28 Nov 2018 19:38:37 +0000 (20:38 +0100)]
patch 8.1.0550: expression evaluation may repeat an error message
Problem: Expression evaluation may repeat an error message. (Jason
Franklin)
Solution: Increment did_emsg and check for the value when giving an error
for the echo command.
Bram Moolenaar [Sun, 25 Nov 2018 01:18:29 +0000 (02:18 +0100)]
patch 8.1.0544: setting 'filetype' in a modeline causes an error
Problem: Setting 'filetype' in a modeline causes an error (Hirohito
Higashi).
Solution: Don't add the P_INSECURE flag when setting 'filetype' from a
modeline. Also for 'syntax'.
Bram Moolenaar [Sat, 24 Nov 2018 13:27:44 +0000 (14:27 +0100)]
patch 8.1.0543: Coverity warns for leaking memory and using wrong struct
Problem: Coverity warns for leaking memory and using wrong struct.
Solution: Free pointer when allocation fails. Change "boff" to "loff".
(closes #3634)
Bram Moolenaar [Thu, 22 Nov 2018 02:08:29 +0000 (03:08 +0100)]
patch 8.1.0542: shiftwidth() does not take 'vartabstop' into account
Problem: shiftwidth() does not take 'vartabstop' into account.
Solution: Use the cursor position or a position explicitly passed.
Also make >> and << work better with 'vartabstop'. (Christian
Brabandt)
Bram Moolenaar [Tue, 20 Nov 2018 13:27:07 +0000 (14:27 +0100)]
patch 8.1.0540: may evaluate insecure value when appending to option
Problem: May evaluate insecure value when appending to option.
Solution: Set the secure flag when changing an option that was previously
set insecurely. Also allow numbers for the characters from
'spelllang' that are used for LANG.vim.
Bram Moolenaar [Tue, 20 Nov 2018 12:32:36 +0000 (13:32 +0100)]
patch 8.1.0539: cannot build without the sandbox
Problem: Cannot build without the sandbox.
Solution: Set the secure option instead of using the sandbox. Also restrict
the characters from 'spelllang' that are used for LANG.vim.
(suggested by Yasuhiro Matsumoto)
Bram Moolenaar [Fri, 16 Nov 2018 16:44:48 +0000 (17:44 +0100)]
patch 8.1.0530: channel and terminal tests that start a server can be flaky
Problem: Channel and terminal tests that start a server can be flaky.
Solution: Add all channel and terminal tests that start a server to the list
of flaky tests.
Bram Moolenaar [Fri, 16 Nov 2018 15:52:16 +0000 (16:52 +0100)]
patch 8.1.0529: flaky test sometimes fails in different ways
Problem: Flaky test sometimes fails in different ways.
Solution: When the second run gives a different error, try running the test
again, up to five times.
Bram Moolenaar [Sat, 10 Nov 2018 15:02:01 +0000 (16:02 +0100)]
patch 8.1.0514: CTRL-W ^ does not work when alternate buffer has no name
Problem: CTRL-W ^ does not work when alternate buffer has no name.
Solution: Use another method to split and edit the alternate buffer. (Jason
Franklin)
Bram Moolenaar [Sat, 20 Oct 2018 18:54:02 +0000 (20:54 +0200)]
patch 8.1.0488: using freed memory in quickfix code
Problem: Using freed memory in quickfix code. (Dominique Pelle)
Solution: Add the quickfix_busy() flag to postpone deleting quickfix lists
until it is safe. (Yegappan Lakshmanan, closes #3538)
Bram Moolenaar [Mon, 15 Oct 2018 20:51:50 +0000 (22:51 +0200)]
patch 8.1.0479: failure when setting 'varsofttabstop' to end in a comma
Problem: Failure when setting 'varsofttabstop' to end in a comma. (Ralf
Schandl)
Solution: Reject value with trailing command. Add test for invalid values
(closes #3544)
Bram Moolenaar [Sat, 13 Oct 2018 17:06:27 +0000 (19:06 +0200)]
patch 8.1.0473: user doesn't notice file does not exist when swap file does
Problem: User doesn't notice file does not exist when swap file does.
Solution: Add a note that the file cannot be found. Make the "still
running" notice stand out.
Bram Moolenaar [Sat, 13 Oct 2018 15:25:27 +0000 (17:25 +0200)]
patch 8.1.0472: dosinst command has a few flaws
Problem: Dosinst command has a few flaws.
Solution: Register DisplayIcon, DisplayVersion and Publisher for the
uninstaller. (closes #3485) Don't set 'diffexpr' if internal diff
is supported. Allow for using Vi compatible from the command line.
Remove needless sleeps. Add comments in the generated _vimrc.
(Ken Takata, closes #3525)
Bram Moolenaar [Fri, 12 Oct 2018 20:15:12 +0000 (22:15 +0200)]
patch 8.1.0471: some tests are flaky or fail on some systems
Problem: Some tests are flaky or fail on some systems.
Solution: Increase waiting time for port number. Use "cmd /c" to execute
"echo" on win32. (Ken Takata, closes #3534)
Bram Moolenaar [Thu, 11 Oct 2018 17:27:47 +0000 (19:27 +0200)]
patch 8.1.0470: pointer ownership around fname_expand() is unclear
Problem: Pointer ownership around fname_expand() is unclear.
Solution: Allow b_ffname and b_sfname to point to the same allocated memory,
only free one. Update comments.
Bram Moolenaar [Tue, 9 Oct 2018 19:49:33 +0000 (21:49 +0200)]
patch 8.1.0468: MS-Windows: filter command with pipe character fails
Problem: MS-Windows: Filter command with pipe character fails. (Johannes
Riecken)
Solution: Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
closes #1743, closes #3523)
Bram Moolenaar [Sun, 7 Oct 2018 18:35:12 +0000 (20:35 +0200)]
patch 8.1.0462: when using ConPTY Vim can be a child process
Problem: When using ConPTY Vim can be a child process.
Solution: To find a Vim window use both EnumWindows() and
EnumChildWindows(). (Nobuhiro Takasaki, closes #3521)