Ulf Möller [Thu, 24 Feb 2000 22:23:45 +0000 (22:23 +0000)]
Use public domain snprintf() implementation by Patrick Powell to avoid
potential buffer overrun in BIO_printf().
----------------------------------------------------------------------
crypto/bio/b_print.c CVS:
----------------------------------------------------------------------
Richard Levitte [Wed, 23 Feb 2000 22:45:22 +0000 (22:45 +0000)]
Avoid saving any macros starting with a _, since that can create
trouble if header files are included in some "impropper" order.
It's much better if the application programmer has to specify on his
or her own if _REENTRANT shall be defined and when.
Ulf Möller [Tue, 22 Feb 2000 11:34:01 +0000 (11:34 +0000)]
Check tlen size in all padding_check functions. As called within the rsa
library, the output buffer always is large enough, but if the tlen
parameter is there, it should be checked in the interest of clarity,
as proposed by David Sacerdote <das33@cornell.edu>.
Bodo Möller [Mon, 21 Feb 2000 10:16:30 +0000 (10:16 +0000)]
Move MAC computations for Finished from ssl3_read_bytes into
ssl3_get_message, which is more logical (and avoids a bug,
in addition to the one that I introduced yesterday :-)
and makes Microsoft "fast SGC" less special.
MS SGC should still work now without an extra state of its own
(it goes directly to SSL3_ST_SR_CLNT_HELLO_C, which is the usual state
for reading the body of a Client Hello message), however this should
be tested to make sure, and I don't have a MS SGC client.
Richard Levitte [Sun, 20 Feb 2000 23:43:02 +0000 (23:43 +0000)]
Move the registration of callback functions to special functions
designed for that. This removes the potential error to mix data and
function pointers.
Please note that I'm a little unsure how incorrect calls to the old
ctrl functions should be handled, in som cases. I currently return 0
and that's it, but it may be more correct to generate a genuine error
in those cases.
Bodo Möller [Fri, 18 Feb 2000 11:15:32 +0000 (11:15 +0000)]
Avoid potential conflicts between #defines in opensslconf.h and
defines when compiling applications, and allow applications to
select what #defines to enable -- OPENSSL_EXLUCDE_DEFINES
enables the "#define NO_whatever" stuff only, which avoids
potential severe confusion caused by "#define _REENTRANT" when
opensslconf.h is not the first header file #included.
Bodo Möller [Thu, 17 Feb 2000 21:04:40 +0000 (21:04 +0000)]
Make sure the return value of by_file_ctrl(..., X509_L_FILE_LOAD, ...)
aka X509_LOOKUP_load_file(...) is always 0 or 1, not the counter
returned from the recently introduced function X509_load_cert_crl_file.
X509_STORE_load_locations expects X509_LOOKUP_load_file to return 1 on
success, and possibly there's other software that relies on this too.
Andy Polyakov [Tue, 15 Feb 2000 13:50:02 +0000 (13:50 +0000)]
test_mont was exercising 100-bit multiplication modulus X*I-bit, where
X is 5120 on 32-bit and 151552 on 64-bit architectures and I varies
from 0 to 4. As result the test was *unreasonably* slow and virtually
impossible to complete on 64-bit architectures (e.g. IRIX bc couldn't
even swallow such long lines).
Richard Levitte [Tue, 15 Feb 2000 09:44:54 +0000 (09:44 +0000)]
Remove the access() call altogether for VMS, since it doesn't quite
work for directory specifications (this will be reported as a bug to
DEC^H^H^HCompaq). It could as well be removed for all others as well,
since stat() and open() will return appropriate errors as well, but I
leave that to someone else to decide.
Richard Levitte [Fri, 11 Feb 2000 18:12:47 +0000 (18:12 +0000)]
A hack to make sure access() will give us the correct answer about the
accessability of an "empty" directory. Thsi *is* weird, and a better
solution will be provided in apps/ca.c, when I get time to hack at it.