contrib: enable debuggin when debug=max and disable optimizations when optimizations=none
except for ffmpeg on darwin i386 which fails to build when optimizations
are disabled due to gcc running out of registers.
libhb: improve dvdnav main feature detection
Add detection of fake menus. Some menus have very short duration and/or
are hidden from the user by making the hightlight transparent. These
menus can lead to invalid titles if traversed, so ignore them.
libhb: improve dvdnav main feature detection
Improve detection of fake titles that are transitioned through on the
way to the real title when a menu button is pressed.
back off part of the last dvdread fix
It isn't necessary, and was incorrect. I was trying to
anticipate a future problem with references outside the allocated region
for the PTT, but did it wrong. It's probably best to just wait for a disc
that exhibits this potential problem to surface before attempting a fix.
libhb: fix a stack corruption crash when scanning some BDs
was overrunning the end of a stack based array when there were more
than 32 clips in a BD title.
libhb: when doing main feature search, skip prohibited buttons.
There is a field in the prohibited user operations PCI flags that
says when the user can push buttons. If they are prohibited, we
shouldn't push them when searching for the main feature since they
would not be accessible on a dvd player.
This fixes selection of "fake" titles on some discs.
libhb: add some logging to main feature search
This lets us see in the logs if it finds a root menu title, a title menu title,
or falls back to using the longest title. Log level 2 must be enabled to
see these.
WinGui: Replace the old-school Windows 9x folder dialog with a 3rd party (ookii) control which uses the new Vista / 7 style folder dialog which is significantly easier to use.
jstebbins [Mon, 27 Jun 2011 08:54:22 +0000 (08:54 +0000)]
LinGui: fix initial enabled state of audio options after scan
audios that are disabled were not getting grayed out in the audio options
list till the track or encoder selection changed.
jstebbins [Mon, 27 Jun 2011 07:13:13 +0000 (07:13 +0000)]
LinGui: fix a problem with enabling dts and dts-hd passthru in audio options
audio_config.in.codec in these cases is HB_ACODEC_DTS* | HB_ACODEC_FF_I_FLAG.
I was not masking off the FF_I_FLAG when checking the input codec.
Note, that this problem goes away in the RB patch that cleans up ffmpeg
hacks, the FF_I_FLAG being one such hack.
jstebbins [Thu, 23 Jun 2011 09:48:38 +0000 (09:48 +0000)]
libhb: fix progress information for batch scans
Use hb_batch_title_count() since hb_list_count() changes as unreadable
titles are removed from the list. Title count needs to be the total
number of files being scanned.
jstebbins [Wed, 22 Jun 2011 16:17:54 +0000 (16:17 +0000)]
LinGui: fix appindicator warning message in log at startup
A signal that causes an indicator update happens before the indicator
has been created, triggering a warning. so check that the indicator
exists first.
jstebbins [Wed, 22 Jun 2011 14:51:32 +0000 (14:51 +0000)]
LinGui: fix scaling problem with preview window
... when the screen is smaller than the preview. If the width fit but the
height didn't, it computed incorrect size and displayed with wrong aspect.
jstebbins [Tue, 21 Jun 2011 15:32:37 +0000 (15:32 +0000)]
LinGui: when appindicator is found, disable gtkstatusicon
libappindicator has a fallback mode that creates a gtkstatusicon
automatically if the indicator service can not be contacted. so I
should only enable one or the other, not both.
jstebbins [Tue, 21 Jun 2011 10:35:55 +0000 (10:35 +0000)]
libhb: fix incorrect error message when adding substreams to ts list
The error message was meant to catch the case were a source has
more than 2 substreams in a stream. But due to incorrect order of
conditionals, it triggered when both substreams have been seen and
we try to add one of them again (which is allowed and should do nothing).
sr55 [Mon, 20 Jun 2011 20:16:12 +0000 (20:16 +0000)]
WinGui: Update the About Window GPL statement & Fix an issue on the subtitles tab where it would refuse to allow an SRT to be imported when doing a queue edit.
jstebbins [Mon, 20 Jun 2011 15:58:36 +0000 (15:58 +0000)]
LinGui: Add status tray icon support for Ubuntu 11.04
Ubuntu disables GtkStatusIcon support in Unity and instead uses a new
API called AppIndicator. So this adds support for appindicator when
it is detected by configure.
sr55 [Mon, 20 Jun 2011 14:48:07 +0000 (14:48 +0000)]
Remove the qt4 directory. Nothing useful has come from this code and too much time has passed with no-one dedicating the time it requires to be useful.
dynaflash [Tue, 14 Jun 2011 20:54:10 +0000 (20:54 +0000)]
MacGui: Don't call "return" at the end of a void function.. .. Redux!
- As Per https://reviews.handbrake.fr/r/122/
- Thanks blindjimmy for the patche(s).
- Borked commit notes courtesy of me.
dynaflash [Tue, 14 Jun 2011 20:48:15 +0000 (20:48 +0000)]
MacGui: Add blank line to previous commit files to fix the commit notes I totally borked.
- Proper change is: Simplify conditionals to make them more readable. As per https://reviews.handbrake.fr/r/123/
- Reverts commit notes for https://trac.handbrake.fr/changeset/4056 besides the update to xcode 3.2.6
dynaflash [Tue, 14 Jun 2011 20:37:17 +0000 (20:37 +0000)]
MacGui: Don't call "return" at the end of a void function.
- Generally speaking, the fewer (simple) lines of code their are, the easier it is for someone to learn/understand it, so there's no good reason to have no-op lines laying around.
- As per https://reviews.handbrake.fr/r/122/
- Also re commit the update to xcode 3.2.6 commit from https://trac.handbrake.fr/changeset/4004 which I borked later.
dynaflash [Mon, 13 Jun 2011 20:27:46 +0000 (20:27 +0000)]
MacGui: HBAudio Indentation Cleanup
- Patch by Rodeo ... Thanks!
- Change hard tabs to 4 spaces
- Place the opening bracket of if, else if, else, while and for statements on another line, not the same line as the condition.
- Xcode's Edit > Format > Re-Indent on all files.
- This patch is purely about cosmetics and indentation. There shouldn't be any change in behavior.
- As per https://reviews.handbrake.fr/r/101/
jstebbins [Sun, 12 Jun 2011 18:05:20 +0000 (18:05 +0000)]
libhb: generalize channel remapping between decoders and encoders
Decoders set the channel map of their output in hb_audio_config_t.
Encoders use this information to remap while encoding.
jstebbins [Fri, 10 Jun 2011 18:20:30 +0000 (18:20 +0000)]
libhb: clean up AVCodecContext initializations
also fixes warning message generated by libav when initializing "silence"
sample about channel layout setting.
jstebbins [Fri, 10 Jun 2011 15:31:32 +0000 (15:31 +0000)]
libhb: disable threaded ffmpeg decoding for scan
There is a bug in ffmpeg that causes a crash if you call
avcodec_open and avcodec_close repeatedly on the same AVCodecContext.
dynaflash [Thu, 9 Jun 2011 18:37:14 +0000 (18:37 +0000)]
MacGui: Increase width of main window from 754 to 960
- Increases the main window width from 754 to 960 which is an increase of 206 px. This allows more breathing room for some crowded tabs like Audio, Subtitles and Advanced. Also increased the associated views. The main prompt for this is the very crowded audio tab which recently added Gain and also could use a vbr checkbox as well as possibly an aname field. I would rather maximize the width we deem available before going to an advanced audio track popup like the lingui and wingui currently utilize.
- For now any widgets have been expanded to their nearest longest known value without truncating.
- As per review board https://reviews.handbrake.fr/r/116/
jstebbins [Thu, 9 Jun 2011 00:49:31 +0000 (00:49 +0000)]
Refresh "Normal" preset
- Changes "Normal" to use x264 --preset veryfast --profile main
Nearly doubles it's speed for little loss of file size or quality.
- remove dummy average bitrate values from all built-in presets
- adds Large File Size to the High Profile preset
jstebbins [Wed, 8 Jun 2011 21:17:31 +0000 (21:17 +0000)]
cli: Allow more flexible specification of native language in the cli
Let the user specify their native language using any of the strings
supported in the iso639_lang table.
jstebbins [Wed, 8 Jun 2011 21:15:06 +0000 (21:15 +0000)]
LinGui: move advanced audio from a dialog popup to an expander box
The expander fits on the audio tab and expands the advanced controls
when activated.
jstebbins [Tue, 7 Jun 2011 21:27:02 +0000 (21:27 +0000)]
libhb: add support for libav aac encoder (libhb only)
This generalizes the ac3 encoder to make it easy to add support
for any audio encoder that libav supports. Since ffaac is not quite
ready, the cli and gui does not expose ffaac yet.
Highlights:
- Sources with more than 20 streams (video, audio and subtitles combined)
are now supported
- Adds decoding support for 10-bit H.264
- Adds frame-based threading for H.264 and VP8
Not yet enabled in HB. See experimental patch on RB to enable.
- Quality tweaks for the AC3 encoder
- AAC encoder improvements
Not yet enabled in HB. See experimental patch on RB to enable.
- Miscellaneous other fixes and improvements
jstebbins [Tue, 7 Jun 2011 18:33:00 +0000 (18:33 +0000)]
libhb: Sort BD titles by playlist id
This makes the logs of different rips more consistent. Previously, the
order of titles was determined by the order the mpls files were written
in the PLAYLIST directory which could vary from rip to rip.
jstebbins [Sun, 5 Jun 2011 19:48:05 +0000 (19:48 +0000)]
Fix a problem with filtering and picking correct BD title
Titles that are the same except for number of chapters were being
filtered out of the title list. So sometimes you would get a BD title
that didn't seem to have any chapters.
sr55 [Fri, 3 Jun 2011 19:49:57 +0000 (19:49 +0000)]
WinGui:
- Added support for naming tracks. New text entry field on the Advanced Audio Window. (Note: May be some CLI issues that need to be fixed up for this. We'll see)
- Disabled application settings upgrade when moving from a release to a svn build. Upgrades now only work for svn -> svn builds as there has been reliability issues when upgrading from much older builds.
jstebbins [Fri, 3 Jun 2011 15:55:00 +0000 (15:55 +0000)]
LinGui: fix preview encode progress display when # previews > 10
flags array indicating that the preview had already been encoded
for live playback was limited to 10. Forgot to change it when we
started allowing more previews.
sr55 [Thu, 2 Jun 2011 19:03:17 +0000 (19:03 +0000)]
WinGui: Improvements to the AutoName functionality.
- Added more flexibility to the "{source_path}" option so that it can now be used with additional folders listed after it. e.g. "{source_path}\encoded". It is no longer limited to just that folder.
- Added an option to put todays date in the output filename "{date}"
- Some tweaks to the way warnings are displayed when using these features to make them a bit less annoying.
jstebbins [Tue, 31 May 2011 14:54:14 +0000 (14:54 +0000)]
Add patch to disable SSE in mpeg2dec for mingw64
This allows use of mpeg2dec with mingw64. From what I've read,
disabling sse in mpeg2dec will result in about 10% speed penalty.
jstebbins [Mon, 30 May 2011 16:38:08 +0000 (16:38 +0000)]
Fix gcc4.6 build error that results in a crash in sse2 code
This fixes mpeg2 decoding on fedora15 and probably also fixes
the mpeg2dec issue we saw with mingw64.
sr55 [Sun, 29 May 2011 16:19:19 +0000 (16:19 +0000)]
WinGui: Refactored the Encode Service to move any reusable code into a base class. Added a new service which will eventually work with libhb to do encodes. Currently this just contains placeholders which throw NotImplementedExceptions.
Removed the Total Elapsed Time on the Queue window since it doesn't work. This will be re-implemented later.
projects / handbrake / log