]> granicus.if.org Git - handbrake/log
handbrake
7 years agotx3g: make font size scale with video height
John Stebbins [Fri, 3 Nov 2017 18:10:02 +0000 (11:10 -0700)]
tx3g: make font size scale with video height

Fixes https://forum.handbrake.fr/viewtopic.php?f=5&t=37034

7 years ago MacGui: fix a wrong usage of CFData API, CFDataCreateMutable creates a a CFData...
Damiano Galassi [Fri, 3 Nov 2017 06:32:09 +0000 (07:32 +0100)]
 MacGui: fix a wrong usage of CFData API, CFDataCreateMutable creates a a CFData instance that can be filled up to the wanted capacity, but it doesn't set the CFData length to the capacity. Use CFDataSetLength to set the length. The original code doesn't work on 10.13.2 beta 1.

7 years agoWinGui: Fix Window Title not resetting when queue finishing.
sr55 [Thu, 2 Nov 2017 20:29:58 +0000 (20:29 +0000)]
WinGui: Fix Window Title not resetting when queue finishing.

7 years agoWinGui: Small Typo #833
sr55 [Thu, 2 Nov 2017 20:23:15 +0000 (20:23 +0000)]
WinGui: Small Typo #833

7 years agoWinGui: Adding Preset Category support into the Windows UI. Single layer support...
sr55 [Thu, 2 Nov 2017 20:21:33 +0000 (20:21 +0000)]
WinGui: Adding Preset Category support into the Windows UI. Single layer support only. #833

7 years agoCLI: add help for --align-av
John Stebbins [Thu, 2 Nov 2017 16:34:01 +0000 (09:34 -0700)]
CLI: add help for --align-av

7 years agoWinGui: Add basic deinterlace to the static preview. #958
sr55 [Mon, 30 Oct 2017 20:38:01 +0000 (20:38 +0000)]
WinGui: Add basic deinterlace to the static preview. #958

7 years agoWinGui: Change ChannelLayout to Int64 #968
sr55 [Mon, 30 Oct 2017 20:28:18 +0000 (20:28 +0000)]
WinGui: Change ChannelLayout to Int64 #968

7 years agoWinGui: Improve the behaviour of the quality slider when changing video encoder....
sr55 [Sun, 29 Oct 2017 21:47:28 +0000 (21:47 +0000)]
WinGui: Improve the behaviour of the quality slider when changing video encoder. It now updates correctly. By default it will not change value unless out of bounds. at which point it'll choose the mid-point as a default and the user can adjust as necessary.

7 years agoWinGui: Don't perform Foreign Audio Subtitle Scans for short video previews. The...
sr55 [Sun, 29 Oct 2017 21:16:33 +0000 (21:16 +0000)]
WinGui: Don't perform Foreign Audio Subtitle Scans for short video previews. The long wait to scan an entire source is not valuable for short video previews.  #877

7 years agobuild: explicitly select HFS+ as the dmg filesystem.
Damiano Galassi [Sat, 28 Oct 2017 06:25:42 +0000 (08:25 +0200)]
build: explicitly select HFS+ as the dmg filesystem.

7 years agogithub: Minor follow-up revision to issue form.
Bradley Sepos [Fri, 20 Oct 2017 05:15:55 +0000 (01:15 -0400)]
github: Minor follow-up revision to issue form.

7 years agogithub: Revise issue form prefilled text.
Bradley Sepos [Fri, 20 Oct 2017 05:10:36 +0000 (01:10 -0400)]
github: Revise issue form prefilled text.

7 years agoLinGui: fix Ubuntu 17.10 snapshots
John Stebbins [Thu, 19 Oct 2017 14:47:15 +0000 (07:47 -0700)]
LinGui: fix Ubuntu 17.10 snapshots

Compression method bzip2 is no longer supported by dpkg-deb

7 years agoLinGui: add Ubuntu 17.10 (artful) to snapshots
John Stebbins [Wed, 18 Oct 2017 17:23:41 +0000 (10:23 -0700)]
LinGui: add Ubuntu 17.10 (artful) to snapshots

Final 17.10 release is tomorrow...

7 years agoLinGui: remove Ubuntu 15.04 (vivid) snapshots
John Stebbins [Tue, 17 Oct 2017 16:00:46 +0000 (09:00 -0700)]
LinGui: remove Ubuntu 15.04 (vivid) snapshots

It's no longer supported by Ubuntu launchpad

7 years agoUpdate libmfx to 5d6f1b6 (Based on upstream 1.23)
sr55 [Sat, 14 Oct 2017 11:16:15 +0000 (12:16 +0100)]
Update libmfx to 5d6f1b6  (Based on upstream 1.23)

7 years agoQSV: Main10 should be default profile
maxd [Mon, 9 Oct 2017 09:04:01 +0000 (11:04 +0200)]
QSV: Main10 should be default profile

7 years agoWinGui: Fix a culture issue with Framerates. Fixes #926
sr55 [Thu, 12 Oct 2017 19:09:15 +0000 (20:09 +0100)]
WinGui: Fix a culture issue with Framerates. Fixes #926

7 years agoMacGui: Disable implicit animations on 10.9 and earlier.
Damiano Galassi [Wed, 11 Oct 2017 20:05:43 +0000 (22:05 +0200)]
MacGui: Disable implicit animations on 10.9 and earlier.

7 years agoMSYS compilation on Windows and for Windows
maxd [Mon, 24 Jul 2017 14:24:49 +0000 (16:24 +0200)]
MSYS compilation on Windows and for Windows

7 years agocontrib: Update to Libav 12.2.
Bradley Sepos [Mon, 2 Oct 2017 02:19:47 +0000 (22:19 -0400)]
contrib: Update to Libav 12.2.

7 years agoWinGui; Implement a smarter Title Case Algorithm. This may resolve #922
sr55 [Sun, 1 Oct 2017 14:11:21 +0000 (15:11 +0100)]
WinGui; Implement a smarter Title Case Algorithm. This may resolve #922

7 years agoWinGui: Code tidyup / tweaks around presets.
sr55 [Fri, 22 Sep 2017 21:54:41 +0000 (22:54 +0100)]
WinGui: Code tidyup / tweaks around presets.

7 years agoWinGui: Change the Preset Selection to a Menu based design as it offers faster naviga...
sr55 [Fri, 22 Sep 2017 21:02:54 +0000 (22:02 +0100)]
WinGui: Change the Preset Selection to a Menu based design as it offers faster navigation than 2 dropdowns.

7 years agoWinGui: Remove the in-line queue view preference. It does not make sense with the...
sr55 [Wed, 20 Sep 2017 18:41:55 +0000 (19:41 +0100)]
WinGui: Remove the in-line queue view preference. It does not make sense with the new design flow of the main screen.

7 years agoWinGui: Tidy up some warnings that you get when you import WinGui presets into the...
sr55 [Wed, 20 Sep 2017 18:25:37 +0000 (19:25 +0100)]
WinGui: Tidy up some warnings that you get when you import WinGui presets into the CLI. #906

7 years agoQSV: Adding D11 support for encode
maxd [Wed, 13 Sep 2017 19:24:49 +0000 (21:24 +0200)]
QSV: Adding D11 support for encode

7 years agoWinGui: Experimenting with InLine vs Preset Pane designs.
sr55 [Sun, 17 Sep 2017 15:13:31 +0000 (16:13 +0100)]
WinGui: Experimenting with InLine vs Preset Pane designs.

7 years agoWinGui: Initial ground work on code that will detect when the user modifies settings...
sr55 [Sun, 17 Sep 2017 14:43:47 +0000 (15:43 +0100)]
WinGui: Initial ground work on code that will detect when the user modifies settings that don't match the currently selected preset.

7 years agoWinGui: Tweak Stylecop.json to add header decoration.
sr55 [Mon, 11 Sep 2017 19:03:36 +0000 (20:03 +0100)]
WinGui: Tweak Stylecop.json to add header decoration.

7 years agoMacGui: end fields editing before the filename check.
Damiano Galassi [Fri, 15 Sep 2017 11:58:02 +0000 (13:58 +0200)]
MacGui: end fields editing before the filename check.

7 years agoWinGui: Improve selection behaviour of the new preset controls.
sr55 [Mon, 11 Sep 2017 18:48:03 +0000 (19:48 +0100)]
WinGui: Improve selection behaviour of the new preset controls.

7 years agoWinGui: Add description tooltip to presets dropdown menu. Also change "User Presets...
sr55 [Sun, 10 Sep 2017 19:39:26 +0000 (20:39 +0100)]
WinGui: Add description tooltip to presets dropdown menu. Also change "User Presets" to "Custom Presets".  Existing presets won't have their category changed.

7 years agoWinGui: Restore Rename / Remove preset options on the More dropdown button. Make...
sr55 [Sun, 10 Sep 2017 18:36:58 +0000 (19:36 +0100)]
WinGui: Restore Rename / Remove preset options on the More dropdown button. Make selected preset italic with "(default)"  when default #833

7 years agoWinGui: Fix Custom Deinterlace / Decomb / Comb Detect preset options
sr55 [Sat, 9 Sep 2017 15:00:01 +0000 (16:00 +0100)]
WinGui: Fix Custom Deinterlace / Decomb / Comb Detect preset options

7 years agoWinGui: Summary Tab Font/Size changes.
sr55 [Fri, 8 Sep 2017 21:28:09 +0000 (22:28 +0100)]
WinGui: Summary Tab Font/Size changes.

7 years agoWinGui: Round FPS to 2dp on Source Info Text.
sr55 [Fri, 8 Sep 2017 21:25:41 +0000 (22:25 +0100)]
WinGui: Round FPS to 2dp on Source Info Text.

7 years agoWinGui: Change the Audio and Subtitle Tab's "Add" Split Button" to a Dropdown Button...
sr55 [Fri, 8 Sep 2017 21:23:55 +0000 (22:23 +0100)]
WinGui: Change the Audio and Subtitle Tab's "Add" Split Button" to a Dropdown Button with a system native feel. The legacy button was always styled to Windows 7 regardless of platform. This resolves that issue.

7 years agoWinGui: Code Style cleanup.
sr55 [Fri, 8 Sep 2017 21:16:04 +0000 (22:16 +0100)]
WinGui: Code Style cleanup.

7 years agoWinGui: Implementing the new Preset design that does away with the legacy style prese...
sr55 [Fri, 8 Sep 2017 21:14:26 +0000 (22:14 +0100)]
WinGui: Implementing the new Preset design that does away with the legacy style preset pane and re-arranges parts of the main window for better process flow.

7 years agoWinGui: Fix a grid scaling issue on the audio defaults pane.
sr55 [Fri, 8 Sep 2017 20:01:37 +0000 (21:01 +0100)]
WinGui: Fix a grid scaling issue on the audio defaults pane.

7 years agoMacGui: move the filters to a separate tab.
Damiano Galassi [Thu, 7 Sep 2017 07:40:50 +0000 (09:40 +0200)]
MacGui: move the filters to a separate tab.

7 years agoRemove spaces and square brackets from Xcode scheme names. Add a distribution scheme...
Damiano Galassi [Thu, 7 Sep 2017 07:02:14 +0000 (09:02 +0200)]
Remove spaces and square brackets from Xcode scheme names. Add a distribution scheme that builds only the gui.

7 years agoWinGui: Change some json model data types from int to long #851
sr55 [Wed, 6 Sep 2017 18:47:14 +0000 (19:47 +0100)]
WinGui: Change some json model data types from int to long #851

7 years agoWinGui: Add BeforeBuild Step to copy required files for the AppX generator project
sr55 [Sun, 3 Sep 2017 17:53:29 +0000 (18:53 +0100)]
WinGui: Add BeforeBuild Step to copy required files for the AppX generator project

7 years agocontrib: Patch fribidi bootstrap to quote directory variable.
Bradley Sepos [Wed, 6 Sep 2017 18:04:17 +0000 (14:04 -0400)]
contrib: Patch fribidi bootstrap to quote directory variable.

7 years agobuild: Quote variables in xcodemake.
Bradley Sepos [Wed, 6 Sep 2017 17:42:32 +0000 (13:42 -0400)]
build: Quote variables in xcodemake.

Partially fixes building in Xcode via Product > Archive.

7 years agoCLI: fix integer wrapping of p-to-p start/end times
John Stebbins [Wed, 6 Sep 2017 17:39:31 +0000 (10:39 -0700)]
CLI: fix integer wrapping of p-to-p start/end times

7 years agoLinGui: Add filter validation for sharpen and comb detect
John Stebbins [Wed, 6 Sep 2017 17:09:43 +0000 (10:09 -0700)]
LinGui: Add filter validation for sharpen and comb detect

7 years agoLinGui: fix comb detect custom settings tooltip
John Stebbins [Wed, 6 Sep 2017 17:09:08 +0000 (10:09 -0700)]
LinGui: fix comb detect custom settings tooltip

7 years agoWinGui: AppX Builder: Adding pre-build event to copy the latest release files to...
sr55 [Sun, 3 Sep 2017 16:46:53 +0000 (17:46 +0100)]
WinGui: AppX Builder: Adding pre-build event to copy the latest release files to the win32 folder.

7 years agoWinGui: Fix UwpDetect
sr55 [Sun, 3 Sep 2017 16:46:11 +0000 (17:46 +0100)]
WinGui: Fix UwpDetect

7 years agoWinGui: Optimise the png assets.
sr55 [Sun, 3 Sep 2017 16:26:37 +0000 (17:26 +0100)]
WinGui: Optimise the png assets.

7 years agoWinGui: Adding a new project to allow us to easily generate AppX packages.
sr55 [Sun, 3 Sep 2017 16:21:38 +0000 (17:21 +0100)]
WinGui: Adding a new project to allow us to easily generate AppX packages.

7 years agoLinGui: fix "More Settings" tooltip updates
John Stebbins [Sat, 2 Sep 2017 00:16:40 +0000 (17:16 -0700)]
LinGui: fix "More Settings" tooltip updates

The tooltip was not updating when the video preset slider changed

7 years agoMacGui: move the color space code out of HBCore.
Damiano Galassi [Thu, 31 Aug 2017 08:04:28 +0000 (10:04 +0200)]
MacGui: move the color space code out of HBCore.

7 years agoWinGui: Complete the SourceMetadata object.
sr55 [Wed, 30 Aug 2017 20:41:29 +0000 (21:41 +0100)]
WinGui: Complete the SourceMetadata object.

7 years agoWinGui: Putting paused duration infrastructure in place
sr55 [Wed, 30 Aug 2017 19:41:13 +0000 (20:41 +0100)]
WinGui: Putting paused duration infrastructure in place

7 years agoWinGui: Some consistency fixes and UI tweaks around queue start/pause/stop.
sr55 [Wed, 30 Aug 2017 19:26:45 +0000 (20:26 +0100)]
WinGui: Some consistency fixes and UI tweaks around queue start/pause/stop.

7 years agoWinGui: Putting in some back-end infrastructure into the queue screen to support...
sr55 [Mon, 28 Aug 2017 14:16:40 +0000 (15:16 +0100)]
WinGui: Putting in some back-end infrastructure into the queue screen to support future features + some misc tidy up.

7 years agoAdding another .NET file to gitignore
sr55 [Mon, 28 Aug 2017 14:04:36 +0000 (15:04 +0100)]
Adding another .NET file to gitignore

7 years agoWinGui: Fixes to chapters tab to correctly handle queue edit jobs. Fixes #870
sr55 [Sat, 26 Aug 2017 20:28:23 +0000 (21:28 +0100)]
WinGui: Fixes to chapters tab to correctly handle queue edit jobs. Fixes #870

7 years agoWinGui: Use ExecWait instead of Exec for the installer. This should prevent the insta...
sr55 [Sat, 26 Aug 2017 20:15:14 +0000 (21:15 +0100)]
WinGui: Use ExecWait instead of Exec for the installer. This should prevent the install from continuing until the uninstall process has completed.

7 years agoWinGui: Various improvements and fixes to the new summary tab. Revert tab order chang...
sr55 [Sat, 26 Aug 2017 20:03:04 +0000 (21:03 +0100)]
WinGui: Various improvements and fixes to the new summary tab. Revert tab order change.  #833

7 years agocontrib: Replace Yadif patch with final Libav version.
Bradley Sepos [Thu, 24 Aug 2017 07:53:20 +0000 (03:53 -0400)]
contrib: Replace Yadif patch with final Libav version.

Patch was modified before landing in Libav. Previous commit was 9fd048196eb423965496c14dac683e6e2546e14f. #576

7 years agoWinGui: Summary Tab - Make the preview controls operational. #833
sr55 [Wed, 23 Aug 2017 21:32:28 +0000 (22:32 +0100)]
WinGui: Summary Tab - Make the preview controls operational. #833

7 years agoWinGui: Put the Video Tab after the Summary tab rather than the Pictures tab. Consis...
sr55 [Wed, 23 Aug 2017 20:02:08 +0000 (21:02 +0100)]
WinGui: Put the Video Tab after the Summary tab rather than the Pictures tab.  Consistent with the Mac UI. #833

7 years agoWinGui: Hide the Preview Count on the Summary tab until preview scrolling is implemented.
sr55 [Wed, 23 Aug 2017 19:58:17 +0000 (20:58 +0100)]
WinGui: Hide the Preview Count on the Summary tab until preview scrolling is implemented.

7 years agoWinGui: Implement "Open Source" and "Open Destination" on the Queue context menu...
sr55 [Wed, 23 Aug 2017 19:57:26 +0000 (20:57 +0100)]
WinGui: Implement "Open Source" and "Open Destination" on the Queue context menu. #863

7 years agoWinGui: Add basic source information to the main window. #833
sr55 [Wed, 23 Aug 2017 19:04:58 +0000 (20:04 +0100)]
WinGui: Add basic source information to the main window. #833

7 years agoWinGui: Initial implementation of the Summary Tab. This may be subject to change...
sr55 [Wed, 23 Aug 2017 18:40:20 +0000 (19:40 +0100)]
WinGui: Initial implementation of the Summary Tab. This may be subject to change. #833

7 years agocontrib: Fix memory corruption in Libav Yadif filter.
Bradley Sepos [Fri, 18 Aug 2017 22:49:15 +0000 (18:49 -0400)]
contrib: Fix memory corruption in Libav Yadif filter.

Fixes #576.

7 years agocontrib: Update to libbluray 1.0.1.
Bradley Sepos [Mon, 10 Jul 2017 19:38:00 +0000 (15:38 -0400)]
contrib: Update to libbluray 1.0.1.

BD-J is always enabled now, so add patch to fix symbols under mingw.

7 years agoWinGui: Improve the QueueTask Surrogate key. It now contains a session id to prevent...
sr55 [Fri, 18 Aug 2017 21:04:57 +0000 (22:04 +0100)]
WinGui: Improve the QueueTask Surrogate key. It now contains a session id to prevent issues with the queue reloads.

7 years agoWinGui: Make the app UWP aware. When in a UWP container, the update options will...
sr55 [Fri, 18 Aug 2017 20:50:54 +0000 (21:50 +0100)]
WinGui: Make the app UWP aware. When in a UWP container, the update options will now be disabled.

7 years agoWinGui: Give the QueueTask object a distinct surrogate key #854
sr55 [Fri, 18 Aug 2017 19:39:51 +0000 (20:39 +0100)]
WinGui: Give the QueueTask object a distinct surrogate key  #854

7 years agocontrib: Fix Libav H.264 decoder pixelation in scenes with solid colors.
Bradley Sepos [Fri, 18 Aug 2017 13:47:54 +0000 (09:47 -0400)]
contrib: Fix Libav H.264 decoder pixelation in scenes with solid colors.

Fixes #787.

7 years agoWinGui: Add signing support to build.xml
sr55 [Tue, 8 Aug 2017 21:24:56 +0000 (22:24 +0100)]
WinGui: Add signing support to build.xml

7 years agoUpdate gitignore
sr55 [Tue, 8 Aug 2017 20:42:25 +0000 (21:42 +0100)]
Update gitignore

7 years agodecomb: add an additional null check to avoid a crash if the filter receive the EOF...
Damiano Galassi [Mon, 7 Aug 2017 05:14:40 +0000 (07:14 +0200)]
decomb: add an additional null check to avoid a crash if the filter receive the EOF flag before reciving a valid frame.

7 years agocontrib: Update to x265 2.5.
Bradley Sepos [Fri, 14 Jul 2017 07:33:55 +0000 (03:33 -0400)]
contrib: Update to x265 2.5.

Adds patch to workaround define issue for mingw.

7 years agoMacGui: sanitise modulus values.
Damiano Galassi [Sun, 6 Aug 2017 16:36:14 +0000 (18:36 +0200)]
MacGui: sanitise modulus values.

7 years agoLinGui: rework audio/subtitle tabs gtk < 3.16
John Stebbins [Fri, 4 Aug 2017 23:57:23 +0000 (16:57 -0700)]
LinGui: rework audio/subtitle tabs gtk < 3.16

Add support for older gtk versions

7 years agoLinGui: rework audio/subtitle tabs
John Stebbins [Fri, 4 Aug 2017 22:36:59 +0000 (15:36 -0700)]
LinGui: rework audio/subtitle tabs

Combine track selection and track list into a single pane with it's own
stack switcher.

7 years agoLinGUI: Consistently capitalize Web Optimized.
Bradley Sepos [Wed, 26 Jul 2017 21:32:35 +0000 (17:32 -0400)]
LinGUI: Consistently capitalize Web Optimized.

7 years agoLinGUI: Reorder Align A/V Start control.
Bradley Sepos [Wed, 26 Jul 2017 21:29:32 +0000 (17:29 -0400)]
LinGUI: Reorder Align A/V Start control.

7 years agoscripts: Periodically update sudo timeout while building Mac toolchain.
Bradley Sepos [Fri, 4 Aug 2017 17:03:08 +0000 (13:03 -0400)]
scripts: Periodically update sudo timeout while building Mac toolchain.

Should help avoid excessive password prompts should certain tools (CMake) take awhile to build.

7 years agoRemove custom header
Scott [Tue, 1 Aug 2017 19:59:09 +0000 (20:59 +0100)]
Remove custom header

Allow GitHub to correctly identify the license.

7 years agoWinGui: Fix an issue that was causing the handles to the scan libhb instance to be...
sr55 [Fri, 28 Jul 2017 19:24:53 +0000 (20:24 +0100)]
WinGui: Fix an issue that was causing the handles to the scan libhb instance to be recycle'd while it was still in use.  Fixes #844 and #836

7 years agoMacGUI: Add Align A/V Start to Queue info.
Bradley Sepos [Wed, 26 Jul 2017 21:23:18 +0000 (17:23 -0400)]
MacGUI: Add Align A/V Start to Queue info.

7 years agoMacGUI: Capitalize Web Optimized and iPod 5G Support.
Bradley Sepos [Wed, 26 Jul 2017 21:20:25 +0000 (17:20 -0400)]
MacGUI: Capitalize Web Optimized and iPod 5G Support.

7 years agoWinGUI: Reorder Align A/V Start control.
Bradley Sepos [Wed, 26 Jul 2017 20:11:24 +0000 (16:11 -0400)]
WinGUI: Reorder Align A/V Start control.

7 years agoMacGui: update the main window browse button tooltip.
Damiano Galassi [Wed, 26 Jul 2017 14:15:44 +0000 (16:15 +0200)]
MacGui: update the main window browse button tooltip.

7 years agoMacGui: mark some preview's layers as opaque.
Damiano Galassi [Wed, 26 Jul 2017 14:05:34 +0000 (16:05 +0200)]
MacGui: mark some preview's layers as opaque.

7 years agoMacGui: allow crop values to be larger than sourceValue / 2
Damiano Galassi [Wed, 26 Jul 2017 09:44:38 +0000 (11:44 +0200)]
MacGui: allow crop values to be larger than sourceValue / 2

7 years agoWinGUI: Really update NLMeans tooltip.
Bradley Sepos [Mon, 24 Jul 2017 18:33:40 +0000 (14:33 -0400)]
WinGUI: Really update NLMeans tooltip.

7 years agoMacGUI, WinGUI: Add NLMeans threads parameter to syntax in tooltips.
Bradley Sepos [Mon, 24 Jul 2017 17:59:30 +0000 (13:59 -0400)]
MacGUI, WinGUI: Add NLMeans threads parameter to syntax in tooltips.

Windows should fetch this dynamically but I updated the related comment for good measure.

7 years agolibhb: Add threads parameter to NLMeans.
Bradley Sepos [Mon, 24 Jul 2017 17:14:32 +0000 (13:14 -0400)]
libhb: Add threads parameter to NLMeans.

Allows setting number of frames to process in parallel. For testing and experts wanting to fine tune the pipeline; e.g., fewer NLMeans threads may make x265 run slightly faster. Realistically, the defaults are the best choice for most everyone.

7 years agocontrib: Use https mirror for libxml2.
Bradley Sepos [Sun, 23 Jul 2017 10:48:11 +0000 (06:48 -0400)]
contrib: Use https mirror for libxml2.