]> granicus.if.org Git - php/log
php
5 years agoFix file conflicts in SplFileObject fputcsv tests
Nikita Popov [Mon, 17 Jun 2019 13:08:52 +0000 (15:08 +0200)]
Fix file conflicts in SplFileObject fputcsv tests

5 years agoRemove XFAIL mark
Dmitry Stogov [Mon, 17 Jun 2019 11:56:28 +0000 (14:56 +0300)]
Remove XFAIL mark

5 years agoAvoid uninitilized field access
Dmitry Stogov [Mon, 17 Jun 2019 11:53:44 +0000 (14:53 +0300)]
Avoid uninitilized field access

5 years agoFixed memory leaks in ext/ffi/tests/100.phpt on Mac OSX
Dmitry Stogov [Mon, 17 Jun 2019 11:40:19 +0000 (14:40 +0300)]
Fixed memory leaks in ext/ffi/tests/100.phpt on Mac OSX

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 17 Jun 2019 11:31:04 +0000 (13:31 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 17 Jun 2019 11:30:56 +0000 (13:30 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoAccept null for preg_quote delimiter argument
Nikita Popov [Mon, 17 Jun 2019 11:30:15 +0000 (13:30 +0200)]
Accept null for preg_quote delimiter argument

Related to bug #78163.

5 years agoSimplify pm.start_servers calculation in docs
Freddie Leeman [Tue, 11 Jun 2019 15:25:07 +0000 (17:25 +0200)]
Simplify pm.start_servers calculation in docs

This makes it more obvious that this is just the average.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 17 Jun 2019 11:14:18 +0000 (13:14 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoAdd syslog.filter=raw
Erik Lundin [Sat, 15 Jun 2019 07:31:16 +0000 (09:31 +0200)]
Add syslog.filter=raw

This passes through syslog message unchanged, without splitting
messages at newlines.

5 years agoAdd debug output to posix_getlogin() test
Nikita Popov [Mon, 17 Jun 2019 11:05:59 +0000 (13:05 +0200)]
Add debug output to posix_getlogin() test

5 years agoMake ext/curl/tests/bug48203_multi.phpt more robust
Nikita Popov [Mon, 17 Jun 2019 10:43:45 +0000 (12:43 +0200)]
Make ext/curl/tests/bug48203_multi.phpt more robust

We don't have a guarantee in which order the output here will
occur. And it's not really relevant for the test anyway, so use a
wildcard.

5 years agoRemove unnecessary short_open_tags use in tokenizer test
George Peter Banyard [Fri, 14 Jun 2019 17:52:27 +0000 (19:52 +0200)]
Remove unnecessary short_open_tags use in tokenizer test

5 years agoEnable intl on macos
Nikita Popov [Mon, 17 Jun 2019 09:28:31 +0000 (11:28 +0200)]
Enable intl on macos

5 years agobugs in fpm logging #4273 #4007
Joe Watkins [Sun, 16 Jun 2019 06:24:32 +0000 (08:24 +0200)]
bugs in fpm logging #4273 #4007

5 years agoUse uint64_t for time_sleep_until calculations
Nikita Popov [Sun, 16 Jun 2019 14:14:30 +0000 (16:14 +0200)]
Use uint64_t for time_sleep_until calculations

5 years agoPrevent parallel test conflict
Christoph M. Becker [Sun, 16 Jun 2019 09:48:48 +0000 (11:48 +0200)]
Prevent parallel test conflict

Cf. <https://travis-ci.org/php/php-src/jobs/546112543#L2865-L2866>.

5 years agothis mtime comparison makes assumptions that cannot always hold true
Joe Watkins [Sun, 16 Jun 2019 06:29:04 +0000 (08:29 +0200)]
this mtime comparison makes assumptions that cannot always hold true

5 years agogettimeofday cannot be used to reliably implement high precision process synchronization
Joe Watkins [Sun, 16 Jun 2019 05:02:28 +0000 (07:02 +0200)]
gettimeofday cannot be used to reliably implement high precision process synchronization

The use of gettimeofday in time_sleep_until is technically incorrect, it's not possible
to use gettimeofday in this way reliably on any platform: It relies on operating system
global structures, which may be modified by any other process on the system at any time.

While in practice, users may be ignoring this flaw, it entirely depends on the other software
running on the system to which the application is deployed, there is no possible way to write
a test that will always pass on any system, therefore it must be marked XFAIL.

5 years agoSet correct default version
Anatol Belski [Sat, 15 Jun 2019 15:39:13 +0000 (17:39 +0200)]
Set correct default version

5 years agoPHP-7.4 branch should not run JIT tests, ever [ci skip]
Joe Watkins [Sat, 15 Jun 2019 08:06:51 +0000 (10:06 +0200)]
PHP-7.4 branch should not run JIT tests, ever [ci skip]

5 years agoThis test is flaky, and some of it doesn't make sense.
Joe Watkins [Sat, 15 Jun 2019 07:57:51 +0000 (09:57 +0200)]
This test is flaky, and some of it doesn't make sense.

I've refactored based on the original bug report, related bugs, and commits
to php-src that were related to them.

It is supposed to be testing windows specific behaviour related to non-blocking pipes,
nevertheless the test runs everywhere.

5 years agoRemove dead code in sockets extension [ci skip]
George Peter Banyard [Fri, 14 Jun 2019 17:01:02 +0000 (19:01 +0200)]
Remove dead code in sockets extension [ci skip]

5 years agofix flaky socket tests
Joe Watkins [Sat, 15 Jun 2019 06:08:08 +0000 (08:08 +0200)]
fix flaky socket tests

5 years agoRemove file/005_variation.phpt
Nikita Popov [Fri, 14 Jun 2019 15:06:47 +0000 (17:06 +0200)]
Remove file/005_variation.phpt

As this test doesn't check differences in times before and after
operations, it doesn't actually verify anything and just wastes
30 seconds of test time.

As we already have other tests that do check how stat times change,
I'm removing it entirely.

5 years agoMake curl_multi_info_read.phpt more robust
Nikita Popov [Fri, 14 Jun 2019 14:55:51 +0000 (16:55 +0200)]
Make curl_multi_info_read.phpt more robust

I don't think there's any need to make remote connections here
(and bugs.php.net is down right now...) so just use local files
instead.

5 years agoRemove useless param in php_snmp_error()
George Peter Banyard [Wed, 12 Jun 2019 19:27:49 +0000 (21:27 +0200)]
Remove useless param in php_snmp_error()

It is always NULL.

5 years agoFix compilation without deprecated OpenSSL 1.1 APIs
Rosen Penev [Sat, 27 Apr 2019 18:17:28 +0000 (11:17 -0700)]
Fix compilation without deprecated OpenSSL 1.1 APIs

5 years agodisable this test temporarily
Joe Watkins [Fri, 14 Jun 2019 12:22:25 +0000 (14:22 +0200)]
disable this test temporarily

5 years agoTurn add_index_zval and add_next_index_zval into inline function
twosee [Tue, 11 Jun 2019 14:07:32 +0000 (22:07 +0800)]
Turn add_index_zval and add_next_index_zval into inline function

Avoids expression warnings and allows explicitly namespaced use in
C++.

Closes GH-4250.

5 years agoMerge branch 'mac-tests' into PHP-7.4
Joe Watkins [Fri, 14 Jun 2019 10:56:08 +0000 (12:56 +0200)]
Merge branch 'mac-tests' into PHP-7.4

* mac-tests:
  fix mac tests on azure

5 years agofix mac tests on azure
Joe Watkins [Thu, 13 Jun 2019 09:28:46 +0000 (11:28 +0200)]
fix mac tests on azure

5 years agoFix SNMP build warnings
Nikita Popov [Fri, 14 Jun 2019 10:44:54 +0000 (12:44 +0200)]
Fix SNMP build warnings

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Dmitry Stogov [Fri, 14 Jun 2019 10:29:40 +0000 (13:29 +0300)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Backport 96a12578c13b5c37195b10526fcdc669b795644d

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Dmitry Stogov [Fri, 14 Jun 2019 10:29:30 +0000 (13:29 +0300)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Backport 96a12578c13b5c37195b10526fcdc669b795644d

5 years agoBackport 96a12578c13b5c37195b10526fcdc669b795644d
Dmitry Stogov [Fri, 14 Jun 2019 10:29:13 +0000 (13:29 +0300)]
Backport 96a12578c13b5c37195b10526fcdc669b795644d

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Dmitry Stogov [Fri, 14 Jun 2019 10:26:04 +0000 (13:26 +0300)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Backport 91a6cdbff5ebd1ca4db1d6e8c42d3265ce80ace4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Dmitry Stogov [Fri, 14 Jun 2019 10:25:06 +0000 (13:25 +0300)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Backport 91a6cdbff5ebd1ca4db1d6e8c42d3265ce80ace4

5 years agoBackport 91a6cdbff5ebd1ca4db1d6e8c42d3265ce80ace4
Dmitry Stogov [Fri, 14 Jun 2019 10:24:47 +0000 (13:24 +0300)]
Backport 91a6cdbff5ebd1ca4db1d6e8c42d3265ce80ace4

5 years agoMore edge case fixes that may cause bug #78106
Dmitry Stogov [Fri, 14 Jun 2019 10:10:02 +0000 (13:10 +0300)]
More edge case fixes that may cause bug #78106

5 years agoAttempt to fix edge conditions that may cause bug #78106
Dmitry Stogov [Fri, 14 Jun 2019 09:47:22 +0000 (12:47 +0300)]
Attempt to fix edge conditions that may cause bug #78106

5 years agoImplement numeric literal separators
Theodore Brown [Thu, 2 May 2019 17:10:19 +0000 (12:10 -0500)]
Implement numeric literal separators

RFC: https://wiki.php.net/rfc/numeric_literal_separator

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Fri, 14 Jun 2019 09:13:15 +0000 (11:13 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoFix some leaks in ldap
Nikita Popov [Fri, 14 Jun 2019 09:11:24 +0000 (11:11 +0200)]
Fix some leaks in ldap

The result of zval_get_string() needs to be released. In some places
where it is inconvenient to manage, I went back to convert_to_string.
It is safe in those places due to existing array separations.

Also fix a preexisting leak when getting controls, the previous
value was not destroyed.

5 years agoFix skipif syntax errors
Nikita Popov [Fri, 14 Jun 2019 07:29:14 +0000 (09:29 +0200)]
Fix skipif syntax errors

Apparently I did this only on masster...

5 years agodisable phpdbg on i386 builds [ci skip]
Joe Watkins [Fri, 14 Jun 2019 06:30:20 +0000 (08:30 +0200)]
disable phpdbg on i386 builds [ci skip]

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Côme Chilliet [Thu, 13 Jun 2019 20:15:13 +0000 (22:15 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Some more string conversion handling, fixing bug #77958
  Avoid converting zval when not needed

5 years agoSome more string conversion handling, fixing bug #77958
Côme Chilliet [Thu, 13 Jun 2019 20:12:34 +0000 (22:12 +0200)]
Some more string conversion handling, fixing bug #77958

5 years agoAvoid converting zval when not needed
Côme Chilliet [Thu, 13 Jun 2019 18:58:45 +0000 (20:58 +0200)]
Avoid converting zval when not needed

Also added exception checks so that exception from __toString are
 correctly handled in the future

5 years agoRevert "ext/standard: Use PKG_CHECK_MODULES to detect the Argon2 library"
Nikita Popov [Thu, 13 Jun 2019 14:50:57 +0000 (16:50 +0200)]
Revert "ext/standard: Use PKG_CHECK_MODULES to detect the Argon2 library"

This reverts commit bdcef51bcb367323f2eea4808f34a1b3e58bd3d8.

It seems that pkg-config support for libargon2 is still flaky:
 * No pc file on Alpine.
 * Custom builds of released libargon2 versions create a broken
   pc file. This is fixed in master, but not released.

Go back to the old detection code for now.

5 years agoCondition some azure jobs on schedule trigger
Nikita Popov [Thu, 13 Jun 2019 12:20:47 +0000 (14:20 +0200)]
Condition some azure jobs on schedule trigger

5 years agoAdd BMP support to PHP info
Christoph M. Becker [Thu, 13 Jun 2019 11:03:58 +0000 (13:03 +0200)]
Add BMP support to PHP info

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Thu, 13 Jun 2019 10:54:10 +0000 (12:54 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Thu, 13 Jun 2019 10:52:22 +0000 (12:52 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFixed bug #78106
Nikita Popov [Thu, 13 Jun 2019 10:51:35 +0000 (12:51 +0200)]
Fixed bug #78106

When disabling opcache during the request via opcache.enable ini
setting, make sure we also disable ZCG(accelerator_enabled).

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Thu, 13 Jun 2019 10:40:23 +0000 (12:40 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Thu, 13 Jun 2019 10:38:57 +0000 (12:38 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoAdd test for bug #78106
Nikita Popov [Thu, 13 Jun 2019 10:35:29 +0000 (12:35 +0200)]
Add test for bug #78106

Also add PHP_TEST_EXTRA_ARGS environment variable, which allows
to pass on -c, -d etc flags provided by run-tests.php. Otherwise
we won't get the built-in server to run with opcache.

5 years agoFixed bug #78154
Nikita Popov [Thu, 13 Jun 2019 08:59:01 +0000 (10:59 +0200)]
Fixed bug #78154

5 years agoFixed bug #78151
Nikita Popov [Thu, 13 Jun 2019 07:37:30 +0000 (09:37 +0200)]
Fixed bug #78151

5 years agoDon't throw warning if testing multiple ports
Nikita Popov [Wed, 12 Jun 2019 14:57:28 +0000 (16:57 +0200)]
Don't throw warning if testing multiple ports

5 years agotest for bug #78151
Joe Watkins [Wed, 12 Jun 2019 20:39:00 +0000 (22:39 +0200)]
test for bug #78151

5 years agoRevert "micro-optimization"
Joe Watkins [Wed, 12 Jun 2019 18:04:47 +0000 (20:04 +0200)]
Revert "micro-optimization"

This reverts commit 374f7699821eb723a3a82a9854d18c0530b9d4e9.

5 years agoEnable -Werror on macos builds
Nikita Popov [Wed, 12 Jun 2019 13:30:44 +0000 (15:30 +0200)]
Enable -Werror on macos builds

5 years agoFix ext/exif/tests/bug76557.phpt for 32-bit builds
Nikita Popov [Wed, 12 Jun 2019 13:39:30 +0000 (15:39 +0200)]
Fix ext/exif/tests/bug76557.phpt for 32-bit builds

The error message is different there.

5 years agoDon't warn if libcurl SSL library not detected
Nikita Popov [Wed, 12 Jun 2019 13:26:06 +0000 (15:26 +0200)]
Don't warn if libcurl SSL library not detected

libcurl may link against 7 different ssl libraries, all of which
are thread-safe -- apart from openssl, of course. We check for
openssl and register locking callbacks in that case, but we should
not warn if any other library is used.

5 years agoMerge branch 'PHP-7.4' of git://github.com/php/php-src into PHP-7.4
Joe Watkins [Wed, 12 Jun 2019 13:10:49 +0000 (15:10 +0200)]
Merge branch 'PHP-7.4' of git://github.com/php/php-src into PHP-7.4

5 years agowe are not running database tests on macos, there is no need to install mysql or...
Joe Watkins [Wed, 12 Jun 2019 13:09:41 +0000 (15:09 +0200)]
we are not running database tests on macos, there is no need to install mysql or start pg

5 years agowe are not running database tests on macos, there is no need to install mysql or...
Joe Watkins [Wed, 12 Jun 2019 12:36:12 +0000 (14:36 +0200)]
we are not running database tests on macos, there is no need to install mysql or start pg

5 years agoFix unsigned char mismatch
Nikita Popov [Wed, 12 Jun 2019 12:58:06 +0000 (14:58 +0200)]
Fix unsigned char mismatch

5 years agoMake ATTRIBUTE_UNUSED more portable
Nikita Popov [Wed, 12 Jun 2019 12:29:23 +0000 (14:29 +0200)]
Make ATTRIBUTE_UNUSED more portable

5 years agoFix ifdef position
Nikita Popov [Wed, 12 Jun 2019 11:49:57 +0000 (13:49 +0200)]
Fix ifdef position

Hopefully fixes the release build...

5 years agoUse memset instead of brace initialization
Nikita Popov [Wed, 12 Jun 2019 11:25:19 +0000 (13:25 +0200)]
Use memset instead of brace initialization

Apparently {{0}} is not enough ... let's not rely on structure
layout specifics here.

5 years agoUpdate NEWS for 7.4.0alpha2
Derick Rethans [Wed, 12 Jun 2019 11:12:55 +0000 (11:12 +0000)]
Update NEWS for 7.4.0alpha2

5 years agoUpdate CREDITS for PHP 7.4.0alpha1
Derick Rethans [Wed, 12 Jun 2019 11:11:36 +0000 (11:11 +0000)]
Update CREDITS for PHP 7.4.0alpha1

5 years agoUpdate NEWS for PHP 7.4.0alpha1
Derick Rethans [Wed, 12 Jun 2019 11:11:36 +0000 (11:11 +0000)]
Update NEWS for PHP 7.4.0alpha1

5 years agoRemove always true condition
Nikita Popov [Wed, 12 Jun 2019 11:16:29 +0000 (13:16 +0200)]
Remove always true condition

5 years agoMark some operand fetching funs as ATTRIBUTE_UNUSED
Nikita Popov [Wed, 12 Jun 2019 11:14:08 +0000 (13:14 +0200)]
Mark some operand fetching funs as ATTRIBUTE_UNUSED

Whether these are used depends on VM specialization.

5 years agoFix unused variables in fpm_env.c
Nikita Popov [Wed, 12 Jun 2019 11:08:15 +0000 (13:08 +0200)]
Fix unused variables in fpm_env.c

5 years agoTry to control ZEND_MM_ALIGNED_SIZE type
Nikita Popov [Wed, 12 Jun 2019 11:06:48 +0000 (13:06 +0200)]
Try to control ZEND_MM_ALIGNED_SIZE type

5 years agoFix unused value warnings in snprintf.c
Nikita Popov [Wed, 12 Jun 2019 11:02:56 +0000 (13:02 +0200)]
Fix unused value warnings in snprintf.c

5 years agoRemove MYSQLND_LLU_SPEC/MYSQLND_LL_SPEC
Nikita Popov [Wed, 12 Jun 2019 10:54:11 +0000 (12:54 +0200)]
Remove MYSQLND_LLU_SPEC/MYSQLND_LL_SPEC

No longer used, replaced by PRIu64/PRIi64.

5 years agoFix mysqlnd printf modifiers
Nikita Popov [Wed, 12 Jun 2019 10:42:53 +0000 (12:42 +0200)]
Fix mysqlnd printf modifiers

By moving the the standard macros...

5 years agoEnable -Werror on m32 build
Nikita Popov [Wed, 12 Jun 2019 10:39:16 +0000 (12:39 +0200)]
Enable -Werror on m32 build

This one is clean now.

5 years agoFix warnings in mysqlnd_alloc.c
Nikita Popov [Wed, 12 Jun 2019 10:28:51 +0000 (12:28 +0200)]
Fix warnings in mysqlnd_alloc.c

And also separate the PHP_DEBUG codepaths more, to avoids having an
ifdef every other line...

5 years agoFix incorrect enum value uses in xmlrpc
Nikita Popov [Wed, 12 Jun 2019 10:05:29 +0000 (12:05 +0200)]
Fix incorrect enum value uses in xmlrpc

5 years agoRemove unused php_mbX_int_to_char() functions
Nikita Popov [Wed, 12 Jun 2019 10:04:10 +0000 (12:04 +0200)]
Remove unused php_mbX_int_to_char() functions

5 years agoFix incorrect printf modifiers
Nikita Popov [Wed, 12 Jun 2019 10:02:40 +0000 (12:02 +0200)]
Fix incorrect printf modifiers

5 years agoGuard functions by SO_PASSCRED
Nikita Popov [Wed, 12 Jun 2019 10:01:05 +0000 (12:01 +0200)]
Guard functions by SO_PASSCRED

5 years agoSimplify GD null byte injection tests
Christoph M. Becker [Tue, 7 May 2019 15:37:35 +0000 (17:37 +0200)]
Simplify GD null byte injection tests

These tests actually check that no file with a name containing a NUL is
created by the GD image output functions.  This is superfluous, since
it is sufficient to check that the function failed, and that an
appropriate warning has been raised.

We also add missing nullbyte injection tests.

5 years agoPreserve CFLAGS/LDFLAGS for curl ssl check
Nikita Popov [Wed, 12 Jun 2019 09:53:14 +0000 (11:53 +0200)]
Preserve CFLAGS/LDFLAGS for curl ssl check

We need to add the curl-specific flags, but we also need to preserve
the general flags, to keep around important stuff like -m32.

5 years agoSuppress int to char conversion warnings
Nikita Popov [Wed, 12 Jun 2019 09:51:33 +0000 (11:51 +0200)]
Suppress int to char conversion warnings

5 years agoUse labs() on long integer
Nikita Popov [Wed, 12 Jun 2019 09:48:18 +0000 (11:48 +0200)]
Use labs() on long integer

5 years agoDon't use sqlite3_aggregate_count()
Nikita Popov [Wed, 12 Jun 2019 09:28:07 +0000 (11:28 +0200)]
Don't use sqlite3_aggregate_count()

This function has been deprecated, with the recommendation that
the count should be explicitly tracked in the aggregate context,
if it is needed.

5 years agoFix type mismatch in two get_col callbacks
Nikita Popov [Wed, 12 Jun 2019 08:54:21 +0000 (10:54 +0200)]
Fix type mismatch in two get_col callbacks

5 years agoFix -Wmissing-braces warnings
Nikita Popov [Wed, 12 Jun 2019 08:50:58 +0000 (10:50 +0200)]
Fix -Wmissing-braces warnings

Unfortunate that = {} is a GNU extension.

5 years agoUpdate credits pre-release
Derick Rethans [Wed, 12 Jun 2019 07:58:11 +0000 (08:58 +0100)]
Update credits pre-release

5 years agofix flaky zip tests, order is OS dependent
Joe Watkins [Wed, 12 Jun 2019 07:47:47 +0000 (09:47 +0200)]
fix flaky zip tests, order is OS dependent

5 years agoadd comment about pg_config/pkgconfig
Remi Collet [Wed, 12 Jun 2019 07:39:11 +0000 (09:39 +0200)]
add comment about pg_config/pkgconfig

5 years agoRevert option rename
Nikita Popov [Wed, 12 Jun 2019 07:28:25 +0000 (09:28 +0200)]
Revert option rename

Let's keep this at --with-password-argon2 to avoid churn, I don't
think we have a strong motivation to rename this one.