dynaflash [Thu, 6 Mar 2008 13:57:37 +0000 (13:57 +0000)]
MacGui: move the presets sorting into a new method "-sortPresets" so it can be done independently of adding a preset in preparation for drag and drop preset arranging capability.
dynaflash [Thu, 6 Mar 2008 13:53:15 +0000 (13:53 +0000)]
MacGui: Increase the preset drawer max width and content view width by 60 px. This still leaves us 1024 width compatible and allows more room for longer preset names, vertical scroller as well as the disclosure triangles for nested presets.
dynaflash [Wed, 5 Mar 2008 14:29:45 +0000 (14:29 +0000)]
MacGui: Fix issue where prepareJob was not sensing MKV in the Format popup correctly.
- Takes care of the no mkv chapter issues reported here: http://forum.handbrake.fr/viewtopic.php?f=12&t=5120
- Thanks for the diagnostic testing and bringing it to our attention simoncoul !
van [Sun, 2 Mar 2008 09:18:19 +0000 (09:18 +0000)]
DVB teletext streams and ATSC AC3 audio streams use the same code points. If we misclassify teletext as audio we'll die early in the encode while trying to find an AC3 sync frame. So, if we don't find a sync frame after searching a megabyte of the stream decide it's not AC3, delete the audio entry & keep going.
Problem & test case from ncbp http://forum.handbrake.fr/viewtopic.php?p=29137#p29137.
van [Sun, 2 Mar 2008 05:15:56 +0000 (05:15 +0000)]
Don't crash just because some dvd title uses an illegal pgn number.
(Fixes bug reported in http://forum.handbrake.fr/viewtopic.php?p=28767&sid=23308d0c02b70fceb54db71b0d0f2660#p28767).
van [Sat, 1 Mar 2008 20:19:20 +0000 (20:19 +0000)]
Oops - left in a mistake from an intermediate version. We want aspect ratio from all previews but crop from only frame two (otherwise we'll crop down to nothing if there's a preview with a lot of black).
van [Fri, 29 Feb 2008 18:33:45 +0000 (18:33 +0000)]
Don't crash while scanning when we can't get previews for some title.
- if we get no previews for some title, ignore the title
- use the most common aspect ratio found from our 10 previews rather than just the aspect of preview 2 (otherwise we'll crash in hb_fix_aspect if we don't get preview 2).
- check parameters in hb_fix_aspect so we don't divide by zero.
van [Fri, 29 Feb 2008 18:24:46 +0000 (18:24 +0000)]
It's a good idea to have a buffer for every pid you decide to decode.
Max buffers was 1/4 max streams. This makes it same as max streams.
(Fixes crash reported by ncbp at http://forum.handbrake.fr/viewtopic.php?p=28899&sid=0c89bb9c9aed7eee51c294f25ac61e99#p28899)
dynaflash [Wed, 27 Feb 2008 16:32:15 +0000 (16:32 +0000)]
Adds Dark_Shikari's vbv 1 pass patch for x264
- While not optimal by any means according to Dark_Shikari over at x264, it definitely seems to help with the borked I frames we have been seeing using vbv 1 pass over x264 standard vbv.
- Rumors are that a more comprehensive fix is in the works for x264. But who wants to hold their breath. HB presets rely on vbv too much to have squashed I frames in the meantime.
eddyg [Tue, 26 Feb 2008 00:51:49 +0000 (00:51 +0000)]
Set an minimum subtitle display time of three seconds *or* until the next subtitle is displayed. This makes subtitles easier to read for the slow readers or for the DVD authors why display the subtitles for too short a period (e.g. only display the subtitles during the talking in a fast speaking tongue).
van [Mon, 25 Feb 2008 06:39:42 +0000 (06:39 +0000)]
Don't allow negative durations. These shouldn't happen but occasionally do due to upstream bugs. Replace them with a small positive duration so the mp4 file will be playable.
van [Mon, 25 Feb 2008 06:35:41 +0000 (06:35 +0000)]
Work-around for xvid crash - dct coeff tables are being loaded with SSE 'load aligned' instructions which require 16-byte alignment but either nasm or the loader is ignoring the .rodata section alignment request. Since .rodata is in the text section which is correctly aligned, pad the text section so it's 16-byte aligned which will cause the following data to be correctly aligned.
sr55 [Sun, 24 Feb 2008 18:40:27 +0000 (18:40 +0000)]
WinGui:
- Fixed bug where the chapter markers csv filename renamed the same for every item on the queue. This meant the same chapter names got added to each encode when in fact, each encode should have had a separate file.
- Disabled development expiry code.
dynaflash [Thu, 21 Feb 2008 14:33:01 +0000 (14:33 +0000)]
MacGui: Un-Banish the 64 bit mp4 checkbox from the Siberia known as the preferences now that we have a device and a preset designed specifically for 64 bit mp4's.
- Don't say it jbrjake :)
dynaflash [Thu, 21 Feb 2008 13:47:09 +0000 (13:47 +0000)]
MacGui: Fix and issue for auto adding the .m4v file extension for the aac + ac3 encoder for mp4 where reselecting mp4 format would reset the extension back to .mp4 and not .m4v
- Moves this to a new method called codecsPopUpChanged: so it is easier to call form multiple methods
dynaflash [Thu, 21 Feb 2008 13:20:21 +0000 (13:20 +0000)]
MacGui: Fix issue where canceling the open source window, then re opening it and selecting a source or cancelling is could cause a crash.
- Patch courtesy of Xeri
sr55 [Wed, 20 Feb 2008 16:36:09 +0000 (16:36 +0000)]
WinGui: minor bug fixes.
- Queue window now allows selection of queued items on the whole panel, not just the left side of the panel.
- Fixed a few rouge extensions not getting changed correctly when selecting a preset. (may need to revisit this for psp preset)
- When using AAC+AC3 use m4v if mp4 is currently on the extension.
- Fixed the user defaults not setting video / audio encode properly.
jbrjake [Mon, 18 Feb 2008 23:01:33 +0000 (23:01 +0000)]
Use 64-bit MP4 containers for the AppleTV preset, in case the 2500kb/s video and 448kb/s AC3 and 160kb/s AAC push the file size over 4 gigs for long movies.
sr55 [Mon, 18 Feb 2008 17:43:31 +0000 (17:43 +0000)]
WinGui:
- Fixed issue with iPod Atom displaying an error with the new presets when switching from a preset with ipod atom to one without.
- Fixed the CLI preset grab during startup. This wasn't working.
dynaflash [Mon, 18 Feb 2008 15:59:12 +0000 (15:59 +0000)]
MacGui: Make sure that mp4's using ac3 passthru whether by itself or in combination with aac use the .m4v file extension as otherwise quicktime will not play it at all.
jbrjake [Sun, 17 Feb 2008 06:15:29 +0000 (06:15 +0000)]
Signal anamorphic in the MP4 container though the pixel aspect atom as well as the transformation matrix. This allows anamorphic on the iPhone and iPod Touch. One day, if Apple fixes a QuickTime Player bug, the only way to get it to display right in QuickTime might be to remove the transformation matrix the AppleTV still depends upon. It's a gamble. Oh well.
jbrjake [Sun, 17 Feb 2008 06:09:18 +0000 (06:09 +0000)]
Msc OS Contrib Binaries ++ to 0022, bringing to make builds the wonders of AC3-in-MP4, multi-track audio and anamorphic for the iPhone, and a fresh copy of libx264 with the vbv 2-pass patch applied.
dynaflash [Sat, 16 Feb 2008 22:49:08 +0000 (22:49 +0000)]
MacGui: Change aac/ ac3 hybrid to utilize the codecs popup and only offer one mixdown for each additional choice.
- adds AVC h.264 / AAC + AC3 Audio and AVC h.264 / AC3
- First corresponds to the dpl2 + ac3 passthru mixdown
- Second corresponds to the AC3 pass thru mixdown
jbrjake [Sat, 16 Feb 2008 16:10:18 +0000 (16:10 +0000)]
Mcdeint is broken, so avoid using it as a deinterlacer. No more "Slowest," "Slow" becomes yadif without spatial checks, "Slower" becomes yadif with spatial checks.
jbrjake [Sat, 16 Feb 2008 15:15:52 +0000 (15:15 +0000)]
Wires up the CLI for doing AAC and AC3 at the same time, with a new audio encoder value, aac+ac3. Allows up to 4 source tracks to be selected, all are handled the same way. (Track-by-track audio configuration waits for 0.9.3.)
dynaflash [Wed, 13 Feb 2008 14:25:06 +0000 (14:25 +0000)]
MacGui: remove the preference to turn off verbose output in the activity window.
- non verbose output is of no use whatsoever to the macgui
- uses "HB_DEBUG_ALL" for hb_init
- removed preference from preferences window
dynaflash [Tue, 12 Feb 2008 16:00:18 +0000 (16:00 +0000)]
Update x264 to revision 736 and update the vbv 2 pass patch by Gabriel Bouvigne to the Feb 6 version.
- As usual jam only until ub contrib packs are updated
- Will require a clean checkout (updating will not work) as jam will need to download and compile a new contrib.
- vbv 2 pass patch is here: http://thread.gmane.org/gmane.comp.video.x264.devel/3093/focus=3502
jbrjake [Tue, 12 Feb 2008 15:31:38 +0000 (15:31 +0000)]
Refer to transitions in the presence-or-lack-thereof of progressive flags on MPEG-2 frames as Film->Video or vice versa instead of Progressive->Interlaced. Slightly more accurate, and will make future comb detection of previews less confusing.
van [Sat, 9 Feb 2008 05:40:09 +0000 (05:40 +0000)]
- More robust stream duration estimation: take 16 (position,pts) samples then do a max likelihood estimate of the average rate based on the rate between all pairs of samples.
- When we detect a sync error attempt to resync so that we can handle streams where a few bytes have been inserted or deleted.
dynaflash [Thu, 7 Feb 2008 18:39:05 +0000 (18:39 +0000)]
MacGui: fix picture sizing issue in presets where creating a preset using an HD source (ie. 960 x 544) and then using that preset on a smaller source (ie. dvd) would cause the smaller source to be upscaled to the larger size. Now preset is restricted to scale no larger than the current source regardless of size when it was created.
dynaflash [Thu, 7 Feb 2008 16:43:51 +0000 (16:43 +0000)]
MacGui: Add the Forced subtitles checkbox to custom user presets
- uses [preset setObject:[NSNumber numberWithInt:1] forKey:@"SubtitlesForced"] to turn the forced checkbox on in the preset
- Not added to any built in presets
- checkbox is unchecked for any preset that doesnt explicitly have it set.
jbrjake [Mon, 4 Feb 2008 16:53:27 +0000 (16:53 +0000)]
Variable frame rate improvements.
- Makes it work better with the source's time stamps and avoids discontinuities, by removing its lazy assumption that all frames are 3003 ticks long.
- Handles more than 1 frame being dropped out of 5.
- Preserves chapter markers from being dropped along with frames they're attached to (thanks van!).
- Also, since VFR no longer requires input at 29.97 fps, removes the hard-coding of that frame rate.
saintdev [Mon, 4 Feb 2008 01:22:30 +0000 (01:22 +0000)]
Remove the seperate action for mpeg4ip on cygwin from the contrib
Jamfile. It was only applying a patch. This makes things a little easier
to maintain and makes mpeg4ip similar to other contribs wrt. patching.
sr55 [Sat, 2 Feb 2008 15:34:27 +0000 (15:34 +0000)]
WinGui:
- now using C#.Net 08
- Fixed bug with VFR setting framerate when enabled.
- Fixed potential framerate bug (passing framerate without -r to the CLI)
ritsuka [Wed, 30 Jan 2008 12:28:55 +0000 (12:28 +0000)]
IHB: - Various bugfix
- IHB can loads .ihbdevice presets from a directory inside the application bundle, and from ~/Application Support/Instant Handbrake
- A .ihbdevice file can contain multiple presets, but IHB only reads the first at the moment. I am not sure how to handle multiple presets yet.
- The only way to create an .ihbprofile file is to edit DeviceController.m , another thing I still need to think about.
van [Thu, 24 Jan 2008 20:37:03 +0000 (20:37 +0000)]
Add an (optional) iso639_2b field to the language struct so that we will accept either ISO 639-2/T or /B codes in input content (particularly MPEG transport stream PMTs) but will always generate /T codes in mp4s to keep QuickTime happy.
dynaflash [Wed, 23 Jan 2008 14:33:25 +0000 (14:33 +0000)]
MacGui: Fix bug where switching titles with vfr on changes the framerate from 29.97 which is required by vfr.
- Note: mostly cosmetic to the gui as libhb is pretty much ignoring the framerate specified by the gui when vfr is on anyway. But the gui should reflect as much as possible what libhb is doing behind the scenes.
van [Tue, 22 Jan 2008 22:06:28 +0000 (22:06 +0000)]
- Make MPEG audio (and other audio types besides AC3) work.
- Since the stream is closed after the scan then reopened by reader, we have to preserve all the state we gathered during the scan (like audio id to TS PID bindings) across the close. For now do this by ignoring the close call & doing a close internally when a stream of a different name is opened.
- Don't overfill ts_packetbuf and abort just because an audio stream was missing the AC3 sync pattern (MPEG & DTS streams don't even have an AC3 sync pattern).
- Get rid of several unused variables so that this compiles with no warnings.
van [Tue, 22 Jan 2008 21:55:38 +0000 (21:55 +0000)]
- rather than completely giving up on a dvd because we got a read error on next_vobu, just skip to the start of the next cell & keep going.
- get rid of some unused variables so this compiles with no warnings.
projects / handbrake / log