]> granicus.if.org Git - apache/log
apache
5 years ago *) mod_http2/mod_proxy_http2: proxy_http2 checks correct master connection aborted...
Stefan Eissing [Tue, 26 Feb 2019 09:55:44 +0000 (09:55 +0000)]
  *) mod_http2/mod_proxy_http2: proxy_http2 checks correct master connection aborted status
     to trigger immediate shutdown of backend connections. This is now always signalled
     by mod_http2 when the the session is being released.
     proxy_http2 now only sends a PING frame to the backend when there is not already one
     in flight. [Stefan Eissing]

  *) mod_proxy_http2: fixed an issue where a proxy_http2 handler entered an infinite
     loop when encountering certain errors on the backend connection.
     See <https://bz.apache.org/bugzilla/show_bug.cgi?id=63170>. [Stefan Eissing]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854365 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 23 Feb 2019 15:50:49 +0000 (15:50 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854223 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML fr doc files updates.
Lucien Gentis [Sat, 23 Feb 2019 15:49:27 +0000 (15:49 +0000)]
XML fr doc files updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854222 13f79535-47bb-0310-9956-ffa450edef68

5 years agohttp: Fix possible empty response with mod_ratelimit for HEAD requests.
Yann Ylavic [Wed, 20 Feb 2019 23:08:15 +0000 (23:08 +0000)]
http: Fix possible empty response with mod_ratelimit for HEAD requests.

Don't eat the EOS in ap_http_header_filter() if it comes in single brigade
with a full response to a HEAD request, otherwise mod_ratelimit will never
flush its pending data.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854004 13f79535-47bb-0310-9956-ffa450edef68

5 years agoReviewed and corrected some spelling and typos
Luis Gil [Wed, 20 Feb 2019 22:51:53 +0000 (22:51 +0000)]
Reviewed and corrected some spelling and typos

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854002 13f79535-47bb-0310-9956-ffa450edef68

5 years agochanged typo on "This module relies on OpenSSL to provide the cryptography engine...
Luis Gil [Wed, 20 Feb 2019 22:47:40 +0000 (22:47 +0000)]
changed typo on "This module relies on OpenSSL to provide the cryptography engine." to change
cryptographic

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1854000 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_hcheck: mute "run from watchdog" message.
Yann Ylavic [Wed, 20 Feb 2019 21:30:16 +0000 (21:30 +0000)]
mod_proxy_hcheck: mute "run from watchdog" message.

This is way too verbose (every 100ms) to be logged at any LogLevel.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853992 13f79535-47bb-0310-9956-ffa450edef68

5 years agoUpdate a comment about the 'PATCH' HTTP command
Christophe Jaillet [Wed, 20 Feb 2019 18:54:03 +0000 (18:54 +0000)]
Update a comment about the 'PATCH' HTTP command

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853980 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_http2: fix for latest mod_reqtimeout change re handshake timeouts
Stefan Eissing [Wed, 20 Feb 2019 15:54:26 +0000 (15:54 +0000)]
mod_http2: fix for latest mod_reqtimeout change re handshake timeouts

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853967 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: revert spurious comment from r1853953.
Yann Ylavic [Wed, 20 Feb 2019 12:53:06 +0000 (12:53 +0000)]
mod_proxy_http: revert spurious comment from r1853953.

No, if we read more bytes than the C-L there is really something wrong in
our (or some) HTTP input filter.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853956 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: common function for stream_reqbody_{cl,chunked}()
Yann Ylavic [Wed, 20 Feb 2019 12:24:14 +0000 (12:24 +0000)]
mod_proxy_http: common function for stream_reqbody_{cl,chunked}()

Since stream_reqbody_cl() and stream_reqbody_chunked}() now have the same
structure, join them into a single stream_reqbody() function which is passed
the rb_method to handle only CL vs chunked cases differently.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853953 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFollow up to r1853874: CHANGES entry.
Yann Ylavic [Wed, 20 Feb 2019 09:48:45 +0000 (09:48 +0000)]
Follow up to r1853874: CHANGES entry.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853938 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_reqtimeout: follow up to r1853901: init stage name outside INIT_STAGE().
Yann Ylavic [Wed, 20 Feb 2019 08:54:51 +0000 (08:54 +0000)]
mod_reqtimeout: follow up to r1853901: init stage name outside INIT_STAGE().

It helps both code readability where stages are initilized and potential
logging in the input filter (even if the stage is disabled).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853935 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_reqtimeout: follow up to r1853901: fix macro args.
Yann Ylavic [Wed, 20 Feb 2019 08:13:41 +0000 (08:13 +0000)]
mod_reqtimeout: follow up to r1853901: fix macro args.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853929 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_reqtimeout: follow up to r1853906: adjust hooks priorities comments.
Yann Ylavic [Tue, 19 Feb 2019 18:22:11 +0000 (18:22 +0000)]
mod_reqtimeout: follow up to r1853906: adjust hooks priorities comments.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853908 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_reqtimeout: Allow to configure (TLS-)handshake timeouts.
Yann Ylavic [Tue, 19 Feb 2019 18:14:13 +0000 (18:14 +0000)]
mod_reqtimeout: Allow to configure (TLS-)handshake timeouts.

The timeouts apply between the process_connection and pre_read_request hooks.
They are disabled by default for compatibily reasons.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853906 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_reqtimeout: factorize structs and code.
Yann Ylavic [Tue, 19 Feb 2019 17:21:09 +0000 (17:21 +0000)]
mod_reqtimeout: factorize structs and code.

With a bit of macro magic, this is to avoid more code duplication when adding
new stages (next commit will add TLS/handshake timeouts handling in addition to
existing header and body ones).

No functional change here.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853901 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_cache_socache: avoid pool to heap reallocation.
Yann Ylavic [Tue, 19 Feb 2019 11:51:27 +0000 (11:51 +0000)]
mod_cache_socache: avoid pool to heap reallocation.

Below some threshold, the previous code tried free (sub-)pooled memory ASAP by
moving small buffers (< capacity / 2) to a heap bucket. But this is not really
an optimization because first it requires at some point to allocate more than
the configured capacity, and second since this happens during response handling
the pool is about to be destroyed soon anymay.

This commit simply keeps the data in the subpool and uses a pool bucket for the
output brigade to take care of the lifetime until it's consumed (or not).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853874 13f79535-47bb-0310-9956-ffa450edef68

5 years agoThis is harmless, but this really should be an 'echo_do *'
Christophe Jaillet [Sun, 17 Feb 2019 14:47:06 +0000 (14:47 +0000)]
This is harmless, but this really should be an 'echo_do *'

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853757 13f79535-47bb-0310-9956-ffa450edef68

5 years ago- Be consistent with the case used for uniqueMember.
Christophe Jaillet [Fri, 15 Feb 2019 20:50:17 +0000 (20:50 +0000)]
- Be consistent with the case used for uniqueMember.
- Be consistent with the case used for AuthLDAPURL. Use uppercase URL, as in the code in order to fix syntax highlight issues.
- Fix the case of AuthLDAPSubGroupAttribute in <default>, so that quickreference.xsl works as expected

Fix some other small layout issues.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853664 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix compatibility note, 'SSLPolicy' is not in 2.4.x yet.
Christophe Jaillet [Fri, 15 Feb 2019 13:24:54 +0000 (13:24 +0000)]
Fix compatibility note, 'SSLPolicy' is not in 2.4.x yet.

+ remove a trailing space to synch with 2.4.x

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853644 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd directive name, so that quickreference.xsl can extract default value correctly.
Christophe Jaillet [Fri, 15 Feb 2019 11:36:44 +0000 (11:36 +0000)]
Add directive name, so that quickreference.xsl can extract default value correctly.

Always align on the left code in <highlight> block in order to be consistent and fix a layout issue.

Add some links between directives.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853637 13f79535-47bb-0310-9956-ffa450edef68

5 years ago* modules/md/mod_md_config.c (md_mod_conf_get): Use state-dir-relative
Joe Orton [Fri, 15 Feb 2019 10:09:53 +0000 (10:09 +0000)]
* modules/md/mod_md_config.c (md_mod_conf_get): Use state-dir-relative
  default base_dir.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853631 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd directive name, so that quickreference.xsl can extract default value correctly.
Christophe Jaillet [Fri, 15 Feb 2019 08:47:16 +0000 (08:47 +0000)]
Add directive name, so that quickreference.xsl can extract default value correctly.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853624 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix the directive name used in <default> syntax for DefaultRuntimeDir.
Christophe Jaillet [Fri, 15 Feb 2019 08:37:25 +0000 (08:37 +0000)]
Fix the directive name used in <default> syntax for DefaultRuntimeDir.

Add some links.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853623 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix typo added in r1838958
Christophe Jaillet [Fri, 15 Feb 2019 08:21:11 +0000 (08:21 +0000)]
Fix typo added in r1838958

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853618 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix case in directive name, so that quickreference.xsl can extract default value...
Christophe Jaillet [Fri, 15 Feb 2019 07:50:20 +0000 (07:50 +0000)]
Fix case in directive name, so that quickreference.xsl can extract default value correctly.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853617 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix typo
Christophe Jaillet [Fri, 15 Feb 2019 07:30:59 +0000 (07:30 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853616 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd some additional tests to report badly formatted synopsis.
Christophe Jaillet [Fri, 15 Feb 2019 07:25:54 +0000 (07:25 +0000)]
Add some additional tests to report badly formatted synopsis.
Comment-out these tests because of the noise it generates, but leave it there, if useful for s.o.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853615 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: follow up to r1853561.
Yann Ylavic [Thu, 14 Feb 2019 08:45:36 +0000 (08:45 +0000)]
mod_proxy_http: follow up to r1853561.

Handle "proxy-sendextracrlf" within the loop too.

Btw, this extra CRLF heresy should go (at least in trunk)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853566 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRevert r1853564.
Yann Ylavic [Thu, 14 Feb 2019 08:40:38 +0000 (08:40 +0000)]
Revert r1853564.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853565 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: follow up to r1853409: no need to double flush on EOS.
Yann Ylavic [Thu, 14 Feb 2019 08:34:05 +0000 (08:34 +0000)]
mod_proxy_http: follow up to r1853409: no need to double flush on EOS.

[Reverted by r1853565]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853564 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: follow up to r1853409: don't play with meta-buckets.
Yann Ylavic [Thu, 14 Feb 2019 08:22:49 +0000 (08:22 +0000)]
mod_proxy_http: follow up to r1853409: don't play with meta-buckets.

It's better/simpler to handle the final 0-size chunk within the loop (on EOS).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853561 13f79535-47bb-0310-9956-ffa450edef68

5 years agoCreate the configure for mod_proxy_hcheck when used in BalancerMember.
Jean-Frederic Clere [Thu, 14 Feb 2019 08:14:52 +0000 (08:14 +0000)]
Create the configure for mod_proxy_hcheck when used in BalancerMember.

PR 60757

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853560 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: follow up to r1853409.
Yann Ylavic [Wed, 13 Feb 2019 16:53:50 +0000 (16:53 +0000)]
mod_proxy_http: follow up to r1853409.

Don't send two final 0-size chunks when the last read brigade is a single EOS.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853518 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix numbering
Christophe Jaillet [Tue, 12 Feb 2019 07:49:32 +0000 (07:49 +0000)]
Fix numbering

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853416 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_proxy_http: rework the flushing strategy when forwarding the request body.
Yann Ylavic [Mon, 11 Feb 2019 21:55:43 +0000 (21:55 +0000)]
mod_proxy_http: rework the flushing strategy when forwarding the request body.

Since the forwarding of 100-continue (end to end) in r1836588, we depended on
reading all of the requested HUGE_STRING_LEN bytes to avoid the flushes, but
this is a bit fragile.

This commit introduces the new stream_reqbody_read() function which will try a
nonblocking read first and, if it fails with EAGAIN, will flush on the backend
side before blocking for the next client side read.

We can then use it in stream_reqbody_{chunked,cl}() to flush client forwarded
data only when necessary. This both allows "optimal" flushing and simplifies
code (note that spool_reqbody_cl() also makes use of the new function but not
its nonblocking/flush functionality, thus only for consistency with the two
others, simplification and common error handling).

Also, since proxy_http_req_t::flushall/subprocess_env::proxy-flushall are now
meaningless (and unused) on the backend side, they are renamed respectively to
prefetch_nonblocking/proxy-prefetch-nonblocking, and solely determine whether
to prefetch in nonblocking mode or not. These flags were trunk only and may
not be really useful if we decided to prefetch in nonblocking mode in any case,
but for 2.4.x the opt-in looks wise.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853407 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFollow up to r1847430.
Christophe Jaillet [Sun, 10 Feb 2019 10:14:37 +0000 (10:14 +0000)]
Follow up to r1847430.

- These flags are not for apr_dir_ function. Clarify comment.
- Initialize 'depth', especially when AP_DIR_FLAG_RECURSIVE is explicitelly required.
- Avoid an harmless over-allocation .

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853302 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 9 Feb 2019 16:30:38 +0000 (16:30 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853289 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML file fr doc update.
Lucien Gentis [Sat, 9 Feb 2019 16:29:03 +0000 (16:29 +0000)]
XML file fr doc update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853288 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_rewrite doc rebuild
Luca Toscano [Sat, 9 Feb 2019 14:15:27 +0000 (14:15 +0000)]
mod_rewrite doc rebuild

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853281 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_rewrite.xml: add an example about override behavior
Luca Toscano [Sat, 9 Feb 2019 14:14:43 +0000 (14:14 +0000)]
mod_rewrite.xml: add an example about override behavior

A user in PR 63051 was confused about the default behavior
of mod_rewrite (override) when merging two sections in the
directory context at the same nesting level. I was confused
as well, but after a quick look at the code I figured out that
RewriteOptions Inherit seems to solve the issue (naming is,
in this case, a bit counter intuitive). I hope that I added
a good clarification in the code, if not please amend it as
you think it's best!

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853280 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix a race condition.
Christophe Jaillet [Fri, 8 Feb 2019 06:14:47 +0000 (06:14 +0000)]
Fix a race condition.
Authentication with valid credentials could be refused in case of concurrent accesses from different users.

PR 63124 [Simon Kappel <simon.kappel axis.com>]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853190 13f79535-47bb-0310-9956-ffa450edef68

5 years agohttp2: mark tasks' pools.
Yann Ylavic [Thu, 7 Feb 2019 22:32:22 +0000 (22:32 +0000)]
http2: mark tasks' pools.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853171 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFollow up to r1853133: CHANGES entry.
Yann Ylavic [Thu, 7 Feb 2019 22:23:27 +0000 (22:23 +0000)]
Follow up to r1853133: CHANGES entry.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853166 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_ssl: unset FIPS mode only if we set it.
Yann Ylavic [Thu, 7 Feb 2019 13:38:12 +0000 (13:38 +0000)]
mod_ssl: unset FIPS mode only if we set it.

If FIPS mode is set by default per openssl lib/module, we should not
unset it on restart or it might never be set again.

PR 63136

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853133 13f79535-47bb-0310-9956-ffa450edef68

5 years ago* server/core.c (core_pre_config): Reset state dir during pre_config.
Joe Orton [Tue, 5 Feb 2019 10:11:44 +0000 (10:11 +0000)]
* server/core.c (core_pre_config): Reset state dir during pre_config.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852982 13f79535-47bb-0310-9956-ffa450edef68

5 years agodocumentation rebuild
Luca Toscano [Sun, 3 Feb 2019 01:33:02 +0000 (01:33 +0000)]
documentation rebuild

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852808 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 2 Feb 2019 14:20:47 +0000 (14:20 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852797 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML fr doc files updates.
Lucien Gentis [Sat, 2 Feb 2019 14:18:54 +0000 (14:18 +0000)]
XML fr doc files updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852796 13f79535-47bb-0310-9956-ffa450edef68

5 years agodelete a blanck space
Luis Gil [Wed, 30 Jan 2019 22:19:13 +0000 (22:19 +0000)]
delete a blanck space

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852560 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFixing typos in documentation files.
Luis Gil [Tue, 29 Jan 2019 22:37:40 +0000 (22:37 +0000)]
Fixing typos in documentation files.
Bug issue https://bz.apache.org/bugzilla/show_bug.cgi?id=63122

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852478 13f79535-47bb-0310-9956-ffa450edef68

5 years agoMake proxy modules compile if APR_HAS_THREADS is not defined.
Stefan Sperling [Tue, 29 Jan 2019 12:28:35 +0000 (12:28 +0000)]
Make proxy modules compile if APR_HAS_THREADS is not defined.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852442 13f79535-47bb-0310-9956-ffa450edef68

5 years ago * inc http2 version number to distinguish to github released version
Stefan Eissing [Mon, 28 Jan 2019 10:43:44 +0000 (10:43 +0000)]
 * inc http2 version number to distinguish to github released version
 * further disentangle streama and request memory pools

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852341 13f79535-47bb-0310-9956-ffa450edef68

5 years ago *) mod_http2: Configuration directoves H2Push and H2Upgrade can now be specified per
Stefan Eissing [Mon, 28 Jan 2019 10:27:08 +0000 (10:27 +0000)]
  *) mod_http2: Configuration directoves H2Push and H2Upgrade can now be specified per
     Location/Directory, e.g. disabling PUSH for a specific set of resources. [Stefan Eissing]

  *) mod_http2: HEAD requests to some module such as mod_cgid caused the stream to
     terminate improperly and cause a HTTP/2 PROTOCOL_ERROR.
     Fixes <https://github.com/icing/mod_h2/issues/167>. [Michael Kaufmann]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852339 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sun, 27 Jan 2019 14:15:48 +0000 (14:15 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852291 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc XML update.
Lucien Gentis [Sun, 27 Jan 2019 14:14:58 +0000 (14:14 +0000)]
fr doc XML update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852290 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sun, 27 Jan 2019 14:08:09 +0000 (14:08 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852289 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc XML updates.
Lucien Gentis [Sun, 27 Jan 2019 14:06:35 +0000 (14:06 +0000)]
fr doc XML updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852288 13f79535-47bb-0310-9956-ffa450edef68

5 years agoQuireference extract the default value of a directive from the <default> of the...
Christophe Jaillet [Sun, 27 Jan 2019 13:49:29 +0000 (13:49 +0000)]
Quireference extract the default value of a directive  from the <default> of the corresponding <directivesynopsis> block.

The current implementation  expects <default> to be formated like:
directive_name default_value

If the directive name is not there, no default value can be extracted and it is missing in the quickreference table.

This commit adds a basic check to see if the formating looks correct. It catches cases where the directive name is  omited or is misspelled.

If it generates too much noise, feel free to revert or improve :)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852285 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix typo (s/ProxyExpressDBMFile/ProxyExpressDBMType/)
Christophe Jaillet [Sun, 27 Jan 2019 08:18:45 +0000 (08:18 +0000)]
Fix typo (s/ProxyExpressDBMFile/ProxyExpressDBMType/)
PR 63119.

Move compatibility note in the module synopsis instead of repeating it in all directives.
Fix the way <default> values are given, so that they can be reflected in quickreference.html.
Fix the style used in <syntax> to be consistent with the documentation.
Improve syntax highlight.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852270 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove a useless compatibility note.
Christophe Jaillet [Sat, 26 Jan 2019 12:51:05 +0000 (12:51 +0000)]
Remove a useless compatibility note.
It is already stated at the very begining of the page.

Add a missing ')' to ease reading

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852223 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_ssl: give mod_md the chance to override certificate after ALPN protocol negotiation.
Stefan Eissing [Fri, 25 Jan 2019 13:33:07 +0000 (13:33 +0000)]
mod_ssl: give mod_md the chance to override certificate after ALPN protocol negotiation.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852128 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_http2: fixed slave connection keepalives counter.
Stefan Eissing [Fri, 25 Jan 2019 09:27:39 +0000 (09:27 +0000)]
mod_http2: fixed slave connection keepalives counter.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852101 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_http2: enable re-use of slave connections again.
Stefan Eissing [Thu, 24 Jan 2019 15:25:52 +0000 (15:25 +0000)]
mod_http2: enable re-use of slave connections again.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852038 13f79535-47bb-0310-9956-ffa450edef68

5 years agoreverting last change
Stefan Eissing [Thu, 24 Jan 2019 15:21:04 +0000 (15:21 +0000)]
reverting last change

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852037 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_http2: enable re-use of slave connections again.
Stefan Eissing [Thu, 24 Jan 2019 15:10:34 +0000 (15:10 +0000)]
mod_http2: enable re-use of slave connections again.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1852032 13f79535-47bb-0310-9956-ffa450edef68

5 years agorevert of r808895 somehow missed mod_proxy_ftp
Eric Covener [Wed, 23 Jan 2019 18:25:50 +0000 (18:25 +0000)]
revert of r808895 somehow missed mod_proxy_ftp

r808895 added `ServerTokens OFF` so some modules were
switched from ap_get_server_banner() to
ap_get_server_description() so they would never be empty.

But ap_get_server_description() is documnented as being for local
use only, so it was not really a suitable replacement much less
w/ `ServerTokens OFF` subsequently taken out.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851954 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXforms
Rainer Jung [Tue, 22 Jan 2019 09:53:04 +0000 (09:53 +0000)]
Xforms

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851794 13f79535-47bb-0310-9956-ffa450edef68

5 years agoCopy the "Note about /" note from the Location
Rainer Jung [Tue, 22 Jan 2019 09:27:15 +0000 (09:27 +0000)]
Copy the "Note about /" note from the Location
explanation to the LocationMatch explanation.
Probably more people use LocationMatch than
Location with "~".

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851790 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix a typo reported by [stephane.blondon gmail.com]
Christophe Jaillet [Sun, 20 Jan 2019 09:55:41 +0000 (09:55 +0000)]
Fix a typo reported by [stephane.blondon gmail.com]
PR 63092

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851702 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 19 Jan 2019 14:42:23 +0000 (14:42 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851673 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML fr doc update.
Lucien Gentis [Sat, 19 Jan 2019 14:22:40 +0000 (14:22 +0000)]
XML fr doc update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851671 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd compatibility note missing in r1740967
Christophe Jaillet [Fri, 18 Jan 2019 20:50:40 +0000 (20:50 +0000)]
Add compatibility note missing in r1740967

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851643 13f79535-47bb-0310-9956-ffa450edef68

5 years agoClarify potentially unsuccessful success results.
William A. Rowe Jr [Thu, 17 Jan 2019 17:19:04 +0000 (17:19 +0000)]
Clarify potentially unsuccessful success results.

Curious why modules/aaa/mod_authz_dbm.c:get_dbm_grp() doesn't need the same
net changes?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851552 13f79535-47bb-0310-9956-ffa450edef68

5 years agomod_lua was moved to stable; https://s.apache.org/Xnh1
Daniel Gruno [Tue, 15 Jan 2019 12:40:11 +0000 (12:40 +0000)]
mod_lua was moved to stable; https://s.apache.org/Xnh1
also linting.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851338 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix a misleading comment about s->defn_name
Eric Covener [Tue, 15 Jan 2019 10:14:57 +0000 (10:14 +0000)]
fix a misleading comment about s->defn_name

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851332 13f79535-47bb-0310-9956-ffa450edef68

5 years agoReverse the order of 2 tests to potentially save a few cycles.
Christophe Jaillet [Sun, 13 Jan 2019 12:51:42 +0000 (12:51 +0000)]
Reverse the order of 2 tests to potentially save a few cycles.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851198 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 12 Jan 2019 15:42:15 +0000 (15:42 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851178 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML fr doc update.
Lucien Gentis [Sat, 12 Jan 2019 15:40:57 +0000 (15:40 +0000)]
XML fr doc update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851177 13f79535-47bb-0310-9956-ffa450edef68

5 years agofr doc rebuild.
Lucien Gentis [Sat, 12 Jan 2019 15:31:26 +0000 (15:31 +0000)]
fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851173 13f79535-47bb-0310-9956-ffa450edef68

5 years agoXML fr doc update.
Lucien Gentis [Sat, 12 Jan 2019 15:29:08 +0000 (15:29 +0000)]
XML fr doc update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851172 13f79535-47bb-0310-9956-ffa450edef68

5 years agoTypo.
Lucien Gentis [Sat, 12 Jan 2019 15:28:10 +0000 (15:28 +0000)]
Typo.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851171 13f79535-47bb-0310-9956-ffa450edef68

5 years agoGive a littlet breath before the permalink
Christophe Jaillet [Sat, 12 Jan 2019 13:50:26 +0000 (13:50 +0000)]
Give a littlet breath before the permalink

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851168 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFollow up to r1828588.
Christophe Jaillet [Sat, 12 Jan 2019 13:38:03 +0000 (13:38 +0000)]
Follow up to r1828588.

Update css to have permalink more in line with httpd.a.o:
   - default to white (blue on dark-blue is not really visible)
   - visible only when the mouse is over the corresponding heading

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851167 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove the default CacheKeyBaseURL value, it doesn't have any.
Christophe Jaillet [Sat, 12 Jan 2019 08:32:14 +0000 (08:32 +0000)]
Remove the default CacheKeyBaseURL value, it doesn't have any.

Improve syntax highlight and hyper-links.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851152 13f79535-47bb-0310-9956-ffa450edef68

5 years agoWhen a :port is included in the CacheKeyBaseURL the ":" is lost from the actual cache...
Christophe Jaillet [Sat, 12 Jan 2019 07:51:48 +0000 (07:51 +0000)]
When a :port is included in the CacheKeyBaseURL the ":" is lost from the actual cache key value.  This doesn't harm apache by itself, the real problem arise if some external program which "knows" about the cache keys structure is used to modify the cache.

When CacheKeyBaseURL is not use, the ":" is kept.

So, be consistent when building the key and keep the ":" in all cases.

PR 53915 [Rein Tollevik <rein basefarm.no>]

+ merge 2 lines of a comment to have it more compact

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851146 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix a typo
Christophe Jaillet [Fri, 11 Jan 2019 21:24:47 +0000 (21:24 +0000)]
Fix a typo

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851100 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix websocket proxy over UDS.
Christophe Jaillet [Fri, 11 Jan 2019 19:31:43 +0000 (19:31 +0000)]
Fix websocket proxy over UDS.

configuration example:
<Location "/apis">
ProxyPass unix:/var/run/unix.sock|ws://127.0.0.1/api
</Location>

Currently 'ap_proxy_get_worker()' can't get matched pre-defined worker because
of different uri formatting in 'proxy_wstunnel_canon()' and ap_proxy_define_worker()'

PR 62932 <pavel dcmsys.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851093 13f79535-47bb-0310-9956-ffa450edef68

5 years agoLanguagePriority should be case-insensitive in order to match AddLanguage behavior...
Christophe Jaillet [Thu, 10 Jan 2019 22:41:59 +0000 (22:41 +0000)]
LanguagePriority should be case-insensitive in order to match AddLanguage behavior. PR 39730

Test case  added in r1850983

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850989 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAlways decode session attributes early.
Hank Ibell [Thu, 10 Jan 2019 15:52:31 +0000 (15:52 +0000)]
Always decode session attributes early.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850947 13f79535-47bb-0310-9956-ffa450edef68

5 years ago* modules/ssl/ssl_engine_io.c (bio_filter_out_write,
Joe Orton [Thu, 10 Jan 2019 15:46:07 +0000 (15:46 +0000)]
* modules/ssl/ssl_engine_io.c (bio_filter_out_write,
  bio_filter_in_read): Clear retry flags before aborting
  on client-initiated reneg.

PR: 63052

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850946 13f79535-47bb-0310-9956-ffa450edef68

5 years agoResync several generated docs
William A. Rowe Jr [Wed, 9 Jan 2019 20:21:41 +0000 (20:21 +0000)]
Resync several generated docs

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850900 13f79535-47bb-0310-9956-ffa450edef68

5 years ago* modules/aaa/mod_authn_dbm.c (fetch_dbm_value): No functional change:
Joe Orton [Wed, 9 Jan 2019 09:34:34 +0000 (09:34 +0000)]
* modules/aaa/mod_authn_dbm.c (fetch_dbm_value): No functional change:
  return APR_SUCCESS rather than rv, which is guaranteed to be
  APR_SUCCESS in current code.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850835 13f79535-47bb-0310-9956-ffa450edef68

5 years ago* modules/md/md_acme_drive.c (acme_driver_init):
Joe Orton [Wed, 9 Jan 2019 09:31:26 +0000 (09:31 +0000)]
* modules/md/md_acme_drive.c (acme_driver_init):
  Remove written-but-not-read variable (gcc 8.x warning).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850834 13f79535-47bb-0310-9956-ffa450edef68

5 years agoMake mod_dialup.c compile when APR has no thread support.
Stefan Sperling [Tue, 8 Jan 2019 15:02:15 +0000 (15:02 +0000)]
Make mod_dialup.c compile when APR has no thread support.
+1 from covener and jim on dev@

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850757 13f79535-47bb-0310-9956-ffa450edef68

5 years agoThis just got me. I upgraded macOS to Mojave (w/ latest Xcode) and I always build...
Jim Jagielski [Tue, 8 Jan 2019 13:12:34 +0000 (13:12 +0000)]
This just got me. I upgraded macOS to Mojave (w/ latest Xcode) and I always build w/ maintainer-mode. The problem is that libxml2 will include various unicode/*.h files that have C++ type comments, which causes building to fail (due to Werror). Work around this.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850745 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd new modules to the list of the 2.4 new features list
Christophe Jaillet [Sun, 6 Jan 2019 11:36:54 +0000 (11:36 +0000)]
Add new modules to the list of the 2.4 new features list

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850545 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd compatibility note
Christophe Jaillet [Sun, 6 Jan 2019 11:35:41 +0000 (11:35 +0000)]
Add compatibility note

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850544 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd compatibility note as already noted in new_features_2_4.xml
Christophe Jaillet [Sun, 6 Jan 2019 11:11:20 +0000 (11:11 +0000)]
Add compatibility note as already noted in new_features_2_4.xml

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850539 13f79535-47bb-0310-9956-ffa450edef68