]> granicus.if.org Git - postgresql/log
postgresql
23 years agoGenerate index.html as the root file name of the documentation set,
Peter Eisentraut [Tue, 18 Sep 2001 12:08:27 +0000 (12:08 +0000)]
Generate index.html as the root file name of the documentation set,
rather than making index.html a symlink to the autogenerated name.
Fixes fatal problems with tar programs that don't handle symlinks
very well (MacOS X).

(The names user.html, admin.html, etc. are still available as make
targets, but they aren't packaged anymore.)

Use the manifest file that the stylesheets generate as the file list
for packaging.  Put graphics in the right place while building, not
while packaging, so you can actually look at them after building.

23 years agoEXPLAIN ANALYZE feature to measure and show actual runtimes and tuple
Tom Lane [Tue, 18 Sep 2001 01:59:07 +0000 (01:59 +0000)]
EXPLAIN ANALYZE feature to measure and show actual runtimes and tuple
counts alongside the planner's estimates.  By Martijn van Oosterhout,
with some further work by Tom Lane.

23 years agoUnify the zip rules and variables.
Peter Eisentraut [Mon, 17 Sep 2001 23:00:27 +0000 (23:00 +0000)]
Unify the zip rules and variables.

23 years agoFix bogus failure-return value from lo_create, per report from Gavin
Tom Lane [Mon, 17 Sep 2001 20:05:47 +0000 (20:05 +0000)]
Fix bogus failure-return value from lo_create, per report from Gavin
Sherry.  Also clean up leakage of open files and LOs in failure exits
from lo_import and lo_export.

23 years agoAttached is a patch that fixes ResultSetMetaData.isNullable() in
Bruce Momjian [Mon, 17 Sep 2001 15:56:11 +0000 (15:56 +0000)]
Attached is a patch that fixes ResultSetMetaData.isNullable() in
the JDBC driver.

This method is currently unimplemented and always returns
ResultSetMetaData.columnNullable. This is obviously incorrect
when a column is defined with NOT NULL or PRIMARY KEY. And we
have to think of check constraints, views, functions etc.

The patch simply changes the return value to
ResultSetMetaData.columnNullableUnknown. This is until someone
comes up with a real implementation of course.

On Fri, 14 Sep 2001 17:53:50 +0200, Tomisaw Kity?ski wrote:
>Hello there,
>
>could someone tell me, please, do I have any chance to get
>proper implementation of above method in JDBC (1.1+) soon?
>
>Current "return 1" works fine on most tables, however it seems
>to be a little bit incorrect with some of them ;)

Ren? Pijlman

23 years agoI'm attaching a patch which fixes the corruption in strings caused
Bruce Momjian [Mon, 17 Sep 2001 15:54:50 +0000 (15:54 +0000)]
I'm attaching a patch which fixes the corruption in strings caused
by escape processing in the SQL statement. I've tested this for a
while now and it appears to work well. Previously string data
with {d was getting corrupt as the {d was being stripped regardless
of whether it was an escape code or not.

I also added checking for time and timestamp escape processing strings
as per 11.3 in the specification. The patch is against the latest
CVS.

Thomas O'Dowd

23 years agoChange vacuumlo to take 'lo' type into account.
Hiroshi Inoue [Mon, 17 Sep 2001 02:30:54 +0000 (02:30 +0000)]
Change vacuumlo to take 'lo' type into account.

23 years agoChange FixupBlobXrefs() to take 'lo' type into account.
Hiroshi Inoue [Mon, 17 Sep 2001 02:07:51 +0000 (02:07 +0000)]
Change FixupBlobXrefs() to take 'lo' type into account.

23 years agoSimplify and clean up FigureColname; make it work without coredumping
Tom Lane [Mon, 17 Sep 2001 01:06:36 +0000 (01:06 +0000)]
Simplify and clean up FigureColname; make it work without coredumping
for TypeCast case.

23 years agoUse portable putenv(), not unportable setenv().
Tom Lane [Mon, 17 Sep 2001 00:42:42 +0000 (00:42 +0000)]
Use portable putenv(), not unportable setenv().

23 years agoSuppress compiler warning.
Tom Lane [Mon, 17 Sep 2001 00:29:10 +0000 (00:29 +0000)]
Suppress compiler warning.

23 years agoUpdate documentation's info about location of our CVSROOT.
Tom Lane [Sun, 16 Sep 2001 23:52:29 +0000 (23:52 +0000)]
Update documentation's info about location of our CVSROOT.

23 years agoRussian translation from Serguei Mokhov
Peter Eisentraut [Sun, 16 Sep 2001 23:10:16 +0000 (23:10 +0000)]
Russian translation from Serguei Mokhov

23 years agoUpdate from Serguei Mokhov
Peter Eisentraut [Sun, 16 Sep 2001 23:06:33 +0000 (23:06 +0000)]
Update from Serguei Mokhov

23 years agoUpdate intro in face of TOAST.
Peter Eisentraut [Sun, 16 Sep 2001 22:53:52 +0000 (22:53 +0000)]
Update intro in face of TOAST.

23 years agoInstall dynamically loadable modules into a private subdirectory
Peter Eisentraut [Sun, 16 Sep 2001 16:11:11 +0000 (16:11 +0000)]
Install dynamically loadable modules into a private subdirectory
under libdir, for a cleaner separation in the installation layout
and compatibility with binary packaging standards.  Point backend's
default search location there.  The contrib modules are also
installed in the said location, giving them the benefit of the
default search path as well.  No changes in user interface
nevertheless.

23 years agoUpdate highlights. More items to add.
Bruce Momjian [Sun, 16 Sep 2001 04:26:22 +0000 (04:26 +0000)]
Update highlights.  More items to add.

23 years agoPoint to HISTORY File for current info.
Bruce Momjian [Sun, 16 Sep 2001 04:18:57 +0000 (04:18 +0000)]
Point to HISTORY File for current info.

23 years agoAdd list of 7.2 changes in preparation for beta.
Bruce Momjian [Sun, 16 Sep 2001 04:12:35 +0000 (04:12 +0000)]
Add list of 7.2 changes in preparation for beta.

23 years agoupdates
Peter Eisentraut [Sat, 15 Sep 2001 19:56:59 +0000 (19:56 +0000)]
updates

23 years agoMarkup examples as examples.
Peter Eisentraut [Sat, 15 Sep 2001 16:08:59 +0000 (16:08 +0000)]
Markup examples as examples.

23 years agoMarkup examples as examples. Fix formatting of examples.
Peter Eisentraut [Sat, 15 Sep 2001 00:48:59 +0000 (00:48 +0000)]
Markup examples as examples.  Fix formatting of examples.

23 years agoSome formatting changes, add CSS stylesheet. Include indexes in
Peter Eisentraut [Fri, 14 Sep 2001 20:37:55 +0000 (20:37 +0000)]
Some formatting changes, add CSS stylesheet.  Include indexes in
documentation tarball builds.

23 years ago> Here's a revised patch. Changes:
Bruce Momjian [Fri, 14 Sep 2001 17:46:40 +0000 (17:46 +0000)]
> Here's a revised patch. Changes:
>
> 1. Now outputs '\\' instead of '\134' when using encode(bytea, 'escape')
> Note that I ended up leaving \0 as \000 so that there are no ambiguities
> when decoding something like, for example, \0123.
>
> 2. Fixed bug in byteain which allowed input values which were not valid
> octals (e.g. \789), to be parsed as if they were octals.
>
> Joe
>

Here's rev 2 of the bytea string support patch. Changes:

1. Added missing declaration for MatchBytea function
2. Added PQescapeBytea to fe-exec.c
3. Applies cleanly on cvs tip from this afternoon

I'm hoping that someone can review/approve/apply this before beta starts, so
I guess I'd vote (not that it counts for much) to delay beta a few days :-)

Joe Conway

23 years agoAllow '1' in jdbc2 boolean test.
Bruce Momjian [Fri, 14 Sep 2001 17:40:41 +0000 (17:40 +0000)]
Allow '1' in jdbc2 boolean test.

23 years agoRemove --enable-unicode-conversion
Tatsuo Ishii [Fri, 14 Sep 2001 10:36:52 +0000 (10:36 +0000)]
Remove --enable-unicode-conversion
unicode-conversion is always on if --enable-multibyte is specified

   Tatsuo Ishii

23 years agoAdd semicolon
Tatsuo Ishii [Fri, 14 Sep 2001 10:28:09 +0000 (10:28 +0000)]
Add semicolon

23 years agoFix typo.
Tatsuo Ishii [Fri, 14 Sep 2001 10:24:35 +0000 (10:24 +0000)]
Fix typo.

23 years agoFix exmaple
Tatsuo Ishii [Fri, 14 Sep 2001 09:49:00 +0000 (09:49 +0000)]
Fix exmaple

    Tatsuo Ishii

23 years agoFix show message
Tatsuo Ishii [Fri, 14 Sep 2001 08:47:00 +0000 (08:47 +0000)]
Fix show message

    Tatsuo Ishii

23 years agoAdd semicolon
Tatsuo Ishii [Fri, 14 Sep 2001 08:24:29 +0000 (08:24 +0000)]
Add semicolon

    Tatsuo Ishii

23 years agoExample rules do not work.
Tatsuo Ishii [Fri, 14 Sep 2001 08:19:55 +0000 (08:19 +0000)]
Example rules do not work.

CREATE RULE bad_rule_combination_1 AS
    ON SELECT TO emp
    DO INSTEAD
        SELECT * FROM toyemp;

CREATE RULE bad_rule_combination_2 AS
    ON SELECT TO toyemp
    DO INSTEAD
        SELECT * FROM emp;

Tatsuo Ishii

23 years agoAdd semicolon
Tatsuo Ishii [Fri, 14 Sep 2001 08:05:55 +0000 (08:05 +0000)]
Add semicolon

23 years agoAdd semicolon
Tatsuo Ishii [Fri, 14 Sep 2001 07:59:31 +0000 (07:59 +0000)]
Add semicolon

    Tatsuo Ishii

23 years agoChange an *if condition*.
Hiroshi Inoue [Fri, 14 Sep 2001 06:46:45 +0000 (06:46 +0000)]
Change an *if condition*.

Hiroshi Inoue

23 years ago1) Improve the implementation of *Disallow Premature* for
Hiroshi Inoue [Fri, 14 Sep 2001 06:30:37 +0000 (06:30 +0000)]
1) Improve the implementation of *Disallow Premature* for
   older versions of servers.
2) Implement SQLProcedures.

Hiroshi Inoue

23 years agoUpdate TODO list.
Bruce Momjian [Fri, 14 Sep 2001 03:21:42 +0000 (03:21 +0000)]
Update TODO list.

23 years agoFix a coversation error with pre 6.4 versions.
Hiroshi Inoue [Fri, 14 Sep 2001 01:50:33 +0000 (01:50 +0000)]
Fix a coversation error with pre 6.4 versions.

Hiroshi Inoue

23 years agoUpdate TODO list.
Bruce Momjian [Fri, 14 Sep 2001 01:23:14 +0000 (01:23 +0000)]
Update TODO list.

23 years agoUpdate TODO list.
Bruce Momjian [Fri, 14 Sep 2001 00:41:06 +0000 (00:41 +0000)]
Update TODO list.

23 years agoAdd missing paren to ODBC compiles.
Bruce Momjian [Thu, 13 Sep 2001 22:39:29 +0000 (22:39 +0000)]
Add missing paren to ODBC compiles.

23 years agoUpdate compatibility information.
Peter Eisentraut [Thu, 13 Sep 2001 19:40:34 +0000 (19:40 +0000)]
Update compatibility information.

23 years agoUpdate compatibility information.
Peter Eisentraut [Thu, 13 Sep 2001 19:05:29 +0000 (19:05 +0000)]
Update compatibility information.

23 years agoUpdate compatibility information.
Peter Eisentraut [Thu, 13 Sep 2001 18:17:44 +0000 (18:17 +0000)]
Update compatibility information.

23 years agoDidn't want that jdbc patch in there yet.
Bruce Momjian [Thu, 13 Sep 2001 17:01:31 +0000 (17:01 +0000)]
Didn't want that jdbc patch in there yet.

23 years ago> I found a problem with PQescapeString (I think). Since it escapes
Bruce Momjian [Thu, 13 Sep 2001 17:00:34 +0000 (17:00 +0000)]
> I found a problem with PQescapeString (I think). Since it escapes
> null bytes to be literally '\0', the following can happen:
> 1. User inputs string value as "<null byte>##" where ## are digits in the
> range of 0 to 7.
> 2. PQescapeString converts this to "\0##"
> 3. Escaped string is used in a context that causes "\0##" to be evaluated as
> an octal escape sequence.

I agree that this is a problem, though it is not possible to do
anything harmful with it.  In addition, it only occurs if there are
any NUL characters in its input, which is very unlikely if you are
using C strings.

The patch below addresses the issue by removing escaping of \0
characters entirely.

> If the goal is to "safely" encode null bytes, and preserve the rest of the
> string as it was entered, I think the null bytes should be escaped as \\000
> (note that if you simply use \000 the same string truncation problem
> occurs).

We can't do that, this would require 4n + 1 bytes of storage for the
result, breaking the interface.

Florian Weimer

23 years agoReplace ASCII-quotes with proper markup.
Peter Eisentraut [Thu, 13 Sep 2001 15:55:24 +0000 (15:55 +0000)]
Replace ASCII-quotes with proper markup.

23 years ago1) Not export ODBC 3.0 functions.
Hiroshi Inoue [Thu, 13 Sep 2001 00:27:11 +0000 (00:27 +0000)]
1) Not export ODBC 3.0 functions.
2) (Maybe) fix a bug reported by Mika Muntila.

23 years ago'chown -R postgres /usr/local/pgsql' is wrong. Need to do some more typing.
Peter Eisentraut [Wed, 12 Sep 2001 20:57:28 +0000 (20:57 +0000)]
'chown -R postgres /usr/local/pgsql' is wrong.  Need to do some more typing.

23 years agoAttached patch is correction for 'doc/jdbc.sgml' of PostgreSQL 7.1.3.
Bruce Momjian [Wed, 12 Sep 2001 15:55:00 +0000 (15:55 +0000)]
Attached patch is correction for 'doc/jdbc.sgml' of PostgreSQL 7.1.3.

Correction content:
  * I revised a mistake of type (copy and paste).
  * I revised multiplicity of description.

Ryouichi Matsuda

23 years agoFollowings are proposed fixes to jdbc.sgml(line numbers are for 7.1.3
Bruce Momjian [Wed, 12 Sep 2001 15:49:10 +0000 (15:49 +0000)]
Followings are proposed fixes to jdbc.sgml(line numbers are for 7.1.3
doc).

Hiroyuki Yatabe

23 years agomax_locks_per_transaction seems to be a more consistent name than
Peter Eisentraut [Wed, 12 Sep 2001 14:06:37 +0000 (14:06 +0000)]
max_locks_per_transaction seems to be a more consistent name than
max_locks_per_xact.

23 years agoCheck both -lrt and -lposix4 for fdatasync, to cover all Solaris versions.
Peter Eisentraut [Wed, 12 Sep 2001 12:14:41 +0000 (12:14 +0000)]
Check both -lrt and -lposix4 for fdatasync, to cover all Solaris versions.

23 years agoIt is not fixed and I doubt that it is working fine in current CVS. The
Bruce Momjian [Wed, 12 Sep 2001 04:01:57 +0000 (04:01 +0000)]
It is not fixed and I doubt that it is working fine in current CVS. The
bugfix is in the attached patch. Please apply it. Thanks.

 Output must be:

test=# SELECT to_char(485, 'RN');
     to_char
-----------------
         CDLXXXV
(1 row)

test=# SELECT to_char(485, 'FMRN');
 to_char
---------
 CDLXXXV
(1 row)

test=# SELECT to_char(1000, 'RN');
     to_char
-----------------
               M
(1 row)

test=# SELECT to_char(7.2, '"Welcome to"9.9 "release! :-)"');
           to_char
-----------------------------
 Welcome to 7.2 release! :-)
(1 row)

Karel Zak

23 years agoHere's some matching documentation, including some other
Bruce Momjian [Wed, 12 Sep 2001 03:58:15 +0000 (03:58 +0000)]
Here's some matching documentation, including some other
undocumented items in TD.

Should doc patches alse be sent to pgsql-patches, or do I
have to subscribe to pgsql-docs?

The archive link for pgsql-patches is broken, and I don't
see any patches in spot checking the archive for pgsql-docs.

-Brad McLean.

23 years agoI noticed that plpython does not make the relid available inside
Bruce Momjian [Wed, 12 Sep 2001 03:03:25 +0000 (03:03 +0000)]
I noticed that plpython does not make the relid available inside
a trigger the way that pltcl does.

Here's a little patch that adds it in.

-Brad McLean

23 years agoFix typo (add ;)
Tatsuo Ishii [Wed, 12 Sep 2001 02:13:25 +0000 (02:13 +0000)]
Fix typo (add ;)

23 years agoFix typo (add ;)
Tatsuo Ishii [Wed, 12 Sep 2001 01:55:25 +0000 (01:55 +0000)]
Fix typo (add ;)

23 years agoFix typo.
Tatsuo Ishii [Wed, 12 Sep 2001 01:22:25 +0000 (01:22 +0000)]
Fix typo.

23 years agoLink ODBC driver with -lnsl and -lsocket, for Solaris.
Peter Eisentraut [Tue, 11 Sep 2001 23:27:10 +0000 (23:27 +0000)]
Link ODBC driver with -lnsl and -lsocket, for Solaris.

reported by Bob Deblier (bob@virtualunlimited.com)

23 years agoUse gcc -shared rather than gcc -G for shared library linking on Solaris.
Peter Eisentraut [Tue, 11 Sep 2001 23:20:41 +0000 (23:20 +0000)]
Use gcc -shared rather than gcc -G for shared library linking on Solaris.

suggested by Bob Deblier (bob@virtualunlimited.com)

23 years agoInvoke on_exit() with correct number and type of arguments.
Peter Eisentraut [Tue, 11 Sep 2001 23:08:07 +0000 (23:08 +0000)]
Invoke on_exit() with correct number and type of arguments.

23 years agoLook for fdatasync() in librt, for Solaris.
Peter Eisentraut [Tue, 11 Sep 2001 14:31:23 +0000 (14:31 +0000)]
Look for fdatasync() in librt, for Solaris.

partially from Kenji Sugita

23 years agoFix some multibyte related bugs.
Hiroshi Inoue [Tue, 11 Sep 2001 06:39:20 +0000 (06:39 +0000)]
Fix some multibyte related bugs.
Psqlodbc is 7.01.0007 now.

Hiroshi Inoue

23 years agoImplement following item in TODO:
Tatsuo Ishii [Tue, 11 Sep 2001 05:18:59 +0000 (05:18 +0000)]
Implement following item in TODO:

* Reject character sequences those are not valid in their charset

23 years agoAdd single quote (example given here does not work)
Tatsuo Ishii [Tue, 11 Sep 2001 05:11:59 +0000 (05:11 +0000)]
Add single quote (example given here does not work)

23 years agoUpdate TODO list.
Bruce Momjian [Tue, 11 Sep 2001 05:09:45 +0000 (05:09 +0000)]
Update TODO list.

23 years agoImplement following item in TODO:
Tatsuo Ishii [Tue, 11 Sep 2001 04:50:36 +0000 (04:50 +0000)]
Implement following item in TODO:

* Reject character sequences those are not valid in their charset

23 years agoFix regression test in the case of building as root.
Tatsuo Ishii [Tue, 11 Sep 2001 02:24:52 +0000 (02:24 +0000)]
Fix regression test in the case of building as root.

23 years agoWhen testing for source and build tree equality, and test -ef doesn't work,
Peter Eisentraut [Mon, 10 Sep 2001 23:52:04 +0000 (23:52 +0000)]
When testing for source and build tree equality, and test -ef doesn't work,
fall back to `cd $srcdir && /bin/pwd` = `/bin/pwd`.  One of these ought to
work, and if not, prep_buildtree is harmless.

23 years agoMake prep_buildtree harmless when run on top of the source tree.
Peter Eisentraut [Mon, 10 Sep 2001 23:28:59 +0000 (23:28 +0000)]
Make prep_buildtree harmless when run on top of the source tree.

from Ian Lance Taylor

23 years agoAdd explicit '-print' to 'find' commands.
Peter Eisentraut [Mon, 10 Sep 2001 22:25:48 +0000 (22:25 +0000)]
Add explicit '-print' to 'find' commands.

(partially) from Ian Lance Taylor

23 years agoMarkup and spell-check run over Programmer's Guide (rather incomplete still).
Peter Eisentraut [Mon, 10 Sep 2001 21:58:47 +0000 (21:58 +0000)]
Markup and spell-check run over Programmer's Guide (rather incomplete still).

23 years agoRemove extra space at end of line.
Peter Eisentraut [Mon, 10 Sep 2001 19:34:18 +0000 (19:34 +0000)]
Remove extra space at end of line.

23 years agoUpdate TODO list.
Bruce Momjian [Mon, 10 Sep 2001 15:21:20 +0000 (15:21 +0000)]
Update TODO list.

23 years agoAttached is a patch that fixes DatabaseMetaDataTest in the JDBC
Bruce Momjian [Mon, 10 Sep 2001 15:07:58 +0000 (15:07 +0000)]
Attached is a patch that fixes DatabaseMetaDataTest in the JDBC
driver's test suite. With previous patches applied, this reduces
the number of failures of the test suite from 6 to 4. The patch
fixes the test case itself, rather than the driver.

Details:

1) The driver correctly provided DatabaseMetaData about the sort
order of NULLs. This was confirmed by Peter Eisentraut on
pgsql-hackers. I fixed the test to accept/require the current
behaviour, and made it dependent on the backend version. See
nullsAreSortedAtStart(), nullsAreSortedAtEnd(),
nullsAreSortedHigh() and nullsAreSortedLow().

2) DatabaseMetaData.supportsOrderByUnrelated() correctly
returned true (an ORDER BY clause can contain columns that are
not in the SELECT clause), but the test case required false.
Fixed that.

3) Replaced deprecated assert() of junit.framework.TestCase by
assertEquals(), assertTrue() and assertNotNull(). This is
because assert will be a new keyword in Java 1.4.

4) Replaced assert(message,false) by the more elegant
fail(message).

Regards,
Ren? Pijlman <rene@lab.applinet.nl>

23 years agoAttached is a patch to add bytea support to JDBC.
Bruce Momjian [Mon, 10 Sep 2001 15:07:05 +0000 (15:07 +0000)]
Attached is a patch to add bytea support to JDBC.

This patch does the following:

- Adds binary datatype support (bytea)
- Changes getXXXStream()/setXXXStream() methods to be spec compliant
- Adds ability to revert to old behavior

Details:

Adds support for the binary type bytea.  The ResultSet.getBytes() and
PreparedStatement.setBytes() methods now work against columns of bytea
type.  This is a change in behavior from the previous code which assumed
the column type was OID and thus a LargeObject.  The new behavior is
more complient with the JDBC spec as BLOB/CLOB are to be used for
LargeObjects and the getBytes()/setBytes() methods are for the databases
binary datatype (which is bytea in postgres).

Changes the behavior of the getBinaryStream(), getAsciiStream(),
getCharacterStream(), getUnicodeStream() and their setXXXStream()
counterparts.  These methos now work against either the bytea type
(BinaryStream) or the text types (AsciiStream, CharacterStream,
UnicodeStream).  The previous behavior was that these all assumed the
underlying column was of type OID and thus a LargeObject.  The
spec/javadoc for these methods indicate that they are for LONGVARCHAR
and LONGVARBINARY datatypes, which are distinct from the BLOB/CLOB
datatypes.  Given that the bytea and text types support upto 1G, they
are the LONGVARBINARY and LONGVARCHAR datatypes in postgres.

Added support for turning off the above new functionality.  Given that
the changes above are not backwardly compatible (however they are more
spec complient), I added the ability to revert back to the old behavior.
  The Connection now takes an optional parameter named 'compatible'.  If
the value of '7.1' is passed, the driver reverts to the 7.1 behavior.
If the parameter is not passed or the value '7.2' is passed the behavior
is the new behavior.  The mechanism put in place can be used in the
future when/if similar needs arise to change behavior.  This is
patterned after how Oracle does this (i.e. Oracle has a 'compatible'
parameter that behaves in a similar manner).

Misc fixes.  Cleaned up a few things I encountered along the way.

Note that in testing the patch I needed to ignore whitespace differences
in order to get it to apply cleanly (i.e. patch -l -i byteapatch.diff).
Also this patch introduces a new file
(src/interfaces/jdbc/org/postgresql/util/PGbytea.java).

Barry Lind

23 years agoOn Fri, 07 Sep 2001 01:34:46 -0400, Tom Lane wrote:
Bruce Momjian [Mon, 10 Sep 2001 14:55:08 +0000 (14:55 +0000)]
On Fri, 07 Sep 2001 01:34:46 -0400, Tom Lane wrote:
>there is still an unpatched reference to pg_description in
>getColumns(), in both jdbc1 and jdbc2.

This was introduced by Jeroen's patch (see
http://fts.postgresql.org/db/mw/msg.html?mid=1032468). Attached
is a patch that returns getColumns() to using "select
obj_description()" instead of direct access to pg_description,
as per the request by Tom.

I've incorporated Jeroen's fix to left outer join with
pg_attrdef instead of inner join, so getColumns() also returns
columns without a default value.

I have, however, not included Jeroen's attempt to combine
multiple queries into one huge multi-join query for better
performance, because:
1) I don't know how to do that using obj_description() instead
of direct access to pg_description
2) I don't think a performance improvement (if any) in this
method is very important

Because of the outer join, getColumns() will only work with a
backend >= 7.1. Since the conditional coding for 7.1/7.2 and
jdbc1/jdbc2 is already giving me headaches I didn't pursue a
pre-7.1 solution.

Regards,
Ren? Pijlman <rene@lab.applinet.nl>

23 years agoAttached is a patch that fixes
Bruce Momjian [Mon, 10 Sep 2001 14:54:22 +0000 (14:54 +0000)]
Attached is a patch that fixes
ConnectionTest.testTransactionIsolation() in the JDBC driver's
test suite. This reduces the number of failures of the test
suite from 7 to 6. The patch fixes the test case itself, rather
than the driver.

In addition to the change described in my posting below, I fixed
the part of the test with autocommit enabled. The author of the
test assumed that setting the transaction isolation level would
have no effect, but in fact it does. Perhaps the test case
worked with pre-7.1 behaviour, when the JDBC driver set the
isolation level in every transaction, instead of using "set
session characteristics". Anyway, now it works with a backend
built from current CVS and the behaviour is JDBC compliant.

I also extended the test case by changing the isolation level
before beginning a transaction and verifying it inside the
transaction.

Regards,
Ren? Pijlman

23 years agoBug #1: attribute name when column is type cast:
Bruce Momjian [Mon, 10 Sep 2001 14:53:10 +0000 (14:53 +0000)]
Bug #1: attribute name when column is type cast:

Given the following table:

test=# \d f
          Table "f"
 Column |  Type   | Modifiers
--------+---------+-----------
 i      | integer |
 test   | text    |

If I do the following:

test=# insert into f values(1,'test');
INSERT 139549 1
test=# select i::int8,test from f;
 ?column? | test
----------+------
        1 | test
(1 row)

It doesn't make much sense that the first column should be called
'?column?'.

The patch results in the output appearing like this:

test=# select i::int8,test from f;
 i | test
---+------
 1 | test
(1 row)

----------

Gavin Sherry

23 years ago> NOTE: in the command.c in three places there (I believe) is a typo:
Bruce Momjian [Mon, 10 Sep 2001 14:51:33 +0000 (14:51 +0000)]
> NOTE: in the command.c in three places there (I believe) is a typo:
>
> "parse error at [the] end of line"
>
> Attached patch also fixes it. I noticed this while editing the po file.
> If I'm wrong, please ignore the command.c.patch. I will revert my translation
> as well then.
>
> --
> Serguei A. Mokhov

23 years agoThe attached patch should be sufficient to fix libpgtcl. It requires
Bruce Momjian [Mon, 10 Sep 2001 14:49:12 +0000 (14:49 +0000)]
The attached patch should be sufficient to fix libpgtcl. It requires
PostgreSQL to support unicode-conversion, but retains binary
compatibility among Tcl versions.

However, it neither checks at compile time not at runtime, if support
for unicode-conversion does really exist and it doesn't prevent the
user from changing the client encoding after initialization. I think
there should be warnings about this somewhere in the documentation.

Reinhard Max

23 years agoChange dialog windows.
Hiroshi Inoue [Mon, 10 Sep 2001 10:13:30 +0000 (10:13 +0000)]
Change dialog windows.

23 years ago1) Fix SQLForeignKeys() in multibyte mode.
Hiroshi Inoue [Mon, 10 Sep 2001 08:53:27 +0000 (08:53 +0000)]
1) Fix SQLForeignKeys() in multibyte mode.
2) Fix a bug with NUMERIC scale in case of Parse
  statement option.
3) Remove a no longer needed loop in CC_send_query().

Hiroshi Inoue

23 years agoShort version of install procedure fails due to lacking chown.
Tatsuo Ishii [Mon, 10 Sep 2001 08:46:46 +0000 (08:46 +0000)]
Short version of install procedure fails due to lacking chown.

23 years agoThe usage of kill is incorrect (lacks "data"). Anyway we should use
Tatsuo Ishii [Mon, 10 Sep 2001 07:17:01 +0000 (07:17 +0000)]
The usage of kill is incorrect (lacks "data"). Anyway we should use
pg_ctl instead.

23 years agoFix typo. split does not produce ".".
Tatsuo Ishii [Mon, 10 Sep 2001 07:11:28 +0000 (07:11 +0000)]
Fix typo. split does not produce ".".

23 years agoFix typo.
Tatsuo Ishii [Mon, 10 Sep 2001 06:35:34 +0000 (06:35 +0000)]
Fix typo.

23 years agoExample program lacks RETURN
Tatsuo Ishii [Mon, 10 Sep 2001 06:30:43 +0000 (06:30 +0000)]
Example program lacks RETURN

23 years agoFix typo.
Tatsuo Ishii [Mon, 10 Sep 2001 05:57:22 +0000 (05:57 +0000)]
Fix typo.

23 years agoFix typo.
Tatsuo Ishii [Mon, 10 Sep 2001 05:46:41 +0000 (05:46 +0000)]
Fix typo.

23 years agoFix initlocation messages
Tatsuo Ishii [Mon, 10 Sep 2001 05:20:23 +0000 (05:20 +0000)]
Fix initlocation messages

23 years agoRemove INV_ARCHIVE mention in python readme.
Bruce Momjian [Mon, 10 Sep 2001 04:21:14 +0000 (04:21 +0000)]
Remove INV_ARCHIVE mention in python readme.

23 years agoRemove INV_ARCHIVE mention in perl.
Bruce Momjian [Mon, 10 Sep 2001 04:19:19 +0000 (04:19 +0000)]
Remove INV_ARCHIVE mention in perl.

23 years agoRemove mention of INV_ARCHIVE.
Bruce Momjian [Mon, 10 Sep 2001 04:15:41 +0000 (04:15 +0000)]
Remove mention of INV_ARCHIVE.

23 years agofix typo.
Tatsuo Ishii [Mon, 10 Sep 2001 03:02:06 +0000 (03:02 +0000)]
fix typo.

23 years agoAdd missing ';'
Tatsuo Ishii [Mon, 10 Sep 2001 02:46:18 +0000 (02:46 +0000)]
Add missing ';'

23 years agoUpdate TODO list.
Bruce Momjian [Mon, 10 Sep 2001 02:02:37 +0000 (02:02 +0000)]
Update TODO list.

23 years agoUpdate TODO list.
Bruce Momjian [Mon, 10 Sep 2001 00:14:29 +0000 (00:14 +0000)]
Update TODO list.

23 years agoMarkup additions and spell check. (covers Admin Guide)
Peter Eisentraut [Sun, 9 Sep 2001 23:52:12 +0000 (23:52 +0000)]
Markup additions and spell check. (covers Admin Guide)