]>
granicus.if.org Git - fortune-mod/log
Shlomi Fish [Fri, 1 May 2020 10:24:28 +0000 (13:24 +0300)]
Require snprintf() without detection.
It is C99.
Shlomi Fish [Fri, 1 May 2020 10:17:51 +0000 (13:17 +0300)]
replace sprintf with snprintf - minor security change
Shlomi Fish [Thu, 30 Apr 2020 08:06:26 +0000 (11:06 +0300)]
prepare for the new release
Shlomi Fish [Thu, 30 Apr 2020 08:01:38 +0000 (11:01 +0300)]
detect snprintf
Shlomi Fish [Thu, 30 Apr 2020 07:24:25 +0000 (10:24 +0300)]
refactoringgot rid of == NULL
Shlomi Fish [Thu, 30 Apr 2020 07:05:32 +0000 (10:05 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Thu, 30 Apr 2020 06:46:56 +0000 (09:46 +0300)]
Extract a method or a function.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Thu, 30 Apr 2020 06:37:39 +0000 (09:37 +0300)]
Extract a method or a function.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Thu, 30 Apr 2020 06:19:19 +0000 (09:19 +0300)]
Some minor fixes from OpenBSD's fortune sources.
Thanks!
Shlomi Fish [Wed, 29 Apr 2020 20:56:40 +0000 (23:56 +0300)]
license an original file better
Shlomi Fish [Wed, 29 Apr 2020 20:52:51 +0000 (23:52 +0300)]
add a regression test for an overflow
Shlomi Fish [Wed, 29 Apr 2020 20:35:59 +0000 (23:35 +0300)]
add a regression test for an overflow
Shlomi Fish [Wed, 29 Apr 2020 20:30:49 +0000 (23:30 +0300)]
Add a regression test for the buffer overflow.
Shlomi Fish [Wed, 29 Apr 2020 12:57:59 +0000 (15:57 +0300)]
prepare for the new release
Shlomi Fish [Wed, 29 Apr 2020 12:57:14 +0000 (15:57 +0300)]
silence warnings on !WITH_RECODE.
Thanks to appveyor.
Shlomi Fish [Wed, 29 Apr 2020 12:36:33 +0000 (15:36 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 12:31:53 +0000 (15:31 +0300)]
Refactoring / code cleanup.
* https://en.wikipedia.org/wiki/Code_refactoring
Some small optimisations may have slipped in as well.
do_free is simply free; copy() was underused.
Shlomi Fish [Wed, 29 Apr 2020 12:19:38 +0000 (15:19 +0300)]
Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Wed, 29 Apr 2020 12:12:39 +0000 (15:12 +0300)]
update the file "cookie-files"
Shlomi Fish [Wed, 29 Apr 2020 11:42:29 +0000 (14:42 +0300)]
Extract a common expression into a variable/const.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Wed, 29 Apr 2020 11:34:45 +0000 (14:34 +0300)]
remove unused and disabled code
Shlomi Fish [Wed, 29 Apr 2020 11:33:51 +0000 (14:33 +0300)]
correct typo.
Shlomi Fish [Wed, 29 Apr 2020 11:27:54 +0000 (14:27 +0300)]
Rename variable/s to make them more descriptive.
Shlomi Fish [Wed, 29 Apr 2020 11:22:14 +0000 (14:22 +0300)]
refactoring + security: avoid overflow
Shlomi Fish [Wed, 29 Apr 2020 11:14:28 +0000 (14:14 +0300)]
security: avoid overflow
Shlomi Fish [Wed, 29 Apr 2020 10:50:58 +0000 (13:50 +0300)]
Silence compile-time or run-time warnings.
See:
* https://duckduckgo.com/?q=warnings+programming&atb=v140-1&ia=web
They are a distraction at best and may indicate other issues.
Shlomi Fish [Wed, 29 Apr 2020 10:49:09 +0000 (13:49 +0300)]
refactoring: was always true
Shlomi Fish [Wed, 29 Apr 2020 10:23:25 +0000 (13:23 +0300)]
refactoring: merge cmake install targets
Shlomi Fish [Wed, 29 Apr 2020 10:20:37 +0000 (13:20 +0300)]
Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Wed, 29 Apr 2020 10:01:51 +0000 (13:01 +0300)]
remove or rename old man pages.
To avoid cluttering the source dirs.
Shlomi Fish [Wed, 29 Apr 2020 09:35:14 +0000 (12:35 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 09:11:03 +0000 (12:11 +0300)]
rename vars
Shlomi Fish [Wed, 29 Apr 2020 09:05:03 +0000 (12:05 +0300)]
travis+appveyor cleanups
Shlomi Fish [Wed, 29 Apr 2020 08:53:41 +0000 (11:53 +0300)]
add cache to travis cpan modules
Shlomi Fish [Wed, 29 Apr 2020 08:46:24 +0000 (11:46 +0300)]
avoid predecls
Shlomi Fish [Wed, 29 Apr 2020 08:43:00 +0000 (11:43 +0300)]
Rename variable/s to make them more descriptive.
Shlomi Fish [Wed, 29 Apr 2020 08:32:07 +0000 (11:32 +0300)]
Avoid predeclaring variables and localize their decl.
See:
* http://perl-begin.org/tutorials/bad-elements/#declaring_all_vars_at_top
* https://en.wikipedia.org/wiki/Perl_Best_Practices
Shlomi Fish [Wed, 29 Apr 2020 08:30:11 +0000 (11:30 +0300)]
Avoid predeclaring variables and localize their decl.
See:
* http://perl-begin.org/tutorials/bad-elements/#declaring_all_vars_at_top
* https://en.wikipedia.org/wiki/Perl_Best_Practices
Shlomi Fish [Wed, 29 Apr 2020 08:20:26 +0000 (11:20 +0300)]
add braces
Shlomi Fish [Wed, 29 Apr 2020 08:11:49 +0000 (11:11 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 08:06:34 +0000 (11:06 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 08:03:35 +0000 (11:03 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 07:50:44 +0000 (10:50 +0300)]
Avoid predeclaring variables and localize their decl.
See:
* http://perl-begin.org/tutorials/bad-elements/#declaring_all_vars_at_top
* https://en.wikipedia.org/wiki/Perl_Best_Practices
Shlomi Fish [Wed, 29 Apr 2020 07:33:56 +0000 (10:33 +0300)]
refactoring
Shlomi Fish [Wed, 29 Apr 2020 07:22:54 +0000 (10:22 +0300)]
remove useless comment
Shlomi Fish [Mon, 6 Apr 2020 11:24:07 +0000 (14:24 +0300)]
avoid cmake warnings
Shlomi Fish [Sat, 4 Apr 2020 18:45:09 +0000 (21:45 +0300)]
bump version
Shlomi Fish [Sat, 4 Apr 2020 18:38:44 +0000 (21:38 +0300)]
remove dups - bug fix / optimize
Shlomi Fish [Sat, 4 Apr 2020 18:29:09 +0000 (21:29 +0300)]
Extract a method or a function.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Sat, 4 Apr 2020 18:14:48 +0000 (21:14 +0300)]
Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Sat, 4 Apr 2020 18:05:18 +0000 (21:05 +0300)]
Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Sat, 4 Apr 2020 17:49:43 +0000 (20:49 +0300)]
elim -D_FORTIFY_SOURCE warnings.
Shlomi Fish [Sat, 4 Apr 2020 14:58:40 +0000 (17:58 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://github.com/shlomif/Docker-CLI-Wrapper .
Shlomi Fish [Sat, 4 Apr 2020 08:53:14 +0000 (11:53 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://github.com/shlomif/Docker-CLI-Wrapper .
Shlomi Fish [Sat, 4 Apr 2020 08:12:54 +0000 (11:12 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://github.com/shlomif/Docker-CLI-Wrapper .
Shlomi Fish [Sat, 4 Apr 2020 07:50:00 +0000 (10:50 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://github.com/shlomif/Docker-CLI-Wrapper .
Shlomi Fish [Fri, 3 Apr 2020 17:49:20 +0000 (20:49 +0300)]
Extract a common class/struct.
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Fri, 3 Apr 2020 16:44:47 +0000 (19:44 +0300)]
Extract a common module/library/header.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Fri, 3 Apr 2020 11:26:43 +0000 (14:26 +0300)]
correct for fedora
Shlomi Fish [Tue, 31 Mar 2020 07:54:25 +0000 (10:54 +0300)]
Extract a method or a function.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Mon, 30 Mar 2020 10:31:33 +0000 (13:31 +0300)]
travis: fix build
Shlomi Fish [Mon, 30 Mar 2020 10:18:36 +0000 (13:18 +0300)]
pass through clang-format.
Shlomi Fish [Mon, 30 Mar 2020 09:04:31 +0000 (12:04 +0300)]
bump version
Shlomi Fish [Mon, 30 Mar 2020 09:01:04 +0000 (12:01 +0300)]
Extract a method or a function.
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
Shlomi Fish [Mon, 30 Mar 2020 08:51:25 +0000 (11:51 +0300)]
avoid double traversal.
Shlomi Fish [Sun, 29 Mar 2020 07:25:49 +0000 (10:25 +0300)]
add distributions install instructions
Shlomi Fish [Sat, 28 Mar 2020 18:16:16 +0000 (21:16 +0300)]
correct typos: "Khan"
Shlomi Fish [Mon, 23 Mar 2020 12:51:30 +0000 (14:51 +0200)]
update the DONE list in the README
Shlomi Fish [Wed, 18 Mar 2020 13:57:27 +0000 (15:57 +0200)]
fix docker script on fedora 31.
See:
https://fedoraproject.org/wiki/Bugs/Common#Docker_package_no_longer_available_and_will_not_run_by_default_.28due_to_switch_to_cgroups_v2.29
.
Shlomi Fish [Wed, 18 Mar 2020 13:13:54 +0000 (15:13 +0200)]
add a quote by Borges
Shlomi Fish [Mon, 2 Mar 2020 11:28:12 +0000 (13:28 +0200)]
fixes to docker-test - inst deps - seems to work
Shlomi Fish [Mon, 2 Mar 2020 10:06:24 +0000 (12:06 +0200)]
fixes to docker-test - progress
Shlomi Fish [Mon, 2 Mar 2020 09:53:25 +0000 (11:53 +0200)]
fixes to docker-test
Shlomi Fish [Mon, 2 Mar 2020 08:34:14 +0000 (10:34 +0200)]
install missing deps
Shlomi Fish [Mon, 2 Mar 2020 08:00:24 +0000 (10:00 +0200)]
update the code - to build debian pkg . not tested
Shlomi Fish [Sun, 1 Mar 2020 17:06:42 +0000 (19:06 +0200)]
add the prog to build deb pkgs - WiP
Shlomi Fish [Sun, 1 Mar 2020 17:05:56 +0000 (19:05 +0200)]
add the prog to build deb pkgs - WiP
Shlomi Fish [Sun, 1 Mar 2020 15:16:45 +0000 (17:16 +0200)]
update the todo list
Shlomi Fish [Fri, 28 Feb 2020 13:44:24 +0000 (15:44 +0200)]
add more credits
Shlomi Fish [Thu, 27 Feb 2020 14:30:54 +0000 (16:30 +0200)]
start writing the CREDITS file
Shlomi Fish [Thu, 27 Feb 2020 13:27:19 +0000 (15:27 +0200)]
address a question
Shlomi Fish [Wed, 26 Feb 2020 14:39:15 +0000 (16:39 +0200)]
avoid packaging tidyall.d+txz only
Shlomi Fish [Wed, 26 Feb 2020 14:36:16 +0000 (16:36 +0200)]
bump ver
Shlomi Fish [Wed, 26 Feb 2020 14:22:53 +0000 (16:22 +0200)]
remove backspaces [from debian]
See
https://salsa.debian.org/shlomif-guest/fortune-mod/-/tree/
6ad75a6553cbc9c4a5edb8d9cec45a0dc4622da5/debian/patches
.
Shlomi Fish [Wed, 26 Feb 2020 14:19:55 +0000 (16:19 +0200)]
add a patch for No_recode from debian.
See:
https://salsa.debian.org/shlomif-guest/fortune-mod/-/blob/
6ad75a6553cbc9c4a5edb8d9cec45a0dc4622da5/debian/patches/fortune.c.diff
.
Shlomi Fish [Wed, 26 Feb 2020 14:14:38 +0000 (16:14 +0200)]
add desktop file from debian.
See
https://salsa.debian.org/shlomif-guest/fortune-mod/-/blob/
6ad75a6553cbc9c4a5edb8d9cec45a0dc4622da5/debian/patches/desktop.diff
.
Shlomi Fish [Wed, 26 Feb 2020 14:10:22 +0000 (16:10 +0200)]
Apply patch for Leo Cohen lyrics from Debian.
See
https://salsa.debian.org/shlomif-guest/fortune-mod/-/blob/
6ad75a6553cbc9c4a5edb8d9cec45a0dc4622da5/debian/patches/Cohen.diff
.
Shlomi Fish [Wed, 26 Feb 2020 14:04:58 +0000 (16:04 +0200)]
Merge the mswindows portability fixes.
See:
https://github.com/shlomif/fortune-mod/tree/appveyor-mswindows-runtime-failure-reduce-branch
.
They were tested on appveyor.
Shlomi Fish [Wed, 26 Feb 2020 07:58:18 +0000 (09:58 +0200)]
Correct a misattribution.
Shlomi Fish [Mon, 24 Feb 2020 11:30:16 +0000 (13:30 +0200)]
appveyor crash debug - enable more warns
Shlomi Fish [Mon, 24 Feb 2020 10:18:27 +0000 (12:18 +0200)]
fix appveyor #3 syntax
Shlomi Fish [Mon, 24 Feb 2020 10:02:09 +0000 (12:02 +0200)]
debug appveyor #2 fail - separate up to make install
Shlomi Fish [Mon, 24 Feb 2020 09:39:12 +0000 (11:39 +0200)]
debug appveyor fail
Shlomi Fish [Sun, 23 Feb 2020 15:04:53 +0000 (17:04 +0200)]
travis fix #3: avoid default
Shlomi Fish [Sun, 23 Feb 2020 14:59:17 +0000 (16:59 +0200)]
travis fix #2: min ver of perl
Shlomi Fish [Sun, 23 Feb 2020 14:29:11 +0000 (16:29 +0200)]
travis fix #1: dist upgrade
Shlomi Fish [Sun, 23 Feb 2020 13:59:42 +0000 (15:59 +0200)]
bump version
Shlomi Fish [Thu, 30 Jan 2020 19:06:27 +0000 (21:06 +0200)]
Correct some broken grammar / spelling / syntax / etc.
See https://duckduckgo.com/?q=english+grammar&ia=web ;
https://duckduckgo.com/?q=english+spelling&ia=web and for the lighter side:
* https://www.youtube.com/watch?v=8Gv0H-vPoDc
* https://shlomif.livejournal.com/53966.html
* http://i.imgur.com/HL1ZR.jpg .
Shlomi Fish [Mon, 20 Jan 2020 19:01:24 +0000 (21:01 +0200)]
Correct some broken grammar / spelling / syntax / etc.
See https://duckduckgo.com/?q=english+grammar&ia=web ;
https://duckduckgo.com/?q=english+spelling&ia=web and for the lighter side:
* https://www.youtube.com/watch?v=8Gv0H-vPoDc
* https://shlomif.livejournal.com/53966.html
* http://i.imgur.com/HL1ZR.jpg .
Shlomi Fish [Sun, 19 Jan 2020 20:16:59 +0000 (22:16 +0200)]
appveyor fix 16 : win32 check something