]> granicus.if.org Git - postgresql/log
postgresql
16 years agoAdd item:
Bruce Momjian [Fri, 7 Mar 2008 19:03:39 +0000 (19:03 +0000)]
Add item:

>  o Store per-table autovacuum settings in pg_class.reloptions.
>
>    http://archives.postgresql.org/pgsql-hackers/2007-02/msg01440.php
>    http://archives.postgresql.org/pgsql-hackers/2008-01/msg00724.php

16 years agoAdd URL for:
Bruce Momjian [Fri, 7 Mar 2008 18:53:49 +0000 (18:53 +0000)]
Add URL for:

* Allow multiple identical NOTIFY events to always be communicated to the
  client, rather than sent as a single notification to the listener

  http://archives.postgresql.org/pgsql-general/2008-01/msg00057.php

16 years agoAdd:
Bruce Momjian [Fri, 7 Mar 2008 17:54:15 +0000 (17:54 +0000)]
Add:

>  o Add SQLSTATE severity to PGconn return status
>
>    http://archives.postgresql.org/pgsql-interfaces/2007-11/msg00015.php

16 years agoChange hashscan.c to keep its list of active hash index scans in
Tom Lane [Fri, 7 Mar 2008 15:59:03 +0000 (15:59 +0000)]
Change hashscan.c to keep its list of active hash index scans in
TopMemoryContext, rather than scattered through executor per-query contexts.
This poses no danger of memory leak since the ResourceOwner mechanism
guarantees release of no-longer-needed items.  It is needed because the
per-query context might already be released by the time we try to clean up
the hash scan list.  Report by ykhuang, diagnosis by Heikki.

Back-patch to 8.0, where the ResourceOwner-based cleanup was introduced.
The given test case does not fail before 8.2, probably because we rearranged
transaction abort processing somehow; but this coding is undoubtedly risky
so I'll patch 8.0 and 8.1 anyway.

16 years agoAdd:
Bruce Momjian [Fri, 7 Mar 2008 15:56:40 +0000 (15:56 +0000)]
Add:

>  o Have \l+ show database size, if permissions allow
>
>    Ideally it will not generate an error for invalid permissions
>

16 years agoAdd:
Bruce Momjian [Fri, 7 Mar 2008 14:57:39 +0000 (14:57 +0000)]
Add:

>
> * Add comments on system tables/columns using the information in
>   catalogs.sgml
>
>   Ideally the information would be pulled from the SGML file
>   automatically.
>

16 years agoFix memory arrangement of tsquery after removing stop words. It causes
Teodor Sigaev [Fri, 7 Mar 2008 14:30:20 +0000 (14:30 +0000)]
Fix memory arrangement  of tsquery after removing stop words. It causes
a unused memory holes in tsquery.

Per report by Richard Huxton <dev@archonet.com>.

It was working well because in fact tsquery->size is not used for any
kind of operation except comparing tsqueries. So, in HEAD it's enough to
fix to_tsquery function, but for previous version it's needed to
remove optimization in CompareTSQ to prevent requirement of renew all
stored tsquery.

16 years agoClearify PITR doc wording.
Bruce Momjian [Fri, 7 Mar 2008 01:46:41 +0000 (01:46 +0000)]
Clearify PITR doc wording.

16 years agoUpdate wording:
Bruce Momjian [Fri, 7 Mar 2008 01:06:55 +0000 (01:06 +0000)]
Update wording:

<  o Require all check constraints to be inherited
>  o Require all CHECK constraints to be inherited

16 years agoAdd:
Bruce Momjian [Fri, 7 Mar 2008 01:06:36 +0000 (01:06 +0000)]
Add:

>
>  o Require all check constraints to be inherited
>
>    http://archives.postgresql.org/pgsql-bugs/2007-04/msg00026.php

16 years agoAdd:
Bruce Momjian [Fri, 7 Mar 2008 00:10:13 +0000 (00:10 +0000)]
Add:

>  o Have \d show foreign keys that reference a table's primary key
>
>    http://archives.postgresql.org/pgsql-hackers/2007-04/msg00424.php
>
>  o Have \d show child tables that inherit from the specified parent

16 years agoAdd URL for:
Bruce Momjian [Thu, 6 Mar 2008 22:17:41 +0000 (22:17 +0000)]
Add URL for:

* Consider compressing indexes by storing key values duplicated in
  several rows as a single index entry

>   http://archives.postgresql.org/pgsql-patches/2007-03/msg00163.php

16 years agoAdd URL for:
Bruce Momjian [Thu, 6 Mar 2008 22:15:27 +0000 (22:15 +0000)]
Add URL for:

* Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT

>   http://archives.postgresql.org/pgsql-patches/2007-03/msg00139.php

16 years agoAdd URLs for:
Bruce Momjian [Thu, 6 Mar 2008 22:09:43 +0000 (22:09 +0000)]
Add URLs for:

* Consider compressing indexes by storing key values duplicated in
  several rows as a single index entry
>
>   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00341.php
>   http://archives.postgresql.org/pgsql-hackers/2007-02/msg01264.php
>   http://archives.postgresql.org/pgsql-hackers/2007-03/msg00465.php
>

16 years agoAdd URL for:
Bruce Momjian [Thu, 6 Mar 2008 22:04:57 +0000 (22:04 +0000)]
Add URL for:

* Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT

>   http://archives.postgresql.org/pgsql-hackers/2007-01/msg01375.php

16 years agoDocument that enabling asserts can _significantly_ slow down the server.
Bruce Momjian [Thu, 6 Mar 2008 21:37:33 +0000 (21:37 +0000)]
Document that enabling asserts can _significantly_ slow down the server.
Back patch to 8.3.X.

16 years agoAdd:
Bruce Momjian [Thu, 6 Mar 2008 21:25:50 +0000 (21:25 +0000)]
Add:

>
> * Allow client certificate names to be checked against the client
>   hostname
>
>   This is already implemented in
>   libpq/fe-secure.c::verify_peer_name_matches_certificate() but the code
>   is commented out.

16 years agoDocument use of pg_locks.objid for advisory locks, suggestion from Marc Mamin
Bruce Momjian [Thu, 6 Mar 2008 18:49:32 +0000 (18:49 +0000)]
Document use of pg_locks.objid for advisory locks, suggestion from Marc Mamin

16 years agoAdd:
Bruce Momjian [Thu, 6 Mar 2008 18:00:59 +0000 (18:00 +0000)]
Add:

>
> * Reduce memory usage of aggregates in set returning functions
>
>   http://archives.postgresql.org/pgsql-performance/2008-01/msg00031.php
>

16 years agoAdd:
Bruce Momjian [Thu, 6 Mar 2008 17:28:22 +0000 (17:28 +0000)]
Add:

>
>  o Prevent escape string warnings when object names have
>    backslashes
>
>    http://archives.postgresql.org/pgsql-hackers/2008-01/msg00227.php
>

16 years agoAdd:
Bruce Momjian [Thu, 6 Mar 2008 17:19:38 +0000 (17:19 +0000)]
Add:

> * Prevent malicious functions from being executed with the permissions
>   of unsuspecting users
>
>   Index functions are safe, so VACUUM and ANALYZE are safe too.
>   Triggers, CHECK and DEFAULT expressions, and rules are still vulnerable.
>   http://archives.postgresql.org/pgsql-hackers/2008-01/msg00268.php

16 years agoImprove "bgwriter_lru_multiplier" GUC description.
Bruce Momjian [Thu, 6 Mar 2008 16:31:42 +0000 (16:31 +0000)]
Improve "bgwriter_lru_multiplier" GUC description.

16 years agoMove client encoding libpq function docs into libpq doc section, and
Bruce Momjian [Thu, 6 Mar 2008 15:37:56 +0000 (15:37 +0000)]
Move client encoding libpq function docs into libpq doc section, and
just reference them from the localization doc section.

Backpatch to 8.3.X.

16 years agoWording fix:
Bruce Momjian [Thu, 6 Mar 2008 03:22:32 +0000 (03:22 +0000)]
Wording fix:

<  o Have CONSTRAINT cname NOT NULL preserve the contraint name
>  o Have CONSTRAINT cname NOT NULL record the contraint name

16 years agoAdd:
Bruce Momjian [Thu, 6 Mar 2008 03:18:19 +0000 (03:18 +0000)]
Add:

>
>  o Have CONSTRAINT cname NOT NULL preserve the contraint name
>
>    Right now pg_attribute.attnotnull records the NOT NULL status
>    of the column, but does not record the contraint name
>

16 years agoBreak out referential integrity and server-side languages into separate
Bruce Momjian [Thu, 6 Mar 2008 03:15:52 +0000 (03:15 +0000)]
Break out referential integrity and server-side languages into separate
TODO categories.

16 years agoClean up double negative, per Tom Lane.
Alvaro Herrera [Wed, 5 Mar 2008 21:14:10 +0000 (21:14 +0000)]
Clean up double negative, per Tom Lane.

16 years agoAdd support for dlopen on recent NetBSD/MIPS, per Rémi Zara.
Alvaro Herrera [Wed, 5 Mar 2008 19:42:11 +0000 (19:42 +0000)]
Add support for dlopen on recent NetBSD/MIPS, per Rémi Zara.

16 years agoUpdate libpqxx URL in top-level README, per Gurjeet Singh.
Bruce Momjian [Wed, 5 Mar 2008 17:04:24 +0000 (17:04 +0000)]
Update libpqxx URL in top-level README, per Gurjeet Singh.

16 years agoIn PrepareToInvalidateCacheTuple, don't force initialization of catalog
Tom Lane [Wed, 5 Mar 2008 17:01:26 +0000 (17:01 +0000)]
In PrepareToInvalidateCacheTuple, don't force initialization of catalog
caches that we don't actually need to touch.  This saves some trivial
number of cycles and avoids certain cases of deadlock when doing concurrent
VACUUM FULL on system catalogs.  Per report from Gavin Roy.

Backpatch to 8.2.  In earlier versions, CatalogCacheInitializeCache didn't
lock the relation so there's no deadlock risk (though that certainly had
plenty of risks of its own).

16 years agoDocument that increasing the number of checkpoints segments or
Bruce Momjian [Wed, 5 Mar 2008 16:59:10 +0000 (16:59 +0000)]
Document that increasing the number of checkpoints segments or
checkpoint timeout can incrase the time needed for crash recovery, per
suggestion from Simon.

16 years agoAdd URL for:
Bruce Momjian [Wed, 5 Mar 2008 16:07:21 +0000 (16:07 +0000)]
Add URL for:

* Add support for SQL-standard GENERATED/IDENTITY columns

>   http://archives.postgresql.org/pgsql-hackers/2008-02/msg00604.php

16 years agoAdd URL for:
Bruce Momjian [Wed, 5 Mar 2008 16:02:31 +0000 (16:02 +0000)]
Add URL for:

* Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT

>   http://archives.postgresql.org/pgsql-hackers/2008-02/msg00642.php
>

16 years agoAdd:
Bruce Momjian [Wed, 5 Mar 2008 15:56:11 +0000 (15:56 +0000)]
Add:

>
>  o Allow COPY FROM to create index entries in bulk
>
>    http://archives.postgresql.org/pgsql-hackers/2008-02/msg00811.php
>

16 years agoWhen text search string is too long, in error message report actual and
Bruce Momjian [Wed, 5 Mar 2008 15:50:37 +0000 (15:50 +0000)]
When text search string is too long, in error message report actual and
maximum number of bytes allowed.

16 years agoInclude -lgss in libpq link, if available. Bjorn Munch
Tom Lane [Wed, 5 Mar 2008 05:39:11 +0000 (05:39 +0000)]
Include -lgss in libpq link, if available.  Bjorn Munch

16 years agoFix PREPARE TRANSACTION to reject the case where the transaction has dropped a
Tom Lane [Tue, 4 Mar 2008 19:54:06 +0000 (19:54 +0000)]
Fix PREPARE TRANSACTION to reject the case where the transaction has dropped a
temporary table; we can't support that because there's no way to clean up the
source backend's internal state if the eventual COMMIT PREPARED is done by
another backend.  This was checked correctly in 8.1 but I broke it in 8.2 :-(.
Patch by Heikki Linnakangas, original trouble report by John Smith.

16 years agoUse windows DACL fix for pg_regress as well.
Magnus Hagander [Tue, 4 Mar 2008 15:38:31 +0000 (15:38 +0000)]
Use windows DACL fix for pg_regress as well.

Dave Page

16 years agoUpdate pg_dump item:
Bruce Momjian [Tue, 4 Mar 2008 14:38:38 +0000 (14:38 +0000)]
Update pg_dump item:

<    produce a single dump output file.
>    produce a single dump output file.  It also would require
>    several sessions to share the same snapshot.

16 years agoShow example of ts_headline() using a configuration name.
Bruce Momjian [Tue, 4 Mar 2008 03:17:18 +0000 (03:17 +0000)]
Show example of ts_headline() using a configuration name.

16 years agoRemove:
Bruce Momjian [Tue, 4 Mar 2008 02:48:22 +0000 (02:48 +0000)]
Remove:

<
<  o To better utilize resources, restore data, primary keys, and
<     indexes for a single table before restoring the next table
<
<    Hopefully this will allow the CPU-I/O load to be more uniform
<    for simultaneous restores.  The idea is to start data restores
<    for several objects, and once the first object is done, to move
<    on to its primary keys and indexes.  Over time, simultaneous
<    data loads and index builds will be running.

16 years agoAdd URL for:
Bruce Momjian [Tue, 4 Mar 2008 01:38:37 +0000 (01:38 +0000)]
Add URL for:

        o Allow pg_restore to utilize multiple CPUs and I/O channels by
          restoring multiple objects simultaneously

>    http://archives.postgresql.org/pgsql-hackers/2008-02/msg00963.php

16 years agoAdd ideas for concurrent pg_dump and pg_restore:
Bruce Momjian [Tue, 4 Mar 2008 01:33:32 +0000 (01:33 +0000)]
Add ideas for concurrent pg_dump and pg_restore:

< * pg_dump
> * pg_dump / pg_restore
>  o Allow pg_dump to utilize multiple CPUs and I/O channels by dumping
>    multiple objects simultaneously
>
>    The difficulty with this is getting multiple dump processes to
>    produce a single dump output file.
>    http://archives.postgresql.org/pgsql-hackers/2008-02/msg00205.php
>
>  o Allow pg_restore to utilize multiple CPUs and I/O channels by
>           restoring multiple objects simultaneously
>
>    This might require a pg_restore flag to indicate how many
>    simultaneous operations should be performed.  Only pg_dump's
>    -Fc format has the necessary dependency information.
>
>  o To better utilize resources, restore data, primary keys, and
>     indexes for a single table before restoring the next table
>
>    Hopefully this will allow the CPU-I/O load to be more uniform
>    for simultaneous restores.  The idea is to start data restores
>    for several objects, and once the first object is done, to move
>    on to its primary keys and indexes.  Over time, simultaneous
>    data loads and index builds will be running.
>
>  o To better utilize resources, allow pg_restore to check foreign
>    keys simultaneously, where possible
>  o Allow pg_restore to create all indexes of a table
>    concurrently, via a single heap scan
>
>    This requires a pg_dump -Fc file because that format contains
>           the required dependency information.
>    http://archives.postgresql.org/pgsql-general/2007-05/msg01274.php
>
>  o Allow pg_restore to load different parts of the COPY data
>    simultaneously
<   single heap scan, and have a restore of a pg_dump somehow use it
>   single heap scan, and have pg_restore use it
<   http://archives.postgresql.org/pgsql-general/2007-05/msg01274.php

16 years agoUpdate Japanese FAQ.
Bruce Momjian [Mon, 3 Mar 2008 22:10:51 +0000 (22:10 +0000)]
Update Japanese FAQ.

Jun Kuwamura

16 years agoAdd:
Bruce Momjian [Mon, 3 Mar 2008 21:26:09 +0000 (21:26 +0000)]
Add:

> * Allow INSERT ... DELETE ... RETURNING, namely allow the DELETE ...
>   RETURNING to supply values to the INSERT
>   http://archives.postgresql.org/pgsql-hackers/2008-02/thrd2.php#00979

16 years agoAdd another URL for:
Bruce Momjian [Mon, 3 Mar 2008 21:00:35 +0000 (21:00 +0000)]
Add another URL for:

        o Consider using a ring buffer for COPY FROM
<
< http://archives.postgresql.org/pgsql-hackers/2008-02/msg01080.php
>    http://archives.postgresql.org/pgsql-hackers/2008-02/msg01080.php

16 years agoDocument that REVOKE doesn't remove all permissions if PUBLIC has permissions.
Bruce Momjian [Mon, 3 Mar 2008 19:17:27 +0000 (19:17 +0000)]
Document that REVOKE doesn't remove all permissions if PUBLIC has permissions.

16 years agoAdd:
Bruce Momjian [Mon, 3 Mar 2008 19:03:44 +0000 (19:03 +0000)]
Add:

>
> * Allow the UUID type to accept non-standard formats
>
>   http://archives.postgresql.org/pgsql-hackers/2008-02/msg01214.php

16 years agoAdd:
Bruce Momjian [Mon, 3 Mar 2008 18:45:24 +0000 (18:45 +0000)]
Add:

> * Speed WAL recovery by allowing more than one page to be prefetched
>
>   This involves having a separate process that can be told which pages
>   the recovery process will need in the near future.
>   http://archives.postgresql.org/pgsql-hackers/2008-02/msg01279.php
>

16 years agoRemove "reliably" from chr(0) doc mention.
Bruce Momjian [Mon, 3 Mar 2008 18:09:02 +0000 (18:09 +0000)]
Remove "reliably" from chr(0) doc mention.

16 years agoDocument that chr(0) is not supported, and why.
Bruce Momjian [Mon, 3 Mar 2008 17:11:13 +0000 (17:11 +0000)]
Document that chr(0) is not supported, and why.

16 years agoFix markup.
Bruce Momjian [Mon, 3 Mar 2008 16:22:55 +0000 (16:22 +0000)]
Fix markup.

16 years agoAdd new FAQ item:
Bruce Momjian [Mon, 3 Mar 2008 15:55:26 +0000 (15:55 +0000)]
Add new FAQ item:

    <H3 id="item1.15">1.15) How do I unsubscribe from the
    PostgreSQL email lists?  How do I avoid receiving duplicate
    emails?</H3>

16 years agoAdd URL's for sequence discussions:
Bruce Momjian [Mon, 3 Mar 2008 15:06:55 +0000 (15:06 +0000)]
Add URL's for sequence discussions:

>
>   http://archives.postgresql.org/pgsql-hackers/2008-03/msg00008.php
>
<  o %Have ALTER TABLE RENAME rename SERIAL sequence names
>  o Have ALTER TABLE RENAME rename SERIAL sequence names
>
>    http://archives.postgresql.org/pgsql-hackers/2008-03/msg00008.php
>
>    http://archives.postgresql.org/pgsql-hackers/2008-03/msg00008.php

16 years agoFixed bug that caused arrays of varchar to be output with incomplete name.
Michael Meskes [Sun, 2 Mar 2008 10:54:11 +0000 (10:54 +0000)]
Fixed bug that caused arrays of varchar to be output with incomplete name.
In the process expanded one test case,

16 years agoVenezuela Time now means UTC-4:30, not UTC-4:00. Adjust our treatment
Tom Lane [Sun, 2 Mar 2008 00:10:22 +0000 (00:10 +0000)]
Venezuela Time now means UTC-4:30, not UTC-4:00.  Adjust our treatment
of "VET" accordingly.  Per bug #3997 from Aaron Mizrachi.

16 years agoFix another place that was assuming that a local variable declared as
Tom Lane [Sat, 1 Mar 2008 19:26:22 +0000 (19:26 +0000)]
Fix another place that was assuming that a local variable declared as
"struct varlena" would be at least word-aligned.  Per buildfarm results
from gypsy_moth.  I did a little bit of trawling for other instances of
this coding pattern, and didn't find any; but if we turn up any more
of them I think we'd better revert the "char [4]" patch and find another
way of making tuptoaster.c alignment-safe.

16 years agoFix unportable usages of tolower(). On signed-char machines, it is necessary
Tom Lane [Sat, 1 Mar 2008 03:26:35 +0000 (03:26 +0000)]
Fix unportable usages of tolower().  On signed-char machines, it is necessary
to explicitly cast the output back to char before comparing it to a char
value, else we get the wrong result for high-bit-set characters.  Found by
Rolf Jentsch.  Also, fix several places where <ctype.h> functions were being
called without casting the argument to unsigned char; this is likewise
unportable, but we keep making that mistake :-(.  These found by buildfarm
member salamander, which I will desperately miss if it ever goes belly-up.

16 years agoDisable the undocumented xmlvalidate() function, which was unintentionally
Tom Lane [Sat, 1 Mar 2008 02:46:49 +0000 (02:46 +0000)]
Disable the undocumented xmlvalidate() function, which was unintentionally
left in the code though it was not meant to be provided.  It represents a
security hole because unprivileged users could use it to look at (at least the
first line of) any file readable by the backend.  Fortunately, this is only
possible if the backend was built with XML support, so the damage is at least
mitigated; and 8.3 probably hasn't propagated into any security-critical uses
yet anyway.  Per report from Sergey Burladyan.

16 years agoDon't call AddUserToDacl on Cygwin
Andrew Dunstan [Fri, 29 Feb 2008 23:31:20 +0000 (23:31 +0000)]
Don't call AddUserToDacl on Cygwin

16 years agoRemove long-unused and broken TCL_ARRAYS.
Alvaro Herrera [Fri, 29 Feb 2008 20:58:33 +0000 (20:58 +0000)]
Remove long-unused and broken TCL_ARRAYS.

16 years agoReducing the assumed alignment of struct varlena means that the compiler
Tom Lane [Fri, 29 Feb 2008 17:47:41 +0000 (17:47 +0000)]
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unaligned
address.  Which will not work if the variable is then manipulated with
SET_VARSIZE or other macros that assume alignment.  So the previous patch
is not an unalloyed good, but on balance I think it's still a win, since
we have very few places that do that sort of thing.  Fix the one place in
tuptoaster.c that does it.  Per buildfarm results from gypsy_moth
(I'm a bit surprised that only one machine showed a failure).

16 years agoFix handling of restricted processes for Windows Vista (mainly),
Magnus Hagander [Fri, 29 Feb 2008 15:31:33 +0000 (15:31 +0000)]
Fix handling of restricted processes for Windows Vista (mainly),
by explicitly adding back the user to the DACL of the new process.
This fixes the failure case when executing as the Administrator
user, which had no permissions left at all after we dropped the
Administrators group.

Dave Page with some modifications from me

16 years agoUpdate wording:
Bruce Momjian [Fri, 29 Feb 2008 14:56:50 +0000 (14:56 +0000)]
Update wording:

< * Add Oracle-style packages  (Pavel)
> * Add features of Oracle-style packages  (Pavel)

16 years agoWrite the objfiles.txt rules in a way that is compatible with GNU make 3.78,
Peter Eisentraut [Fri, 29 Feb 2008 10:34:51 +0000 (10:34 +0000)]
Write the objfiles.txt rules in a way that is compatible with GNU make 3.78,
and simpler, too.

16 years agoFix several memory leaks when rescanning SRFs. Arrange for an SRF's
Neil Conway [Fri, 29 Feb 2008 02:49:39 +0000 (02:49 +0000)]
Fix several memory leaks when rescanning SRFs. Arrange for an SRF's
"multi_call_ctx" to be a distinct sub-context of the EState's per-query
context, and delete the multi_call_ctx as soon as the SRF finishes
execution. This avoids leaking SRF memory until the end of the current
query, which is particularly egregious when the SRF is scanned
multiple times. This change also fixes a leak of the fields of the
AttInMetadata struct in shutdown_MultiFuncCall().

Also fix a leak of the SRF result TupleDesc when rescanning a
FunctionScan node. The TupleDesc is allocated in the per-query context
for every call to ExecMakeTableFunctionResult(), so we should free it
after calling that function. Since the SRF might choose to return
a non-expendable TupleDesc, we only free the TupleDesc if it is
not being reference-counted.

Backpatch to 8.3 and 8.2 stable branches.

16 years agoSupport for building contrib/uuid-ossp with MSVC.
Magnus Hagander [Thu, 28 Feb 2008 12:17:59 +0000 (12:17 +0000)]
Support for building contrib/uuid-ossp with MSVC.

Original patch from Hiroshi Saito, modified by me.

16 years agoChange expand_subsys function so that it preserves the relative order of
Peter Eisentraut [Wed, 27 Feb 2008 20:31:01 +0000 (20:31 +0000)]
Change expand_subsys function so that it preserves the relative order of
the files passed as argument.  This is desirable so that the dtrace rule
in src/backend/Makefile works.

16 years agoIf RelationBuildDesc() fails to open a critical system index, PANIC with
Tom Lane [Wed, 27 Feb 2008 17:44:19 +0000 (17:44 +0000)]
If RelationBuildDesc() fails to open a critical system index, PANIC with
a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.

16 years agoAdd more clarification about SSH tunnels from Faheem Mitha.
Peter Eisentraut [Tue, 26 Feb 2008 18:01:26 +0000 (18:01 +0000)]
Add more clarification about SSH tunnels from Faheem Mitha.

16 years agoIn the SSH setup instructions, change
Peter Eisentraut [Tue, 26 Feb 2008 16:07:16 +0000 (16:07 +0000)]
In the SSH setup instructions, change

ssh -L 3333:foo.com:5432 joe@foo.com

I think this should be changed to

ssh -L 3333:localhost:5432 joe@foo.com

The reason is that this assumes the postgres server on foo.com allows
connections from foo.com, which is not allowed by the default
listen_addresses setting.  Add more detail explaining this.

pointed out by Faheem Mitha

Also change the example port number 3333 to 63333 so no one can complain
that we are stealing a reserved port number.

16 years agoAdd information about format modifiers that apply to numeric formats.
Peter Eisentraut [Tue, 26 Feb 2008 15:32:30 +0000 (15:32 +0000)]
Add information about format modifiers that apply to numeric formats.
These were previously only documented in the context of date/time formats.

16 years agoFixed dtrace build
Peter Eisentraut [Tue, 26 Feb 2008 14:42:27 +0000 (14:42 +0000)]
Fixed dtrace build

found by Magne Mæhre

16 years agoDon't build the win32 support files in the all target, only in distprep and
Peter Eisentraut [Tue, 26 Feb 2008 14:26:16 +0000 (14:26 +0000)]
Don't build the win32 support files in the all target, only in distprep and
when they are actually needed as prerequisites.

16 years agoFix uninstall target.
Peter Eisentraut [Tue, 26 Feb 2008 13:48:57 +0000 (13:48 +0000)]
Fix uninstall target.

16 years agoCreate two separate libpq.rc's: One that is built at build time, and one
Peter Eisentraut [Tue, 26 Feb 2008 13:31:40 +0000 (13:31 +0000)]
Create two separate libpq.rc's: One that is built at build time, and one
that is shipped in the distribution, named libpq-dist.rc.  This way the
build system doesn't get upset when a distributed file is forcibly
overwritten by during a normal build.

16 years agoReorganize some of the exports list generation code. It seems that this
Peter Eisentraut [Tue, 26 Feb 2008 10:45:24 +0000 (10:45 +0000)]
Reorganize some of the exports list generation code.  It seems that this
has been reinvented about four different times throughout history (aix,
cygwin, win32, darwin/linux) and a lot of the concepts are actually shared,
which the code now shows better.

16 years agoEscape # character in variable assignment
Peter Eisentraut [Tue, 26 Feb 2008 10:30:06 +0000 (10:30 +0000)]
Escape # character in variable assignment

16 years agoNeed more dependencies to get the build order right when objfiles.txt
Peter Eisentraut [Tue, 26 Feb 2008 08:23:31 +0000 (08:23 +0000)]
Need more dependencies to get the build order right when objfiles.txt
doesn't exist yet.

16 years agoWe don't need to rebuild objfiles.txt every time an object file changes.
Peter Eisentraut [Tue, 26 Feb 2008 07:20:38 +0000 (07:20 +0000)]
We don't need to rebuild objfiles.txt every time an object file changes.
So only rebuild when a makefile changes (which presumably defines the
file list somewhere), and only touch the file if an object changed. The
touch is necessary so the parent make knows something changed and
ultimately rebuilds postgres.

16 years agoRefactor the code that creates the shared library export files to appear
Peter Eisentraut [Tue, 26 Feb 2008 06:41:24 +0000 (06:41 +0000)]
Refactor the code that creates the shared library export files to appear
only once in Makefile.shlib and not in four copies.

16 years agoFix encode(...bytea..., 'escape') so that it converts all high-bit-set byte
Tom Lane [Tue, 26 Feb 2008 02:54:08 +0000 (02:54 +0000)]
Fix encode(...bytea..., 'escape') so that it converts all high-bit-set byte
values into \nnn octal escape sequences.  When the database encoding is
multibyte this is *necessary* to avoid generating invalidly encoded text.
Even in a single-byte encoding, the old behavior seems very hazardous ---
consider for example what happens if the text is transferred to another
database with a different encoding.  Decoding would then yield some other
bytea value than what was encoded, which is surely undesirable.  Per gripe
from Hernan Gonzalez.

Backpatch to 8.3, but not further.  This is a bit of a judgment call, but I
make it on these grounds: pre-8.3 we don't really have much encoding safety
anyway because of the convert() function family, and we would also have much
higher risk of breaking existing apps that may not be expecting this behavior.
8.3 is still new enough that we can probably get away with making this change
in the function's behavior.

16 years agoReject year zero during datetime input, except when it's a 2-digit year
Tom Lane [Mon, 25 Feb 2008 23:36:28 +0000 (23:36 +0000)]
Reject year zero during datetime input, except when it's a 2-digit year
(then it means 2000 AD).  Formerly we silently interpreted this as 1 BC,
which at best is unwarranted familiarity with the implementation.
It's barely possible that some app somewhere expects the old behavior,
though, so we won't back-patch this into existing release branches.

16 years agoFix datetime input to behave correctly for Feb 29 in years BC.
Tom Lane [Mon, 25 Feb 2008 23:21:01 +0000 (23:21 +0000)]
Fix datetime input to behave correctly for Feb 29 in years BC.

Formerly, DecodeDate attempted to verify the day-of-the-month exactly, but
it was under the misapprehension that it would know whether we were looking
at a BC year or not.  In reality this check can't be made until the calling
function (eg DecodeDateTime) has processed all the fields.  So, split the
BC adjustment and validity checks out into a new function ValidateDate that
is called only after processing all the fields.  In passing, this patch
makes DecodeTimeOnly work for BC inputs, which it never did before.

(The historical veracity of all this is nonexistent, of course, but if
we're going to say we support proleptic Gregorian calendar then we should
do it correctly.  In any case the unpatched code is broken because it could
emit dates that it would then reject on re-inputting.)

Per report from Bernd Helmle.  Back-patch as far as 8.0; in 7.x we were
not using our own calendar support and so this seems a bit too risky
to put into 7.4.

16 years agoLink postgres from all object files at once, to avoid the error-prone
Peter Eisentraut [Mon, 25 Feb 2008 17:55:42 +0000 (17:55 +0000)]
Link postgres from all object files at once, to avoid the error-prone
SUBSYS.o step and allow for better optimization by the linker.

Instead of partial linking into SUBSYS.o, the list of object files is
assembled in objfiles.txt files that are expanded when the final
linking is done.

Because we are not yet sure how long command lines different platforms
can handle, the old way of linking is still available, by defining the
make variable PARTIAL_LINKING (e.g., make all PARTIAL_LINKING=1).  If
we determine that this is necessary for some platforms, then we will
document this in a more prominent place.

16 years agoUse our own getopt() and getopt_long() on Solaris, because that platform's
Tom Lane [Sun, 24 Feb 2008 05:21:54 +0000 (05:21 +0000)]
Use our own getopt() and getopt_long() on Solaris, because that platform's
versions don't handle long options the way we want.  Per Zdenek Kotala.

16 years agoAvoid trying to print a NULL char pointer in --describe-config. On some
Tom Lane [Sat, 23 Feb 2008 19:23:33 +0000 (19:23 +0000)]
Avoid trying to print a NULL char pointer in --describe-config.  On some
platforms this works, but on some it crashes.  Zdenek Kotala

16 years agoChange the declaration of struct varlena so that the length word is
Tom Lane [Sat, 23 Feb 2008 19:11:45 +0000 (19:11 +0000)]
Change the declaration of struct varlena so that the length word is
represented as "char ...[4]" not "int32".  Since the length word is never
supposed to be accessed via this struct member anyway, this won't break
any existing code that is following the rules.  The advantage is that C
compilers will no longer assume that a pointer to struct varlena is
word-aligned, which prevents incorrect optimizations in TOAST-pointer
access and perhaps other places.  gcc doesn't seem to do this (at least
not at -O2), but the problem is demonstrable on some other compilers.

I changed struct inet as well, but didn't bother to touch a lot of other
struct definitions in which it wouldn't make any difference because there
were other fields forcing int alignment anyway.  Hopefully none of those
struct definitions are used for accessing unaligned Datums.

16 years agoRename miscadmin.h's PG_VERSIONSTR macro to PG_BACKEND_VERSIONSTR to
Tom Lane [Wed, 20 Feb 2008 22:46:24 +0000 (22:46 +0000)]
Rename miscadmin.h's PG_VERSIONSTR macro to PG_BACKEND_VERSIONSTR to
make it a bit clearer what it is, and get rid of duplicate definitions
in initdb and pg_ctl.

16 years agoMake pg_regress -V consistent with the corresponding code in other
Tom Lane [Wed, 20 Feb 2008 22:44:16 +0000 (22:44 +0000)]
Make pg_regress -V consistent with the corresponding code in other
programs: use puts with a compile-time-constant string.

16 years agoFix mistakes in pg_ctl's code for "start -w" that tries to cope with
Tom Lane [Wed, 20 Feb 2008 22:18:15 +0000 (22:18 +0000)]
Fix mistakes in pg_ctl's code for "start -w" that tries to cope with
non-default settings for the postmaster's port number.  The code to parse
command line options and postgresql.conf entries wasn't quite right about
whitespace or quotes, and it was coded in a not-very-readable way too.
Per bug #3969 from Itagaki Takahiro, though this is more extensive than his
proposed patch (which fixed only the whitespace problem).
This code has been broken since it was put in in 8.0, so patch all the way
back.

16 years agoPut a CHECK_FOR_INTERRUPTS call into the loops that try to find a unique new
Tom Lane [Wed, 20 Feb 2008 17:44:09 +0000 (17:44 +0000)]
Put a CHECK_FOR_INTERRUPTS call into the loops that try to find a unique new
OID or new relfilenode.  If the existing OIDs are sufficiently densely
populated, this could take a long time (perhaps even be an infinite loop),
so it seems wise to allow the system to respond to a cancel interrupt here.
Per a gripe from Jacky Leng.

Backpatch as far as 8.1.  Older versions just fail on OID collision,
instead of looping.

16 years agoImprove error messages emitted when VACUUM and ANALYZE skip a table.
Alvaro Herrera [Wed, 20 Feb 2008 14:31:35 +0000 (14:31 +0000)]
Improve error messages emitted when VACUUM and ANALYZE skip a table.

Per gripe from Clodoaldo Pinto Neto on
Message-ID: <a595de7a0801060326qbfc790ax2a60573043c2e2be@mail.gmail.com>

16 years agoChange error message to be able to differentiate the two cases. Per suggestion
Alvaro Herrera [Wed, 20 Feb 2008 14:01:45 +0000 (14:01 +0000)]
Change error message to be able to differentiate the two cases.  Per suggestion
from Jaime Casanova.

16 years agoBackport fixed AC_FUNC_FSEEKO
Peter Eisentraut [Tue, 19 Feb 2008 18:02:30 +0000 (18:02 +0000)]
Backport fixed AC_FUNC_FSEEKO

16 years agoUn-break msvc port yet again (it started pulling in the Darwin
Magnus Hagander [Tue, 19 Feb 2008 16:15:14 +0000 (16:15 +0000)]
Un-break msvc port yet again (it started pulling in the Darwin
port files, which obviously didn't compile)

16 years agoMore refactoring, so that the SUBSYS.o rules are now all in one place.
Peter Eisentraut [Tue, 19 Feb 2008 15:29:58 +0000 (15:29 +0000)]
More refactoring, so that the SUBSYS.o rules are now all in one place.

16 years agoThis subdirectory has been unused, dead, and broken for 10 years.
Peter Eisentraut [Tue, 19 Feb 2008 13:08:56 +0000 (13:08 +0000)]
This subdirectory has been unused, dead, and broken for 10 years.

16 years agoFix function prototype to silence compiler warnings.
Magnus Hagander [Tue, 19 Feb 2008 12:06:35 +0000 (12:06 +0000)]
Fix function prototype to silence compiler warnings.

16 years agoUnbreak MSVC build after recent addition of HTMLDIR.
Magnus Hagander [Tue, 19 Feb 2008 12:00:03 +0000 (12:00 +0000)]
Unbreak MSVC build after recent addition of HTMLDIR.