]>
granicus.if.org Git - php/log
George Peter Banyard [Sat, 12 Sep 2020 21:24:30 +0000 (23:24 +0200)]
Promote Warnings to Error in PostgreSQL PDO driver
Closes GH-6119
George Peter Banyard [Sat, 12 Sep 2020 22:43:00 +0000 (00:43 +0200)]
Convert Division by 0 warnings to Error per the Engine Warning RFC
Closes GH-6125
Dmitry Stogov [Mon, 14 Sep 2020 10:31:41 +0000 (13:31 +0300)]
JIT for ASSIGN_OBJ_OP
Nikita Popov [Mon, 14 Sep 2020 10:15:24 +0000 (12:15 +0200)]
Convert E_ERROR to Error exception in mysqli_result iterator
The same condition uses Error exceptions in lots of other classes.
Nikita Popov [Mon, 14 Sep 2020 10:02:56 +0000 (12:02 +0200)]
Drop some dead code
Máté Kocsis [Mon, 14 Sep 2020 09:59:51 +0000 (11:59 +0200)]
Slightly improve error handling in DatePeriod::__construct()
Máté Kocsis [Mon, 14 Sep 2020 09:59:32 +0000 (11:59 +0200)]
Declare array|int and object-of-class|int types in stubs
Closes GH-6081
Co-Authored-By: Nikita Popov <nikic@php.net>
Máté Kocsis [Mon, 14 Sep 2020 09:52:33 +0000 (11:52 +0200)]
Make mb_send_mail() consistent with mail()
The $additional_headers parameter shouldn't accept null.
Máté Kocsis [Mon, 14 Sep 2020 09:46:14 +0000 (11:46 +0200)]
Fix a few stub parameter types in ext/standard
Máté Kocsis [Mon, 14 Sep 2020 09:40:27 +0000 (11:40 +0200)]
Add Z_PARAM_OBJ_OF_CLASS ZPP macro
Christoph M. Becker [Mon, 14 Sep 2020 08:13:07 +0000 (10:13 +0200)]
Unmark tests as XFAIL on Windows
This issue has been resolved[1], so the tests are expected to pass on
Windows again.
[1] <https://github.com/php/php-src/commit/
0a03291b51e7cf199c06ba4ae914277ce0ac4202 >
Dmitry Stogov [Mon, 14 Sep 2020 07:41:22 +0000 (10:41 +0300)]
Allocate Windows 64 shadow stack space
Benjamin Eberlei [Sat, 12 Sep 2020 15:25:16 +0000 (17:25 +0200)]
Remove @jit Docblock support for now due to dev-time constraints
George Peter Banyard [Sat, 12 Sep 2020 21:41:25 +0000 (23:41 +0200)]
Convert warnings to assetions in OCI PDO driver
Closes GH-6118
Christoph M. Becker [Sun, 13 Sep 2020 13:37:46 +0000 (15:37 +0200)]
Mark tests as XFAIL on Windows
These tests segfault with tracing JIT on Windows as of a recent
commit[1]. A link to a backtrace is available in a comment[2]. For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.
[1] <https://github.com/php/php-src/commit/
7b0a05316957982f9e4cc021aec5c20cc80f7542 >
[2] <https://github.com/php/php-src/commit/
7b0a05316957982f9e4cc021aec5c20cc80f7542 #commitcomment-
42267637 >
Christoph M. Becker [Sun, 13 Sep 2020 13:35:22 +0000 (15:35 +0200)]
Mark tests as XFAIL on Windows
These tests segfault with tracing JIT on Windows as of a recent
commit[1]. A link to a backtrace is available in a comment[2]. For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.
[1] <https://github.com/php/php-src/commit/
817ae414962480d133ed76618b88b3e7ba482718 >
[2] <https://github.com/php/php-src/commit/
817ae414962480d133ed76618b88b3e7ba482718 #commitcomment-
42227420 >
Matteo Beccati [Sun, 13 Sep 2020 08:02:13 +0000 (10:02 +0200)]
Fix broken test
Since
e8e4ddce
George Peter Banyard [Fri, 11 Sep 2020 16:10:38 +0000 (18:10 +0200)]
Use Error for uninitialized SQLite object
Closes GH-6113
George Peter Banyard [Fri, 11 Sep 2020 16:12:59 +0000 (18:12 +0200)]
Fix SKIPIF section for SQLite3 test
Test is borked if the posix_geteui() function is unavailable.
Máté Kocsis [Thu, 20 Aug 2020 14:03:34 +0000 (16:03 +0200)]
Improve parameter handling in ext/openssl
Closes GH-6025
Máté Kocsis [Sat, 12 Sep 2020 17:09:02 +0000 (19:09 +0200)]
Fix prototype of get_active_function_or_method_name()
George Peter Banyard [Sat, 12 Sep 2020 16:41:25 +0000 (18:41 +0200)]
Normalize behaviour of DNS function on Windows
This is a follow-up on commit
4a438b44694d4caf86d8e57266ed2fc2f4ae6213
Add some tests to hopefully not forget it next time
Nikita Popov [Fri, 11 Sep 2020 20:36:41 +0000 (22:36 +0200)]
Handle missing result_var in binary_op_result_type
For dim/obj compound ops we don't have a result_var. Not sure why
this never caused issues before, but this can crash with JIT.
Nikita Popov [Fri, 11 Sep 2020 16:34:15 +0000 (18:34 +0200)]
Fix mbstring fuzzer
mb_ereg can throw now, so we need a dummy frame and need to
free the exception afterwards.
George Peter Banyard [Fri, 11 Sep 2020 15:40:06 +0000 (17:40 +0200)]
Promote some warnings in BCMath to Errors
Also do a bit of refactoring at the same time.
Closes GH-6105
Nikita Popov [Fri, 11 Sep 2020 15:28:20 +0000 (17:28 +0200)]
Use string|int union types in pgsql
For "field name or field offset" parameters.
Also make $ctor_params an ?array parameter.
Nikita Popov [Wed, 9 Sep 2020 09:42:32 +0000 (11:42 +0200)]
Make argument type error message consistent for variadics
If an argument error refers to a variadic argument, we normally
do not print the name of the variadic (as it is not referring to
an individual argument, but to the collection of all of them).
However, this was not the case for the userland argument type
error message, which did it's own formatting.
Closes GH-6101.
Nikita Popov [Fri, 11 Sep 2020 13:27:54 +0000 (15:27 +0200)]
Also forbid null bytes in mail()
I've adjusted mb_send_mail() already, but of course the handling
in mail() should be the same.
Christoph M. Becker [Fri, 11 Sep 2020 12:49:07 +0000 (14:49 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
Fix #80067: Omitting the port in bindto setting errors
Christoph M. Becker [Fri, 11 Sep 2020 12:46:28 +0000 (14:46 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #80067: Omitting the port in bindto setting errors
Christoph M. Becker [Wed, 9 Sep 2020 12:28:55 +0000 (14:28 +0200)]
Fix #80067: Omitting the port in bindto setting errors
A recent commit[1] which fixed a memory leak introduced a regression
regarding the formerly liberal handling of IP addresses to bind to. We
fix this by reverting that commit, and fix the memory leak where it
actually occurs. In other words, this fix is less intrusive than the
former fix.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=
0b8c83f5936581942715d14883cdebddc18bad30 >
Closes GH-6104.
Máté Kocsis [Thu, 10 Sep 2020 17:50:41 +0000 (19:50 +0200)]
Clean up ext/session errors
Closes GH-6111
Máté Kocsis [Thu, 10 Sep 2020 22:23:54 +0000 (00:23 +0200)]
Consolidate new union type ZPP macro names
They will now follow the canonical order of types. Older macros are
left intact due to maintaining BC.
Closes GH-6112
Máté Kocsis [Wed, 9 Sep 2020 00:21:51 +0000 (02:21 +0200)]
Refactor ReflectionMethod::__construct()
Closes GH-6098
Nikita Popov [Fri, 11 Sep 2020 08:46:59 +0000 (10:46 +0200)]
Throw ValueError on null bytes in mb_send_mail()
Instead of silently replacing with spaces.
Hailong Zhao [Wed, 9 Sep 2020 22:34:14 +0000 (18:34 -0400)]
Remove the duplicate line in zend_ast.c
Closes GH-6107.
Nikita Popov [Fri, 11 Sep 2020 07:05:37 +0000 (09:05 +0200)]
Add missing condition on azure community job
Dmitry Stogov [Fri, 11 Sep 2020 07:30:43 +0000 (10:30 +0300)]
Eliminate repeatable class guards and unnecessary IS_UNDEF property checks
Nikita Popov [Thu, 10 Sep 2020 21:19:25 +0000 (23:19 +0200)]
Fix leak in snmp
Dmitry Stogov [Thu, 10 Sep 2020 20:41:50 +0000 (23:41 +0300)]
JIT for ASSIGN_OBJ
Dmitry Stogov [Thu, 10 Sep 2020 13:55:08 +0000 (16:55 +0300)]
Fixed 32-bit JIT
Tyson Andre [Sun, 6 Sep 2020 20:47:34 +0000 (16:47 -0400)]
Avoid gap in AST_CLASS child nodes for attributes
See https://github.com/nikic/php-ast/pull/181
> Hm, I'm thinking it would make more sense to change the structure in php-src.
> All the function types have consistent AST structure, but there's no reason at
> all why classes should be consistent with functions.
It's unusual to have an unused child node between other child nodes that are
used (for name, extends, implements, and attributes of AST_CLASS)
> That gap is a leftover from a previous refactoring. An earlier version of
> attributes extended `zend_ast_decl` with a new member called `attributes` and
> therefore did not need to handle functions and classes in different ways.
Closes GH-6088
Remi Collet [Thu, 10 Sep 2020 10:40:47 +0000 (12:40 +0200)]
fix zend_hash_get_current_key_type_ex proto
Remi Collet [Thu, 10 Sep 2020 09:19:09 +0000 (11:19 +0200)]
fix zend_hash_get_current_key_ex proto
twosee [Thu, 10 Sep 2020 09:36:04 +0000 (17:36 +0800)]
Simplify error type filter
Closes GH-6049.
Nikita Popov [Thu, 10 Sep 2020 07:58:04 +0000 (09:58 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix azure i386 build, again
Nikita Popov [Thu, 10 Sep 2020 07:26:51 +0000 (09:26 +0200)]
Fix azure i386 build, again
Christopher Jones [Thu, 10 Sep 2020 07:37:18 +0000 (17:37 +1000)]
Squash compile warnings the easy way
Christopher Jones [Thu, 10 Sep 2020 07:33:30 +0000 (17:33 +1000)]
Make PDO_OCI test more resilient
Christopher Jones [Thu, 10 Sep 2020 07:32:44 +0000 (17:32 +1000)]
Skip PDO test for Oracle
Christopher Jones [Thu, 10 Sep 2020 06:45:28 +0000 (16:45 +1000)]
Fix premature test termination
Dmitry Stogov [Thu, 10 Sep 2020 06:34:32 +0000 (09:34 +0300)]
Attempt to fix bug #80014 (PHP 8.0 beta2 crashes with default JIT flags due to hardware incompatibility)
chopins [Thu, 10 Sep 2020 06:14:45 +0000 (09:14 +0300)]
Added FFI\CType::getName() method
Dmitry Stogov [Wed, 9 Sep 2020 23:20:15 +0000 (02:20 +0300)]
Eliminate unnecessary IS_INDIRECT guards
Dmitry Stogov [Wed, 9 Sep 2020 20:25:54 +0000 (23:25 +0300)]
Avoid more exception checks
Sammy Kaye Powers [Wed, 9 Sep 2020 20:00:25 +0000 (13:00 -0700)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #79825: opcache.file_cache causes SIGSEGV with custom opcode handlers
Nikita Popov [Wed, 9 Sep 2020 19:49:13 +0000 (21:49 +0200)]
More pgsql func info fixes
Máté Kocsis [Wed, 9 Sep 2020 19:43:44 +0000 (21:43 +0200)]
Fix opcache return type info for pgsql functions
Sammy Kaye Powers [Wed, 9 Sep 2020 19:36:51 +0000 (12:36 -0700)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #79825: opcache.file_cache causes SIGSEGV with custom opcode handlers
Sammy Kaye Powers [Fri, 10 Jul 2020 17:20:40 +0000 (10:20 -0700)]
Fix #79825: opcache.file_cache causes SIGSEGV with custom opcode handlers
Modules may have changed after restart which can cause dangling pointers from custom opcode handlers in the second-level cache files. This fix includes the installed module names and versions in the accel_system_id hash as entropy. Closes GH-5836
Dmitry Stogov [Wed, 9 Sep 2020 18:41:48 +0000 (21:41 +0300)]
JIT for ASSIGN_DIM[_OP] with first IS_VAR + IS_INDIRECT operand
Nikita Popov [Wed, 9 Sep 2020 15:18:58 +0000 (17:18 +0200)]
Use proper int type for parameter
Nikita Popov [Wed, 9 Sep 2020 15:14:14 +0000 (17:14 +0200)]
Fix default value
Nikita Popov [Wed, 9 Sep 2020 15:09:40 +0000 (17:09 +0200)]
Use PGSQL_RETURN_OID() in more places
Nikita Popov [Wed, 9 Sep 2020 10:20:10 +0000 (12:20 +0200)]
Add stub for pgsql extension
Nikita Popov [Wed, 9 Sep 2020 13:49:05 +0000 (15:49 +0200)]
Remove deprecated pgsql signatures
As the comment indicates, these are deprecated in PHP 4.2...
Dmitry Stogov [Wed, 9 Sep 2020 13:15:37 +0000 (16:15 +0300)]
Eliminate unnecessary exception checks
George Peter Banyard [Thu, 2 Apr 2020 15:05:43 +0000 (17:05 +0200)]
Promote some warnings in MBString Regexes
Closes GH-5341
Nikita Popov [Wed, 9 Sep 2020 10:44:28 +0000 (12:44 +0200)]
Promote pgsql no link to Error exception
Nikita Popov [Wed, 9 Sep 2020 10:31:00 +0000 (12:31 +0200)]
Remove deprecated multi-parameter form of pg_connect()
Nikita Popov [Wed, 9 Sep 2020 09:36:38 +0000 (11:36 +0200)]
Make array_multisort() signature more variadic
The second and third arguments are not always the sort_order and
sort_flags -- they can also be in reverse order, or be arrays
altogether. Move them into the variadic parameter to avoid awkward
error messages.
Nikita Popov [Wed, 9 Sep 2020 08:04:16 +0000 (10:04 +0200)]
Test snmp on azure
Closes GH-6100.
Nikita Popov [Wed, 9 Sep 2020 09:23:55 +0000 (11:23 +0200)]
Mark snmp tests as conflicting
Nikita Popov [Wed, 9 Sep 2020 08:23:06 +0000 (10:23 +0200)]
Suppress uninitialized variable warning in snmp
These are false positive warnings.
Nikita Popov [Tue, 8 Sep 2020 13:14:48 +0000 (15:14 +0200)]
Allow array_diff() and array_intersect() with single array argument
Both of these functions are well-defined when used with a single
array argument -- rejecting this case was an artificial limitation.
This is not useful when called with explicit arguments, but removes
edge-cases when used with argument unpacking:
// OK even if $excludes is empty.
array_diff($array, ...$excludes);
// OK even if $arrays contains a single array only.
array_intersect(...$arrays);
This matches the behavior of functions like array_merge() and
array_push(), which also allow calls with no array or a single
array respectively.
Closes GH-6097.
Máté Kocsis [Sun, 16 Aug 2020 19:49:20 +0000 (21:49 +0200)]
Improve error messages mentioning parameters instead of arguments
Closes GH-5999
Dmitry Stogov [Wed, 9 Sep 2020 08:09:20 +0000 (11:09 +0300)]
Fixed memory leak
Nikita Popov [Wed, 9 Sep 2020 08:01:32 +0000 (10:01 +0200)]
Wildcard output differences in snmp tests
And point out that snmp-mibs-downloader is needed.
Dmitry Stogov [Wed, 9 Sep 2020 07:35:44 +0000 (10:35 +0300)]
Tracin JIT support for FETCH_DIM_W/RW with IS_VAR + IS_INDIRECT first operand.
Nikita Popov [Tue, 8 Sep 2020 14:55:48 +0000 (16:55 +0200)]
Avoid use of remote_port in snmp
This field is not used (and has not been used for a long time --
I've seen some mailing list thread from 2003 about it!) and throws
a deprecation warning. The port is part of peername instead (for
transports that support a port at all).
Nikita Popov [Wed, 9 Sep 2020 07:29:18 +0000 (09:29 +0200)]
Pass correct op_info to zend_jit_fetch_dim()
twosee [Fri, 4 Sep 2020 14:43:02 +0000 (22:43 +0800)]
Flesh out ZEND_HASH_REVERSE_FOREACH_* macros
Closes GH-6080.
Christopher Jones [Wed, 9 Sep 2020 01:28:00 +0000 (11:28 +1000)]
Fix
3b0fecd and resulting test fail lob_012.phpt
Dmitry Stogov [Tue, 8 Sep 2020 23:41:22 +0000 (02:41 +0300)]
JIT for FETCH_DIM_W/RW insructions
Christoph M. Becker [Tue, 8 Sep 2020 20:51:46 +0000 (22:51 +0200)]
Fix Windows build for shared ext/sockets
We can't use `PHPAPI` for extensions which may be built shared. Thus,
we introduce `PHP_SOCKETS_API`.
Nikita Popov [Tue, 8 Sep 2020 18:42:45 +0000 (20:42 +0200)]
Don't handle missing value in zend_verify_arg_error()
This error condition is handled separately, never reaches this
function.
Alex Dowad [Tue, 8 Sep 2020 18:09:44 +0000 (20:09 +0200)]
mb_str_split is already documented on php.net
So remove TODO comment which implies that it's not.
Dmitry Stogov [Tue, 8 Sep 2020 18:03:51 +0000 (21:03 +0300)]
JIT for IN_ARRAY instruction.
Christoph M. Becker [Tue, 8 Sep 2020 16:11:26 +0000 (18:11 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
Fix #72941: Modifying bucket->data by-ref has no effect any longer
Christoph M. Becker [Tue, 8 Sep 2020 16:07:57 +0000 (18:07 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #72941: Modifying bucket->data by-ref has no effect any longer
Christoph M. Becker [Tue, 8 Sep 2020 13:09:30 +0000 (15:09 +0200)]
Fix #72941: Modifying bucket->data by-ref has no effect any longer
To match the PHP 5 behavior, we have to explicitly cater to `buffer` or
`data` being references.
Closes GH-6096.
Nikita Popov [Tue, 8 Sep 2020 15:37:40 +0000 (17:37 +0200)]
Try to fix 32-bit setcookie tests, again
Remi Collet [Tue, 8 Sep 2020 12:46:23 +0000 (14:46 +0200)]
add socket_ce and socket_import_file_descriptor in public API
Nikita Popov [Tue, 8 Sep 2020 15:01:08 +0000 (17:01 +0200)]
Fix some snmp stubs
As well as some basic mistakes in tests.
Nikita Popov [Tue, 8 Sep 2020 14:50:10 +0000 (16:50 +0200)]
Suppress unused variable in snmp
force_ipv6 may be unused if compiling without ipv6 support.
Nikita Popov [Tue, 8 Sep 2020 14:29:01 +0000 (16:29 +0200)]
Run the opcache-only configuration only for scheduled builds
The opcache-only configuration has very little signal (i.e. it is
very rare that it fails while non-opcache and opcache+jit both
pass). Switch it to run only for nightly builds, so we get faster
results on normal builds.
Nikita Popov [Tue, 8 Sep 2020 14:18:45 +0000 (16:18 +0200)]
Try to fix setcookie() tests on 32-bit
Dmitry Stogov [Tue, 8 Sep 2020 13:47:30 +0000 (16:47 +0300)]
micro-optimization
Dmitry Stogov [Tue, 8 Sep 2020 13:47:15 +0000 (16:47 +0300)]
JIT for FETCH_LIST_R
Máté Kocsis [Mon, 7 Sep 2020 15:38:14 +0000 (17:38 +0200)]
Fix UNKNOWN default values in ext/oci8
Closes GH-6089