]>
granicus.if.org Git - php/log
Christopher Jones [Sat, 22 Aug 2020 01:37:23 +0000 (11:37 +1000)]
Squash a Linux compile warning
David Carlier [Thu, 13 Aug 2020 09:40:24 +0000 (09:40 +0000)]
fileinfo build fix proposal for haiku.
Haiku already defines a unichar type and different than the fileinfo's anyway.
Closed GH-5983
Christoph M. Becker [Fri, 21 Aug 2020 13:46:30 +0000 (15:46 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
sqlite3 linkage issue on some systems/package combination fix.
David Carlier [Sat, 15 Aug 2020 13:11:51 +0000 (14:11 +0100)]
sqlite3 linkage issue on some systems/package combination fix.
Checking the version is not enough, the function might be available
but the symbols are not present still.
Closes GH-5993
Christoph M. Becker [Fri, 21 Aug 2020 13:30:07 +0000 (15:30 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
Fix wrong datatype
Christoph M. Becker [Fri, 21 Aug 2020 13:28:37 +0000 (15:28 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix wrong datatype
Manuel Mausz [Fri, 21 Aug 2020 11:53:40 +0000 (11:53 +0000)]
Fix wrong datatype
ini_entry->modifiable is of type uint8_t and so should be the temp. variable. Especially important after
4b77a158 .
Closes GH-6028
Remi Collet [Fri, 21 Aug 2020 12:41:35 +0000 (14:41 +0200)]
ensure installed ini don't interfere
Christopher Jones [Fri, 21 Aug 2020 07:46:16 +0000 (17:46 +1000)]
OCI8 classes were already renamed in 8; this now follows the new-new standard
Dmitry Stogov [Fri, 21 Aug 2020 06:50:28 +0000 (09:50 +0300)]
Better register usage for ASSIGN_DIM_OP
Dmitry Stogov [Thu, 20 Aug 2020 22:57:03 +0000 (01:57 +0300)]
Better registers usage
Dmitry Stogov [Thu, 20 Aug 2020 17:43:40 +0000 (20:43 +0300)]
cleanup unused parameters
Dmitry Stogov [Thu, 20 Aug 2020 17:39:13 +0000 (20:39 +0300)]
efree() doesn't use line number arguments (pass zeros)
Dmitry Stogov [Thu, 20 Aug 2020 12:02:12 +0000 (15:02 +0300)]
micro-optimization
Máté Kocsis [Wed, 19 Aug 2020 21:27:53 +0000 (23:27 +0200)]
Promote warnings to exceptions in ext/gd
Closes GH-6023
Dmitry Stogov [Wed, 19 Aug 2020 14:51:23 +0000 (17:51 +0300)]
Load zval type into register to eliminate double load
Dmitry Stogov [Wed, 19 Aug 2020 11:53:01 +0000 (14:53 +0300)]
Shrink live intervals of IS_VAR/IS_TMP_VAR
Dmitry Stogov [Wed, 19 Aug 2020 11:51:39 +0000 (14:51 +0300)]
Fixed tracing JIT crash in case SSA for op_array is not provided
Benjamin Eberlei [Wed, 19 Aug 2020 10:20:11 +0000 (12:20 +0200)]
Update NEWS w.r.t to bugfix #79968
Benjamin Eberlei [Sat, 15 Aug 2020 08:52:04 +0000 (10:52 +0200)]
Fix #79968: Manipulation on unattached DOMChildNode should throw DOMException
Dmitry Stogov [Wed, 19 Aug 2020 06:30:08 +0000 (09:30 +0300)]
Fixed memory leak (ext/hash/tests/mhash_001.phpt failure)
Tyson Andre [Tue, 18 Aug 2020 23:17:03 +0000 (19:17 -0400)]
Fix more basic function stubs
User-defined functions can't have multiple parameters with the same name.
Don't do that for var_dump/debug_zval_dump.
Consistently use array $array to match docs
Fix typo in UPGRADING
Fixes GH-6015
Dmitry Stogov [Tue, 18 Aug 2020 18:13:18 +0000 (21:13 +0300)]
Check for exception after $this destruction
Dmitry Stogov [Tue, 18 Aug 2020 18:10:34 +0000 (21:10 +0300)]
Fixed register allocation for CASE instruction. CASE don't destroy first operand and it may be used later in VM or different trace.
Máté Kocsis [Tue, 18 Aug 2020 12:29:30 +0000 (14:29 +0200)]
Promote warnings to exceptions in ext/pspell
Closes GH-6010
Matteo Beccati [Tue, 18 Aug 2020 16:31:11 +0000 (18:31 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #47021: SoapClient stumbles over WSDL delivered with "Transfer-Encoding: chunked"
Matteo Beccati [Tue, 18 Aug 2020 16:27:26 +0000 (18:27 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #47021: SoapClient stumbles over WSDL delivered with "Transfer-Encoding: chunked"
Matteo Beccati [Tue, 18 Aug 2020 16:10:39 +0000 (18:10 +0200)]
Fix #47021: SoapClient stumbles over WSDL delivered with "Transfer-Encoding: chunked"
Sara Golemon [Tue, 18 Aug 2020 14:03:56 +0000 (14:03 +0000)]
Update NEWS for 8.0.0beta3
Sara Golemon [Tue, 18 Aug 2020 13:44:29 +0000 (13:44 +0000)]
Update NEWS for PHP 8.0.0beta2
Christoph M. Becker [Tue, 18 Aug 2020 10:39:18 +0000 (12:39 +0200)]
Fix #79988: new reserved keyword `match` is a backward incompatible change
Dmitry Stogov [Tue, 18 Aug 2020 10:13:58 +0000 (13:13 +0300)]
Don't add guard for empty()
Dmitry Stogov [Tue, 18 Aug 2020 08:08:04 +0000 (11:08 +0300)]
Fixed bug #79987 (Memory leak in SplFileInfo because of missing zend_restore_error_handling())
Christoph M. Becker [Tue, 18 Aug 2020 08:03:17 +0000 (10:03 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
7.3.23 is next
Christoph M. Becker [Tue, 18 Aug 2020 08:00:46 +0000 (10:00 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
7.3.23 is next
Christoph M. Becker [Tue, 18 Aug 2020 07:55:37 +0000 (09:55 +0200)]
7.3.23 is next
Derick Rethans [Tue, 18 Aug 2020 07:06:35 +0000 (08:06 +0100)]
Merge branch 'PHP-7.4' into master
Derick Rethans [Tue, 18 Aug 2020 07:06:20 +0000 (08:06 +0100)]
Prepare for 7.4.11
Christoph M. Becker [Tue, 18 Aug 2020 06:37:36 +0000 (08:37 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
Fix HTTP response status code
Christoph M. Becker [Tue, 18 Aug 2020 06:35:56 +0000 (08:35 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix HTTP response status code
Christoph M. Becker [Mon, 17 Aug 2020 16:36:02 +0000 (18:36 +0200)]
Fix HTTP response status code
Dmitry Stogov [Tue, 18 Aug 2020 06:28:13 +0000 (09:28 +0300)]
JIT extension may be NULL
Dmitry Stogov [Mon, 17 Aug 2020 21:12:05 +0000 (00:12 +0300)]
Fixed support for named arguments
Dmitry Stogov [Mon, 17 Aug 2020 19:55:25 +0000 (22:55 +0300)]
Fixed trace type inference for FE_FETCH_R/RW
Dmitry Stogov [Mon, 17 Aug 2020 19:31:03 +0000 (22:31 +0300)]
Fixed support for possible indirect variable modification (ext/standard/tests/array/bug77135.phpt failure).
Dmitry Stogov [Mon, 17 Aug 2020 17:48:48 +0000 (20:48 +0300)]
JIT for ZEND_ISSET_ISEMPTY_CV
Dmitry Stogov [Mon, 17 Aug 2020 17:47:06 +0000 (20:47 +0300)]
Fixed JIT for indirectly recursive traces
George Peter Banyard [Wed, 8 Jul 2020 13:51:28 +0000 (15:51 +0200)]
Promote warnings in ext/zip
Dmitry Stogov [Mon, 17 Aug 2020 12:24:33 +0000 (15:24 +0300)]
Removed outdated/duplicated code
Dmitry Stogov [Mon, 17 Aug 2020 10:50:03 +0000 (13:50 +0300)]
Properly patch jmp tables
George Peter Banyard [Sun, 16 Aug 2020 16:59:52 +0000 (18:59 +0200)]
Promote various OpenSSL warnings into Errors
Closes GH-5111
Tyson Andre [Mon, 10 Aug 2020 02:07:33 +0000 (22:07 -0400)]
Add `run-tests.php --context [n]` option.
Mentioned in https://github.com/php/php-src/pull/5965#discussion_r467621123
This PR proposes 3 lines of context so the impact can be seen in tests.
Other `diff` programs show around 3 lines of context.
(This helps indicate exactly which position a test should be updated
to add a new expected line at)
Use the mapping for choosing order to display diffs
Properly include context in cases where the expected output had more lines than
the actual output, e.g.
```
--FILE--
A
A1
A
C
NEARBY
--EXPECTF--
A
B
A1
B
A
B
A
B
NEARBY
```
Closes GH-5968
Máté Kocsis [Sun, 9 Aug 2020 09:05:26 +0000 (11:05 +0200)]
Promote warnings to exceptions in ext/curl
Closes GH-5963
Nikita Popov [Fri, 14 Aug 2020 13:52:31 +0000 (15:52 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Null terminate the sodium_crypto_kx_keypair() result
Nikita Popov [Fri, 14 Aug 2020 13:52:15 +0000 (15:52 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Null terminate the sodium_crypto_kx_keypair() result
Nikita Popov [Fri, 14 Aug 2020 13:51:00 +0000 (15:51 +0200)]
Null terminate the sodium_crypto_kx_keypair() result
Nikita Popov [Fri, 14 Aug 2020 13:37:48 +0000 (15:37 +0200)]
Reduce cost factors in sodium password_hash tests
Drop the 4x factors to make these tests a bit less obscenely
slow.
Christoph M. Becker [Fri, 14 Aug 2020 13:33:02 +0000 (15:33 +0200)]
Improve test portability
We have to ensure that the attempted connection to the MySQL server
fails, and do that by passing an unknown host instead of falling back
to localhost.
Nikita Popov [Fri, 14 Aug 2020 13:17:52 +0000 (15:17 +0200)]
Avoid fatal error in session handler
Nikita Popov [Fri, 14 Aug 2020 13:07:55 +0000 (15:07 +0200)]
Use variadic signature for PDOStatement::fetchAll()
The current signature is incorrect, because the $ctor_args parameter
is not required to be an array (it can at least also be null, and
isn't enforced by an exception anyway).
I'm going for the variadic signature here, because we already use
the same variadic signature in PDO::query() and
PDOStatement::setFetchMode(), all of them accepting essentially the
same arguments.
Nikita Popov [Fri, 14 Aug 2020 12:42:54 +0000 (14:42 +0200)]
Fix types in openssl stub
These two $recipcert parameters don't use proper union types
right now. They are a bit tricky due to the $recipkey -> $recipcert
fallback.
Christoph M. Becker [Fri, 14 Aug 2020 12:34:24 +0000 (14:34 +0200)]
Fix newly introduced test for Windows
The warning message is rather different there, but since that is
irrelevant for this test case, we just suppress the warning.
Máté Kocsis [Fri, 14 Aug 2020 09:59:25 +0000 (11:59 +0200)]
Add a few callable method parameter types to ext/sqlite3
Closes GH-5988
Nikita Popov [Fri, 14 Aug 2020 10:44:13 +0000 (12:44 +0200)]
Don't assert mysql->mysql is non-null
There is an edge case in constructor behavior where we can end up
with mysql->mysql being NULL (rather than mysql itself already being
NULL). I think that ultimately that's a bug in the constructor code,
and we should probably be destroying the outer structure on
construction failure as well. However it's pretty hard to unravel
with when considering all the construction permutations.
Nikita Popov [Fri, 14 Aug 2020 09:32:41 +0000 (11:32 +0200)]
Simplify mysqli_stmt_bind_param() implementation
By using zpp.
Nikita Popov [Fri, 14 Aug 2020 09:15:36 +0000 (11:15 +0200)]
Use normal zpp in mysqli_result::__construct()
This method doesn't need any special handling...
Nikita Popov [Fri, 14 Aug 2020 09:12:41 +0000 (11:12 +0200)]
Remove dummy aliases for mysqli constructors
These are only available as methods. Directly declare them as
such instead of aliasing to functions that don't actually exist.
Nikita Popov [Fri, 14 Aug 2020 08:52:34 +0000 (10:52 +0200)]
Return empty string from SplFileInfo::getPathname()
Instead of false. This is consistent with how other methods like
SplFileInfo::getPath() behave. It's also a requirement before
SplFileInfo::__toString() calls SplFileInfo::getPathname() and
needs to return a string.
Nikita Popov [Fri, 14 Aug 2020 08:42:14 +0000 (10:42 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Add missing initialization check to RegexIterator::getRegex()
Nikita Popov [Fri, 14 Aug 2020 08:27:09 +0000 (10:27 +0200)]
Add missing initialization check to RegexIterator::getRegex()
Nikita Popov [Fri, 14 Aug 2020 08:40:20 +0000 (10:40 +0200)]
Fix test after is_callable change
Nikita Popov [Fri, 14 Aug 2020 08:22:42 +0000 (10:22 +0200)]
Fix bug #78770
Refactor the zend_is_callable implementation to check callability
at a particular frame (this is an implementation detail for now,
but could be exposed in the API if useful). Pick the first parent
user frame as the one to check.
Máté Kocsis [Thu, 13 Aug 2020 21:57:23 +0000 (23:57 +0200)]
Fix ZPP for mhash()
Closes GH-5985
George Peter Banyard [Wed, 8 Jul 2020 16:44:34 +0000 (18:44 +0200)]
Use ZPP callable check for ldap_set_rebind_proc()
George Peter Banyard [Wed, 8 Jul 2020 16:37:01 +0000 (18:37 +0200)]
Use ZPP callable check for Windows specific functions
George Peter Banyard [Wed, 12 Aug 2020 17:26:54 +0000 (19:26 +0200)]
Allow number_format to be only passed 3 arguments
Closes GH-5977
Tyson Andre [Wed, 12 Aug 2020 23:27:00 +0000 (19:27 -0400)]
Colorize --show-diff, only on stdout
Don't add colors to the saved `.diff` file.
Related to
a41cf3e1d2ed3ae38ad6115a8b65e5f14dae0b49
Nikita Popov [Thu, 13 Aug 2020 15:26:20 +0000 (17:26 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79724
Nikita Popov [Thu, 13 Aug 2020 09:45:05 +0000 (11:45 +0200)]
Fixed bug #79724
Nikita Popov [Thu, 13 Aug 2020 15:18:50 +0000 (17:18 +0200)]
Add some missing DatePeriod initialization checks
Nikita Popov [Thu, 13 Aug 2020 14:34:56 +0000 (16:34 +0200)]
Add a missing null check in simplexml
Nikita Popov [Thu, 13 Aug 2020 14:32:43 +0000 (16:32 +0200)]
Fix invalid zpp calls in pcntl_get/setpriority
Nikita Popov [Thu, 13 Aug 2020 14:45:32 +0000 (16:45 +0200)]
Fix test after PDOStatement::fetchObject() change
Nikita Popov [Thu, 13 Aug 2020 14:24:08 +0000 (16:24 +0200)]
Use zpp C in pg_fetch_object
Nikita Popov [Thu, 13 Aug 2020 14:20:29 +0000 (16:20 +0200)]
Use Z_PARAM_CLASS in PDOStatement::fetchObject()
Instead of implementing custom logic.
Nikita Popov [Thu, 13 Aug 2020 14:11:16 +0000 (16:11 +0200)]
Throw Error on uninitialized XMLWriter
Nikita Popov [Thu, 13 Aug 2020 13:52:17 +0000 (15:52 +0200)]
Throw on uninitialized SimpleXMLElement
Elevate this warning into an Error, as usual. Add a few checks
in places that were missing them.
Nikita Popov [Thu, 13 Aug 2020 12:59:39 +0000 (14:59 +0200)]
Avoid fatal error on not found class in mysqli_fetch_object()
Instead use C zpp modifier and throw TypeError.
Máté Kocsis [Thu, 30 Jul 2020 12:31:47 +0000 (14:31 +0200)]
Check missing parameter types in stubs
[skip ci] Closes GH-5627
Máté Kocsis [Thu, 13 Aug 2020 12:54:48 +0000 (14:54 +0200)]
Fix param name in PHPDoc
Máté Kocsis [Fri, 7 Aug 2020 19:50:02 +0000 (21:50 +0200)]
Add all the missing parameter types to stubs
Closes GH-5955
Nikita Popov [Thu, 13 Aug 2020 12:39:38 +0000 (14:39 +0200)]
Use a dedicated method for MultipleIterator::countIterators()
This method has a different signature from
SplObjectStorage::count(), so don't share implementations.
Nikita Popov [Thu, 13 Aug 2020 12:35:11 +0000 (14:35 +0200)]
Replace fatal error in SplFileInfo with exception
Using RuntimeException here, because the same error condition
uses that in many other places in this file.
Nikita Popov [Thu, 13 Aug 2020 11:15:38 +0000 (13:15 +0200)]
Throw Error exception in DOM_GET_OBJ
Per general convention for handling of uninitialized objects.
Nikita Popov [Wed, 24 Jun 2020 15:00:32 +0000 (17:00 +0200)]
Switch to mime-db as source of extension => MIME map
The Apache MIME type map is not actively maintained anymore, so
this switches to jshttp/mime-db, which seems to be the de-facto
standard in this area now. This avoid the need to patch in our
own MIME types over time.
The preference algorithm is based on:
https://github.com/jshttp/mime-types/blob/
47b62ac45e9b176a2af35532d0eea4968bb9eb6d /index.js#L154
Closes GH-5764.
Nikita Popov [Wed, 12 Aug 2020 15:06:02 +0000 (17:06 +0200)]
Make strftime tests musl compatible
* Remove usage of strftime() in favor of date() in cases where
we are not specifically testing strftime(). We implement
date() ourselves, and as such are insulated from implementation-
defined behavior.
* Add skipif for broken strftime() %Z support. We have decided
not to work around the issue for musl using manual expansion,
as people should not be using this function anyway, and it is
slated for future deprecation.
* Don't test strftime() with invalid format specifier. The
behavior is implementation-dependent.
Remi Collet [Thu, 13 Aug 2020 07:36:42 +0000 (09:36 +0200)]
fix test expectation
George Peter Banyard [Thu, 13 Aug 2020 00:37:00 +0000 (02:37 +0200)]
Drop redundant arg count check
Tyson Andre [Sun, 9 Aug 2020 15:26:51 +0000 (11:26 -0400)]
Support NO_COLOR environment variable in run-tests.php
And add a --color option for run-tests.php
See https://no-color.org/
> an informal standard is hereby proposed:
>
> All command-line software which outputs text with ANSI color added should check
> for the presence of a `NO_COLOR` environment variable that, when present
> (regardless of its value), prevents the addition of ANSI color.
Nikita Popov [Fri, 7 Aug 2020 10:15:06 +0000 (12:15 +0200)]
Recognize gnu-libiconv location on alpine