]> granicus.if.org Git - postgresql/log
postgresql
19 years agoComplete the following TODO items:
Neil Conway [Mon, 9 May 2005 11:31:34 +0000 (11:31 +0000)]
Complete the following TODO items:

* Add session start time to pg_stat_activity
* Add the client IP address and port to pg_stat_activity

Original patch from Magnus Hagander, code review by Neil Conway. Catalog
version bumped. This patch sends the client IP address and port number in
every statistics message; that's not ideal, but will be fixed up shortly.

19 years agoUpdate release notes for upcoming re-releases.
Tom Lane [Mon, 9 May 2005 00:09:45 +0000 (00:09 +0000)]
Update release notes for upcoming re-releases.

19 years agoUpdate release checklist to reflect that HISTORY and INSTALL don't
Tom Lane [Sun, 8 May 2005 23:34:15 +0000 (23:34 +0000)]
Update release checklist to reflect that HISTORY and INSTALL don't
need to be created by hand anymore.

19 years agoAdd encryption section to documentation.
Bruce Momjian [Sun, 8 May 2005 03:29:06 +0000 (03:29 +0000)]
Add encryption section to documentation.

Christopher Browne

19 years agoDocumentation adjustments.
Bruce Momjian [Sun, 8 May 2005 03:08:05 +0000 (03:08 +0000)]
Documentation adjustments.

Vladimir Chukharev

19 years agoRepair very-low-probability race condition between relation extension
Tom Lane [Sat, 7 May 2005 21:32:24 +0000 (21:32 +0000)]
Repair very-low-probability race condition between relation extension
and VACUUM: in the interval between adding a new page to the relation
and formatting it, it was possible for VACUUM to come along and decide
it should format the page too.  Though not harmful in itself, this would
cause data loss if a third transaction were able to insert tuples into
the vacuumed page before the original extender got control back.

19 years agoAdjust time qual checking code so that we always check TransactionIdIsInProgress
Tom Lane [Sat, 7 May 2005 21:22:01 +0000 (21:22 +0000)]
Adjust time qual checking code so that we always check TransactionIdIsInProgress
before we check commit/abort status.  Formerly this was done in some paths
but not all, with the result that a transaction might be considered
committed for some purposes before it became committed for others.
Per example found by Jan Wieck.

19 years agoFix case in which a debug printout would print already-pfreed data.
Tom Lane [Sat, 7 May 2005 18:14:25 +0000 (18:14 +0000)]
Fix case in which a debug printout would print already-pfreed data.

19 years agoAdd description:
Bruce Momjian [Sat, 7 May 2005 15:45:23 +0000 (15:45 +0000)]
Add description:

<   Currently locale can only be set during initdb.
>   Currently locale can only be set during initdb.  No global tables have
>   locale-aware columns.  However, the database template used during
>   database creation might have locale-aware indexes.  The indexes would
>   need to be reindexed to match the new locale.

19 years agoAdd comment on C locale test for upper/lower/initcap().
Bruce Momjian [Sat, 7 May 2005 15:18:17 +0000 (15:18 +0000)]
Add comment on C locale test for upper/lower/initcap().

19 years agoRevert the ld --as-needed patch. This breaks Fedora Core 3, due to a strange
Neil Conway [Sat, 7 May 2005 05:48:50 +0000 (05:48 +0000)]
Revert the ld --as-needed patch. This breaks Fedora Core 3, due to a strange
interaction between ld, readline, termcap, and psql. The symptom is psql
failing with this error on startup:

    symbol lookup error: /usr/lib64/libreadline.so.4: undefined symbol: BC

I'm still trying to find the best way to solve this, but in the mean time
I'm reverting the patch in order to unbreak FC3.

19 years agoDone:
Bruce Momjian [Sat, 7 May 2005 04:38:08 +0000 (04:38 +0000)]
Done:
>  o -Allow COPY to optionally include column headings in the first line

19 years agoAdd items:
Bruce Momjian [Sat, 7 May 2005 04:24:34 +0000 (04:24 +0000)]
Add items:

> * Prevent to_char() on interval from returning meaningless values
>
>   For example, to_char('1 month', 'mon') is meaningless.  Basically,
>   most date-related parameters to to_char() are meaningless for
>   intervals because interval is not anchored to a date.
>
> * Allow to_char() on interval values to accumulate the highest unit
>   requested
>
>  o to_char(INTERVAL '1 hour 5 minutes', 'MI') => 65
>  o to_char(INTERVAL '43 hours 20 minutes', 'MI' ) => 2600
>  o to_char(INTERVAL '43 hours 20 minutes', 'WK:DD:HR:MI') => 0:1:19:20
>  o to_char(INTERVAL '3 years 5 months','MM') => 41
>
>   Some special format flag would be required to request such
>   accumulation.  Such functionality could also be added to EXTRACT.
>   Prevent accumulation that crosses the month/day boundary because of
>   the uneven number of days in a month.
>

19 years agoAdd COPY WITH CVS HEADER to allow a heading line as the first line in
Bruce Momjian [Sat, 7 May 2005 02:22:49 +0000 (02:22 +0000)]
Add COPY WITH CVS HEADER to allow a heading line as the first line in
COPY.

Andrew Dunstan

19 years agoUpdate backend flowchart HTML.
Bruce Momjian [Fri, 6 May 2005 19:13:02 +0000 (19:13 +0000)]
Update backend flowchart HTML.

19 years agoUpdate flowchart sections to match current CVS.
Bruce Momjian [Fri, 6 May 2005 19:07:17 +0000 (19:07 +0000)]
Update flowchart sections to match current CVS.

19 years agoMarkup improvements.
Bruce Momjian [Fri, 6 May 2005 18:25:46 +0000 (18:25 +0000)]
Markup improvements.

19 years agoUpdate backend flowchard wording
Bruce Momjian [Fri, 6 May 2005 18:23:13 +0000 (18:23 +0000)]
Update backend flowchard wording

19 years agoAdjust question spacing.
Bruce Momjian [Fri, 6 May 2005 17:48:03 +0000 (17:48 +0000)]
Adjust question spacing.

19 years agoFor some reason access/tupmacs.h has been #including utils/memutils.h,
Tom Lane [Fri, 6 May 2005 17:24:55 +0000 (17:24 +0000)]
For some reason access/tupmacs.h has been #including utils/memutils.h,
which is neither needed by nor related to that header.  Remove the bogus
inclusion and instead include the header in those C files that actually
need it.  Also fix unnecessary inclusions and bad inclusion order in
tsearch2 files.

19 years agoUpdate misleading comment about the use of lanpltrusted ... it is
Tom Lane [Fri, 6 May 2005 14:28:53 +0000 (14:28 +0000)]
Update misleading comment about the use of lanpltrusted ... it is
significant regardless of the value of lanispl.

19 years agoUpdate comment to mention "Name classification hierarchy" as place to
Bruce Momjian [Fri, 6 May 2005 03:42:17 +0000 (03:42 +0000)]
Update comment to mention "Name classification hierarchy" as place to
check for reserved words.

19 years agoRemove documentation that CSV didn't handle carriage returns and line
Bruce Momjian [Fri, 6 May 2005 03:38:05 +0000 (03:38 +0000)]
Remove documentation that CSV didn't handle carriage returns and line
feeds properly.

19 years agoConvert some mulit-line comments in copy.c to single line, as appropriate.
Bruce Momjian [Fri, 6 May 2005 02:56:42 +0000 (02:56 +0000)]
Convert some mulit-line comments in copy.c to single line, as appropriate.

19 years agoMarginal performance improvements in dynahash: make sure that everything
Tom Lane [Fri, 6 May 2005 00:19:14 +0000 (00:19 +0000)]
Marginal performance improvements in dynahash: make sure that everything
associated with a hashtable is allocated in that hashtable's private
context, so that hash_destroy only has to destroy the context and not
do any retail pfree's; and tighten the inner loop of hash_seq_search.

19 years agoFix bogus hashtable setup. (This code has quite a few other problems
Tom Lane [Thu, 5 May 2005 22:18:27 +0000 (22:18 +0000)]
Fix bogus hashtable setup.  (This code has quite a few other problems
too, but that one is in my way at the moment.)

19 years agoMake standalone backends ignore pg_database.datallowconn, so that there
Tom Lane [Thu, 5 May 2005 19:53:26 +0000 (19:53 +0000)]
Make standalone backends ignore pg_database.datallowconn, so that there
is a way to recover from disabling connections to all databases at once.

19 years agoOn Win32, libintl replaces snprintf() with its own version that
Bruce Momjian [Thu, 5 May 2005 19:15:54 +0000 (19:15 +0000)]
On Win32, libintl replaces snprintf() with its own version that
understands arg control, so we don't need our own.  In fact, it
also uses macros that conflict with ours, so we _can't_ use
our own.

19 years agoPer core discussion, we should push out a 7.2.* release too while
Tom Lane [Thu, 5 May 2005 17:59:40 +0000 (17:59 +0000)]
Per core discussion, we should push out a 7.2.* release too while
we are at it.  Add release notes.

19 years agoAdd comments on WSAStartup usage.
Bruce Momjian [Thu, 5 May 2005 16:40:42 +0000 (16:40 +0000)]
Add comments on WSAStartup usage.

19 years agoAdd WSACleanup() for Win32 socket cleanup.
Bruce Momjian [Thu, 5 May 2005 16:36:12 +0000 (16:36 +0000)]
Add WSACleanup() for Win32 socket cleanup.

Jason Erickson

19 years agoThe issue has been raised in the past that our build system links each
Neil Conway [Thu, 5 May 2005 11:50:18 +0000 (11:50 +0000)]
The issue has been raised in the past that our build system links each
executable against the maximal set of libraries it might need. So for
example, if one executable requires `libreadline', all executables are
linked against it.

The easiest fix is to make use of GNU ld's --as-needed flag, which
ignores linker arguments that are not actually needed by the specified
object files. The attached patch modifies configure to check for this
flag (when using GNU ld), and if ld supports it, adds the flag to
LDFLAGS (we need to do the check since only relatively recent versions
of GNU ld support this capability). Currently only GNU ld is supported;
I'm not aware of any other linkers that support this functionality.

19 years agoAdjust nodeBitmapIndexscan to keep the target index opened from plan
Tom Lane [Thu, 5 May 2005 03:37:23 +0000 (03:37 +0000)]
Adjust nodeBitmapIndexscan to keep the target index opened from plan
startup to end, rather than re-opening it in each MultiExecBitmapIndexScan
call.  I had foolishly thought that opening/closing wouldn't be much
more expensive than a rescan call, but that was sheer brain fade.

This seems to fix about half of the performance lossage reported by
Sergey Koposov.  I'm still not sure where the other half went.

19 years agoUpdate "control" item.
Bruce Momjian [Thu, 5 May 2005 01:42:04 +0000 (01:42 +0000)]
Update "control" item.
Rosser Schwarz

19 years agoTypo fix, Dave Held
Bruce Momjian [Thu, 5 May 2005 01:23:51 +0000 (01:23 +0000)]
Typo fix, Dave Held

19 years agoAllow implicit cast from any named composite type to RECORD. At the
Tom Lane [Thu, 5 May 2005 00:19:47 +0000 (00:19 +0000)]
Allow implicit cast from any named composite type to RECORD.  At the
moment this has no particular use except to allow table rows to be
passed to record_out(), but that case seems to be useful in itself
per recent example from Elein.  Further down the road we could look
at letting PL functions be declared to accept RECORD parameters.

19 years agoUse postmaster_is_alive() check in pg_ctl restart as well as pg_ctl status,
Tom Lane [Wed, 4 May 2005 22:35:15 +0000 (22:35 +0000)]
Use postmaster_is_alive() check in pg_ctl restart as well as pg_ctl status,
so that restart doesn't fail when old postmaster died unbetimes.

19 years agoPreliminary release notes for 8.0.3, 7.4.8, 7.3.10.
Tom Lane [Wed, 4 May 2005 21:19:33 +0000 (21:19 +0000)]
Preliminary release notes for 8.0.3, 7.4.8, 7.3.10.

19 years agoSpell DELIMITER correctly, per Seamus Dean.
Tom Lane [Wed, 4 May 2005 14:25:24 +0000 (14:25 +0000)]
Spell DELIMITER correctly, per Seamus Dean.

19 years agoClean up MultiXactIdExpand's API by separating out the case where we
Tom Lane [Tue, 3 May 2005 19:42:41 +0000 (19:42 +0000)]
Clean up MultiXactIdExpand's API by separating out the case where we
are creating a new MultiXactId from two regular XIDs.  The original
coding was unnecessarily complicated and didn't save any code anyway.

19 years agoAlter the signature for encoding conversion functions to declare the
Tom Lane [Tue, 3 May 2005 19:17:59 +0000 (19:17 +0000)]
Alter the signature for encoding conversion functions to declare the
output area as INTERNAL not CSTRING.  This is to prevent people from
calling the functions by hand.  This is a permanent solution for the
back branches but I hope it is just a stopgap for HEAD.

19 years agoChange tsearch2 to not use the unsafe practice of creating functions
Tom Lane [Tue, 3 May 2005 16:51:00 +0000 (16:51 +0000)]
Change tsearch2 to not use the unsafe practice of creating functions
that return INTERNAL without also having INTERNAL arguments.  Since the
functions in question aren't meant to be called by hand anyway, I just
redeclared them to take 'internal' instead of 'text'.  Also add code
to ProcedureCreate() to enforce the restriction, as I should have done
to start with :-(

19 years agoFix typos in documentation.
Neil Conway [Tue, 3 May 2005 03:10:01 +0000 (03:10 +0000)]
Fix typos in documentation.

19 years agoAdd FAQ on who controls the project.
Bruce Momjian [Mon, 2 May 2005 20:11:27 +0000 (20:11 +0000)]
Add FAQ on who controls the project.

19 years agoCompleted:
Bruce Momjian [Mon, 2 May 2005 18:27:12 +0000 (18:27 +0000)]
Completed:

< * Remove unreferenced table files created by transactions that were
> * -Check for unreferenced table files created by transactions that were

19 years agoCheck the file system on postmaster startup and report any unreferenced
Bruce Momjian [Mon, 2 May 2005 18:26:54 +0000 (18:26 +0000)]
Check the file system on postmaster startup and report any unreferenced
files in the server log.

Heikki Linnakangas

19 years agoAdd some missing "See Also" entries to the domain-related SQL reference
Neil Conway [Mon, 2 May 2005 01:52:50 +0000 (01:52 +0000)]
Add some missing "See Also" entries to the domain-related SQL reference
pages. From Robert Treat.

19 years agoChange SPI functions to use a `long' when specifying the number of tuples
Neil Conway [Mon, 2 May 2005 00:37:07 +0000 (00:37 +0000)]
Change SPI functions to use a `long' when specifying the number of tuples
to produce when running the executor. This is consistent with the internal
executor APIs (such as ExecutorRun), which also use a long for this purpose.
It also allows FETCH_ALL to be passed -- since FETCH_ALL is defined as
LONG_MAX, this wouldn't have worked on platforms where int and long are of
different sizes. Per report from Tzahi Fadida.

19 years agoChange CREATE TYPE to require datatype output and send functions to have
Tom Lane [Sun, 1 May 2005 18:56:19 +0000 (18:56 +0000)]
Change CREATE TYPE to require datatype output and send functions to have
only one argument.  (Per recent discussion, the option to accept multiple
arguments is pretty useless for user-defined types, and would be a likely
source of security holes if it was used.)  Simplify call sites of
output/send functions to not bother passing more than one argument.

19 years agoFix incorrect backslashing in regexp example, per Robert Treat.
Tom Lane [Sun, 1 May 2005 15:57:59 +0000 (15:57 +0000)]
Fix incorrect backslashing in regexp example, per Robert Treat.

19 years agoMention the actual stored size of NUMERIC values, per David Fetter.
Tom Lane [Sun, 1 May 2005 15:54:46 +0000 (15:54 +0000)]
Mention the actual stored size of NUMERIC values, per David Fetter.

19 years agoRemove the contents of the src/corba subdirectory: this has been dead code
Neil Conway [Sun, 1 May 2005 06:15:51 +0000 (06:15 +0000)]
Remove the contents of the src/corba subdirectory: this has been dead code
for a long time.

19 years agoChange catalog entries for record_out and record_send to show only one
Tom Lane [Sat, 30 Apr 2005 20:31:39 +0000 (20:31 +0000)]
Change catalog entries for record_out and record_send to show only one
argument, since that's all they are using now.  Adjust type_sanity
regression test so that it will complain if anyone tries to define
multiple-argument output functions in future.

19 years agoMake record_out and record_send extract type information from the passed
Tom Lane [Sat, 30 Apr 2005 20:04:33 +0000 (20:04 +0000)]
Make record_out and record_send extract type information from the passed
record object itself, rather than relying on a second OID argument to be
correct.  This patch just changes the function behavior and not the
catalogs, so it's OK to back-patch to 8.0.  Will remove the now-redundant
second argument in pg_proc in a separate patch in HEAD only.

19 years agoUse the standard lock manager to establish priority order when there
Tom Lane [Sat, 30 Apr 2005 19:03:33 +0000 (19:03 +0000)]
Use the standard lock manager to establish priority order when there
is contention for a tuple-level lock.  This solves the problem of a
would-be exclusive locker being starved out by an indefinite succession
of share-lockers.  Per recent discussion with Alvaro.

19 years agoGCC 4.0 includes a new warning option, -Wformat-literal, that emits
Neil Conway [Sat, 30 Apr 2005 08:08:51 +0000 (08:08 +0000)]
GCC 4.0 includes a new warning option, -Wformat-literal, that emits
a warning when a variable is used as a format string for printf()
and similar functions (if the variable is derived from untrusted
data, it could include unexpected formatting sequences). This
emits too many warnings to be enabled by default, but it does
flag a few dubious constructs in the Postgres tree. This patch
fixes up the obvious variants: functions that are passed a variable
format string but no additional arguments.

Most of these are harmless (e.g. the ruleutils stuff), but there
is at least one actual bug here: if you create a trigger named
"%sfoo", pg_dump will read uninitialized memory and fail to dump
the trigger correctly.

19 years agoFix BCC to not define compiler location.
Bruce Momjian [Sat, 30 Apr 2005 04:00:07 +0000 (04:00 +0000)]
Fix BCC to not define compiler location.

19 years agoUpdate FAQ.
Bruce Momjian [Sat, 30 Apr 2005 03:53:17 +0000 (03:53 +0000)]
Update FAQ.

19 years agoUpdate replication FAQ.
Bruce Momjian [Sat, 30 Apr 2005 03:52:23 +0000 (03:52 +0000)]
Update replication FAQ.

Christopher Browne

19 years agoRestructure LOCKTAG as per discussions of a couple months ago.
Tom Lane [Fri, 29 Apr 2005 22:28:24 +0000 (22:28 +0000)]
Restructure LOCKTAG as per discussions of a couple months ago.
Essentially, we shoehorn in a lockable-object-type field by taking
a byte away from the lockmethodid, which can surely fit in one byte
instead of two.  This allows less artificial definitions of all the
other fields of LOCKTAG; we can get rid of the special pg_xactlock
pseudo-relation, and also support locks on individual tuples and
general database objects (including shared objects).  None of those
possibilities are actually exploited just yet, however.

I removed pg_xactlock from pg_class, but did not force initdb for
that change.  At this point, relkind 's' (SPECIAL) is unused and
could be removed entirely.

19 years agoRemove extern from optreset that was just added.
Bruce Momjian [Fri, 29 Apr 2005 14:30:11 +0000 (14:30 +0000)]
Remove extern from optreset that was just added.

19 years agoImprove cleanup from win32 client-only build.
Bruce Momjian [Fri, 29 Apr 2005 14:07:27 +0000 (14:07 +0000)]
Improve cleanup from win32 client-only build.

19 years agoBackpatch BCC compile changes to 8.0.X for psql.
Bruce Momjian [Fri, 29 Apr 2005 13:42:21 +0000 (13:42 +0000)]
Backpatch BCC compile changes to 8.0.X for psql.

19 years agoThis patch fixes a bug in the error message emitted by pg_restore on an
Neil Conway [Fri, 29 Apr 2005 07:08:06 +0000 (07:08 +0000)]
This patch fixes a bug in the error message emitted by pg_restore on an
incorrect -F argument: write_msg() expects its first parameter to be a
"module name", not the format string.

19 years agoDone:
Bruce Momjian [Fri, 29 Apr 2005 05:03:02 +0000 (05:03 +0000)]
Done:

> * -Implement shared row locks and use them in RI triggers

19 years agoImplement sharable row-level locks, and use them for foreign key references
Tom Lane [Thu, 28 Apr 2005 21:47:18 +0000 (21:47 +0000)]
Implement sharable row-level locks, and use them for foreign key references
to eliminate unnecessary deadlocks.  This commit adds SELECT ... FOR SHARE
paralleling SELECT ... FOR UPDATE.  The implementation uses a new SLRU
data structure (managed much like pg_subtrans) to represent multiple-
transaction-ID sets.  When more than one transaction is holding a shared
lock on a particular row, we create a MultiXactId representing that set
of transactions and store its ID in the row's XMAX.  This scheme allows
an effectively unlimited number of row locks, just as we did before,
while not costing any extra overhead except when a shared lock actually
has to be shared.   Still TODO: use the regular lock manager to control
the grant order when multiple backends are waiting for a row lock.

Alvaro Herrera and Tom Lane.

19 years agoFix a whitespace problem. From Alvaro Herrera.
Dennis Bjorklund [Thu, 28 Apr 2005 15:51:57 +0000 (15:51 +0000)]
Fix a whitespace problem. From Alvaro Herrera.

19 years agoAdd WAL compression item to TODO.detail.
Bruce Momjian [Thu, 28 Apr 2005 13:25:40 +0000 (13:25 +0000)]
Add WAL compression item to TODO.detail.

19 years agoAdd psql \set ON_ERROR_ROLLBACK to allow statements in a transaction to
Bruce Momjian [Thu, 28 Apr 2005 13:09:59 +0000 (13:09 +0000)]
Add psql \set ON_ERROR_ROLLBACK to allow statements in a transaction to
error without affecting the entire transaction.  Valid values are
"on|interactive|off".

19 years agoWording improvement.
Bruce Momjian [Wed, 27 Apr 2005 20:11:07 +0000 (20:11 +0000)]
Wording improvement.

19 years agoUpdate PAM documentation, per Alvaro.
Bruce Momjian [Wed, 27 Apr 2005 20:09:50 +0000 (20:09 +0000)]
Update PAM documentation, per Alvaro.

19 years agoMention that PAM requires the user already exist in the database, per
Bruce Momjian [Tue, 26 Apr 2005 03:01:09 +0000 (03:01 +0000)]
Mention that PAM requires the user already exist in the database, per
Dick Davies.

19 years agoOn further experimentation, there were still a couple of bugs in
Tom Lane [Mon, 25 Apr 2005 22:02:30 +0000 (22:02 +0000)]
On further experimentation, there were still a couple of bugs in
ExpandIndirectionStar() ... and in markTargetListOrigin() too.

19 years agoFix ExpandIndirectionStar to handle cases where the expression to be
Tom Lane [Mon, 25 Apr 2005 21:03:25 +0000 (21:03 +0000)]
Fix ExpandIndirectionStar to handle cases where the expression to be
expanded is of RECORD type, eg
'select (foo).* from (select foo(f1) from t1) ss'
where foo() is a function declared with multiple OUT parameters.

19 years agoget_expr_result_type probably needs to be able to handle OpExpr as well
Tom Lane [Mon, 25 Apr 2005 20:59:44 +0000 (20:59 +0000)]
get_expr_result_type probably needs to be able to handle OpExpr as well
as FuncExpr, to cover cases where a function returning tuple is invoked
via an operator.

19 years agoUpdate description:
Bruce Momjian [Mon, 25 Apr 2005 15:35:32 +0000 (15:35 +0000)]
Update description:

< * Allow ORDER BY ... LIMIT 1 to select high/low value without sort or
> * Allow ORDER BY ... LIMIT # to select high/low value without sort or
868c868
<   Right now, if no index exists, ORDER BY ... LIMIT 1 requires we sort
>   Right now, if no index exists, ORDER BY ... LIMIT # requires we sort
870a871
>   MIN/MAX already does this, but not for LIMIT > 1.

19 years agoRe-add item with better description:
Bruce Momjian [Mon, 25 Apr 2005 13:03:37 +0000 (13:03 +0000)]
Re-add item with better description:

> * Allow ORDER BY ... LIMIT 1 to select high/low value without sort or
>   index using a sequential scan for highest/lowest values
>
>   Right now, if no index exists, ORDER BY ... LIMIT 1 requires we sort
>   all values to return the high/low value.  Instead The idea is to do a
>   sequential scan to find the high/low value, thus avoiding the sort.
>

19 years agoFix btree_gist to handle timetz zone correctly per recent changes.
Tom Lane [Mon, 25 Apr 2005 07:00:32 +0000 (07:00 +0000)]
Fix btree_gist to handle timetz zone correctly per recent changes.

19 years agoAvoid rechecking lossy operators twice in a bitmap scan plan.
Tom Lane [Mon, 25 Apr 2005 04:27:12 +0000 (04:27 +0000)]
Avoid rechecking lossy operators twice in a bitmap scan plan.

19 years agoWhile determining the filter clauses for an index scan (either plain
Tom Lane [Mon, 25 Apr 2005 03:58:30 +0000 (03:58 +0000)]
While determining the filter clauses for an index scan (either plain
or bitmap), use pred_test to be a little smarter about cases where a
filter clause is logically unnecessary.  This may be overkill for the
plain indexscan case, but it's definitely useful for OR'd bitmap scans.

19 years agoReplace slightly klugy create_bitmap_restriction() function with a
Tom Lane [Mon, 25 Apr 2005 02:14:48 +0000 (02:14 +0000)]
Replace slightly klugy create_bitmap_restriction() function with a
more efficient routine in restrictinfo.c (which can make use of
make_restrictinfo_internal).

19 years agoAdd description for concurrent sequential scans:
Bruce Momjian [Mon, 25 Apr 2005 01:42:41 +0000 (01:42 +0000)]
Add description for concurrent sequential scans:

>   One possible implementation is to start sequential scans from the lowest
>   numbered buffer in the shared cache, and when reaching the end wrap
>   around to the beginning, rather than always starting sequential scans
>   at the start of the table.

19 years agoRemove support for OR'd indexscans internal to a single IndexScan plan
Tom Lane [Mon, 25 Apr 2005 01:30:14 +0000 (01:30 +0000)]
Remove support for OR'd indexscans internal to a single IndexScan plan
node, as this behavior is now better done as a bitmap OR indexscan.
This allows considerable simplification in nodeIndexscan.c itself as
well as several planner modules concerned with indexscan plan generation.
Also we can improve the sharing of code between regular and bitmap
indexscans, since they are now working with nigh-identical Plan nodes.

19 years agoAdjust nodeBitmapIndexscan.c to not keep the index open across calls,
Tom Lane [Sun, 24 Apr 2005 18:16:38 +0000 (18:16 +0000)]
Adjust nodeBitmapIndexscan.c to not keep the index open across calls,
but just to open and close it during MultiExecBitmapIndexScan.  This
avoids acquiring duplicate resources (eg, multiple locks on the same
relation) in a tree with many bitmap scans.  Also, don't bother to
lock the parent heap at all here, since we must be underneath a
BitmapHeapScan node that will be holding a suitable lock.

19 years agoActually, nodeBitmapIndexscan.c doesn't need to create a standard
Tom Lane [Sun, 24 Apr 2005 17:32:46 +0000 (17:32 +0000)]
Actually, nodeBitmapIndexscan.c doesn't need to create a standard
ExprContext at all, since it never evaluates any qual or tlist expressions.

19 years agoPut back example of using Result node to execute an INSERT.
Tom Lane [Sun, 24 Apr 2005 15:32:07 +0000 (15:32 +0000)]
Put back example of using Result node to execute an INSERT.

19 years agoUpdate wording:
Bruce Momjian [Sun, 24 Apr 2005 12:39:07 +0000 (12:39 +0000)]
Update wording:

<   This allows vacuum to reclaim free space without requiring
<   a sequential scan
>   This allows vacuum to target specific pages for possible free space
>   without requiring a sequential scan.

19 years agoUpdate wording.
Bruce Momjian [Sun, 24 Apr 2005 12:01:32 +0000 (12:01 +0000)]
Update wording.

19 years agoClean up HTML.
Bruce Momjian [Sun, 24 Apr 2005 11:57:19 +0000 (11:57 +0000)]
Clean up HTML.

19 years agoAdd replication FAQ item.
Bruce Momjian [Sun, 24 Apr 2005 11:48:52 +0000 (11:48 +0000)]
Add replication FAQ item.

19 years agoUpdate some comments to use SQL examples rather than QUEL. From Simon
Neil Conway [Sun, 24 Apr 2005 11:46:21 +0000 (11:46 +0000)]
Update some comments to use SQL examples rather than QUEL. From Simon
Riggs.

19 years agoAdd line break.
Bruce Momjian [Sun, 24 Apr 2005 11:27:51 +0000 (11:27 +0000)]
Add line break.

19 years agoUpdate book items.
Bruce Momjian [Sun, 24 Apr 2005 11:22:44 +0000 (11:22 +0000)]
Update book items.

19 years agoUpdate VACUUM VERBOSE FSM message, per Tom.
Bruce Momjian [Sun, 24 Apr 2005 03:51:49 +0000 (03:51 +0000)]
Update VACUUM VERBOSE FSM message, per Tom.

19 years agoRepair two TIME WITH TIME ZONE bugs found by Dennis Vshivkov. Comparison
Tom Lane [Sat, 23 Apr 2005 22:53:05 +0000 (22:53 +0000)]
Repair two TIME WITH TIME ZONE bugs found by Dennis Vshivkov.  Comparison
of timetz values misbehaved in --enable-integer-datetime cases, and
EXTRACT(EPOCH) subtracted the zone instead of adding it in all cases.
Backpatch to all supported releases (except --enable-integer-datetime code
does not exist in 7.2).

19 years agoRemove useless argtype_inherit() code, and make consequent simplifications.
Tom Lane [Sat, 23 Apr 2005 22:09:58 +0000 (22:09 +0000)]
Remove useless argtype_inherit() code, and make consequent simplifications.
As I pointed out a few days ago, this code has failed to do anything useful
for some time ... and if we did want to revive the capability to select
functions by nearness of inheritance ancestry, this is the wrong place
and way to do it anyway.  The knowledge would need to go into
func_select_candidate() instead.  Perhaps someday someone will be motivated
to do that, but I am not today.

19 years agoTurns out our existing page size is already optimal in most cases:
Bruce Momjian [Sat, 23 Apr 2005 21:45:28 +0000 (21:45 +0000)]
Turns out our existing page size is already optimal in most cases:

< * Research the use of larger page sizes

19 years agoItem already added to existing 'thread' item:
Bruce Momjian [Sat, 23 Apr 2005 21:44:52 +0000 (21:44 +0000)]
Item already added to existing 'thread' item:

< * Consider parallel processing a single query
<
<   This would involve using multiple threads or processes to do optimization,
<   sorting, or execution of single query.  The major advantage of such a
<   feature would be to allow multiple CPUs to work together to process a
<   single query.
<

19 years agoRemove item, not sure what it refers to:
Bruce Momjian [Sat, 23 Apr 2005 21:43:24 +0000 (21:43 +0000)]
Remove item, not sure what it refers to:

< * Allow ORDER BY ... LIMIT 1 to select high/low value without sort or
<   index using a sequential scan for highest/lowest values
<
<   If only one value is needed, there is no need to sort the entire
<   table. Instead a sequential scan could get the matching value.
<

19 years agoNew item:
Bruce Momjian [Sat, 23 Apr 2005 21:41:01 +0000 (21:41 +0000)]
New item:

> * Change WAL to use 32-bit CRC, for performance reasons