libhb: fix comb detection crash and decomb crash
hb_detect_comb() could crash because the dimensions of the video buffer
don't have to match the dimensions returned by work object info() method
if the video has segments of differeing resolutions.
decomb was allocating reference buffers that were too small. This bug appears
to have always existed but doesn't usually get triggered because malloc
usually rounds allocation sizes up.
sr55 [Sat, 30 Jun 2012 17:37:25 +0000 (17:37 +0000)]
WinGui: Assorted fixes.
- Implementation of CanBeBurned and CanBeForced on the subtitles panel.
- Save updates to user presets from the Presets Options Menu. (Can use Add Preset to overwrite preset configuration instead also)
dynaflash [Wed, 27 Jun 2012 21:06:34 +0000 (21:06 +0000)]
MacGui: Add AppleTV 3 Preset
- Basically High Profile preset with rc-lookahead removed ( so now default)
- 1920 x nnn (1080p) resolution max
- Fast decomb due to the fact that "decomb 3" is currently deemed too much of a speed hit. Upon a speed up recommend a change.
- - Note this is the first device preset to use decomb … fast decomb is better imo than no decomb.
jstebbins [Mon, 25 Jun 2012 07:56:49 +0000 (07:56 +0000)]
libhb: fix deinterlace fast problem with sources that have <mod8 alignment
avpicture_deinterlace requires that both width and height of the input
be 8 pixel aligned. Video buffers already have padding to align horizontally
to 16 pixels, but they were not padded vertically. This adds vertical
padding.
sr55 [Sun, 17 Jun 2012 20:19:28 +0000 (20:19 +0000)]
WinGui: Fix a couple of the issues with the Picture settings view with regard to max width / height settings stored in presets. There are still a number of issues around the calculation of width/height to be tidy'd up.
jstebbins [Sun, 17 Jun 2012 14:04:02 +0000 (14:04 +0000)]
Add CFLAGS and LDFLAGS specified during configure to compile and link commands
Enhances portability.
configure.py already added these to the GNUmakefile output, but the
values did not get incorporated into compile or link commands.
Thanks to Fabian Greffrath and Rogerio Brito for this patch
sr55 [Sat, 16 Jun 2012 16:29:23 +0000 (16:29 +0000)]
WinGui: Convert the Presets Panel to a Listbox and update the styling. This should better reflect the selected preset and cleanup the horrible toolbar styling for the button controls.
sr55 [Thu, 14 Jun 2012 19:08:34 +0000 (19:08 +0000)]
WinGui: Code Cleanup
- New file headers for App Services
- Update Interop to include an IWindsorInstaller implementation
- Update Interop Converter (new framerates and fflac)
- Many stylecop warnings fixed.
sr55 [Thu, 14 Jun 2012 09:59:24 +0000 (09:59 +0000)]
WinGui: Some layout tweaks by beta-tester
- disabling sizing on windows, where sizing makes no sense;
- limit sizing on windows, where sizing in a wrong directions makes problems;
- make controls full sizable, where the readability/information will benefit from;
- all windows appears now in ScreenCenter;
jstebbins [Fri, 8 Jun 2012 21:34:23 +0000 (21:34 +0000)]
Don't override fribidi lib and cflags when building libass on linux
We use the system version of fribidi on linux and overriding the build
flags causes failures on some systems (gentoo).
jstebbins [Fri, 8 Jun 2012 20:38:40 +0000 (20:38 +0000)]
LinGui: fix crash when dvd volume id has non-ascii characters
The iso9660 spec says the volume id must only be composed of 0-9, A-Z, and _.
But dvd authors seem to take liberties with the character set. Certain
non-ascii character sequences cause a crash in the glib function
g_markup_escape_text(). So force all characters into the standard ascii range.
jstebbins [Fri, 8 Jun 2012 17:23:26 +0000 (17:23 +0000)]
LinGui: fix problem with setting the default destination file name
If ghb is started with a parameter that specifies the source, it was
not updating the destination name as it normally would when choosing
the source from the file open dialog.
sr55 [Fri, 8 Jun 2012 02:13:59 +0000 (02:13 +0000)]
WinGui: Added a Shell View which can host various windows. By default this will host the Main window. Changed the Options window to be a usercontrol so it can be hosted in this shell view, allowing for a chrome-esk style options within the main window without the need for a dialog window. The options window will need some design changes. (Coming soon)
jstebbins [Thu, 7 Jun 2012 23:18:40 +0000 (23:18 +0000)]
Portability patches
gudev is only available on linux, so ifdef it out on all other systems.
also add some definitions to the make system for generic gnu and freebsd
systems.
sr55 [Sun, 3 Jun 2012 20:54:33 +0000 (20:54 +0000)]
WinGui: Numerous fixes to the picture settings tab. Fixed framerate typo on the Video tab and fixed an issue on the main window when changing back to Chapters mode. (Start and End points were not set correctly)
sr55 [Thu, 31 May 2012 00:50:26 +0000 (00:50 +0000)]
WinGui: Fix an issue with the x264 CQ Granulairty on certain cultures. Change the way the Destination text box works and update the autonaming code to work with Start and End points.
sr55 [Sun, 27 May 2012 17:29:52 +0000 (17:29 +0000)]
WinGui: Fix a threading bug in the Queue Manger. ClearCompleted should always be done on the UI Thread. This was causing the "Clear completed" queue option to crash.
Rodeo [Sun, 27 May 2012 13:38:41 +0000 (13:38 +0000)]
decdca: attempt to fix Dolby Surround and Pro Logic II mixdown. We were doing it wrong in some cases.
This means Dolby Pro Logic II is now only available for sources with at least L, R, C, Ls, Rs channels (as well as any additional channels), due to some libdca limitations. This will eventually go away when we use our own downmixing for all sources.
Further cleanup to follow.
Also cleans up usage of audio->config.in.flags (was audio->config.flags.*).
- Threaded lookahead: improved encoding speed with very fast settings, on systems with 8 processor "threads" or more.
'By default, lookahead threads are 1/6 of regular threads. This isn't exacting,
but it seems to work well for all presets on real systems. With sliced-threads,
it's the same as the number of encoding threads.'
Mini-benchmark:
---------------
2.2 GHz Intel Core i7, 8 processor threads (4 physical cores + 4 virtual cores), Mac OS X 10.7.4. HandBrake's "Normal" preset.
libavcodec decoding threads: 8 / 2 + 1 = 5
x264 encoding threads: 8 * 3 / 2 = 12
x264 lookahead threads: 12 / 6 = 2
Blu-ray, H.264, 1920x1080 -> 1920x800
~48 fps with threaded lookahead, ~42 fps without
DVD, MPEG-2, 720x576 -> 720x576
~224 fps with threaded lookahead, ~192 fps without
sr55 [Sat, 26 May 2012 02:29:13 +0000 (02:29 +0000)]
WinGui: Improvements and fixes to the Queue Window. Added WhenDone option. Fixed an issue where the progress counter would not display if you started an encode before opening the queue window.
Updated the Options Window to keep settings displayed up to date.
projects / handbrake / log