]> granicus.if.org Git - shadow/log
shadow
16 years ago * src/logoutd.c: Use a bool when possible instead of int integers.
nekral-guest [Mon, 9 Jun 2008 20:02:46 +0000 (20:02 +0000)]
* src/logoutd.c: Use a bool when possible instead of int integers.
* src/logoutd.c: Avoid implicit conversion of pointers / integers
/ chars to booleans.
* src/logoutd.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/logoutd.c: Add brackets and parenthesis.

16 years ago * src/chpasswd.c: Use a bool when possible instead of int
nekral-guest [Mon, 9 Jun 2008 19:46:11 +0000 (19:46 +0000)]
* src/chpasswd.c: Use a bool when possible instead of int
integers.
* src/chpasswd.c: Avoid implicit conversion of pointers / integers
/ chars to booleans.
* src/chpasswd.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().

16 years ago * src/pwconv.c: Use a bool when possible instead of int integers.
nekral-guest [Mon, 9 Jun 2008 19:43:22 +0000 (19:43 +0000)]
* src/pwconv.c: Use a bool when possible instead of int integers.
* src/pwconv.c: Add brackets and parenthesis.
* src/pwconv.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/pwconv.c: Avoid implicit conversion of pointers / integers /
chars to booleans.

16 years ago * NEWS, src/newusers.c: Implement the -r, --system option.
nekral-guest [Mon, 9 Jun 2008 19:36:08 +0000 (19:36 +0000)]
* NEWS, src/newusers.c: Implement the -r, --system option.
* src/newusers.c: Use a bool when possible instead of int
integers.
* src/newusers.c: Avoid implicit conversion of pointers / integers
/ chars to booleans.
* src/newusers.c: Ignore the return value of pam_end() before
exiting.
* src/newusers.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/newusers.c: Avoid multi-statements lines.
* src/newusers.c: Add brackets and parenthesis.

16 years ago * src/gpasswd.c: Use a bool when possible instead of int integers.
nekral-guest [Mon, 9 Jun 2008 19:26:19 +0000 (19:26 +0000)]
* src/gpasswd.c: Use a bool when possible instead of int integers.
* src/gpasswd.c: Avoid implicit conversion of pointers / integers
/ chars to booleans.
* src/gpasswd.c: Ignore the return value of putchar() and fflush()
before exiting.
* src/gpasswd.c: check_list() renamed is_valid_user_list(), and
return a bool.
* src/gpasswd.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().

16 years ago * src/grpck.c: Use a bool when possible instead of int integers.
nekral-guest [Mon, 9 Jun 2008 19:20:00 +0000 (19:20 +0000)]
* src/grpck.c: Use a bool when possible instead of int integers.
* src/grpck.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().

16 years ago * src/lastlog.c: Use a bool when possible instead of int integers.
nekral-guest [Mon, 9 Jun 2008 19:15:27 +0000 (19:15 +0000)]
* src/lastlog.c: Use a bool when possible instead of int integers.
* src/lastlog.c: Avoid implicit conversion of pointers / integers
/ chars to booleans.
* src/lastlog.c: Add brackets and parenthesis.
* src/lastlog.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().

16 years ago * src/userdel.c: Use a bool for the is_shadow_pwd, is_shadow_grp,
nekral-guest [Mon, 9 Jun 2008 19:10:44 +0000 (19:10 +0000)]
* src/userdel.c: Use a bool for the is_shadow_pwd, is_shadow_grp,
deleted_user_group, was_member, was_admin, and the
options' flags.
* src/userdel.c: Change path_prefix() prototype to return a bool.
* src/userdel.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/userdel.c: Ignore the return value from pam_end() since we
are exiting anyway just afterwards.
* src/userdel.c: Avoid implicit conversion of pointers /
integers / chars to booleans.
* src/userdel.c: Add brackets and parenthesis.
* src/userdel.c: Avoid assignments in comparisons.
* src/userdel.c: Do not ignore the return value of the *_unlock()
functions.

16 years ago * src/login_nopam.c: Do not use the YES and NO macros. Use the
nekral-guest [Mon, 9 Jun 2008 18:35:32 +0000 (18:35 +0000)]
* src/login_nopam.c: Do not use the YES and NO macros. Use the
booleans true and false instead. Change the prototypes of
list_match(), user_match(), from_match(), and string_match()
accordingly. Also use booleans internally.
* src/login_nopam.c: Add brackets and parenthesis.
* src/login_nopam.c: Avoid implicit conversion of pointers /
integers / chars to booleans.
* src/login_nopam.c: Avoid assignments in comparisons.

16 years ago * src/newgrp.c: Use a bool for is_newgrp, notfound, needspasswd,
nekral-guest [Mon, 9 Jun 2008 18:23:23 +0000 (18:23 +0000)]
* src/newgrp.c: Use a bool for is_newgrp, notfound, needspasswd,
initflag, and cflag.
* src/newgrp.c: Add brackets and parenthesis.
* src/newgrp.c: Avoid implicit conversion of pointers / integers /
chars to booleans.
* src/newgrp.c: Avoid multi-statements lines.
* src/newgrp.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/newgrp.c: Avoid assignments in comparisons.

16 years ago * libmisc/list.c: Change is_on_list() prototype to return a bool.
nekral-guest [Mon, 9 Jun 2008 18:13:52 +0000 (18:13 +0000)]
* libmisc/list.c: Change is_on_list() prototype to return a bool.

16 years ago * libmisc/find_new_ids.c: Change find_new_uid() and find_new_gid()
nekral-guest [Mon, 9 Jun 2008 18:13:09 +0000 (18:13 +0000)]
* libmisc/find_new_ids.c: Change find_new_uid() and find_new_gid()
prototypes to use a bool for their first argument (sys_user /
sys_group).

16 years ago * libmisc/console.c: Change is_listed() prototype to return a bool.
nekral-guest [Mon, 9 Jun 2008 18:11:20 +0000 (18:11 +0000)]
* libmisc/console.c: Change is_listed() prototype to return a bool.
The default parameter should also be a bool.
* libmisc/console.c: Add brackets and parenthesis.
* libmisc/console.c: Avoid assignments in comparisons.
* libmisc/console.c: Change console() prototype to return a bool.

16 years ago * lib/sgetspent.c: Add brackets and parenthesis.
nekral-guest [Mon, 26 May 2008 09:39:29 +0000 (09:39 +0000)]
* lib/sgetspent.c: Add brackets and parenthesis.
* lib/sgetspent.c: Avoid assignments in comparisons.
* lib/sgetspent.c: Avoid implicit conversion of pointers / chars to booleans.
* lib/sgetspent.c: Avoid multi-statements lines.

16 years agoAvoid assignments in comparisons.
nekral-guest [Mon, 26 May 2008 09:22:44 +0000 (09:22 +0000)]
Avoid assignments in comparisons.
Add note about possible bug.

16 years agoDo not check twice if fields[2] and fields[3] are not empty.
nekral-guest [Mon, 26 May 2008 09:17:17 +0000 (09:17 +0000)]
Do not check twice if fields[2] and fields[3] are not empty.

16 years ago * lib/sgetpwent.c: Avoid implicit conversion of pointers / chars to booleans.
nekral-guest [Mon, 26 May 2008 09:15:02 +0000 (09:15 +0000)]
* lib/sgetpwent.c: Avoid implicit conversion of pointers / chars to booleans.
* lib/sgetpwent.c: Add brackets and parenthesis.
* lib/sgetpwent.c: Return NULL instead of 0.

16 years ago* Avoid implicit conversion of pointers to booleans.
nekral-guest [Mon, 26 May 2008 09:12:34 +0000 (09:12 +0000)]
* Avoid implicit conversion of pointers to booleans.
* Add parenthesis.

16 years ago * libmisc/getdate.y: abbrev is a bool.
nekral-guest [Mon, 26 May 2008 08:59:54 +0000 (08:59 +0000)]
* libmisc/getdate.y: abbrev is a bool.
* libmisc/getdate.y: Avoid implicit conversion of pointers / chars / integers to booleans.

16 years ago * lib/prototypes.h: Fix prototypes according to earlier changes (usage of the bool...
nekral-guest [Mon, 26 May 2008 08:56:34 +0000 (08:56 +0000)]
* lib/prototypes.h: Fix prototypes according to earlier changes (usage of the bool type).
* lib/prototypes.h: Add the arguments' name to the prototypes.

16 years agoAdd protection against multiple inclusions.
nekral-guest [Mon, 26 May 2008 08:53:56 +0000 (08:53 +0000)]
Add protection against multiple inclusions.

16 years agoIndicate that defines.h is included for the definition of the "bool" type.
nekral-guest [Mon, 26 May 2008 08:52:34 +0000 (08:52 +0000)]
Indicate that defines.h is included for the definition of the "bool" type.

16 years agoThe changed, isopen, locked, and readonly fields of the db are booleans.
nekral-guest [Mon, 26 May 2008 08:51:45 +0000 (08:51 +0000)]
The changed, isopen, locked, and readonly fields of the db are booleans.

16 years ago * lib/pwio.h: Add protection against multiple inclusions.
nekral-guest [Mon, 26 May 2008 08:49:44 +0000 (08:49 +0000)]
* lib/pwio.h: Add protection against multiple inclusions.
* lib/pwio.c: The changed, isopen, locked, and readonly fields of the db are booleans.

16 years ago * lib/sgroupio.c: Avoid assignments in comparisons.
nekral-guest [Mon, 26 May 2008 08:46:41 +0000 (08:46 +0000)]
* lib/sgroupio.c: Avoid assignments in comparisons.
* lib/sgroupio.c: Add brackets.
* lib/sgroupio.c: Avoid implicit conversion of pointers / integers to booleans.
* lib/sgroupio.c: The changed, isopen, locked, and readonly fields of the db are booleans.
* lib/sgroupio.h, lib/sgroupio.c: sgr_file_present returns a bool.
* lib/sgroupio.h: Add protection against multiple inclusions.

16 years ago * lib/shadowio.h, lib/shadowio.c: spw_file_present returns a bool.
nekral-guest [Mon, 26 May 2008 08:45:34 +0000 (08:45 +0000)]
* lib/shadowio.h, lib/shadowio.c: spw_file_present returns a bool.
* lib/shadowio.h: Add protection against multiple inclusions.

16 years ago * lib/sgroupio.c: Avoid assignments in comparisons.
nekral-guest [Mon, 26 May 2008 08:43:50 +0000 (08:43 +0000)]
* lib/sgroupio.c: Avoid assignments in comparisons.
* lib/sgroupio.c: Add brackets.
* lib/sgroupio.c: Avoid implicit conversion of pointers / integers to booleans.
* lib/sgroupio.c: The changed, isopen, locked, and readonly fields of the db are booleans.
* lib/sgroupio.h, lib/sgroupio.c: sgr_file_present returns a bool.
* lib/sgroupio.h: Add protection against multiple inclusions.

16 years ago * lib/gshadow.c: nis_used and nis_bound are booleans.
nekral-guest [Mon, 26 May 2008 08:40:04 +0000 (08:40 +0000)]
* lib/gshadow.c: nis_used and nis_bound are booleans.
* lib/gshadow.c: Avoid implicit conversion of pointers / integers to booleans.
* lib/gshadow.c: Avoid assignments in comparisons.
* lib/gshadow.c: Add brackets.

16 years agoAdd protection against multiple inclusion
nekral-guest [Mon, 26 May 2008 08:35:13 +0000 (08:35 +0000)]
Add protection against multiple inclusion

16 years agoThe changed, isopen, locked, and readonly fields of the db are booleans.
nekral-guest [Mon, 26 May 2008 08:34:04 +0000 (08:34 +0000)]
The changed, isopen, locked, and readonly fields of the db are booleans.

16 years ago * lib/sgetgrent.c: implicit conversion of pointers / chars to booleans.
nekral-guest [Mon, 26 May 2008 08:31:14 +0000 (08:31 +0000)]
* lib/sgetgrent.c: implicit conversion of pointers / chars to booleans.
* lib/sgetgrent.c: Avoid assignments in comparisons.
* lib/sgetgrent.c: Add brackets.

16 years ago * lib/encrypt.c: Avoid implicit conversion of pointers to booleans.
nekral-guest [Mon, 26 May 2008 01:07:13 +0000 (01:07 +0000)]
* lib/encrypt.c: Avoid implicit conversion of pointers to booleans.
* lib/encrypt.c: Add parenthesis.

16 years ago * lib/port.c: Avoid implicit conversion of pointers / integers / chars to booleans.
nekral-guest [Mon, 26 May 2008 01:05:04 +0000 (01:05 +0000)]
* lib/port.c: Avoid implicit conversion of pointers / integers / chars to booleans.
* lib/port.c: Avoid multiple statement on the same line.
* lib/port.c: Add brackets and parenthesis.
* lib/port.c: Avoid assignments in comparisons.
* lib/port.c: Fix typo comparision -> comparison (in comment).

16 years ago * lib/fputsx.c: Add brackets.
nekral-guest [Mon, 26 May 2008 00:59:42 +0000 (00:59 +0000)]
* lib/fputsx.c: Add brackets.
* lib/fputsx.c: Avoid assignments in comparisons.
* lib/fputsx.c: Avoid implicit conversion of pointers / integers / chars to booleans.

16 years ago * lib/commonio.h: commonio_entry.changed, commonio_db.changed, commonio_db.isopen...
nekral-guest [Mon, 26 May 2008 00:46:25 +0000 (00:46 +0000)]
* lib/commonio.h: commonio_entry.changed, commonio_db.changed, commonio_db.isopen, commonio_db.locked, and commonio_db.readonly are no booleans.
* lib/commonio.h: Include defines.h to get the definition of bool.
* lib/commonio.h: commonio_present returns a bool
* lib/commonio.c: Implement above changes.
* lib/commonio.c: add argument names in prototypes.
* lib/commonio.c: name_is_nis returns a bool.
* lib/commonio.c: nscd_need_reload is a bool.
* lib/commonio.c: Improve types (use size_t / pid_t when needed instead of int).
* lib/commonio.c: Avoid assignments in comparisons.
* lib/commonio.c: Add brackets and parenthesis.
* lib/commonio.c: Avoid implicit conversion of pointers / integers to booleans
* lib/commonio.c: The return values of utime is not checked on purpose.

16 years agocheckutmp is implemented twice. I only changed the second one. Now fix the
nekral-guest [Mon, 26 May 2008 00:26:33 +0000 (00:26 +0000)]
checkutmp is implemented twice. I only changed the second one. Now fix the
first one.

16 years ago * libmisc/isexpired.c: ARGSUSED is no more needed (shadow is always supported).
nekral-guest [Mon, 26 May 2008 00:14:10 +0000 (00:14 +0000)]
* libmisc/isexpired.c: ARGSUSED is no more needed (shadow is always supported).
* libmisc/isexpired.c: Avoid implicit conversion of pointers to booleans.
* libmisc/isexpired.c: Add brackets and parenthesis.

16 years ago * libmisc/sulog.c (sulog): The success argument is a bool.
nekral-guest [Mon, 26 May 2008 00:09:24 +0000 (00:09 +0000)]
* libmisc/sulog.c (sulog): The success argument is a bool.
* libmisc/sulog.c: The return values of fflush is not checked on purpose.
* libmisc/sulog.c: Indicate that some return values should be checked.

16 years agoUpdated copyright dates.
nekral-guest [Mon, 26 May 2008 00:04:30 +0000 (00:04 +0000)]
Updated copyright dates.

16 years ago * libmisc/ttytype.c: Avoid implicit conversion of pointers / integers to booleans.
nekral-guest [Mon, 26 May 2008 00:02:15 +0000 (00:02 +0000)]
* libmisc/ttytype.c: Avoid implicit conversion of pointers / integers to booleans.
* libmisc/ttytype.c: Avoid assignments in comparisons.
* libmisc/ttytype.c: Add brackets and parenthesis.
* libmisc/ttytype.c: The return values of fclose is not checked on purpose.

16 years ago * libmisc/mail.c: Avoid implicit conversion of pointers to booleans.
nekral-guest [Sun, 25 May 2008 23:59:05 +0000 (23:59 +0000)]
* libmisc/mail.c: Avoid implicit conversion of pointers to booleans.
* libmisc/mail.c: Avoid assignments in comparisons.

16 years ago * libmisc/loginprompt.c: Avoid implicit conversion of pointers / chars to booleans.
nekral-guest [Sun, 25 May 2008 23:57:41 +0000 (23:57 +0000)]
* libmisc/loginprompt.c: Avoid implicit conversion of pointers / chars to booleans.
* libmisc/loginprompt.c: Add brackets.
* libmisc/loginprompt.c: Avoid assignments in comparisons.
* libmisc/loginprompt.c: The return values of fclose and fflush are not checked on purpose.

16 years agoAvoid implicit conversion of chars to booleans.
nekral-guest [Sun, 25 May 2008 23:50:03 +0000 (23:50 +0000)]
Avoid implicit conversion of chars to booleans.

16 years agoselinux_checked, selinux_enabled, and set_orig are now booleans.
nekral-guest [Sun, 25 May 2008 23:45:21 +0000 (23:45 +0000)]
selinux_checked, selinux_enabled, and set_orig are now booleans.

16 years ago * libmisc/setugid.c (setup_uid_gid): The is_console argument is now a bool.
nekral-guest [Sun, 25 May 2008 23:42:39 +0000 (23:42 +0000)]
* libmisc/setugid.c (setup_uid_gid): The is_console argument is now a bool.
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.

16 years ago * libmisc/setugid.c (setup_uid_gid): The is_console argument is no a bool.
nekral-guest [Sun, 25 May 2008 23:39:59 +0000 (23:39 +0000)]
* libmisc/setugid.c (setup_uid_gid): The is_console argument is no a bool.
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.

16 years ago * libmisc/pam_pass.c (do_pam_passwd): The silent and
nekral-guest [Sun, 25 May 2008 23:38:05 +0000 (23:38 +0000)]
* libmisc/pam_pass.c (do_pam_passwd): The silent and
change_expired are no booleans instead of int.
* libmisc/pam_pass.c: The return value of pam_end is not checked
on purpose.

16 years agoUpdated copyright dates.
nekral-guest [Sun, 25 May 2008 23:32:41 +0000 (23:32 +0000)]
Updated copyright dates.

16 years agoUpdated copyright dates.
nekral-guest [Sun, 25 May 2008 23:31:10 +0000 (23:31 +0000)]
Updated copyright dates.

16 years ago * libmisc/getlong.c: Avoid implicit conversion of pointers / chars to booleans.
nekral-guest [Sun, 25 May 2008 23:25:33 +0000 (23:25 +0000)]
* libmisc/getlong.c: Avoid implicit conversion of pointers / chars to booleans.
* libmisc/getlong.c: Add brackets.

16 years ago * libmisc/valid.c: Avoid implicit conversion of pointers /chars to booleans.
nekral-guest [Sun, 25 May 2008 23:22:15 +0000 (23:22 +0000)]
* libmisc/valid.c: Avoid implicit conversion of pointers /chars to booleans.
* libmisc/valid.c: Add brackets.

16 years ago * libmisc/yesno.c: yes_or_no returns a bool instead of int.
nekral-guest [Sun, 25 May 2008 23:01:14 +0000 (23:01 +0000)]
* libmisc/yesno.c: yes_or_no returns a bool instead of int.
* libmisc/yesno.c: Avoid implicit conversion of pointers to booleans.
* libmisc/yesno.c: The return value of fflush is not checked on purpose.

16 years ago(failcheck): The failed argument is a bool.
nekral-guest [Sun, 25 May 2008 22:54:20 +0000 (22:54 +0000)]
(failcheck): The failed argument is a bool.

16 years agoAvoid implicit conversion of integers to booleans.
nekral-guest [Sun, 25 May 2008 22:51:46 +0000 (22:51 +0000)]
Avoid implicit conversion of integers to booleans.

16 years ago * libmisc/rlogin.c: Avoid assignments in comparisons.
nekral-guest [Sun, 25 May 2008 22:49:41 +0000 (22:49 +0000)]
* libmisc/rlogin.c: Avoid assignments in comparisons.
* libmisc/rlogin.c: Avoid implicit conversion of integers to booleans.
* libmisc/rlogin.c: Add brackets.

16 years ago * libmisc/failure.c (failcheck): The failed argument is a bool.
nekral-guest [Sun, 25 May 2008 22:44:44 +0000 (22:44 +0000)]
* libmisc/failure.c (failcheck): The failed argument is a bool.
* libmisc/failure.c (too_many_failures): too_many_failures returns
a bool.
* libmisc/failure.c: Add notes about unchecked return values.
* libmisc/failure.c: Avoid assignments in comparisons.
* libmisc/failure.c: Add brackets.

16 years ago * libmisc/myname.c: Avoid assignments in comparisons.
nekral-guest [Sun, 25 May 2008 22:15:28 +0000 (22:15 +0000)]
* libmisc/myname.c: Avoid assignments in comparisons.
* libmisc/myname.c: Avoid implicit conversion of pointers / chars
to booleans.
* libmisc/myname.c: Add brackets.

16 years ago(no commit message)
nekral-guest [Sun, 25 May 2008 22:14:19 +0000 (22:14 +0000)]

16 years ago * libmisc/utmp.c (checkutmp): Change picky argument's type to
nekral-guest [Sun, 25 May 2008 22:11:12 +0000 (22:11 +0000)]
* libmisc/utmp.c (checkutmp): Change picky argument's type to
bool.
* libmisc/utmp.c: Use bool when possible (found_utmpx,
found_utmp).
* libmisc/utmp.c: Add note about unchecked return values.

16 years ago* Change type of added to bool.
nekral-guest [Sun, 25 May 2008 22:03:09 +0000 (22:03 +0000)]
* Change type of added to bool.
* Avoid implicit conversion of pointers to booleans.

16 years ago* hushed returns a bool instead of int.
nekral-guest [Sun, 25 May 2008 21:52:14 +0000 (21:52 +0000)]
* hushed returns a bool instead of int.
* Avoid assignments in comparisons.
* (hushed) Change type of found to bool.
* Add brackets.
* Always check if the user or the shell is in
  the file. Do not check the first character of the line first. This
  is simpler and match better with the HUSHLOGIN_FILE documentation.

16 years ago * lib/getdef.h, lib/getdef.c: getdef_bool returns a bool instead
nekral-guest [Sun, 25 May 2008 21:43:05 +0000 (21:43 +0000)]
* lib/getdef.h, lib/getdef.c: getdef_bool returns a bool instead
of int.
* lib/getdef.c: Change typo of def_loaded to bool.
* lib/getdef.c: Add brackets.
* lib/getdef.c: Avoid assignment in comparisons.

16 years agoAllow usage of booleans in the source.
nekral-guest [Sun, 25 May 2008 21:34:38 +0000 (21:34 +0000)]
Allow usage of booleans in the source.

16 years ago* is_my_tty returns a bool.
nekral-guest [Sun, 25 May 2008 21:33:38 +0000 (21:33 +0000)]
* is_my_tty returns a bool.
* Avoid implicit conversion of integers to booleans.
* Add brackets.

16 years ago* Avoid assignment in comparisons, implicit comparison of integers to booleans.
nekral-guest [Sun, 25 May 2008 21:23:28 +0000 (21:23 +0000)]
* Avoid assignment in comparisons, implicit comparison of integers to booleans.
* The return value of closedir is not checked on purpose.
* Add brackets.

16 years ago * libmisc/chkname.h, libmisc/chkname.c: check_group_name (resp.
nekral-guest [Sun, 25 May 2008 20:58:16 +0000 (20:58 +0000)]
* libmisc/chkname.h, libmisc/chkname.c: check_group_name (resp.
check_user_name) renamed to is_valid_user_name (resp.
is_valid_group_name). is_valid_user_name and is_valid_group_name
return a bool.
* src/grpck.c, src/newusers.c, src/usermod.c, src/useradd.c,
src/groupmod.c, src/pwck.c, src/groupadd.c: Use is_valid_user_name
and is_valid_group_name, following above change.
* libmisc/chkname.c: Avoid implicit conversion of chars to
booleans. Add brackets and parenthesis.

16 years agoAvoid implicit conversion of integers / pointers to booleans.
nekral-guest [Sun, 25 May 2008 20:41:13 +0000 (20:41 +0000)]
Avoid implicit conversion of integers / pointers to booleans.

16 years agoAvoid implicit conversion of integers / pointers to booleans.
nekral-guest [Sun, 25 May 2008 20:39:31 +0000 (20:39 +0000)]
Avoid implicit conversion of integers / pointers to booleans.

16 years agoAllow usage of booleans in the source.
nekral-guest [Sun, 25 May 2008 20:37:51 +0000 (20:37 +0000)]
Allow usage of booleans in the source.

16 years agoAllow --disable-man and --enable-man=no.
nekral-guest [Sun, 25 May 2008 20:30:45 +0000 (20:30 +0000)]
Allow --disable-man and --enable-man=no.

16 years agoSet the version to 4.1.2.
nekral-guest [Sat, 24 May 2008 23:15:47 +0000 (23:15 +0000)]
Set the version to 4.1.2.

16 years ago Prepare the 4.1.2 release
nekral-guest [Sat, 24 May 2008 23:03:24 +0000 (23:03 +0000)]
Prepare the 4.1.2 release
* NEWS: set the release date.
* man/po/*.po, po/*.po: Updated PO files.

16 years agoRun msgmerge with --previous. (This requires gettext >= 0.16)
nekral-guest [Sat, 24 May 2008 22:58:21 +0000 (22:58 +0000)]
Run msgmerge with --previous. (This requires gettext >= 0.16)

16 years ago * libmisc/copydir.c (remove_tree): As we always use remove_tree
nekral-guest [Sat, 24 May 2008 15:35:15 +0000 (15:35 +0000)]
* libmisc/copydir.c (remove_tree): As we always use remove_tree
followed by rmdir to remove the directory itself, delete also the
root directory in remove_tree.
* src/userdel.c, src/usermod.c: Do not call rmdir after
remove_tree.

16 years ago * libmisc/fields.c: Avoid assignments in comparisons, assignments
nekral-guest [Sat, 24 May 2008 15:19:02 +0000 (15:19 +0000)]
* libmisc/fields.c: Avoid assignments in comparisons, assignments
with post increments (x++), use of integers as booleans, and
explicitly mark blocks with brackets.
* libmisc/copydir.c: Likewise.
* libmisc/fields.c: Add comments.
* libmisc/copydir.c: Mark function whose return value is not
checked as such.

* libmisc/copydir.c (remove_tree): Make sure unlink is successful
when removing files.

16 years agoSimply passwd_check since it's never used when configured with PAM support.
nekral-guest [Sat, 24 May 2008 14:11:31 +0000 (14:11 +0000)]
Simply passwd_check since it's never used when configured with PAM support.

16 years ago * libmisc/list.c: Avoid assignments in comparisons, assignments
nekral-guest [Sat, 24 May 2008 14:09:35 +0000 (14:09 +0000)]
* libmisc/list.c: Avoid assignments in comparisons, assignments
with post increments (x++), use of integers as booleans, and
explicitly mark blocks with brackets.

16 years ago Fix compiler warnings:
nekral-guest [Sat, 24 May 2008 13:08:58 +0000 (13:08 +0000)]
Fix compiler warnings:
* libmisc/audit_help.c: Include prototypes.h to get the prototype
of audit_help_open.
* libmisc/salt.c: Use booleans instead of negating integers.
* src/passwd.c: Declare the check_selinux_access prototype and
avoid name clashes (change_user -> changed_user; change_uid ->
changed_uid; access -> requested_access)

16 years agoUse fputs rather than fprintf for constant strings.
nekral-guest [Fri, 23 May 2008 20:55:11 +0000 (20:55 +0000)]
Use fputs rather than fprintf for constant strings.

16 years agoAdded TODO items.
nekral-guest [Fri, 23 May 2008 20:47:45 +0000 (20:47 +0000)]
Added TODO items.

16 years agoIndicate that login should be executed with "exec login" if called from a shell.
nekral-guest [Wed, 21 May 2008 18:58:06 +0000 (18:58 +0000)]
Indicate that login should be executed with "exec login" if called from a shell.

16 years agoRemove the advices for the choice of a good password (they are debatable). Point...
nekral-guest [Wed, 21 May 2008 18:25:48 +0000 (18:25 +0000)]
Remove the advices for the choice of a good password (they are debatable). Point to http://en.wikipedia.org/wiki/Password_strength instead.

16 years ago*** security:
nekral-guest [Tue, 20 May 2008 13:34:06 +0000 (13:34 +0000)]
*** security:
- generation of SHA encrypted passwords (chpasswd, gpasswd, newusers,
  chgpasswd; and also passwd if configured without PAM support).
  The number of rounds and number of salt bytes was fixed to their lower
  allowed values (resp. configurable and 8), hence voiding some of the
  advantages of this encryption method. Dictionary attacks with
  precomputed tables were easier than expected, but still harder than with
  the MD5 (or DES) methods.

* NEWS, libmisc/salt.c (SHA_salt_size): Seed the RNG, and fix a
overflow. These caused the SHA salt size to always be 8 bytes,
instead of being in the 8-16 range. Thanks to Peter Vrabec
pvrabec@redhat.com for noticing.
* NEWS, libmisc/salt.c (SHA_salt_rounds): Seed the RNG with
seedRNG instead of srand, and fix the same overflow. This caused
the number of rounds to always be the smallest one.

16 years agoTag the section which require --enable-shadowgrp or --with-sha-crypt
nekral-guest [Mon, 19 May 2008 22:18:14 +0000 (22:18 +0000)]
Tag the section which require --enable-shadowgrp or --with-sha-crypt
accordingly.

16 years agoSHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can only exist if configured with ...
nekral-guest [Mon, 19 May 2008 21:57:48 +0000 (21:57 +0000)]
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can only exist if configured with --with-sha-crypt.

16 years agoDocument the -k, --skel option, and update the -m, --create-home documentation.
nekral-guest [Mon, 19 May 2008 21:32:19 +0000 (21:32 +0000)]
Document the -k, --skel option, and update the -m, --create-home documentation.

16 years agoSort options.
nekral-guest [Mon, 19 May 2008 21:04:34 +0000 (21:04 +0000)]
Sort options.

16 years agoSHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
nekral-guest [Mon, 19 May 2008 20:59:51 +0000 (20:59 +0000)]
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
only exist if configured with --with-sha-crypt.

16 years agoSHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
nekral-guest [Mon, 19 May 2008 20:58:59 +0000 (20:58 +0000)]
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
only exist if configured with --with-sha-crypt.

16 years agoDocument the sections closed by #endif
nekral-guest [Mon, 19 May 2008 20:56:48 +0000 (20:56 +0000)]
Document the sections closed by #endif

16 years ago * NEWS, man/groupadd.8.xml: Document the -r, --system option.
nekral-guest [Mon, 19 May 2008 20:53:12 +0000 (20:53 +0000)]
* NEWS, man/groupadd.8.xml: Document the -r, --system option.
* NEWS, man/newusers.8.xml: Document the -r, --system option.
* NEWS, man/newusers.8.xml: Document the -c, --crypt-method and
-s, --sha-rounds options.

16 years agoFix formatting.
nekral-guest [Mon, 19 May 2008 20:31:48 +0000 (20:31 +0000)]
Fix formatting.

16 years agoDocument the -r, --system option.
nekral-guest [Mon, 19 May 2008 19:43:24 +0000 (19:43 +0000)]
Document the -r, --system option.

16 years agoFix typo.
nekral-guest [Sun, 18 May 2008 16:38:13 +0000 (16:38 +0000)]
Fix typo.

16 years ago Import Debian patch 487_passwd_chauthtok_failed_message
nekral-guest [Sun, 18 May 2008 15:06:51 +0000 (15:06 +0000)]
Import Debian patch 487_passwd_chauthtok_failed_message
* libmisc/pam_pass.c: Be more verbose and indicate that the
password was not changed when pam_chauthtok fails (in addition to
the PAM error, which may not be comprehensible for the users).

16 years ago Import Debian patch 434_login_stop_checking_args_after--
nekral-guest [Sun, 18 May 2008 14:54:35 +0000 (14:54 +0000)]
Import Debian patch 434_login_stop_checking_args_after--
* NEWS, src/login.c (check_flags): Stop checking the arguments
after --. The later options will be sent to the shell, and do not
need to be checked.

16 years ago * src/vipw.c, src/su.c, src/newgrp.c: Harmonize the children's
nekral-guest [Sun, 18 May 2008 13:41:56 +0000 (13:41 +0000)]
* src/vipw.c, src/su.c, src/newgrp.c: Harmonize the children's
SIGSTOP handling. Raise the signal which stopped the child instead
of always SIGSTOP.

Import Debian patch 406_vipw_resume_properly.
Thanks to Dean Gaudet.
* NEWS, src/vipw.c: Resume properly after ^Z.

16 years agoMake sure every source files are distributed with a copyright and license.
nekral-guest [Sun, 27 Apr 2008 00:40:09 +0000 (00:40 +0000)]
Make sure every source files are distributed with a copyright and license.
Files with no license use the default 3-clauses BSD license. The copyright
were mostly not recorded; they were updated according to the Changelog.
"Julianne Frances Haugh and contributors" changed to "copyright holders
and contributors".

16 years agoIf the SULOG_FILE does not exist when an su session is logged, make sure
nekral-guest [Sun, 27 Apr 2008 00:27:59 +0000 (00:27 +0000)]
If the SULOG_FILE does not exist when an su session is logged, make sure
the file is created with group root, instead of using the group of the
caller.

16 years agoAllow non-US-ASCII characters in the GECOS fields ("name", "room number",
nekral-guest [Sun, 27 Apr 2008 00:24:49 +0000 (00:24 +0000)]
Allow non-US-ASCII characters in the GECOS fields ("name", "room number",
and "other info" fields).