]> granicus.if.org Git - graphviz/log
graphviz
7 years agoRemove `AC_HEADER_TIME` from configure.ac
Erwin Janssen [Wed, 8 Feb 2017 17:14:10 +0000 (18:14 +0100)]
Remove `AC_HEADER_TIME` from configure.ac

This check is deprecated according to the official autoconf documentation,
it can safely be removed.

7 years agoRemove final check and usage of stdbool.h
Erwin Janssen [Wed, 8 Feb 2017 17:10:52 +0000 (18:10 +0100)]
Remove final check and usage of stdbool.h

Removed the check for stdbool.h from configure.ac and a remaining usage
of the define.

7 years agoRemove HAVE_STDBOOL_H check from common/logic.h
Erwin Janssen [Mon, 6 Feb 2017 17:12:22 +0000 (18:12 +0100)]
Remove HAVE_STDBOOL_H check from common/logic.h

This header check was removed earlier, but this one was missed. The C++
check can also be removed, because the stdbool.h header files includes is
check by itself.

7 years agoInclude header check for unistd.h in utils.c
Erwin Janssen [Sat, 4 Feb 2017 14:40:07 +0000 (15:40 +0100)]
Include header check for unistd.h in utils.c

The header unistd.h is not available on on platforms, so we add a check
around it.

7 years agoDon't use path as variable name in colortbl.awk
Erwin Janssen [Sat, 4 Feb 2017 10:21:18 +0000 (11:21 +0100)]
Don't use path as variable name in colortbl.awk

Instead of using `argv[1]` to name the variable, we now always call it
`color_lib` in awk/colortbl.awk. The reason for this, is in some build
configurations, like the Visual Studio and CMake build, the full path to
the color_lib file is used. This resulted in the variable conaining
slashes, etc. Since the rest of the code already assumes this variable is
called `color_lib`, there is no problem with hard coding it in
colortbl.awk

7 years agoRemove email address from .travis.yml
Erwin Janssen [Tue, 31 Jan 2017 15:57:32 +0000 (16:57 +0100)]
Remove email address from .travis.yml

Notifications about the build were now always send to John, even when
someone else, in their own fork, was using Travis. This should send the
emails to the one that issued the build.

7 years agoMade libgvpr a dynamic library on Windows
Erwin Janssen [Tue, 31 Jan 2017 13:29:46 +0000 (14:29 +0100)]
Made libgvpr a dynamic library on Windows

libgvpr is a dynamic library with the Autotools build, but was for some
reason a static library on Windows. Since Autotools is considered the
default, this commit makes libgvpr a dynamic library on Windows as well.
The added define "GVPR_API", is used for linking, so a seperate gvpr.def
file is not needed. On non-Windows platforms, this define is set to
"extern", so nothing changes there.

7 years agofix gtk_message_dialog_new() usage (fc26)
John Ellson [Sun, 5 Mar 2017 16:42:50 +0000 (11:42 -0500)]
fix gtk_message_dialog_new() usage (fc26)

7 years agofix gtk_message_dialog_new() usage (fc26)
John Ellson [Sun, 5 Mar 2017 16:32:26 +0000 (11:32 -0500)]
fix gtk_message_dialog_new() usage (fc26)

7 years agotrying to fix an issue with %post in rpm .spec filr
John Ellson [Sun, 5 Mar 2017 05:29:19 +0000 (00:29 -0500)]
trying to fix an issue with %post in rpm .spec filr

7 years agoAdd initializer to avoid warning.
Emden Gansner [Fri, 3 Mar 2017 15:46:58 +0000 (10:46 -0500)]
Add initializer to avoid warning.

7 years agoFix warning messages.
Emden Gansner [Fri, 3 Mar 2017 15:38:56 +0000 (10:38 -0500)]
Fix warning messages.

7 years agoFix bug in print function: two fields were interchanged.
Emden Gansner [Fri, 3 Mar 2017 14:58:29 +0000 (09:58 -0500)]
Fix bug in print function: two fields were interchanged.

7 years agoFix rtest.sh to use test data based on system running the tests;
Emden Gansner [Wed, 1 Mar 2017 19:54:27 +0000 (14:54 -0500)]
Fix rtest.sh to use test data based on system running the tests;
add test data for Ubuntu;
remove absolute paths containing dperry-make relative to the rtest directory.

7 years agoRemove antique test directories
Emden Gansner [Wed, 1 Mar 2017 19:26:32 +0000 (14:26 -0500)]
Remove antique test directories

7 years agosometimes 'dot -c' isn't getting run
John Ellson [Fri, 17 Feb 2017 14:17:52 +0000 (09:17 -0500)]
sometimes 'dot -c' isn't getting run

7 years agosometimes 'dot -c' isn't getting run
John Ellson [Fri, 17 Feb 2017 14:09:12 +0000 (09:09 -0500)]
sometimes 'dot -c' isn't getting run

7 years agoMerge branch 'master' of https://github.com/ellson/graphviz
Emden Gansner [Wed, 15 Feb 2017 17:39:30 +0000 (12:39 -0500)]
Merge branch 'master' of https://github.com/ellson/graphviz

7 years agoAdd documentation on the newrank attribute.
Emden Gansner [Wed, 15 Feb 2017 17:39:02 +0000 (12:39 -0500)]
Add documentation on the newrank attribute.

7 years agoMerge pull request #1208 from ErwinJanssen/update-test-reference
John Ellson [Sun, 12 Feb 2017 21:33:37 +0000 (16:33 -0500)]
Merge pull request #1208 from ErwinJanssen/update-test-reference

Update test reference files after indent change

7 years agoUpdate test reference files after indent change
Erwin Janssen [Sat, 11 Feb 2017 10:33:37 +0000 (11:33 +0100)]
Update test reference files after indent change

The recent change in the indentation of the dot output, caused tests
regarding gv and xdot output to fail. A minor difference in indentation
was the cause (a single space), but the indentation is now better aligned.
We update the rest reference files to reflect this update.

7 years agoFix issue #1207 - if an edge key is written as part of printing all attributes, it...
Emden Gansner [Fri, 10 Feb 2017 20:13:17 +0000 (15:13 -0500)]
Fix issue #1207 - if an edge key is written as part of printing all attributes, it must increase the tab level.

7 years agoMerge branch 'master' of https://github.com/ellson/graphviz
Emden R. Gansner [Sun, 29 Jan 2017 23:53:04 +0000 (18:53 -0500)]
Merge branch 'master' of https://github.com/ellson/graphviz

7 years agoUpdate documentation to handle included json
Emden R. Gansner [Sun, 29 Jan 2017 23:50:34 +0000 (18:50 -0500)]
Update documentation to handle included json

7 years agoMerge pull request #1201 from ErwinJanssen/cmake
John Ellson [Sat, 28 Jan 2017 21:56:29 +0000 (16:56 -0500)]
Merge pull request #1201 from ErwinJanssen/cmake

Beginning of CMake build

7 years agoMerge pull request #1200 from ErwinJanssen/add-awk-to-windows
John Ellson [Sat, 28 Jan 2017 21:53:40 +0000 (16:53 -0500)]
Merge pull request #1200 from ErwinJanssen/add-awk-to-windows

Add awk to Windows

7 years agoDifferent section seperation in main CMakeLists
Erwin Janssen [Fri, 27 Jan 2017 13:08:02 +0000 (14:08 +0100)]
Different section seperation in main CMakeLists

With this new header, the section seperation is more clear.

7 years agoUse awk to generate ps.h on Windows
Erwin Janssen [Fri, 27 Jan 2017 00:49:58 +0000 (01:49 +0100)]
Use awk to generate ps.h on Windows

Instead of using the pregenerated ps.h in windows/include, we use awk to
generate this file instead.

7 years agoUse awk to generate colortbl.h on Windows
Erwin Janssen [Thu, 26 Jan 2017 12:56:15 +0000 (13:56 +0100)]
Use awk to generate colortbl.h on Windows

Instead of using the pregenerated colortbl.h in windows/include, we now
include awk in windows/dependencies/graphviz-build-utilities and use this
to generate colortbl.h

7 years agoAdded missing headers to windows libraries
Erwin Janssen [Thu, 26 Jan 2017 12:55:00 +0000 (13:55 +0100)]
Added missing headers to windows libraries

Two headers were missing from, and now added to
windows/dependencies/libraries: gd_io.h and gdfx.h

7 years agoAdd lib/neatogen to CMake build
Erwin Janssen [Tue, 24 Jan 2017 14:36:07 +0000 (15:36 +0100)]
Add lib/neatogen to CMake build

The static library 'neatogen' has no dependencies, but the `with_digcola`
option had to be added, for this is also done in the Autotools build.

7 years agoDecapitalize CMake option variables
Erwin Janssen [Tue, 24 Jan 2017 11:25:22 +0000 (12:25 +0100)]
Decapitalize CMake option variables

The options that can be passed to configure the CMake build, are now in
lower case, similar to the Autotools build.

7 years agoAdd lib/sfdpgen to CMake build
Erwin Janssen [Fri, 20 Jan 2017 18:02:04 +0000 (19:02 +0100)]
Add lib/sfdpgen to CMake build

The static library 'sfdpgen' has no dependencies, but the `WITH_SFDP`
option had to be added, for this is also done in the Autotools build.
If WITH_SFDP is set, the define SFDP is also added (also added this for
ORTHO, this was missing).

7 years agoAdd lib/vpsc to CMake build
Erwin Janssen [Fri, 20 Jan 2017 16:55:41 +0000 (17:55 +0100)]
Add lib/vpsc to CMake build

The static library 'vpsc' has no dependencies, but the `WITH_IPSEPCOLA`
option had to be added, for this is also done in the Autotools build. This
library is disabled by default due to C++ portability issues.

7 years agoAdd lib/ortho to CMake build
Erwin Janssen [Fri, 20 Jan 2017 16:38:47 +0000 (17:38 +0100)]
Add lib/ortho to CMake build

The static library 'ortho' has no dependencies, but the `WITH_ORTHO`
option had to be added, for this is also done in the Autotools build.

7 years agoAdd lib/rbtree to CMake build
Erwin Janssen [Mon, 9 Jan 2017 22:06:34 +0000 (23:06 +0100)]
Add lib/rbtree to CMake build

The static library 'rbtree' has no dependencies and required no
additional checks.

7 years agoAdd lib/osage to CMake build
Erwin Janssen [Sun, 8 Jan 2017 11:03:41 +0000 (12:03 +0100)]
Add lib/osage to CMake build

The static library 'osage' has no dependencies and required no
additional checks.

7 years agoAdd lib/sparse to CMake build
Erwin Janssen [Sat, 7 Jan 2017 22:31:30 +0000 (23:31 +0100)]
Add lib/sparse to CMake build

The static library 'sparse' has no dependencies and required no
additional checks.

7 years agoAdd lib/spine to CMake build
Erwin Janssen [Sat, 7 Jan 2017 22:31:05 +0000 (23:31 +0100)]
Add lib/spine to CMake build

The static library 'spine' has no dependencies and required no
additional checks.

7 years agoAdd lib/ingraphs to CMake build
Erwin Janssen [Sat, 7 Jan 2017 21:41:27 +0000 (22:41 +0100)]
Add lib/ingraphs to CMake build

The static library 'ingraphs' has no dependencies and required no
additional checks.

7 years agoAdd lib/pack to CMake build
Erwin Janssen [Fri, 6 Jan 2017 14:55:55 +0000 (15:55 +0100)]
Add lib/pack to CMake build

The static library pack has no dependencies and required no
additional checks.

7 years agoAdd lib/xdot to CMake build
Erwin Janssen [Fri, 6 Jan 2017 14:38:16 +0000 (15:38 +0100)]
Add lib/xdot to CMake build

The dynamic library xdot has no dependencies and required no
additional checks.

7 years agoAdd lib/vmalloc to CMake build
Erwin Janssen [Thu, 5 Jan 2017 18:10:31 +0000 (19:10 +0100)]
Add lib/vmalloc to CMake build

The static library vmalloc has no dependencies. Various additional
header, function and type checks have been added.

7 years agoAdd lib/label to CMake build
Erwin Janssen [Thu, 5 Jan 2017 09:36:10 +0000 (10:36 +0100)]
Add lib/label to CMake build

The static library label has no dependencies and required no
additional checks.

7 years agoAdd lib/fdpgen to CMake build
Erwin Janssen [Thu, 5 Jan 2017 09:20:19 +0000 (10:20 +0100)]
Add lib/fdpgen to CMake build

The static library fdpgen has no dependencies. Two additional function
checks have been added: drand48 and srand48.

7 years agoReplace "." with "${CMAKE_CURRENT_SOURCE_DIR}"
Erwin Janssen [Thu, 5 Jan 2017 09:07:48 +0000 (10:07 +0100)]
Replace "." with "${CMAKE_CURRENT_SOURCE_DIR}"

When specifying the current source directory as an include directory, both
"." and "${CMAKE_CURRENT_SOURCE_DIR}" mean the same, but the latter is
more descriptive.

7 years agoAdd lib/dotgen to CMake build
Erwin Janssen [Wed, 4 Jan 2017 23:07:10 +0000 (00:07 +0100)]
Add lib/dotgen to CMake build

The static library dotgen has no dependencies and required no
additional checks.

7 years agoAdd Graphviz version define to config-cmake.h.in
Erwin Janssen [Wed, 4 Jan 2017 22:57:32 +0000 (23:57 +0100)]
Add Graphviz version define to config-cmake.h.in

This adds the `PACKAGE_VERSION` define, which is used in various parts to
print the version number.

7 years agoAdd lib/circogen to CMake build
Erwin Janssen [Tue, 3 Jan 2017 23:49:15 +0000 (00:49 +0100)]
Add lib/circogen to CMake build

The static library circogen has no dependencies and required no
additional checks.

7 years agoAdd lib/twopigen to CMake build
Erwin Janssen [Tue, 3 Jan 2017 22:08:18 +0000 (23:08 +0100)]
Add lib/twopigen to CMake build

The static library twopigen has no dependencies and required no
additional checks.

7 years agoAdd lib/patchwork to CMake build
Erwin Janssen [Tue, 3 Jan 2017 21:41:18 +0000 (22:41 +0100)]
Add lib/patchwork to CMake build

The static library patchwork has no dependencies and required no
additional checks.

7 years agoAdd lib/pathplan to the CMake build
Erwin Janssen [Tue, 3 Jan 2017 17:01:50 +0000 (18:01 +0100)]
Add lib/pathplan to the CMake build

Only a one additional checks were required for pathplan: cbrt function

7 years agoModify files generated by Bison and Flex, to match the Autotools build.
Erwin Janssen [Tue, 3 Jan 2017 12:35:12 +0000 (13:35 +0100)]
Modify files generated by Bison and Flex, to match the Autotools build.

- Replace "yy" with "aag" in all three files
- Replace "unsigned long int" with "uint64_t" in grammar.h and grammar.c
- Replace "unsigned long" with "uint64_t" in grammar.h and grammar.c
- Remove declaration of the "isatty()" function from scan.c

7 years agoRestructure root CMakeLists.txt
Erwin Janssen [Tue, 3 Jan 2017 09:31:43 +0000 (10:31 +0100)]
Restructure root CMakeLists.txt

Improve clairity of the file. Also bumps the version number to 2.41.

7 years agoAdd lib/cgraph to the CMake build
Erwin Janssen [Sun, 1 Jan 2017 16:12:21 +0000 (17:12 +0100)]
Add lib/cgraph to the CMake build

Before lib/cgraph can be build, a few checks have to be done for available
headers and functions. This is done in the main CMakeLists.txt.
The generate the required files with BISON and FLEX, the build-in CMake
modules for BISON and FLEX can be used.

7 years agoAdd (so)version specification to cdt CMake build
Erwin Janssen [Sat, 31 Dec 2016 12:55:00 +0000 (13:55 +0100)]
Add (so)version specification to cdt CMake build

The `set_target_properties` function can be used to set the version and
soversion properties. The versions are set to the current Autotools
version numbers.

7 years agoAdd 'uninstall' target to CMake build
Erwin Janssen [Sat, 31 Dec 2016 12:05:14 +0000 (13:05 +0100)]
Add 'uninstall' target to CMake build

When CMake performs the 'install' step, it keeps track of the installed
files by listing them in the `install_manifest.txt` file. The 'uninstall'
step reverses the installation by removing the files listed in the
manifest. This solution is taken directly from the CMake FAQ:
https://cmake.org/Wiki/CMake_FAQ#Can_I_do_.22make_uninstall.22_with_CMake.3://cmake.org/Wiki/CMake_FAQ#Can_I_do_.22make_uninstall.22_with_CMake.3F

7 years agoAdd install target and initial packaging to CMake
Erwin Janssen [Thu, 29 Dec 2016 11:41:06 +0000 (12:41 +0100)]
Add install target and initial packaging to CMake

The installation locations are identical to the Autotools install step,
but the pdf version of the manpages aren't generated yet.
With CPack, packages can be generated based on the `install` commands. For
now only the basic ZIP package generator is added.
Added the new CMake commands to the Travis and Appveyor scripts.

7 years agoCMake: add BISON and FLEX as build dependencies
Erwin Janssen [Wed, 28 Dec 2016 15:06:50 +0000 (16:06 +0100)]
CMake: add BISON and FLEX as build dependencies

BISON and FLEX are required to build some of the core parts of Graphviz.

7 years agoCMake: Add Graphviz version information
Erwin Janssen [Tue, 20 Dec 2016 19:38:45 +0000 (20:38 +0100)]
CMake: Add Graphviz version information

Adds version numbers to the main CMakeLists.txt. The build version is set
to the date and time of the most recent commit, similar to the Autotools
build.

7 years agoAdd CMake build to Travis
Erwin Janssen [Tue, 27 Sep 2016 16:45:29 +0000 (18:45 +0200)]
Add CMake build to Travis

- Add CMake installation to Centos 7 dockerfile
- New build script for CMake
- Add `BUILD_SYSTEM` variable to Travis: perform Autotools and CMake build, both on native Travis and Docker.

7 years agoAdd the CMake build to Appveyor CI
Erwin Janssen [Tue, 27 Sep 2016 15:46:27 +0000 (17:46 +0200)]
Add the CMake build to Appveyor CI

Renamed the `compiler` in appveyor.yml variable to `build_system`.
The CMake build will run for both configurations: Debug and Release.

7 years agoInitial minimal CMake project
Erwin Janssen [Mon, 19 Dec 2016 15:03:57 +0000 (16:03 +0100)]
Initial minimal CMake project

A CMake project consists of CMakeLists.txt files. The primary file in the
root of the project specifies global project information and
configuration. CMakeLists.txt files in subdirectories can contain
configuration for how to build to binaries.

This configuration minimal configuration only builds lib/cdt as a shared
(dynamic) library. CMake supports out of source builds, which is the
recommended way of building:

mkdir build
cd build
cmake ..
cmake --build .

The `cmake ..` generates the build files. On Unix based systems, it
gerenates makefiles, on Windows it generates Visual Studio projects. The
used generated can be specified with -G.

7 years agoMerge pull request #1197 from ErwinJanssen/various-changes
John Ellson [Thu, 19 Jan 2017 05:08:35 +0000 (00:08 -0500)]
Merge pull request #1197 from ErwinJanssen/various-changes

Various changes

7 years agoUse prebuild libgd from windows deps submodule
Erwin Janssen [Tue, 17 Jan 2017 16:41:06 +0000 (17:41 +0100)]
Use prebuild libgd from windows deps submodule

Instead of building libgd manually before Graphviz can be build, we
included a prebuild version of libgd in the graphviz windows dependencies
submodule. The doc/winbuild.html is updated to reflect this.

7 years agoMerge Windows dependencies into one submodule
Erwin Janssen [Mon, 16 Jan 2017 12:50:05 +0000 (13:50 +0100)]
Merge Windows dependencies into one submodule

Instead of using a submodule for every Windows dependency with a lot of
extra files, we now use a single submodule that only contains those files
that are required. This means fewer submodules and shorter download time
(because of the reduction in size and number of files).
Also removed some unused links in Smyrna.

7 years agoUpdate Freetype download link in appveyor.yml
Erwin Janssen [Wed, 11 Jan 2017 16:17:31 +0000 (17:17 +0100)]
Update Freetype download link in appveyor.yml

7 years agoReplace checks for `WIN32` with `_WIN32`
Erwin Janssen [Wed, 11 Jan 2017 13:59:11 +0000 (14:59 +0100)]
Replace checks for `WIN32` with `_WIN32`

The preprocesser macro `WIN32` is defined by the user, while `_WIN32` is
defined by the compiler. To improve consistantcy, and prevent errors
caused by forgetting to define `WIN32` somewhere, it is better to use
`_WIN32` to check for Windows.

7 years agoRemove checks standard C funcs from features/sfio
Erwin Janssen [Mon, 9 Jan 2017 19:01:50 +0000 (20:01 +0100)]
Remove checks standard C funcs from features/sfio

Some functions are part of the C standard, so the checks in
features/sfio are not required and can be removed.

7 years agoMove headers checks features/sfio to configure.ac
Erwin Janssen [Mon, 9 Jan 2017 18:50:33 +0000 (19:50 +0100)]
Move headers checks features/sfio to configure.ac

Some headers required new checks, for some headers, checks were already
present in configure.ac

7 years agoRemove mmap code from sfio
Erwin Janssen [Mon, 9 Jan 2017 17:54:44 +0000 (18:54 +0100)]
Remove mmap code from sfio

There are multiple reasons to remove this code:
- The define that guards all the mmap code (_mmap_worthy) is rarely set.
  When building local or on Travis, the define isn't set.
  On Windows, it is never set.
- If a 'binary compatibility package' of sfio is build (when _SFBINARY_H
  is defined), `_sys_mann` is `undef`ed, excluding mmap code from the build.

Instead of keeping the code that is rarely included, we can reduce code
complexity by removing it.

7 years agoAssume default memchr and memcpy are fast enough
Erwin Janssen [Mon, 9 Jan 2017 12:11:52 +0000 (13:11 +0100)]
Assume default memchr and memcpy are fast enough

`features/sfio` contains some test that check if the default memchr and
memcpy are "fast enough". These days we can safely assume that this is the
case, also because this define is always enabled when running the tests.

7 years agoRemove checks bcopy and bzero from features/sfio
Erwin Janssen [Mon, 9 Jan 2017 11:50:49 +0000 (12:50 +0100)]
Remove checks bcopy and bzero from features/sfio

The code contains several checks regarding these functions, but they are
never actually used in lib/sfio. It is therefore not needed to test their
availability.

7 years agoRemove disabled vt_threaded code from lib/sfio
Erwin Janssen [Mon, 9 Jan 2017 12:56:29 +0000 (13:56 +0100)]
Remove disabled vt_threaded code from lib/sfio

The threaded part of sfio and vthread is disabled for Graphviz by setting
various defines. This commit removes the disabled code entirely, to make
it more clear which code is actually part of the compilation.

7 years agoRemove checks memset and memcpy from features/sfio
Erwin Janssen [Mon, 9 Jan 2017 11:43:57 +0000 (12:43 +0100)]
Remove checks memset and memcpy from features/sfio

Both are functions are part of the C standard and therefore always
present. Checking is therefore not needed.

7 years agoRemove three unused checks from features/sfio
Erwin Janssen [Mon, 9 Jan 2017 00:10:34 +0000 (01:10 +0100)]
Remove three unused checks from features/sfio

The result of the following checks is never used, so they can be removed:
- qfrexp
- qldexp
- memalign

7 years agoRemove usage of _ast_int and _ast_flt defines
Erwin Janssen [Sun, 8 Jan 2017 23:45:02 +0000 (00:45 +0100)]
Remove usage of _ast_int and _ast_flt defines

The definition of these defines was removed in a previous commit
(2ee0993a22db6faa8506ac1c69164a5120dbd76c) but the usage was still
present. This is corrected by removing the usage as well.

7 years agoRemove definition and usage of _hdr_math in sfio
Erwin Janssen [Sun, 8 Jan 2017 23:27:02 +0000 (00:27 +0100)]
Remove definition and usage of _hdr_math in sfio

The header <math.h> is not required to build lib/sfio, so the check and
the usage can be removed.

7 years agoFix incorrect assignment in gvCloneGVC function
Erwin Janssen [Sat, 7 Jan 2017 18:19:40 +0000 (19:19 +0100)]
Fix incorrect assignment in gvCloneGVC function

The function `gvCloneGVC` creates a new `GVC_t` object and copies the values
from gvc0 to gvc. In the last assignment, gvc->packages is given the value
of itself: gvc->pckages. This should be gvc0 instead.

7 years agoFixed use of unitialized variable in lefty
Erwin Janssen [Sat, 7 Jan 2017 11:51:01 +0000 (12:51 +0100)]
Fixed use of unitialized variable in lefty

In the file cmd/lefty/ws/x11/gquery.c, function Gqwpopaction:
THe char c is declared without initializer, giving it a unpredictable
value. If the next if statement takes the false branch, the function where
c is set is not executed. The next if statement then checks `c != 13`, but
because C could have any value, the behavior is unpredictable.
Initializing c with a known value, such as 0, fixes the problem.

7 years agoReplace Windows' pragma linking with VS linking
Erwin Janssen [Fri, 6 Jan 2017 14:06:42 +0000 (15:06 +0100)]
Replace Windows' pragma linking with VS linking

In various places, mostly the projects in `cmd` and `plugin`, had a
`#pragma comment( lib, "libname.lib" )` in the source code for linking
under Windows. Were possible, these have been removed and replaced link
specifications in the Visual Studio project files.
This seperates the linking from the source code and makes transitioning to
other build systems easier.

7 years agoMade vmalloc a static library on Windows
Erwin Janssen [Thu, 5 Jan 2017 23:59:09 +0000 (00:59 +0100)]
Made vmalloc a static library on Windows

vmalloc is a static library with the Autotools build, but was for some
reason a dynamic library on Windows. Since Autotools is considered the
default, this commit makes vmalloc a static library on Windows as well.
To disable the function export that is required for a dynamic library,
but not for a static one, various define checks were removed.

7 years agoFix github issue #919; general cleanup.
Emden Gansner [Thu, 12 Jan 2017 21:29:42 +0000 (16:29 -0500)]
Fix github issue #919; general cleanup.

7 years agoMerge pull request #1195 from ErwinJanssen/various-changes
John Ellson [Thu, 5 Jan 2017 16:53:36 +0000 (11:53 -0500)]
Merge pull request #1195 from ErwinJanssen/various-changes

Various changes

7 years agoRemove usage of features/vmalloc
Erwin Janssen [Thu, 5 Jan 2017 14:00:38 +0000 (15:00 +0100)]
Remove usage of features/vmalloc

The only check left in features/vmalloc, checks if the return type of
malloc is the old `char *`. Because we are using standard C, we can
always assume the returntype of malloc is `void *`, this define is
there never set. We can remove this check and with it the usage of
features/vmalloc and FEATURE/vmalloc.

7 years agoMove checks from features/vmalloc to configure.ac
Erwin Janssen [Thu, 5 Jan 2017 13:34:50 +0000 (14:34 +0100)]
Move checks from features/vmalloc to configure.ac

Instead of checking certain headers and functions in a seperate config
script, place these checks in configure.ac and use HAVE_* style defines.
Some checks were already present in configure.ac, the others have been
added. No addtional defines in windows/config.h were needed.
There is only one check remaining in features/vmalloc.

7 years agoRemove unused checks from features/vmalloc
Erwin Janssen [Thu, 5 Jan 2017 11:16:24 +0000 (12:16 +0100)]
Remove unused checks from features/vmalloc

These checks set defines if they succeed, but these defines are never used.
The checks can therefore be removed.

7 years agoRemove declaration enqueue_neighbors from render.h
Erwin Janssen [Wed, 4 Jan 2017 23:20:03 +0000 (00:20 +0100)]
Remove declaration enqueue_neighbors from render.h

The function `enqueue_neighbors` is declared in both render.h and in
dotprocs.h, while it is only used in lib/dotgen. The double declaration
causes "inconstant dll linkage" warnings on Windows.

7 years agoMade xdot a dynamic library on Windows
Erwin Janssen [Tue, 3 Jan 2017 18:20:58 +0000 (19:20 +0100)]
Made xdot a dynamic library on Windows

xdot is a dynamic library with the Autotools build, but was for some
reason a static library on Windows. Since Autotools is considered the
default, this commit makes xdot a dynamic library on Windows as well.
The added define "XDOT_API", is used for linking, so a seperate xdot.def
file is not needed. On non-Windows platforms, this define is set to
"extern", so nothing changes there.

7 years agoDisable warning 4706 in Windows build of lib/cdt
Erwin Janssen [Thu, 29 Dec 2016 15:58:37 +0000 (16:58 +0100)]
Disable warning 4706 in Windows build of lib/cdt

Warning C4706: assignment within conditional expression
The CDT library is mostly an external library included with the Graphviz
source and modified. It throws a lot of C4706 warnings, which isn't the
warning with the highest priority. We disable it for now.

7 years agoRemove cdt/dttreeset.c, not present in newest CDT
Erwin Janssen [Sun, 18 Dec 2016 14:31:15 +0000 (15:31 +0100)]
Remove cdt/dttreeset.c, not present in newest CDT

The code file dttreeset.c is not present in the most recent version of
CDT, it also isn't used by Graphviz, so it can be removed.

7 years agoRemove checks for 'libgen', library not used
Erwin Janssen [Wed, 28 Dec 2016 20:22:27 +0000 (21:22 +0100)]
Remove checks for 'libgen', library not used

configure.ac contains checks for the `libgen` library and header, but the
header is never included, which means the library is never used. Checking
and linking is therefore not needed.

7 years agoUse <limits.h> in favor of <values.h>
Erwin Janssen [Wed, 28 Dec 2016 19:42:43 +0000 (20:42 +0100)]
Use <limits.h> in favor of <values.h>

The header <values.h> is obsolete in favor of <limits.h>, which is part of
the standard C library.

7 years agoRemove definition and usage of HAVE_STRERROR
Erwin Janssen [Wed, 28 Dec 2016 18:19:02 +0000 (19:19 +0100)]
Remove definition and usage of HAVE_STRERROR

This function is part of the standard C library, checking is therefore not
needed. With this change, check that sets HAVE_ERRNO_DECLS and the file
lib/ast/strerror.c can both be removed.

7 years agoRemove usage and definition of HAVE_ERRNO_H
Erwin Janssen [Wed, 28 Dec 2016 17:21:50 +0000 (18:21 +0100)]
Remove usage and definition of HAVE_ERRNO_H

The header "errno.h" is part of the standard C library, checking is
therefore not needed.

7 years agoMerge pull request #1194 from Chiel92/expose_ageqedge
John Ellson [Wed, 4 Jan 2017 04:38:52 +0000 (23:38 -0500)]
Merge pull request #1194 from Chiel92/expose_ageqedge

Expose ageqedge in cgraph.dll.

7 years agoMerge pull request #1193 from Chiel92/update-winbuild
John Ellson [Wed, 4 Jan 2017 04:38:37 +0000 (23:38 -0500)]
Merge pull request #1193 from Chiel92/update-winbuild

Add newer build instructions to winbuild.html.

7 years agoMerge pull request #1192 from Chiel92/master
John Ellson [Wed, 4 Jan 2017 04:38:15 +0000 (23:38 -0500)]
Merge pull request #1192 from Chiel92/master

Fix a few windows issues

7 years agoGive AgraphVersion a meaningful value.
Emden Gansner [Tue, 3 Jan 2017 18:45:42 +0000 (13:45 -0500)]
Give AgraphVersion a meaningful value.

7 years agoFixed typo that broke wildcard feature in agedgeidcmpf()
Stephen C North [Tue, 3 Jan 2017 17:55:00 +0000 (12:55 -0500)]
Fixed typo that broke wildcard feature in agedgeidcmpf()