]> granicus.if.org Git - transmission/log
transmission
7 years agoMerge pull request #387 from DevilDimon/noGrowl
Mike Gelfand [Tue, 28 Nov 2017 21:59:04 +0000 (00:59 +0300)]
Merge pull request #387 from DevilDimon/noGrowl

Remove Growl support

7 years agoRemove Growl support
Dmitry Serov [Sat, 26 Aug 2017 12:55:45 +0000 (19:55 +0700)]
Remove Growl support

7 years agoMerge pull request #364 from futekov/patch-2
Mike Gelfand [Tue, 28 Nov 2017 19:48:10 +0000 (22:48 +0300)]
Merge pull request #364 from futekov/patch-2

Download/upload speed typography changes for web ui

7 years agoMerge pull request #411 from dubhater/master
Mike Gelfand [Tue, 28 Nov 2017 19:45:48 +0000 (22:45 +0300)]
Merge pull request #411 from dubhater/master

Qt: Show file names in tooltips in Torrent Properties

7 years agoMerge pull request #429 from Fish2/master
Mike Gelfand [Tue, 28 Nov 2017 19:43:45 +0000 (22:43 +0300)]
Merge pull request #429 from Fish2/master

lossless compression of images

7 years agoRefactor completion scripts execution
Mike Gelfand [Mon, 27 Nov 2017 22:22:44 +0000 (01:22 +0300)]
Refactor completion scripts execution

There're still a few issues here and there, but overall I believe it's now
better than it was before.

7 years agoEnsure include guard is the first non-comment line
Mike Gelfand [Tue, 14 Nov 2017 20:21:28 +0000 (23:21 +0300)]
Ensure include guard is the first non-comment line

7 years agolossless compression of images
Fish2 [Sat, 4 Nov 2017 00:26:40 +0000 (00:26 +0000)]
lossless compression of images

7 years agoMerge pull request #394 from Allezxandre/fix/no-visible-interface
Mike Gelfand [Wed, 1 Nov 2017 06:38:20 +0000 (09:38 +0300)]
Merge pull request #394 from Allezxandre/fix/no-visible-interface

Fix `No @interface declares "containsIndex:"`

7 years agoFix potential NULL pointer dereference introduced by last commit
Mike Gelfand [Tue, 31 Oct 2017 07:01:06 +0000 (10:01 +0300)]
Fix potential NULL pointer dereference introduced by last commit

7 years agoTake another approach to creating intermediate dirs on *NIX
Mike Gelfand [Fri, 27 Oct 2017 13:12:55 +0000 (16:12 +0300)]
Take another approach to creating intermediate dirs on *NIX

Walk up one level at a time until the directory creation succeeds, then go
back down one level at a time. This reduces the number of operations in the
most common case (when directory already exists).

7 years agoShow file names in tooltips in Torrent Properties
cantabile [Sat, 30 Sep 2017 17:26:49 +0000 (20:26 +0300)]
Show file names in tooltips in Torrent Properties

File names are often too long to fit. Hovering is much easier than
resizing the column and possibly the window.

7 years agoFix `No @interface declares "containsIndex:"`
Alexandre Jouandin [Wed, 30 Aug 2017 22:21:08 +0000 (01:21 +0300)]
Fix `No @interface declares "containsIndex:"`

This fixes the `No visible @interface for NSArray declares the selector "containsIndex:"` error that prevented Xcode (9b6) from compiling.

7 years agoMerge pull request #386 from kholia/Netdisk
Mike Gelfand [Sun, 27 Aug 2017 07:22:30 +0000 (10:22 +0300)]
Merge pull request #386 from kholia/Netdisk

Add Peer ID for Baidu Netdisk

7 years agoFix torrent list styling issue in Chrome 59+ (patch by @kyleinprogress)
Mike Gelfand [Sun, 27 Aug 2017 06:50:24 +0000 (09:50 +0300)]
Fix torrent list styling issue in Chrome 59+ (patch by @kyleinprogress)

Fixes: #384
7 years agoAdd Peer ID for Baidu Netdisk
Dhiru Kholia [Sat, 26 Aug 2017 05:39:31 +0000 (11:09 +0530)]
Add Peer ID for Baidu Netdisk

Baidu Netdisk uses Azureus-style Peer ID with "-BN" prefix.

7 years agoMerge pull request #371 from bobbyhopere/anti-brute
Mike Gelfand [Wed, 23 Aug 2017 19:51:03 +0000 (22:51 +0300)]
Merge pull request #371 from bobbyhopere/anti-brute

anti-brute force for RPC Server

7 years agoMerge pull request #353 from DevilDimon/master
Mike Gelfand [Wed, 23 Aug 2017 19:47:35 +0000 (22:47 +0300)]
Merge pull request #353 from DevilDimon/master

Transition to ARC

7 years agoUse NSInvocation to make Growl compile under ARC
Dmitry Serov [Fri, 18 Aug 2017 11:47:55 +0000 (18:47 +0700)]
Use NSInvocation to make Growl compile under ARC

7 years agoAll modifications suggested by mikedld
bobbyhopere [Sun, 13 Aug 2017 11:53:41 +0000 (13:53 +0200)]
All modifications suggested by mikedld

7 years agoanti-brute force for RPC Server
bobbyhopere [Sat, 12 Aug 2017 14:36:43 +0000 (16:36 +0200)]
anti-brute force for RPC Server

7 years agoMerge pull request #367 from clyang/master
Mike Gelfand [Fri, 11 Aug 2017 07:50:03 +0000 (10:50 +0300)]
Merge pull request #367 from clyang/master

Disable autocomplete on torrent url field from WebUI

7 years agoDisable browser to autocomplete on torrent url field
clyang [Thu, 10 Aug 2017 16:52:40 +0000 (00:52 +0800)]
Disable browser to autocomplete on torrent url field

It disrupts the view and I can't come up a daily usage scenario that needs to utilize autocomplete function.

7 years agoMerge pull request #360 from clyang/master
Mike Gelfand [Tue, 8 Aug 2017 15:32:44 +0000 (18:32 +0300)]
Merge pull request #360 from clyang/master

Improving ToS on IPv6 connections

7 years agoDL/UL speed typography changes for web ui
Alexander Futekov [Mon, 7 Aug 2017 03:34:00 +0000 (06:34 +0300)]
DL/UL speed typography changes for web ui

The current icons are very hard to read at the current font size and it's not immediately visible which icon i which.

Additionally, spaces after icons are removed because upload icon is equally positioned between DL/UL speeds (like so `↓ 273 kB/s **↑** 0 kB/s`) which requires reading the whole line to make sense of which number the arrow applies to.

To further separate one type of information from another the hyphen is replaced by the slightly wider en dash.

Old vs New:
Downloading from 7 of 19 peers - ↓ 273 kB/s ↑ 167 kB/s
Downloading from 7 of 19 peers – ▼273 kB/s ▲167 kB/s

7 years agoMerge pull request #363 from kholia/Folx
Mike Gelfand [Sun, 6 Aug 2017 22:33:47 +0000 (01:33 +0300)]
Merge pull request #363 from kholia/Folx

Add Peer ID for Folx

7 years agoMerge remote-tracking branch 'origin/master'
Dmitry Serov [Sat, 5 Aug 2017 11:42:15 +0000 (18:42 +0700)]
Merge remote-tracking branch 'origin/master'

7 years agoEnforce VDKQueue destruction before closing transmission session
Dmitry Serov [Sat, 5 Aug 2017 11:41:36 +0000 (18:41 +0700)]
Enforce VDKQueue destruction before closing transmission session

7 years agoAdd Peer ID for Folx
Dhiru Kholia [Sat, 5 Aug 2017 06:57:14 +0000 (12:27 +0530)]
Add Peer ID for Folx

Based on experiments with Folx version 5.2.1.13690 running on macOS
Sierra.

Folx uses Azureus-style Peer ID with "-FL" prefix.

7 years agoImprove ToS on IPv6 connections
clyang [Wed, 2 Aug 2017 10:01:39 +0000 (18:01 +0800)]
Improve ToS on IPv6 connections

7 years agoMerge pull request #355 from kholia/FDM
Mike Gelfand [Wed, 2 Aug 2017 20:10:28 +0000 (23:10 +0300)]
Merge pull request #355 from kholia/FDM

Add Peer ID for Free Download Manager (FDM)

7 years agoAdd Peer ID for Free Download Manager (FDM)
Dhiru Kholia [Tue, 1 Aug 2017 08:43:33 +0000 (14:13 +0530)]
Add Peer ID for Free Download Manager (FDM)

Based on experiments with FDM 5.1.32 running on Windows 10.

FDM uses Azureus-style Peer ID with "-FD" prefix.

7 years agoEnable ARC when configuring the project via CMake
Mike Gelfand [Wed, 2 Aug 2017 04:12:31 +0000 (07:12 +0300)]
Enable ARC when configuring the project via CMake

7 years agoRemove leftover dealloc empty lines, nullify StatsWindowController instance on close
Dmitry Serov [Tue, 1 Aug 2017 10:57:27 +0000 (17:57 +0700)]
Remove leftover dealloc empty lines, nullify StatsWindowController instance on close

7 years agoCorrect __bridge_retained and __bridge_transfer casts using ARC
Dmitry Serov [Tue, 1 Aug 2017 10:40:39 +0000 (17:40 +0700)]
Correct __bridge_retained and __bridge_transfer casts using ARC

7 years agoTransition to ARC for QuickLook plugin
Dmitry Serov [Tue, 1 Aug 2017 10:26:49 +0000 (17:26 +0700)]
Transition to ARC for QuickLook plugin

7 years agoRemove ARC compiler flags for 3rd-party C libraries
Dmitry Serov [Mon, 31 Jul 2017 14:23:19 +0000 (21:23 +0700)]
Remove ARC compiler flags for 3rd-party C libraries

7 years agoDisable ARC for 3rd-party libraries
Dmitry Serov [Mon, 31 Jul 2017 14:15:11 +0000 (21:15 +0700)]
Disable ARC for 3rd-party libraries

7 years agoMerge pull request #351 from puyt/master
Mike Gelfand [Sun, 30 Jul 2017 12:55:48 +0000 (15:55 +0300)]
Merge pull request #351 from puyt/master

Add keyboard hotkeys for web interface

7 years agoRevert indentation from commit d94f44b
Sven Depondt [Sun, 30 Jul 2017 12:36:58 +0000 (14:36 +0200)]
Revert indentation from commit d94f44b

`switch` and `case` are on the same level everywhere else.

7 years agoRework hotkeys for focused input fields and open dialogs
Sven Depondt [Sun, 30 Jul 2017 11:54:13 +0000 (13:54 +0200)]
Rework hotkeys for focused input fields and open dialogs

Also added 2 hotkeys:
    1. `i` Toggle inspector
    2. `l` Set location

7 years agoEnable ARC in project settings
Dmitry Serov [Sat, 29 Jul 2017 16:42:30 +0000 (23:42 +0700)]
Enable ARC in project settings

7 years agoTransition to ARC
Dmitry Serov [Sat, 29 Jul 2017 16:14:22 +0000 (23:14 +0700)]
Transition to ARC

7 years agoUse id when handling hotkeys for specific dialogs
Sven Depondt [Fri, 28 Jul 2017 20:32:18 +0000 (22:32 +0200)]
Use id when handling hotkeys for specific dialogs

Identifying a dialog by it's header title is kinda dirty and now we use
the dialogs id instead. We also check if the dialog is visible before executing
the hotkey action.

7 years agoAdd keyboard hotkeys for web interface
Sven Depondt [Fri, 28 Jul 2017 16:56:50 +0000 (18:56 +0200)]
Add keyboard hotkeys for web interface

7 years agoBump miniupnpc version to 2.0.20170509 (take two)
Mike Gelfand [Thu, 27 Jul 2017 15:27:29 +0000 (18:27 +0300)]
Bump miniupnpc version to 2.0.20170509 (take two)

Fix Xcode project to reference changed list of miniupnpc files.
Disable building of upnpc-static executable.

Fixes: #347
7 years agoBump miniupnpc version to 2.0.20170509
Mike Gelfand [Thu, 27 Jul 2017 14:12:38 +0000 (17:12 +0300)]
Bump miniupnpc version to 2.0.20170509

Fixes: #347
7 years agoGo back to using hash as base name for resume and torrent files
Mike Gelfand [Wed, 26 Jul 2017 18:20:30 +0000 (21:20 +0300)]
Go back to using hash as base name for resume and torrent files

The format introduced in TRAC-394 is nice but brings its own issues (e.g.
TRAC-4189, #122). I'm okay with a bit of grepping myself if it makes the
experience better for end users.

Using hashes results in filenames well under 255 bytes limit on some
filesystems. If even that will not be enough, I'd suggest reporting the
issue elsewhere.

Fixes: #122
7 years agoMerge pull request #329 from DevilDimon/master
Mike Gelfand [Sat, 22 Jul 2017 20:36:05 +0000 (23:36 +0300)]
Merge pull request #329 from DevilDimon/master

Objective-C literals & subscripting

7 years agoDon't force debug configuration in qmake project
Mike Gelfand [Thu, 20 Jul 2017 22:39:55 +0000 (01:39 +0300)]
Don't force debug configuration in qmake project

7 years agoPatch up file test to allow for a bit of time discrepancy
Mike Gelfand [Thu, 20 Jul 2017 21:45:30 +0000 (00:45 +0300)]
Patch up file test to allow for a bit of time discrepancy

Since one cannot really compare system time to filesystem time (see e.g.
https://lkml.org/lkml/2017/3/30/809), allow for 1 second error to avoid
(or at least minimize) random test failures.

7 years agoMake version text in about dialog selectable/copyable (Qt client)
Mike Gelfand [Mon, 17 Jul 2017 20:38:19 +0000 (23:38 +0300)]
Make version text in about dialog selectable/copyable (Qt client)

Closes: #326
7 years agoManually released collections are not autoreleased anymore, pointer syntax adheres...
Dmitry Serov [Mon, 17 Jul 2017 17:34:52 +0000 (00:34 +0700)]
Manually released collections are not autoreleased anymore, pointer syntax adheres to codestyle

7 years agoMerge pull request #320 from gonstr/master
Mike Gelfand [Sun, 16 Jul 2017 18:01:09 +0000 (21:01 +0300)]
Merge pull request #320 from gonstr/master

(web) show upload torrent file button on mobile devices

7 years agoMerge pull request #334 from xzcvczx/ssl-noverify
Mike Gelfand [Sun, 16 Jul 2017 17:55:25 +0000 (20:55 +0300)]
Merge pull request #334 from xzcvczx/ssl-noverify

Change TR_CURL_SSL_VERIFY to TR_CURL_SSL_NO_VERIFY

7 years agoChange TR_CURL_SSL_VERIFY to TR_CURL_SSL_NO_VERIFY
Simon Wells [Sun, 16 Jul 2017 17:28:13 +0000 (05:28 +1200)]
Change TR_CURL_SSL_VERIFY to TR_CURL_SSL_NO_VERIFY

use secure by default and change the env var to match curl -k behaviour

Closes: #179
7 years agoRevert dd538539aa, fix RPC queue processing
Mike Gelfand [Sat, 15 Jul 2017 05:46:31 +0000 (08:46 +0300)]
Revert dd538539aa, fix RPC queue processing

Queue callback for items returning no new future was never called leaving
queue alive and leading to memory leak in Qt client.

7 years agoNSDictionary init literals
Dmitry Serov [Sat, 8 Jul 2017 15:02:00 +0000 (22:02 +0700)]
NSDictionary init literals

7 years agoNSDictionary subscripting
Dmitry Serov [Sat, 8 Jul 2017 14:38:47 +0000 (21:38 +0700)]
NSDictionary subscripting

7 years agoRename `tr_sys_file_prefetch` to `tr_sys_file_advise`
Mike Gelfand [Sat, 8 Jul 2017 13:09:37 +0000 (16:09 +0300)]
Rename `tr_sys_file_prefetch` to `tr_sys_file_advise`

New function now supports two flags: will need and don't need.

7 years agoChange `tr_sys_file_prefetch` behavior a bit
Mike Gelfand [Sat, 8 Jul 2017 09:51:36 +0000 (12:51 +0300)]
Change `tr_sys_file_prefetch` behavior a bit

Return true by default. Only return false if we did in fact perform some
action and it failed.

7 years agoNSArray subscripting
Dmitry Serov [Sat, 8 Jul 2017 09:16:01 +0000 (16:16 +0700)]
NSArray subscripting

7 years agoNSArray init literals
Dmitry Serov [Sat, 8 Jul 2017 08:23:05 +0000 (15:23 +0700)]
NSArray init literals

7 years agoNSString literals
Dmitry Serov [Sat, 8 Jul 2017 08:06:32 +0000 (15:06 +0700)]
NSString literals

7 years agoNSNumber literals
Dmitry Serov [Fri, 7 Jul 2017 10:34:27 +0000 (17:34 +0700)]
NSNumber literals

7 years agoChange torrent location even if no data move is needed
Mike Gelfand [Thu, 6 Jul 2017 18:46:32 +0000 (21:46 +0300)]
Change torrent location even if no data move is needed

This helps when old and new location point to the same place but the actual
path differs (i.e. one of the paths is a symlink).

Fixes: #35
7 years agoSet idle seed limit range to 1..40320 (4 weeks tops) in all clients
Mike Gelfand [Wed, 5 Jul 2017 18:07:16 +0000 (21:07 +0300)]
Set idle seed limit range to 1..40320 (4 weeks tops) in all clients

Fixes: #212
7 years agoUncaught exception when dragging multiple items between groups (macOS)
Mike Gelfand [Tue, 4 Jul 2017 19:59:55 +0000 (22:59 +0300)]
Uncaught exception when dragging multiple items between groups (macOS)

Change group after all the torrents are retrieved from drop data to avoid
premature view item index changes.

Fixes: #51
7 years agoDon't switch trackers while announcing
Mike Gelfand [Tue, 4 Jul 2017 18:22:26 +0000 (21:22 +0300)]
Don't switch trackers while announcing

Fixes: #297
7 years agoCorrect "annouce" spelling
Mike Gelfand [Sun, 2 Jul 2017 16:18:02 +0000 (19:18 +0300)]
Correct "annouce" spelling

Fixes: #303
7 years agoMove uTP timer to session struct
Mike Gelfand [Sun, 2 Jul 2017 10:31:33 +0000 (13:31 +0300)]
Move uTP timer to session struct

7 years agoFix a couple more implicit boolean expressions
Mike Gelfand [Sun, 2 Jul 2017 10:26:26 +0000 (13:26 +0300)]
Fix a couple more implicit boolean expressions

7 years agoRemoved freespace-info class from sass file
gonstr [Sat, 1 Jul 2017 17:44:38 +0000 (19:44 +0200)]
Removed freespace-info class from sass file

7 years agoUnhide upload file button
gonstr [Sat, 1 Jul 2017 17:26:34 +0000 (19:26 +0200)]
Unhide upload file button

7 years agoHandle IPv6 RPC addresses in transmission-remote
Mike Gelfand [Thu, 29 Jun 2017 06:59:47 +0000 (09:59 +0300)]
Handle IPv6 RPC addresses in transmission-remote

7 years agoIntroduce peer socket struct to improve readability
Mike Gelfand [Wed, 28 Jun 2017 15:46:06 +0000 (18:46 +0300)]
Introduce peer socket struct to improve readability

7 years agoRemove obsolete comment as we're using C99 now
Mike Gelfand [Wed, 28 Jun 2017 15:49:11 +0000 (18:49 +0300)]
Remove obsolete comment as we're using C99 now

7 years agoUse field initializers for readability
Mike Gelfand [Sat, 24 Jun 2017 10:17:04 +0000 (13:17 +0300)]
Use field initializers for readability

7 years agoMerge pull request #312 from realzhtw/master
Mike Gelfand [Mon, 19 Jun 2017 16:47:41 +0000 (19:47 +0300)]
Merge pull request #312 from realzhtw/master

Fixed platform-quota.c for DragonFly.

7 years agoFixed platform-quota.c for DragonFly. The patch is taken from dports.
Aleksej Lebedev [Mon, 19 Jun 2017 10:45:09 +0000 (12:45 +0200)]
Fixed platform-quota.c for DragonFly. The patch is taken from dports.

7 years agoMove generic macros to a separate tr-macros.h file
Mike Gelfand [Sun, 18 Jun 2017 12:34:21 +0000 (15:34 +0300)]
Move generic macros to a separate tr-macros.h file

7 years agoMerge pull request #304 from Fish2/master
Mike Gelfand [Tue, 13 Jun 2017 17:03:17 +0000 (20:03 +0300)]
Merge pull request #304 from Fish2/master

lossless compression of images saved 72KB

7 years agoBring assertions closer to the beginning of blocks
Mike Gelfand [Tue, 13 Jun 2017 02:24:09 +0000 (05:24 +0300)]
Bring assertions closer to the beginning of blocks

7 years agoAdd tr-assert.{h,c} to Xcode project
Mike Gelfand [Thu, 8 Jun 2017 17:52:05 +0000 (20:52 +0300)]
Add tr-assert.{h,c} to Xcode project

7 years agoIntroduce our own assertion macros with finer control
Mike Gelfand [Thu, 8 Jun 2017 07:24:12 +0000 (10:24 +0300)]
Introduce our own assertion macros with finer control

7 years agolossless compression of images saved 72KB
Fish2 [Sat, 3 Jun 2017 22:52:34 +0000 (23:52 +0100)]
lossless compression of images saved 72KB

7 years agoMake use of new checking capabilities in unit tests
Mike Gelfand [Tue, 30 May 2017 17:56:12 +0000 (20:56 +0300)]
Make use of new checking capabilities in unit tests

7 years agoAdd generic `check_mem` (libtest)
Mike Gelfand [Tue, 30 May 2017 17:09:19 +0000 (20:09 +0300)]
Add generic `check_mem` (libtest)

7 years agoAdd generic `check_bool`, extend `check` to be more informative (libtest)
Mike Gelfand [Tue, 30 May 2017 16:21:14 +0000 (19:21 +0300)]
Add generic `check_bool`, extend `check` to be more informative (libtest)

7 years agoTransform `check_ptr_eq` into generic `check_ptr` (libtest)
Mike Gelfand [Tue, 30 May 2017 14:42:05 +0000 (17:42 +0300)]
Transform `check_ptr_eq` into generic `check_ptr` (libtest)

7 years agoTransform `check_uint_eq` into generic `check_uint` (libtest)
Mike Gelfand [Mon, 29 May 2017 20:39:51 +0000 (23:39 +0300)]
Transform `check_uint_eq` into generic `check_uint` (libtest)

7 years agoTransform `check_int_eq` into generic `check_int` (libtest)
Mike Gelfand [Mon, 29 May 2017 20:22:36 +0000 (23:22 +0300)]
Transform `check_int_eq` into generic `check_int` (libtest)

7 years agoTransform `check_str_eq` into generic `check_str` (libtest)
Mike Gelfand [Mon, 29 May 2017 19:48:02 +0000 (22:48 +0300)]
Transform `check_str_eq` into generic `check_str` (libtest)

7 years agoContinue running other test-cases even if one fails (libtest)
Mike Gelfand [Mon, 29 May 2017 17:05:24 +0000 (20:05 +0300)]
Continue running other test-cases even if one fails (libtest)

7 years agoPass `(u)intmax_t` instead of `(u)int64_t` to `check_(u)int_eq` (libtest)
Mike Gelfand [Mon, 29 May 2017 16:51:25 +0000 (19:51 +0300)]
Pass `(u)intmax_t` instead of `(u)int64_t` to `check_(u)int_eq` (libtest)

7 years agoRename `check_streq` to `check_str_eq` to be in line with other macros (libtest)
Mike Gelfand [Mon, 29 May 2017 16:50:23 +0000 (19:50 +0300)]
Rename `check_streq` to `check_str_eq` to be in line with other macros (libtest)

7 years agoFixup 2321bc3fad (unintended logic change, spotted by cfpp2p in #297)
Mike Gelfand [Mon, 29 May 2017 05:50:40 +0000 (08:50 +0300)]
Fixup 2321bc3fad (unintended logic change, spotted by cfpp2p in #297)

7 years agoAdd command line interface notes readme section
Mike Gelfand [Thu, 25 May 2017 18:31:43 +0000 (21:31 +0300)]
Add command line interface notes readme section

Fixes: #274
7 years agoInclude stdbool.h unconditionally
Mike Gelfand [Wed, 24 May 2017 19:53:06 +0000 (22:53 +0300)]
Include stdbool.h unconditionally

All the compilers should provide the header file by now. Remove `tr_isBool`
sanity checks along the way as compiler should guarantee that bool (_Bool)
values are 0 or 1 and nothing else.

7 years agoLittle bastards keep popping up here and there :(
Mike Gelfand [Tue, 23 May 2017 19:17:17 +0000 (22:17 +0300)]
Little bastards keep popping up here and there :(