]> granicus.if.org Git - clang/log
clang
12 years agoSilence unused-variable warning when assertions are disabled.
Kaelyn Uhrain [Thu, 3 May 2012 19:46:38 +0000 (19:46 +0000)]
Silence unused-variable warning when assertions are disabled.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156091 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoHonour CLANG_BUILD_EXAMPLES correctly, by setting the directory's
Peter Collingbourne [Thu, 3 May 2012 19:11:45 +0000 (19:11 +0000)]
Honour CLANG_BUILD_EXAMPLES correctly, by setting the directory's
EXCLUDE_FROM_ALL property.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156090 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] When promoting constant integers in a comparison, use the larger width...
Jordy Rose [Thu, 3 May 2012 19:05:48 +0000 (19:05 +0000)]
[analyzer] When promoting constant integers in a comparison, use the larger width of the two to avoid truncation.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156089 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRemove diagnostic groups and DefaultIgnore from notes.
Richard Smith [Thu, 3 May 2012 18:38:45 +0000 (18:38 +0000)]
Remove diagnostic groups and DefaultIgnore from notes.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156087 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd -Wimplicit-fallthrough warning flag, which warns on fallthrough between
Richard Smith [Thu, 3 May 2012 18:27:39 +0000 (18:27 +0000)]
Add -Wimplicit-fallthrough warning flag, which warns on fallthrough between
cases in switch statements. Also add a [[clang::fallthrough]] attribute, which
can be used to suppress the warning in the case of intentional fallthrough.

Patch by Alexander Kornienko!

The handling of C++11 attribute namespaces in this patch is temporary, and will
be replaced with a cleaner mechanism in a subsequent patch.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156086 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] CString Checker: Do not split the path unless the user
Anna Zaks [Thu, 3 May 2012 18:21:28 +0000 (18:21 +0000)]
[analyzer] CString Checker: Do not split the path unless the user
specifically checks for equality to null.

Enforcing this general practice, which keeps the analyzer less
noisy, in the CString Checker. This change suppresses "Assigned value is
garbage or undefined" warning in the added test case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156085 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix a couple of cases of (innocuous) unmarked fallthrough. At least one of these
Richard Smith [Thu, 3 May 2012 17:56:49 +0000 (17:56 +0000)]
Fix a couple of cases of (innocuous) unmarked fallthrough. At least one of these
was unintentional. Found by -Wimplicit-fallthrough, patch by Alexander Kornienko!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156082 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoIn StringLiteralParser::init, make sure we emit an error when
Argyrios Kyrtzidis [Thu, 3 May 2012 17:50:32 +0000 (17:50 +0000)]
In StringLiteralParser::init, make sure we emit an error when
failing to lex the string, as suggested by Eli.

Part of rdar://11305263.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156081 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[driver crash diagnostics] Remove more flags that reference absolute paths that
Chad Rosier [Thu, 3 May 2012 17:07:55 +0000 (17:07 +0000)]
[driver crash diagnostics] Remove more flags that reference absolute paths that
aren't necessary to reproduce the clang crash.
Part of rdar://11285725

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156079 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoobjective-c: warn for properties being default synthesized
Fariborz Jahanian [Thu, 3 May 2012 16:43:30 +0000 (16:43 +0000)]
objective-c: warn for properties being default synthesized
under -Wobjc-missing-property-synthesis which must be
opted-in. // rdar://11295716

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156078 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoCorrectly constify clang::CXXMemberCallExpr::getRecordDecl()
David Blaikie [Thu, 3 May 2012 16:25:49 +0000 (16:25 +0000)]
Correctly constify clang::CXXMemberCallExpr::getRecordDecl()

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156074 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoTest case Clang::Driver/debug-options-as.c depends on the integrated assembler. Turn...
Simon Atanasyan [Thu, 3 May 2012 13:57:00 +0000 (13:57 +0000)]
Test case Clang::Driver/debug-options-as.c depends on the integrated assembler. Turn it on explicitly on all platforms by the "-integrated-as" option.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156063 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Equality ops are like relational ops in that the arguments shouldn't be...
Jordy Rose [Thu, 3 May 2012 07:34:01 +0000 (07:34 +0000)]
[analyzer] Equality ops are like relational ops in that the arguments shouldn't be converted to the result type. Fixes PR12206 and dupe PR12510.

This was probably the original intent of r133041 (also me, a year ago).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156062 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Fix RUN line and general cleanup for additive folding tests.
Jordy Rose [Thu, 3 May 2012 07:33:56 +0000 (07:33 +0000)]
[analyzer] Fix RUN line and general cleanup for additive folding tests.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156061 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRip out old code for finding libraries in GCC's directories.
Bob Wilson [Thu, 3 May 2012 05:23:52 +0000 (05:23 +0000)]
Rip out old code for finding libraries in GCC's directories.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156058 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[PCH] Clear switch case IDs when deserializing a objc method body.
Argyrios Kyrtzidis [Thu, 3 May 2012 02:26:32 +0000 (02:26 +0000)]
[PCH] Clear switch case IDs when deserializing a objc method body.

Fixes rdar://11353109 & http://llvm.org/bugs/show_bug.cgi?id=12689

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156056 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Conjure a symbol to ensure we can identify pointer arithmetic
Anna Zaks [Thu, 3 May 2012 02:13:56 +0000 (02:13 +0000)]
[analyzer] Conjure a symbol to ensure we can identify pointer arithmetic

We need to identify the value of ptr as
ElementRegion (result of pointer arithmetic) in the following code.
However, before this commit '(2-x)' evaluated to Unknown value, and as
the result, 'p + (2-x)' evaluated to Unknown value as well.

int *p = malloc(sizeof(int));
ptr = p + (2-x);

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156052 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Do not assert on constructing SymSymExpr with diff types.
Anna Zaks [Thu, 3 May 2012 02:13:53 +0000 (02:13 +0000)]
[analyzer] Do not assert on constructing SymSymExpr with diff types.

The resulting type info is stored in the SymSymExpr, so no reason not to
support construction of expression with different subexpression types.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156051 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Add a complexity bound on history tracking.
Anna Zaks [Thu, 3 May 2012 02:13:50 +0000 (02:13 +0000)]
[analyzer] Add a complexity bound on history tracking.

(Currently, this is only relevant for tainted data.)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156050 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Revert the functional part of r155944.
Anna Zaks [Thu, 3 May 2012 02:13:46 +0000 (02:13 +0000)]
[analyzer] Revert the functional part of r155944.

The change resulted in multiple issues on the buildbot, so it's not
ready for prime time. Only enable history tracking for tainted
data(which is experimental) for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156049 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoMerge x86-64-abi-sret-vs-2word-struct-param.cpp into the generic
John McCall [Thu, 3 May 2012 01:34:46 +0000 (01:34 +0000)]
Merge x86-64-abi-sret-vs-2word-struct-param.cpp into the generic
x86_64-arguments.cpp test file and be sure to test the coerced
case as well.  Thanks to Wei-Ren Chen for bringing this test
to my attention.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156047 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix a note without a SourceLocation.
Richard Trieu [Thu, 3 May 2012 01:09:59 +0000 (01:09 +0000)]
Fix a note without a SourceLocation.

#define TEST int y; int x = y;
void foo() {
  TEST
}

-Wuninitialized gives this warning:
invalid-loc.cc:4:3: warning: variable 'y' is uninitialized when used here
      [-Wuninitialized]
  TEST
  ^~~~
invalid-loc.cc:2:29: note: expanded from macro 'TEST'
#define TEST int y; int x = y;
                            ^
note: initialize the variable 'y' to silence this warning
1 warning generated.

The second note lacks filename, line number, and code snippet.  This change
will remove the fixit and only point to variable declaration.

invalid-loc.cc:4:3: warning: variable 'y' is uninitialized when used here
      [-Wuninitialized]
  TEST
  ^~~~
invalid-loc.cc:2:29: note: expanded from macro 'TEST'
#define TEST int y; int x = y;
                            ^
invalid-loc.cc:4:3: note: variable 'y' is declared here
  TEST
  ^
invalid-loc.cc:2:14: note: expanded from macro 'TEST'
#define TEST int y; int x = y;
             ^
1 warning generated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156045 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoIn StringLiteralParser::init(), fail gracefully if the string is
Argyrios Kyrtzidis [Thu, 3 May 2012 01:01:56 +0000 (01:01 +0000)]
In StringLiteralParser::init(), fail gracefully if the string is
not as we expect; it may be due to racing issue of a file coming from PCH
changing after the PCH is loaded.

rdar://11353109

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156043 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agomodern objective-c translator: Fix destructor def.
Fariborz Jahanian [Wed, 2 May 2012 23:53:46 +0000 (23:53 +0000)]
modern objective-c translator: Fix destructor def.
for __NSContainer_literal.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156035 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd commas to for loop warning to separate variable names.
Richard Trieu [Wed, 2 May 2012 22:48:45 +0000 (22:48 +0000)]
Add commas to for loop warning to separate variable names.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156033 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRevert most of r154844, which was disabled in r155975. Keep around the
Richard Smith [Wed, 2 May 2012 22:22:32 +0000 (22:22 +0000)]
Revert most of r154844, which was disabled in r155975. Keep around the
refactorings in that revision, and some of the subsequent bugfixes, which
seem to be relevant even without delayed exception specification parsing.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156031 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoThread safety analysis: additional support for smart pointers in lock expressions.
DeLesley Hutchins [Wed, 2 May 2012 22:18:42 +0000 (22:18 +0000)]
Thread safety analysis: additional support for smart pointers in lock expressions.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156030 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix some doxycomments using \class instead of \brief.
David Blaikie [Wed, 2 May 2012 21:58:03 +0000 (21:58 +0000)]
Fix some doxycomments using \class instead of \brief.

Patches by Csaba Raduly (rcsaba@gmail.com)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156027 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[python] Add testcase for annotation cursor
Anders Waldenborg [Wed, 2 May 2012 21:28:34 +0000 (21:28 +0000)]
[python] Add testcase for annotation cursor

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156022 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[python] Add Cursor.enum_value wrapping clang_getEnumConstantDeclValue
Anders Waldenborg [Wed, 2 May 2012 20:57:33 +0000 (20:57 +0000)]
[python] Add Cursor.enum_value wrapping clang_getEnumConstantDeclValue

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156017 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoWalk the decls looking for the last one that has an attribute. We do have to walk
Rafael Espindola [Wed, 2 May 2012 20:36:57 +0000 (20:36 +0000)]
Walk the decls looking for the last one that has an attribute. We do have to walk
them, otherwise we cannot produce an error for both

struct HIDDEN test4; // canonical
struct test4;
struct DEFAULT test4;

and

struct test5; // canonical
struct HIDDEN test5;
struct DEFAULT test5;

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156016 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[python] Add testcase for enum with specified underlaying type
Anders Waldenborg [Wed, 2 May 2012 19:39:46 +0000 (19:39 +0000)]
[python] Add testcase for enum with specified underlaying type

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156009 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[python] Run tests for c++ with std=c++11
Anders Waldenborg [Wed, 2 May 2012 19:37:16 +0000 (19:37 +0000)]
[python] Run tests for c++ with std=c++11

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156008 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[python] Fix warning in c-code inside testcase
Anders Waldenborg [Wed, 2 May 2012 19:35:37 +0000 (19:35 +0000)]
[python] Fix warning in c-code inside testcase

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156007 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoThread Safety Analysis: fixed attribute handling for lock_returned attribute.
DeLesley Hutchins [Wed, 2 May 2012 17:38:37 +0000 (17:38 +0000)]
Thread Safety Analysis: fixed attribute handling for lock_returned attribute.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156005 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoModern objective-c translation: Fixing couple of bugs
Fariborz Jahanian [Wed, 2 May 2012 17:34:59 +0000 (17:34 +0000)]
Modern objective-c translation: Fixing couple of bugs
related to laying out ivar structs and accessing non-fragile-ivar
in more compilated cases. // rdar://11323187

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156004 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoReplace the StringSwitch in AttributeList::getKind() with a
Douglas Gregor [Wed, 2 May 2012 17:33:51 +0000 (17:33 +0000)]
Replace the StringSwitch in AttributeList::getKind() with a
TableGen-generated StringMatcher, for a 1.2% speedup in -fparse-only
time in <rdar://problem/11004361>. Thanks to Benjamin for pointing me
at StringMatcher!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156003 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoIntroduce the notion of 'ignored' attributes, so that all attributes
Douglas Gregor [Wed, 2 May 2012 16:18:45 +0000 (16:18 +0000)]
Introduce the notion of 'ignored' attributes, so that all attributes
we accept are not modeled somehow via Attr.td.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155998 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoIntroduce the notion of an attribute that has no direct representation
Douglas Gregor [Wed, 2 May 2012 15:56:52 +0000 (15:56 +0000)]
Introduce the notion of an attribute that has no direct representation
as an AST node, and fold a number of such attributes into Attr.td.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155995 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix same line doxycomments so they comment the adjacent field.
David Blaikie [Wed, 2 May 2012 15:24:47 +0000 (15:24 +0000)]
Fix same line doxycomments so they comment the adjacent field.

Without the '<' prefix in the doxycomment these comments were incorrectly
attached to the proceeding comment on the next line, rather than the
preceeding one.

Fixes PR12722

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155993 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoImplement the alternate spellings of attributes aligned (as "align")
Douglas Gregor [Wed, 2 May 2012 15:16:13 +0000 (15:16 +0000)]
Implement the alternate spellings of attributes aligned (as "align")
and const (as "__const") using tblgen, rather than explicitly hacking
them in.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155991 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoDriver: Turn the default value for -fmath-errno into a proper target hook and disable...
Benjamin Kramer [Wed, 2 May 2012 14:55:48 +0000 (14:55 +0000)]
Driver: Turn the default value for -fmath-errno into a proper target hook and disable it by default on more platforms.

For now -fno-math-errno is the default on BSD-derived platforms (Darwin,
DragonFlyBSD, FreeBSD, NetBSD, OpenBSD). If the default is not right for
your platform, please yell. I only verified the result with the default
compilers on Darwin and FreeBSD.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155990 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRevert my optimization to AttributeList::getKind() in r155987;
Douglas Gregor [Wed, 2 May 2012 14:50:50 +0000 (14:50 +0000)]
Revert my optimization to AttributeList::getKind() in r155987;
Benjamin has suggested a better approach.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155989 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoReplace a ConsumeAnyToken() call with ConsumeToken() when we know
Douglas Gregor [Wed, 2 May 2012 14:34:16 +0000 (14:34 +0000)]
Replace a ConsumeAnyToken() call with ConsumeToken() when we know
we're looking at a normal token. Tiny positive impact -fsyntax-only
time for <rdar://problem/11004361>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155988 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoReplace the StringSwitch in AttributeList::getKind(const
Douglas Gregor [Wed, 2 May 2012 14:24:30 +0000 (14:24 +0000)]
Replace the StringSwitch in AttributeList::getKind(const
IdentifierInfo *) with a static StringMap, improving -fsyntax-only
performance by 1% for the example in <rdar://problem/11004361>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155987 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix forwarding of -fpack-struct from driver to CC1, and add a test.
James Molloy [Wed, 2 May 2012 07:56:14 +0000 (07:56 +0000)]
Fix forwarding of -fpack-struct from driver to CC1, and add a test.

-fpack-struct's handling has changed in CC1 (one of only two flags that needed changing) because the driver treats "-fpack-struct" as a boolean flag, and CC1 (did) treat it as an option with a separated value.

This change causes -fpack-struct=X to be forwarded correctly to -fpack-struct=X instead of erroneously to "-fpack-struct X"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155981 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoDon't try to instantiate std::list at an incomplete type; it's not
John McCall [Wed, 2 May 2012 05:44:20 +0000 (05:44 +0000)]
Don't try to instantiate std::list at an incomplete type;  it's not
allowed, and it'll blow up in unfortunate ways when using a proper
C++11 library.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155980 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix cmake. Remaining two ClangCC1Options deps.
Andrew Trick [Wed, 2 May 2012 05:31:31 +0000 (05:31 +0000)]
Fix cmake. Remaining two ClangCC1Options deps.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155977 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoDisable our non-standard delayed parsing of exception specifications. Delaying
Richard Smith [Wed, 2 May 2012 01:29:43 +0000 (01:29 +0000)]
Disable our non-standard delayed parsing of exception specifications. Delaying
the parsing of such things appears to be a conforming extension, but it breaks
libstdc++4.7's std::pair.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155975 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoSpeculatively fix windows cmake builders.
Andrew Trick [Wed, 2 May 2012 01:23:51 +0000 (01:23 +0000)]
Speculatively fix windows cmake builders.

Really just a wild stab in the dark.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155974 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRefine analyzer diagnostics by adding an expression "cone-of-influence" to reverse...
Ted Kremenek [Wed, 2 May 2012 00:31:29 +0000 (00:31 +0000)]
Refine analyzer diagnostics by adding an expression "cone-of-influence" to reverse track interesting
values through interesting expressions.  This allows us to map from interesting values in a caller
to interesting values in a caller, thus recovering some precision in diagnostics lost from IPA.

Fixes <rdar://problem/11327497>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155971 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoUnrevert r155951, reverted in r155962, with two changes:
Richard Smith [Wed, 2 May 2012 00:30:48 +0000 (00:30 +0000)]
Unrevert r155951, reverted in r155962, with two changes:
 * Work around build failures due to gcc 4.2 bugs.
 * Remove BodyIndexer::TraverseCXXOperatorCallExpr, which was not being called
   prior to this change, and whose presence disables a RecursiveASTVisitor
   stack space optimization after this change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155969 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] RetainRelease: Self assignment should not suppress a leak
Anna Zaks [Wed, 2 May 2012 00:15:40 +0000 (00:15 +0000)]
[analyzer] RetainRelease: Self assignment should not suppress a leak
warning.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155966 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoTry harder to recognize hidden tag type names in potential declarations instead
Kaelyn Uhrain [Wed, 2 May 2012 00:11:40 +0000 (00:11 +0000)]
Try harder to recognize hidden tag type names in potential declarations instead
of giving unhelpful errors about undeclared identifers and missing semicolons.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155965 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Fix an assertion failure triggered by the analyzer buildbot.
Anna Zaks [Wed, 2 May 2012 00:05:23 +0000 (00:05 +0000)]
[analyzer] Fix an assertion failure triggered by the analyzer buildbot.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155964 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Fix the 'ptr = ptr' false negative in the Malloc checker.
Anna Zaks [Wed, 2 May 2012 00:05:20 +0000 (00:05 +0000)]
[analyzer] Fix the 'ptr = ptr' false negative in the Malloc checker.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155963 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRevert "Fix RecursiveASTVisitor's data recursion to call the Traverse* functions...
Andrew Trick [Tue, 1 May 2012 23:47:36 +0000 (23:47 +0000)]
Revert "Fix RecursiveASTVisitor's data recursion to call the Traverse* functions if they"

FAIL: Clang :: Index/index-many-call-ops.cpp

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155962 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoEliminate Sema::CompareMethodParamsInBaseAndSuper() entirely, by
Douglas Gregor [Tue, 1 May 2012 23:37:00 +0000 (23:37 +0000)]
Eliminate Sema::CompareMethodParamsInBaseAndSuper() entirely, by
folding its one check into the normal path for checking overridden
Objective-C methods. Good for another 3.6% speedup on the test case in
<rdar://problem/11004361>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155961 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoThe semantic checking that verifies whether an Objective-C method
Douglas Gregor [Tue, 1 May 2012 23:07:34 +0000 (23:07 +0000)]
The semantic checking that verifies whether an Objective-C method
declared in a subclass has consistent parameter types with a method
having the same selector in a superclass performs a significant number
of lookups into the class hierarchy. In the example in
<rdar://problem/11004361>, we spend 4.7% of -fsyntax-only time in
these lookups.

Optimize away most of the calls to this routine
(Sema::CompareMethodParamsInBaseAndSuper) by first checking whether we
have ever seen *any* method with that selector (using the global
selector table). Since most selectors are unique, we can avoid the
cost of this name lookup in many cases, for a 3.3% speedup.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155958 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd a missing RequireCompleteType call when synthesizing properties. <rdar://problem...
Eli Friedman [Tue, 1 May 2012 22:26:06 +0000 (22:26 +0000)]
Add a missing RequireCompleteType call when synthesizing properties.  <rdar://problem/11333367>.

While I'm here, fix source locations for other diagnostics related to property synthesis.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155953 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoUtilize getLocStart()/getLocEnd() on my recent change.
Argyrios Kyrtzidis [Tue, 1 May 2012 22:19:11 +0000 (22:19 +0000)]
Utilize getLocStart()/getLocEnd() on my recent change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155952 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix RecursiveASTVisitor's data recursion to call the Traverse* functions if they
Richard Smith [Tue, 1 May 2012 21:58:31 +0000 (21:58 +0000)]
Fix RecursiveASTVisitor's data recursion to call the Traverse* functions if they
have been overridden in the derived class. Also, remove a non-functional
implementation of an incorrect optimization for ParenExprs.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155951 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoTeach SValBuilder to handle casts of symbolic pointer values to an integer twice...
Ted Kremenek [Tue, 1 May 2012 21:58:29 +0000 (21:58 +0000)]
Teach SValBuilder to handle casts of symbolic pointer values to an integer twice.  Fixes <rdar://problem/11212866>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155950 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoClean up changes suggested by Douglas Gregor:
Patrick Beard [Tue, 1 May 2012 21:47:19 +0000 (21:47 +0000)]
Clean up changes suggested by Douglas Gregor:

BuildObjCNumericLiteral() and BuildObjCBoxedExpr() now both using
PerformCopyInitialization() rather than PerformImplicitConversion(),
which suppresses errors.

In BuildObjCBoxedExpr(): no longer calling .getCanonicalType(),
ValueType->getAs() will remove the minimal amount of sugar.
Using ValueType->isBuiltinType() instead of isa<BuiltinType>(ValueType).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155949 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix test cases broken by 155936.
David Blaikie [Tue, 1 May 2012 21:29:03 +0000 (21:29 +0000)]
Fix test cases broken by 155936.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155948 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Test case reported for a reported false positive, now fixed.
Anna Zaks [Tue, 1 May 2012 21:10:29 +0000 (21:10 +0000)]
[analyzer] Test case reported for a reported false positive, now fixed.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155945 91177308-0d34-0410-b5e6-96231b3b80d8

12 years ago[analyzer] Construct a SymExpr even when the constraint solver cannot
Anna Zaks [Tue, 1 May 2012 21:10:26 +0000 (21:10 +0000)]
[analyzer] Construct a SymExpr even when the constraint solver cannot
reason about the expression.

This essentially keeps more history about how symbolic values were
constructed. As an optimization, previous to this commit, we only kept
the history if one of the symbols was tainted, but it's valuable keep
the history around for other purposes as well: it allows us to avoid
constructing conjured symbols.

Specifically, we need to identify the value of ptr as
ElementRegion (result of pointer arithmetic) in the following code.
However, before this commit '(2-x)' evaluated to Unknown value, and as
the result, 'p + (2-x)' evaluated to Unknown value as well.

int *p = malloc(sizeof(int));
ptr = p + (2-x);

This change brings 2% slowdown on sqlite. Fixes radar://11329382.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155944 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoExtend the error about incompatible visibility attributes in different
Rafael Espindola [Tue, 1 May 2012 20:58:29 +0000 (20:58 +0000)]
Extend the error about incompatible visibility attributes in different
decls to work on function templates specializations.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155943 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoWe don't need a lengthy quote from the wrong standard.
Douglas Gregor [Tue, 1 May 2012 20:44:16 +0000 (20:44 +0000)]
We don't need a lengthy quote from the wrong standard.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155942 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd test cases for r155935.
Douglas Gregor [Tue, 1 May 2012 20:31:53 +0000 (20:31 +0000)]
Add test cases for r155935.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155940 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRevert r155933
Douglas Gregor [Tue, 1 May 2012 20:30:48 +0000 (20:30 +0000)]
Revert r155933

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155939 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoWorkaround a miscompile in 483.xalancbmk while we figure it out.
David Blaikie [Tue, 1 May 2012 20:28:45 +0000 (20:28 +0000)]
Workaround a miscompile in 483.xalancbmk while we figure it out.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155938 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoDuring block layout, after padding up to the max field alignment,
John McCall [Tue, 1 May 2012 20:28:00 +0000 (20:28 +0000)]
During block layout, after padding up to the max field alignment,
the alignment might actually exceed the max field alignment;  don't
assert in this case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155937 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoDiagnostics should start with a lower-case letter.
Patrick Beard [Tue, 1 May 2012 20:27:10 +0000 (20:27 +0000)]
Diagnostics should start with a lower-case letter.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155936 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoIn C++11 mode, implement the C++11 semantics for
Douglas Gregor [Tue, 1 May 2012 20:23:02 +0000 (20:23 +0000)]
In C++11 mode, implement the C++11 semantics for
[basic.lookup.classref]p1 and p4, which concerns name lookup for
nested-name-specifiers and template names, respectively, in a member
access expression. C++98/03 forces us to look both in the scope of the
object and in the current scope, then compare the results. C++11 just
takes the result from the scope of the object, if something is
found. Fixes <rdar://problem/11328502>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155935 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix CMake build
Douglas Gregor [Tue, 1 May 2012 20:08:24 +0000 (20:08 +0000)]
Fix CMake build

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155933 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoTest verified.
John McCall [Tue, 1 May 2012 19:57:05 +0000 (19:57 +0000)]
Test verified.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155932 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoSpacing.
Chad Rosier [Tue, 1 May 2012 19:53:37 +0000 (19:53 +0000)]
Spacing.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155931 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoImplement simplify_type traits for redecl_iterator.
David Blaikie [Tue, 1 May 2012 19:49:42 +0000 (19:49 +0000)]
Implement simplify_type traits for redecl_iterator.

Based on Chandler Carruth's feedback on r155869.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155929 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRemove variables made dead by r155923
David Blaikie [Tue, 1 May 2012 19:49:38 +0000 (19:49 +0000)]
Remove variables made dead by r155923

This makes Clang's build warning free again.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155928 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoGet rid of storelv4si builtin as it can be expressed directly. This is general
Chad Rosier [Tue, 1 May 2012 18:11:51 +0000 (18:11 +0000)]
Get rid of storelv4si builtin as it can be expressed directly.  This is general
goodness because it provides opportunites to cleanup things.  For example,

uint64_t t1(__m128i vA)
{
  uint64_t Alo;
  _mm_storel_epi64((__m128i*)&Alo, vA);
  return Alo;
}

was generating

movq %xmm0, -8(%rbp)
movq -8(%rbp), %rax

and now generates

movd %xmm0, %rax

rdar://11282581

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155924 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRemove dead code found by static analyzer.
Ted Kremenek [Tue, 1 May 2012 17:56:57 +0000 (17:56 +0000)]
Remove dead code found by static analyzer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155923 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoPush variable declaration into nested scope (the only place where it is used). Found...
Ted Kremenek [Tue, 1 May 2012 17:56:53 +0000 (17:56 +0000)]
Push variable declaration into nested scope (the only place where it is used).  Found by static analyzer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155922 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agomodern objective-c translation of private ivars.
Fariborz Jahanian [Tue, 1 May 2012 17:46:45 +0000 (17:46 +0000)]
modern objective-c translation of private ivars.
// rdar://11351299

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155921 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRestructure some of the member-pointer tests, implicitly
John McCall [Tue, 1 May 2012 17:32:20 +0000 (17:32 +0000)]
Restructure some of the member-pointer tests, implicitly
removing some that were added without a triple (and moving
their tests into files that appropriately test multiple
architectures).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155920 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoUnify Options.td and CC1Options.td, in a first step towards unifying the serializatio...
James Molloy [Tue, 1 May 2012 14:57:16 +0000 (14:57 +0000)]
Unify Options.td and CC1Options.td, in a first step towards unifying the serialization logic in Frontend and Driver.

Reviewed by Eric, Doug and Chandler, and here: http://llvm.org/reviews/r/7/

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155916 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoMake some helper functions static.
Benjamin Kramer [Tue, 1 May 2012 14:34:11 +0000 (14:34 +0000)]
Make some helper functions static.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155914 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoclang/test/CodeGenCXX: Fix two tests, destructors.cpp and microsoft-abi-array-cookies...
NAKAMURA Takumi [Tue, 1 May 2012 11:13:04 +0000 (11:13 +0000)]
clang/test/CodeGenCXX: Fix two tests, destructors.cpp and microsoft-abi-array-cookies.cpp, for -Asserts.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155913 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoclang/test/Rewriter: Remove XFAIL and add -U__declspec to other 9 tests. mingw32...
NAKAMURA Takumi [Tue, 1 May 2012 10:52:06 +0000 (10:52 +0000)]
clang/test/Rewriter: Remove XFAIL and add -U__declspec to other 9 tests. mingw32 tends to define built-in __declspec.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155911 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoclang/test/Rewriter/rewrite-modern-extern-c-func-decl.mm: Remove XFAIL and add -U__de...
NAKAMURA Takumi [Tue, 1 May 2012 10:51:55 +0000 (10:51 +0000)]
clang/test/Rewriter/rewrite-modern-extern-c-func-decl.mm: Remove XFAIL and add -U__declspec. mingw32 tends to define built-in __declspec.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155910 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd a disclaimer to the new test, plus a user-declared ctor
John McCall [Tue, 1 May 2012 08:59:06 +0000 (08:59 +0000)]
Add a disclaimer to the new test, plus a user-declared ctor
to force the emission of vtordisps.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155906 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAdd support for laying out vtordisps according to our current
John McCall [Tue, 1 May 2012 08:55:32 +0000 (08:55 +0000)]
Add support for laying out vtordisps according to our current
working knowledge of the Microsoft ABI.  Based on a patch by
Dmitry Sokolov.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155905 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoFix compilation with mingw-w64.
Abramo Bagnara [Tue, 1 May 2012 08:38:19 +0000 (08:38 +0000)]
Fix compilation with mingw-w64.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155904 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoEnable AVX on AMD Bulldozer processors.
Craig Topper [Tue, 1 May 2012 07:18:03 +0000 (07:18 +0000)]
Enable AVX on AMD Bulldozer processors.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155900 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoAbstract the emission of global destructors into ABI-specific code
John McCall [Tue, 1 May 2012 06:13:13 +0000 (06:13 +0000)]
Abstract the emission of global destructors into ABI-specific code
and only consider using __cxa_atexit in the Itanium logic.  The
default logic is to use atexit().

Emit "guarded" initializers in Microsoft mode unconditionally.
This is definitely not correct, but it's closer to correct than
just not emitting the initializer.

Based on a patch by Timur Iskhodzhanov!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155894 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoPR12710 - broken default argument handling for templates.
David Blaikie [Tue, 1 May 2012 06:05:57 +0000 (06:05 +0000)]
PR12710 - broken default argument handling for templates.

I broke this in r155838 by not actually instantiating non-dependent default arg
expressions. The motivation for that change was to avoid producing duplicate
conversion warnings for such default args (we produce them once when we parse
the template - there's no need to produce them at each instantiation) but
without actually instantiating the default arg, things break in weird ways.

Technically, I think we could still get the right diagnostic experience without
the bugs if we instantiated the non-dependent args (for non-dependent params
only) immediately, rather than lazily. But I'm not sure if such a refactoring/
change would be desirable so here's the conservative fix for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155893 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoPlace several uncovered warnings under warning flags, and tweak diagnostic output...
Ted Kremenek [Tue, 1 May 2012 05:56:02 +0000 (05:56 +0000)]
Place several uncovered warnings under warning flags, and tweak diagnostic output including the term "gc" (in lowercase).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155892 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRemove some not-very-stable assumptions from this testcase.
John McCall [Tue, 1 May 2012 05:29:32 +0000 (05:29 +0000)]
Remove some not-very-stable assumptions from this testcase.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155889 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoTeach RetainCountchecker about IORegistryEntrySearchCFProperty returning retained...
Ted Kremenek [Tue, 1 May 2012 05:28:27 +0000 (05:28 +0000)]
Teach RetainCountchecker about IORegistryEntrySearchCFProperty returning retained objects.  I know there is an SDK enhancement request for this to have the cf_returns_retained annotation, so this is just a stop gap.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155887 91177308-0d34-0410-b5e6-96231b3b80d8

12 years agoRefactor the C++ ABI code a little bit to take advantage of
John McCall [Tue, 1 May 2012 05:23:51 +0000 (05:23 +0000)]
Refactor the C++ ABI code a little bit to take advantage of
what I'm going to treat as basically universal properties of
array-cookie code.  Implement MS array cookies on top of that.
Based on a patch by Timur Iskhodzhanov!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155886 91177308-0d34-0410-b5e6-96231b3b80d8