]> granicus.if.org Git - python/log
python
11 years agoIssue #18038: SyntaxError raised during compilation sources with illegal
Serhiy Storchaka [Sun, 9 Jun 2013 13:51:52 +0000 (16:51 +0300)]
Issue #18038: SyntaxError raised during compilation sources with illegal
encoding now always contains an encoding name.

11 years ago#18126: update NumPy links in the documentation. Patch by Yury V. Zaytsev.
Ezio Melotti [Sat, 8 Jun 2013 22:04:21 +0000 (01:04 +0300)]
#18126: update NumPy links in the documentation.  Patch by Yury V. Zaytsev.

11 years ago#17691: test_univnewlines now works with unittest test discovery. Patch by Zachary...
Ezio Melotti [Sat, 8 Jun 2013 21:07:06 +0000 (00:07 +0300)]
#17691: test_univnewlines now works with unittest test discovery.  Patch by Zachary Ware.

11 years ago#18151, part 1: Backport idlelilb portion of Andrew Svetlov's 3.4 patch
Terry Jan Reedy [Sat, 8 Jun 2013 04:22:45 +0000 (00:22 -0400)]
#18151, part 1: Backport idlelilb portion of Andrew Svetlov's 3.4 patch
changing IOError to OSError (#16715).

11 years agoIssue #18055: Move to importlib from imp for IDLE.
Brett Cannon [Fri, 7 Jun 2013 17:17:48 +0000 (13:17 -0400)]
Issue #18055: Move to importlib from imp for IDLE.

11 years agoIssue 18130: delete extra spaces
Terry Jan Reedy [Wed, 5 Jun 2013 18:36:33 +0000 (14:36 -0400)]
Issue 18130: delete extra spaces

11 years agoIssue18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog.
Terry Jan Reedy [Wed, 5 Jun 2013 18:22:26 +0000 (14:22 -0400)]
Issue18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog.
Fix bug in existing human test and add instructions; fix two bugs in tested
code; remove redundancies, add spaces, and change two internal method names.
Add mock_tk with mocks for tkinter.Variable subclasses and tkinter.messagebox.
Use mocks in test_config_name to unittest methods that are otherwise gui-free.

11 years agoClose #18109: os.uname() now decodes fields from the locale encoding, and
Victor Stinner [Mon, 3 Jun 2013 20:07:27 +0000 (22:07 +0200)]
Close #18109: os.uname() now decodes fields from the locale encoding, and
socket.gethostname() now decodes the hostname from the locale encoding, instead
of using the UTF-8 encoding in strict mode.

11 years agoFix #17967 - Fix related to regression on Windows.
Senthil Kumaran [Sun, 2 Jun 2013 18:59:47 +0000 (11:59 -0700)]
Fix #17967 - Fix related to regression on Windows.

os.path.join(*self.dirs) produces an invalid path on windows.
ftp paths are always forward-slash seperated like this. /pub/dir.

11 years agoClarify which dictionaries are updateable
Raymond Hettinger [Sun, 2 Jun 2013 17:03:05 +0000 (10:03 -0700)]
Clarify which dictionaries are updateable
by using the wording from the Py2.7 docs.

11 years agoFix thishost helper funtion in urllib. Returns the ipaddress of localhost when
Senthil Kumaran [Sat, 1 Jun 2013 18:12:17 +0000 (11:12 -0700)]
Fix thishost helper funtion in urllib. Returns the ipaddress of localhost when
hostname is resolvable by socket.gethostname for local machine. This all fixes
certain freebsd builtbot failures.

11 years agoFix #17967: For ftp urls CWD to target instead of hopping to each directory
Senthil Kumaran [Sat, 1 Jun 2013 15:27:06 +0000 (08:27 -0700)]
Fix #17967: For ftp urls CWD to target instead of hopping to each directory
towards target. This fixes a bug where target is accessible, but parent
directories are restricted.

11 years agoIssue #18094: test_uuid no more reports skipped tests as passed.
Serhiy Storchaka [Fri, 31 May 2013 19:31:02 +0000 (22:31 +0300)]
Issue #18094: test_uuid no more reports skipped tests as passed.

11 years agoIssue #15392: Finish news entry.
Terry Jan Reedy [Fri, 31 May 2013 00:55:52 +0000 (20:55 -0400)]
Issue #15392: Finish news entry.

11 years agoSupport multiarch build in tests.
Stefan Krah [Wed, 29 May 2013 18:58:19 +0000 (20:58 +0200)]
Support multiarch build in tests.

11 years agoBackport bff16086f03b and bcaaaa00425b.
Stefan Krah [Wed, 29 May 2013 17:14:17 +0000 (19:14 +0200)]
Backport bff16086f03b and bcaaaa00425b.

11 years agoIssue #17768: Support newline fill character in decimal.py and NUL fill
Stefan Krah [Wed, 29 May 2013 13:45:38 +0000 (15:45 +0200)]
Issue #17768: Support newline fill character in decimal.py and NUL fill
character in _decimal.c.

11 years ago#17403: urllib.parse.robotparser normalizes the urls before adding to ruleline.
Senthil Kumaran [Wed, 29 May 2013 12:54:31 +0000 (05:54 -0700)]
#17403: urllib.parse.robotparser normalizes the urls before adding to ruleline.
This helps in handling certain types invalid urls in a conservative manner.

11 years agoIssue #15392: Do not run tests if threading/_thread not available. Otherwise
Terry Jan Reedy [Wed, 29 May 2013 02:21:53 +0000 (22:21 -0400)]
Issue #15392: Do not run tests if threading/_thread not available. Otherwise
touchup test_idle. Rename README.txt.

11 years agoIssue #18080: When building a C extension module on OS X, if the compiler
Ned Deily [Tue, 28 May 2013 23:35:30 +0000 (16:35 -0700)]
Issue #18080: When building a C extension module on OS X, if the compiler
is overriden with the CC environment variable, use the new compiler as
the default for linking if LDSHARED is not also overriden.  This restores
Distutils behavior introduced in 3.2.3 and inadvertently dropped in 3.3.0.

11 years agoIssue #18085: Fix PyObject_CallMethodObjArgs()'s entry in refcounts.dat.
Serhiy Storchaka [Tue, 28 May 2013 19:46:15 +0000 (22:46 +0300)]
Issue #18085: Fix PyObject_CallMethodObjArgs()'s entry in refcounts.dat.

11 years agoIssue #18025: Fixed a segfault in io.BufferedIOBase.readinto() when raw
Serhiy Storchaka [Tue, 28 May 2013 13:24:45 +0000 (16:24 +0300)]
Issue #18025: Fixed a segfault in io.BufferedIOBase.readinto() when raw
stream's read() returns more bytes than requested.

11 years agoIssue #17746: Skip test_shutil.test_non_matching_mode when run as root or
Serhiy Storchaka [Tue, 28 May 2013 12:50:15 +0000 (15:50 +0300)]
Issue #17746: Skip test_shutil.test_non_matching_mode when run as root or
on unsuitable platform/environment.

11 years agoIssue #18011: base64.b32decode() now raises a binascii.Error if there are
Serhiy Storchaka [Tue, 28 May 2013 12:27:29 +0000 (15:27 +0300)]
Issue #18011: base64.b32decode() now raises a binascii.Error if there are
non-alphabet characters present in the input string to conform a docstring.
Updated the module documentation.

11 years agoIssue #18079: Fix a typo in the tutorial.
Serhiy Storchaka [Tue, 28 May 2013 09:49:34 +0000 (12:49 +0300)]
Issue #18079: Fix a typo in the tutorial.

11 years agoUse simple call to os.symlink for broken link (intended for previous commit)
Jason R. Coombs [Tue, 28 May 2013 03:52:43 +0000 (23:52 -0400)]
Use simple call to os.symlink for broken link (intended for previous commit)

11 years agoIssue #13772: Restored directory detection of targets in `os.symlink` on Windows...
Jason R. Coombs [Tue, 28 May 2013 03:21:28 +0000 (23:21 -0400)]
Issue #13772: Restored directory detection of targets in `os.symlink` on Windows, which was temporarily removed in Python 3.2.3 due to an incomplete implementation. The implementation now works even if the symlink is created in a location other than the current directory.

11 years agoIssue #15392: Create a unittest framework for IDLE.
Terry Jan Reedy [Tue, 28 May 2013 01:32:03 +0000 (21:32 -0400)]
Issue #15392: Create a unittest framework for IDLE.
Preliminary patch by Rajagopalasarma Jayakrishnan.

11 years agoFix typo in embedding doc and update examples to 3.3.
Ned Deily [Mon, 27 May 2013 01:53:39 +0000 (18:53 -0700)]
Fix typo in embedding doc and update examples to 3.3.

11 years agoIssue #18063: fix some struct specifications in the tests for sys.getsizeof().
Antoine Pitrou [Sat, 25 May 2013 21:47:29 +0000 (23:47 +0200)]
Issue #18063: fix some struct specifications in the tests for sys.getsizeof().

11 years agoMention __cached__ in the import ref.
Brett Cannon [Sat, 25 May 2013 15:32:50 +0000 (11:32 -0400)]
Mention __cached__ in the import ref.

11 years agoAdd a missing parenthesis.
Brett Cannon [Sat, 25 May 2013 15:28:20 +0000 (11:28 -0400)]
Add a missing parenthesis.

11 years agoVarious tweaks to importlib docs.
Brett Cannon [Sat, 25 May 2013 15:26:11 +0000 (11:26 -0400)]
Various tweaks to importlib docs.

11 years agoClean-up duplicated code in tests
Eli Bendersky [Sat, 25 May 2013 14:12:14 +0000 (07:12 -0700)]
Clean-up duplicated code in tests

11 years agoIssue #13612: handle unknown encodings without a buffer overflow.
Eli Bendersky [Sat, 25 May 2013 12:25:48 +0000 (05:25 -0700)]
Issue #13612: handle unknown encodings without a buffer overflow.

This affects pyexpat and _elementtree. PyExpat_CAPI now exposes a new
function - DefaultUnknownEncodingHandler.

Based on a patch by Serhiy Storchaka.

11 years agoFix test_bad_address on Ubuntu 13.04
Antoine Pitrou [Sat, 25 May 2013 11:08:13 +0000 (13:08 +0200)]
Fix test_bad_address on Ubuntu 13.04

11 years agoindicate that read/write work with bytes (closes #18009)
Benjamin Peterson [Fri, 24 May 2013 21:35:57 +0000 (14:35 -0700)]
indicate that read/write work with bytes (closes #18009)

11 years agoIssue #17953: document that sys.modules shouldn't be replaced (thanks
Brett Cannon [Fri, 24 May 2013 12:05:07 +0000 (08:05 -0400)]
Issue #17953: document that sys.modules shouldn't be replaced (thanks
to interp->modules) and that deleting essential items from the dict
can cause Python to blow up.

Thanks to Terry Reedy for coming up with initial wording and Yogesh
Chaudhari for coming up with a patch using that wording in parallel to
my own patch.

11 years agoIssue #17269: Workaround for a platform bug in getaddrinfo on OSX
Ronald Oussoren [Fri, 24 May 2013 11:47:37 +0000 (13:47 +0200)]
Issue #17269: Workaround for a platform bug in getaddrinfo on OSX

Without this patch socket.getaddrinfo crashed when called
with some unusual argument combinations.

11 years agoFix #18007 : Document CookieJar.add_cookie_header request parameter changes in 3.3
Senthil Kumaran [Thu, 23 May 2013 12:27:38 +0000 (05:27 -0700)]
Fix #18007 : Document CookieJar.add_cookie_header request parameter changes in 3.3

11 years agoIssue 17844: Clarify meaning of different codec tables
Nick Coghlan [Thu, 23 May 2013 10:24:02 +0000 (20:24 +1000)]
Issue 17844: Clarify meaning of different codec tables

11 years agoIssue #18031: %-formatting isn't dead yet and might pull through.
Raymond Hettinger [Thu, 23 May 2013 07:14:47 +0000 (00:14 -0700)]
Issue #18031:  %-formatting isn't dead yet and might pull through.

11 years agoIssue #17532: Always include Options menu for IDLE on OS X.
Ned Deily [Wed, 22 May 2013 22:19:40 +0000 (15:19 -0700)]
Issue #17532: Always include Options menu for IDLE on OS X.
Patch by Guilherme Simões.

11 years agoadd test for inequality
Benjamin Peterson [Wed, 22 May 2013 20:27:25 +0000 (13:27 -0700)]
add test for inequality

11 years agoIssue #16986: ElementTree now correctly parses a string input not only when
Serhiy Storchaka [Wed, 22 May 2013 14:07:51 +0000 (17:07 +0300)]
Issue #16986: ElementTree now correctly parses a string input not only when
an internal XML encoding is UTF-8 or US-ASCII.

11 years agoIssue #17844: Add links to encoders and decoders for bytes-to-bytes codecs.
Serhiy Storchaka [Wed, 22 May 2013 12:33:09 +0000 (15:33 +0300)]
Issue #17844: Add links to encoders and decoders for bytes-to-bytes codecs.

11 years ago#17973: fix technical inaccuracy in faq entry (it now passes doctest).
R David Murray [Tue, 21 May 2013 15:44:41 +0000 (11:44 -0400)]
#17973: fix technical inaccuracy in faq entry (it now passes doctest).

11 years ago#14146: Highlight source line while debugging on Windows.
Roger Serwy [Tue, 21 May 2013 03:13:39 +0000 (22:13 -0500)]
#14146: Highlight source line while debugging on Windows.

11 years agoIssue #17743: Now use extended syntax of set command in .bat files.
Vinay Sajip [Mon, 20 May 2013 22:38:12 +0000 (15:38 -0700)]
Issue #17743: Now use extended syntax of set command in .bat files.

11 years agoIssue #17744: Now unset VIRTUAL_ENV environment variable when deactivating.
Vinay Sajip [Mon, 20 May 2013 22:28:52 +0000 (15:28 -0700)]
Issue #17744: Now unset VIRTUAL_ENV environment variable when deactivating.

11 years agoIssue #18026: fix ctypes doc typo
Ned Deily [Mon, 20 May 2013 21:29:44 +0000 (14:29 -0700)]
Issue #18026: fix ctypes doc typo

11 years ago#17973: Add FAQ entry for ([],)[0] += [1] both extending and raising.
R David Murray [Mon, 20 May 2013 14:32:46 +0000 (10:32 -0400)]
#17973: Add FAQ entry for ([],)[0] += [1] both extending and raising.

This has come up often enough now on the tracker that it deserves a FAQ entry.

11 years ago#14097: improve the "introduction" page of the tutorial.
Ezio Melotti [Mon, 20 May 2013 05:12:32 +0000 (08:12 +0300)]
#14097: improve the "introduction" page of the tutorial.

11 years agoadd recursive repr test
Benjamin Peterson [Mon, 20 May 2013 02:39:38 +0000 (19:39 -0700)]
add recursive repr test

11 years agoIssue #17989: fix typo in error message
Eli Bendersky [Sun, 19 May 2013 23:59:59 +0000 (16:59 -0700)]
Issue #17989: fix typo in error message

11 years agoTry to make test more reliable (saw some sporadic failures on buildbots)
Antoine Pitrou [Sun, 19 May 2013 13:55:40 +0000 (15:55 +0200)]
Try to make test more reliable (saw some sporadic failures on buildbots)

11 years agoIssue #11995: test_pydoc doesn't import all sys.path modules anymore.
Antoine Pitrou [Sun, 19 May 2013 13:44:54 +0000 (15:44 +0200)]
Issue #11995: test_pydoc doesn't import all sys.path modules anymore.

11 years agoIssue #17812: Fixed quadratic complexity of base64.b32encode().
Serhiy Storchaka [Sun, 19 May 2013 08:41:15 +0000 (11:41 +0300)]
Issue #17812: Fixed quadratic complexity of base64.b32encode().

11 years agoIssue #17901: fix TreeBuilder construction for an explicit element_factory=None
Eli Bendersky [Sat, 18 May 2013 22:47:16 +0000 (15:47 -0700)]
Issue #17901: fix TreeBuilder construction for an explicit element_factory=None

Based on report and patch by Aaron Oakley.

11 years agoClose file before reopening to keep Windows happy in test_sax.
Richard Oudkerk [Sat, 18 May 2013 17:11:30 +0000 (18:11 +0100)]
Close file before reopening to keep Windows happy in test_sax.

11 years agoIssue #17980: Fix possible abuse of ssl.match_hostname() for denial of service using...
Antoine Pitrou [Sat, 18 May 2013 15:56:42 +0000 (17:56 +0200)]
Issue #17980: Fix possible abuse of ssl.match_hostname() for denial of service using certificates with many wildcards (CVE-2013-2099).

11 years agoIssue #17989: element_setattro returned incorrect error value.
Eli Bendersky [Sat, 18 May 2013 14:52:34 +0000 (07:52 -0700)]
Issue #17989: element_setattro returned incorrect error value.

This caused an exception to be raised later than expected.

11 years agoUpdate docstring for _asdict() to indicate it is obsolete.
Raymond Hettinger [Fri, 17 May 2013 23:43:14 +0000 (16:43 -0700)]
Update docstring for _asdict() to indicate it is obsolete.
Use the cleaner looking @property style for __dict__.
Move _replace() to be just after make() to indicate that
it is a core method on named tuples.

11 years agoonly recursively expand in the format spec (closes #17644)
Benjamin Peterson [Fri, 17 May 2013 22:34:30 +0000 (17:34 -0500)]
only recursively expand in the format spec (closes #17644)

11 years agoIssue #17563: Fix dict resize performance regression.
Raymond Hettinger [Fri, 17 May 2013 10:01:13 +0000 (03:01 -0700)]
Issue #17563: Fix dict resize performance regression.

11 years agoRemove unnecessary exception handler.
Raymond Hettinger [Fri, 17 May 2013 09:28:33 +0000 (02:28 -0700)]
Remove unnecessary exception handler.

11 years agoIgnore Mac OS X entries for .DS_Store
Raymond Hettinger [Fri, 17 May 2013 09:23:16 +0000 (02:23 -0700)]
Ignore Mac OS X entries for .DS_Store

11 years agoFix some bugs in Tools/scripts/abitype.py.
Serhiy Storchaka [Fri, 17 May 2013 07:17:43 +0000 (10:17 +0300)]
Fix some bugs in Tools/scripts/abitype.py.

11 years agomove definition to top of block
Benjamin Peterson [Fri, 17 May 2013 00:38:22 +0000 (19:38 -0500)]
move definition to top of block

11 years agoIssue #17981: Closed socket on error in SysLogHandler.
Vinay Sajip [Thu, 16 May 2013 21:57:02 +0000 (22:57 +0100)]
Issue #17981: Closed socket on error in SysLogHandler.

11 years agoC89 declaration compliance
Benjamin Peterson [Thu, 16 May 2013 20:29:44 +0000 (15:29 -0500)]
C89 declaration compliance

11 years agoAdd Nick Sloan for his contribution to #17732
Brian Curtin [Thu, 16 May 2013 16:59:29 +0000 (11:59 -0500)]
Add Nick Sloan for his contribution to #17732

11 years agocomplain about "global __class__" in a class body (closes #17983)
Benjamin Peterson [Wed, 15 May 2013 21:17:25 +0000 (16:17 -0500)]
complain about "global __class__" in a class body (closes #17983)

11 years agopost-release update.
Georg Brandl [Wed, 15 May 2013 17:42:39 +0000 (19:42 +0200)]
post-release update.

11 years ago- Fix typos in the multiprocessing module.
doko@ubuntu.com [Wed, 15 May 2013 16:06:56 +0000 (18:06 +0200)]
- Fix typos in the multiprocessing module.

11 years ago- Issue #17754: Make ctypes.util.find_library() independent of the locale.
doko@ubuntu.com [Wed, 15 May 2013 16:02:13 +0000 (18:02 +0200)]
- Issue #17754: Make ctypes.util.find_library() independent of the locale.

11 years agoMisc/NEWS: Add 3.3.3 section and move entries made after the 3.3.2 release
doko@ubuntu.com [Wed, 15 May 2013 16:00:05 +0000 (18:00 +0200)]
Misc/NEWS: Add 3.3.3 section and move entries made after the 3.3.2 release
to the new section.

11 years agowhen arguments are cells clear the locals slot (backport of #17927)
Benjamin Peterson [Wed, 15 May 2013 03:31:26 +0000 (22:31 -0500)]
when arguments are cells clear the locals slot (backport of #17927)

11 years ago- Issue #17977: The documentation for the cadefault argument's default value
Barry Warsaw [Tue, 14 May 2013 15:35:16 +0000 (11:35 -0400)]
- Issue #17977: The documentation for the cadefault argument's default value
  in urllib.request.urlopen() is fixed to match the code.

11 years agoprevent double free in cleanup code (#17968)
Benjamin Peterson [Tue, 14 May 2013 00:55:40 +0000 (19:55 -0500)]
prevent double free in cleanup code (#17968)

11 years agoFix ResourceWarnings in test_sax
Antoine Pitrou [Mon, 13 May 2013 20:34:21 +0000 (22:34 +0200)]
Fix ResourceWarnings in test_sax

11 years agoSilence unclosed open file ResourceWarning.
Terry Jan Reedy [Mon, 13 May 2013 20:07:44 +0000 (16:07 -0400)]
Silence unclosed open file ResourceWarning.

11 years agoComplete 2 to 3 conversion
Terry Jan Reedy [Mon, 13 May 2013 19:39:24 +0000 (15:39 -0400)]
Complete 2 to 3 conversion

11 years agoIssue #17968: Fix memory leak in os.listxattr().
Antoine Pitrou [Mon, 13 May 2013 17:46:29 +0000 (19:46 +0200)]
Issue #17968: Fix memory leak in os.listxattr().

11 years agouse correct format code for exceptions
Benjamin Peterson [Mon, 13 May 2013 00:01:52 +0000 (19:01 -0500)]
use correct format code for exceptions

11 years agoAdded tag v3.3.2 for changeset d047928ae3f6
Georg Brandl [Sun, 12 May 2013 17:55:55 +0000 (19:55 +0200)]
Added tag v3.3.2 for changeset d047928ae3f6

11 years agoCloses #17962: Build with OpenSSL 1.0.1e on Windows. v3.3.2
Georg Brandl [Sun, 12 May 2013 17:50:34 +0000 (19:50 +0200)]
Closes #17962: Build with OpenSSL 1.0.1e on Windows.

11 years agomerge
Georg Brandl [Sun, 12 May 2013 17:44:21 +0000 (19:44 +0200)]
merge

11 years agoIssue #17606: Fixed support of encoded byte strings in the XMLGenerator
Serhiy Storchaka [Sun, 12 May 2013 14:31:16 +0000 (17:31 +0300)]
Issue #17606: Fixed support of encoded byte strings in the XMLGenerator
characters() and ignorableWhitespace() methods.  Original patch by Sebastian
Ortiz Vasquez.

11 years agobump to 3.3.2
Georg Brandl [Sun, 12 May 2013 10:51:38 +0000 (12:51 +0200)]
bump to 3.3.2

11 years agoCloses issue #17732: ignore install-directory specific options in
Georg Brandl [Sun, 12 May 2013 10:36:07 +0000 (12:36 +0200)]
Closes issue #17732: ignore install-directory specific options in
distutils.cfg when a venv is active.

11 years agoBack out patch for #1159051, which caused backwards compatibility problems.
Georg Brandl [Sun, 12 May 2013 09:57:26 +0000 (11:57 +0200)]
Back out patch for #1159051, which caused backwards compatibility problems.

11 years agomerge with 3.2
Georg Brandl [Sun, 12 May 2013 09:52:22 +0000 (11:52 +0200)]
merge with 3.2

11 years agomerge with 3.2
Georg Brandl [Sun, 12 May 2013 09:51:26 +0000 (11:51 +0200)]
merge with 3.2

11 years agoIssue #17915: Fix interoperability of xml.sax with file objects returned by
Georg Brandl [Sun, 12 May 2013 09:41:12 +0000 (11:41 +0200)]
Issue #17915: Fix interoperability of xml.sax with file objects returned by
codecs.open().

11 years agoIssue #1159051: Back out a fix for handling corrupted gzip files that
Georg Brandl [Sun, 12 May 2013 09:29:27 +0000 (11:29 +0200)]
Issue #1159051: Back out a fix for handling corrupted gzip files that
broke backwards compatibility.

11 years agomerge heads
Georg Brandl [Sun, 12 May 2013 09:24:47 +0000 (11:24 +0200)]
merge heads

11 years agoprevent IDLE from trying to close when sys.stdin is reassigned (#17838)
Benjamin Peterson [Sun, 12 May 2013 03:24:28 +0000 (22:24 -0500)]
prevent IDLE from trying to close when sys.stdin is reassigned (#17838)

11 years agoonly close non-None files
Benjamin Peterson [Sat, 11 May 2013 21:29:03 +0000 (16:29 -0500)]
only close non-None files

11 years ago-Wformat is needed by gcc 4.8 (closes #17547)
Benjamin Peterson [Sat, 11 May 2013 18:00:05 +0000 (13:00 -0500)]
-Wformat is needed by gcc 4.8 (closes #17547)