]>
granicus.if.org Git - php/log
Nikita Popov [Thu, 17 Sep 2020 09:35:03 +0000 (11:35 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
mysql: native mysql-8.0 uses _Bool
mysqli: use native api
Nikita Popov [Thu, 17 Sep 2020 09:32:01 +0000 (11:32 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
mysql: native mysql-8.0 uses _Bool
mysqli: use native api
Daniel Black [Sun, 13 Sep 2020 04:09:49 +0000 (14:09 +1000)]
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
The mysqlclient_r library exists in mysql-5.6 for compatibility only.
Later versions have it removed.
Daniel Black [Sat, 12 Sep 2020 05:29:23 +0000 (15:29 +1000)]
mysql: native mysql-8.0 uses _Bool
MySQL-8.0 removes option MYSQLI_OPT_SSL_VERIFY_SERVER_CERT
Daniel Black [Sat, 29 Aug 2020 07:18:57 +0000 (17:18 +1000)]
mysqli: use native api
Tested with:
* mysql-5.6.49-linux-glibc2.12-x86_64
* mysql-5.7.31-linux-glibc2.12-x86_64
* mysql-8.0.21-linux-glibc2.17-x86_64
* mariadb-10.5.6
configure --with-mysqli=/usr/local/$version/bin/mysql_config --with-pdo-mysql=/usr/local/$version
MySQL-8.0 removed my_bool
Some options where deprecated in mysql-8.0
MY_CHARSET_INFO used with exposed api mysql_get_character_set_info
rather than internal structures.
Máté Kocsis [Wed, 16 Sep 2020 20:33:23 +0000 (22:33 +0200)]
Fix a few UNKNOWN default values in ext/pgsql
Closes GH-6149
Dmitry Stogov [Thu, 17 Sep 2020 08:55:50 +0000 (11:55 +0300)]
Fixed memory leak in ext/spl/tests/bug77263.phpt
Nikita Popov [Thu, 17 Sep 2020 08:31:48 +0000 (10:31 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
ext/soap: Compare Set-Cookie header case-insensitively
Nikita Popov [Thu, 17 Sep 2020 08:31:30 +0000 (10:31 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
ext/soap: Compare Set-Cookie header case-insensitively
Gabríel Arthúr Pétursson [Wed, 16 Sep 2020 14:18:00 +0000 (14:18 +0000)]
ext/soap: Compare Set-Cookie header case-insensitively
Closes GH-6143.
Nikita Popov [Thu, 17 Sep 2020 08:14:19 +0000 (10:14 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #80083
Nikita Popov [Thu, 17 Sep 2020 08:13:42 +0000 (10:13 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #80083
Nikita Popov [Thu, 17 Sep 2020 08:12:10 +0000 (10:12 +0200)]
Fixed bug #80083
Add db2_execute() to the list of functions accessing the local
scope. Ideally the API wouldn't do that, but it seems most
pragmatic to address this on the opcache side at this point.
Nikita Popov [Thu, 17 Sep 2020 07:59:44 +0000 (09:59 +0200)]
Fixed bug #80109
Skip over leading EXT_NOP, if it exists.
Dharman [Wed, 16 Sep 2020 14:41:02 +0000 (15:41 +0100)]
mysqli: Promote warning in field_seek
Aligning the behaviour of fetch_field and field_seek.
Máté Kocsis [Wed, 16 Sep 2020 19:38:30 +0000 (21:38 +0200)]
Change int parameter types to bool when the parameter behaves as bool
Closes GH-6148
Máté Kocsis [Wed, 16 Sep 2020 19:28:27 +0000 (21:28 +0200)]
Generate arginfos
Máté Kocsis [Wed, 16 Sep 2020 19:27:01 +0000 (21:27 +0200)]
Display string default values in stubs more uniformly
Settling on using quoted string
Máté Kocsis [Wed, 16 Sep 2020 19:19:36 +0000 (21:19 +0200)]
Display types in stubs more uniformly
In preparation for generating method signatures for the manual.
This change gets rid of bogus false|null return types, a few unnecessary trailing backslashes, and settles on using ? when possible for nullable types.
Nikita Popov [Wed, 16 Sep 2020 09:04:56 +0000 (11:04 +0200)]
Accept GMP|string|int union in GMP functions
This changes GMP functions to accept a GMP|string|int union with
standard semantics (and thus also uses it in function signatures).
Relative to the previous behavior, this means that GMP functions
in weak mode now also accept float and null, and in strict mode no
longer accept bool, and have full type information.
Closes GH-6139.
Máté Kocsis [Wed, 16 Sep 2020 11:51:36 +0000 (13:51 +0200)]
Update xmlreader arginfo hash
My git client (GitHub Desktop) decided to commit and push my staged changes, so arginfo generation was not done with the previous commit.
Máté Kocsis [Wed, 16 Sep 2020 11:47:58 +0000 (13:47 +0200)]
Update php_xmlreader.stub.php
Máté Kocsis [Wed, 16 Sep 2020 11:45:13 +0000 (13:45 +0200)]
XMLReader::getAttributeNs() can no longer return false
Dmitry Stogov [Wed, 16 Sep 2020 11:22:36 +0000 (14:22 +0300)]
Optimize code for FETCH_THIS + INIT_METHOD_CALL/ASSIGN_OBJ_OP/etc
Dharman [Tue, 15 Sep 2020 17:42:38 +0000 (18:42 +0100)]
Changed the wording of the error message
"cannot be used in MYSQLI_USE_RESULT mode" sounds more correct than "cannot be used with MYSQLI_USE_RESULT"
Closes GH-6137.
Nikita Popov [Wed, 16 Sep 2020 08:42:10 +0000 (10:42 +0200)]
Remove unused GMP_ABS() macro
Dmitry Stogov [Wed, 16 Sep 2020 09:04:29 +0000 (12:04 +0300)]
Exclude trait methods from call-graph
Nikita Popov [Wed, 16 Sep 2020 08:28:28 +0000 (10:28 +0200)]
Avoid ubsan warning due to memcpy null
This showed up in ext/mysqli/tests/mysqli_change_user.phpt on azure
today. Not seeing it locally though, and also not sure why it decided
to show up now...
Matteo Beccati [Wed, 16 Sep 2020 08:04:14 +0000 (10:04 +0200)]
Fix test
follow-up to
7a95e94 for MySQL < 5.6
Dmitry Stogov [Wed, 16 Sep 2020 07:49:54 +0000 (10:49 +0300)]
Fixed incorrect constant string access
Dmitry Stogov [Wed, 16 Sep 2020 07:25:36 +0000 (10:25 +0300)]
JIT for INIT_METHOD_CALL
Remi Collet [Wed, 16 Sep 2020 05:58:53 +0000 (07:58 +0200)]
missing fix for test for new param. name
George Peter Banyard [Fri, 22 May 2020 14:43:07 +0000 (16:43 +0200)]
Add some ValueErrors to ext/date
Closes GH-5613
Sara Golemon [Tue, 15 Sep 2020 18:38:15 +0000 (18:38 +0000)]
Update NEWS for 8.0.0RC1
Sara Golemon [Tue, 15 Sep 2020 18:30:23 +0000 (18:30 +0000)]
Update NEWS for PHP 8.0.0beta4
Bob Weinand [Tue, 15 Sep 2020 18:07:25 +0000 (20:07 +0200)]
Fix OSS Fuzz issue: yielding from an aborted generator
George Peter Banyard [Fri, 3 Jul 2020 11:43:29 +0000 (13:43 +0200)]
Promote warnings to Error in MySQLi extension
Closes GH-5803
Nikita Popov [Tue, 15 Sep 2020 14:08:14 +0000 (16:08 +0200)]
Fix uninitialized run-time cache when resolving named param defaults
Fixes oss-fuzz #25676.
Nikita Popov [Tue, 15 Sep 2020 13:43:31 +0000 (15:43 +0200)]
Fix undef var exception handling in JMP_NULL
We need to initialize the result variable in the exceptional
case as well.
Fixes oss-fuzz #25526.
Nikita Popov [Tue, 15 Sep 2020 13:26:56 +0000 (15:26 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix assumption about property guard hash value
Nikita Popov [Tue, 15 Sep 2020 13:25:22 +0000 (15:25 +0200)]
Fix assumption about property guard hash value
The "member" string here does not necessarily have a pre-calculated
hash value. In particular this is not the case if the class has no
properties.
Fixes oss-fuzz #25546.
Remi Collet [Tue, 15 Sep 2020 11:54:27 +0000 (13:54 +0200)]
fix mbfl function prototypes
re-add mbfl_convert_filter_feed API
re-add pointer cast
Nikita Popov [Tue, 15 Sep 2020 13:06:56 +0000 (15:06 +0200)]
Fix compile-time/run-time discrepancies with unary operators
This addresses two issues:
* ~ throws for a number of types, and we should not compile-time
evaluate in that case. Add a check similar to what we do for
binary ops.
* Unary +/- may produce a different error message due to
canonicalization of the constant operand to the RHS. To avoid
this, put the constant operand on the RHS right away.
Fixes oss-fuzz #25649.
Dmitry Stogov [Tue, 15 Sep 2020 12:57:57 +0000 (15:57 +0300)]
Tracing JIT for INIT_DYNAMIC_CALL (closure only)
Máté Kocsis [Tue, 15 Sep 2020 12:49:30 +0000 (14:49 +0200)]
Remove unintendedly committed test
Máté Kocsis [Sat, 12 Sep 2020 21:53:15 +0000 (23:53 +0200)]
Adjust ext/openssl parameter names
Closes GH-6121
Máté Kocsis [Thu, 10 Sep 2020 11:28:18 +0000 (13:28 +0200)]
Promote a few remaining errors in ext/standard
Closes GH-6110
George Peter Banyard [Tue, 8 Sep 2020 14:59:35 +0000 (16:59 +0200)]
Promote warnings to Error in SNMP extension
Gabriel Caruso [Mon, 14 Sep 2020 14:06:18 +0000 (16:06 +0200)]
Check `ReflectionReference::fromArrayElement` with union types
ReflectionReference::fromArrayElement(array $array, int|string $key): ?ReflectionReference
is going to be its official signature for PHP 8.0.
Closes GH-5651
George Peter Banyard [Sat, 12 Sep 2020 23:08:18 +0000 (01:08 +0200)]
Promote warning to Error in ODBC extension
Closes GH-6123
George Peter Banyard [Sat, 12 Sep 2020 01:00:53 +0000 (03:00 +0200)]
Use ValueError instead of exceptions in SPL extension
George Peter Banyard [Fri, 11 Sep 2020 16:58:32 +0000 (18:58 +0200)]
Use normal error in SPL for uninitialized objects
George Peter Banyard [Fri, 11 Sep 2020 16:35:50 +0000 (18:35 +0200)]
Use normal error in SPL for 'An iterator cannot be used with foreach by reference'
George Peter Banyard [Sat, 12 Sep 2020 21:53:52 +0000 (23:53 +0200)]
Convert warning to assetion in MySQL PDO driver
Closes GH-6120
Máté Kocsis [Tue, 15 Sep 2020 10:46:40 +0000 (12:46 +0200)]
Add missing param type to pcre reflection test
Nikita Popov [Tue, 15 Sep 2020 09:26:59 +0000 (11:26 +0200)]
Fix preg_replace_callback_array() with array subject
Apparently this "feature" was completely untested...
Nikita Popov [Tue, 15 Sep 2020 09:38:40 +0000 (11:38 +0200)]
Add GC_TRY_ADDREF macro
That adds a ref if not immutable. Also audit uses of GC_IMMUTABLE
to either use GC_TRY_ADDREF or GC_TRY_PROTECT_RECURSION.
Christoph M. Becker [Tue, 15 Sep 2020 08:59:24 +0000 (10:59 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
7.3.24 is next
Christoph M. Becker [Tue, 15 Sep 2020 08:57:39 +0000 (10:57 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
7.3.24 is next
Christoph M. Becker [Tue, 15 Sep 2020 08:51:41 +0000 (10:51 +0200)]
7.3.24 is next
Nikita Popov [Tue, 15 Sep 2020 08:40:46 +0000 (10:40 +0200)]
Fix observer leak
Make sure to startup observer infrastructure before we register
the first observer...
Derick Rethans [Tue, 15 Sep 2020 08:37:16 +0000 (09:37 +0100)]
Merge branch 'PHP-7.4' into master
Derick Rethans [Tue, 15 Sep 2020 08:36:57 +0000 (09:36 +0100)]
The next release here will be 7.4.12
Dmitry Stogov [Tue, 15 Sep 2020 06:39:41 +0000 (09:39 +0300)]
micro-optimization
Dmitry Stogov [Tue, 15 Sep 2020 06:39:27 +0000 (09:39 +0300)]
Renumber ZEND_ACC_... constants
George Peter Banyard [Sat, 12 Sep 2020 15:38:02 +0000 (17:38 +0200)]
Promote some warnings to ValueError in OCI8
Closes GH-6116
Co-authored-by: Christopher Jones <sixd@php.net>
Bob Weinand [Mon, 14 Sep 2020 21:05:28 +0000 (23:05 +0200)]
Fix use-after-free with yield from in yield_from_multi_tree_single_nodes.phpt
Prevent release of generator children during destruction
Christoph M. Becker [Mon, 14 Sep 2020 20:36:00 +0000 (22:36 +0200)]
Merge branch 'PHP-7.4' into master
* PHP-7.4:
Avoid segfault if module/extension version is not defined
Christoph M. Becker [Mon, 14 Sep 2020 20:34:58 +0000 (22:34 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Avoid segfault if module/extension version is not defined
Christoph M. Becker [Mon, 14 Sep 2020 20:31:15 +0000 (22:31 +0200)]
Avoid segfault if module/extension version is not defined
Dmitry Stogov [Mon, 14 Sep 2020 20:30:49 +0000 (23:30 +0300)]
Support for reference
Dmitry Stogov [Mon, 14 Sep 2020 19:26:34 +0000 (22:26 +0300)]
Simplify zend_jit_pre/post_inc/dec_typed_ref() helpers
Bob Weinand [Sun, 13 Sep 2020 22:04:45 +0000 (00:04 +0200)]
Fix crashes with unproper cleaning of repeated yield from
Closes GH-6130
Benjamin Eberlei [Mon, 14 Sep 2020 12:05:54 +0000 (14:05 +0200)]
Rename zend_error_notify APIs to zend_observer_error*
Dmitry Stogov [Mon, 14 Sep 2020 16:36:15 +0000 (19:36 +0300)]
JIT for PRE/POST_INC/DEC_OBJ
George Peter Banyard [Sun, 13 Sep 2020 03:31:01 +0000 (05:31 +0200)]
Promote warnings to Errors in PostgreSQL extension
Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP
Closes GH-6129
Larry Garfield [Wed, 26 Aug 2020 22:20:22 +0000 (17:20 -0500)]
Update array parameter names for named parameters
* The array "subject" of a function gets called $array.
* Further parameters should be self-descriptive if used
as a named parameter, and a full word, not an abbreviation.
* If there is a "bunch more arrays" variadic, it gets
called $arrays (because that's what was already there).
* A few functions have a variadic "a bunch more arrays,
and then a callable", and were already called $rest.
I left those as is and died a little inside.
* Any callable provided to an array function that acts
on the array is called $callback. (Nearly all were already,
I just fixed the one or two outliers.)
* array_multisort() is beyond help so I ran screaming.
Nikita Popov [Mon, 14 Sep 2020 13:49:49 +0000 (15:49 +0200)]
Fixed bug #80096
We shouldn't assume that call->prev_execute_data is NULL here. The
value needs to be preserved for call chains.
George Peter Banyard [Sat, 12 Sep 2020 21:24:30 +0000 (23:24 +0200)]
Promote Warnings to Error in PostgreSQL PDO driver
Closes GH-6119
George Peter Banyard [Sat, 12 Sep 2020 22:43:00 +0000 (00:43 +0200)]
Convert Division by 0 warnings to Error per the Engine Warning RFC
Closes GH-6125
Dmitry Stogov [Mon, 14 Sep 2020 10:31:41 +0000 (13:31 +0300)]
JIT for ASSIGN_OBJ_OP
Nikita Popov [Mon, 14 Sep 2020 10:15:24 +0000 (12:15 +0200)]
Convert E_ERROR to Error exception in mysqli_result iterator
The same condition uses Error exceptions in lots of other classes.
Nikita Popov [Mon, 14 Sep 2020 10:02:56 +0000 (12:02 +0200)]
Drop some dead code
Máté Kocsis [Mon, 14 Sep 2020 09:59:51 +0000 (11:59 +0200)]
Slightly improve error handling in DatePeriod::__construct()
Máté Kocsis [Mon, 14 Sep 2020 09:59:32 +0000 (11:59 +0200)]
Declare array|int and object-of-class|int types in stubs
Closes GH-6081
Co-Authored-By: Nikita Popov <nikic@php.net>
Máté Kocsis [Mon, 14 Sep 2020 09:52:33 +0000 (11:52 +0200)]
Make mb_send_mail() consistent with mail()
The $additional_headers parameter shouldn't accept null.
Máté Kocsis [Mon, 14 Sep 2020 09:46:14 +0000 (11:46 +0200)]
Fix a few stub parameter types in ext/standard
Máté Kocsis [Mon, 14 Sep 2020 09:40:27 +0000 (11:40 +0200)]
Add Z_PARAM_OBJ_OF_CLASS ZPP macro
Christoph M. Becker [Mon, 14 Sep 2020 08:13:07 +0000 (10:13 +0200)]
Unmark tests as XFAIL on Windows
This issue has been resolved[1], so the tests are expected to pass on
Windows again.
[1] <https://github.com/php/php-src/commit/
0a03291b51e7cf199c06ba4ae914277ce0ac4202 >
Dmitry Stogov [Mon, 14 Sep 2020 07:41:22 +0000 (10:41 +0300)]
Allocate Windows 64 shadow stack space
Benjamin Eberlei [Sat, 12 Sep 2020 15:25:16 +0000 (17:25 +0200)]
Remove @jit Docblock support for now due to dev-time constraints
George Peter Banyard [Sat, 12 Sep 2020 21:41:25 +0000 (23:41 +0200)]
Convert warnings to assetions in OCI PDO driver
Closes GH-6118
Christoph M. Becker [Sun, 13 Sep 2020 13:37:46 +0000 (15:37 +0200)]
Mark tests as XFAIL on Windows
These tests segfault with tracing JIT on Windows as of a recent
commit[1]. A link to a backtrace is available in a comment[2]. For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.
[1] <https://github.com/php/php-src/commit/
7b0a05316957982f9e4cc021aec5c20cc80f7542 >
[2] <https://github.com/php/php-src/commit/
7b0a05316957982f9e4cc021aec5c20cc80f7542 #commitcomment-
42267637 >
Christoph M. Becker [Sun, 13 Sep 2020 13:35:22 +0000 (15:35 +0200)]
Mark tests as XFAIL on Windows
These tests segfault with tracing JIT on Windows as of a recent
commit[1]. A link to a backtrace is available in a comment[2]. For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.
[1] <https://github.com/php/php-src/commit/
817ae414962480d133ed76618b88b3e7ba482718 >
[2] <https://github.com/php/php-src/commit/
817ae414962480d133ed76618b88b3e7ba482718 #commitcomment-
42227420 >
Matteo Beccati [Sun, 13 Sep 2020 08:02:13 +0000 (10:02 +0200)]
Fix broken test
Since
e8e4ddce
George Peter Banyard [Fri, 11 Sep 2020 16:10:38 +0000 (18:10 +0200)]
Use Error for uninitialized SQLite object
Closes GH-6113
George Peter Banyard [Fri, 11 Sep 2020 16:12:59 +0000 (18:12 +0200)]
Fix SKIPIF section for SQLite3 test
Test is borked if the posix_geteui() function is unavailable.
Máté Kocsis [Thu, 20 Aug 2020 14:03:34 +0000 (16:03 +0200)]
Improve parameter handling in ext/openssl
Closes GH-6025
Máté Kocsis [Sat, 12 Sep 2020 17:09:02 +0000 (19:09 +0200)]
Fix prototype of get_active_function_or_method_name()
George Peter Banyard [Sat, 12 Sep 2020 16:41:25 +0000 (18:41 +0200)]
Normalize behaviour of DNS function on Windows
This is a follow-up on commit
4a438b44694d4caf86d8e57266ed2fc2f4ae6213
Add some tests to hopefully not forget it next time