]> granicus.if.org Git - php/log
php
13 years ago- Fixed bug #54395 (Phar::mount() crashes when calling with wrong parameters)
Felipe Pena [Sat, 26 Mar 2011 17:02:34 +0000 (17:02 +0000)]
- Fixed bug #54395 (Phar::mount() crashes when calling with wrong parameters)

13 years agoUpdate of mysqlnd version. This has been forgotten when introducing set_autocommit...
Ulf Wendel [Fri, 25 Mar 2011 10:45:28 +0000 (10:45 +0000)]
Update of mysqlnd version. This has been forgotten when introducing set_autocommit, tx_commit, tx_rollback calls (http://svn.php.net/viewvc?view=revision&revision=308669).

13 years agofix buffer overflow - overwriting with 0x0, due to
Andrey Hristov [Thu, 24 Mar 2011 16:12:18 +0000 (16:12 +0000)]
fix buffer overflow - overwriting with 0x0, due to
unchecked buffer size. This can be easily workarouned on
existing unpatched systems by increasing
mysqlnd.net_cmd_buffer_size ini variable to more than 8k

13 years agoLimit test with 65k params, should crash mysqlnd
Ulf Wendel [Thu, 24 Mar 2011 13:40:06 +0000 (13:40 +0000)]
Limit test with 65k params, should crash mysqlnd

13 years agoFixed a crash inside dtor for error handling.
Ilia Alshanetsky [Thu, 24 Mar 2011 12:57:38 +0000 (12:57 +0000)]
Fixed a crash inside dtor for error handling.

13 years ago- Fixed bug #54292 (Wrong parameter causes crash in SplFileObject::__construct())
Felipe Pena [Wed, 23 Mar 2011 22:46:04 +0000 (22:46 +0000)]
- Fixed bug #54292 (Wrong parameter causes crash in SplFileObject::__construct())

13 years agoFixed bug #54084 (Fix apxs Apache version test to work with Oracle HTTP Server) ...
Christopher Jones [Wed, 23 Mar 2011 18:56:47 +0000 (18:56 +0000)]
Fixed bug #54084 (Fix apxs Apache version test to work with Oracle HTTP Server) (Chris Jones)

13 years agoFix compressed build, make it easier
Andrey Hristov [Wed, 23 Mar 2011 17:14:28 +0000 (17:14 +0000)]
Fix compressed build, make it easier

13 years agoImplement request #54355 (Test for de_DE doesn't use UTF-8 locales). Patch by
Adam Harvey [Wed, 23 Mar 2011 08:59:11 +0000 (08:59 +0000)]
Implement request #54355 (Test for de_DE doesn't use UTF-8 locales). Patch by
Ondřej Surý.

13 years agoCoverage for a 'silent server protocol change' from the past for which both mysqlnd...
Ulf Wendel [Wed, 23 Mar 2011 08:57:52 +0000 (08:57 +0000)]
Coverage for a 'silent server protocol change' from the past for which both mysqlnd and libmysql have workarounds.

13 years agoBah, these should have been in the last commit too. Update expected output for
Adam Harvey [Wed, 23 Mar 2011 08:48:32 +0000 (08:48 +0000)]
Bah, these should have been in the last commit too. Update expected output for
further tests that now generate warnings after r306931.

13 years agoUpdate test that now generates a warning after r306931, which increased the
Adam Harvey [Wed, 23 Mar 2011 08:43:36 +0000 (08:43 +0000)]
Update test that now generates a warning after r306931, which increased the
error you get when silently casting an empty variable to an object to an
E_WARNING from E_STRICT.

13 years ago- Fixed bug #54283 (new DatePeriod(NULL) causes crash)
Felipe Pena [Wed, 23 Mar 2011 01:22:18 +0000 (01:22 +0000)]
- Fixed bug #54283 (new DatePeriod(NULL) causes crash)

13 years ago- Updating UPGRADING for r309516 and modest merge to 5.3.
Gustavo André dos Santos Lopes [Wed, 23 Mar 2011 00:51:22 +0000 (00:51 +0000)]
- Updating UPGRADING for r309516 and modest merge to 5.3.

13 years ago- Fixed bug #54281 (Crash in non-initialized RecursiveIteratorIterator)
Felipe Pena [Tue, 22 Mar 2011 22:41:16 +0000 (22:41 +0000)]
- Fixed bug #54281 (Crash in non-initialized RecursiveIteratorIterator)

13 years agopalloc is long dead, use more appropriate name
Andrey Hristov [Tue, 22 Mar 2011 14:39:58 +0000 (14:39 +0000)]
palloc is long dead, use more appropriate name

13 years agoFix message
Andrey Hristov [Tue, 22 Mar 2011 14:39:36 +0000 (14:39 +0000)]
Fix message

13 years agoremove more unneeded includes
Andrey Hristov [Tue, 22 Mar 2011 12:54:02 +0000 (12:54 +0000)]
remove more unneeded includes

13 years agoremove unneeded includes
Andrey Hristov [Tue, 22 Mar 2011 12:22:16 +0000 (12:22 +0000)]
remove unneeded includes

13 years agoFix bug #54318 (Non-portable grep option used in PDO pgsql configuration).
Adam Harvey [Tue, 22 Mar 2011 09:12:01 +0000 (09:12 +0000)]
Fix bug #54318 (Non-portable grep option used in PDO pgsql configuration).
Patch by Ben Walton <bwalton at artsci dot utoronto dot ca>.

13 years agoFix bug #54340 (DateTime::add() method bug).
Adam Harvey [Tue, 22 Mar 2011 08:33:22 +0000 (08:33 +0000)]
Fix bug #54340 (DateTime::add() method bug).

13 years ago- Added socket_import_stream().
Gustavo André dos Santos Lopes [Tue, 22 Mar 2011 00:44:23 +0000 (00:44 +0000)]
- Added socket_import_stream().
- Fixed socket_strerror.phpt
- Made php_set_sock_blocking return FAILURE on fcntl error.
- Made socket_set_block()/socket_set_nonblock() emit warning on error.

13 years agothrow out legacy code, that never was used for something
Andrey Hristov [Mon, 21 Mar 2011 13:58:11 +0000 (13:58 +0000)]
throw out legacy code, that never was used for something
useful. Was added for QC but QC is now a plugin, not part of
the core.

13 years agoFix bug #54316 (DateTime::createFromFormat does not handle trailing '|'
Adam Harvey [Mon, 21 Mar 2011 09:40:52 +0000 (09:40 +0000)]
Fix bug #54316 (DateTime::createFromFormat does not handle trailing '|'
correctly).

13 years ago- Make fclose() actually close stream, even when the resource refcount is > 1.
Gustavo André dos Santos Lopes [Mon, 21 Mar 2011 02:58:54 +0000 (02:58 +0000)]
- Make fclose() actually close stream, even when the resource refcount is > 1.
  This reverts the fix for bug #24557.
- Make php_stream_free delete the stream from the resources list, not merely
  decrease its refcount, as a single call to zend_list_delete does.
#Not worth the risk merging to 5.3. While change #2 may prevent some segfaults,
#a quick and dirty survey to the codebase only showed calls to php_stream_close
#or php_stream_free on streams allocated in the same function, which would have
#refcount == 1. May be reconsidered.

13 years ago- Fixed SKIPIF section of bug52820.phpt.
Gustavo André dos Santos Lopes [Sun, 20 Mar 2011 22:15:43 +0000 (22:15 +0000)]
- Fixed SKIPIF section of bug52820.phpt.

13 years ago- Fixed SKIPIF section of bug51958.phpt.
Gustavo André dos Santos Lopes [Sun, 20 Mar 2011 22:12:11 +0000 (22:12 +0000)]
- Fixed SKIPIF section of bug51958.phpt.

13 years agofollow CS:
Boris Lytochkin [Sun, 20 Mar 2011 20:07:33 +0000 (20:07 +0000)]
follow CS:
 - method set_security should be named as setSecurity
 - SNMP_VERSION_2C constant

13 years ago- Fixed bug #54332 (trunk only, null pointer deref due to information loss on long...
Gustavo André dos Santos Lopes [Sun, 20 Mar 2011 15:15:08 +0000 (15:15 +0000)]
- Fixed bug #54332 (trunk only, null pointer deref due to information loss on long to int conversion)
- Fixed some int* pointers being passed as size_t*.

13 years ago- Normalized line endings, added native eol-style.
Gustavo André dos Santos Lopes [Sun, 20 Mar 2011 02:05:41 +0000 (02:05 +0000)]
- Normalized line endings, added native eol-style.

13 years ago- Adding copyright headers to the new files, gotta do something about the
Gustavo André dos Santos Lopes [Sun, 20 Mar 2011 02:03:29 +0000 (02:03 +0000)]
- Adding copyright headers to the new files, gotta do something about the
  windows line endings too, but I'm separating the commits.

13 years ago- Fixed bug #54291 (Crash iterating DirectoryIterator for dir name starting
Gustavo André dos Santos Lopes [Sat, 19 Mar 2011 23:15:04 +0000 (23:15 +0000)]
- Fixed bug #54291 (Crash iterating DirectoryIterator for dir name starting
  with \0).

13 years agorevert r309111 (name_len was not a typo)
Boris Lytochkin [Sat, 19 Mar 2011 20:50:39 +0000 (20:50 +0000)]
revert r309111 (name_len was not a typo)

13 years ago- Fixed bug #54312 (soap_version logic bug)
Felipe Pena [Sat, 19 Mar 2011 17:36:01 +0000 (17:36 +0000)]
- Fixed bug #54312 (soap_version logic bug)
  Patch by: tom at samplonius dot org

13 years agoAdd the libraries we actually test and need for LDAP and OpenSSL, fixes bug #53339
Raphael Geissert [Fri, 18 Mar 2011 18:47:09 +0000 (18:47 +0000)]
Add the libraries we actually test and need for LDAP and OpenSSL, fixes bug #53339
Patch by Clint Byrum

13 years agoadd a proxy for sppintf and vspprintf
Andrey Hristov [Fri, 18 Mar 2011 14:56:20 +0000 (14:56 +0000)]
add a proxy for sppintf and vspprintf

13 years agoWS
Andrey Hristov [Fri, 18 Mar 2011 13:55:25 +0000 (13:55 +0000)]
WS

13 years agonew function/methods - mysqlnd_stmt_flush. Removing
Andrey Hristov [Fri, 18 Mar 2011 13:35:33 +0000 (13:35 +0000)]
new function/methods - mysqlnd_stmt_flush. Removing
code duplication

13 years agoless trace info
Andrey Hristov [Fri, 18 Mar 2011 12:33:17 +0000 (12:33 +0000)]
less trace info

13 years agosplit mysqlnd_debug.c in 3 files
Andrey Hristov [Fri, 18 Mar 2011 11:58:46 +0000 (11:58 +0000)]
split mysqlnd_debug.c in 3 files

13 years ago- Replaced calls to getprotobyname by constants to avoid
Gustavo André dos Santos Lopes [Thu, 17 Mar 2011 22:21:59 +0000 (22:21 +0000)]
- Replaced calls to getprotobyname by constants to avoid
  unnecessarily hitting /etc/protocols on MINIT.

13 years agoTest coverage for some of the cases where LAST_INSERT_ID() and API *_insert_id()...
Ulf Wendel [Thu, 17 Mar 2011 15:18:22 +0000 (15:18 +0000)]
Test coverage for some of the cases where LAST_INSERT_ID() and API *_insert_id() differ as documented in the MySQL manual in particular the C API reference section

13 years agoFix for bug #54221 mysqli::get_warnings segfault when used in multi queries
Andrey Hristov [Thu, 17 Mar 2011 10:28:53 +0000 (10:28 +0000)]
Fix for bug #54221 mysqli::get_warnings segfault when used in multi queries

13 years agoFixed bug #54265 (crash when variable gets reassigned in error handler)
Dmitry Stogov [Wed, 16 Mar 2011 15:21:38 +0000 (15:21 +0000)]
Fixed bug #54265 (crash when variable gets reassigned in error handler)

13 years agoRemove unused macros
Andrey Hristov [Wed, 16 Mar 2011 14:10:59 +0000 (14:10 +0000)]
Remove unused macros

13 years agoallocate persistently
Andrey Hristov [Wed, 16 Mar 2011 12:42:59 +0000 (12:42 +0000)]
allocate persistently

13 years agocompiler warnings fixed
Andrey Hristov [Wed, 16 Mar 2011 11:51:56 +0000 (11:51 +0000)]
compiler warnings fixed

13 years agoFixed bug #54262 (Crash when assigning value to a dimension in a non-array)
Dmitry Stogov [Wed, 16 Mar 2011 11:14:33 +0000 (11:14 +0000)]
Fixed bug #54262 (Crash when assigning value to a dimension in a non-array)

13 years agofix UMR when setting forward string offset
Stanislav Malyshev [Wed, 16 Mar 2011 05:41:50 +0000 (05:41 +0000)]
fix UMR when setting forward string offset

13 years agofix UMR when variable name is an object and __toString is used
Stanislav Malyshev [Wed, 16 Mar 2011 05:25:02 +0000 (05:25 +0000)]
fix UMR when variable name is an object and __toString is used
# zend_call_function checks IS_REF on This

13 years ago- windows only
Pierre Joye [Tue, 15 Mar 2011 17:14:32 +0000 (17:14 +0000)]
- windows only

13 years ago- make setlocale thread only, drastically reduce TS related crashes in error mgt...
Pierre Joye [Tue, 15 Mar 2011 17:13:44 +0000 (17:13 +0000)]
- make setlocale thread only, drastically reduce TS related crashes in error mgt and other parts like pcre, and actually a good thing (tm)

13 years ago- Fixed bug #51958: socket_accept() fails on IPv6 sockets.
Gustavo André dos Santos Lopes [Mon, 14 Mar 2011 22:59:05 +0000 (22:59 +0000)]
- Fixed bug #51958: socket_accept() fails on IPv6 sockets.
#On hold for 5.3

13 years ago- Updated to version 2011.4 (2011d)
Derick Rethans [Mon, 14 Mar 2011 18:56:02 +0000 (18:56 +0000)]
- Updated to version 2011.4 (2011d)

13 years agoFixed multibyte related issues
Dmitry Stogov [Mon, 14 Mar 2011 16:02:04 +0000 (16:02 +0000)]
Fixed multibyte related issues

13 years agoFixed multibyte related issues
Dmitry Stogov [Mon, 14 Mar 2011 16:00:59 +0000 (16:00 +0000)]
Fixed multibyte related issues

13 years ago- Missing fixes for bug #54247
Felipe Pena [Mon, 14 Mar 2011 14:12:42 +0000 (14:12 +0000)]
- Missing fixes for bug #54247

13 years ago- Fixed bug #54247 (format-string vulnerability on Phar)
Felipe Pena [Mon, 14 Mar 2011 13:54:41 +0000 (13:54 +0000)]
- Fixed bug #54247 (format-string vulnerability on Phar)

13 years ago- Added multicast support to the sockets extension (bug #40510).
Gustavo André dos Santos Lopes [Mon, 14 Mar 2011 00:08:29 +0000 (00:08 +0000)]
- Added multicast support to the sockets extension (bug #40510).

13 years ago- Fix infile return on duplicated key (related to bug #54242)
Felipe Pena [Sun, 13 Mar 2011 14:57:19 +0000 (14:57 +0000)]
- Fix infile return on duplicated key (related to bug #54242)

13 years ago- Fixed bug #54242 (dba_insert returns true if key already exists)
Felipe Pena [Sun, 13 Mar 2011 14:21:58 +0000 (14:21 +0000)]
- Fixed bug #54242 (dba_insert returns true if key already exists)

13 years ago- Fixed ZTS build
Felipe Pena [Sun, 13 Mar 2011 14:19:31 +0000 (14:19 +0000)]
- Fixed ZTS build

13 years agoRemove unused variable
Pierrick Charron [Sun, 13 Mar 2011 05:25:45 +0000 (05:25 +0000)]
Remove unused variable

13 years agoFixed bug #54180 (parse_url() incorrectly parses path when ? in fragment)
Pierrick Charron [Sun, 13 Mar 2011 04:02:56 +0000 (04:02 +0000)]
Fixed bug #54180 (parse_url() incorrectly parses path when ? in fragment)

13 years agofix typo in SNMP_SNPRINT_VALUE usage: use val_len, not name_length
Boris Lytochkin [Fri, 11 Mar 2011 07:21:13 +0000 (07:21 +0000)]
fix typo in SNMP_SNPRINT_VALUE usage: use val_len, not name_length

13 years agoFix prototype of zend_fetch_debug_backtrace().
Sebastian Bergmann [Fri, 11 Mar 2011 03:52:39 +0000 (03:52 +0000)]
Fix prototype of zend_fetch_debug_backtrace().

13 years agofixed tests to match the new float precision of 53, as described in bug 47168
Eyal Teutsch [Thu, 10 Mar 2011 13:25:19 +0000 (13:25 +0000)]
fixed tests to match the new float precision of 53, as described in bug 47168

13 years agoAdd a version number to timelib for other projects that use it.
Scott MacVicar [Wed, 9 Mar 2011 20:06:52 +0000 (20:06 +0000)]
Add a version number to timelib for other projects that use it.

This has the same version scheme as timezonedb.

<year><release-padded-to-two>

13 years agoClose [PHP-BUG] Req #54152...
Jim Jagielski [Wed, 9 Mar 2011 18:53:22 +0000 (18:53 +0000)]
Close [PHP-BUG] Req #54152...
Apache 2.3.12 (and later) will now work correctly with PHP's fcgi
impl with this patch.

13 years ago- Fixed bug #49608 (Using CachingIterator on DirectoryIterator instance segfaults)
Felipe Pena [Tue, 8 Mar 2011 19:56:29 +0000 (19:56 +0000)]
- Fixed bug #49608 (Using CachingIterator on DirectoryIterator instance segfaults)

13 years ago- Version++
Felipe Pena [Tue, 8 Mar 2011 18:24:04 +0000 (18:24 +0000)]
- Version++

13 years agofix typppo
Antony Dovgal [Tue, 8 Mar 2011 14:53:38 +0000 (14:53 +0000)]
fix typppo

13 years ago- Fixed bug #54193 (Integer overflow in shmop_read())
Felipe Pena [Tue, 8 Mar 2011 13:11:14 +0000 (13:11 +0000)]
- Fixed bug #54193 (Integer overflow in shmop_read())

13 years ago- Updated to version 2011.3 (2011c)
Derick Rethans [Mon, 7 Mar 2011 14:55:28 +0000 (14:55 +0000)]
- Updated to version 2011.3 (2011c)

13 years agoFix speling.
Sebastian Bergmann [Sun, 6 Mar 2011 21:47:46 +0000 (21:47 +0000)]
Fix speling.

13 years agoFix ZTS build.
Moriyoshi Koizumi [Sun, 6 Mar 2011 07:06:55 +0000 (07:06 +0000)]
Fix ZTS build.

13 years agoFix zend.multibyte oddities. Hope this will address all the known problems.
Moriyoshi Koizumi [Sun, 6 Mar 2011 07:00:30 +0000 (07:00 +0000)]
Fix zend.multibyte oddities. Hope this will address all the known problems.

13 years ago- Fixed bug #54167 (PDO_DBLIB returns null on SQLUNIQUE field)
Felipe Pena [Sat, 5 Mar 2011 23:07:45 +0000 (23:07 +0000)]
- Fixed bug #54167 (PDO_DBLIB returns null on SQLUNIQUE field)
# initial patch by: mjh at hodginsmedia dot com (5.3)
# trunk version by me

13 years ago* tune snmp2_walk.phpt
Boris Lytochkin [Fri, 4 Mar 2011 19:23:25 +0000 (19:23 +0000)]
* tune snmp2_walk.phpt
* more net-snmp v5.3 compatibility (OPAQUE_SPECIAL_TYPES)

13 years ago* fix warning about redefining REGISTER_PDO_CLASS_CONST_LONG (damn copy'n'paste)
Boris Lytochkin [Fri, 4 Mar 2011 18:58:01 +0000 (18:58 +0000)]
* fix warning about redefining REGISTER_PDO_CLASS_CONST_LONG (damn copy'n'paste)
* tuned two unit test that failed at gcov.php.net/PHP_HEAD

13 years ago- Be more consistent in these instructions
Johannes Schlüter [Thu, 3 Mar 2011 13:23:05 +0000 (13:23 +0000)]
- Be more consistent in these instructions

13 years agofix warnings mentioned in 'Parameter Parsing Report'
Boris Lytochkin [Wed, 2 Mar 2011 22:12:02 +0000 (22:12 +0000)]
fix warnings mentioned in 'Parameter Parsing Report'

13 years ago- Enable windows build system to accept paths containing spaces.
Moriyoshi Koizumi [Wed, 2 Mar 2011 05:22:22 +0000 (05:22 +0000)]
- Enable windows build system to accept paths containing spaces.

13 years ago- Fixed SplObjectStorage::offsetSet arginfo, reported in bug #54118
Felipe Pena [Tue, 1 Mar 2011 00:13:23 +0000 (00:13 +0000)]
- Fixed SplObjectStorage::offsetSet arginfo, reported in bug #54118

13 years agoFixed bug #54089 (token_get_all() does not stop after __halt_compiler).
Ilia Alshanetsky [Mon, 28 Feb 2011 15:18:27 +0000 (15:18 +0000)]
Fixed bug #54089 (token_get_all() does not stop after __halt_compiler).

13 years ago- Fixed bug #54092 (Segmentation fault when using HTTP proxy with the FTP
Gustavo André dos Santos Lopes [Sun, 27 Feb 2011 20:23:54 +0000 (20:23 +0000)]
- Fixed bug #54092 (Segmentation fault when using HTTP proxy with the FTP
  wrapper).
#php_stream->wrapperdata should hold an array zval (like its zval* type
#indicates...), it's not a place where the wrapper can drop an arbitrary
#pointer. For that, .wrapperthis should be used.
#Also, since the ftp dir wrapper defines its own stream type, it's more
#appropriate to use .abstract to store the stream instance specific data.

13 years ago- Possible fix for Bug #54108 (valgrind can not be found if located outside of system...
Felipe Pena [Sun, 27 Feb 2011 17:55:39 +0000 (17:55 +0000)]
- Possible fix for Bug #54108 (valgrind can not be found if located outside of system's default PATH)

13 years agoremove compiler warnings
Boris Lytochkin [Sat, 26 Feb 2011 19:08:55 +0000 (19:08 +0000)]
remove compiler warnings
fix various memory leaks seen with --enable-debug

13 years ago* new methods get_errno, get_error to get errno and error string
Boris Lytochkin [Sat, 26 Feb 2011 08:27:26 +0000 (08:27 +0000)]
* new methods get_errno, get_error to get errno and error string
    of last SNMP-related error
* formatting markup
* some fixes in max_oids logic: NULL will set it to default value,
    do not allow non-positive user-supplied values
* unit tests for changes

13 years agofix parse errors for non_repeaters & max_repetitions: aligment errors
Boris Lytochkin [Fri, 25 Feb 2011 19:22:15 +0000 (19:22 +0000)]
fix parse errors for non_repeaters & max_repetitions: aligment errors

13 years agoeven better fix
Andrey Hristov [Fri, 25 Feb 2011 16:55:27 +0000 (16:55 +0000)]
even better fix

13 years agofix plugin counting, this is trunk only
Andrey Hristov [Fri, 25 Feb 2011 16:44:39 +0000 (16:44 +0000)]
fix plugin counting, this is trunk only

13 years agomove from macros to functions, which can be overwritten, if needed
Andrey Hristov [Fri, 25 Feb 2011 12:25:36 +0000 (12:25 +0000)]
move from macros to functions, which can be overwritten, if needed

13 years ago- fix regression (carsten_sttgt@gmx.de)
Pierre Joye [Fri, 25 Feb 2011 11:28:33 +0000 (11:28 +0000)]
- fix regression (carsten_sttgt@gmx.de)

13 years agoMFB: fix lcov build (r308657)
Nuno Lopes [Fri, 25 Feb 2011 09:37:33 +0000 (09:37 +0000)]
MFB: fix lcov build (r308657)

13 years ago- Fixed possible off-by-one overflow in ibase_gen_id()
Felipe Pena [Thu, 24 Feb 2011 02:42:38 +0000 (02:42 +0000)]
- Fixed possible off-by-one overflow in ibase_gen_id()

13 years ago- Fix tests. temp dir might be something other than /tmp
Johannes Schlüter [Tue, 22 Feb 2011 14:49:32 +0000 (14:49 +0000)]
- Fix tests. temp dir might be something other than /tmp

13 years ago-not needed, buildconf helps...
Pierre Joye [Tue, 22 Feb 2011 13:09:15 +0000 (13:09 +0000)]
-not needed, buildconf helps...

13 years ago- missing files
Pierre Joye [Tue, 22 Feb 2011 12:59:50 +0000 (12:59 +0000)]
- missing files

13 years agoDeclare vars first. Fix Windows build.
Johannes Schlüter [Tue, 22 Feb 2011 12:51:43 +0000 (12:51 +0000)]
Declare vars first. Fix Windows build.