]> granicus.if.org Git - icu/log
icu
4 years agoAdd LongNameHandler::LongNameHandler(). AllowShortFunctionsOnASingleLine: false
Hugo van der Merwe [Tue, 30 Jun 2020 22:29:05 +0000 (00:29 +0200)]
Add LongNameHandler::LongNameHandler(). AllowShortFunctionsOnASingleLine: false

4 years agoLongNameHandler factories return pointers again, but accept fillIns.
Hugo van der Merwe [Tue, 30 Jun 2020 21:55:44 +0000 (23:55 +0200)]
LongNameHandler factories return pointers again, but accept fillIns.

4 years agodependencies.txt: numberformatter depends on unitsformatter.
Hugo van der Merwe [Tue, 30 Jun 2020 19:06:56 +0000 (21:06 +0200)]
dependencies.txt: numberformatter depends on unitsformatter.

4 years agoBetter error handling on four calls.
Hugo van der Merwe [Tue, 30 Jun 2020 19:00:28 +0000 (21:00 +0200)]
Better error handling on four  calls.

4 years agooutputUnit: std::move tweak.
Hugo van der Merwe [Tue, 30 Jun 2020 18:49:48 +0000 (20:49 +0200)]
outputUnit: std::move tweak.

4 years agoLongNameHandler: replace orig factory funcs with the 'ByValue' versions
Hugo van der Merwe [Tue, 30 Jun 2020 18:42:22 +0000 (20:42 +0200)]
LongNameHandler: replace orig factory funcs with the 'ByValue' versions

4 years agoCommented assertFormatDescendingBig tests: usage skeletons not implemented yet.
Hugo van der Merwe [Tue, 30 Jun 2020 18:32:10 +0000 (20:32 +0200)]
Commented assertFormatDescendingBig tests: usage skeletons not implemented yet.

4 years agoImplement FormattedNumber::getOutputUnit() properly.
Hugo van der Merwe [Tue, 30 Jun 2020 17:20:26 +0000 (19:20 +0200)]
Implement FormattedNumber::getOutputUnit() properly.

4 years agoAdd LongNameHandler forMeasureUnitByValue and forCompoundUnitByValue.
Hugo van der Merwe [Tue, 30 Jun 2020 15:34:33 +0000 (17:34 +0200)]
Add LongNameHandler forMeasureUnitByValue and forCompoundUnitByValue.

4 years agoSix of Nine PR comments addressed.
Hugo van der Merwe [Mon, 29 Jun 2020 14:51:00 +0000 (16:51 +0200)]
Six of Nine PR comments addressed.

4 years agoMore cleanups, and disable getOutputUnit tests.
Hugo van der Merwe [Fri, 26 Jun 2020 11:53:47 +0000 (13:53 +0200)]
More cleanups, and disable getOutputUnit tests.

4 years agofixup! Move Usage implementation to number_usageprefs.cpp
Hugo van der Merwe [Fri, 26 Jun 2020 10:58:08 +0000 (12:58 +0200)]
fixup! Move Usage implementation to number_usageprefs.cpp

4 years agoLittle cleanups
Hugo van der Merwe [Fri, 26 Jun 2020 08:33:03 +0000 (10:33 +0200)]
Little cleanups

4 years agoDrop StubUnitsRouter, modify UnitsRouter as needed.
Hugo van der Merwe [Fri, 26 Jun 2020 09:01:00 +0000 (11:01 +0200)]
Drop StubUnitsRouter, modify UnitsRouter as needed.

4 years agoMove Usage implementation to number_usageprefs.cpp
Hugo van der Merwe [Fri, 26 Jun 2020 08:31:50 +0000 (10:31 +0200)]
Move Usage implementation to number_usageprefs.cpp

4 years agoImprovements; TODO: getOutputUnit() still not implemented.
Hugo van der Merwe [Wed, 24 Jun 2020 12:36:47 +0000 (14:36 +0200)]
Improvements; TODO: getOutputUnit() still not implemented.

- For primitives: malloc/free, not new/delete.
- Some cleanup.
- Failing test cases for getOutputUnit(), with comments as to where it
  likely needs to be plumbed in.

4 years agocmemory.h: incorporate code-review feedback.
Hugo van der Merwe [Wed, 24 Jun 2020 12:35:00 +0000 (14:35 +0200)]
cmemory.h: incorporate code-review feedback.

4 years agoNew files: add to dependencies.txt and i18n.vcxproj
Hugo van der Merwe [Tue, 23 Jun 2020 17:40:34 +0000 (19:40 +0200)]
New files: add to dependencies.txt and i18n.vcxproj

4 years agoOne pass of clean-up for PR.
Hugo van der Merwe [Tue, 23 Jun 2020 17:06:38 +0000 (19:06 +0200)]
One pass of clean-up for PR.

4 years agofixup! Documentation tweaks (no code changes).
Hugo van der Merwe [Tue, 23 Jun 2020 14:50:40 +0000 (16:50 +0200)]
fixup! Documentation tweaks (no code changes).

4 years agoICU-21174 Add adopt*() to MemoryPool and MaybeStackVector
Hugo van der Merwe [Fri, 19 Jun 2020 12:10:17 +0000 (14:10 +0200)]
ICU-21174 Add adopt*() to MemoryPool and MaybeStackVector

Also add more const-correctness, including getConstAlias().

4 years agoImplement stubbed-out Precision, improve NumberFormatterSettings docs.
Hugo van der Merwe [Tue, 23 Jun 2020 11:34:42 +0000 (13:34 +0200)]
Implement stubbed-out Precision, improve NumberFormatterSettings docs.

4 years agoStubUnitsRouter constructor taking StringPiece region, like UnitsRouter.
Hugo van der Merwe [Mon, 22 Jun 2020 17:50:59 +0000 (19:50 +0200)]
StubUnitsRouter constructor taking StringPiece region, like UnitsRouter.

4 years agoGlue Code: skeletons/formatting not implemented yet.
Hugo van der Merwe [Fri, 19 Jun 2020 13:24:38 +0000 (15:24 +0200)]
Glue Code: skeletons/formatting not implemented yet.

- Unit selection works.
- Rebased from 8341388b94

4 years agoDocumentation tweaks (no code changes).
Hugo van der Merwe [Fri, 19 Jun 2020 13:24:54 +0000 (15:24 +0200)]
Documentation tweaks (no code changes).

4 years agoTweak the edit in the MemoryPool docstring.
Hugo van der Merwe [Fri, 19 Jun 2020 12:44:56 +0000 (14:44 +0200)]
Tweak the edit in the MemoryPool docstring.

4 years agoAdd adoptBack() to MemoryPool and MaybeStackVector
Hugo van der Merwe [Fri, 19 Jun 2020 12:10:17 +0000 (14:10 +0200)]
Add adoptBack() to MemoryPool and MaybeStackVector

4 years agoMerge pull request #49 from hugovdm/units-staging
Shane F. Carr [Thu, 18 Jun 2020 22:07:42 +0000 (17:07 -0500)]
Merge pull request #49 from hugovdm/units-staging

Merge upstream/master into sffc/units-staging

4 years agoImprove SingleUnitImpl comparisons.
Hugo van der Merwe [Thu, 18 Jun 2020 19:17:50 +0000 (21:17 +0200)]
Improve SingleUnitImpl comparisons.

4 years agoUse SingleUnitImpl::getSimpleUnitID() instead of now-missing ::identifier.
Hugo van der Merwe [Thu, 18 Jun 2020 08:40:43 +0000 (10:40 +0200)]
Use SingleUnitImpl::getSimpleUnitID() instead of now-missing ::identifier.

4 years agoAdd new cpp files to sources.txt
Hugo van der Merwe [Thu, 18 Jun 2020 08:15:34 +0000 (10:15 +0200)]
Add new cpp files to sources.txt

4 years agoMerge remote-tracking branch 'upstream/master' into units-staging
Hugo van der Merwe [Thu, 18 Jun 2020 08:09:34 +0000 (10:09 +0200)]
Merge remote-tracking branch 'upstream/master' into units-staging

4 years agoICU-21165 Add LdmlConverter UNITS output, update SUPPLEMENTAL_DATA.
Hugo van der Merwe [Mon, 15 Jun 2020 15:21:13 +0000 (17:21 +0200)]
ICU-21165 Add LdmlConverter UNITS output, update SUPPLEMENTAL_DATA.

- Produce new supplementalData.txt and units.txt with:

      ant -f build-icu-data.xml -DoutDir=/tmp/new_dir \
          -DcldrVersion=37 -DoutputTypes=UNITS,SUPPLEMENTAL_DATA

4 years agoICU-21169 Add SingleUnitImpl::getSimpleUnitID().
Hugo van der Merwe [Tue, 16 Jun 2020 14:12:15 +0000 (16:12 +0200)]
ICU-21169 Add SingleUnitImpl::getSimpleUnitID().

Also:
- Use BytesTrie not UCharsTrie.
- Add a nullptr check for a uprv_malloc.

4 years agoICU-21161 Mark uloc_getDisplayScriptInContext static
Frank Tang [Thu, 18 Jun 2020 04:51:13 +0000 (21:51 -0700)]
ICU-21161 Mark uloc_getDisplayScriptInContext static

Remove from urename.h

4 years agoICU-21137 Adjust VSCode IDE settings and README.
Hugo van der Merwe [Wed, 27 May 2020 13:43:15 +0000 (15:43 +0200)]
ICU-21137 Adjust VSCode IDE settings and README.

ICU Pull Request #1159.

- Set intltest's Current Working Directory correctly to enable finding
  resources.
- Adds c_cpp_properties.json, primarily for the includePath settings.
- Load average takes a while to respond, specify -j24 to always limit
  parallel jobs to a maximum of 24.
- make's "-l" parameter is system load average, not CPU percentage.
  A load average of 90 makes my laptop unusable, changing to -l20.
- Make running all tests the unit-testing default.
- Document the adjustments that can be made in the README.
- Skip these json files when checking for copyright notices. Pure json
  does not permit comments, so c_cpp_properties.json cannot have
  comments.
- defines += U_DISABLE_RENAMING=1 to simplify reference following.

Rebased from 00a5d6dd5c.

4 years agoMerge branch 'doubleEqualsWithDelta' into units-staging
Hugo van der Merwe [Thu, 18 Jun 2020 00:04:53 +0000 (02:04 +0200)]
Merge branch 'doubleEqualsWithDelta' into units-staging

4 years agoA bit more constness.
Hugo van der Merwe [Wed, 17 Jun 2020 23:34:42 +0000 (01:34 +0200)]
A bit more constness.

4 years agoMove new assertEqualsNear code into place.
Hugo van der Merwe [Wed, 17 Jun 2020 22:39:53 +0000 (00:39 +0200)]
Move new assertEqualsNear code into place.

4 years agoTemporarily restore assertEqualsNear.
Hugo van der Merwe [Wed, 17 Jun 2020 20:59:56 +0000 (22:59 +0200)]
Temporarily restore assertEqualsNear.

This function was restored as part of the original merge of
units-staging into this development branch, in case it was in used in
new code in units-staging.

With the rebase, we are thus also restoring it temporarily, at the
point in the sequence of commits where the merge had been.

4 years agoCode review feedback. Temporarily 'assertEqualsNewNear'.
Hugo van der Merwe [Tue, 9 Jun 2020 22:55:20 +0000 (00:55 +0200)]
Code review feedback. Temporarily 'assertEqualsNewNear'.

4 years agoUse uprv_fabs. (abs() is for integer types.)
Hugo van der Merwe [Mon, 11 May 2020 18:19:50 +0000 (20:19 +0200)]
Use uprv_fabs. (abs() is for integer types.)

4 years agoAttempt to disambiguate 'abs', for MacOSX build failure.
Hugo van der Merwe [Mon, 11 May 2020 17:12:41 +0000 (19:12 +0200)]
Attempt to disambiguate 'abs', for MacOSX build failure.

4 years agoImprove @param delta documentation.
Hugo van der Merwe [Mon, 11 May 2020 15:02:28 +0000 (17:02 +0200)]
Improve @param delta documentation.

4 years agoUse JUnit-like assertEquals. Improve test messages.
Hugo van der Merwe [Mon, 11 May 2020 14:53:29 +0000 (16:53 +0200)]
Use JUnit-like assertEquals. Improve test messages.

4 years agoUpdate code for correct NaN/Inf handling.
Hugo van der Merwe [Thu, 30 Apr 2020 10:54:11 +0000 (12:54 +0200)]
Update code for correct NaN/Inf handling.

4 years agoCreate assertEquals for double with a delta parameter.
Hugo van der Merwe [Thu, 30 Apr 2020 10:54:11 +0000 (12:54 +0200)]
Create assertEquals for double with a delta parameter.

4 years agoMerge pull request #51 from hugovdm/units-staging-import-cldr-units
Hugo [Wed, 17 Jun 2020 20:27:03 +0000 (22:27 +0200)]
Merge pull request #51 from hugovdm/units-staging-import-cldr-units

Update supplementalData.txt and units.txt from upstream PR #1173

4 years agoICU-13565 Break Iteration, remove the dictionary bit from the implementation.
Andy Heninger [Tue, 9 Jun 2020 20:19:17 +0000 (13:19 -0700)]
ICU-13565 Break Iteration, remove the dictionary bit from the implementation.

For identifying text that needs to be handled by a word dictionary for Break Iteration,
change from using a bit in the character category to sorting all dictionary categories
together, and recording the boundary between the non-dictionary and dictionary ranges.

This is internal to the implementaion. It does not affect behavior.
It does increase the number of character categories that can be handled using a
compact 8 bit Trie, from 127 to 255.

4 years agoAdd -DcldrVersion=37 to 'ant -f build-icu-data.xml' command-line.
Hugo van der Merwe [Wed, 17 Jun 2020 14:32:50 +0000 (16:32 +0200)]
Add -DcldrVersion=37 to 'ant -f build-icu-data.xml' command-line.

Pull Request for this branch: https://github.com/sffc/icu/pull/51

4 years agoUpdate supplementalData.txt and units.txt from CLDR&ICU master
Hugo van der Merwe [Mon, 15 Jun 2020 15:21:13 +0000 (17:21 +0200)]
Update supplementalData.txt and units.txt from CLDR&ICU master

4 years agoMerge pull request #30 from younies/units_router
Younies Mahmoud [Wed, 17 Jun 2020 15:17:43 +0000 (17:17 +0200)]
Merge pull request #30 from younies/units_router

Implementation of UnitsRouter and ComplexUnitConverter.

4 years agofix MeasureUnit::simplify method
younies [Tue, 16 Jun 2020 20:54:03 +0000 (22:54 +0200)]
fix MeasureUnit::simplify method

4 years agoadd a hint for sorting the units
younies [Tue, 16 Jun 2020 19:05:23 +0000 (21:05 +0200)]
add a hint for sorting the units

4 years agoadd U_FAILURE(status) in emplaceBackAndConfirm
younies [Tue, 16 Jun 2020 18:57:18 +0000 (20:57 +0200)]
add U_FAILURE(status) in emplaceBackAndConfirm

4 years agofix small typo
younies [Tue, 16 Jun 2020 18:54:27 +0000 (20:54 +0200)]
fix small typo

4 years agofix findAndMerge function
younies [Tue, 16 Jun 2020 18:14:44 +0000 (20:14 +0200)]
fix findAndMerge function

4 years agoICU-21078 Improve instructions and gitignore files for cldr-to-icu.
Hugo van der Merwe [Sun, 14 Jun 2020 15:49:00 +0000 (17:49 +0200)]
ICU-21078 Improve instructions and gitignore files for cldr-to-icu.

This also adds .idea/ to the top-level .gitignore, next to .vs/ and
.vscode/.

4 years agofix small style
younies [Tue, 16 Jun 2020 17:04:11 +0000 (19:04 +0200)]
fix small style

4 years agofix various parts of the code
younies [Tue, 16 Jun 2020 16:28:30 +0000 (18:28 +0200)]
fix various parts of the code

4 years agoICU-21149 Adding a helper to allow simpler debugging of mappers.
David Beaumont [Mon, 15 Jun 2020 21:56:23 +0000 (21:56 +0000)]
ICU-21149 Adding a helper to allow simpler debugging of mappers.

4 years agofix warning in UnitsRouter#route function
younies [Sun, 14 Jun 2020 09:33:33 +0000 (11:33 +0200)]
fix warning in UnitsRouter#route function

4 years agoadd formattable to unitsformatter
Younies Mahmoud [Sun, 14 Jun 2020 07:28:26 +0000 (09:28 +0200)]
add formattable to unitsformatter

4 years agofix dependices
younies [Sun, 14 Jun 2020 06:46:13 +0000 (08:46 +0200)]
fix dependices

4 years agoremove unneeded test case
younies [Sat, 13 Jun 2020 20:50:09 +0000 (22:50 +0200)]
remove unneeded test case

4 years agofix simplify function
younies [Sat, 13 Jun 2020 16:14:51 +0000 (18:14 +0200)]
fix simplify function

4 years agofix formatting
younies [Sat, 13 Jun 2020 13:37:15 +0000 (15:37 +0200)]
fix formatting

4 years agoadd arounding epsilon to correct the error in the double operation
younies [Sat, 13 Jun 2020 13:36:14 +0000 (15:36 +0200)]
add arounding epsilon to correct the error in the double operation

4 years agoadd MeasureUnit#simplify method to simplify the units when we check the convertibility
younies [Sat, 13 Jun 2020 13:28:32 +0000 (15:28 +0200)]
add MeasureUnit#simplify method to simplify the units when we check the convertibility

4 years agoMerge pull request #49 from younies/units_router_younies
Younies Mahmoud [Fri, 12 Jun 2020 22:12:51 +0000 (00:12 +0200)]
Merge pull request #49 from younies/units_router_younies

add emplaceBackAndConfirm to not confirm the emplace back everytime

4 years agoadd emplaceBackAndConfirm to not confirm the emplace back everytime
Younies Mahmoud [Fri, 12 Jun 2020 22:10:58 +0000 (00:10 +0200)]
add emplaceBackAndConfirm to not confirm the emplace back everytime

4 years agoMerge pull request #48 from younies/units_router_younies
Younies Mahmoud [Fri, 12 Jun 2020 13:18:43 +0000 (15:18 +0200)]
Merge pull request #48 from younies/units_router_younies

fix complext number format

4 years agofix complext number format
Younies Mahmoud [Fri, 12 Jun 2020 13:10:59 +0000 (15:10 +0200)]
fix complext number format

4 years agoMerge pull request #47 from younies/units_router_younies
Younies Mahmoud [Fri, 12 Jun 2020 10:13:33 +0000 (12:13 +0200)]
Merge pull request #47 from younies/units_router_younies

add a printf in units router to print the unit preferences

4 years agoremove non needed fprintf
Younies Mahmoud [Fri, 12 Jun 2020 10:13:02 +0000 (12:13 +0200)]
remove non needed fprintf

4 years agofinalize Units Router
Younies Mahmoud [Fri, 12 Jun 2020 10:09:58 +0000 (12:09 +0200)]
finalize Units Router

4 years agoICU-21109 minimum grouping digits in DecimalFormat
Frank Tang [Thu, 11 Jun 2020 00:53:05 +0000 (00:53 +0000)]
ICU-21109 minimum grouping digits in DecimalFormat

See #1152

4 years agoMerge branch 'units_router' into units_router_younies
Hugo van der Merwe [Thu, 11 Jun 2020 17:44:20 +0000 (19:44 +0200)]
Merge branch 'units_router' into units_router_younies

4 years agoFix unit test affected by CLDR units data hack.
Hugo van der Merwe [Thu, 11 Jun 2020 17:40:39 +0000 (19:40 +0200)]
Fix unit test affected by CLDR units data hack.

4 years agoadd internal illustration and split only the outputUnits when it is UMEASURE_UNIT_MIXED
Younies Mahmoud [Thu, 11 Jun 2020 16:31:50 +0000 (18:31 +0200)]
add internal illustration and split only the outputUnits when it is UMEASURE_UNIT_MIXED

4 years agoMerge branch 'units_router' of github.com:younies/icu into units_router_younies
Younies Mahmoud [Wed, 10 Jun 2020 13:27:47 +0000 (15:27 +0200)]
Merge branch 'units_router' of github.com:younies/icu into units_router_younies

4 years agohangle precision
Younies Mahmoud [Wed, 10 Jun 2020 13:27:36 +0000 (15:27 +0200)]
hangle precision

4 years agoHack for CLDR units data: use "inch" below 3 feet.
Hugo van der Merwe [Wed, 10 Jun 2020 13:25:33 +0000 (15:25 +0200)]
Hack for CLDR units data: use "inch" below 3 feet.

4 years agoMerge remote-tracking branch 'sffc/units-staging' into units_router
Hugo van der Merwe [Wed, 10 Jun 2020 08:01:11 +0000 (10:01 +0200)]
Merge remote-tracking branch 'sffc/units-staging' into units_router

4 years agomerge sffc units-staging branch
Younies Mahmoud [Wed, 10 Jun 2020 06:54:18 +0000 (08:54 +0200)]
merge sffc units-staging branch

4 years agoMerge pull request #47 from hugovdm/stringpiecify
Shane F. Carr [Tue, 9 Jun 2020 23:29:41 +0000 (18:29 -0500)]
Merge pull request #47 from hugovdm/stringpiecify

Change getPreferencesFor parameters from char* to StringPiece.

4 years agoDrop 'const', it's by-value anyway.
Hugo van der Merwe [Tue, 9 Jun 2020 22:40:49 +0000 (00:40 +0200)]
Drop 'const', it's by-value anyway.

4 years agoTemporary hacky override of 'SE road' preferences.
Hugo van der Merwe [Tue, 9 Jun 2020 22:15:38 +0000 (00:15 +0200)]
Temporary hacky override of 'SE road' preferences.

4 years agoPass StringPiece instances to getPreferencesFor.
Hugo van der Merwe [Tue, 9 Jun 2020 21:59:21 +0000 (23:59 +0200)]
Pass StringPiece instances to getPreferencesFor.

4 years agoChange getPreferencesFor parameters from char* to StringPiece.
Hugo van der Merwe [Tue, 9 Jun 2020 21:00:35 +0000 (23:00 +0200)]
Change getPreferencesFor parameters from char* to StringPiece.

4 years agoChange getPreferencesFor parameters from char* to StringPiece.
Hugo van der Merwe [Tue, 9 Jun 2020 21:00:35 +0000 (23:00 +0200)]
Change getPreferencesFor parameters from char* to StringPiece.

4 years agofix fprintf for printing floating number
Younies Mahmoud [Tue, 9 Jun 2020 19:58:57 +0000 (21:58 +0200)]
fix fprintf for printing floating number

4 years agoadd a printf in units router to print the unit preferences
Younies Mahmoud [Tue, 9 Jun 2020 19:27:57 +0000 (21:27 +0200)]
add a printf in units router to print the unit preferences

4 years agoMerge pull request #46 from younies/units_router_younies
Younies Mahmoud [Tue, 9 Jun 2020 17:50:26 +0000 (19:50 +0200)]
Merge pull request #46 from younies/units_router_younies

add the internal design documentation

4 years agoMerge pull request #46 from hugovdm/moreUnitsDataTest
Shane F. Carr [Tue, 9 Jun 2020 17:32:26 +0000 (12:32 -0500)]
Merge pull request #46 from hugovdm/moreUnitsDataTest

Add six more unit tests for getPreferencesFor.

4 years agoAdd six more unit tests for getPreferencesFor.
Hugo van der Merwe [Tue, 9 Jun 2020 13:56:53 +0000 (15:56 +0200)]
Add six more unit tests for getPreferencesFor.

4 years agoadd the internal design documentation
Younies Mahmoud [Tue, 9 Jun 2020 12:56:28 +0000 (14:56 +0200)]
add the internal design documentation

4 years agoMerge pull request #45 from younies/units_router_younies
Younies Mahmoud [Tue, 9 Jun 2020 06:53:07 +0000 (08:53 +0200)]
Merge pull request #45 from younies/units_router_younies

fix the merge of sffc/units-staging

4 years agofix small typo
Younies Mahmoud [Tue, 9 Jun 2020 06:51:31 +0000 (08:51 +0200)]
fix small typo

4 years agofix the merge of sffc/units-staging
Younies Mahmoud [Mon, 8 Jun 2020 18:12:48 +0000 (20:12 +0200)]
fix the merge of sffc/units-staging