Bruce Momjian [Wed, 9 Aug 2006 17:47:03 +0000 (17:47 +0000)]
Fix statement_timeout on Win32 so that it properly treats micro-seconds
as micro-seconds, rather than as 100 microseconds, as it does now. This
actually fixes all setitimer calls on Win32, but statement_timeout is
the most visible fix.
Bruce Momjian [Wed, 9 Aug 2006 16:35:51 +0000 (16:35 +0000)]
Add TODO items we don't want (Idea from Josh Berkus)
>
>
> Features We Do _Not_ Want
> =========================
>
> * All backends running as threads in a single process (not want)
>
> This eliminates the process protection we get from the current setup.
> Thread creation is usually the same overhead as process creation on
> modern systems, so it seems unwise to use a pure threaded model.
>
> * Optimizer hints (not want)
>
> Optimizer hints are used to work around problems in the optimizer. We
> would rather have the problems reported and fixed.
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00506.php
Bruce Momjian [Wed, 9 Aug 2006 14:55:39 +0000 (14:55 +0000)]
Update packages:
< A package would be a schema with public/private variables,
> A package would be a schema with session-local variables,
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00384.php
Bruce Momjian [Wed, 9 Aug 2006 02:48:10 +0000 (02:48 +0000)]
Update packages description:
< A package would be a schema with its own variables,
< private functions, and initialization functions. It
> A package would be a schema with public/private variables,
> public/private functions, and initialization functions. It
Bruce Momjian [Tue, 8 Aug 2006 22:51:37 +0000 (22:51 +0000)]
Update packages:
< private functions, and initialization functions
> private functions, and initialization functions. It
> is also possible to implement these capabilities
> in all schemas and not use a separate "packages"
> syntax at all.
Tom Lane [Tue, 8 Aug 2006 19:15:09 +0000 (19:15 +0000)]
Add a feature for automatic initialization and finalization of dynamically
loaded libraries: call functions _PG_init() and _PG_fini() if the library
defines such symbols. Hence we no longer need to specify an initialization
function in preload_libraries: we can assume that the library used the
_PG_init() convention, instead. This removes one source of pilot error
in use of preloaded libraries. Original patch by Ralf Engelschall,
preload_libraries changes by me.
Bruce Momjian [Tue, 8 Aug 2006 17:40:02 +0000 (17:40 +0000)]
Done:
< o Automatically force archiving of partially-filled WAL files when
> o -Automatically force archiving of partially-filled WAL files when
<
< Doing this will allow administrators to know more easily when
< the archive contains all the files needed for point-in-time
< recovery.
< http://archives.postgresql.org/pgsql-patches/2005-04/msg00121.php
<
< o Add reporting of the current WAL file and offset, perhaps as
> o -Add reporting of the current WAL file and offset, perhaps as
<
< The offset allows parts of a WAL file to be archived using
< an external program.
<
Bruce Momjian [Tue, 8 Aug 2006 01:24:36 +0000 (01:24 +0000)]
Done:
< * Allow protocol-level BIND parameter values to be logged
<
< http://archives.postgresql.org/pgsql-hackers/2006-02/msg00165.php
> * -Allow protocol-level BIND parameter values to be logged, if text mode
Bruce Momjian [Tue, 8 Aug 2006 01:23:15 +0000 (01:23 +0000)]
For protocol-level prepare/bind/execute:
o print user name for all
o print portal name if defined for all
o print query for all
o reduce log_statement header to single keyword
o print bind parameters as DETAIL if text mode
Tom Lane [Mon, 7 Aug 2006 17:41:42 +0000 (17:41 +0000)]
On some platforms, pg_usleep isn't interruptible by signals; fix
archiver to behave per original coder's expectation on these machines.
We already know this everywhere else AFAICT.
Tom Lane [Mon, 7 Aug 2006 16:57:57 +0000 (16:57 +0000)]
Make recovery from WAL be restartable, by executing a checkpoint-like
operation every so often. This improves the usefulness of PITR log
shipping for hot standby: formerly, if the standby server crashed, it
was necessary to restart it from the last base backup and replay all
the WAL since then. Now it will only need to reread about the same
amount of WAL as the master server would. The behavior might also
come in handy during a long PITR replay sequence. Simon Riggs,
with some editorialization by Tom Lane.
Tom Lane [Sun, 6 Aug 2006 04:35:21 +0000 (04:35 +0000)]
Tweak sanity_check regression test to display more tables (viz, those
without indexes) but not to display temp tables. It's a bit hard to
credit that sanity_check could get through a database-wide VACUUM
while the preceding create_index test is still trying to clean up
its temp tables ... but I see no other explanation for the current
failure report from buildfarm member sponge.
Tom Lane [Sun, 6 Aug 2006 03:53:44 +0000 (03:53 +0000)]
Add support for forcing a switch to a new xlog file; cause such a switch
to happen automatically during pg_stop_backup(). Add some functions for
interrogating the current xlog insertion point and for easily extracting
WAL filenames from the hex WAL locations displayed by pg_stop_backup
and friends. Simon Riggs with some editorialization by Tom Lane.
Tom Lane [Sat, 5 Aug 2006 17:21:52 +0000 (17:21 +0000)]
Fix inheritance_planner() to delete dummy subplans from its Append plan
list, when some of the child rels have been excluded by constraint
exclusion. This doesn't save a huge amount of time but it'll save some,
and it makes the EXPLAIN output look saner. We already did the
equivalent thing in set_append_rel_pathlist(), but not here.
Tom Lane [Sat, 5 Aug 2006 00:22:49 +0000 (00:22 +0000)]
Extend relation_excluded_by_constraints() to check for mutually
contradictory WHERE-clauses applied to a relation. This makes the
GUC variable constraint_exclusion rather inappropriately named,
but I've refrained for the moment from renaming it.
Per example from Martin Lesser.
Tom Lane [Sat, 5 Aug 2006 00:21:14 +0000 (00:21 +0000)]
Teach predicate_refuted_by() how to do proofs involving NOT-clauses.
This doesn't matter too much for ordinary NOTs, since prepqual.c does
its best to get rid of those, but it helps with IS NOT TRUE clauses
which the rule rewriter likes to insert. Per example from Martin Lesser.
Tom Lane [Fri, 4 Aug 2006 21:33:36 +0000 (21:33 +0000)]
Fix domain_in() bug exhibited by Darcy Buskermolen. The idea of an EState
that's shorter-lived than the expression state being evaluated in it really
doesn't work :-( --- we end up with fn_extra caches getting deleted while
still in use. Rather than abandon the notion of caching expression state
across domain_in calls altogether, I chose to make domain_in a bit cozier
with ExprContext. All we really need for evaluating variable-free
expressions is an ExprContext, not an EState, so I invented the notion of a
"standalone" ExprContext. domain_in can prevent resource leakages by doing
a ReScanExprContext on this rather than having to free it entirely; so we
can make the ExprContext have the same lifespan (and particularly the same
per_query memory context) as the expression state structs.
Tom Lane [Fri, 4 Aug 2006 14:09:51 +0000 (14:09 +0000)]
Teach eval_const_expressions to simplify BooleanTest nodes that have
constant input. Seems worth doing because rule rewriter inserts
IS NOT TRUE tests into WHERE clauses.
Tom Lane [Thu, 3 Aug 2006 20:57:06 +0000 (20:57 +0000)]
Cause ALTER TABLE to perform ALTER COLUMN DROP DEFAULT operations during
the DROP pass rather than the ADD_CONSTR pass. On examining the code I
think this was just an oversight rather than intentional, and it seems
to satisfy the principle of least surprise better than the alternative
solution that was discussed. Add an example to the ref page showing how
to do ALTER TYPE and update the default in one command. Per gripe from
Markus Bertheau that that wasn't possible.
Tom Lane [Thu, 3 Aug 2006 17:04:00 +0000 (17:04 +0000)]
Remove use of a regex character class in resultmap (for freebsd version
check). This isn't supported by pg_regress since the recent rewrite
into C. While we could add char classes to pg_regress.c's code, it's
not really needed at the moment: thanks to Andrew's patch to make
pg_regress always accept the 'standard' comparison file, we can just
drop the version check.
Tom Lane [Thu, 3 Aug 2006 16:04:41 +0000 (16:04 +0000)]
Fix AfterTriggerExecute() to pass tg_trigtuple and tg_newtuple as NULLs
rather than pointers to garbage, when calling AFTER STATEMENT triggers.
Michael Fuhr
Bruce Momjian [Wed, 2 Aug 2006 21:48:43 +0000 (21:48 +0000)]
Move 'ddl' right after 'none' in postgresql.conf. It used to be between
'mod' and 'all', which is not the right order. SGML documentation order
was correct. Report from Chander Ganesan.
Tom Lane [Wed, 2 Aug 2006 18:58:21 +0000 (18:58 +0000)]
Arrange for ValuesScan to keep per-sublist expression eval state in a
temporary context that can be reset when advancing to the next sublist.
This is faster and more thorough at recovering space than the previous
method; moreover it will do the right thing if something in the sublist
tries to register an expression context callback.
Tom Lane [Wed, 2 Aug 2006 16:29:49 +0000 (16:29 +0000)]
Fix documentation error: GRANT/REVOKE for roles only accept role names
as grantees, not PUBLIC ... and you can't say GROUP either. Noted by
Brian Hurt.
Tom Lane [Wed, 2 Aug 2006 13:58:52 +0000 (13:58 +0000)]
Add a HINT per suggestion from Michael Glaesemann. Also, tweak OLD/NEW
test to avoid expensive contain_vars_of_level() scan in the normal case
where we're not inside a rule.
Joe Conway [Wed, 2 Aug 2006 01:59:48 +0000 (01:59 +0000)]
Add support for multi-row VALUES clauses as part of INSERT statements
(e.g. "INSERT ... VALUES (...), (...), ...") and elsewhere as allowed
by the spec. (e.g. similar to a FROM clause subselect). initdb required.
Joe Conway and Tom Lane.
Bruce Momjian [Tue, 1 Aug 2006 18:07:36 +0000 (18:07 +0000)]
Done:
< o %Allow pg_dump to use multiple -t and -n switches [pg_dump]
<
< http://archives.postgresql.org/pgsql-patches/2006-01/msg00190.php
<
> o -Allow pg_dump to use multiple -t and -n switches, exclusion
> ability, and regular expression object matching
Bruce Momjian [Tue, 1 Aug 2006 18:05:04 +0000 (18:05 +0000)]
Allow multiple -n (schema) and -t (table) pg_dump options, and add -T
and -N options to exclude objects. Also support regular expressions for
option object names.
Tom Lane [Mon, 31 Jul 2006 20:09:10 +0000 (20:09 +0000)]
Change the relation_open protocol so that we obtain lock on a relation
(table or index) before trying to open its relcache entry. This fixes
race conditions in which someone else commits a change to the relation's
catalog entries while we are in process of doing relcache load. Problems
of that ilk have been reported sporadically for years, but it was not
really practical to fix until recently --- for instance, the recent
addition of WAL-log support for in-place updates helped.
Along the way, remove pg_am.amconcurrent: all AMs are now expected to support
concurrent update.
Tom Lane [Mon, 31 Jul 2006 01:16:38 +0000 (01:16 +0000)]
Change the bootstrap sequence so that toast tables for system catalogs are
created in the bootstrap phase proper, rather than added after-the-fact
by initdb. This is cleaner than before because it allows us to retire the
undocumented ALTER TABLE ... CREATE TOAST TABLE command, but the real reason
I'm doing it is so that toast tables of shared catalogs will now have
predetermined OIDs. This will allow a reasonably clean solution to the
problem of locking tables before we load their relcache entries, to appear
in a forthcoming patch.