]> granicus.if.org Git - icinga2/log
icinga2
9 years agoDB IDO: Fix datatype for 'check_source' in statehistory table
Michael Friedrich [Mon, 22 Jun 2015 15:02:58 +0000 (17:02 +0200)]
DB IDO: Fix datatype for 'check_source' in statehistory table

fixes #9455

9 years agoFix wrong nscp path w/ command_endpoint runtime macros
Michael Friedrich [Fri, 19 Jun 2015 11:30:26 +0000 (13:30 +0200)]
Fix wrong nscp path w/ command_endpoint runtime macros

Do not allow to override the nscp path by runtime macros.
This causes the (linux) master to send just "." as $nscp_path$
and the windows client ignores the local global constant NscpPath
being overridden by the master.

Only happens with command_endpoints where runtime macros are passed
from the master to the clients.

fixes #9456

9 years agoUpdate release hints for chocolatey versions
Michael Friedrich [Fri, 19 Jun 2015 07:41:51 +0000 (09:41 +0200)]
Update release hints for chocolatey versions

refs #8503

9 years agoFix file reference in README.md
Michael Friedrich [Fri, 19 Jun 2015 07:36:12 +0000 (09:36 +0200)]
Fix file reference in README.md

fixes #9452

9 years agonode setup: indent accept_config and accept_commands
Benedikt Heine [Thu, 18 Jun 2015 17:13:10 +0000 (19:13 +0200)]
node setup: indent accept_config and accept_commands

fixes #9450

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoUpdate AUTHORS
Gunnar Beutner [Fri, 19 Jun 2015 02:50:53 +0000 (04:50 +0200)]
Update AUTHORS

fixes #9451

9 years agoFix typo in the documentation
Benedikt Heine [Thu, 18 Jun 2015 18:06:10 +0000 (20:06 +0200)]
Fix typo in the documentation

refs #9451

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
9 years agoGrammar fix in doc/3-monitoring-basics.md
Ian Kelling [Thu, 18 Jun 2015 20:19:16 +0000 (13:19 -0700)]
Grammar fix in doc/3-monitoring-basics.md

refs #9451

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
9 years agochangelog.py: Fix non-links formatting
Michael Friedrich [Thu, 18 Jun 2015 13:57:44 +0000 (15:57 +0200)]
changelog.py: Fix non-links formatting

refs #9435

9 years agoUpdate release hints
Michael Friedrich [Thu, 18 Jun 2015 13:53:08 +0000 (15:53 +0200)]
Update release hints

refs #9435

9 years agochangelog.py: Add --{version,project,links,html} arguments for output formatting
Michael Friedrich [Thu, 18 Jun 2015 13:46:15 +0000 (15:46 +0200)]
changelog.py: Add --{version,project,links,html} arguments for output formatting

fixes #9435

9 years agoUpdate owner for the chocolatey package
Gunnar Beutner [Thu, 18 Jun 2015 12:23:52 +0000 (14:23 +0200)]
Update owner for the chocolatey package

refs #8503

9 years agoUpdate package description in the spec file
Gunnar Beutner [Thu, 18 Jun 2015 12:13:37 +0000 (14:13 +0200)]
Update package description in the spec file

refs #8503

9 years agochangelog.py: Allow to define project, make custom_fields and changes optional
Michael Friedrich [Thu, 18 Jun 2015 11:26:59 +0000 (13:26 +0200)]
changelog.py: Allow to define project, make custom_fields and changes optional

fixes #9446

9 years agoAdd spec file for Chocolatey
Gunnar Beutner [Thu, 18 Jun 2015 09:42:33 +0000 (11:42 +0200)]
Add spec file for Chocolatey

fixes #8503

9 years agoFix incorrect validator for command arguments
Gunnar Beutner [Thu, 18 Jun 2015 06:13:40 +0000 (08:13 +0200)]
Fix incorrect validator for command arguments

fixes #9436

9 years agoFix wrong timestamp w/ timezone format in DB IDO PGSQL schema
Michael Friedrich [Wed, 17 Jun 2015 14:11:21 +0000 (16:11 +0200)]
Fix wrong timestamp w/ timezone format in DB IDO PGSQL schema

refs #9027

9 years agoUpdate AUTHORS
Michael Friedrich [Wed, 17 Jun 2015 13:28:50 +0000 (15:28 +0200)]
Update AUTHORS

refs #9416
refs #9303

9 years agoITL: Add securityLevel to snmpv3 CheckCommand
Christian Lehmann [Tue, 31 Mar 2015 13:04:58 +0000 (15:04 +0200)]
ITL: Add securityLevel to snmpv3 CheckCommand

For example if using snmpv3 without encryption.
Defaults set to privAuth to stay compatible to older versions.

fixes #9416

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoAdd elasticsearch checkcommand to itl
Dirk Goetz [Mon, 15 Jun 2015 13:09:18 +0000 (15:09 +0200)]
Add elasticsearch checkcommand to itl

fixes #9415

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoAdd 'snmp_is_cisco' to Manubulon snmp-memory command definition
Tom Geissler [Fri, 22 May 2015 09:44:28 +0000 (11:44 +0200)]
Add 'snmp_is_cisco' to Manubulon snmp-memory command definition

The new var 'snmp_is_cisco' was added to snmp-memory check
for use the correct OID with cisco switches. The default
is 'false'.

fixes #9303

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoUpdate release TODOs
Michael Friedrich [Wed, 17 Jun 2015 12:22:59 +0000 (14:22 +0200)]
Update release TODOs

9 years agoRelease version 2.3.5
Gunnar Beutner [Wed, 17 Jun 2015 08:28:42 +0000 (10:28 +0200)]
Release version 2.3.5

9 years agoDocumentation: Fix wrong anchor
Michael Friedrich [Wed, 17 Jun 2015 07:56:25 +0000 (09:56 +0200)]
Documentation: Fix wrong anchor

refs #8850

9 years agoDocumentation: String concat in apply, additional fixes
Michael Friedrich [Tue, 16 Jun 2015 17:58:32 +0000 (19:58 +0200)]
Documentation: String concat in apply, additional fixes

fixes #9318

9 years agoDocumentation: Add best practices for cluster config sync
Michael Friedrich [Tue, 16 Jun 2015 17:44:02 +0000 (19:44 +0200)]
Documentation: Add best practices for cluster config sync

fixes #9285

9 years agoDocumentation: Add function usage examples to advanced topics
Michael Friedrich [Tue, 16 Jun 2015 17:04:40 +0000 (19:04 +0200)]
Documentation: Add function usage examples to advanced topics

Includes typeof() examples, referenced to command variable scopes
and examples from community support.

fixes #9297
fixes #9310
fixes #9311

9 years agoDocumentation: Revamp the 'passing command parameters' section
Michael Friedrich [Tue, 16 Jun 2015 15:34:53 +0000 (17:34 +0200)]
Documentation: Revamp the 'passing command parameters' section

fixes #9313

9 years agoDocumentation: Move configuration before advanced topics
Michael Friedrich [Tue, 16 Jun 2015 14:01:02 +0000 (16:01 +0200)]
Documentation: Move configuration before advanced topics

fixes #9431

9 years agoDocumentation: Enhance cluster troubleshooting; add HA command_endpoint
Michael Friedrich [Mon, 15 Jun 2015 18:10:58 +0000 (20:10 +0200)]
Documentation: Enhance cluster troubleshooting; add HA command_endpoint

fixes #9419
fixes #9420

9 years agoBuild fix
Michael Friedrich [Mon, 15 Jun 2015 15:24:55 +0000 (17:24 +0200)]
Build fix

refs #9324

9 years agoFix objects cache dump in compat for multiline vars
Markus Frosch [Thu, 28 May 2015 07:48:57 +0000 (09:48 +0200)]
Fix objects cache dump in compat for multiline vars

Multiline vars should be written as:
  _test test1\ntest2

And not
  _test test1
test2

fixes #9328

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoFix multi line handling for compat check results
Markus Frosch [Wed, 27 May 2015 14:05:10 +0000 (16:05 +0200)]
Fix multi line handling for compat check results

When a multi line result is submitted via the command pipe, any multi line
output is escaped to a actual string '\n', because any external command only
can be a single line.

Example:
  [1432735140] PROCESS_SERVICE_CHECK_RESULT;host;service;3;Test1\nTest2|test=1

We need to unescape this values, just like we use to escape multi line output
for IDO and status.dat.

fixes #9324

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoRemove selective reconnecting behavior
Markus Frosch [Thu, 11 Jun 2015 21:02:13 +0000 (23:02 +0200)]
Remove selective reconnecting behavior

We want to remove the partial reconnecting behavior, so that all endpoints of
a zone try to connect to a lower or higher zone in hierarchy.

fixes #9406

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoFix unexpected exception in Utility::DirName when specifying an empty path
Gunnar Beutner [Mon, 15 Jun 2015 12:04:38 +0000 (14:04 +0200)]
Fix unexpected exception in Utility::DirName when specifying an empty path

refs #9263

9 years agoMove NSClient++ installation step after all other wizard steps
Gunnar Beutner [Mon, 15 Jun 2015 11:43:29 +0000 (13:43 +0200)]
Move NSClient++ installation step after all other wizard steps

refs #9263

9 years agoUpdate AUTHORS
Gunnar Beutner [Mon, 15 Jun 2015 10:04:05 +0000 (12:04 +0200)]
Update AUTHORS

refs #9412

9 years agoDocumentation: Update the link to register a new Icinga account
Alexander Fuhr [Mon, 15 Jun 2015 09:40:14 +0000 (11:40 +0200)]
Documentation: Update the link to register a new Icinga account

fixes #9412

9 years agoFix wrong check parameter in 'tcp' CheckCommand
Michael Friedrich [Mon, 15 Jun 2015 09:29:06 +0000 (11:29 +0200)]
Fix wrong check parameter in 'tcp' CheckCommand

refs #9147

9 years agoAdd "Install NSClient++" check box in the Windows wizard
Gunnar Beutner [Mon, 15 Jun 2015 09:19:18 +0000 (11:19 +0200)]
Add "Install NSClient++" check box in the Windows wizard

fixes #9263

9 years agoDocumentation: Extend Custom Attributes with the boolean type
Michael Friedrich [Mon, 15 Jun 2015 09:11:49 +0000 (11:11 +0200)]
Documentation: Extend Custom Attributes with the boolean type

fixes #9393

9 years agoUpdate documentation
Michael Friedrich [Mon, 15 Jun 2015 09:03:45 +0000 (11:03 +0200)]
Update documentation

fixes #9399

9 years agoFix unregistered function failure including <nscp> on Linux
Michael Friedrich [Mon, 15 Jun 2015 08:26:42 +0000 (10:26 +0200)]
Fix unregistered function failure including <nscp> on Linux

fixes #9394

9 years agoFix wrong service table attributes in Livestatus documentation
Martin Stiborsky [Thu, 28 May 2015 11:47:25 +0000 (13:47 +0200)]
Fix wrong service table attributes in Livestatus documentation

Copy&paste error.

fixes #9390

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoAdd System Requirements to Windows Agent Documentation
David Beck [Fri, 15 May 2015 15:33:48 +0000 (08:33 -0700)]
Add System Requirements to Windows Agent Documentation

fixes #9180

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoDocumentation; Fix typo
Jesse Morgan [Thu, 7 May 2015 14:01:12 +0000 (10:01 -0400)]
Documentation; Fix typo

fixes #9389

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoDocumentation: Update escape sequence
Reto Zeder [Wed, 3 Jun 2015 11:34:13 +0000 (13:34 +0200)]
Documentation: Update escape sequence

fixes #9363

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoFix wrong argument for mssql plugin check command
Michael Friedrich [Mon, 8 Jun 2015 16:05:16 +0000 (18:05 +0200)]
Fix wrong argument for mssql plugin check command

fixes #9372

9 years agoAdd a note on libedit-devel on RHEL extra repository
Michael Friedrich [Tue, 2 Jun 2015 12:04:33 +0000 (14:04 +0200)]
Add a note on libedit-devel on RHEL extra repository

fixes #8776

9 years agoDisable selinux rpm build for el5/6 for now
Michael Friedrich [Tue, 2 Jun 2015 11:32:48 +0000 (13:32 +0200)]
Disable selinux rpm build for el5/6 for now

refs #8332

9 years agoFix doc path in selinux package
Michael Friedrich [Mon, 1 Jun 2015 11:29:55 +0000 (13:29 +0200)]
Fix doc path in selinux package

refs #8332

9 years agoSELinux: changed spec
Dirk Goetz [Thu, 7 May 2015 20:26:42 +0000 (20:26 +0000)]
SELinux: changed spec

refs #8332

9 years agoSelinux: added boolean for allowing icinga 2 to connect to all ports, added plugin...
Dirk Goetz [Tue, 31 Mar 2015 19:36:03 +0000 (19:36 +0000)]
Selinux: added boolean for allowing icinga 2 to connect to all ports, added plugin domain transition to admin role

refs #8332

9 years agoSelinux: added more documentation
Dirk Goetz [Thu, 26 Mar 2015 21:11:43 +0000 (21:11 +0000)]
Selinux: added more documentation

refs #8332

9 years agoSelinux: added interface to manage perfdata
Dirk Goetz [Thu, 26 Mar 2015 19:41:26 +0000 (19:41 +0000)]
Selinux: added interface to manage perfdata

refs #8332

9 years agoSelinux: added role and some required changes
Dirk Goetz [Wed, 25 Mar 2015 21:00:53 +0000 (21:00 +0000)]
Selinux: added role and some required changes

refs #8332

9 years agoSelinux: added context to config files to provide interfaces
Dirk Goetz [Wed, 25 Mar 2015 18:52:42 +0000 (18:52 +0000)]
Selinux: added context to config files to provide interfaces

refs #8332

9 years agoSelinux: added more nagios plugin contexts
Dirk Goetz [Tue, 24 Mar 2015 19:28:59 +0000 (19:28 +0000)]
Selinux: added more nagios plugin contexts

refs #8332

9 years agoextended selinux policy documentation
Dirk Goetz [Tue, 24 Mar 2015 19:27:04 +0000 (19:27 +0000)]
extended selinux policy documentation

refs #8332

9 years agoadded first draft of selinux policy documentation
Dirk Goetz [Thu, 19 Mar 2015 19:55:11 +0000 (19:55 +0000)]
added first draft of selinux policy documentation

refs #8332

9 years agoadded chcon to systemd safe-reload script
Dirk Goetz [Tue, 17 Mar 2015 21:23:02 +0000 (21:23 +0000)]
added chcon to systemd safe-reload script
Selinux: Added support for notifications

refs #8332

9 years agoadded restorecon to systemd prepare-dirs script
Dirk Goetz [Tue, 17 Mar 2015 18:51:54 +0000 (18:51 +0000)]
added restorecon to systemd prepare-dirs script

refs #8332

9 years agoSelinux: Added graphite support
Dirk Goetz [Mon, 2 Mar 2015 14:54:39 +0000 (14:54 +0000)]
Selinux: Added graphite support

9 years agoSelinux: Added capabilities and database support
Dirk Goetz [Fri, 27 Feb 2015 09:47:45 +0000 (09:47 +0000)]
Selinux: Added capabilities and database support

refs #8332

9 years agoSelinux: Added file contexts and port
Dirk Goetz [Wed, 11 Feb 2015 21:56:12 +0000 (22:56 +0100)]
Selinux: Added file contexts and port

refs #8332

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
9 years agoAdd selinux policy (first draft)
Michael Friedrich [Tue, 3 Feb 2015 10:29:27 +0000 (11:29 +0100)]
Add selinux policy (first draft)

refs #8332

9 years agoReally remove the NSClient++ installer
Michael Friedrich [Fri, 29 May 2015 08:56:05 +0000 (10:56 +0200)]
Really remove the NSClient++ installer

refs #9238

9 years agoDocs: Add a reference from basics: plugins to plugin integration
Michael Friedrich [Fri, 29 May 2015 08:20:30 +0000 (10:20 +0200)]
Docs: Add a reference from basics: plugins to plugin integration

9 years agoRemove NSClient++ from the installer (for now; will be moved to the setup wizard)
Gunnar Beutner [Tue, 19 May 2015 08:14:46 +0000 (10:14 +0200)]
Remove NSClient++ from the installer (for now; will be moved to the setup wizard)

refs #9238

9 years agoAdd source code for i2eval to the contrib directory
Gunnar Beutner [Tue, 19 May 2015 07:04:10 +0000 (09:04 +0200)]
Add source code for i2eval to the contrib directory

9 years agoFix incorrect type and state filter mapping for User objects in DB IDO
Michael Friedrich [Fri, 15 May 2015 14:40:32 +0000 (16:40 +0200)]
Fix incorrect type and state filter mapping for User objects in DB IDO

fixes #9143

9 years agoFix missing custom attributes in backends if name is equal to object attribute
Michael Friedrich [Fri, 15 May 2015 13:59:02 +0000 (15:59 +0200)]
Fix missing custom attributes in backends if name is equal to object attribute

fixes #9222

9 years agoDocumentation: Fix typo in Configuration Best Practice
Alexander A. Klimov [Wed, 13 May 2015 08:45:04 +0000 (10:45 +0200)]
Documentation: Fix typo in Configuration Best Practice

fixes #9268

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>
9 years agoFix service apply for example
Michael Friedrich [Wed, 13 May 2015 16:24:19 +0000 (18:24 +0200)]
Fix service apply for example

refs #9270

9 years agoFix missing IPv6 support in 'iftraffic' check command
Michael Friedrich [Wed, 13 May 2015 12:19:20 +0000 (14:19 +0200)]
Fix missing IPv6 support in 'iftraffic' check command

refs #9272

9 years agoUpdate "service apply for" documentation using a more real-world example
Michael Friedrich [Wed, 13 May 2015 12:14:30 +0000 (14:14 +0200)]
Update "service apply for" documentation using a more real-world example

fixes #9270

9 years agoAdd 'iftraffic' to plugins-contrib check command definitions
Michael Friedrich [Wed, 13 May 2015 12:13:45 +0000 (14:13 +0200)]
Add 'iftraffic' to plugins-contrib check command definitions

fixes #9272

9 years agoChange permissions for the etc directory on Windows
Gunnar Beutner [Wed, 13 May 2015 11:47:29 +0000 (13:47 +0200)]
Change permissions for the etc directory on Windows

fixes #9269

9 years agoImplement the basename and dirname script functions
Gunnar Beutner [Wed, 13 May 2015 07:46:59 +0000 (09:46 +0200)]
Implement the basename and dirname script functions

refs #9256

9 years agoAdd the --load-all and --log options for nscp-local
Gunnar Beutner [Wed, 13 May 2015 06:45:19 +0000 (08:45 +0200)]
Add the --load-all and --log options for nscp-local

fixes #9261

9 years agoInclude <nscp> in the default Windows config
Gunnar Beutner [Wed, 13 May 2015 06:45:04 +0000 (08:45 +0200)]
Include <nscp> in the default Windows config

fixes #9260

9 years agoRe-add disk and icinga services in the Windows config
Gunnar Beutner [Wed, 13 May 2015 06:43:58 +0000 (08:43 +0200)]
Re-add disk and icinga services in the Windows config

fixes #9259

9 years agoFix incorrect custom var names in the ITL
Gunnar Beutner [Wed, 13 May 2015 06:09:31 +0000 (08:09 +0200)]
Fix incorrect custom var names in the ITL

fixes #9258

9 years agoBundle NSClient++ in Windows installer
Gunnar Beutner [Tue, 12 May 2015 14:00:04 +0000 (16:00 +0200)]
Bundle NSClient++ in Windows installer

fixes #9238

9 years agoDetermine NSClient++ installation path using MsiGetComponentPath
Gunnar Beutner [Tue, 12 May 2015 13:44:44 +0000 (15:44 +0200)]
Determine NSClient++ installation path using MsiGetComponentPath

fixes #9256

9 years agoAdd 'disk_smb' Plugin CheckCommand definition
Michael Friedrich [Tue, 12 May 2015 12:45:10 +0000 (14:45 +0200)]
Add 'disk_smb' Plugin CheckCommand definition

fixes #9254

9 years agoMake sure that --scm-install doesn't fail when the service already exists
Gunnar Beutner [Tue, 12 May 2015 12:39:44 +0000 (14:39 +0200)]
Make sure that --scm-install doesn't fail when the service already exists

fixes #9255

9 years agoImprove user experience when updating Icinga 2 with the NSIS installer
Gunnar Beutner [Tue, 12 May 2015 11:49:52 +0000 (13:49 +0200)]
Improve user experience when updating Icinga 2 with the NSIS installer

fixes #8116

9 years agoFix incorrect variable name in the ITL
Gunnar Beutner [Tue, 12 May 2015 11:08:10 +0000 (13:08 +0200)]
Fix incorrect variable name in the ITL

fixes #9253

9 years agoDocs: Add wiki url for contributing plugin check command definitions
Michael Friedrich [Tue, 12 May 2015 08:17:40 +0000 (10:17 +0200)]
Docs: Add wiki url for contributing plugin check command definitions

9 years agoUpdate AUTHORS
Michael Friedrich [Tue, 5 May 2015 16:41:42 +0000 (18:41 +0200)]
Update AUTHORS

9 years agoFix problem with option order of disk_wfree and disk_cfree
Ralph Breier [Tue, 5 May 2015 11:36:37 +0000 (13:36 +0200)]
Fix problem with option order of disk_wfree and disk_cfree

If using the -r/-R option with check_disk, the command  expects the
warning and critical threshold on the left side of its position.
With order = -3 will be moved to the first position of all options.

fixes #9161

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>
9 years agoFix schema version 1.14.0
Michael Friedrich [Mon, 4 May 2015 09:34:21 +0000 (11:34 +0200)]
Fix schema version 1.14.0

refs #9027

9 years agoAdd yet empty MySQL schema upgrade to IDO version 1.14.0
Eric Lippmann [Thu, 9 Apr 2015 08:30:20 +0000 (10:30 +0200)]
Add yet empty MySQL schema upgrade to IDO version 1.14.0

refs #9027

9 years agoAdd PostgreSQL schema upgrade to IDO version 1.14.0 for adding the time zone for...
Eric Lippmann [Thu, 9 Apr 2015 08:29:19 +0000 (10:29 +0200)]
Add PostgreSQL schema upgrade to IDO version 1.14.0 for adding the time zone for default timestamps

refs #9027

9 years agoFix PostgreSQL schema not specifying the time zone for default timestamps
Eric Lippmann [Thu, 9 Apr 2015 08:27:47 +0000 (10:27 +0200)]
Fix PostgreSQL schema not specifying the time zone for default timestamps

The timestamp columns in the PostgreSQL schema are defined as timestamp with time zone but their default values lack the time zone offset +00.
Thus default timestamps are converted to local time in the zone specified by PostgreSQL's configuration before being displayed to the client.

refs #9027

9 years agoFix Port wrong default port in Node Wizard
Jean Flach [Thu, 30 Apr 2015 10:52:35 +0000 (12:52 +0200)]
Fix Port wrong default port in Node Wizard

fixes #9205

9 years agoUpdate AUTHORS
Gunnar Beutner [Tue, 28 Apr 2015 12:31:25 +0000 (14:31 +0200)]
Update AUTHORS

refs #9191

9 years agoAdd database CheckCommand definition for mongodb
Ferdi Gueran [Mon, 27 Apr 2015 15:15:52 +0000 (17:15 +0200)]
Add database CheckCommand definition for mongodb

fixes #9191

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
9 years agoAdd Windows version string to --version
Jean Flach [Tue, 28 Apr 2015 10:34:33 +0000 (12:34 +0200)]
Add Windows version string to --version

fixes #8888