]> granicus.if.org Git - apache/log
apache
22 years agoThe style police at work.
Justin Erenkrantz [Mon, 4 Mar 2002 10:46:22 +0000 (10:46 +0000)]
The style police at work.

(Justin took a minor pass at this on top of Sander's patch.)

Submitted by: Sander Striker <striker@apache.org>
Reviewed by: Justin Erenkrantz

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93695 13f79535-47bb-0310-9956-ffa450edef68

22 years agoEnsure that net_time filter isn't added on subreqs - we assume that it is
Justin Erenkrantz [Mon, 4 Mar 2002 09:20:03 +0000 (09:20 +0000)]
Ensure that net_time filter isn't added on subreqs - we assume that it is
added on !r->main requests.  This led to infinite loop/SEGV when dealing
with anything that created a subreq.

(I don't think core_create_req is a good place for adding this filter.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93694 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdding the same filters over and over again used to be okay, because
Ryan Bloom [Mon, 4 Mar 2002 05:54:44 +0000 (05:54 +0000)]
Adding the same filters over and over again used to be okay, because
we would lose the extra filters.  Now, if a filter is added, it is run.
Unfortunately, this can cause an infinite loop, or it can cause request
headers to appear twice.  This commit removes two instances in the core
where we were inserting filters for a second and third time.  The bug
was that error responses were causing infinite loops.

This also removes the reset_filters function, which did the exact
same thing as add_required_filters.  The two functions were both called
in error conditions, which was part of what caused this bug.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93693 13f79535-47bb-0310-9956-ffa450edef68

22 years agoIf we insert a protocol filter before we insert a request filter, we
Ryan Bloom [Mon, 4 Mar 2002 05:29:04 +0000 (05:29 +0000)]
If we insert a protocol filter before we insert a request filter, we
must set the r->output_filter to r->proto_output_filter.  If we don't,
then as soon as we insert the request filter, the protocol filter will
be removed.  This was causing headers to not be sent on some requests.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93692 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConversion to xml
Rich Bowen [Mon, 4 Mar 2002 02:55:47 +0000 (02:55 +0000)]
Conversion to xml

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93691 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConversion to xml
Rich Bowen [Mon, 4 Mar 2002 02:45:22 +0000 (02:45 +0000)]
Conversion to xml

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93690 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConversion to xml
Rich Bowen [Mon, 4 Mar 2002 02:38:42 +0000 (02:38 +0000)]
Conversion to xml

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93689 13f79535-47bb-0310-9956-ffa450edef68

22 years agoClassify some of the input filters as the correct types. Previous to
Ryan Bloom [Sun, 3 Mar 2002 22:34:55 +0000 (22:34 +0000)]
Classify some of the input filters as the correct types.  Previous to
this patch, the type wasn't too important, because all filters were
put on the same list.  After this patch, the filter type is very important,
because there are three different types of filters, and they are all treated
differently, namely:

CONNECTION: Filters of this type are valid for the lifetime of this
connection.
PROTOCOL: Filters of this type are valid for the lifetime of this
request from the point of view of the client, this means
that the request is valid from the time that the request
is sent until the time that the response is received.
CONTENT: Filters of this type are valid for the time that this
content is used to satisfy a request.  For simple requests,
this is identical to PROTOCOL, but internal redirects
and sub-requests can change the content without ending
the request.

It is important to realize that the three major types above are actually
broken down into smaller groups in the code, to ensure that the ordering
of filters is always correct.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93688 13f79535-47bb-0310-9956-ffa450edef68

22 years agoI forgot the return, which mean meaningless log messages. This makes us
Ryan Bloom [Sun, 3 Mar 2002 22:18:45 +0000 (22:18 +0000)]
I forgot the return, which mean meaningless log messages.  This makes us
return the correct information.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93687 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThis fixes most of the header bug that was committed last night. The server
Ryan Bloom [Sun, 3 Mar 2002 22:04:03 +0000 (22:04 +0000)]
This fixes most of the header bug that was committed last night.  The server
is seg faulting on pipelined requests currently, but I want to get people
back to a running server.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93686 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdates to the XSLT transformation:
Joshua Slive [Sun, 3 Mar 2002 15:32:57 +0000 (15:32 +0000)]
Updates to the XSLT transformation:

- Add a facility for translations.
- Add a type="warning" for <note>.
- Clean up some variable definitions.

Submitted by:  Patrik Grip-Jansson <patrikj@gnulix.org>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93685 13f79535-47bb-0310-9956-ffa450edef68

22 years agoI forgot to bump the mmn.
Ryan Bloom [Sun, 3 Mar 2002 06:05:58 +0000 (06:05 +0000)]
I forgot to bump the mmn.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93684 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThis finishes the mod_dir/mod_negotiation bug. This final part of the
Ryan Bloom [Sun, 3 Mar 2002 06:04:08 +0000 (06:04 +0000)]
This finishes the mod_dir/mod_negotiation bug.  This final part of the
solution ensures that we don't lose filters if they are added later than
we expect.  The problem could be seen if a connection filter was added
after a request-based filter was added in the past.  The problem was that
the request-based filters pointed to the first filter in the connection
record, so the new connection filter was never called.  Now, all filters
are put on their correct filter lists, and we are sure to always update
all pointers when adding a filter.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93683 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix the mod_dir/mod_negotiation bug, where redirects and sub requests
Ryan Bloom [Sun, 3 Mar 2002 02:15:52 +0000 (02:15 +0000)]
Fix the mod_dir/mod_negotiation bug, where redirects and sub requests
were not getting the correct filters.  This is done by creating a location
in the request rec that holds protocol level filters.  Protocol level
filters survive for one request, from the time the request is received
from the user to the time the response is sent.  r->output_filters now
stores the request level filters, which are only valid for the lifetime
of one request_rec.

This patch works, but it is not complete.  The second half of the problem
is that add_any_filter doesn't check where it puts the filters that it
adds, so it is possible for filters to be put on this wrong list, and
for filters to be lost completely during request processing.  That half
of the fix will be coming in the next day or so.

Submitted by: Will Rowe, Justin Erenkrantz, Ryan Bloom

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93682 13f79535-47bb-0310-9956-ffa450edef68

22 years agoreuse existing private key if possible for all SSLPassPhraseDialog
Doug MacEachern [Sun, 3 Mar 2002 00:46:07 +0000 (00:46 +0000)]
reuse existing private key if possible for all SSLPassPhraseDialog
types, not just builtin.  on win32 for example, a pipe dialog might
allocate a wintty for prompting, which results in 4 prompts at
startup, 2 for each child and 2 within each when httpd "restarts
itself".
update comments on this and wrap them a bit.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93679 13f79535-47bb-0310-9956-ffa450edef68

22 years agoParen-protect macro arguments when used. (This will be needed later when
Cliff Woolley [Sun, 3 Mar 2002 00:36:07 +0000 (00:36 +0000)]
Paren-protect macro arguments when used.  (This will be needed later when
the bucket api gets changed.)

Submitted by: Brian Pane

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93678 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd stupid idea
Jim Jagielski [Sat, 2 Mar 2002 19:10:07 +0000 (19:10 +0000)]
Add stupid idea

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93676 13f79535-47bb-0310-9956-ffa450edef68

22 years agoChanged all the examples into <examples>. Changed a few notes to
Rich Bowen [Sat, 2 Mar 2002 16:40:41 +0000 (16:40 +0000)]
Changed all the examples into <examples>. Changed a few notes to
<notes>. Other minor cleanup.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93673 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd section id, make a note into a <note>
Rich Bowen [Sat, 2 Mar 2002 16:39:01 +0000 (16:39 +0000)]
Add section id, make a note into a <note>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93672 13f79535-47bb-0310-9956-ffa450edef68

22 years agoInitial conversion. Need to clean this up a little.
Rich Bowen [Sat, 2 Mar 2002 16:15:29 +0000 (16:15 +0000)]
Initial conversion. Need to clean this up a little.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93671 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConversion to XML
Rich Bowen [Sat, 2 Mar 2002 03:32:22 +0000 (03:32 +0000)]
Conversion to XML

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93669 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdded example of denying, or allowing, particular users to have UserDir
Rich Bowen [Sat, 2 Mar 2002 02:37:17 +0000 (02:37 +0000)]
Added example of denying, or allowing, particular users to have UserDir
directories.
In a discussion on IRC, it was requested that an explicit example of
this configuration be provided in the documentation.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93668 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdded the documentation for building Apache for NetWare using the GNU
Bradley Nicholes [Fri, 1 Mar 2002 22:29:16 +0000 (22:29 +0000)]
Added the documentation for building Apache for NetWare using the GNU
make files

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93666 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSwitching from a project build file to GNU make files
Bradley Nicholes [Fri, 1 Mar 2002 22:21:25 +0000 (22:21 +0000)]
Switching from a project build file to GNU make files

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93665 13f79535-47bb-0310-9956-ffa450edef68

22 years agoXML conversions of mod_cgi and mod_cgid.
Joshua Slive [Fri, 1 Mar 2002 22:16:23 +0000 (22:16 +0000)]
XML conversions of mod_cgi and mod_cgid.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93664 13f79535-47bb-0310-9956-ffa450edef68

22 years ago next_filter of NULL to any ap_sub_req_lookup*() fn implies the subreq
William A. Rowe Jr [Fri, 1 Mar 2002 20:44:20 +0000 (20:44 +0000)]
  next_filter of NULL to any ap_sub_req_lookup*() fn implies the subreq
  will never be run - or we expect to pass the subreq to fast_redirect.
  The comming fix will break invalid ap_sub_req_lookups* expecting to
  run subrequests with the next_filter NULL semantic.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93663 13f79535-47bb-0310-9956-ffa450edef68

22 years agomod_cern_meta xml conversion.
Joshua Slive [Fri, 1 Mar 2002 19:46:20 +0000 (19:46 +0000)]
mod_cern_meta xml conversion.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93662 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConversion of mod_autoindex to xml.
Joshua Slive [Fri, 1 Mar 2002 18:38:04 +0000 (18:38 +0000)]
Conversion of mod_autoindex to xml.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93661 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix typo.
Joshua Slive [Fri, 1 Mar 2002 18:11:51 +0000 (18:11 +0000)]
Fix typo.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93660 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFancyIndexing is no longer an independent directive.
Joshua Slive [Fri, 1 Mar 2002 18:06:18 +0000 (18:06 +0000)]
FancyIndexing is no longer an independent directive.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93659 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAll I can say is "Ouch" this is nasty.
Justin Erenkrantz [Fri, 1 Mar 2002 09:23:05 +0000 (09:23 +0000)]
All I can say is "Ouch" this is nasty.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93658 13f79535-47bb-0310-9956-ffa450edef68

22 years agoOur favorite showstopper is getting reports from our fans.
Justin Erenkrantz [Fri, 1 Mar 2002 09:21:42 +0000 (09:21 +0000)]
Our favorite showstopper is getting reports from our fans.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93657 13f79535-47bb-0310-9956-ffa450edef68

22 years ago For fat-fingered friends and others who like typing err and warn rather
William A. Rowe Jr [Fri, 1 Mar 2002 06:48:02 +0000 (06:48 +0000)]
  For fat-fingered friends and others who like typing err and warn rather
  than spelling it out on the -e argument.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93656 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Significant cleanup and enable wintty to -always- escape from the service
William A. Rowe Jr [Fri, 1 Mar 2002 06:44:54 +0000 (06:44 +0000)]
  Significant cleanup and enable wintty to -always- escape from the service
  context when the run-as-user is LocalSystem or has access to the windows
  station and desktop.  The original method did not give us a visible tty
  unless the 'Allow Service to Interact with Desktop' toggle was set.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93655 13f79535-47bb-0310-9956-ffa450edef68

22 years agoWe don't need transfer_brigade() because we already have macros to do that
Cliff Woolley [Fri, 1 Mar 2002 05:43:57 +0000 (05:43 +0000)]
We don't need transfer_brigade() because we already have macros to do that
for us, and faster.  :)

Warning, though:  transfer_brigade() was equivalent to APR_BRIGADE_CONCAT(),
and I don't think that was the right behavior for one of the two callers!
I changed that one to use APR_BRIGADE_PREPEND() since by my inspection that
looks like what it should be, but please check me on this.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93654 13f79535-47bb-0310-9956-ffa450edef68

22 years agos/const void/const char/g in ssl_asn1_table api
Doug MacEachern [Fri, 1 Mar 2002 05:24:06 +0000 (05:24 +0000)]
s/const void/const char/g in ssl_asn1_table api
pointed out by gstein

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93653 13f79535-47bb-0310-9956-ffa450edef68

22 years agoConsensus is that we should not use the scoreboard as a source of entropy.
Cliff Woolley [Fri, 1 Mar 2002 04:35:17 +0000 (04:35 +0000)]
Consensus is that we should not use the scoreboard as a source of entropy.

Reviewed by: OtherBill, Justin, Madhu

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93652 13f79535-47bb-0310-9956-ffa450edef68

22 years agoGive mod_dav the ability to output both standard and customized
Greg Stein [Fri, 1 Mar 2002 03:25:49 +0000 (03:25 +0000)]
Give mod_dav the ability to output both standard and customized
<D:error> responses.  It's crucial for marshalling svn error messages
back over to the client; and someday it will be needed to return
specific <DAV:> errors as dictated by the DeltaV spec.

* mod_dav.h (dav_error): add two new fields -- an optional error
    namespace, and an error-tag-name.  Remove the 'delayed computation'
    function and cxt ptrs in this struct;  they were never used.

  (dav_new_error_tag):  new alternative constructor that takes new
    fields.

* util.c (dav_new_error_tag):  implement constructor.

* mod_dav.c (dav_error_response_tag):  new function to output
    'standard' xml error response based on error struct.

  (dav_handle_err): if no multistatus response is passed in, and if an
    error-tag is defined, then call our new xml-output routine.

Submitted by: Ben Collins-Sussman <sussman@collab.net>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93651 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUse the new APR_BRIGADE_PREPEND() macro
Cliff Woolley [Thu, 28 Feb 2002 23:24:08 +0000 (23:24 +0000)]
Use the new APR_BRIGADE_PREPEND() macro

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93650 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNew xml mod_auth_digest docs.
Joshua Slive [Thu, 28 Feb 2002 19:20:22 +0000 (19:20 +0000)]
New xml mod_auth_digest docs.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93649 13f79535-47bb-0310-9956-ffa450edef68

22 years agoplug leak in newish ssl_asn1_table_set() function
Doug MacEachern [Thu, 28 Feb 2002 19:11:31 +0000 (19:11 +0000)]
plug leak in newish ssl_asn1_table_set() function

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93648 13f79535-47bb-0310-9956-ffa450edef68

22 years agoHow can reach our goals if we never have them? So, I ask, "Can we kill
Justin Erenkrantz [Thu, 28 Feb 2002 18:37:45 +0000 (18:37 +0000)]
How can reach our goals if we never have them?  So, I ask, "Can we kill
all showstoppers in a week?"  Are there enough developers paying attention
to go showstopper hunting?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93647 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSync with contents of apache-1.3/ABOUT_APACHE
Lars Eilebrecht [Thu, 28 Feb 2002 17:27:46 +0000 (17:27 +0000)]
Sync with contents of apache-1.3/ABOUT_APACHE

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93646 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix a typo on a directive name.
Joshua Slive [Thu, 28 Feb 2002 17:05:00 +0000 (17:05 +0000)]
Fix a typo on a directive name.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93642 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFor some reason AC_PREFIX_DEFAULT must not be called before the apr
Aaron Bannert [Thu, 28 Feb 2002 15:44:43 +0000 (15:44 +0000)]
For some reason AC_PREFIX_DEFAULT must not be called before the apr
m4 files are included. This fixes builds on autoconf 2.52 again.

Obtained from:  Sander Striker
Submitted by: Thom May <thom@planetarytramp.net>
Reviewed by: Aaron Bannert

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93639 13f79535-47bb-0310-9956-ffa450edef68

22 years agoremove an XXX: we already do CRYPTO_set_locking_callback() in ssl_util_thread_setup()
Doug MacEachern [Thu, 28 Feb 2002 05:58:49 +0000 (05:58 +0000)]
remove an XXX: we already do CRYPTO_set_locking_callback() in ssl_util_thread_setup()

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93637 13f79535-47bb-0310-9956-ffa450edef68

22 years agoremove #ifdef SHARED_MODULE around ssl library cleanup calls.
Doug MacEachern [Thu, 28 Feb 2002 05:28:43 +0000 (05:28 +0000)]
remove #ifdef SHARED_MODULE around ssl library cleanup calls.
SHARED_MODULE is no longer defined, so we were leaking.
plus we always do a full startup/teardown regardless of being a dso or
static.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93636 13f79535-47bb-0310-9956-ffa450edef68

22 years agomove SSL_load_client_CA_file() comment to where we moved the call to it
Doug MacEachern [Thu, 28 Feb 2002 05:22:56 +0000 (05:22 +0000)]
move SSL_load_client_CA_file() comment to where we moved the call to it

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93635 13f79535-47bb-0310-9956-ffa450edef68

22 years agovarious SSLCACertificatePath fixes:
Doug MacEachern [Thu, 28 Feb 2002 05:17:03 +0000 (05:17 +0000)]
various SSLCACertificatePath fixes:
- return value from apr_dir_read() was checking != APR_SUCCESS rather
  than == APR_SUCCESS, so no certs were ever loaded.

- wasn't checking return value of apr_dir_open(), now log an error and
  ssl_die() on failure.

- don't bother trying to load directories

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93634 13f79535-47bb-0310-9956-ffa450edef68

22 years agoplug leak in ssl_init_FindCAList() where return value of
Doug MacEachern [Thu, 28 Feb 2002 04:59:07 +0000 (04:59 +0000)]
plug leak in ssl_init_FindCAList() where return value of
X509_NAME_oneline() used for trace logging was not freed.
now passes in a static buffer so no buffer is malloced.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93633 13f79535-47bb-0310-9956-ffa450edef68

22 years agofold some duplication within ssl_init_FindCAList() into generic
Doug MacEachern [Thu, 28 Feb 2002 04:35:29 +0000 (04:35 +0000)]
fold some duplication within ssl_init_FindCAList() into generic
ssl_init_PushCAList() function.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93632 13f79535-47bb-0310-9956-ffa450edef68

22 years agoneed to free X509_NAME duplicates already found in the stack built by
Doug MacEachern [Thu, 28 Feb 2002 04:00:51 +0000 (04:00 +0000)]
need to free X509_NAME duplicates already found in the stack built by
ssl_init_FindCAList().

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93626 13f79535-47bb-0310-9956-ffa450edef68

22 years agoneed to free the stacks returned by calls to SSL_load_client_CA_file()
Doug MacEachern [Thu, 28 Feb 2002 03:48:26 +0000 (03:48 +0000)]
need to free the stacks returned by calls to SSL_load_client_CA_file()
in ssl_init_FindCAList().  values are pushed into another stack which
gets freed when SSL context is destroyed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93625 13f79535-47bb-0310-9956-ffa450edef68

22 years agocontrary to what comments say, DH* returned from ssl_dh_GetTmpParam()
Doug MacEachern [Thu, 28 Feb 2002 03:21:51 +0000 (03:21 +0000)]
contrary to what comments say, DH* returned from ssl_dh_GetTmpParam()
is _not_ static and needs to be freed via DH_free().

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93624 13f79535-47bb-0310-9956-ffa450edef68

22 years agoneed to free sc->pRevocationStore at shutdown
Doug MacEachern [Thu, 28 Feb 2002 03:12:11 +0000 (03:12 +0000)]
need to free sc->pRevocationStore at shutdown

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93623 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNo longer assume SERVER_CONFIG_FILE is in the "conf" directory. Instead
Aaron Bannert [Thu, 28 Feb 2002 02:56:15 +0000 (02:56 +0000)]
No longer assume SERVER_CONFIG_FILE is in the "conf" directory. Instead
look for it in the $sysconfdir.

This required the use of a new m4 function from APR that retrieves
the fully "expanded", or recursively interpolated, value of the
$sysconfdir variable.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93622 13f79535-47bb-0310-9956-ffa450edef68

22 years agoPR:
Doug MacEachern [Thu, 28 Feb 2002 02:00:10 +0000 (02:00 +0000)]
PR:
Obtained from:
Submitted by:
Reviewed by:
add note about ssl restart changes.
s/mod_perl/mod_ssl/ in bill's note.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93621 13f79535-47bb-0310-9956-ffa450edef68

22 years agoalways reusing existing private key for given vhost on restarts if key
Doug MacEachern [Thu, 28 Feb 2002 01:47:26 +0000 (01:47 +0000)]
always reusing existing private key for given vhost on restarts if key
is encrypted and mtime stamp has not changed.  this prevents getting
prompted twice for passphrase on windows and elsewhere when server is
started with -DNO_DETACH.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93620 13f79535-47bb-0310-9956-ffa450edef68

22 years agos/asn1->mtime/asn1->source_mtime/
Doug MacEachern [Thu, 28 Feb 2002 01:41:42 +0000 (01:41 +0000)]
s/asn1->mtime/asn1->source_mtime/

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93619 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix a typo in the default cgidir variable.
Aaron Bannert [Thu, 28 Feb 2002 01:38:11 +0000 (01:38 +0000)]
Fix a typo in the default cgidir variable.
Set a couple more defaults if they haven't already been set, just
as a precaution.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93618 13f79535-47bb-0310-9956-ffa450edef68

22 years agoinitialize ssl_asn1_t.mtime to 0
Doug MacEachern [Thu, 28 Feb 2002 01:36:04 +0000 (01:36 +0000)]
initialize ssl_asn1_t.mtime to 0

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93617 13f79535-47bb-0310-9956-ffa450edef68

22 years agoreuse vhost keys for asn1 tables where keys are allocated out
Doug MacEachern [Thu, 28 Feb 2002 01:30:18 +0000 (01:30 +0000)]
reuse vhost keys for asn1 tables where keys are allocated out
of s->process->pool to prevent "leaking" each time we format
a vhost key.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93616 13f79535-47bb-0310-9956-ffa450edef68

22 years agoswitch SSLModConfigRec.tPublicCert to ssl_asn1_table api to prevent
Doug MacEachern [Thu, 28 Feb 2002 00:28:05 +0000 (00:28 +0000)]
switch SSLModConfigRec.tPublicCert to ssl_asn1_table api to prevent
leakage on restarts.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93615 13f79535-47bb-0310-9956-ffa450edef68

22 years agoswitch SSLModConfigRec.tPrivateKey to ssl_asn1_table api to prevent
Doug MacEachern [Thu, 28 Feb 2002 00:23:32 +0000 (00:23 +0000)]
switch SSLModConfigRec.tPrivateKey to ssl_asn1_table api to prevent
leakage on restarts.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93614 13f79535-47bb-0310-9956-ffa450edef68

22 years agoadd ssl_asn1_table_get() wrapper and change ssl_init_TmpKeysHandle()
Doug MacEachern [Thu, 28 Feb 2002 00:10:52 +0000 (00:10 +0000)]
add ssl_asn1_table_get() wrapper and change ssl_init_TmpKeysHandle()
to use it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93613 13f79535-47bb-0310-9956-ffa450edef68

22 years agomod_ssl was "leaking" on restart since mc->tTmpKeys table entries
Doug MacEachern [Thu, 28 Feb 2002 00:01:57 +0000 (00:01 +0000)]
mod_ssl was "leaking" on restart since mc->tTmpKeys table entries
were allocated using apr_palloc out of s->process->pool and pushed
into an apr_array_header_t.
solve the problem by moving from apr_array_header_t's to an apr_hash_t.
also add ssl_asn1_table_{set,unset} wrappers to use malloc/free so we
do not "leak" from s->process->pool.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93612 13f79535-47bb-0310-9956-ffa450edef68

22 years agoclean up the passed-in brigade since mod_deflate is through with it
Allan K. Edwards [Wed, 27 Feb 2002 21:49:33 +0000 (21:49 +0000)]
clean up the passed-in brigade since mod_deflate is through with it

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93611 13f79535-47bb-0310-9956-ffa450edef68

22 years agoownership of the brigade is passed in the ap_pass_brigade call
Allan K. Edwards [Wed, 27 Feb 2002 21:16:19 +0000 (21:16 +0000)]
ownership of the brigade is passed in the ap_pass_brigade call
so make sure that it doesn't get left lying around. This tickled
a bug with mod_deflate and resulted in a bucket being compressed
more than once.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93610 13f79535-47bb-0310-9956-ffa450edef68

22 years agoaxe an unused variable
Jeff Trawick [Wed, 27 Feb 2002 20:44:49 +0000 (20:44 +0000)]
axe an unused variable

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93609 13f79535-47bb-0310-9956-ffa450edef68

22 years ago I hope this explanation is simple enough - comments welcome.
William A. Rowe Jr [Wed, 27 Feb 2002 20:17:53 +0000 (20:17 +0000)]
  I hope this explanation is simple enough - comments welcome.

  When you touch CHANGES - remember they are for the 'common man',
  not just us :-)  Legibility is important.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93608 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Introduce PassPhraseDialog 'pipe' mechanism. This builds on DougM's
William A. Rowe Jr [Wed, 27 Feb 2002 19:54:07 +0000 (19:54 +0000)]
  Introduce PassPhraseDialog 'pipe' mechanism.  This builds on DougM's
  apr-ization of the 'tty', and changes his naming a bit so we clearly
  identify the pipe-to and pipe-from the user.

  This patch invokes a bidirectional piped dialog to the user.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93607 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Introduce the PassPhraseDialog 'pipe' mechanism.
William A. Rowe Jr [Wed, 27 Feb 2002 19:51:33 +0000 (19:51 +0000)]
  Introduce the PassPhraseDialog 'pipe' mechanism.

  This is the directive handling commit only, the mechanics patch will
  follow.  PassPhraseDialog "|/path/to/pipe" will use the bidirectional
  pipe to have a 'conversation', along the lines of the tty dialog with
  PassPhraseDialog 'builtin'.  This is entirely different than the 'exec'
  method, which simply runs once for each passphrase, and doesn't allow
  for failure/retries, and certainly doesn't offer any sensible 'dialog'.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93606 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSet defaults for non-autoconf path variables. Also export a couple
Aaron Bannert [Wed, 27 Feb 2002 19:40:27 +0000 (19:40 +0000)]
Set defaults for non-autoconf path variables. Also export a couple
variables that for whatever reason weren't being placed into
config_vars.mk.

Warning: This commit alters the "default" layout (ie. when no --enable-layout
is specified). The most notable change will be htdocs in $prefix/share/htdocs,
which works with the autoconf defaults, but may not be what we want. This
will require more work.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93605 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Need broader permissions if we are to read and the set the flags that
William A. Rowe Jr [Wed, 27 Feb 2002 19:38:09 +0000 (19:38 +0000)]
  Need broader permissions if we are to read and the set the flags that
  apply to the console stream.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93604 13f79535-47bb-0310-9956-ffa450edef68

22 years agoDe-tabify...
Bill Stoddard [Wed, 27 Feb 2002 18:57:26 +0000 (18:57 +0000)]
De-tabify...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93603 13f79535-47bb-0310-9956-ffa450edef68

22 years ago This baffled .mak exported build targets for mod_ssl/abs. They will
William A. Rowe Jr [Wed, 27 Feb 2002 17:41:34 +0000 (17:41 +0000)]
  This baffled .mak exported build targets for mod_ssl/abs.  They will
  recognize their output only as .\Release|Debug\mod_ssl.so, etc.  Without
  the leading .\ kept getting 'dunno how to make ... target'

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93602 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Must admit, my use case was focused on services. It seems that if we
William A. Rowe Jr [Wed, 27 Feb 2002 17:38:20 +0000 (17:38 +0000)]
  Must admit, my use case was focused on services.  It seems that if we
  had a console, we weren't reassigning stdhandles with AllocConsole().
  Open the conin/conout very explicitly, and clean up some other cruft.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93601 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix --sysconfdir and --localstatedir, which were being ignored.
Aaron Bannert [Wed, 27 Feb 2002 17:16:29 +0000 (17:16 +0000)]
Fix --sysconfdir and --localstatedir, which were being ignored.
Fix --enable-layout to work.

showstoppers--

Note: As far as we can tell, autoconf will not let us override our layout
settings from paramers like --prefix, etc. This is unfortunate, but
we will not let this get in the way of --enable-layout working. This
will be made clear in the docs.

PR: 9124, 9873, 9885, 9888

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93600 13f79535-47bb-0310-9956-ffa450edef68

22 years agoWhen we fix this, make sure to close 9963 as this is that problem.
Justin Erenkrantz [Wed, 27 Feb 2002 17:06:35 +0000 (17:06 +0000)]
When we fix this, make sure to close 9963 as this is that problem.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93599 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix --enable-layout to work again.
Aaron Bannert [Wed, 27 Feb 2002 17:06:33 +0000 (17:06 +0000)]
Fix --enable-layout to work again.
Fix bug where --sysconfdir and --localstatedir were being ignored by APR.

Caution: When specifying --enable-layout, common arguments like --prefix,
--exec-prefix, etc. will be ignored and the settings from the layout
will be used instead.

PR: 9124, 9888, 9873, 9885
Submitted by: Thom May <thom@planetarytramp.net>, Aaron Bannert
Reviewed by:    Justin Erenkrantz

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93598 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd the ProxyRemoteMatch directive to the mod_proxy
Jim Jagielski [Wed, 27 Feb 2002 15:49:01 +0000 (15:49 +0000)]
Add the ProxyRemoteMatch directive to the mod_proxy
code. Doccos to be done soon

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93597 13f79535-47bb-0310-9956-ffa450edef68

22 years agodocument the ctx parameter to the add-input-filter functions
Jeff Trawick [Wed, 27 Feb 2002 15:36:23 +0000 (15:36 +0000)]
document the ctx parameter to the add-input-filter functions

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93596 13f79535-47bb-0310-9956-ffa450edef68

22 years agomention some graceful restart breakage with worker
Jeff Trawick [Wed, 27 Feb 2002 12:25:55 +0000 (12:25 +0000)]
mention some graceful restart breakage with worker

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93595 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNo releases until these two are addressed. It doesn't make sense to
Justin Erenkrantz [Wed, 27 Feb 2002 08:24:42 +0000 (08:24 +0000)]
No releases until these two are addressed.  It doesn't make sense to
release a new build if our top two filed issues aren't addressed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93594 13f79535-47bb-0310-9956-ffa450edef68

22 years agoI just tried to do a graceful restart while pounding my box with worker
Justin Erenkrantz [Wed, 27 Feb 2002 04:53:58 +0000 (04:53 +0000)]
I just tried to do a graceful restart while pounding my box with worker
MPM and no segfaults.  Am I missing something or were these fixed with
Jeff's latest fixes?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93592 13f79535-47bb-0310-9956-ffa450edef68

22 years agoap_calc_scoreboard_size() needs to be exported for win32
Doug MacEachern [Wed, 27 Feb 2002 04:10:19 +0000 (04:10 +0000)]
ap_calc_scoreboard_size() needs to be exported for win32

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93590 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Clarity on a snowy night in Illinois.
William A. Rowe Jr [Wed, 27 Feb 2002 04:00:47 +0000 (04:00 +0000)]
  Clarity on a snowy night in Illinois.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93589 13f79535-47bb-0310-9956-ffa450edef68

22 years agoDon't set bytes_sent to be 0 when r->assbackwards since this screws up
Justin Erenkrantz [Wed, 27 Feb 2002 03:55:31 +0000 (03:55 +0000)]
Don't set bytes_sent to be 0 when r->assbackwards since this screws up
logging.

The content length filter seems to track bytes_sent properly regardless
of HTTP version.  The HTTP header filter knows not to send C-L (or any
headers) to this client.

showstoppers--;

(Also fix typo of my last name in CHANGES...)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93588 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Whoh boy that's rough... We sometimes like to answer SIGHUP in the
William A. Rowe Jr [Wed, 27 Feb 2002 03:52:20 +0000 (03:52 +0000)]
  Whoh boy that's rough... We sometimes like to answer SIGHUP in the
  parent process, don't we?

  This -was- post-fork() in 1.3, but with the massive restructuring,
  we inadvertantly now whack the parent process.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93587 13f79535-47bb-0310-9956-ffa450edef68

22 years agochange builtin passphrase prompt to use stdout rather than stderr.
Doug MacEachern [Wed, 27 Feb 2002 03:33:38 +0000 (03:33 +0000)]
change builtin passphrase prompt to use stdout rather than stderr.
and switch to using apr_file api for portability.
stderr has already been redirected to the error_log.
rather than attempting to temporarily rehook it to the terminal,
we print the prompt to stdout before EVP_read_pw_string turns
off tty echo.  which is also more portable.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93586 13f79535-47bb-0310-9956-ffa450edef68

22 years agochanging mod_ssl to do a full startup/teardown on each restart rather
Doug MacEachern [Wed, 27 Feb 2002 03:21:09 +0000 (03:21 +0000)]
changing mod_ssl to do a full startup/teardown on each restart rather
than hack to only read passphrase on 1st round startup.  this change:
- fixes current segv on restarts (SHARED_MODULE is not defined)
- allows LoadModule ssl_module to be added to httpd.conf on restart
  (was core dumping previously)
- allows certs/keys to be changed on restart provided key is not
  encrypted or SSLPassPhraseDialog is exec.  if key is encrypted and
  SSLPassPhraseDialog is builtin, existing private keys will be reused
  on restart (which happens currently for any type of key/dialog).

note: mod_ssl currently leaks on restart; leaks more with this change.
      fixes to come.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93585 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAll the work on the lock APIs probably deserves a little note, and besides
Aaron Bannert [Wed, 27 Feb 2002 03:17:26 +0000 (03:17 +0000)]
All the work on the lock APIs probably deserves a little note, and besides
the module authors will appreciate the note directing them to the new
APIs.

showstoppers--

Also, fast_redirect is lame, toss it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93584 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUse the empty string, not NUL. I should have read my code more closely.
Ryan Bloom [Wed, 27 Feb 2002 00:58:17 +0000 (00:58 +0000)]
Use the empty string, not NUL.  I should have read my code more closely.

Thanks Cliff for slapping me in the head.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93583 13f79535-47bb-0310-9956-ffa450edef68

22 years agoGrrrrr..... We should really use the correct line endings on all
Ryan Bloom [Wed, 27 Feb 2002 00:39:01 +0000 (00:39 +0000)]
Grrrrr.....  We should really use the correct line endings on all
platforms.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93582 13f79535-47bb-0310-9956-ffa450edef68

22 years agofix some problems with variables in config_vars.mk
Jeff Trawick [Tue, 26 Feb 2002 21:31:45 +0000 (21:31 +0000)]
fix some problems with variables in config_vars.mk

Submitted by: Aaron Bannert
Tested by: Jeff Trawick

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93581 13f79535-47bb-0310-9956-ffa450edef68

22 years agoCommit the transformations from the xml docs.
Joshua Slive [Tue, 26 Feb 2002 19:02:35 +0000 (19:02 +0000)]
Commit the transformations from the xml docs.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93580 13f79535-47bb-0310-9956-ffa450edef68

22 years agoStart converting the mpm documentation.
Joshua Slive [Tue, 26 Feb 2002 19:00:40 +0000 (19:00 +0000)]
Start converting the mpm documentation.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93579 13f79535-47bb-0310-9956-ffa450edef68

22 years agoChanges necessary to document MPMs.
Joshua Slive [Tue, 26 Feb 2002 19:00:01 +0000 (19:00 +0000)]
Changes necessary to document MPMs.

In particular, we use an mpm_common file for directives shared between
mpms.  These changes allow for an

<directivesynopsis location="mpm_common">
<name>Listen</name>
</directivesynopsis>

to be included in mpm documentation files.  Also, I added the option
of a <modulelist>, which is used in documenting directives inside
mpm_common.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93578 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThese variables need to be delimited with {} or they will conflict with
Aaron Bannert [Tue, 26 Feb 2002 18:41:58 +0000 (18:41 +0000)]
These variables need to be delimited with {} or they will conflict with
other variables in the same namespace with a shorter prefix substring.
How did this ever work before? I ran into this while testing some of
the recent layout-fixing patches.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93577 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix segfault if content_type is NULL.
Justin Erenkrantz [Tue, 26 Feb 2002 04:04:54 +0000 (04:04 +0000)]
Fix segfault if content_type is NULL.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93570 13f79535-47bb-0310-9956-ffa450edef68