]> granicus.if.org Git - python/log
python
8 years agoIssue #27200: Merge with 3.5
Zachary Ware [Wed, 10 Aug 2016 06:05:56 +0000 (01:05 -0500)]
Issue #27200: Merge with 3.5

8 years agoIssue #27200: Fix doctests in Doc/library/hashlib.rst
Zachary Ware [Wed, 10 Aug 2016 06:05:19 +0000 (01:05 -0500)]
Issue #27200: Fix doctests in Doc/library/hashlib.rst

8 years agoCloses #27210: Merge with 3.5
Zachary Ware [Wed, 10 Aug 2016 06:01:05 +0000 (01:01 -0500)]
Closes #27210: Merge with 3.5

8 years agoIssue #27210: Fix doctests for a few modules.
Zachary Ware [Wed, 10 Aug 2016 05:59:59 +0000 (00:59 -0500)]
Issue #27210: Fix doctests for a few modules.

Initial patch by Jelle Zijlstra.

8 years agoCloses #27209: Merge with 3.5
Zachary Ware [Wed, 10 Aug 2016 05:39:59 +0000 (00:39 -0500)]
Closes #27209: Merge with 3.5

8 years agoIssue #27209: Fix doctests in Doc/library/email*.rst
Zachary Ware [Wed, 10 Aug 2016 05:39:41 +0000 (00:39 -0500)]
Issue #27209: Fix doctests in Doc/library/email*.rst

Patch by Jelle Zijlstra.

8 years agoCloses #27208: Merge with 3.5
Zachary Ware [Wed, 10 Aug 2016 05:35:51 +0000 (00:35 -0500)]
Closes #27208: Merge with 3.5

8 years agoIssue #27208: Fix doctest in Doc/library/traceback.rst
Zachary Ware [Wed, 10 Aug 2016 05:35:27 +0000 (00:35 -0500)]
Issue #27208: Fix doctest in Doc/library/traceback.rst

Patch by Jelle Zijlstra.

8 years agoCloses #27207: Merge with 3.5
Zachary Ware [Wed, 10 Aug 2016 05:31:31 +0000 (00:31 -0500)]
Closes #27207: Merge with 3.5

8 years agoIssue #27207: Fix doctests in Doc/whatsnew/3.2.rst
Zachary Ware [Wed, 10 Aug 2016 05:30:41 +0000 (00:30 -0500)]
Issue #27207: Fix doctests in Doc/whatsnew/3.2.rst

Initial patch by Jelle Zijlstra.

8 years agoCloses #27206: Merge with 3.5
Zachary Ware [Tue, 9 Aug 2016 22:45:15 +0000 (17:45 -0500)]
Closes #27206: Merge with 3.5

8 years agoIssue #27206: Fix doctests in Doc/tutorial.
Zachary Ware [Tue, 9 Aug 2016 22:44:52 +0000 (17:44 -0500)]
Issue #27206: Fix doctests in Doc/tutorial.

Patch by Jelle Zijlstra.

8 years agoCloses #27205: Merge with 3.5
Zachary Ware [Tue, 9 Aug 2016 22:38:44 +0000 (17:38 -0500)]
Closes #27205: Merge with 3.5

8 years agoIssue #27205: Fix doctests in Doc/library/collections.rst.
Zachary Ware [Tue, 9 Aug 2016 22:38:22 +0000 (17:38 -0500)]
Issue #27205: Fix doctests in Doc/library/collections.rst.

Initial patch by Jelle Zijlstra.

8 years agoCloses #27722: Merge with 3.5
Zachary Ware [Tue, 9 Aug 2016 22:10:53 +0000 (17:10 -0500)]
Closes #27722: Merge with 3.5

8 years agoIssue #27722: Fix default for touch method's 'mode' argument
Zachary Ware [Tue, 9 Aug 2016 22:10:39 +0000 (17:10 -0500)]
Issue #27722: Fix default for touch method's 'mode' argument

8 years agoCloses #27204: Merge with 3.5
Zachary Ware [Tue, 9 Aug 2016 22:05:23 +0000 (17:05 -0500)]
Closes #27204: Merge with 3.5

8 years agoIssue #27204: Fix doctests in Doc/howto
Zachary Ware [Tue, 9 Aug 2016 21:47:04 +0000 (16:47 -0500)]
Issue #27204: Fix doctests in Doc/howto

Patch by Jelle Zijlstra.

8 years agoMerge with 3.5
Zachary Ware [Tue, 9 Aug 2016 21:21:17 +0000 (16:21 -0500)]
Merge with 3.5

8 years agoCorrect signatures for a couple of logging handlers
Zachary Ware [Tue, 9 Aug 2016 21:20:41 +0000 (16:20 -0500)]
Correct signatures for a couple of logging handlers

Reported by Oleg Gromyak on docs@

8 years agoCloses #21999: (Empty) merge from 3.5.
Vinay Sajip [Tue, 9 Aug 2016 14:07:06 +0000 (15:07 +0100)]
Closes #21999: (Empty) merge from 3.5.

8 years agoCloses #21999: Handled empty strings correctly when in POSIX mode.
Vinay Sajip [Tue, 9 Aug 2016 14:04:49 +0000 (15:04 +0100)]
Closes #21999: Handled empty strings correctly when in POSIX mode.

8 years agoIssue27181 add geometric mean.
Steven D'Aprano [Tue, 9 Aug 2016 03:58:10 +0000 (13:58 +1000)]
Issue27181 add geometric mean.

8 years agoTighten up test of harmonic mean on a single value.
Steven D'Aprano [Tue, 9 Aug 2016 03:19:48 +0000 (13:19 +1000)]
Tighten up test of harmonic mean on a single value.

8 years agoAutomated merge with ssh://hg.python.org/cpython
Steven D'Aprano [Tue, 9 Aug 2016 02:49:20 +0000 (12:49 +1000)]
Automated merge with ssh://hg.python.org/cpython

8 years agoAdd harmonic mean and tests.
Steven D'Aprano [Tue, 9 Aug 2016 02:49:01 +0000 (12:49 +1000)]
Add harmonic mean and tests.

8 years agoIssue #27700: Document AbstractEventLoop, not BaseEventLoop. (Merge 3.5->3.6)
Guido van Rossum [Mon, 8 Aug 2016 21:43:46 +0000 (14:43 -0700)]
Issue #27700: Document AbstractEventLoop, not BaseEventLoop. (Merge 3.5->3.6)

8 years agoCloses #27710: Disallow fold not in [0, 1] in time and datetime constructors.
Alexander Belopolsky [Mon, 8 Aug 2016 21:05:40 +0000 (17:05 -0400)]
Closes #27710: Disallow fold not in [0, 1] in time and datetime constructors.

8 years agoIssue #27700: Document AbstractEventLoop, not BaseEventLoop.
Guido van Rossum [Mon, 8 Aug 2016 16:41:21 +0000 (09:41 -0700)]
Issue #27700: Document AbstractEventLoop, not BaseEventLoop.

8 years agoIssue #27702: Only expose SOCK_RAW when defined
Berker Peksag [Mon, 8 Aug 2016 11:07:05 +0000 (14:07 +0300)]
Issue #27702: Only expose SOCK_RAW when defined

SOCK_RAW is marked as optional in the POSIX specification:

    http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html

Patch by Ed Schouten.

8 years agoExpose EPOLLRDHUP conditionally
Berker Peksag [Mon, 8 Aug 2016 10:39:43 +0000 (13:39 +0300)]
Expose EPOLLRDHUP conditionally

8 years agoMerge from 3.5
Berker Peksag [Mon, 8 Aug 2016 10:35:27 +0000 (13:35 +0300)]
Merge from 3.5

8 years agoFix use of default reST role
Berker Peksag [Mon, 8 Aug 2016 10:34:49 +0000 (13:34 +0300)]
Fix use of default reST role

8 years agoIssue #23322: Merge from 3.5
Berker Peksag [Mon, 8 Aug 2016 10:07:35 +0000 (13:07 +0300)]
Issue #23322: Merge from 3.5

8 years agoIssue #23322: Remove outdated reference to an example in parser docs
Berker Peksag [Mon, 8 Aug 2016 10:07:08 +0000 (13:07 +0300)]
Issue #23322: Remove outdated reference to an example in parser docs

Initial patch by Sahil Chelaramani.

8 years agoRe-linewrap comments
Raymond Hettinger [Mon, 8 Aug 2016 03:20:33 +0000 (20:20 -0700)]
Re-linewrap comments

8 years agoMerge 3.5
Andrew Svetlov [Mon, 8 Aug 2016 00:11:06 +0000 (03:11 +0300)]
Merge 3.5

8 years agoUse asyncio.gather instead of asyncio.wait in example.
Andrew Svetlov [Mon, 8 Aug 2016 00:10:39 +0000 (03:10 +0300)]
Use asyncio.gather instead of asyncio.wait in example.

gather will raise exception in case of problem but wait just returns done and pending lists of futures.
For getting error every future result should be retrieved, which is boring and error prone.

8 years agoIssue #27664: Add to concurrent.futures.thread.ThreadPoolExecutor()
Gregory P. Smith [Sun, 7 Aug 2016 17:19:20 +0000 (10:19 -0700)]
Issue #27664: Add to concurrent.futures.thread.ThreadPoolExecutor()
the ability to specify a thread name prefix.

8 years agoIssue #26750: unittest.mock.create_autospec() now works properly for
Gregory P. Smith [Sun, 7 Aug 2016 16:06:27 +0000 (09:06 -0700)]
Issue #26750: unittest.mock.create_autospec() now works properly for
subclasses of property() and other data descriptors.  Removes the never
publicly used, never documented unittest.mock.DescriptorTypes tuple.

8 years agoIssue #26750: unittest.mock.create_autospec() now works properly
Gregory P. Smith [Sun, 7 Aug 2016 15:52:26 +0000 (08:52 -0700)]
Issue #26750: unittest.mock.create_autospec() now works properly
for subclasses of property() and other data descriptors.

8 years agoBetter docs for typing.Any by Michael Lee. Fixes issue #27688. (Merge 3.5->3.6)
Guido van Rossum [Sat, 6 Aug 2016 20:48:10 +0000 (13:48 -0700)]
Better docs for typing.Any by Michael Lee. Fixes issue #27688. (Merge 3.5->3.6)

8 years agoBetter docs for typing.Any by Michael Lee. Fixes issue #27688.
Guido van Rossum [Sat, 6 Aug 2016 20:46:48 +0000 (13:46 -0700)]
Better docs for typing.Any by Michael Lee. Fixes issue #27688.

8 years agoIssue #26754: Undocumented support of general bytes-like objects
Serhiy Storchaka [Sat, 6 Aug 2016 20:29:29 +0000 (23:29 +0300)]
Issue #26754: Undocumented support of general bytes-like objects
as path in compile() and similar functions is now deprecated.

8 years agoIssue #26800: Undocumented support of general bytes-like objects
Serhiy Storchaka [Sat, 6 Aug 2016 20:22:08 +0000 (23:22 +0300)]
Issue #26800: Undocumented support of general bytes-like objects
as paths in os functions is now deprecated.

8 years agoSilence warnings from 'make suspicious' to make the docs buildbot happy
Berker Peksag [Sat, 6 Aug 2016 10:37:22 +0000 (13:37 +0300)]
Silence warnings from 'make suspicious' to make the docs buildbot happy

8 years agoCloses #22829: Added --prompt option to venv.
Vinay Sajip [Sat, 6 Aug 2016 09:43:44 +0000 (10:43 +0100)]
Closes #22829: Added --prompt option to venv.

8 years agoCloses #27650: Implemented repr methods for logging objects.
Vinay Sajip [Sat, 6 Aug 2016 09:28:31 +0000 (10:28 +0100)]
Closes #27650: Implemented repr methods for logging objects.

8 years agoIssue #18548: Merge from 3.5
Berker Peksag [Sat, 6 Aug 2016 00:00:30 +0000 (03:00 +0300)]
Issue #18548: Merge from 3.5

8 years agoIssue #18548: Fix unittest.TestSuite() example
Berker Peksag [Sat, 6 Aug 2016 00:00:03 +0000 (03:00 +0300)]
Issue #18548: Fix unittest.TestSuite() example

Initial patch by py.user.

8 years agoAdd AutoEnum: automatically provides next value if missing. Issue 26988.
Ethan Furman [Fri, 5 Aug 2016 23:03:16 +0000 (16:03 -0700)]
Add AutoEnum: automatically provides next value if missing.  Issue 26988.

8 years agoClarify NotImplemented vs NotImplementedError. Initial patch by Emmanuel Barry....
Ethan Furman [Fri, 5 Aug 2016 22:10:16 +0000 (15:10 -0700)]
Clarify NotImplemented vs NotImplementedError.  Initial patch by Emmanuel Barry.  Closes issue 27242.

8 years agoCloses #20160: Merged fix from 3.5.
Vinay Sajip [Fri, 5 Aug 2016 20:44:52 +0000 (21:44 +0100)]
Closes #20160: Merged fix from 3.5.

8 years agoIssue #20160: Merged fix from 3.4.
Vinay Sajip [Fri, 5 Aug 2016 20:44:15 +0000 (21:44 +0100)]
Issue #20160: Merged fix from 3.4.

8 years agoIssue #20160: Merged fix from 3.3.
Vinay Sajip [Fri, 5 Aug 2016 20:43:25 +0000 (21:43 +0100)]
Issue #20160: Merged fix from 3.3.

8 years agoIssue #20160: Handled passing of large structs to callbacks correctly.
Vinay Sajip [Fri, 5 Aug 2016 20:24:27 +0000 (21:24 +0100)]
Issue #20160: Handled passing of large structs to callbacks correctly.

8 years agoAdd typing.Generator docs, by Michael Lee. (Merge 3.5->3.6)
Guido van Rossum [Fri, 5 Aug 2016 19:57:38 +0000 (12:57 -0700)]
Add typing.Generator docs, by Michael Lee. (Merge 3.5->3.6)

8 years agoAdd typing.Generator docs, by Michael Lee.
Guido van Rossum [Fri, 5 Aug 2016 19:56:09 +0000 (12:56 -0700)]
Add typing.Generator docs, by Michael Lee.

8 years agoMerge spelling and grammar fixes from 3.5
Martin Panter [Fri, 5 Aug 2016 01:51:39 +0000 (01:51 +0000)]
Merge spelling and grammar fixes from 3.5

8 years agoMerge with 3.5
Zachary Ware [Thu, 4 Aug 2016 17:14:51 +0000 (12:14 -0500)]
Merge with 3.5

8 years agoFix half-finished sentence.
Zachary Ware [Thu, 4 Aug 2016 17:13:47 +0000 (12:13 -0500)]
Fix half-finished sentence.

Reported by Linda Pescatore on docs@.

8 years agoMerge from 3.5
Berker Peksag [Thu, 4 Aug 2016 14:26:00 +0000 (17:26 +0300)]
Merge from 3.5

8 years agoFix indentation of versionadded directive in IPv4Address.reverse_pointer docs
Berker Peksag [Thu, 4 Aug 2016 14:25:40 +0000 (17:25 +0300)]
Fix indentation of versionadded directive in IPv4Address.reverse_pointer docs

8 years agoMerge from 3.5
Berker Peksag [Thu, 4 Aug 2016 14:22:05 +0000 (17:22 +0300)]
Merge from 3.5

8 years agoIndent ipaddress.ip_address() example correctly
Berker Peksag [Thu, 4 Aug 2016 14:21:46 +0000 (17:21 +0300)]
Indent ipaddress.ip_address() example correctly

8 years agoFix spelling and grammar in documentation and code comments
Martin Panter [Thu, 4 Aug 2016 13:07:31 +0000 (13:07 +0000)]
Fix spelling and grammar in documentation and code comments

8 years agomerge 3.5 (#27670)
Benjamin Peterson [Thu, 4 Aug 2016 05:02:42 +0000 (22:02 -0700)]
merge 3.5 (#27670)

8 years agohttps link to the bug tracker (closes #27670)
Benjamin Peterson [Thu, 4 Aug 2016 05:01:32 +0000 (22:01 -0700)]
https link to the bug tracker (closes #27670)

8 years agoIssue #17599: Use unique _Py_REPARSE_DATA_BUFFER etc names to avoid conflict
Martin Panter [Thu, 4 Aug 2016 02:38:59 +0000 (02:38 +0000)]
Issue #17599: Use unique _Py_REPARSE_DATA_BUFFER etc names to avoid conflict

The conflict occurs with Min GW, which already defines REPARSE_DATA_BUFFER.
Also, Min GW uses a lowercase <windows.h> filename.

8 years agoIssue #27641: Merge cross-compiling improvement from 3.5
Martin Panter [Thu, 4 Aug 2016 01:53:40 +0000 (01:53 +0000)]
Issue #27641: Merge cross-compiling improvement from 3.5

8 years agoIssue #24278: Merge argument parsing docs from 3.5
Martin Panter [Thu, 4 Aug 2016 01:51:32 +0000 (01:51 +0000)]
Issue #24278: Merge argument parsing docs from 3.5

8 years agoMerge 3.5
Donald Stufft [Wed, 3 Aug 2016 22:49:46 +0000 (18:49 -0400)]
Merge 3.5

8 years agoMerge 3.4
Donald Stufft [Wed, 3 Aug 2016 22:49:19 +0000 (18:49 -0400)]
Merge 3.4

8 years agoMerge 3.3
Donald Stufft [Wed, 3 Aug 2016 22:48:17 +0000 (18:48 -0400)]
Merge 3.3

8 years agoSwitch upload.pypi.io to upload.pypi.org
Donald Stufft [Wed, 3 Aug 2016 22:43:38 +0000 (18:43 -0400)]
Switch upload.pypi.io to upload.pypi.org

8 years agoIssue #24278: Explain how argument parsing output buffers are managed
Martin Panter [Wed, 3 Aug 2016 14:35:05 +0000 (14:35 +0000)]
Issue #24278: Explain how argument parsing output buffers are managed

8 years agoIssue #23710: Merge from 3.5
Berker Peksag [Wed, 3 Aug 2016 09:59:16 +0000 (12:59 +0300)]
Issue #23710: Merge from 3.5

8 years agoIssue #23710: Update PyObject_HEAD documentation
Berker Peksag [Wed, 3 Aug 2016 09:58:49 +0000 (12:58 +0300)]
Issue #23710: Update PyObject_HEAD documentation

Since PEP 3123, PyObject_HEAD only has one field named ob_base.
Users now need to use the Py_TYPE macro instead of self->ob_type.

Initial patch by Ammar Askar.

8 years agoMerge 3.5.
Stefan Krah [Wed, 3 Aug 2016 09:18:54 +0000 (11:18 +0200)]
Merge 3.5.

8 years agoIssue #20767: Fix -R option for FreeBSD/clang.
Stefan Krah [Wed, 3 Aug 2016 09:18:26 +0000 (11:18 +0200)]
Issue #20767: Fix -R option for FreeBSD/clang.

8 years agoIssue #26576: Merge from 3.5
Berker Peksag [Wed, 3 Aug 2016 07:17:51 +0000 (10:17 +0300)]
Issue #26576: Merge from 3.5

8 years agoIssue #26576: Clarify that the @deco syntax is not always an equivalent of f = deco(f)
Berker Peksag [Wed, 3 Aug 2016 07:17:21 +0000 (10:17 +0300)]
Issue #26576: Clarify that the @deco syntax is not always an equivalent of f = deco(f)

Patch by Chris Angelico.

8 years agoCloses #27661: Added tzinfo keyword argument to datetime.combine.
Alexander Belopolsky [Tue, 2 Aug 2016 21:49:30 +0000 (17:49 -0400)]
Closes #27661: Added tzinfo keyword argument to datetime.combine.

8 years agoMerge 3.5.
Stefan Krah [Tue, 2 Aug 2016 20:30:57 +0000 (22:30 +0200)]
Merge 3.5.

8 years agoIssue #27241: Catch exception when running pstats as main.
Stefan Krah [Tue, 2 Aug 2016 20:30:24 +0000 (22:30 +0200)]
Issue #27241: Catch exception when running pstats as main.

8 years agoIssue #22557: Now importing already imported modules is up to 2.5 times faster.
Serhiy Storchaka [Tue, 2 Aug 2016 19:51:21 +0000 (22:51 +0300)]
Issue #22557: Now importing already imported modules is up to 2.5 times faster.

8 years ago[merge from 3.5] - Prevent HTTPoxy attack (CVE-2016-1000110)
Senthil Kumaran [Sun, 31 Jul 2016 06:51:13 +0000 (23:51 -0700)]
[merge from 3.5] - Prevent HTTPoxy attack (CVE-2016-1000110)

Ignore the HTTP_PROXY variable when REQUEST_METHOD environment is set, which
indicates that the script is in CGI mode.

Issue #27568 Reported and patch contributed by Rémi Rampin.

8 years agomerge heads
Senthil Kumaran [Sun, 31 Jul 2016 06:48:19 +0000 (23:48 -0700)]
merge heads

8 years ago[merge from 3.4] - Prevent HTTPoxy attack (CVE-2016-1000110)
Senthil Kumaran [Sun, 31 Jul 2016 06:39:06 +0000 (23:39 -0700)]
[merge from 3.4] - Prevent HTTPoxy attack (CVE-2016-1000110)

Ignore the HTTP_PROXY variable when REQUEST_METHOD environment is set, which
indicates that the script is in CGI mode.

Issue #27568 Reported and patch contributed by Rémi Rampin.

8 years ago[merge from 3.3] Prevent HTTPoxy attack (CVE-2016-1000110)
Senthil Kumaran [Sun, 31 Jul 2016 06:34:34 +0000 (23:34 -0700)]
[merge from 3.3] Prevent HTTPoxy attack (CVE-2016-1000110)

Ignore the HTTP_PROXY variable when REQUEST_METHOD environment is set, which
indicates that the script is in CGI mode.

Issue #27568 Reported and patch contributed by Rémi Rampin.

8 years agoPrevent HTTPoxy attack (CVE-2016-1000110)
Senthil Kumaran [Sun, 31 Jul 2016 06:24:16 +0000 (23:24 -0700)]
Prevent HTTPoxy attack (CVE-2016-1000110)

Ignore the HTTP_PROXY variable when REQUEST_METHOD environment is set, which
indicates that the script is in CGI mode.

Issue #27568 Reported and patch contributed by Rémi Rampin.

8 years agomerge 3.5 (#27656)
Benjamin Peterson [Sun, 31 Jul 2016 06:22:24 +0000 (23:22 -0700)]
merge 3.5 (#27656)

8 years agoall SCHED_ constants are optional (closes #27656)
Benjamin Peterson [Sun, 31 Jul 2016 06:21:50 +0000 (23:21 -0700)]
all SCHED_ constants are optional (closes #27656)

8 years agoIssue 27366: PEP 487 docs updates
Nick Coghlan [Sun, 31 Jul 2016 02:42:49 +0000 (12:42 +1000)]
Issue 27366: PEP 487 docs updates

- Porting note for type keyword arg handling
- __init_subclass__ note regarding  metaclass hint

8 years agoIssue 24773: Use the standard Asia/Tehran name in the Iran test.
Alexander Belopolsky [Sat, 30 Jul 2016 15:41:02 +0000 (11:41 -0400)]
Issue 24773: Use the standard Asia/Tehran name in the Iran test.

8 years agoIssue #27652: Expose ESHUTDOWN conditionally
Berker Peksag [Sat, 30 Jul 2016 11:14:12 +0000 (14:14 +0300)]
Issue #27652: Expose ESHUTDOWN conditionally

ESHUTDOWN is also exposed conditionally in Modules/errnomodule.c.

Patch by Ed Schouten.

8 years agoIssue #27366: Tweak PEP 487 documentation
Berker Peksag [Sat, 30 Jul 2016 11:06:15 +0000 (14:06 +0300)]
Issue #27366: Tweak PEP 487 documentation

* Added versionadded directives
* Deleted duplicate sentence from __init_subclass__ docstring
* Modernized tests

8 years ago(merge from 3.5) Issue #27453: CPP invocation in configure must use CPPFLAGS.
Xavier de Gaye [Sat, 30 Jul 2016 09:36:32 +0000 (11:36 +0200)]
(merge from 3.5) Issue #27453: CPP invocation in configure must use CPPFLAGS.
Patch by Chi Hsuan Yen.

8 years agoIssue #27453: CPP invocation in configure must use CPPFLAGS.
Xavier de Gaye [Sat, 30 Jul 2016 09:28:35 +0000 (11:28 +0200)]
Issue #27453: CPP invocation in configure must use CPPFLAGS.
Patch by Chi Hsuan Yen.

8 years agoIssue #27366: Implement PEP 487
Nick Coghlan [Sat, 30 Jul 2016 06:26:03 +0000 (16:26 +1000)]
Issue #27366: Implement PEP 487

- __init_subclass__ called when new subclasses defined
- __set_name__ called when descriptors are part of a
  class definition