]> granicus.if.org Git - sysstat/log
sysstat
4 years agoMake device name consistent between sar and iostat
Sebastien GODARD [Mon, 27 Jul 2020 07:27:32 +0000 (09:27 +0200)]
Make device name consistent between sar and iostat

Use a common function to determine the name of the device to be
displayed by sar (sar -d) and iostat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate sar, iostat and cifsiostat manual pages
Sebastien GODARD [Sat, 25 Jul 2020 16:19:49 +0000 (18:19 +0200)]
Update sar, iostat and cifsiostat manual pages

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sat, 25 Jul 2020 13:23:48 +0000 (15:23 +0200)]
Update non regression tests

Update non regression tests results as device names are now
pretty-printed by default with sar.
Also test new option --pretty.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat,iostat,sar: Add --pretty option
Sebastien GODARD [Sat, 25 Jul 2020 13:15:53 +0000 (15:15 +0200)]
cifsiostat,iostat,sar: Add --pretty option

This option makes the report easier to read by a human.
Please note that for sar, option -p is now equivalent to this one.
Use this option to display device names or network interface names
on the right of the report instead of the left (which can be
particularly useful for long names).

Also option -h is now equivalent to "--pretty --human".

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Device names are now pretty-printed by default
Sebastien GODARD [Sat, 25 Jul 2020 07:20:14 +0000 (09:20 +0200)]
sar: Device names are now pretty-printed by default

sar now pretty-prints device names by default. It means that they will
be displayed as they appear in /dev (e.g. sda, sdb...) instead of
"devM-m", and you don't need to use option -p for that.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Fri, 24 Jul 2020 14:59:33 +0000 (16:59 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #263: Incorrect device name from iostat
Sebastien GODARD [Fri, 24 Jul 2020 14:52:18 +0000 (16:52 +0200)]
Fix #263: Incorrect device name from iostat

Using sysstat.ioconf configure file to determine the device name based
on its major and minor numbers gives a wrong name for xvd* devices with
big minor numbers.
Don't use it any more as there are other ways to find the name (e.g. we
can read the symlink in /sys/dev/block/).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression code to handle big minor numbers
Sebastien GODARD [Fri, 24 Jul 2020 14:15:29 +0000 (16:15 +0200)]
Update non regression code to handle big minor numbers

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoAdd new non regression tests on big minor numbers
Sebastien GODARD [Fri, 24 Jul 2020 14:12:40 +0000 (16:12 +0200)]
Add new non regression tests on big minor numbers

Add new xvd* devices in sysstat environment tests.
One of them (xvdq) has a minor number value of 4096.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoAdd non regression test for sa1 --sleep option
Sebastien GODARD [Tue, 21 Jul 2020 16:45:28 +0000 (18:45 +0200)]
Add non regression test for sa1 --sleep option

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoCosmetic changes in code
Sebastien GODARD [Tue, 21 Jul 2020 16:42:29 +0000 (18:42 +0200)]
Cosmetic changes in code

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix gcc V10 warnings in sysstat 12.0.1 code used for test
Sebastien GODARD [Tue, 21 Jul 2020 16:36:11 +0000 (18:36 +0200)]
Fix gcc V10 warnings in sysstat 12.0.1 code used for test

The tests/ directory contains an old version of sysstat code (v 12.0.1)
used for non regression tests.
Compiling this version produces warnings with recent gcc v9/v10. Fix
them, even if we alter a bit the original 12.0.1 code.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix various comments in code and other files
Sebastien GODARD [Fri, 17 Jul 2020 15:49:33 +0000 (17:49 +0200)]
Fix various comments in code and other files

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoioconf.c: Remove some dead code
Sebastien GODARD [Wed, 1 Jul 2020 06:01:51 +0000 (08:01 +0200)]
ioconf.c: Remove some dead code

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoconfigure: Substitute WITH_DEBUG variable
Sebastien GODARD [Fri, 26 Jun 2020 15:49:05 +0000 (17:49 +0200)]
configure: Substitute WITH_DEBUG variable

Calling AC_SUBST(WITH_DEBUG) is needed for manual pages.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoTravis script line now calls do_test script
Sebastien GODARD [Sat, 20 Jun 2020 16:42:35 +0000 (18:42 +0200)]
Travis script line now calls do_test script

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUse --enable-debuginfo in do_test script
Sebastien GODARD [Sat, 20 Jun 2020 16:33:35 +0000 (18:33 +0200)]
Use --enable-debuginfo in do_test script

Use proper configure's option instead of using -D DEBUG.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoconfigure: Fix --enable-debuginfo option
Sebastien GODARD [Sat, 20 Jun 2020 16:24:12 +0000 (18:24 +0200)]
configure: Fix --enable-debuginfo option

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate help files used by iconfig script
Sebastien GODARD [Sat, 20 Jun 2020 08:55:08 +0000 (10:55 +0200)]
Update help files used by iconfig script

Add pcp file which was missing.
Fix a typo in another one.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMakefile: Remove all reports and data files if requested
Sebastien GODARD [Sat, 20 Jun 2020 08:36:26 +0000 (10:36 +0200)]
Makefile: Remove all reports and data files if requested

When option --enable-clean-sa-dir, sysstat used to remove compressed
reports and data files in /var/log/sa directory only when they had
been compressed using gzip.
Update Makefile to look for other compression programs. Also remove
files using the format saYYYYMMDD or sarYYYYMMDD.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoCompress manual pages by default when installed
Sebastien GODARD [Sat, 20 Jun 2020 07:40:32 +0000 (09:40 +0200)]
Compress manual pages by default when installed

Compress manual pages (using xz, bzip2 or gzip) by default when they are
installed.
Replace option --enable-compress-manpg with --disable-compress-manpg in
configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoconfigure: Remove obsolete autoconf macros
Sebastien GODARD [Sat, 20 Jun 2020 07:22:59 +0000 (09:22 +0200)]
configure: Remove obsolete autoconf macros

Don't use AC_HEADER_STDC and AC_HEADER_DIRENT macros in configure.in
script.
GNU autoconf manual says that these macros are obsolete and that new
code should no longer use them.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate manual pages again
Sebastien GODARD [Sun, 14 Jun 2020 07:15:25 +0000 (09:15 +0200)]
Update manual pages again

Explain that sysstat commands use kibibytes and mebibytes, but not
kilobytes and megabytes.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate manual pages
Sebastien GODARD [Sat, 13 Jun 2020 09:58:26 +0000 (11:58 +0200)]
Update manual pages

Tell that statistics are now displayed by default in color on a
terminal.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoDisplay statistics in color by default
Sebastien GODARD [Sat, 13 Jun 2020 09:55:28 +0000 (11:55 +0200)]
Display statistics in color by default

Display statistics in colors by default when the output is connected to
a terminal. It is no longer necessary to set the S_COLORS environment
variable.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Output format without option FO_LOCAL_TIME rejects option -T only
Sebastien GODARD [Sun, 7 Jun 2020 12:54:17 +0000 (14:54 +0200)]
sadf: Output format without option FO_LOCAL_TIME rejects option -T only

Output format wit option FO_LOCAL_TIME not set should only rejects
option -T, not option -t (use FO_NO_TRUE_TIME for that).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUse NULL as an argument for time() system call
Sebastien GODARD [Fri, 5 Jun 2020 15:45:22 +0000 (17:45 +0200)]
Use NULL as an argument for time() system call

According to the time(2) manual page, the argument passed to time()
system call is obsolescent and should always be NULL in new code.
When this argument is NULL, the call cannot fail.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge pull request #261 from tchebb/fix-index-usage
GODARD Sebastien [Fri, 5 Jun 2020 15:27:05 +0000 (17:27 +0200)]
Merge pull request #261 from tchebb/fix-index-usage

Replace index() call with strchr() call

4 years agoReplace index() call with strchr() call
Tom Hebb [Wed, 3 Jun 2020 18:57:21 +0000 (11:57 -0700)]
Replace index() call with strchr() call

According to glibc documentation[1], "index is another name for strchr;
they are exactly the same. New code should always use strchr." The use
of index() breaks compilation for Android targets, which use Bionic
instead of glibc and don't have index().

[1] https://www.gnu.org/software/libc/manual/html_node/Search-Functions.html#index-index

4 years agosa_common.c: Fix comment in code
Sebastien GODARD [Thu, 21 May 2020 08:40:27 +0000 (10:40 +0200)]
sa_common.c: Fix comment in code

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Thu, 21 May 2020 08:40:03 +0000 (10:40 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf_misc.c: Remove some dead code
Sebastien GODARD [Thu, 21 May 2020 07:27:10 +0000 (09:27 +0200)]
sadf_misc.c: Remove some dead code

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa1: Update manual page
Sebastien GODARD [Mon, 11 May 2020 13:48:55 +0000 (15:48 +0200)]
sa1: Update manual page

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa1: Insert a comment in daily datafile on system suspend/resume
Sebastien GODARD [Mon, 11 May 2020 13:43:15 +0000 (15:43 +0200)]
sa1: Insert a comment in daily datafile on system suspend/resume

Add a new option ("--sleep") to sa1 so that a comment can be inserted in
current daily datafile on system suspend/resume.
This comment can then be displayed using sar's option -C.
E.g.:

$ sar -C
Linux 5.6.10-300.fc32.x86_64 (localhost.localdomain)  05/11/2020  _x86_64_ (8 CPU)
02:53:05 PM  LINUX RESTART (8 CPU)

02:55:01 PM     CPU     %user     %nice   %system   %iowait    %steal     %idle
03:00:01 PM     all      1.66      0.00      1.27      0.17      0.00     96.89
03:10:01 PM     all      1.30      0.00      1.38      0.20      0.00     97.12
03:12:22 PM  COM LINUX SLEEP MODE (pre suspend)
03:14:55 PM  COM LINUX SLEEP MODE (post suspend)
03:15:31 PM     all      2.79      0.00      3.46      4.35      0.00     89.40
03:20:01 PM     all      0.66      0.00      0.82      0.13      0.00     98.39
Average:        all      3.50      0.00      3.53      0.78      0.00     92.19

"sa1 --sleep" will be called by sysstat.sleep script installed in
$systemdsleepdir directory if systemd is available.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa2: Wait for a random delay before running
Sebastien GODARD [Mon, 11 May 2020 08:04:17 +0000 (10:04 +0200)]
sa2: Wait for a random delay before running

Add a new option ("delay_range=") to configure script to tell sa2 script
to wait for a random delay in the indicated range before running.
This delay (expressed in seconds) is aimed at preventing a massive I/O
burst at the same time on VM sharing the same storage area.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoconfigure: Use AC_COMPILE_IFELSE instead of old AC_TRY_COMPILE macro
Sebastien GODARD [Sun, 10 May 2020 10:07:23 +0000 (12:07 +0200)]
configure: Use AC_COMPILE_IFELSE instead of old AC_TRY_COMPILE macro

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoconfigure: Add new option "--enable-use-crond"
Sebastien GODARD [Sun, 10 May 2020 08:57:53 +0000 (10:57 +0200)]
configure: Add new option "--enable-use-crond"

Add a new option to configuration script to tell it to use the standard
cron daemon (and the SysV standard files in /etc/rc.d/) even if systemd
is installed.
I have added this option because systemd seems currently broken on my
F32 distro.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix typos in sar manual page
Sebastien GODARD [Fri, 8 May 2020 09:49:01 +0000 (11:49 +0200)]
Fix typos in sar manual page

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoStarting sysstat-12.3.4
Sebastien GODARD [Fri, 8 May 2020 08:17:29 +0000 (10:17 +0200)]
Starting sysstat-12.3.4

Configure script updated.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosysstat-12.3.3 v12.3.3
Sebastien GODARD [Fri, 8 May 2020 08:02:41 +0000 (10:02 +0200)]
sysstat-12.3.3

sysstat version 12.3.3 final packaging.
lsm and spec files updated.
Changelog added.
Year of (C) message updated.

Exciting new features in this version include:

* sar/sadc collect and display Pressure-Stall Information statistics.
  These metrics have been added during the 4.20 development cycle of the
  Linux kernel. They can be displayed with "sar -q {CPU | LOAD | MEM}".

* iostat has gained support devices managed by drivers in userspace like
  spdk (see #257). New flags (-f / +f) have been added so that the user
  can specify an alternate location for statistics files.

This version also includes various bug fixes.
Enjoy!

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate NLS translations
Sebastien GODARD [Fri, 8 May 2020 07:25:05 +0000 (09:25 +0200)]
Update NLS translations

Sync with The Translation Project.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix GCC v10 warnings
Sebastien GODARD [Sun, 3 May 2020 07:05:58 +0000 (09:05 +0200)]
Fix GCC v10 warnings

GCC versions 9 and later complain more agressively, e.g.:

common.c: In function ‘get_wwnid_from_pretty’:
common.c:396:4: warning: ‘strncpy’ offset [275, 4095] from the object at ‘drd’ is out of the bounds of referenced subobject ‘d_name’ with type ‘char[256]’ at offset 19 [-Warray-bounds]
  396 |    strncpy(wwn_name, drd->d_name, sizeof(wwn_name));
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/dirent.h:61,
                 from common.c:32:
/usr/include/bits/dirent.h:33:10: note: subobject ‘d_name’ declared here
   33 |     char d_name[256];  /* We must not include limits.h! */
      |          ^~~~~~

or:

common.c: In function ‘get_persistent_name_path’:
common.c:876:37: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
  876 |  snprintf(path, sizeof(path), "%s/%s",
      |                                     ^
common.c:876:2: note: ‘snprintf’ output 2 or more bytes (assuming 4097) into a destination of size 4096
  876 |  snprintf(path, sizeof(path), "%s/%s",
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  877 |    get_persistent_type_dir(persistent_name_type), name);
      |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This patch quiets GCC.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoCosmetic fixes
Sebastien GODARD [Sun, 3 May 2020 06:55:12 +0000 (08:55 +0200)]
Cosmetic fixes

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge branch 'Sdrkun-master'
Sebastien GODARD [Fri, 1 May 2020 07:24:03 +0000 (09:24 +0200)]
Merge branch 'Sdrkun-master'

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa1: fix sar error when the directory var/log/sa was removed.
Sdrkun [Tue, 28 Apr 2020 14:31:54 +0000 (10:31 -0400)]
sa1: fix sar error when the directory var/log/sa was removed.

Signed-off-by: Sdrkun <shanzhikun@gmail.com>
4 years agocommon.c: Remove unused get_dev_part_nr() function
Sebastien GODARD [Mon, 27 Apr 2020 13:55:50 +0000 (15:55 +0200)]
common.c: Remove unused get_dev_part_nr() function

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add new non regression tests for iostat
Sebastien GODARD [Mon, 27 Apr 2020 13:38:40 +0000 (15:38 +0200)]
simtest: Add new non regression tests for iostat

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoAdd new flag to iostat that can be used to specify an alternate
Sebastien GODARD [Mon, 27 Apr 2020 13:17:28 +0000 (15:17 +0200)]
Add new flag to iostat that can be used to specify an alternate
directory for devices statistics.

Example:

iostat -f /altdir [...]
-> Use <altdir> directory to read devices statistics.

iostat +f /altdir [...]
-> Use standard kernel files *and* <altdir> to read devices statistics.

<altdir> is a directory containing files with statistics for devices
managed in userspace.

<altdir> may contain:
- a diskstats file whose format is compliant with that located in /proc.
- statistics for individual devices contained in files whose format is
compliant with that of files located in /sys.

In particular, the following files located in <altdir> may be used by
iostat:
<altdir>/block/<device>/stat
<altdir>/block/<device>/<partition>/stat

<partition> files must have an entry in <altdir>/dev/block/ directory,
e.g.:
<altdir>/dev/block/[major]:[minor] --> ../../block/<device>/<partition>

Notes:
1) iostat uses the /proc/diskstats file to read statistics only when
"-p all" has been entered on the command line (read statistics for all
the devices and their partitions).
2) iostat uses the /sys/block/<device>/stat files to read the statistics
for a device (e.g. "iostat sda") and possibly all its partitions
(e.g. "iostat -p sda").
3) iostat uses the link in /sys/dev/block/[major]:[minor] to know where
the stat file is located for a partition that has been entered on the
command line (e.g. "iostat sda3"). The partition must exist in /dev to
get its major and minor numbers.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #256: sar: Don't display duplicate entries in /etc/mtab
Sebastien GODARD [Sat, 25 Apr 2020 09:08:40 +0000 (11:08 +0200)]
Fix #256: sar: Don't display duplicate entries in /etc/mtab

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add overlay and duplicate filesystem entries to etc/mtab
Sebastien GODARD [Sat, 25 Apr 2020 08:57:01 +0000 (10:57 +0200)]
simtest: Add overlay and duplicate filesystem entries to etc/mtab

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add tests for sadf "hz=" option
Sebastien GODARD [Sat, 25 Apr 2020 07:36:46 +0000 (09:36 +0200)]
simtest: Add tests for sadf "hz=" option

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Don't check if we are close enough to selected interval when
Sebastien GODARD [Sat, 25 Apr 2020 07:35:38 +0000 (09:35 +0200)]
sar: Don't check if we are close enough to selected interval when
interval=1

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update manual page
Sebastien GODARD [Sat, 25 Apr 2020 07:34:57 +0000 (09:34 +0200)]
sadf: Update manual page

Explain new option "hz=" for sadf -c.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Add option "hz=" for datafile conversion
Sebastien GODARD [Sat, 25 Apr 2020 07:31:56 +0000 (09:31 +0200)]
sadf: Add option "hz=" for datafile conversion

Add a new option to be used with "sadf -c" (datafile conversion).
This option enables the user to specify the number of ticks per second
for the machine where the datafile to be converted was created.
E.g.:
sadf -c old_datafile -O hz=250 > new_datafile

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 07:28:22 +0000 (09:28 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Use actual number of items, not its pointer address
Sebastien GODARD [Sun, 19 Apr 2020 07:13:58 +0000 (09:13 +0200)]
sadf: Use actual number of items, not its pointer address

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:47:37 +0000 (08:47 +0200)]
Update non regression tests

"per" attribute is no longer required for XML output memory activity.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate DTD and XSD documents
Sebastien GODARD [Sun, 19 Apr 2020 06:46:58 +0000 (08:46 +0200)]
Update DTD and XSD documents

Remove the "per" attribute for memory activity.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: XML: Remove "per" attribute for memory activity
Sebastien GODARD [Sun, 19 Apr 2020 06:45:19 +0000 (08:45 +0200)]
sadf: XML: Remove "per" attribute for memory activity

All memory statistics are not "per second" values.
So remove this attribute from the XML output.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:38:34 +0000 (08:38 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Don't display "Inconsistent input data" when no activities are
Sebastien GODARD [Sun, 19 Apr 2020 06:36:04 +0000 (08:36 +0200)]
sar: Don't display "Inconsistent input data" when no activities are
collected by sadc

When no activities are collected by sadc, sadc writes an error message
("Requested activities not available").
sar used to display a second error message in addition to the previous
one ("Inconsistent input data"). Remove this one.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Add new non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:16:21 +0000 (08:16 +0200)]
PSI: Add new non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadc: Check that PSI statistics can be collected
Sebastien GODARD [Sun, 19 Apr 2020 06:11:33 +0000 (08:11 +0200)]
sadc: Check that PSI statistics can be collected

Check that /proc/pressure directory exists for PSI statistics to be
collected.
Add all the necessary code that will be reusable to check if an activity
can be collected by sadc.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopr_stats.c: Printing timestamp should appear only once
Sebastien GODARD [Sat, 18 Apr 2020 07:41:14 +0000 (09:41 +0200)]
pr_stats.c: Printing timestamp should appear only once

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Add new non regression tests
Sebastien GODARD [Sat, 18 Apr 2020 07:04:08 +0000 (09:04 +0200)]
PSI: Add new non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Update manual pages
Sebastien GODARD [Sat, 18 Apr 2020 06:34:58 +0000 (08:34 +0200)]
sar: PSI: Update manual pages

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sat, 18 Apr 2020 06:29:58 +0000 (08:29 +0200)]
Update non regression tests

Take into account the change concerning PSI metrics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Update help message
Sebastien GODARD [Sat, 18 Apr 2020 06:28:25 +0000 (08:28 +0200)]
sar: Update help message

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate DTD and XSD documents
Sebastien GODARD [Sat, 18 Apr 2020 06:27:27 +0000 (08:27 +0200)]
Update DTD and XSD documents

Take into account new PSI metrics names

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: PSI: Change metrics names and make them percent values
Sebastien GODARD [Sat, 18 Apr 2020 06:23:33 +0000 (08:23 +0200)]
sadf: PSI: Change metrics names and make them percent values

Change PSI metrics names (e.g. s_acpu10 -> %scpu-10) to make clear that
they are percent values.
Also change metrics using the total number of microseconds spent stalled
on ressources to also be a percent value calculated over the past time
interval (e.g. s_tcpu/s -> %scpu).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Update non regression tests results
Sebastien GODARD [Tue, 14 Apr 2020 11:48:12 +0000 (13:48 +0200)]
PSI: Update non regression tests results

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Print ratios as percentage values
Sebastien GODARD [Tue, 14 Apr 2020 11:46:07 +0000 (13:46 +0200)]
sar: PSI: Print ratios as percentage values

Make sure pressure-stall average values are considered as percentage
values, so that they will be displayed with a '%' sign if option --human
is used.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update DTD and XSD documents
Sebastien GODARD [Tue, 14 Apr 2020 11:44:43 +0000 (13:44 +0200)]
sadf: Update DTD and XSD documents

Take into account PSI statistics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Fix PSI memory file name
Sebastien GODARD [Tue, 14 Apr 2020 11:43:08 +0000 (13:43 +0200)]
sar: Fix PSI memory file name

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: PCP: Add PSI support
Sebastien GODARD [Tue, 14 Apr 2020 08:15:15 +0000 (10:15 +0200)]
sadf: PCP: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: SVG: Add PSI support
Sebastien GODARD [Mon, 13 Apr 2020 09:37:40 +0000 (11:37 +0200)]
sadf: SVG: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: JSON: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 14:09:12 +0000 (16:09 +0200)]
sadf: JSON: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: XML: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 12:16:29 +0000 (14:16 +0200)]
sadf: XML: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Cosmetic changes
Sebastien GODARD [Sun, 12 Apr 2020 12:16:00 +0000 (14:16 +0200)]
sadf: Cosmetic changes

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: RAW: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 09:22:04 +0000 (11:22 +0200)]
sadf: RAW: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: CSV/ppc: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 09:03:38 +0000 (11:03 +0200)]
sadf: CSV/ppc: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update option -q to support PSI statistics
Sebastien GODARD [Sun, 12 Apr 2020 09:00:20 +0000 (11:00 +0200)]
sadf: Update option -q to support PSI statistics

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Display pressure-stall statistics
Sebastien GODARD [Sun, 12 Apr 2020 08:31:20 +0000 (10:31 +0200)]
sar: PSI: Display pressure-stall statistics

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Add PSI keyword to option -q
Sebastien GODARD [Sun, 12 Apr 2020 08:29:46 +0000 (10:29 +0200)]
sar: Add PSI keyword to option -q

Specifying "sar -q PSI" will be equivalent to "sar -q CPU,MEM,IO".

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Read PSI statistics
Sebastien GODARD [Sat, 11 Apr 2020 13:34:14 +0000 (15:34 +0200)]
sar: PSI: Read PSI statistics

Read statistics from /proc/pressure/* files.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #233: sar: PSI: Basic definitions
Sebastien GODARD [Sat, 11 Apr 2020 13:18:31 +0000 (15:18 +0200)]
Fix #233: sar: PSI: Basic definitions

This is the first patch to add support for pressure-stall information
(PSI) to sar.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoStarting sysstat-12.3.3
Sebastien GODARD [Fri, 10 Apr 2020 07:42:02 +0000 (09:42 +0200)]
Starting sysstat-12.3.3

Update sysstat version number in configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosysstat-12.3.2 v12.3.2
Sebastien GODARD [Fri, 10 Apr 2020 07:37:28 +0000 (09:37 +0200)]
sysstat-12.3.2

sysstat version 12.3.2 final packaging.
lsm and spec files updated.
Changelog added.

pidstat and cifsiostat commands have been largely rewritten in this
version. In particular they now use a linked list with dynamic
allocation for all the items being monitored. Memory footprint should be
reduced. Last, several bugs have been fixed in pidstat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate NLS translations
Sebastien GODARD [Fri, 10 Apr 2020 07:24:04 +0000 (09:24 +0200)]
Update NLS translations

Sync with The Translation Project

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate configure script
Sebastien GODARD [Mon, 6 Apr 2020 15:32:34 +0000 (17:32 +0200)]
Update configure script

Take into account commit 1b4185b.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge branch 'ffontaine-master'
Sebastien GODARD [Mon, 6 Apr 2020 15:30:29 +0000 (17:30 +0200)]
Merge branch 'ffontaine-master'

4 years agoLink with -lintl if needed
Fabrice Fontaine [Sun, 5 Apr 2020 13:39:50 +0000 (15:39 +0200)]
Link with -lintl if needed

Some libc implementations like uclibc or musl provides
gettext stubs via libintl library. Without it, build will fail on:

/home/fabrice/buildroot/output/host/bin/arm-linux-gcc -o cifsiostat -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os   -Wall -Wstrict-prototypes -pipe -O2 cifsiostat.o librdstats_light.a libsyscom.a -s
/home/fabrice/buildroot/output/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-musleabihf/8.3.0/../../../../arm-buildroot-linux-musleabihf/bin/ld: tapestat.o: in function `usage':
tapestat.c:(.text+0x44c): undefined reference to `libintl_gettext'

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
4 years agopidstat: Remove unused global variable
Sebastien GODARD [Sun, 5 Apr 2020 07:50:55 +0000 (09:50 +0200)]
pidstat: Remove unused global variable

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Major code refactoring
Sebastien GODARD [Sun, 5 Apr 2020 07:49:56 +0000 (09:49 +0200)]
cifsiostat: Major code refactoring

Now use a linked list with dynamic allocation to save CIFS filesystems.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #228: pidstat's -l replaces "\0" with " ", displaying unnecesary data
Sebastien GODARD [Sat, 4 Apr 2020 08:45:48 +0000 (10:45 +0200)]
Fix #228: pidstat's -l replaces "\0" with " ", displaying unnecesary data

Fix issue #228.
Also add use cases to simulation test environment.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add a new non regression test
Sebastien GODARD [Sat, 4 Apr 2020 07:54:07 +0000 (09:54 +0200)]
pidstat: Add a new non regression test

This is to test pidstat's option -e.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add a replacement function for fork()
Sebastien GODARD [Sat, 4 Apr 2020 07:53:23 +0000 (09:53 +0200)]
pidstat: Add a replacement function for fork()

The replacement function will be used in a non regression test.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Update non regression tests
Sebastien GODARD [Sat, 4 Apr 2020 07:24:54 +0000 (09:24 +0200)]
pidstat: Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Major code refactoring
Sebastien GODARD [Sat, 4 Apr 2020 07:19:04 +0000 (09:19 +0200)]
pidstat: Major code refactoring

Now use a linked list and dynamic allocatin to save tasks being
monitored.
Also fix several bugs that were lurking in previous pidstat version,
like threads that were displayed as attached to the wrong thread leader
if their real leader was not displayed because it was not an active
task.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Make sure pointer on linked list has been initialized
Sebastien GODARD [Sat, 4 Apr 2020 07:17:48 +0000 (09:17 +0200)]
iostat: Make sure pointer on linked list has been initialized

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>