]> granicus.if.org Git - sysstat/log
sysstat
4 years agosysstat-12.3.3 v12.3.3
Sebastien GODARD [Fri, 8 May 2020 08:02:41 +0000 (10:02 +0200)]
sysstat-12.3.3

sysstat version 12.3.3 final packaging.
lsm and spec files updated.
Changelog added.
Year of (C) message updated.

Exciting new features in this version include:

* sar/sadc collect and display Pressure-Stall Information statistics.
  These metrics have been added during the 4.20 development cycle of the
  Linux kernel. They can be displayed with "sar -q {CPU | LOAD | MEM}".

* iostat has gained support devices managed by drivers in userspace like
  spdk (see #257). New flags (-f / +f) have been added so that the user
  can specify an alternate location for statistics files.

This version also includes various bug fixes.
Enjoy!

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate NLS translations
Sebastien GODARD [Fri, 8 May 2020 07:25:05 +0000 (09:25 +0200)]
Update NLS translations

Sync with The Translation Project.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix GCC v10 warnings
Sebastien GODARD [Sun, 3 May 2020 07:05:58 +0000 (09:05 +0200)]
Fix GCC v10 warnings

GCC versions 9 and later complain more agressively, e.g.:

common.c: In function ‘get_wwnid_from_pretty’:
common.c:396:4: warning: ‘strncpy’ offset [275, 4095] from the object at ‘drd’ is out of the bounds of referenced subobject ‘d_name’ with type ‘char[256]’ at offset 19 [-Warray-bounds]
  396 |    strncpy(wwn_name, drd->d_name, sizeof(wwn_name));
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/dirent.h:61,
                 from common.c:32:
/usr/include/bits/dirent.h:33:10: note: subobject ‘d_name’ declared here
   33 |     char d_name[256];  /* We must not include limits.h! */
      |          ^~~~~~

or:

common.c: In function ‘get_persistent_name_path’:
common.c:876:37: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
  876 |  snprintf(path, sizeof(path), "%s/%s",
      |                                     ^
common.c:876:2: note: ‘snprintf’ output 2 or more bytes (assuming 4097) into a destination of size 4096
  876 |  snprintf(path, sizeof(path), "%s/%s",
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  877 |    get_persistent_type_dir(persistent_name_type), name);
      |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This patch quiets GCC.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoCosmetic fixes
Sebastien GODARD [Sun, 3 May 2020 06:55:12 +0000 (08:55 +0200)]
Cosmetic fixes

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge branch 'Sdrkun-master'
Sebastien GODARD [Fri, 1 May 2020 07:24:03 +0000 (09:24 +0200)]
Merge branch 'Sdrkun-master'

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa1: fix sar error when the directory var/log/sa was removed.
Sdrkun [Tue, 28 Apr 2020 14:31:54 +0000 (10:31 -0400)]
sa1: fix sar error when the directory var/log/sa was removed.

Signed-off-by: Sdrkun <shanzhikun@gmail.com>
4 years agocommon.c: Remove unused get_dev_part_nr() function
Sebastien GODARD [Mon, 27 Apr 2020 13:55:50 +0000 (15:55 +0200)]
common.c: Remove unused get_dev_part_nr() function

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add new non regression tests for iostat
Sebastien GODARD [Mon, 27 Apr 2020 13:38:40 +0000 (15:38 +0200)]
simtest: Add new non regression tests for iostat

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoAdd new flag to iostat that can be used to specify an alternate
Sebastien GODARD [Mon, 27 Apr 2020 13:17:28 +0000 (15:17 +0200)]
Add new flag to iostat that can be used to specify an alternate
directory for devices statistics.

Example:

iostat -f /altdir [...]
-> Use <altdir> directory to read devices statistics.

iostat +f /altdir [...]
-> Use standard kernel files *and* <altdir> to read devices statistics.

<altdir> is a directory containing files with statistics for devices
managed in userspace.

<altdir> may contain:
- a diskstats file whose format is compliant with that located in /proc.
- statistics for individual devices contained in files whose format is
compliant with that of files located in /sys.

In particular, the following files located in <altdir> may be used by
iostat:
<altdir>/block/<device>/stat
<altdir>/block/<device>/<partition>/stat

<partition> files must have an entry in <altdir>/dev/block/ directory,
e.g.:
<altdir>/dev/block/[major]:[minor] --> ../../block/<device>/<partition>

Notes:
1) iostat uses the /proc/diskstats file to read statistics only when
"-p all" has been entered on the command line (read statistics for all
the devices and their partitions).
2) iostat uses the /sys/block/<device>/stat files to read the statistics
for a device (e.g. "iostat sda") and possibly all its partitions
(e.g. "iostat -p sda").
3) iostat uses the link in /sys/dev/block/[major]:[minor] to know where
the stat file is located for a partition that has been entered on the
command line (e.g. "iostat sda3"). The partition must exist in /dev to
get its major and minor numbers.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #256: sar: Don't display duplicate entries in /etc/mtab
Sebastien GODARD [Sat, 25 Apr 2020 09:08:40 +0000 (11:08 +0200)]
Fix #256: sar: Don't display duplicate entries in /etc/mtab

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add overlay and duplicate filesystem entries to etc/mtab
Sebastien GODARD [Sat, 25 Apr 2020 08:57:01 +0000 (10:57 +0200)]
simtest: Add overlay and duplicate filesystem entries to etc/mtab

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add tests for sadf "hz=" option
Sebastien GODARD [Sat, 25 Apr 2020 07:36:46 +0000 (09:36 +0200)]
simtest: Add tests for sadf "hz=" option

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Don't check if we are close enough to selected interval when
Sebastien GODARD [Sat, 25 Apr 2020 07:35:38 +0000 (09:35 +0200)]
sar: Don't check if we are close enough to selected interval when
interval=1

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update manual page
Sebastien GODARD [Sat, 25 Apr 2020 07:34:57 +0000 (09:34 +0200)]
sadf: Update manual page

Explain new option "hz=" for sadf -c.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Add option "hz=" for datafile conversion
Sebastien GODARD [Sat, 25 Apr 2020 07:31:56 +0000 (09:31 +0200)]
sadf: Add option "hz=" for datafile conversion

Add a new option to be used with "sadf -c" (datafile conversion).
This option enables the user to specify the number of ticks per second
for the machine where the datafile to be converted was created.
E.g.:
sadf -c old_datafile -O hz=250 > new_datafile

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 07:28:22 +0000 (09:28 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Use actual number of items, not its pointer address
Sebastien GODARD [Sun, 19 Apr 2020 07:13:58 +0000 (09:13 +0200)]
sadf: Use actual number of items, not its pointer address

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:47:37 +0000 (08:47 +0200)]
Update non regression tests

"per" attribute is no longer required for XML output memory activity.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate DTD and XSD documents
Sebastien GODARD [Sun, 19 Apr 2020 06:46:58 +0000 (08:46 +0200)]
Update DTD and XSD documents

Remove the "per" attribute for memory activity.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: XML: Remove "per" attribute for memory activity
Sebastien GODARD [Sun, 19 Apr 2020 06:45:19 +0000 (08:45 +0200)]
sadf: XML: Remove "per" attribute for memory activity

All memory statistics are not "per second" values.
So remove this attribute from the XML output.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:38:34 +0000 (08:38 +0200)]
Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Don't display "Inconsistent input data" when no activities are
Sebastien GODARD [Sun, 19 Apr 2020 06:36:04 +0000 (08:36 +0200)]
sar: Don't display "Inconsistent input data" when no activities are
collected by sadc

When no activities are collected by sadc, sadc writes an error message
("Requested activities not available").
sar used to display a second error message in addition to the previous
one ("Inconsistent input data"). Remove this one.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Add new non regression tests
Sebastien GODARD [Sun, 19 Apr 2020 06:16:21 +0000 (08:16 +0200)]
PSI: Add new non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadc: Check that PSI statistics can be collected
Sebastien GODARD [Sun, 19 Apr 2020 06:11:33 +0000 (08:11 +0200)]
sadc: Check that PSI statistics can be collected

Check that /proc/pressure directory exists for PSI statistics to be
collected.
Add all the necessary code that will be reusable to check if an activity
can be collected by sadc.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopr_stats.c: Printing timestamp should appear only once
Sebastien GODARD [Sat, 18 Apr 2020 07:41:14 +0000 (09:41 +0200)]
pr_stats.c: Printing timestamp should appear only once

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Add new non regression tests
Sebastien GODARD [Sat, 18 Apr 2020 07:04:08 +0000 (09:04 +0200)]
PSI: Add new non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Update manual pages
Sebastien GODARD [Sat, 18 Apr 2020 06:34:58 +0000 (08:34 +0200)]
sar: PSI: Update manual pages

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate non regression tests
Sebastien GODARD [Sat, 18 Apr 2020 06:29:58 +0000 (08:29 +0200)]
Update non regression tests

Take into account the change concerning PSI metrics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Update help message
Sebastien GODARD [Sat, 18 Apr 2020 06:28:25 +0000 (08:28 +0200)]
sar: Update help message

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate DTD and XSD documents
Sebastien GODARD [Sat, 18 Apr 2020 06:27:27 +0000 (08:27 +0200)]
Update DTD and XSD documents

Take into account new PSI metrics names

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: PSI: Change metrics names and make them percent values
Sebastien GODARD [Sat, 18 Apr 2020 06:23:33 +0000 (08:23 +0200)]
sadf: PSI: Change metrics names and make them percent values

Change PSI metrics names (e.g. s_acpu10 -> %scpu-10) to make clear that
they are percent values.
Also change metrics using the total number of microseconds spent stalled
on ressources to also be a percent value calculated over the past time
interval (e.g. s_tcpu/s -> %scpu).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoPSI: Update non regression tests results
Sebastien GODARD [Tue, 14 Apr 2020 11:48:12 +0000 (13:48 +0200)]
PSI: Update non regression tests results

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Print ratios as percentage values
Sebastien GODARD [Tue, 14 Apr 2020 11:46:07 +0000 (13:46 +0200)]
sar: PSI: Print ratios as percentage values

Make sure pressure-stall average values are considered as percentage
values, so that they will be displayed with a '%' sign if option --human
is used.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update DTD and XSD documents
Sebastien GODARD [Tue, 14 Apr 2020 11:44:43 +0000 (13:44 +0200)]
sadf: Update DTD and XSD documents

Take into account PSI statistics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Fix PSI memory file name
Sebastien GODARD [Tue, 14 Apr 2020 11:43:08 +0000 (13:43 +0200)]
sar: Fix PSI memory file name

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: PCP: Add PSI support
Sebastien GODARD [Tue, 14 Apr 2020 08:15:15 +0000 (10:15 +0200)]
sadf: PCP: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: SVG: Add PSI support
Sebastien GODARD [Mon, 13 Apr 2020 09:37:40 +0000 (11:37 +0200)]
sadf: SVG: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: JSON: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 14:09:12 +0000 (16:09 +0200)]
sadf: JSON: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: XML: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 12:16:29 +0000 (14:16 +0200)]
sadf: XML: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Cosmetic changes
Sebastien GODARD [Sun, 12 Apr 2020 12:16:00 +0000 (14:16 +0200)]
sadf: Cosmetic changes

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: RAW: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 09:22:04 +0000 (11:22 +0200)]
sadf: RAW: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: CSV/ppc: Add PSI support
Sebastien GODARD [Sun, 12 Apr 2020 09:03:38 +0000 (11:03 +0200)]
sadf: CSV/ppc: Add PSI support

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosadf: Update option -q to support PSI statistics
Sebastien GODARD [Sun, 12 Apr 2020 09:00:20 +0000 (11:00 +0200)]
sadf: Update option -q to support PSI statistics

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Display pressure-stall statistics
Sebastien GODARD [Sun, 12 Apr 2020 08:31:20 +0000 (10:31 +0200)]
sar: PSI: Display pressure-stall statistics

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: Add PSI keyword to option -q
Sebastien GODARD [Sun, 12 Apr 2020 08:29:46 +0000 (10:29 +0200)]
sar: Add PSI keyword to option -q

Specifying "sar -q PSI" will be equivalent to "sar -q CPU,MEM,IO".

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosar: PSI: Read PSI statistics
Sebastien GODARD [Sat, 11 Apr 2020 13:34:14 +0000 (15:34 +0200)]
sar: PSI: Read PSI statistics

Read statistics from /proc/pressure/* files.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #233: sar: PSI: Basic definitions
Sebastien GODARD [Sat, 11 Apr 2020 13:18:31 +0000 (15:18 +0200)]
Fix #233: sar: PSI: Basic definitions

This is the first patch to add support for pressure-stall information
(PSI) to sar.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoStarting sysstat-12.3.3
Sebastien GODARD [Fri, 10 Apr 2020 07:42:02 +0000 (09:42 +0200)]
Starting sysstat-12.3.3

Update sysstat version number in configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosysstat-12.3.2 v12.3.2
Sebastien GODARD [Fri, 10 Apr 2020 07:37:28 +0000 (09:37 +0200)]
sysstat-12.3.2

sysstat version 12.3.2 final packaging.
lsm and spec files updated.
Changelog added.

pidstat and cifsiostat commands have been largely rewritten in this
version. In particular they now use a linked list with dynamic
allocation for all the items being monitored. Memory footprint should be
reduced. Last, several bugs have been fixed in pidstat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate NLS translations
Sebastien GODARD [Fri, 10 Apr 2020 07:24:04 +0000 (09:24 +0200)]
Update NLS translations

Sync with The Translation Project

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate configure script
Sebastien GODARD [Mon, 6 Apr 2020 15:32:34 +0000 (17:32 +0200)]
Update configure script

Take into account commit 1b4185b.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge branch 'ffontaine-master'
Sebastien GODARD [Mon, 6 Apr 2020 15:30:29 +0000 (17:30 +0200)]
Merge branch 'ffontaine-master'

4 years agoLink with -lintl if needed
Fabrice Fontaine [Sun, 5 Apr 2020 13:39:50 +0000 (15:39 +0200)]
Link with -lintl if needed

Some libc implementations like uclibc or musl provides
gettext stubs via libintl library. Without it, build will fail on:

/home/fabrice/buildroot/output/host/bin/arm-linux-gcc -o cifsiostat -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os   -Wall -Wstrict-prototypes -pipe -O2 cifsiostat.o librdstats_light.a libsyscom.a -s
/home/fabrice/buildroot/output/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-musleabihf/8.3.0/../../../../arm-buildroot-linux-musleabihf/bin/ld: tapestat.o: in function `usage':
tapestat.c:(.text+0x44c): undefined reference to `libintl_gettext'

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
4 years agopidstat: Remove unused global variable
Sebastien GODARD [Sun, 5 Apr 2020 07:50:55 +0000 (09:50 +0200)]
pidstat: Remove unused global variable

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Major code refactoring
Sebastien GODARD [Sun, 5 Apr 2020 07:49:56 +0000 (09:49 +0200)]
cifsiostat: Major code refactoring

Now use a linked list with dynamic allocation to save CIFS filesystems.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #228: pidstat's -l replaces "\0" with " ", displaying unnecesary data
Sebastien GODARD [Sat, 4 Apr 2020 08:45:48 +0000 (10:45 +0200)]
Fix #228: pidstat's -l replaces "\0" with " ", displaying unnecesary data

Fix issue #228.
Also add use cases to simulation test environment.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add a new non regression test
Sebastien GODARD [Sat, 4 Apr 2020 07:54:07 +0000 (09:54 +0200)]
pidstat: Add a new non regression test

This is to test pidstat's option -e.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add a replacement function for fork()
Sebastien GODARD [Sat, 4 Apr 2020 07:53:23 +0000 (09:53 +0200)]
pidstat: Add a replacement function for fork()

The replacement function will be used in a non regression test.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Update non regression tests
Sebastien GODARD [Sat, 4 Apr 2020 07:24:54 +0000 (09:24 +0200)]
pidstat: Update non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Major code refactoring
Sebastien GODARD [Sat, 4 Apr 2020 07:19:04 +0000 (09:19 +0200)]
pidstat: Major code refactoring

Now use a linked list and dynamic allocatin to save tasks being
monitored.
Also fix several bugs that were lurking in previous pidstat version,
like threads that were displayed as attached to the wrong thread leader
if their real leader was not displayed because it was not an active
task.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Make sure pointer on linked list has been initialized
Sebastien GODARD [Sat, 4 Apr 2020 07:17:48 +0000 (09:17 +0200)]
iostat: Make sure pointer on linked list has been initialized

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add new non regression tests
Sebastien GODARD [Sun, 22 Mar 2020 08:55:58 +0000 (09:55 +0100)]
pidstat: Add new non regression tests

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Remove extra space at end of command name
Sebastien GODARD [Sat, 21 Mar 2020 09:22:35 +0000 (10:22 +0100)]
pidstat: Remove extra space at end of command name

When pidstat was used with option "-l" to display the command name and
all its arguments, a space was added at the end after all the arguments.
Remove it as it is unneeded and it may prevent the user from displaying
lines based on a pattern located at the end of line
(e.g. pidstat -l -C "pattern$" ...)

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix sa2 script, so it wont complain about "unrecognized archive format"
Anatoly Pugachev [Sun, 15 Mar 2020 23:56:12 +0000 (02:56 +0300)]
Fix sa2 script, so it wont complain about "unrecognized archive format"
on empty list for compress program.

Signed-off-by: Anatoly Pugachev <matorola@gmail.com>
4 years agopidstat: Add new non regression tests
Sebastien GODARD [Wed, 11 Mar 2020 17:41:06 +0000 (18:41 +0100)]
pidstat: Add new non regression tests

New non regression tests for the pidstat command. Tests should be run in
sysstat simulation environment (use do_test script).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Cosmetic updates
Sebastien GODARD [Wed, 11 Mar 2020 17:38:38 +0000 (18:38 +0100)]
pidstat: Cosmetic updates

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add non regression tests
Sebastien GODARD [Sat, 8 Feb 2020 17:08:31 +0000 (18:08 +0100)]
pidstat: Add non regression tests

First tests set for pidstat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Add a replacement function for getpwuid()
Sebastien GODARD [Sat, 1 Feb 2020 13:47:31 +0000 (14:47 +0100)]
pidstat: Add a replacement function for getpwuid()

This replacement function will be used in tests environment.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agopidstat: Set up test environment
Sebastien GODARD [Wed, 29 Jan 2020 10:21:11 +0000 (11:21 +0100)]
pidstat: Set up test environment

Update pidstat for use in non regression tests.
Create all the necessary files in tests directory.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Add new ng tests for flush I/Os
Sebastien GODARD [Sun, 29 Dec 2019 08:39:53 +0000 (09:39 +0100)]
iostat: Add new ng tests for flush I/Os

Test part of iostat code which reads flush I/O operations using
/sys/block/xxx/stat file (instead of /proc/diskstats file).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoStarting sysstat-12.3.2
Sebastien GODARD [Fri, 27 Dec 2019 13:13:30 +0000 (14:13 +0100)]
Starting sysstat-12.3.2

Update sysstat version number in configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosysstat-12.3.1 v12.3.1
Sebastien GODARD [Fri, 27 Dec 2019 12:58:17 +0000 (13:58 +0100)]
sysstat-12.3.1

sysstat version 12.3.1 final packaging.
lsm and spec files updated.
Changelog added.

This version includes new interesting features such as:
* the possibility to display system topology (logical core, socket and
NUMA node numbers) with mpstat,
* statistics for flush I/O operations with iostat,
* and the support for SMB2 version of statistics file for the cifsiostat
command.

It also fixes some bugs concerning iostat and sadf. Enjoy!

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoUpdate NLS translations
Sebastien GODARD [Fri, 27 Dec 2019 12:35:54 +0000 (13:35 +0100)]
Update NLS translations

Sync with the Translation Project.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Add ng tests for flush I/Os statistics
Sebastien GODARD [Mon, 23 Dec 2019 10:55:26 +0000 (11:55 +0100)]
iostat: Add ng tests for flush I/Os statistics

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Make code a bit more solid
Sebastien GODARD [Mon, 23 Dec 2019 10:52:59 +0000 (11:52 +0100)]
iostat: Make code a bit more solid

Add some extra verifications even though flush operations are normally
counted as writes before being merged.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Update non regression tests results
Sebastien GODARD [Mon, 23 Dec 2019 09:56:54 +0000 (10:56 +0100)]
iostat: Update non regression tests results

Take into account flush operations statistics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat.h: Update comment
Sebastien GODARD [Sun, 22 Dec 2019 11:06:51 +0000 (12:06 +0100)]
iostat.h: Update comment

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Indicate that flush ops are counted as writes before being
Sebastien GODARD [Sun, 22 Dec 2019 11:05:36 +0000 (12:05 +0100)]
iostat: Indicate that flush ops are counted as writes before being
merged

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge branch 'koct9i-flush'
Sebastien GODARD [Sat, 21 Dec 2019 17:21:09 +0000 (18:21 +0100)]
Merge branch 'koct9i-flush'

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Add flush I/O statistics
Konstantin Khlebnikov [Sun, 15 Dec 2019 09:29:28 +0000 (12:29 +0300)]
iostat: Add flush I/O statistics

Statistics for flush operations have been added into Linux 5.5

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b6866318657717c8914673a6394894d12bc9ff5e
4 years agoFix #243: Heap overflow in logic2_display_loop()
Sebastien GODARD [Sun, 15 Dec 2019 17:38:49 +0000 (18:38 +0100)]
Fix #243: Heap overflow in logic2_display_loop()

Make sure that all tests from check_file_actlst() function are done on a
data file, even if this file has activities with unknown formats.
"sadf -H" and, e.g., "sadf -Hx" should as a consequence behave the same.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoFix #242: Double free in check_file_actlst()
Sebastien GODARD [Mon, 9 Dec 2019 16:54:07 +0000 (17:54 +0100)]
Fix #242: Double free in check_file_actlst()

Avoid freeing buffer() twice.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Fix compilation warning
Sebastien GODARD [Mon, 9 Dec 2019 16:22:58 +0000 (17:22 +0100)]
cifsiostat: Fix compilation warning

Fix wrong type used to read number of open files.

cifsiostat.c:398:18: warning: format ‘%d’ expects argument of type ‘int *’, but argument 4 has type ‘long long unsigned int *’ [-Wformat=]

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Add SMB2 non regression test
Sebastien GODARD [Fri, 6 Dec 2019 15:44:19 +0000 (16:44 +0100)]
cifsiostat: Add SMB2 non regression test

Test cifsiostat output using /proc/fs/cifs/Stats file with SMB2 format.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Add support for SMB2 version
Sebastien GODARD [Fri, 6 Dec 2019 14:40:22 +0000 (15:40 +0100)]
cifsiostat: Add support for SMB2 version

The /proc/fs/cifs/Stat file format is different between SMB1 and SMB2
versions. Now support both of them.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agocifsiostat: Add non regression tests
Sebastien GODARD [Fri, 6 Dec 2019 10:49:46 +0000 (11:49 +0100)]
cifsiostat: Add non regression tests

Add non regression tests for cifsiostat command.
These tests are intended to be run in sysstat's simulation test
environment (use do_test script).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agotapestat: Add non regression tests
Sebastien GODARD [Fri, 6 Dec 2019 08:45:53 +0000 (09:45 +0100)]
tapestat: Add non regression tests

Add non regression tests for tapestat command.
These tests are intended to be run in sysstat's simulation test
environment (use do_test script).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Add new non regression tests
Sebastien GODARD [Mon, 25 Nov 2019 08:09:18 +0000 (09:09 +0100)]
mpstat: Add new non regression tests

Add new non regression tests for topology and JSON output.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Display negative values if topology cannot be read
Sebastien GODARD [Mon, 25 Nov 2019 07:37:44 +0000 (08:37 +0100)]
mpstat: Display negative values if topology cannot be read

Display socket and core numbers as -1 if the topology couldn't be read.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge pull request #239 from maxice8/fix-musl-includes
GODARD Sebastien [Mon, 25 Nov 2019 07:20:40 +0000 (08:20 +0100)]
Merge pull request #239 from maxice8/fix-musl-includes

add missing includes for musl

4 years agoadd missing includes for musl
Leo [Sun, 24 Nov 2019 18:11:19 +0000 (19:11 +0100)]
add missing includes for musl

4 years agosimtest: Add new non regression tests for iostat
Sebastien GODARD [Sun, 24 Nov 2019 10:45:58 +0000 (11:45 +0100)]
simtest: Add new non regression tests for iostat

Test iostat values for  JSON output format.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoiostat: Fix wrong unit used in JSON output
Sebastien GODARD [Sun, 24 Nov 2019 07:55:40 +0000 (08:55 +0100)]
iostat: Fix wrong unit used in JSON output

The values for the amount of data read/written or discarded were always
expressed in blocks/s in the JSON output generated by iostat. It should
take into account the unit (blocks, kB, MB) selected by the user.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Update manual page
Sebastien GODARD [Mon, 18 Nov 2019 16:30:37 +0000 (17:30 +0100)]
mpstat: Update manual page

Explain new option -T.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Add new switch to display system topology
Sebastien GODARD [Mon, 18 Nov 2019 15:30:38 +0000 (16:30 +0100)]
mpstat: Add new switch to display system topology

Add new switch "-T", which tells mpstat to display system topology
(core, socket and node for each cpu).
See #225.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosimtest: Add non regression tests for mpstat command
Sebastien GODARD [Sat, 16 Nov 2019 13:37:59 +0000 (14:37 +0100)]
simtest: Add non regression tests for mpstat command

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Update manual page
Sebastien GODARD [Sat, 16 Nov 2019 12:46:52 +0000 (13:46 +0100)]
mpstat: Update manual page

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agosa_common.c: Fix typo in comment
Sebastien GODARD [Fri, 15 Nov 2019 16:42:51 +0000 (17:42 +0100)]
sa_common.c: Fix typo in comment

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agompstat: Allow to select individual CPU/nodes with option -A
Sebastien GODARD [Fri, 15 Nov 2019 16:39:29 +0000 (17:39 +0100)]
mpstat: Allow to select individual CPU/nodes with option -A

Previously, using option -A with mpstat would display statistics for all
CPU and nodes (i.e. using -A would also imply -P ALL -N ALL).
Now this is true only if the user didn't specify explicitly a list of
CPU or nodes using options -P or -N.
Example: "mpstat -A -P1,4" will display all possible statistics but only
those concerning CPU 1 and 4 for CPU-related metrics.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
4 years agoMerge pull request #238 from albert-github/feature/bug_line_md
GODARD Sebastien [Fri, 15 Nov 2019 07:15:02 +0000 (08:15 +0100)]
Merge pull request #238 from albert-github/feature/bug_line_md

Missing empty line