]> granicus.if.org Git - python/log
python
15 years ago#6481: fix typo in os.system() replacement.
Georg Brandl [Thu, 16 Jul 2009 07:38:35 +0000 (07:38 +0000)]
#6481: fix typo in os.system() replacement.

15 years ago#6486: start with built in functions rather than "built in objects".
Georg Brandl [Thu, 16 Jul 2009 07:33:04 +0000 (07:33 +0000)]
#6486: start with built in functions rather than "built in objects".

15 years ago#5910: fix kqueue for calls with more than one event.
Georg Brandl [Thu, 16 Jul 2009 07:18:07 +0000 (07:18 +0000)]
#5910: fix kqueue for calls with more than one event.

15 years ago#6076 Add a title to the IDLE Preferences window.
Amaury Forgeot d'Arc [Wed, 15 Jul 2009 21:29:27 +0000 (21:29 +0000)]
#6076 Add a title to the IDLE Preferences window.

15 years agoIssue #2389: Pickle array objects using a list representation for portability
Alexandre Vassalotti [Wed, 15 Jul 2009 18:19:47 +0000 (18:19 +0000)]
Issue #2389: Pickle array objects using a list representation for portability
across different machine architectures and compatibility with Python 3.x.

15 years agomethods' names pep8ification
Ezio Melotti [Wed, 15 Jul 2009 17:07:04 +0000 (17:07 +0000)]
methods' names pep8ification

15 years agoupdate year
Benjamin Peterson [Wed, 15 Jul 2009 00:46:42 +0000 (00:46 +0000)]
update year

15 years agoMove TestRunner initialisation into unittest.TestProgram.runTests. Fixes issue 6418.
Michael Foord [Tue, 14 Jul 2009 17:58:12 +0000 (17:58 +0000)]
Move TestRunner initialisation into unittest.TestProgram.runTests. Fixes issue 6418.

15 years agoDocument the newly added codec
Amaury Forgeot d'Arc [Mon, 13 Jul 2009 23:11:54 +0000 (23:11 +0000)]
Document the newly added codec

15 years agoUse a different VER command output parser to address the localization
Marc-André Lemburg [Mon, 13 Jul 2009 21:28:33 +0000 (21:28 +0000)]
Use a different VER command output parser to address the localization
issues mentioned in #3410.

Prepare for Windows 7 (still commented out).

15 years agoUse a new global DEV_NULL instead of hard-coding /dev/null into the system
Marc-André Lemburg [Mon, 13 Jul 2009 20:23:49 +0000 (20:23 +0000)]
Use a new global DEV_NULL instead of hard-coding /dev/null into the system
command helper functions.

See #6479 for some motivation.

15 years agoNEWS entry for r74000.
Amaury Forgeot d'Arc [Mon, 13 Jul 2009 20:03:21 +0000 (20:03 +0000)]
NEWS entry for r74000.

15 years ago#1616979: Add the cp720 (Arabic DOS) encoding.
Amaury Forgeot d'Arc [Mon, 13 Jul 2009 20:01:11 +0000 (20:01 +0000)]
#1616979: Add the cp720 (Arabic DOS) encoding.
Since there is no official mapping file from unicode.org,
the codec file is generated on Windows with the new genwincodec.py script.

15 years agoSet svn:eol-style=CRLF on all Visual Studio solution files.
Amaury Forgeot d'Arc [Mon, 13 Jul 2009 19:14:17 +0000 (19:14 +0000)]
Set svn:eol-style=CRLF on all Visual Studio solution files.
This should allow direct compilation from a downloaded source tar ball.

15 years agoIssue #6314: logging: Extra checks on the "level" argument in more places.
Vinay Sajip [Mon, 13 Jul 2009 11:21:05 +0000 (11:21 +0000)]
Issue #6314: logging: Extra checks on the "level" argument in more places.

15 years agofix umlaut
Benjamin Peterson [Mon, 13 Jul 2009 00:03:20 +0000 (00:03 +0000)]
fix umlaut

15 years agochange encoding to utf-8
Benjamin Peterson [Sun, 12 Jul 2009 23:56:18 +0000 (23:56 +0000)]
change encoding to utf-8

15 years agofix another name
Benjamin Peterson [Sun, 12 Jul 2009 23:49:23 +0000 (23:49 +0000)]
fix another name

15 years agochange encoding to utf-8
Benjamin Peterson [Sun, 12 Jul 2009 23:44:43 +0000 (23:44 +0000)]
change encoding to utf-8

15 years agofix Tarek's name
Benjamin Peterson [Sun, 12 Jul 2009 23:40:33 +0000 (23:40 +0000)]
fix Tarek's name

15 years agohttp://bugs.python.org/issue6267
Kristján Valur Jónsson [Sun, 12 Jul 2009 22:42:08 +0000 (22:42 +0000)]
http://bugs.python.org/issue6267
Add more tests for the xlmrpc.ServerProxy

15 years agoadd Joe
Benjamin Peterson [Sun, 12 Jul 2009 21:18:55 +0000 (21:18 +0000)]
add Joe

15 years agoadd versionadded
Benjamin Peterson [Sun, 12 Jul 2009 16:56:54 +0000 (16:56 +0000)]
add versionadded

15 years agoFixed distutils test.
Hirokazu Yamamoto [Sun, 12 Jul 2009 02:04:47 +0000 (02:04 +0000)]
Fixed distutils test.

15 years agoignore things in Lib/test/data/
Benjamin Peterson [Sat, 11 Jul 2009 22:25:24 +0000 (22:25 +0000)]
ignore things in Lib/test/data/

15 years agoput downloaded test support files in Lib/test/data instead of the cwd
Benjamin Peterson [Sat, 11 Jul 2009 22:15:13 +0000 (22:15 +0000)]
put downloaded test support files in Lib/test/data instead of the cwd

15 years agoreverted changes for #6459 (doesn't apply on 2.x)
Tarek Ziadé [Sat, 11 Jul 2009 17:21:00 +0000 (17:21 +0000)]
reverted changes for #6459 (doesn't apply on 2.x)

15 years ago#2622 Import errors in email.message, from a py2app standalone application.
Amaury Forgeot d'Arc [Sat, 11 Jul 2009 14:33:51 +0000 (14:33 +0000)]
#2622 Import errors in email.message, from a py2app standalone application.

Patch by Mads Kiilerich, Reviewed by Barry Warsaw.

15 years agoarray.array is actually a class.
Georg Brandl [Sat, 11 Jul 2009 14:23:38 +0000 (14:23 +0000)]
array.array is actually a class.

15 years agofixed #6459: distutils.command.build_ext.get_export_symbols now uses 'PyInit'
Tarek Ziadé [Sat, 11 Jul 2009 10:55:27 +0000 (10:55 +0000)]
fixed #6459: distutils.command.build_ext.get_export_symbols now uses 'PyInit'

15 years ago#6456: clarify the meaning of constants used as arguments to nl_langinfo().
Georg Brandl [Sat, 11 Jul 2009 10:51:31 +0000 (10:51 +0000)]
#6456: clarify the meaning of constants used as arguments to nl_langinfo().

15 years agocleaned up distutils.build_ext module
Tarek Ziadé [Sat, 11 Jul 2009 10:48:31 +0000 (10:48 +0000)]
cleaned up distutils.build_ext module

15 years ago#6430: add note about size of "u" type.
Georg Brandl [Sat, 11 Jul 2009 10:37:38 +0000 (10:37 +0000)]
#6430: add note about size of "u" type.

15 years ago#6448: clarify docs for find_module().
Georg Brandl [Sat, 11 Jul 2009 10:18:10 +0000 (10:18 +0000)]
#6448: clarify docs for find_module().

15 years ago#6446: fix import_spam() function to use correct error and reference handling.
Georg Brandl [Sat, 11 Jul 2009 10:14:54 +0000 (10:14 +0000)]
#6446: fix import_spam() function to use correct error and reference handling.

15 years agoFix style.
Georg Brandl [Sat, 11 Jul 2009 10:12:36 +0000 (10:12 +0000)]
Fix style.

15 years agoAdd basic tests for the return value of os.popen().close().
Amaury Forgeot d'Arc [Sat, 11 Jul 2009 09:09:59 +0000 (09:09 +0000)]
Add basic tests for the return value of os.popen().close().
According to #6358, python 3.0 has a different implementation that behaves differently.

15 years agohttp://bugs.python.org/issue6460
Kristján Valur Jónsson [Sat, 11 Jul 2009 08:44:43 +0000 (08:44 +0000)]
http://bugs.python.org/issue6460
Need to be careful with thread switching when testing the xmlrpc server.  The server thread may not have updated stats when the client thread tests them.

15 years agomore cleanups and if zlib -> skipUnless(zlib)
Ezio Melotti [Fri, 10 Jul 2009 20:25:56 +0000 (20:25 +0000)]
more cleanups and if zlib -> skipUnless(zlib)

15 years ago#6447: typo in subprocess docstring
Amaury Forgeot d'Arc [Fri, 10 Jul 2009 16:47:42 +0000 (16:47 +0000)]
#6447: typo in subprocess docstring

15 years agocleaned up distutils.command.build
Tarek Ziadé [Fri, 10 Jul 2009 10:00:21 +0000 (10:00 +0000)]
cleaned up distutils.command.build

15 years agoAdded test coverage for distutils.command.build
Tarek Ziadé [Fri, 10 Jul 2009 09:57:15 +0000 (09:57 +0000)]
Added test coverage for distutils.command.build

15 years agoFixed #6455 (the test shall use pyd files under win32, rather than so files)
Tarek Ziadé [Fri, 10 Jul 2009 09:10:33 +0000 (09:10 +0000)]
Fixed #6455 (the test shall use pyd files under win32, rather than so files)

15 years ago#6416: Fix compilation of the select module on Windows, as well as test_subprocess:
Amaury Forgeot d'Arc [Thu, 9 Jul 2009 22:37:22 +0000 (22:37 +0000)]
#6416: Fix compilation of the select module on Windows, as well as test_subprocess:
PIPE_BUF is not defined on Windows, and probably has no meaning there.

Anyway the subprocess module uses another way to perform non-blocking reads (with a thread)

15 years agoTry to fix Solaris buildbot rmtree failure in test_getcwd_long_pathnames
R. David Murray [Thu, 9 Jul 2009 18:41:03 +0000 (18:41 +0000)]
Try to fix Solaris buildbot rmtree failure in test_getcwd_long_pathnames
cleanup.  If this fix works, it means that Solaris is unique among
our platforms in what happens when shutil.rmtree is called on the
current working directory (ie: it doesn't work on Solaris, but
it does everywhere else).

15 years agoTemporarily ignore rmtree errors in test_getcwd_long_pathnames to see
R. David Murray [Thu, 9 Jul 2009 16:17:30 +0000 (16:17 +0000)]
Temporarily ignore rmtree errors in test_getcwd_long_pathnames to see
if the test gives useful failure info on Solaris buildbot.

15 years agoCurdir needs to be in the path for the test to work on all buildbots.
R. David Murray [Thu, 9 Jul 2009 15:35:33 +0000 (15:35 +0000)]
Curdir needs to be in the path for the test to work on all buildbots.
(I copied this from another import test, but currently this will fail if
TESTFN ends up in /tmp...see issue 2609).

15 years agoSpecify umask in execute bit test to get consistent results
R. David Murray [Thu, 9 Jul 2009 13:55:44 +0000 (13:55 +0000)]
Specify umask in execute bit test to get consistent results
and make sure we test resetting all three execute bits.

15 years agoPendingDeprecationWarning -> DeprecationWarning in build_ext
Tarek Ziadé [Thu, 9 Jul 2009 07:42:42 +0000 (07:42 +0000)]
PendingDeprecationWarning -> DeprecationWarning in build_ext

15 years agoMake test work with -O.
R. David Murray [Thu, 9 Jul 2009 02:06:17 +0000 (02:06 +0000)]
Make test work with -O.

15 years agoConditionalize test cleanup code to eliminate traceback, which will
R. David Murray [Thu, 9 Jul 2009 01:43:41 +0000 (01:43 +0000)]
Conditionalize test cleanup code to eliminate traceback, which will
hopefully reveal the real problem.

15 years agoSets the compiler attribute to keep the old behavior for third-party packages.
Tarek Ziadé [Wed, 8 Jul 2009 22:40:51 +0000 (22:40 +0000)]
Sets the compiler attribute to keep the old behavior for third-party packages.

15 years agoIssue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson [Tue, 7 Jul 2009 15:08:28 +0000 (15:08 +0000)]
Issue #1523: Remove deprecated overflow masking in struct module, and
make sure that out-of-range values consistently raise struct.error.

15 years agoExpand test coverage for struct.pack with native integer packing;
Mark Dickinson [Tue, 7 Jul 2009 14:15:45 +0000 (14:15 +0000)]
Expand test coverage for struct.pack with native integer packing;
reorganize the test_struct module to remove duplicated code and tests.

15 years agoAdd skipping to struct test that only applies when overflow masking is in effect
Mark Dickinson [Tue, 7 Jul 2009 11:08:23 +0000 (11:08 +0000)]
Add skipping to struct test that only applies when overflow masking is in effect

15 years agoTypo in error message
Mark Dickinson [Tue, 7 Jul 2009 10:18:22 +0000 (10:18 +0000)]
Typo in error message

15 years agoUpdate issue 6070 patch to match the patch that was actually tested
R. David Murray [Tue, 7 Jul 2009 09:54:16 +0000 (09:54 +0000)]
Update issue 6070 patch to match the patch that was actually tested
on Windows.

15 years agohttp://bugs.python.org/issue6382
Kristján Valur Jónsson [Tue, 7 Jul 2009 09:01:34 +0000 (09:01 +0000)]
http://bugs.python.org/issue6382
added the shutdown_request() which can perform shutdown before calling close.  This is needed for the ForkingMixIn because different close semantics are required for child and parent process.  shutdown_request(), for TCP servers, calls socket.shutdown() and then calls close_request().  Therefore, this is not an backwards incompatible change, since subclasses that continue to override close_request() continue to work.

16 years ago#6420: Fix a compilation warning in the nis module, for OpenBSD and FreeBSD.
Amaury Forgeot d'Arc [Tue, 7 Jul 2009 06:49:41 +0000 (06:49 +0000)]
#6420: Fix a compilation warning in the nis module, for OpenBSD and FreeBSD.

16 years agoGrow the allocated buffer in PyUnicode_EncodeUTF7 to avoid buffer overrun.
Alexandre Vassalotti [Tue, 7 Jul 2009 02:17:30 +0000 (02:17 +0000)]
Grow the allocated buffer in PyUnicode_EncodeUTF7 to avoid buffer overrun.

Without this change, test_unicode.UnicodeTest.test_codecs_utf7 crashes in
debug mode. What happens is the unicode string u'\U000abcde' with a length
of 1 encodes to the string '+2m/c3g-' of length 8. Since only 5 bytes is
reserved in the buffer, a buffer overrun occurs.

16 years agoIssue 6070: when creating a compiled file, after copying the mode bits, on
R. David Murray [Tue, 7 Jul 2009 01:06:13 +0000 (01:06 +0000)]
Issue 6070: when creating a compiled file, after copying the mode bits, on
posix zap the execute bit in case it was set on the .py file, since the
compiled files are not directly executable on posix.  Patch by Marco N.

16 years agoFixed #6377: distutils compiler switch ignored (and added a deprecation warning if...
Tarek Ziadé [Mon, 6 Jul 2009 12:50:46 +0000 (12:50 +0000)]
Fixed #6377: distutils compiler switch ignored (and added a deprecation warning if compiler is not used as supposed = a string option)

16 years agohttp://bugs.python.org/issue6382
Kristján Valur Jónsson [Sun, 5 Jul 2009 20:56:57 +0000 (20:56 +0000)]
http://bugs.python.org/issue6382
close_request() (which can send a socket.shutdown()) must be called by the child process in a forking server.  The parent must merely close the socket handle.

16 years agoIssues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson [Sun, 5 Jul 2009 10:01:24 +0000 (10:01 +0000)]
Issues #1530559, #1741130:  Fix various inconsistencies in struct.pack
integer packing, and reenable some previously broken tests.

16 years agoBackport test cases added in r73852.
Alexandre Vassalotti [Sun, 5 Jul 2009 06:33:41 +0000 (06:33 +0000)]
Backport test cases added in r73852.

16 years agoFix bad variable name in r73846.
Alexandre Vassalotti [Sun, 5 Jul 2009 04:25:46 +0000 (04:25 +0000)]
Fix bad variable name in r73846.

16 years agoIssue 2370: Add Python 3 warnings for the removal of operator.isCallable and
Alexandre Vassalotti [Sun, 5 Jul 2009 04:22:40 +0000 (04:22 +0000)]
Issue 2370: Add Python 3 warnings for the removal of operator.isCallable and
operator.sequenceIncludes.

Patch contributed by Jeff Balogh (and updated slightly by me).

16 years agoif zlib -> skipUnless(zlib) and minor cleanups
Ezio Melotti [Sat, 4 Jul 2009 14:58:27 +0000 (14:58 +0000)]
if zlib -> skipUnless(zlib) and minor cleanups

16 years agoMerge r73838 from py3k branch. Use the nondeprecated unittest method
Gregory P. Smith [Sat, 4 Jul 2009 08:42:10 +0000 (08:42 +0000)]
Merge r73838 from py3k branch.  Use the nondeprecated unittest method
names.

16 years agousing print statements when used for user interaction
Tarek Ziadé [Sat, 4 Jul 2009 02:59:19 +0000 (02:59 +0000)]
using print statements when used for user interaction

16 years agoFixed #6413: fixed log level in distutils.dist.announce
Tarek Ziadé [Sat, 4 Jul 2009 02:02:41 +0000 (02:02 +0000)]
Fixed #6413: fixed log level in distutils.dist.announce

16 years agonews entry for r73825
Gregory P. Smith [Sat, 4 Jul 2009 01:55:11 +0000 (01:55 +0000)]
news entry for r73825

16 years agoUse select.poll() in subprocess, when available, rather than select() so that
Gregory P. Smith [Sat, 4 Jul 2009 01:49:29 +0000 (01:49 +0000)]
Use select.poll() in subprocess, when available, rather than select() so that
it does not fail when file descriptors are large.  Fixes issue3392.

Patch largely contributed by Frank Chu (fpmc) with some improvements by me.
See http://bugs.python.org/issue3392.

Candidate for backporting to release26-maint as it is a bug fix and changes no
public API.

16 years ago#6398 typo: versio. -> version.
Ezio Melotti [Sat, 4 Jul 2009 01:18:08 +0000 (01:18 +0000)]
#6398 typo: versio. -> version.

16 years agohttp://bugs.python.org/issue6267
Kristján Valur Jónsson [Fri, 3 Jul 2009 23:29:50 +0000 (23:29 +0000)]
http://bugs.python.org/issue6267
Incorrect exception handling for xmlrpc client retry

16 years agohttp://bugs.python.org/issue6267
Kristján Valur Jónsson [Fri, 3 Jul 2009 23:26:02 +0000 (23:26 +0000)]
http://bugs.python.org/issue6267
Incorrect exception handling for xmlrp client retry

16 years agohttp://bugs.python.org/issue6381
Kristján Valur Jónsson [Fri, 3 Jul 2009 23:07:07 +0000 (23:07 +0000)]
http://bugs.python.org/issue6381
some platforms may raise ENOTCONN if the stack has disconnected the socket on behalf of the peer.

16 years agoAdds the select.PIPE_BUF attribute to expose the system constant.
Gregory P. Smith [Fri, 3 Jul 2009 20:48:31 +0000 (20:48 +0000)]
Adds the select.PIPE_BUF attribute to expose the system constant.

16 years agocleaned distutils.file_util
Tarek Ziadé [Fri, 3 Jul 2009 19:14:49 +0000 (19:14 +0000)]
cleaned distutils.file_util

16 years agobasic tests to raise distutils.file_util coverage
Tarek Ziadé [Fri, 3 Jul 2009 19:01:12 +0000 (19:01 +0000)]
basic tests to raise distutils.file_util coverage

16 years agoanother cStringIO restriction
Benjamin Peterson [Fri, 3 Jul 2009 14:08:20 +0000 (14:08 +0000)]
another cStringIO restriction

16 years agocleaned up distutils.command.build_py
Tarek Ziadé [Fri, 3 Jul 2009 09:01:07 +0000 (09:01 +0000)]
cleaned up distutils.command.build_py

16 years agoFixed #6403 : package path usage for build_ext
Tarek Ziadé [Fri, 3 Jul 2009 08:22:56 +0000 (08:22 +0000)]
Fixed #6403 : package path usage for build_ext

16 years agocondense with assertRaises
Benjamin Peterson [Thu, 2 Jul 2009 22:56:16 +0000 (22:56 +0000)]
condense with assertRaises

16 years agotest that compile() accepts the future flag
Benjamin Peterson [Thu, 2 Jul 2009 21:38:36 +0000 (21:38 +0000)]
test that compile() accepts the future flag

16 years agoIssue 6389: add documentation for the 'mode' flags defined in the
R. David Murray [Thu, 2 Jul 2009 18:19:20 +0000 (18:19 +0000)]
Issue 6389: add documentation for the 'mode' flags defined in the
stat module.

16 years agowhen print() gets unicode arguments, sep and end should be unicode by default #4618
Benjamin Peterson [Thu, 2 Jul 2009 18:16:45 +0000 (18:16 +0000)]
when print() gets unicode arguments, sep and end should be unicode by default #4618

16 years agoonly order comparisons are removed in py3k #6119
Benjamin Peterson [Thu, 2 Jul 2009 17:06:17 +0000 (17:06 +0000)]
only order comparisons are removed in py3k #6119

16 years agoremove this test; a module level warning is enough
Benjamin Peterson [Thu, 2 Jul 2009 16:51:56 +0000 (16:51 +0000)]
remove this test; a module level warning is enough

16 years agomultiprocessing doesn't compile in Solaris because a typo
Jesus Cea [Thu, 2 Jul 2009 14:30:18 +0000 (14:30 +0000)]
multiprocessing doesn't compile in Solaris because a typo

16 years agopep8-fied and cleaned up distutils.util
Tarek Ziadé [Thu, 2 Jul 2009 14:20:47 +0000 (14:20 +0000)]
pep8-fied and cleaned up distutils.util

16 years agocleaned up the bdist_dumb module
Tarek Ziadé [Thu, 2 Jul 2009 12:51:56 +0000 (12:51 +0000)]
cleaned up the bdist_dumb module

16 years agoraising bdist_dumb test coverage
Tarek Ziadé [Thu, 2 Jul 2009 12:47:54 +0000 (12:47 +0000)]
raising bdist_dumb test coverage

16 years agosmall optimization: avoid popping the current block until we have to
Benjamin Peterson [Wed, 1 Jul 2009 23:45:19 +0000 (23:45 +0000)]
small optimization: avoid popping the current block until we have to

16 years agoproxy the __exit__ call
Benjamin Peterson [Wed, 1 Jul 2009 13:34:35 +0000 (13:34 +0000)]
proxy the __exit__ call

16 years agoMake punctuation prettier and break up run-on sentence.
R. David Murray [Wed, 1 Jul 2009 02:49:10 +0000 (02:49 +0000)]
Make punctuation prettier and break up run-on sentence.

16 years agoMerged revisions 73379,73388,73507,73722 via svnmerge from
Benjamin Peterson [Wed, 1 Jul 2009 00:49:09 +0000 (00:49 +0000)]
Merged revisions 73379,73388,73507,73722 via svnmerge from
svn+ssh://pythondev@svn.python.org/sandbox/trunk/2to3/lib2to3

........
  r73379 | benjamin.peterson | 2009-06-11 18:06:21 -0500 (Thu, 11 Jun 2009) | 1 line

  use a real conditional expresion
........
  r73388 | benjamin.peterson | 2009-06-12 09:44:29 -0500 (Fri, 12 Jun 2009) | 1 line

  fix typo in last fix
........
  r73507 | benjamin.peterson | 2009-06-22 13:32:04 -0500 (Mon, 22 Jun 2009) | 1 line

  remove svn:executable property
........
  r73722 | benjamin.peterson | 2009-06-30 19:44:30 -0500 (Tue, 30 Jun 2009) | 1 line

  replace fail* with assert*
........

16 years agofix a few cases where automated fail -> assert translation messed up
Benjamin Peterson [Wed, 1 Jul 2009 00:36:41 +0000 (00:36 +0000)]
fix a few cases where automated fail -> assert translation messed up

Thanks Joe Amenta

16 years agouse assert* methods in test_unittest
Benjamin Peterson [Tue, 30 Jun 2009 23:30:12 +0000 (23:30 +0000)]
use assert* methods in test_unittest

16 years agoconvert usage of fail* to assert*
Benjamin Peterson [Tue, 30 Jun 2009 22:57:08 +0000 (22:57 +0000)]
convert usage of fail* to assert*