]> granicus.if.org Git - neomutt/log
neomutt
6 years agoUpdate zh_CN translation
Zero King [Tue, 5 Jun 2018 03:23:24 +0000 (03:23 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Mon, 4 Jun 2018 13:27:20 +0000 (13:27 +0000)]
Update zh_CN translation

6 years agoUpdate ja translation
Zero King [Sun, 3 Jun 2018 12:16:32 +0000 (12:16 +0000)]
Update ja translation

6 years agoUpdate ja translation
Zero King [Sat, 2 Jun 2018 03:36:44 +0000 (03:36 +0000)]
Update ja translation

6 years agotrans: de-dupe an ssl string
Richard Russon [Fri, 1 Jun 2018 21:55:24 +0000 (22:55 +0100)]
trans: de-dupe an ssl string

6 years agoUpdate Slovak translation
David Sterba [Fri, 1 Jun 2018 10:37:25 +0000 (12:37 +0200)]
Update Slovak translation

6 years agoadd missing 'Plural-Forms' statement
Richard Russon [Thu, 31 May 2018 14:22:48 +0000 (15:22 +0100)]
add missing 'Plural-Forms' statement

6 years agoUpdate ja translation
Zero King [Thu, 31 May 2018 13:52:18 +0000 (13:52 +0000)]
Update ja translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:50:30 +0000 (12:50 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:33:32 +0000 (12:33 +0000)]
Update zh_CN translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 12:07:56 +0000 (12:07 +0000)]
Update zh_CN translation

6 years agoUpdate Czech translation
David Sterba [Tue, 29 May 2018 11:31:48 +0000 (13:31 +0200)]
Update Czech translation

6 years agoUpdate zh_CN translation
Zero King [Tue, 29 May 2018 05:21:13 +0000 (05:21 +0000)]
Update zh_CN translation

6 years agomerge: increase and unify buffer sizes
Richard Russon [Wed, 6 Jun 2018 14:58:24 +0000 (15:58 +0100)]
merge: increase and unify buffer sizes

 * adjust the size of some general buffers
 * Use sizeof() rather than constants
 * Create a large buffer for command strings
 * Enlarge buffers from _POSIX_PATH_MAX to PATH_MAX
 * Enlarge buffers from LONG_STRING to PATH_MAX

6 years agoEnlarge buffers from LONG_STRING to PATH_MAX 1229/head
Richard Russon [Tue, 29 May 2018 15:52:55 +0000 (16:52 +0100)]
Enlarge buffers from LONG_STRING to PATH_MAX

Every buffer that has a filesystem path copied into it

6 years agoEnlarge buffers from _POSIX_PATH_MAX to PATH_MAX
Richard Russon [Tue, 29 May 2018 14:55:51 +0000 (15:55 +0100)]
Enlarge buffers from _POSIX_PATH_MAX to PATH_MAX

Every buffer that has a filesystem path copied into it

6 years agoCreate a large buffer for command strings
Richard Russon [Tue, 29 May 2018 14:38:06 +0000 (15:38 +0100)]
Create a large buffer for command strings

6 years agoUse sizeof() rather than constants
Richard Russon [Tue, 29 May 2018 14:32:05 +0000 (15:32 +0100)]
Use sizeof() rather than constants

6 years agomerge: small improvements
Richard Russon [Wed, 6 Jun 2018 14:43:55 +0000 (15:43 +0100)]
merge: small improvements

 * tidy handler.c
 * tidy for loops
 * insert {}s
 * doxy: document buffy.c
 * tidy return statements
 * move new functions to reduce header deps
 * add enum for 'set' commands
 * tidy the regex types
 * minor tidying

6 years agominor tidying
Richard Russon [Sat, 2 Jun 2018 17:12:56 +0000 (18:12 +0100)]
minor tidying

- rename parameters
- change member types
- fix doxygen typo
- make variable const

6 years agotidy the regex types
Richard Russon [Thu, 31 May 2018 00:36:06 +0000 (01:36 +0100)]
tidy the regex types

- remove unnecessary casts
- fix variable types
- remove once-used macro (REGEXEC)

6 years agoadd enum for 'set' commands
Richard Russon [Sat, 2 Jun 2018 11:42:55 +0000 (12:42 +0100)]
add enum for 'set' commands

The 'set' family of commands are mutually exclusive, so change the
defines to an enumeration.

6 years agomove new functions to reduce header deps
Richard Russon [Sat, 2 Jun 2018 22:37:17 +0000 (23:37 +0100)]
move new functions to reduce header deps

Having the `new` functions in the header creates a requirement on the
mutt library.

6 years agotidy return statements
Richard Russon [Tue, 5 Jun 2018 11:00:45 +0000 (12:00 +0100)]
tidy return statements

Add ()s to return statements where the logic is non-trivial.

6 years agodoxy: document buffy.c
Richard Russon [Mon, 4 Jun 2018 23:24:38 +0000 (00:24 +0100)]
doxy: document buffy.c

6 years agoinsert {}s
Richard Russon [Sun, 3 Jun 2018 16:53:10 +0000 (17:53 +0100)]
insert {}s

Insert {}s where the conditional or body take up more than one line.

6 years agotidy for loops
Richard Russon [Sat, 2 Jun 2018 23:40:53 +0000 (00:40 +0100)]
tidy for loops

- Add {}s where the body of a `for` loop isn't obvious.
- Add ()s where the logic isn't clear

6 years agotidy handler.c
Richard Russon [Sat, 2 Jun 2018 21:33:17 +0000 (22:33 +0100)]
tidy handler.c

- Move the function prototypes to a new file `handler.h`
- Rearrange the functions

There are no changes to the code.

6 years agotidy hcache
Richard Russon [Wed, 6 Jun 2018 12:18:46 +0000 (13:18 +0100)]
tidy hcache

- Drop the typedefs -- they were only used once
- Move the backend list `HCACHE_BACKEND_LIST` into hcache.c
- Update all the source docs

6 years agomerge: tidy the mailbox API
Richard Russon [Wed, 6 Jun 2018 12:46:58 +0000 (13:46 +0100)]
merge: tidy the mailbox API

 * unify parameter naming
 * reorder functions
 * rename functions
 * rename implementation functions
 * document all implementation functions
 * swap mx_commit_message() params
 * rename mx functions to match api

6 years agomx api: rename mx functions to match api
Richard Russon [Wed, 6 Jun 2018 01:27:15 +0000 (02:27 +0100)]
mx api: rename mx functions to match api

6 years agomx api: swap mx_commit_message() params
Richard Russon [Wed, 6 Jun 2018 01:16:05 +0000 (02:16 +0100)]
mx api: swap mx_commit_message() params

for consistency with the other api functions

6 years agomx api: document all implementation functions
Richard Russon [Wed, 6 Jun 2018 01:05:11 +0000 (02:05 +0100)]
mx api: document all implementation functions

6 years agomx api: rename implementation functions
Richard Russon [Tue, 5 Jun 2018 19:55:34 +0000 (20:55 +0100)]
mx api: rename implementation functions

6 years agomx api: rename functions
Richard Russon [Tue, 5 Jun 2018 19:42:03 +0000 (20:42 +0100)]
mx api: rename functions

6 years agomx api: reorder functions
Richard Russon [Tue, 5 Jun 2018 19:22:55 +0000 (20:22 +0100)]
mx api: reorder functions

6 years agomx api: unify parameter naming
Richard Russon [Tue, 5 Jun 2018 19:10:34 +0000 (20:10 +0100)]
mx api: unify parameter naming

6 years agoDo not (try to) install / uninstall nonexistent man pages
Pietro Cerutti [Mon, 4 Jun 2018 07:37:45 +0000 (07:37 +0000)]
Do not (try to) install / uninstall nonexistent man pages

See #1247

6 years agomerge: drop pgpring references
Richard Russon [Fri, 1 Jun 2018 10:01:51 +0000 (11:01 +0100)]
merge: drop pgpring references

 * remove pgpring from docs
 * remove last references to pgpring
 * drop obsolete pgp notes

6 years agodrop obsolete pgp notes 1242/head
Richard Russon [Fri, 1 Jun 2018 09:47:58 +0000 (10:47 +0100)]
drop obsolete pgp notes

6 years agoremove last references to pgpring
Richard Russon [Fri, 1 Jun 2018 09:47:04 +0000 (10:47 +0100)]
remove last references to pgpring

6 years agoremove pgpring from docs
Bo YU [Fri, 1 Jun 2018 08:48:30 +0000 (16:48 +0800)]
remove pgpring from docs

6 years agoRemove PgpSignature
Bo YU [Thu, 31 May 2018 08:44:55 +0000 (16:44 +0800)]
Remove PgpSignature

The PgpSignature is only used by the pgpring tool.
The pgpring tool is only needed by users of PGP2 and PGP5.
PGP5 is over twenty years old.

- remove PgpSignature from ncrypt/pgplib.[ch]
- remove pgppubring.c
- update Makefile.autosetup
- remove contrib/pgp2.rc
- remove contrib/pgp5.rc
- remove contrib/pgp6.rc
- update contrib/Makefile.autosetup

6 years agopager: index must be rebuilt on MUTT_REOPENED
Mehdi ABAAKOUK [Wed, 30 May 2018 14:27:38 +0000 (16:27 +0200)]
pager: index must be rebuilt on MUTT_REOPENED

When we call mx_check_mailbox() and something change
header in Context->hdrs may have been updated.

In case of MUTT_NEW_MAIL, the page rebuild the index, and fixup
rd.index->current/max and extra->hdr. If the extra->hdr change
like when an above the opened one, or the selected one, is deleted, the
pager is closed.

In case of MUTT_REOPENED we do nothing. Making rd.index->current/max
wrong and extra->hdr perhaps pointing to something that doesn't exist
anymore.

This change makes the MUTT_REOPENED behavior similar to MUTT_NEW_MAIL.

Note that we this the pager have good change to be closed with the
mailbox is modified externally, just like the current MUTT_NEW_MAIL
behavior.

Closes #796

6 years agoHandle a BAD response in AUTH PLAIN w/o initial response (#1237)
Pietro Cerutti [Wed, 30 May 2018 12:44:14 +0000 (13:44 +0100)]
Handle a BAD response in AUTH PLAIN w/o initial response (#1237)

The incorrect assumption was that the first line of an AUTH PLAIN w/o
I-R was always successful, so the client could write the second line and
end up with a readable socket that would be activated by the server
sending the final OK or BAD response.
If however the first line results in a BAD response already, the server
wouldn't write anything else and the client would be left polling for an
additional response that never arrives, effectively hanging the process.

Issue #1236

6 years agoAvoid regenerating hcache/hcversion.h after building objects in hcache
Pietro Cerutti [Tue, 29 May 2018 15:39:23 +0000 (15:39 +0000)]
Avoid regenerating hcache/hcversion.h after building objects in hcache

Specifying the hcache directory asqa dependency for hcache/hcversion.h
means that the latter will be regenerated whenever the hcache directory
is changed, such as when object files are written into it. The net
effect is that "make; make" regenerates hcache/hcversion.h twice.

This commit fixes this problem by explicitely creating the hcache
directory as part of the hcache/hcversion.h target.

6 years agoadjust the size of some general buffers
Richard Russon [Tue, 29 May 2018 15:12:50 +0000 (16:12 +0100)]
adjust the size of some general buffers

Also, reduce the scope of the variables.

6 years agoAdd the mutt_ch_check API (#1139)
Pietro Cerutti [Tue, 29 May 2018 13:29:02 +0000 (14:29 +0100)]
Add the mutt_ch_check API (#1139)

* Add the mutt_ch_check API

This adds the mutt_ch_check API that can be used to check whether a
string can be converted between character sets. It is stricter than
mutt_ch_convert_string in that it doesn't apply any replacement chars to
unconvertible characters and doesn't return the converted string.

* Fix ICONV_CONST

* Fix arguments to iconv()

* Free the correct pointer

6 years agoDon't let info messages reset error messages' timeouts (#1234)
Pietro Cerutti [Tue, 29 May 2018 12:05:10 +0000 (13:05 +0100)]
Don't let info messages reset error messages' timeouts (#1234)

Issue #1100

6 years agoFix typo in comment
Pietro Cerutti [Tue, 29 May 2018 08:13:11 +0000 (08:13 +0000)]
Fix typo in comment

6 years agomerge: update translations
Richard Russon [Tue, 29 May 2018 03:03:52 +0000 (04:03 +0100)]
merge: update translations

 * add missing format specifier
 * curs_main.c: Fix plural messages with "messages"
 * drop dupe bad IDN messages
 * handler.c: Partly fix plural message about attachment size
 * make room for translation
 * mx.c: Fix plural message "messages(s) not deleted"
 * mx.c: Fix plural message "Move %d read messages to %s?"
 * ncrypt/crypt_gpgme.c: Fix plural message "%s, %lu bit %s\n"
 * ncrypt/ncrypt.c: Fix plural message "Passphrases forgotten."
 * opcodes.h: Fix plural messages with "<word>(s)"
 * pager.c: Fix plural messages with "messages"
 * pager.c: Mark two strings for translation
 * pop.c: Fix plural message "Reading new messages (%d bytes)..."
 * recvattach.c: Fix plural message "Print tagged attachments?"
 * sync translations
 * translate status 'all' and 'end'
 * Update Czech translation
 * Update lt_LT translation
 * Update po files
 * Update pt_BR translation
 * Update zh_CN translation
 * Updated Catalan translation.
 * Updated Japanese translation.
 * Updated Russian translation.
 * Updated Slovak translation
 * Updated Ukrainian translation.

6 years agosync translations
Richard Russon [Tue, 29 May 2018 02:54:50 +0000 (03:54 +0100)]
sync translations

6 years agoUpdated Catalan translation.
Ivan Vilata i Balaguer [Thu, 17 May 2018 19:24:31 +0000 (12:24 -0700)]
Updated Catalan translation.

6 years agoUpdated Japanese translation.
TAKAHASHI Tamotsu [Thu, 17 May 2018 17:10:52 +0000 (10:10 -0700)]
Updated Japanese translation.

6 years agoUpdated Russian translation.
Vsevolod Volkov [Wed, 9 May 2018 16:32:48 +0000 (09:32 -0700)]
Updated Russian translation.

6 years agoUpdated Ukrainian translation.
Vsevolod Volkov [Wed, 9 May 2018 16:30:55 +0000 (09:30 -0700)]
Updated Ukrainian translation.

6 years agoUpdate zh_CN translation
Zero King [Sun, 27 May 2018 13:09:32 +0000 (13:09 +0000)]
Update zh_CN translation

6 years agodrop dupe bad IDN messages
Richard Russon [Sun, 27 May 2018 23:20:03 +0000 (00:20 +0100)]
drop dupe bad IDN messages

6 years agoUpdate zh_CN translation
Zero King [Sat, 26 May 2018 10:13:16 +0000 (10:13 +0000)]
Update zh_CN translation

6 years agoTranslate: update zh_cn
Bo YU [Thu, 24 May 2018 12:11:31 +0000 (08:11 -0400)]
Translate: update zh_cn

The translate would be better

Signed-off-by: Bo YU <yuzibode@126.com>
6 years agoTranslate zh_cn update
Bo YU [Thu, 24 May 2018 11:42:00 +0000 (07:42 -0400)]
Translate zh_cn update

msgid "Print tagged attachment?"
msgid_plural "Print %d tagged attachments?"
msgstr[0] "打印 %d 件已标记的附件?"

And i want to make clear for that:if i place %d into msgstr[0],then
msgid "Print tagged attachment" how to translate?Under my understand,if
program invokes msgid, it will display "打印 件已标记的附件",just left a
space.

Signed-off-by: Bo YU <yuzibode@126.com>
6 years agoTranslate: update zh_CN translate
Bo YU [Thu, 24 May 2018 10:56:21 +0000 (06:56 -0400)]
Translate: update zh_CN translate

add missing format specifier: %d

Signed-off-by: Bo YU <yuzibode@126.com>
6 years agoadd missing format specifier
Richard Russon [Wed, 23 May 2018 16:53:04 +0000 (17:53 +0100)]
add missing format specifier

6 years agoTranslate: Update zh_CN translates
Bo Yu [Thu, 24 May 2018 01:45:28 +0000 (21:45 -0400)]
Translate: Update zh_CN translates

Zh_CN translate update.Now, i removed about 15 string "fuzzy" tagged.

Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
6 years agotranslate status 'all' and 'end'
Richard Russon [Wed, 23 May 2018 16:34:48 +0000 (17:34 +0100)]
translate status 'all' and 'end'

6 years agoUpdate Czech translation
David Sterba [Wed, 23 May 2018 14:18:10 +0000 (16:18 +0200)]
Update Czech translation

6 years agomake room for translation
Richard Russon [Wed, 23 May 2018 14:01:36 +0000 (15:01 +0100)]
make room for translation

6 years agoUpdate lt_LT translation
Marius Gedminas [Wed, 23 May 2018 13:07:03 +0000 (16:07 +0300)]
Update lt_LT translation

Two new strings, a bunch of fuzzy strings.  Back to 100%.

6 years agoUpdate pt_BR translation
Thiago Costa de Paiva [Wed, 23 May 2018 13:08:55 +0000 (09:08 -0400)]
Update pt_BR translation

6 years agoUpdate pt_BR translation
Thiago Costa de Paiva [Wed, 23 May 2018 13:00:59 +0000 (09:00 -0400)]
Update pt_BR translation

6 years agoUpdate pt_BR translation
Thiago Costa de Paiva [Wed, 9 May 2018 10:40:17 +0000 (06:40 -0400)]
Update pt_BR translation

6 years agoUpdate po files to match new code base
Reis Radomil [Tue, 22 May 2018 14:18:53 +0000 (14:18 +0000)]
Update po files to match new code base

Most changes are splitting up plural constructions into more "saner"
versions, e.g. _("message(s)") becomes ngettext("message", "messages",
n). In all the cases we used the old translation for the new pluralised
translation (in all plural forms). This might not be correct but yields
the same result as before the change to the end user.

6 years agoopcodes.h: Fix plural messages with "<word>(s)"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
opcodes.h: Fix plural messages with "<word>(s)"

Due to the implementation details we do not know whether we work with
zero, 1, 12, ... messages/files/.... So in English we use normal plural.
We leave it up to the translator to choose a fitting translation. Some
language might have other means to express this situation.

6 years agocurs_main.c: Fix plural messages with "messages"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
curs_main.c: Fix plural messages with "messages"

Due to the implementation details we do not know whether we
delete/undelete/mark/... zero, 1, 12, ... messages. So in English we use
"messages". We leave it up to the translator to choose a fitting
translation. Some language might have other means to express this
situation.

6 years agopager.c: Fix plural messages with "messages"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
pager.c: Fix plural messages with "messages"

Due to the implementation details we do not know whether we
delete/undelete zero, 1, 12, ... messages. So in English we use
"messages". We leave it up to the translator to choose a fitting
translation. Some language might have other means to express this
situation.

6 years agohandler.c: Partly fix plural message about attachment size
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
handler.c: Partly fix plural message about attachment size

Use ngettext() to choose a (more) correct plural form for 'byte'
depending on the attachment size. There is a caveat though: We do not
print the size as number but as a prettified number, e.g.  2048 will be
printed as 2K. Some languages might inflect 'byte' different depending
on whether it is '1K byte' or '1024'. Sadly there is nothing we can do
about that in the moment (besides not using the prettified version but
that is not an option).

6 years agoncrypt/crypt_gpgme.c: Fix plural message "%s, %lu bit %s\n"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
ncrypt/crypt_gpgme.c: Fix plural message "%s, %lu bit %s\n"

Give translators to opportunity to inflect "bit" according to the bit
size of the key.

6 years agopop.c: Fix plural message "Reading new messages (%d bytes)..."
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
pop.c: Fix plural message "Reading new messages (%d bytes)..."

Although the English use case with "1 byte" is unlikely to happen, other
languages might have other rules.

6 years agomx.c: Fix plural message "Move %d read messages to %s?"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
mx.c: Fix plural message "Move %d read messages to %s?"

6 years agorecvattach.c: Fix plural message "Print tagged attachments?"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
recvattach.c: Fix plural message "Print tagged attachments?"

If messages are tagged, then count them and use the number to pluralise
the phrase "tagged messages" correctly.

6 years agoncrypt/ncrypt.c: Fix plural message "Passphrases forgotten."
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
ncrypt/ncrypt.c: Fix plural message "Passphrases forgotten."

Due to the implementation details (e.g. some passwords are managed by
gpg-agent) we cannot know whether we forgot zero, 1, 12, ...  passwords.
So in English we use a generic plural. Different languages might have
other means, so we leave the decision what to choose to the translator.

6 years agomx.c: Fix plural message "messages(s) not deleted"
Reis Radomil [Tue, 22 May 2018 14:16:12 +0000 (14:16 +0000)]
mx.c: Fix plural message "messages(s) not deleted"

6 years agoUpdate po files
Reis Radomil [Sun, 20 May 2018 02:03:58 +0000 (02:03 +0000)]
Update po files

6 years agopager.c: Mark two strings for translation
Reis Radomil [Sun, 20 May 2018 02:02:01 +0000 (02:02 +0000)]
pager.c: Mark two strings for translation

Mark to strings which are displayed to the end user for translation.

Fixes #1217

6 years agoUpdated Slovak translation
David Sterba [Tue, 22 May 2018 13:49:19 +0000 (15:49 +0200)]
Updated Slovak translation

6 years agofix inappropriate use of FREE() in ssl init error path
Oswald Buddenhagen [Sun, 6 Jan 2013 18:24:18 +0000 (19:24 +0100)]
fix inappropriate use of FREE() in ssl init error path

OpenSSL structures need to be freed with dedicated functions.

6 years agoRemove mutt_buffer_new() NULL retval checks.
Kevin McCarthy [Mon, 21 May 2018 22:12:47 +0000 (15:12 -0700)]
Remove mutt_buffer_new() NULL retval checks.

It will fail, rather than return NULL.

Further clean up imap_new_data() since it also had NULL checks for
safe_calloc() that shouldn't happen.

6 years agomerge: trivial improvements
Richard Russon [Tue, 29 May 2018 01:48:27 +0000 (02:48 +0100)]
merge: trivial improvements

 * fix comment
 * fix formatting
 * tidy main
 * mutt_file_sanitize_filename bool param
 * mutt_param_cmp_strict bool retval
 * content state bools
 * use buffer printf
 * include queue.h in mutt/mutt.h
 * bool param
 * tidy handler.c
 * split out enriched text code

6 years agosplit out enriched text code
Richard Russon [Tue, 29 May 2018 01:35:18 +0000 (02:35 +0100)]
split out enriched text code

6 years agotidy handler.c
Richard Russon [Mon, 28 May 2018 19:42:51 +0000 (20:42 +0100)]
tidy handler.c

6 years agobool param
Richard Russon [Mon, 28 May 2018 18:45:04 +0000 (19:45 +0100)]
bool param

6 years agoinclude queue.h in mutt/mutt.h
Richard Russon [Mon, 28 May 2018 18:43:30 +0000 (19:43 +0100)]
include queue.h in mutt/mutt.h

6 years agouse buffer printf
Richard Russon [Mon, 28 May 2018 13:17:32 +0000 (14:17 +0100)]
use buffer printf

6 years agocontent state bools
Richard Russon [Sun, 27 May 2018 19:22:35 +0000 (20:22 +0100)]
content state bools

6 years agomutt_param_cmp_strict bool retval
Richard Russon [Sun, 27 May 2018 18:40:58 +0000 (19:40 +0100)]
mutt_param_cmp_strict bool retval

6 years agomutt_file_sanitize_filename bool param
Richard Russon [Sun, 27 May 2018 18:33:25 +0000 (19:33 +0100)]
mutt_file_sanitize_filename bool param

6 years agotidy main
Richard Russon [Fri, 25 May 2018 00:20:00 +0000 (01:20 +0100)]
tidy main

6 years agofix formatting
Richard Russon [Thu, 24 May 2018 11:13:40 +0000 (12:13 +0100)]
fix formatting

6 years agofix comment
Richard Russon [Wed, 23 May 2018 12:34:28 +0000 (13:34 +0100)]
fix comment

6 years agoMove LSUB call from connection establishment to mailbox SELECTion (#1232)
Pietro Cerutti [Mon, 28 May 2018 12:42:30 +0000 (13:42 +0100)]
Move LSUB call from connection establishment to mailbox SELECTion (#1232)

* Move LSUB call from connection establishment to mailbox SELECTion

This changes the place where an LSUB is issued to an IMAP server in
order to populate the buffy list, when imap_check_subscribed is set.

Previously, LSUB was issued when a connection to an IMAP server was
*first* established.  This caused the commands sequence

  ":unmailboxes *<enter><change-folder>imaps://foo.com<enter>"

to populate the buffy list when *first* opening a connection to foo.com,
but not on subsequent back-and-forth between IMAP servers.

The new code moves the LSUB call - and thus the population of the buffy
list - to just before a mailbox is selected.
This fixes the above-mentioned issue, at the cost of additional LSUB
calls when switching between mailboxes on the same server. Given that
the list of subscribed mailboxes is expected to be in the tens, I think
this is a reasonable tradeoff.

Issue #1225