Greg Ames [Wed, 7 Nov 2001 15:41:43 +0000 (15:41 +0000)]
Insure that ap_get_client_block _always_ sets the length parm positive when
calling ap_get_brigade. This takes care of the loop with short request bodies
seen on 2.0.27.
This eliminates the use of r->remaining within ap_get_client_block.
http_filter has the equivalent in its context. r->remaining is
still used in ap_setup_client_block for a "body too long" check. But that
check can't cover chunked bodies, so it probably should happen elsewhere.
Doug MacEachern [Wed, 7 Nov 2001 05:41:22 +0000 (05:41 +0000)]
ap_getline() is useful to modules outside of the core..
change declaration from AP_CORE_DECLARE to AP_DECLARE so it can be used
used outside the core
PR:
Obtained from:
Submitted by:
Reviewed by:
Joshua Slive [Tue, 6 Nov 2001 19:09:51 +0000 (19:09 +0000)]
Put the ssl docs in a format where they will be maintainable without Ralf's
tools. Mostly I've only touched the top and the bottom of each doc.
I also got rid of the old cover page and the overview, since they seemed
obsolete.
Once again, I apologize for wrecking Ralf's nice work.
htdbm provides a compiled interface to dbm authentication databases,
using the compiled-in dbm manager and auth schema. Resolves the hassles
of grabbing the appropriate cpan package for md5 and fixing the dbm
engine for dbmmanage.pl.
Joshua Slive [Tue, 6 Nov 2001 16:06:13 +0000 (16:06 +0000)]
I am just moving the reference chapter of the ssl docs into the modules directory
to be the baseline. The next commit will put it in the correct format.
Ian Holsman [Mon, 5 Nov 2001 23:06:55 +0000 (23:06 +0000)]
Fix so that errordocument works when a error gets returned from the
proxy.
Problem was ErrorHandler thought it was in some kind of recursion and
couldn't find the custom error document
Obtained from: Jin Hong <jinh@cnet.com>
Submitted by:
Reviewed by: Ian Holsman
This patch optimizes away some strlen and strcat calls in
ap_directory_walk. The strlen calls, in particular, had
ranked as a top bottleneck in the usr-space code in recent
performance profiling.
Submitted by: Brian Pane <bpane@pacbell.net>
Reviewed by: Justin Erenkrantz
Aaron Bannert [Fri, 2 Nov 2001 21:49:35 +0000 (21:49 +0000)]
Forces suexec to be compiled statically. This is necessary since it
is difficult and sometimes impossible to relocate executables that
are both setuid and dependent on dynamically loaded libraries.
(that is: setuid binaries ignore LD_* environment variables).
Greg Stein [Fri, 2 Nov 2001 19:25:50 +0000 (19:25 +0000)]
Don't change the type of the new resource. The provider will update it
when the copy/move takes place.
Specifically, the new location might imply a different type from the
original, so updating the type is bad mojo. In the observed case, a
resource was copied into a working collection; the type of the new
resource is supposed to be WORKING. Copying the type would be wrong if
the source was REGULAR.
Make this a bit more formal, as in httpd.conf. Also should cite the
contributor, but only Ralf knows who all should be the primary citation,
if not simply "the modssl project". I don't know if this conf is all
new material, significantly created by the modssl project, or if much
of it goes all the way back to ApacheSSL. Rather that miss-attribute,
I'm leaving line one for someone else [Ralf?] to add, vis-a-vie the
citation in httpd-std.conf line 2.
Roy T. Fielding [Thu, 1 Nov 2001 00:05:58 +0000 (00:05 +0000)]
Since we are in a file that is only included with mod_ssl.c and
there is no point in any of it if SSL is not defined, just wrap
the whole thing in one IfDefine.
Greg Ames [Wed, 31 Oct 2001 21:14:23 +0000 (21:14 +0000)]
change ap_getline to return the size of the buffer when there's no apparent end
to an input line. This is more like the 1.3 behavior which should help the
callers recognize this condition.
Greg Ames [Wed, 31 Oct 2001 20:18:56 +0000 (20:18 +0000)]
return the actual number of bytes read when we're in "read a line" mode and it
looks like the line may never end.
This lets ap_getline determine whether there's excessive bytes or not,
depending on the size of its caller's buffers. If the buffer can accomodate
more bytes, ap_getline will continue to read.
Aaron Bannert [Wed, 31 Oct 2001 18:21:53 +0000 (18:21 +0000)]
Fix a big memory leak bug related to arbitrarily large header lines.
The core input filter would happily consume all the data you gave it
in a header line, looking for that one LF. This patch limits that
"getline" functionality to HUGE_STRING_LEN (8192 bytes).
Joshua Slive [Sat, 27 Oct 2001 22:22:00 +0000 (22:22 +0000)]
Fix some broken links, change to the simplest possible example, and add a
couple notes to give hints to people running servers behind port-forwarding
firewalls.
Jeff Trawick [Sat, 27 Oct 2001 14:01:13 +0000 (14:01 +0000)]
make shared libraries executable so they work on HP-UX
(I'm not sure that this logic for copying DSOs will survive
in the libtool scheme; I'm putting this 1.3 fix in just in
case.)
Fix RedirectMatch handling to properly handle URLs with host portions.
Previously, we would segfault if no path is specified (case 1 below).
We would also ignore any host and scheme portion of the URL (which is
how we specify it on daedalus), so restore that capability.
The query strings will still not be escaped (standards cops can
determine if this is correct behavior).
The following directives now work as expected:
RedirectMatch /jakarta1(.*) http://jakarta.apache.org$1
RedirectMatch /jakarta2(.*) http://jakarta.apache.org/dist$1
RedirectMatch /jakarta3(.*) http://jakarta.apache.org/dist$1?bar=foo
RedirectMatch /jakarta4(.*) http://jakarta.apache.org/dist$1?bar=foo#spaz
Greg Ames [Fri, 26 Oct 2001 15:40:04 +0000 (15:40 +0000)]
prevent seg faults in mod_status trying to access vhost structures from
the former generation, after a restart. It happens mostly when the MPM has
threads.
Aaron Bannert [Wed, 24 Oct 2001 17:20:44 +0000 (17:20 +0000)]
Two more mod_so configure-time fixes:
- Treat --enable-so=yes as "static" (this includes --enable-so, etc).
- An explicit --enable-so=shared issues an error.
Put in a note about the last condition that I'm not as sure how to fix:
If the user doesn't explicitly request mod_so, but instead gives a
mass-enable parameter like --enable-modules=most or
--enable-mods-shared=most then it is still possible to enable a bunch
of modules while mod_so itself is not buildable (ie no APR_HAS_DSO or
other build dependency failure).
Aaron Bannert [Tue, 23 Oct 2001 23:13:27 +0000 (23:13 +0000)]
If the user explicitly requests --enable-so, --enable-so=yes,
--enable-so=static, or --enable-so=shared but APR_HAS_DSO is
not defined on their system, then it is a fatal error.
Tested on Solaris, but I think it should work everywhere else.
Feel free to change the error message to something
better/more descriptive/etc.
Bill Stoddard [Tue, 23 Oct 2001 17:13:26 +0000 (17:13 +0000)]
Win32: Track and display "Parent Server Generation:" in
mod_status output. The generation will be bumped at
server graceful restart, when the child process exits
by hitting MaxRequestsPerChild or if the child
process exits abnormally. [Bill Stoddard]
Cliff Woolley [Tue, 23 Oct 2001 09:41:54 +0000 (09:41 +0000)]
Fix a segfault seen on daedalus earlier this evening. All that was happening
was that we forgot to check whether ctx->bb was empty, so when we pulled the
first bucket, it would be the sentinel, and we'd segfault trying to apr_bucket_read
the sentinel.
projects / apache / log