Brendan Cully [Mon, 16 Aug 2004 21:36:38 +0000 (21:36 +0000)]
If STARTTLS fails to complete the SSL handshake, the error is not
propagated and mutt will attempt to log in anyway, probably causing an
infinite block on read. The attached patch closes the socket in this
case, and propagates the error properly.
Brendan Cully [Mon, 16 Aug 2004 21:36:06 +0000 (21:36 +0000)]
The attached patch causes mutt to attempt the next method in
imap_authenticators if the previous method failed, even if the server
reported that the method was available. Previously mutt would give up
if any authentication method failed.
Elmar Hoffmann [Wed, 14 Jul 2004 05:19:15 +0000 (05:19 +0000)]
By default Mutt hides the subject of messages in the thread tree
that have the same subject as their parent or closest previously
displayed sibling. This patch makes this optional, introducing the
hide_thread_subject boolean setting which defaults to the old
behaviour.
Thomas Roessler [Wed, 14 Jul 2004 04:34:07 +0000 (04:34 +0000)]
Fix a cvs commit SNAFU: This commit undoes the include_onlyfirst
patch, but leaves the generic spam detection by David Champion in
place (which, erroneously, hadn't been committed automatically).
Thomas Roessler [Mon, 12 Jul 2004 13:22:24 +0000 (13:22 +0000)]
Add some debugging code, and rewrite the previously-ununderstandable
mutt_remove_duplicates. (All this done on the search for a problem
that ultimately turned out to be a configuration issue. Still, the
changed code could come in handy some day.)
Moritz Schulte [Thu, 17 Jun 2004 20:36:13 +0000 (20:36 +0000)]
This is the sequel to the crypto modularization changes I did on
2003-01-21. Moritz added another abstraction layer which cleans up
the code and allows the crypto modules to use their own option menu.
Everything should work as it used to but is now in a really good
shape for part III, the Return of the GnuPG Easy Makers. -wk
* crypt-mod-pgp-classic.c, crypt-mod-smime-classic.c, crypt-mod.c,
crypt-mod.h: New files.
* smime.c (smime_valid_passphrase, smime_send_menu): New functions.
* smime.h: Removed macro: smime_valid_passphrase.
Declared: smime_valid_passphrase, smime_send_menu.
* pgp.c: Include "mutt_menu.h".
(pgp_valid_passphrase, pgp_send_menu): New functions.
* pgp.h: Removed macro: pgp_valid_passphrase.
Declared: pgp_valid_passphrase, pgp_send_menu.
* mutt_curses.h: Declare: mutt_need_hard_redraw.
* mutt_crypt.h: Declare: crypt_pgp_valid_passphrase,
crypt_pgp_send_menu, crypt_smime_valid_passphrase,
crypt_smime_send_menu, crypt_init.
Adjust WithCrypto definition since the GPGME backend does not
exclude anymore the other `classic' backends.
(KEYFLAG_ISX509): New symbol.
* mutt.h (enum): New symbol: OPTCRYPTUSEGPGME.
(struct body): New member: is_signed_data, warnsig.
* main.c (main): Call crypt_init.
* keymap.c (km_get_table): Support for MENU_KEY_SELECT_PGP and
MENU_KEY_SELECT_SMIME.
(Menus): Added entries fuer MENU_KEY_SELECT_PGP and
MENU_KEY_SELECT_SMIME.
(km_init): Create bindings for MENU_KEY_SELECT_PGP and
MENU_KEY_SELECT_SMIME.
* keymap.h (enum): New enum symbols: MENU_KEY_SELECT_PGP,
MENU_KEY_SELECT_SMIME.
* init.h: New configuration variable: crypt_use_gpgme.
* compose.c (pgp_send_menu, smime_send_menu): Removed functions,
they are now contained in the crypto backend modules.
(mutt_compose_menu): Use crypt_pgp_send_menu and
crypt_smime_send_menu instead pgp_send_menu and smime_send_menu.
* cryptglue.c: Slightly rewritten in order to make use of the
module mechanism used to access crypto backends.
* curs_lib.c (mutt_need_hard_redraw): New function.
* crypt.c (crypt_forget_passphrase): Adjust for new crypto backend
interface.
(crypt_valid_passphrase): Stripped, use calls to
crypt_pgp_valid_passphrase and crypt_smime_valid_passphrase.
Thomas Roessler [Mon, 12 Apr 2004 20:33:33 +0000 (20:33 +0000)]
A belated fix for #1808 (Debian #233106): Make sure
check-traditional-pgp doesn't leave the pager context unnecessarily.
This makes message-hooks like this one safe: