Bruce Momjian [Sat, 28 Dec 1996 02:22:12 +0000 (02:22 +0000)]
Here is a bug fix and some spelling changes for the complex number tutorial
code. I have also written a complete complex number package based on this
tutorial; I will submit this as a contribution soon. Is there a particular
format for contributed tar files? I have a C source file, two SQL files, and a
Makefile.
Vadim B. Mikheev [Fri, 27 Dec 1996 13:13:58 +0000 (13:13 +0000)]
There was JMP_BUF defined in config.h. And SIGJMP_BUF later.
And now - JMP_BUF again. Is it enough, folks ?
Fixed again:
cc1: warnings being treated as errors
exc.c: In function 'ExcRaise':
exc.c:187: warning: passing arg 1 of 'Longjmp' from incompatible pointer type
gmake[3]: *** [exc.o] Error 1
Bruce Momjian [Thu, 26 Dec 1996 17:47:42 +0000 (17:47 +0000)]
I have this annoying habit (among others) of putting
%ud in a printf format strings instead of just %u.
There were three occurances of this in catalog_utils.c,
two in parser.c and one in rewriteSupport.c in the oid
patch that I submitted and was applied. They won't crash
anything, but the error messages will have a 'd' after the
Oid. Annoying, but none are db-threatening.
Sorry about that folks...I'll be more careful in the future...
Bruce Momjian [Thu, 26 Dec 1996 17:46:07 +0000 (17:46 +0000)]
In src/backend/catalog/pg_operator.c in OperatorDef, there
are three SearchSysCacheTuple(PRONAME,...) calls that use three
different macros to convert the typeId array of Oids.
Bruce Momjian [Thu, 26 Dec 1996 17:44:46 +0000 (17:44 +0000)]
Removal of CppConcat from indexam.c.
As an example I sent a bug-report on 26 Nov to tell that the fix included
below is necessary to compile pg95-current on Ultrix with Digital's
standard C compiler c89. In fact I think that this fix is needed
for any C compiler sticking very close the standard, see my discussion
in the original bug report.
Vadim B. Mikheev [Sat, 14 Dec 1996 07:56:05 +0000 (07:56 +0000)]
Avoiding:
cc1: warnings being treated as errors
datum.c: In function `DatumGetSize':
datum.c:57: warning: unsigned value >= 0 is always 1
gmake[3]: *** [datum.o] Error 1
There was:
if (byVal) {
if (len >= 0 && len <= sizeof(Datum)) {
but len has type Size (unsigned int) and so now there is:
if (byVal) {
if (len <= sizeof(Datum)) {
Vadim B. Mikheev [Sat, 14 Dec 1996 05:55:27 +0000 (05:55 +0000)]
Avoiding
cc1: warnings being treated as errors
exc.c: In function 'ExcRaise':
exc.c:186: warning: passing arg 1 of 'Longjmp' from incompatible pointer type
gmake[3]: *** [exc.o] Error 1
Now we have:
#if defined (JMP_BUF)
longjmp(efp->context, 1);
#else
siglongjmp(efp->context, 1);
#endif
Vadim B. Mikheev [Sat, 14 Dec 1996 05:20:39 +0000 (05:20 +0000)]
Avoiding
cc1: warnings being treated as errors
transsup.c: In function `TransBlockGetLastTransactionIdStatus':
transsup.c:122: warning: unsigned value >= 0 is always 1
gmake[3]: *** [transsup.o] Error 1
...
1. _bt_compare fixed to work properly with new code in _bt_insertonpg
(old _bt_compare always returned >= 0 while comparing with P_HIKEY
on root page - it breaks root page when _bt_insertonpg tries insert
new minimal key into root page).
2. Fixed bug concerns "empty" pages: non-rightmost pages with only P_HIKEY
present on it. Such pages appear after vacuum.
Bruce Momjian [Sat, 30 Nov 1996 18:07:02 +0000 (18:07 +0000)]
This patch changes quite a few instances of references of Oid's
as ints and longs. Touches on quite a few function args as
well. Most other files look ok as far as Oids go...still checking
though...
Since Oids are type'd as unsigned ints, they should prolly be used
with the %ud format string in elog and sprintf messages. Not sure
what kind of strangeness that could produce.