]>
granicus.if.org Git - taglib/log
Tsuda Kageyu [Thu, 21 May 2015 03:15:11 +0000 (12:15 +0900)]
FLAC: AudioProperties improvements
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503)
Add bitsPerSample() property besides sampleWidth(). (#360)
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
Tsuda Kageyu [Fri, 31 Jul 2015 11:55:23 +0000 (20:55 +0900)]
Silence some MSVC specific warnings in tests.
Tsuda Kageyu [Fri, 31 Jul 2015 03:23:01 +0000 (12:23 +0900)]
Silence some MSVC2015 specific warnings.
Tsuda Kageyu [Fri, 31 Jul 2015 02:24:36 +0000 (11:24 +0900)]
MP4 atom length is limited up to 31 bits.
32-bit value will be negative.
Tsuda Kageyu [Fri, 31 Jul 2015 01:27:16 +0000 (10:27 +0900)]
Add some comments to tutils.h.
Tsuda Kageyu [Fri, 31 Jul 2015 01:10:12 +0000 (10:10 +0900)]
Reorder CMake checks for sprintf() variants.
VS2015 has snprintf(), however sprintf_s() is still recommended.
Tsuda Kageyu [Fri, 31 Jul 2015 00:02:32 +0000 (09:02 +0900)]
Remove sudo from .travis.yml.
This allows our tests to run faster on the container-based infrastructure.
Tsuda Kageyu [Thu, 30 Jul 2015 14:55:16 +0000 (23:55 +0900)]
Merge pull request #554 from FestusHagen/fh1.m_FriendlyCppUnitSearch
Don't look for CppUnit unless BUILD_TESTS, general cleanup.
Tsuda Kageyu [Thu, 30 Jul 2015 14:39:04 +0000 (23:39 +0900)]
Merge pull request #595 from TsudaKageyu/gcc-warning-test
Silence a GCC warning about ignoring a return value in test.
Tsuda Kageyu [Thu, 30 Jul 2015 14:36:44 +0000 (23:36 +0900)]
Fix a typo in a debug message.
Tsuda Kageyu [Thu, 30 Jul 2015 14:30:43 +0000 (23:30 +0900)]
Merge pull request #625 from TsudaKageyu/checksum-comment
(minor, comment only) Add a supplementary comment to ByteVector::checksum().
Tsuda Kageyu [Thu, 30 Jul 2015 14:30:18 +0000 (23:30 +0900)]
Merge pull request #617 from TsudaKageyu/useless-call
Remove an useless function call.
Tsuda Kageyu [Thu, 30 Jul 2015 13:03:02 +0000 (22:03 +0900)]
Update NEWS.
Fixed reading FLAC files with zero-sized padding blocks.
Tsuda Kageyu [Thu, 30 Jul 2015 13:00:00 +0000 (22:00 +0900)]
Merge pull request #638 from TsudaKageyu/update-news
Update NEWS.
Tsuda Kageyu [Thu, 30 Jul 2015 12:58:42 +0000 (21:58 +0900)]
Merge pull request #637 from TsudaKageyu/flac-zero-sized-padding
Make FLAC::File tolerant to zero-sized padding blocks.
Tsuda Kageyu [Thu, 30 Jul 2015 01:02:51 +0000 (10:02 +0900)]
Update NEWS.
Tsuda Kageyu [Wed, 29 Jul 2015 14:05:17 +0000 (23:05 +0900)]
Avoid creating zero-sized padding blocks.
Tsuda Kageyu [Wed, 29 Jul 2015 11:52:56 +0000 (20:52 +0900)]
Make FLAC::File tolerant to zero-sized padding blocks.
Tsuda Kageyu [Fri, 26 Jun 2015 16:29:16 +0000 (01:29 +0900)]
Add a supplementary comment to ByteVector::checksum().
Tsuda Kageyu [Sun, 21 Jun 2015 18:21:38 +0000 (03:21 +0900)]
Remove an useless function call.
Scott Wheeler [Fri, 19 Jun 2015 07:12:32 +0000 (09:12 +0200)]
Merge pull request #614 from TsudaKageyu/win32-pkg-config
Enable pkg-config on Windows.
Tsuda Kageyu [Thu, 18 Jun 2015 16:26:12 +0000 (01:26 +0900)]
Enable pkg-config on Windows.
Scott Wheeler [Thu, 18 Jun 2015 06:22:59 +0000 (08:22 +0200)]
Merge pull request #611 from TsudaKageyu/fix-bufsize
Fix mismatched file I/O buffer sizes.
Tsuda Kageyu [Thu, 18 Jun 2015 02:22:54 +0000 (11:22 +0900)]
Fix mismatched file I/O buffer sizes.
Scott Wheeler [Mon, 15 Jun 2015 19:15:08 +0000 (21:15 +0200)]
Merge pull request #607 from TsudaKageyu/unused-function
Remove some unused private function prototypes.
Tsuda Kageyu [Fri, 12 Jun 2015 05:07:52 +0000 (14:07 +0900)]
Removed an unused data member from MPE::File.
It seems to be related to scan().
Tsuda Kageyu [Fri, 12 Jun 2015 02:50:38 +0000 (11:50 +0900)]
Remove some unused private function prototypes.
Tsuda Kageyu [Tue, 9 Jun 2015 18:44:30 +0000 (03:44 +0900)]
Silence a GCC warning about ignoring a return value in test.
Stephen F. Booth [Tue, 9 Jun 2015 02:19:27 +0000 (22:19 -0400)]
Merge pull request #594 from TsudaKageyu/typos-in-comment
Fix some typos in comments.
Tsuda Kageyu [Tue, 9 Jun 2015 01:33:32 +0000 (10:33 +0900)]
Fix some typos in comments.
Scott Wheeler [Tue, 2 Jun 2015 23:20:48 +0000 (01:20 +0200)]
Add const to docs
Stephen F. Booth [Tue, 2 Jun 2015 12:19:33 +0000 (08:19 -0400)]
Merge pull request #591 from TsudaKageyu/wmemcpy
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
Tsuda Kageyu [Mon, 1 Jun 2015 04:52:55 +0000 (13:52 +0900)]
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
Festus Hagen [Mon, 1 Jun 2015 02:12:18 +0000 (22:12 -0400)]
Undo comment stacking.
Michael Helmling [Fri, 29 May 2015 17:53:42 +0000 (19:53 +0200)]
Prefix #ifndef with TAGLIB_ in tpropertymap.h
Scott Wheeler [Tue, 26 May 2015 15:53:24 +0000 (17:53 +0200)]
Merge pull request #577 from TsudaKageyu/frameoffset
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190)
Stephen F. Booth [Mon, 25 May 2015 12:41:37 +0000 (08:41 -0400)]
Merge pull request #578 from TsudaKageyu/test-temp
A lot of zero-sized temporary files are left after a test session on …
Tsuda Kageyu [Mon, 25 May 2015 06:51:19 +0000 (15:51 +0900)]
A lot of zero-sized temporary files are left after a test session on Windows.
Stephen F. Booth [Sun, 24 May 2015 18:38:50 +0000 (14:38 -0400)]
Merge pull request #574 from TsudaKageyu/skip-dup-chunks
Skip duplicate chunks when reading AIFF/WAV files.
Tsuda Kageyu [Sun, 24 May 2015 17:41:27 +0000 (02:41 +0900)]
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190)
Tsuda Kageyu [Sun, 24 May 2015 15:40:13 +0000 (00:40 +0900)]
Skip duplicate chunks when reading AIFF/WAV files.
Similar to #492.
There is no good reason to use the last chunk rather than the first one.
Stephen F. Booth [Sat, 23 May 2015 12:21:58 +0000 (08:21 -0400)]
Merge pull request #572 from TsudaKageyu/map-erase2
Map::erase() can take a key directly so no need to call find() before…
Tsuda Kageyu [Sat, 23 May 2015 09:12:01 +0000 (18:12 +0900)]
Map::erase() can take a key directly so no need to call find() beforehand.
Stephen F. Booth [Fri, 22 May 2015 11:44:41 +0000 (07:44 -0400)]
Merge pull request #571 from TsudaKageyu/fuzzed-wv
Avoid an infinite loop when reading fuzzed WavPack files. (#482)
Stephen F. Booth [Fri, 22 May 2015 11:41:46 +0000 (07:41 -0400)]
Merge pull request #570 from TsudaKageyu/audioprop-typo
Fix a typo in comment.
Tsuda Kageyu [Fri, 22 May 2015 05:11:06 +0000 (14:11 +0900)]
Avoid an infinite loop when reading fuzzed WavPack files. (#482)
Tsuda Kageyu [Fri, 22 May 2015 03:05:33 +0000 (12:05 +0900)]
Fix a typo in comment.
Stephen F. Booth [Fri, 22 May 2015 02:46:15 +0000 (22:46 -0400)]
Merge pull request #569 from TsudaKageyu/map-erase
std::map::erase() can take a key directly and has no-throw guarantee.
Stephen F. Booth [Fri, 22 May 2015 02:44:10 +0000 (22:44 -0400)]
Merge pull request #484 from TsudaKageyu/fix-rfind
Fix File::rfind() for small files.
Tsuda Kageyu [Thu, 21 May 2015 16:26:56 +0000 (01:26 +0900)]
std::map::erase() can take a key directly and has no-throw guarantee.
Lukáš Lalinský [Wed, 20 May 2015 22:18:01 +0000 (15:18 -0700)]
TagLib::XM::Properties is a public class that should be exported
Festus Hagen [Wed, 20 May 2015 19:34:05 +0000 (15:34 -0400)]
Removed missed unnecessary BUILD_TESTS check.
Scott Wheeler [Wed, 20 May 2015 17:24:52 +0000 (19:24 +0200)]
Merge pull request #550 from TsudaKageyu/fix-test
Fix test code to work on some environments.
Tsuda Kageyu [Wed, 20 May 2015 17:03:06 +0000 (02:03 +0900)]
Fix test code to work on some environments.
const char * is more preferable than string for ifstream constructor.
Festus Hagen [Wed, 20 May 2015 05:16:54 +0000 (01:16 -0400)]
Don't look for CppUnit unless BUILD_TESTS, general cleanup.
Scott Wheeler [Wed, 20 May 2015 12:23:48 +0000 (14:23 +0200)]
Bring the API more in line with the rest of TagLib
Like in #255, this also makes it possible to read values from the
tag in a const function.
Scott Wheeler [Wed, 20 May 2015 11:50:49 +0000 (13:50 +0200)]
Merge pull request #549 from TsudaKageyu/win32-test
Modify the test code to work on MSVC/Windows.
Tsuda Kageyu [Wed, 20 May 2015 10:57:08 +0000 (19:57 +0900)]
Modify the test code to work on MSVC/Windows.
Scott Wheeler [Wed, 20 May 2015 09:53:32 +0000 (11:53 +0200)]
This should also work Windows and has less duplicated code
Scott Wheeler [Wed, 20 May 2015 09:43:43 +0000 (11:43 +0200)]
Don't use tempnam on UNIX
This silences the huge stream of warnings when building the tests.
I think I didn't break the Windows version in the process (though
it may make sense to use the built in Windows functions there
instead), but I don't have a Windows build environment here, so
I can't test.
Scott Wheeler [Tue, 19 May 2015 17:57:47 +0000 (19:57 +0200)]
Merge pull request #546 from TsudaKageyu/test-surrogate-pair
Add a test for strings that contains surrogate pairs.
Scott Wheeler [Tue, 19 May 2015 09:28:50 +0000 (11:28 +0200)]
Merge pull request #548 from TsudaKageyu/render-twice
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
Tsuda Kageyu [Tue, 19 May 2015 08:39:37 +0000 (17:39 +0900)]
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
Scott Wheeler [Tue, 19 May 2015 08:15:15 +0000 (10:15 +0200)]
Quote path names including user-provided variables
This should make these work even if the value contains spaces
Closes #344
Tsuda Kageyu [Mon, 23 Feb 2015 00:38:12 +0000 (09:38 +0900)]
Add a test for strings that contains surrogate pairs.
Scott Wheeler [Mon, 18 May 2015 21:11:51 +0000 (23:11 +0200)]
Remove *file argument to private members
This is already covered by d->file, so there's no reason to pass a pointer
to the member dozens of times.
Scott Wheeler [Mon, 18 May 2015 21:00:16 +0000 (23:00 +0200)]
Moar const fixes
Scott Wheeler [Mon, 18 May 2015 20:25:00 +0000 (22:25 +0200)]
1001 Const fixes (plus iterator rename)
Scott Wheeler [Mon, 18 May 2015 19:40:11 +0000 (21:40 +0200)]
Remove unnecessary checks for null before delete
Closes #343
Scott Wheeler [Mon, 18 May 2015 19:36:37 +0000 (21:36 +0200)]
Merge pull request #515 from TsudaKageyu/empty-id3v2-frame
Skip empty ID3v2 frames when saving an ID3v2 tag.
Scott Wheeler [Mon, 18 May 2015 19:18:33 +0000 (21:18 +0200)]
Add accessors to manipulate MP4 tags without modifying the internal structure
This brings the MP4 API in line closer to other tag formats and makes it
possible to access the tag data from const functions.
"ItemListMap" has been renamed to "ItemMap" (with the old version
deprecated). It seems that the "ListMap" notion was copied probably
from Allan's ApeTag implementation, which incorrectly copied the term
from the XiphTag. Notably, in XiphTag, because a field can have multiple
values, the "ListMap" is a map of lists. Calling things a "ListMap" where
there can be only one value doesn't fit.
Closes #255
Scott Wheeler [Mon, 18 May 2015 18:30:19 +0000 (20:30 +0200)]
Add isEmpty() to MP4
Closes #457
Scott Wheeler [Mon, 18 May 2015 17:51:18 +0000 (19:51 +0200)]
Show something useful for ChapterFrame::toString()
Closes #517
Tsuda Kageyu [Thu, 1 Jan 2015 07:40:13 +0000 (16:40 +0900)]
Fix File::rfind() for small files to work just like ByteVector::rfind().
Scott Wheeler [Mon, 18 May 2015 16:19:43 +0000 (18:19 +0200)]
Update signature and docs
Specifically this allows the frame to be constructed and then to have
the children and embedded frames set later.
Scott Wheeler [Mon, 18 May 2015 16:12:34 +0000 (18:12 +0200)]
Remove the null termination stuff from the ToC frames too
Scott Wheeler [Mon, 18 May 2015 15:29:52 +0000 (17:29 +0200)]
We've moved away from including the null byte in the returned value
This does change previous behavior, but the previous behavior was
particularly stupid and inconsistent with everything else in TagLib.
It should be possible to mitigate this by putting the same safety
guards in the TableOfContents
Scott Wheeler [Mon, 18 May 2015 15:11:06 +0000 (17:11 +0200)]
Don't underflow if there are no embedded frames
Closes #513
Scott Wheeler [Mon, 18 May 2015 14:53:12 +0000 (16:53 +0200)]
This isn't tracked as part of the elementID anymore
Scott Wheeler [Mon, 18 May 2015 14:45:57 +0000 (16:45 +0200)]
Split chapter data and embedded frame data
This will allow us to test parsing them separately
Scott Wheeler [Mon, 18 May 2015 14:41:30 +0000 (16:41 +0200)]
Don't require users to include a padding byte explicitly
This makes it where the natural construction can be used of something
like:
new ChapterFrame("ID", ... )
Closes #514
Scott Wheeler [Mon, 18 May 2015 14:25:06 +0000 (16:25 +0200)]
Also test second constructor
Scott Wheeler [Mon, 18 May 2015 13:35:41 +0000 (15:35 +0200)]
Update signature and docs to be more in-line with TagLib's style
Scott Wheeler [Mon, 18 May 2015 13:09:28 +0000 (15:09 +0200)]
Merge pull request #544 from TsudaKageyu/advance
Use std::advance rather than a loop and increment.
Scott Wheeler [Mon, 18 May 2015 12:21:55 +0000 (14:21 +0200)]
It doesn't make sense to set the factory after construction
Closes #259
Scott Wheeler [Mon, 18 May 2015 10:42:24 +0000 (12:42 +0200)]
Make this macro work with current Qt versions
Closes #499
Tsuda Kageyu [Mon, 18 May 2015 10:03:20 +0000 (19:03 +0900)]
Add a test to check if an empty ID3v2 frame is really skipped.
Scott Wheeler [Mon, 18 May 2015 09:30:28 +0000 (11:30 +0200)]
Add astylerc
Tsuda Kageyu [Mon, 18 May 2015 00:31:43 +0000 (09:31 +0900)]
Use std::advance rather than a loop and increment.
Lukáš Lalinský [Sun, 17 May 2015 17:06:10 +0000 (10:06 -0700)]
Merge pull request #521 from TsudaKageyu/gcc-warning
Fix a GCC/Clang warning about singed/unsigned comparison.
Lukáš Lalinský [Sun, 17 May 2015 17:05:43 +0000 (10:05 -0700)]
Merge pull request #542 from TsudaKageyu/comment-typos
Fix some typos in comment.
Tsuda Kageyu [Sun, 17 May 2015 15:31:46 +0000 (00:31 +0900)]
Fix some typos in comment.
Lukáš Lalinský [Sun, 17 May 2015 00:03:53 +0000 (17:03 -0700)]
Merge pull request #535 from FestusHagen/fh1.m_UintAmbiguity
Silenced uint ambiguity error.
Lukáš Lalinský [Sat, 16 May 2015 03:06:24 +0000 (20:06 -0700)]
Merge pull request #538 from gogglesmm/optimize-mid-to-uint
bytevector.mid(pos,4).toUInt() => bytevector.toUInt(pos)
Lukáš Lalinský [Sat, 16 May 2015 02:48:43 +0000 (19:48 -0700)]
Merge pull request #536 from FestusHagen/fh1.m_CMakeSubProjectFix
Fix for using Taglib as a CMake sub directory project.
Lukáš Lalinský [Sat, 16 May 2015 02:43:38 +0000 (19:43 -0700)]
Merge pull request #533 from TsudaKageyu/bytevector-resize
Fix the wrong padding of ByteVector::resize().
Sander Jansen [Sat, 16 May 2015 02:39:34 +0000 (21:39 -0500)]
Fix code styling
Sander Jansen [Sat, 16 May 2015 02:25:44 +0000 (21:25 -0500)]
replace use of bytevector.mid(pos,4).toUInt() with more optimized bytevector.toUInt(pos)
Tsuda Kageyu [Sat, 16 May 2015 02:16:00 +0000 (11:16 +0900)]
Revert the last two commits.
But leave the tests unchanged, and add some comments.
Tsuda Kageyu [Fri, 15 May 2015 18:46:34 +0000 (03:46 +0900)]
Reduce redundant memset when resizing ByteVector.