]> granicus.if.org Git - postgresql/log
postgresql
20 years agoMention psql variable names are case-sensitive.
Bruce Momjian [Fri, 13 Feb 2004 05:10:02 +0000 (05:10 +0000)]
Mention psql variable names are case-sensitive.

20 years agoFix typo:
Bruce Momjian [Fri, 13 Feb 2004 04:47:13 +0000 (04:47 +0000)]
Fix typo:

< * Allow cross-db queries with transaction sematics
> * Allow cross-db queries with transaction semantics

20 years agoTom Lane wrote:
Bruce Momjian [Fri, 13 Feb 2004 04:40:06 +0000 (04:40 +0000)]
Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
>>      someone asked me about the FK deadlock fix, mentioned in the 7.3.3
>>      release notes as 3rd change:
>>      http://www.postgresql.org/docs/current/static/release-7-3-3.html
>>      Actually, that fix was available with 7.4, not 7.3. Don't know if we can
>>      retroactively change the release-notes though.
>
> This is completely erroneous, please undo it.
>
> 2003-05-21 14:14  tgl
>
>       * src/: backend/utils/adt/ri_triggers.c,
>       test/regress/expected/foreign_key.out (REL7_3_STABLE): Back-patch
>       Jan's fix to avoid primary key lookup (and lock) if foreign key
>       does not change on UPDATE.

Oh ... didn't know that you did a backpatch. Sorry

Jan

20 years agoAdd:
Bruce Momjian [Fri, 13 Feb 2004 04:36:02 +0000 (04:36 +0000)]
Add:

> * Use nested transactions to prevent syntax errors from aborting a transaction

20 years agoAdd:
Bruce Momjian [Fri, 13 Feb 2004 02:30:53 +0000 (02:30 +0000)]
Add:

> * Allow temporary views on non-temporary tables

20 years agoTry to make 'cross-database references are not implemented' errors a
Tom Lane [Fri, 13 Feb 2004 01:08:20 +0000 (01:08 +0000)]
Try to make 'cross-database references are not implemented' errors a
bit more helpful by identifying the specific qualified name being
complained of.

20 years agoAdd hooks for type-specific calculation of ANALYZE statistics. Idea and
Tom Lane [Thu, 12 Feb 2004 23:41:04 +0000 (23:41 +0000)]
Add hooks for type-specific calculation of ANALYZE statistics.  Idea and
coding by Mark Cave-Ayland, some kibitzing by Tom Lane.  initdb forced
due to new column in pg_type.

20 years agoAdd from Joe Conway:
Bruce Momjian [Thu, 12 Feb 2004 23:27:52 +0000 (23:27 +0000)]
Add from Joe Conway:

>  o Modify array literal representation to handle array index lower bound
>    of other than one
>
183d185
<

20 years agoAdd CVS ID tags to port/win32/files.
Bruce Momjian [Thu, 12 Feb 2004 20:37:34 +0000 (20:37 +0000)]
Add CVS ID tags to port/win32/files.

20 years agoJan:
Bruce Momjian [Thu, 12 Feb 2004 20:17:34 +0000 (20:17 +0000)]
Jan:

someone asked me about the FK deadlock fix, mentioned in the 7.3.3
release notes as 3rd change:

     http://www.postgresql.org/docs/current/static/release-7-3-3.html

Actually, that fix was available with 7.4, not 7.3. Don't know if we can
retroactively change the release-notes though.

20 years agoAvoid delaying postmaster shutdown by up to 10 seconds on platforms
Tom Lane [Thu, 12 Feb 2004 20:07:26 +0000 (20:07 +0000)]
Avoid delaying postmaster shutdown by up to 10 seconds on platforms
where signals do not terminate sleep() delays.

20 years agoImprove \? wording, remove 'internal'.
Bruce Momjian [Thu, 12 Feb 2004 19:58:16 +0000 (19:58 +0000)]
Improve \? wording, remove 'internal'.

20 years agoTranslation updates
Peter Eisentraut [Thu, 12 Feb 2004 19:19:32 +0000 (19:19 +0000)]
Translation updates

20 years agoAdd bitmap discussion to performance TODO.detail.
Bruce Momjian [Thu, 12 Feb 2004 18:13:29 +0000 (18:13 +0000)]
Add bitmap discussion to performance TODO.detail.

20 years agoRemove TODO.detail files that contained useless or very old information.
Bruce Momjian [Thu, 12 Feb 2004 18:11:54 +0000 (18:11 +0000)]
Remove TODO.detail files that contained useless or very old information.
Update TODO accordingly.

20 years agoDone:
Bruce Momjian [Thu, 12 Feb 2004 18:11:16 +0000 (18:11 +0000)]
Done:

<
<
< Reporting
< =========
<
< * Show location of syntax error in query [yacc]

20 years agoFile not needed:
Bruce Momjian [Thu, 12 Feb 2004 18:09:43 +0000 (18:09 +0000)]
File not needed:

.< * Improve speed with indexes (perhaps recreate index instead) [vacuum]
> * Improve speed with indexes (perhaps recreate index instead)
369c369
<   lock and truncate table [vacuum]
>   lock and truncate table
371c371
<   rather than in /contrib [vacuum]
>   rather than in /contrib

20 years agoMostly done:
Bruce Momjian [Thu, 12 Feb 2004 18:05:51 +0000 (18:05 +0000)]
Mostly done:

< * Allow better handling of numeric constants, type conversion [typeconv]

20 years agoFile not needed:
Bruce Momjian [Thu, 12 Feb 2004 18:01:20 +0000 (18:01 +0000)]
File not needed:

< * Add replication of distributed databases [replication]
> * Add replication of distributed databases

20 years agoRemove:
Bruce Momjian [Thu, 12 Feb 2004 17:59:50 +0000 (17:59 +0000)]
Remove:

<  o http://gborg.postgresql.org/project/pgreplication/projdisplay.php

20 years agoMerge files:
Bruce Momjian [Thu, 12 Feb 2004 17:51:03 +0000 (17:51 +0000)]
Merge files:

< * Allow persistent backends [persistent]
> * Allow persistent backends [pool]
397c397
<   connection pooling
>   connection pooling [pool]

20 years agoNot needed:
Bruce Momjian [Thu, 12 Feb 2004 17:38:50 +0000 (17:38 +0000)]
Not needed:

<   float4, numeric/decimal too [optimizer]
>   float4, numeric/decimal too
422c422
< * Missing optimizer selectivities for date, r-tree, etc. [optimizer]
> * Missing optimizer selectivities for date, r-tree, etc

20 years agoNot needed:
Bruce Momjian [Thu, 12 Feb 2004 17:32:38 +0000 (17:32 +0000)]
Not needed:

< * Delay fsync() when other backends are about to commit too [fsync]
> * Delay fsync() when other backends are about to commit too

20 years agoNot needed:
Bruce Momjian [Thu, 12 Feb 2004 17:31:09 +0000 (17:31 +0000)]
Not needed:

< * Add MATCH PARTIAL referential integrity [foreign]
> * Add MATCH PARTIAL referential integrity

20 years agoRemove crossdb content.
Bruce Momjian [Thu, 12 Feb 2004 17:23:30 +0000 (17:23 +0000)]
Remove crossdb content.

20 years agoAdd, dblink doesn't do this:
Bruce Momjian [Thu, 12 Feb 2004 17:22:39 +0000 (17:22 +0000)]
Add, dblink doesn't do this:

> * Allow cross-db queries with transaction sematics

20 years agoDone, mostly by dblink, I think:
Bruce Momjian [Thu, 12 Feb 2004 17:21:41 +0000 (17:21 +0000)]
Done, mostly by dblink, I think:

< * Allow queries across multiple databases [crossdb]

20 years agoFix typo:
Bruce Momjian [Thu, 12 Feb 2004 16:38:04 +0000 (16:38 +0000)]
Fix typo:

On Mon, 2004-01-26 at 21:28, Peter Eisentraut wrote:
> Christophe Combelles wrote:
> > At the bottom of this doc file :
> > file:///usr/share/doc/postgresql-doc/html/tutorial-createdb.html
> > "and it also happens that that user always has permission"
> >                       ---- x2
> The first "that" serves as a conjuction, the second one serves as an
> article.  Looks correct to me.

A better workaround for the sentence would be something like:

        "and it also happens that the user always has permission"

Looks easier to read, I think.

Enver ALTIN (a.k.a. skyblue)

20 years agoAdd:
Bruce Momjian [Thu, 12 Feb 2004 16:05:15 +0000 (16:05 +0000)]
Add:
<
> * Allow substring/replace() to get/set bit values

20 years agoFixed bug where FlushRelationBuffers() did call StrategyInvalidateBuffer()
Jan Wieck [Thu, 12 Feb 2004 15:06:56 +0000 (15:06 +0000)]
Fixed bug where FlushRelationBuffers() did call StrategyInvalidateBuffer()
for already empty buffers because their buffer tag was not cleard out
when the buffers have been invalidated before.

Also removed the misnamed BM_FREE bufhdr flag and replaced the checks,
which effectively ask if the buffer is unpinned, with checks against the
refcount field.

Jan

20 years agoRemove URL for specific pljava implementation:
Bruce Momjian [Thu, 12 Feb 2004 14:41:13 +0000 (14:41 +0000)]
Remove URL for specific pljava implementation:

<  o Allow Java server-side programming, http://pljava.sourceforge.net
<    [java]
>  o Allow Java server-side programming [java]

20 years agoCheck only live tuples for OID validity, to avoid issues after ALTER
Tom Lane [Thu, 12 Feb 2004 05:39:55 +0000 (05:39 +0000)]
Check only live tuples for OID validity, to avoid issues after ALTER
TABLE.  Per recent discussion.

20 years agoAdded hints about the reason, why the command string in
Jan Wieck [Thu, 12 Feb 2004 01:44:22 +0000 (01:44 +0000)]
Added hints about the reason, why the command string in
the view pg_stat_activity is missing, as per Bruces suggestion.

Jan

20 years agoCommit the reasonably uncontroversial parts of J.R. Nield's PITR patch, to
Tom Lane [Wed, 11 Feb 2004 22:55:26 +0000 (22:55 +0000)]
Commit the reasonably uncontroversial parts of J.R. Nield's PITR patch, to
wit: Add a header record to each WAL segment file so that it can be reliably
identified.  Avoid splitting WAL records across segment files (this is not
strictly necessary, but makes it simpler to incorporate the header records).
Make WAL entries for file creation, deletion, and truncation (as foreseen but
never implemented by Vadim).  Also, add support for making XLOG_SEG_SIZE
configurable at compile time, similarly to BLCKSZ.  Fix a couple bugs I
introduced in WAL replay during recent smgr API changes.  initdb is forced
due to changes in pg_control contents.

20 years agoRepair some problems in bgwriter start/stop logic. In particular, don't
Tom Lane [Wed, 11 Feb 2004 22:25:02 +0000 (22:25 +0000)]
Repair some problems in bgwriter start/stop logic.  In particular, don't
allow the bgwriter to start before the startup subprocess has finished
... it tends to crash otherwise.  (The same problem may have existed for
the checkpointer, I'm not entirely sure.)  Remove some code that was
redundant because the bgwriter is handled as a member of the backend list.

20 years agoAdd:
Bruce Momjian [Wed, 11 Feb 2004 22:04:35 +0000 (22:04 +0000)]
Add:

>  o Disallow dropping of an inherited constraint

20 years agoCheck and set thread-safe functions separately, rather than as a single
Bruce Momjian [Wed, 11 Feb 2004 21:44:06 +0000 (21:44 +0000)]
Check and set thread-safe functions separately, rather than as a single
variable.

Remove thread locking for non-thread-safe functions, instead throw a
compile error.

Platforms will have to re-run tools/thread to record their thread
safety.

20 years agoProperly set NEED_REENTRANT_FUNCS for threaded libpq/ecpg.
Bruce Momjian [Wed, 11 Feb 2004 17:29:01 +0000 (17:29 +0000)]
Properly set NEED_REENTRANT_FUNCS for threaded libpq/ecpg.

Without this patch, no thread locking or *_r functions were being used.

20 years agoDoes not apply anymore:
Bruce Momjian [Wed, 11 Feb 2004 17:04:04 +0000 (17:04 +0000)]
Does not apply anymore:

< * Make blind writes go through the file descriptor cache

20 years agoNo need to link libpq into these programs ...
Tom Lane [Tue, 10 Feb 2004 23:24:13 +0000 (23:24 +0000)]
No need to link libpq into these programs ...

20 years agoSGML markup improvements.
Neil Conway [Tue, 10 Feb 2004 20:51:39 +0000 (20:51 +0000)]
SGML markup improvements.

20 years agoAdd configure support for determining UINT64_FORMAT, the appropriate
Tom Lane [Tue, 10 Feb 2004 19:55:45 +0000 (19:55 +0000)]
Add configure support for determining UINT64_FORMAT, the appropriate
snprintf format for uint64 items.

20 years agoMore clearly describe why PQinSend returns false for non-threaded libpq.
Bruce Momjian [Tue, 10 Feb 2004 15:21:24 +0000 (15:21 +0000)]
More clearly describe why PQinSend returns false for non-threaded libpq.

20 years agoAdd URL for most current version.
Bruce Momjian [Tue, 10 Feb 2004 15:16:36 +0000 (15:16 +0000)]
Add URL for most current version.

20 years agoRepair missing inclusions of -lintl for shared libraries.
Tom Lane [Tue, 10 Feb 2004 07:26:25 +0000 (07:26 +0000)]
Repair missing inclusions of -lintl for shared libraries.

20 years agoLooks like we need <unistd.h> for select() on Darwin.
Tom Lane [Tue, 10 Feb 2004 04:23:03 +0000 (04:23 +0000)]
Looks like we need <unistd.h> for select() on Darwin.

20 years agoCentralize implementation of delay code by creating a pg_usleep()
Tom Lane [Tue, 10 Feb 2004 03:42:45 +0000 (03:42 +0000)]
Centralize implementation of delay code by creating a pg_usleep()
subroutine in src/port/pgsleep.c.  Remove platform dependencies from
miscadmin.h and put them in port.h where they belong.  Extend recent
vacuum cost-based-delay patch to apply to VACUUM FULL, ANALYZE, and
non-btree index vacuuming.

By the way, where is the documentation for the cost-based-delay patch?

20 years agoRestructure smgr API as per recent proposal. smgr no longer depends on
Tom Lane [Tue, 10 Feb 2004 01:55:27 +0000 (01:55 +0000)]
Restructure smgr API as per recent proposal.  smgr no longer depends on
the relcache, and so the notion of 'blind write' is gone.  This should
improve efficiency in bgwriter and background checkpoint processes.
Internal restructuring in md.c to remove the not-very-useful array of
MdfdVec objects --- might as well just use pointers.
Also remove the long-dead 'persistent main memory' storage manager (mm.c),
since it seems quite unlikely to ever get resurrected.

20 years agoWin32 signals cleanup. Patch by Magnus Hagander, with input from Claudio
Neil Conway [Sun, 8 Feb 2004 22:28:57 +0000 (22:28 +0000)]
Win32 signals cleanup. Patch by Magnus Hagander, with input from Claudio
Natoli and Bruce Momjian (and some cosmetic fixes from Neil Conway).
Changes:

    - remove duplicate signal definitions from pqsignal.h

    - replace pqkill() with kill() and redefine kill() in Win32

    - use ereport() in place of fprintf() in some error handling in
      pqsignal.c

    - export pg_queue_signal() and make use of it where necessary

    - add a console control handler for Ctrl-C and similar handling
      on Win32

    - do WaitForSingleObjectEx() in CHECK_FOR_INTERRUPTS() on Win32;
      query cancelling should now work on Win32

    - various other fixes and cleanups

20 years agoAdd mention of the developer's FAQ.
Bruce Momjian [Sun, 8 Feb 2004 03:16:31 +0000 (03:16 +0000)]
Add mention of the developer's FAQ.

20 years agoAdd mention of PostgreSQL as a community project.
Bruce Momjian [Sun, 8 Feb 2004 03:09:12 +0000 (03:09 +0000)]
Add mention of PostgreSQL as a community project.

20 years agoAdd PITR web page:
Bruce Momjian [Sun, 8 Feb 2004 01:17:09 +0000 (01:17 +0000)]
Add PITR web page:

< * Point-in-time data recovery using backup and write-ahead log
< * Create native Win32 port, http://momjian.postgresql.org/main/writings/pgsql/win32.html
> * Point-in-time data recovery using backup and write-ahead log,
>   http://momjian.postgresql.org/main/writings/pgsql/project/pitr.html
> * Create native Win32 port, http://momjian.postgresql.org/main/writings/pgsql/project/win32.html

20 years agoAdd missing dependency, per Wade Klaver.
Tom Lane [Sat, 7 Feb 2004 07:20:12 +0000 (07:20 +0000)]
Add missing dependency, per Wade Klaver.

20 years agoCost based vacuum delay feature.
Jan Wieck [Fri, 6 Feb 2004 19:36:18 +0000 (19:36 +0000)]
Cost based vacuum delay feature.

Jan

20 years agoDocumentation for generate_series() functions committed a few days ago.
Joe Conway [Thu, 5 Feb 2004 22:54:36 +0000 (22:54 +0000)]
Documentation for generate_series() functions committed a few days ago.

20 years agoBacking out the background writer sync() option.
Jan Wieck [Wed, 4 Feb 2004 01:24:53 +0000 (01:24 +0000)]
Backing out the background writer sync() option.

Jan

20 years agoUse memmove() rather than memcpy() in set_var_from_var(). If this function
Neil Conway [Wed, 4 Feb 2004 01:11:47 +0000 (01:11 +0000)]
Use memmove() rather than memcpy() in set_var_from_var(). If this function
is asked to assign a variable to itself, it will result in doing a
memcpy() on an entirely-overlapping memory range, which results in
undefined behavior according to ANSI C. That said, it is unlikely to
actually do anything bad on any sane libc, but this keeps valgrind quiet.

20 years agopwd
Tom Lane [Tue, 3 Feb 2004 17:52:55 +0000 (17:52 +0000)]
pwd

20 years agoRename SortMem and VacuumMem to work_mem and maintenance_work_mem.
Tom Lane [Tue, 3 Feb 2004 17:34:04 +0000 (17:34 +0000)]
Rename SortMem and VacuumMem to work_mem and maintenance_work_mem.
Make btree index creation and initial validation of foreign-key constraints
use maintenance_work_mem rather than work_mem as their memory limit.
Add some code to guc.c to allow these variables to be referenced by their
old names in SHOW and SET commands, for backwards compatibility.

20 years agoAdd:
Bruce Momjian [Tue, 3 Feb 2004 16:53:56 +0000 (16:53 +0000)]
Add:

> * Make pg_restore continue after errors, so it acts more like pg_dump scripts

20 years agoAdd function (actually an int4 and an int8 version) that generates
Joe Conway [Tue, 3 Feb 2004 08:29:57 +0000 (08:29 +0000)]
Add function (actually an int4 and an int8 version) that generates
a series of numbers, optionally using an explicit step size other
than the default value (one). Use function in the information_schema
to replace hard-wired knowledge of INDEX_MAX_KEYS. initdb forced due
to pg_proc change. Documentation update still needed -- will be
committed separately.

20 years agoWin32 adjustments for dirmod and configure/configure.in.
Bruce Momjian [Mon, 2 Feb 2004 22:20:33 +0000 (22:20 +0000)]
Win32 adjustments for dirmod and configure/configure.in.

20 years agoautoconf run.
Tom Lane [Mon, 2 Feb 2004 18:35:45 +0000 (18:35 +0000)]
autoconf run.

20 years agoSet only LC_ALL for sort in tags creation.
Bruce Momjian [Mon, 2 Feb 2004 17:29:32 +0000 (17:29 +0000)]
Set only LC_ALL for sort in tags creation.

20 years ago> src/backend/commands/user.c file has some parse error at repalloc(),
Bruce Momjian [Mon, 2 Feb 2004 17:21:08 +0000 (17:21 +0000)]
> src/backend/commands/user.c file has some parse error at repalloc(),
palloc()$

Fixed.  Thanks.

> src/backend/postmaster/pgstat.c miss
> #include "tcop/tcopprot.h" line.

Fixed.

> src/utils/dllinit.c wrong include header line at MinGW.
> #include <cygwin/version.h> must be not included

Fixed.

> by the way,
> I can't compile eccp because I used lower version bison.

> and bin/pg_resetxlog too. in this case I can't find what's wrong.

Fixed.

20 years agoFix a read of uninitialized memory in next_token() of hba.c, spotted via
Neil Conway [Mon, 2 Feb 2004 16:58:30 +0000 (16:58 +0000)]
Fix a read of uninitialized memory in next_token() of hba.c, spotted via
valgrind: a buffer passed to strncmp() had to be NUL-terminated. Original
report and patch from Dennis Bjorkland, some cleanup by Andrew Dunstan,
and finally some editorializing from Neil Conway.

20 years agoAdjustments for Win32-specific rename code, and add include file.
Bruce Momjian [Mon, 2 Feb 2004 16:37:46 +0000 (16:37 +0000)]
Adjustments for Win32-specific rename code, and add include file.

20 years agoMove win32 changes from configure to configure.in, per Tom, autoconf
Bruce Momjian [Mon, 2 Feb 2004 16:00:49 +0000 (16:00 +0000)]
Move win32 changes from configure to configure.in, per Tom, autoconf
run.

20 years agoDo not let external specification of CFLAGS stop us from adding
Tom Lane [Mon, 2 Feb 2004 04:07:18 +0000 (04:07 +0000)]
Do not let external specification of CFLAGS stop us from adding
-fno-strict-aliasing.

20 years agoAvoid generating invalid character encoding sequences in make_greater_string.
Tom Lane [Mon, 2 Feb 2004 03:07:08 +0000 (03:07 +0000)]
Avoid generating invalid character encoding sequences in make_greater_string.
Not sure how this mistake evaded detection for so long.

20 years agoUse Tcl_PutEnv() in place of putenv() in libpgtcl, as the latter can
Neil Conway [Mon, 2 Feb 2004 00:35:08 +0000 (00:35 +0000)]
Use Tcl_PutEnv() in place of putenv() in libpgtcl, as the latter can
apparently corrupt the Tcl runtime. Per suggestion from Michael
Brusser <michael@synchronicity.com>

20 years agoAdjust rename on Win32 to only link to temp name while holding lock,
Bruce Momjian [Mon, 2 Feb 2004 00:17:23 +0000 (00:17 +0000)]
Adjust rename on Win32 to only link to temp name while holding lock,
then release locks and loop over renaming to active file name.

20 years agoBriefly,
Bruce Momjian [Mon, 2 Feb 2004 00:11:31 +0000 (00:11 +0000)]
Briefly,
 * configure + Makefile changes
 * shared memory attaching in EXEC_BACKEND case (+ minor fix for apparent
cygwin bug under cygwin/EXEC_BACKEND case only)
 * PATH env var separator differences
 * missing win32 rand functions added
 * placeholder replacements for sync etc under port.h

To those who are really interested, and there are a few of you: the attached
patch + file will allow the source base to be compiled (and, for some
definition, "run") under MingW, with the following caveats (I wanted to
first properly fix all but the last of these, but y'all won't quit asking
for a patch :-):

        * child death: SIGCHLD not yet sent, so as a minimum, you'll need to
put in some sort of delay after StartupDatabase, and handle setting
StartupPID to 0 etc (ie. the stuff the reaper() signal function is supposed
to do)

        * dirmod.c: comment out the elog calls

        * dfmgr.c: some hackage required to substitute_libpath_macro

        * slru/xact.c: comment out the errno checking after the readdir
(fixed by next version of MingW)

Again, this is only if you *really* want to see postgres compile and start,
and is a nice leg-up for working on the other Win32 TODO list items. Just
don't expect too much else from it at this point...

Claudio Natoli

20 years agoSet locale to C before doing sort in make_ctags.
Bruce Momjian [Sun, 1 Feb 2004 23:11:33 +0000 (23:11 +0000)]
Set locale to C before doing sort in make_ctags.

20 years agoUpdate char_length() example for new semantics.
Tom Lane [Sun, 1 Feb 2004 06:55:07 +0000 (06:55 +0000)]
Update char_length() example for new semantics.

20 years agoMake length() disregard trailing spaces in char(n) values, per discussion
Tom Lane [Sun, 1 Feb 2004 06:27:48 +0000 (06:27 +0000)]
Make length() disregard trailing spaces in char(n) values, per discussion
some time ago and recent patch from Gavin Sherry.  Update documentation
to point out that trailing spaces are insignificant in char(n).

20 years agoFix a probably-harmless read of uninitialized memory in mkdir_p(), to
Neil Conway [Sat, 31 Jan 2004 22:10:00 +0000 (22:10 +0000)]
Fix a probably-harmless read of uninitialized memory in mkdir_p(), to
silence a valgrind warning.

20 years agoRemove a superfluous semi-colon.
Neil Conway [Sat, 31 Jan 2004 21:18:00 +0000 (21:18 +0000)]
Remove a superfluous semi-colon.

20 years agoMicro-opt: replace calls like
Neil Conway [Sat, 31 Jan 2004 05:09:41 +0000 (05:09 +0000)]
Micro-opt: replace calls like
    appendStringInfo(buf, "%s", str);
with
    appendStringInfoString(buf, str);
as the latter form is slightly faster.

20 years agoFix text_position to not scan past end of source string in multibyte
Tom Lane [Sat, 31 Jan 2004 00:45:21 +0000 (00:45 +0000)]
Fix text_position to not scan past end of source string in multibyte
case, per report from Korea PostgreSQL Users' Group.  Also do some
cosmetic cleanup in nearby code.

20 years agoFix debug elog message to agree with name of its routine.
Tom Lane [Fri, 30 Jan 2004 22:44:21 +0000 (22:44 +0000)]
Fix debug elog message to agree with name of its routine.

20 years agoRemove sleep() and use single PG_SLEEP call for Win32 signal handling
Bruce Momjian [Fri, 30 Jan 2004 15:57:04 +0000 (15:57 +0000)]
Remove sleep() and use single PG_SLEEP call for Win32 signal handling
and consistency.

Change PG_USLEEP to use SleepEx() for signal interuptability.

20 years agoAdd:
Bruce Momjian [Fri, 30 Jan 2004 11:11:07 +0000 (11:11 +0000)]
Add:
<
> * Allow libpq to return information about prepared queries

20 years agoFix (debatable) spelling mistake in a comment: 'concatenate' is the usual
Neil Conway [Thu, 29 Jan 2004 12:34:59 +0000 (12:34 +0000)]
Fix (debatable) spelling mistake in a comment: 'concatenate' is the usual
term, not 'catenate'.

20 years agoMake USING and WITH optional to bring the syntax of \copy into exact
Tom Lane [Wed, 28 Jan 2004 22:14:04 +0000 (22:14 +0000)]
Make USING and WITH optional to bring the syntax of \copy into exact
agreement with what the backend grammar actually accepts (which is a
bit looser than what its documentation claims).  Per report from Bill
Moran, though I did not use his patch since it removed all the
undocumented flexibility that the code historically had and the backend
still has.

20 years agoReview uses of IsUnderPostmaster, change some tests to look at
Tom Lane [Wed, 28 Jan 2004 21:02:40 +0000 (21:02 +0000)]
Review uses of IsUnderPostmaster, change some tests to look at
whereToSendOutput instead because they are really inquiring about
the correct client communication protocol.  Update some comments.
This is pointing towards supporting regular FE/BE client protocol
in a standalone backend, per discussion a month or so back.

20 years agoFix typo.
Tom Lane [Wed, 28 Jan 2004 20:43:03 +0000 (20:43 +0000)]
Fix typo.

20 years agoRemoved some debugging output.
Michael Meskes [Wed, 28 Jan 2004 09:54:23 +0000 (09:54 +0000)]
Removed some debugging output.

20 years ago- Issue a warning if a cursor is declared but not opened.
Michael Meskes [Wed, 28 Jan 2004 09:52:14 +0000 (09:52 +0000)]
- Issue a warning if a cursor is declared but not opened.
- Fixed prototype for ECPGprepared_statement to not moan about "const char"
- Fixed parsing of nested structures.
- Added option to parse header files.

20 years agoFix oversight in check_ungrouped_columns optimization that avoids
Tom Lane [Wed, 28 Jan 2004 07:46:44 +0000 (07:46 +0000)]
Fix oversight in check_ungrouped_columns optimization that avoids
unnecessary checks for complex grouping expressions: we cannot check
whether the expressions are simple Vars until after we apply
flatten_join_alias_vars, because in the case of FULL JOIN that routine
can introduce non-Var expressions.  Per example from Joel Knight.

20 years agosimplify_function() mustn't try to evaluate functions that return
Tom Lane [Wed, 28 Jan 2004 00:05:04 +0000 (00:05 +0000)]
simplify_function() mustn't try to evaluate functions that return
composite types, because TupleTableSlots aren't Datums and can't be
stored in Const nodes.  We can remove this restriction if we ever
adopt a cleaner runtime representation for whole-tuple results, but
at the moment it's broken.  Per example from Thomas Hallgren.

20 years agoImprove the documentation of the 'join_collapse_limit' GUC var. Thanks to
Neil Conway [Tue, 27 Jan 2004 16:51:43 +0000 (16:51 +0000)]
Improve the documentation of the 'join_collapse_limit' GUC var. Thanks to
Tom Lane for some editorial suggestions.

20 years agoRun stats test separately, not as part of a parallel group, to avoid
Tom Lane [Tue, 27 Jan 2004 00:50:33 +0000 (00:50 +0000)]
Run stats test separately, not as part of a parallel group, to avoid
possible failures due to stats collector not updating fast enough under
heavy load.  Per report from Jeremy Yoder.

20 years agoPgindent win32 signal code.
Bruce Momjian [Tue, 27 Jan 2004 00:46:58 +0000 (00:46 +0000)]
Pgindent win32 signal code.

20 years agoHere's the latest win32 signals code, this time in the form of a patch
Bruce Momjian [Tue, 27 Jan 2004 00:45:26 +0000 (00:45 +0000)]
Here's the latest win32 signals code, this time in the form of a patch
against the latest shapshot. It also includes the replacement of kill()
with pqkill() and sigsetmask() with pqsigsetmask().

Passes all tests fine on my linux machine once applied. Still doesn't
link completely on Win32 - there are a few things still required. But
much closer than before.

At Bruce's request, I'm goint to write up a README file about the method
of signals delivery chosen and why the others were rejected (basically a
summary of the mailinglist discussions). I'll finish that up once/if the
patch is accepted.

Magnus Hagander

20 years ago[all] Removed call to getppid in SendPostmasterSignal, replacing with a
Bruce Momjian [Mon, 26 Jan 2004 22:59:54 +0000 (22:59 +0000)]
[all] Removed call to getppid in SendPostmasterSignal, replacing with a
PostmasterPid variable, which gets set (early) in PostmasterMain
getppid would not be the postmaster?

[fork/exec] Implements processCancelRequest by keeping an array of

pid/cancel_key structs in shared mem

[fork/exec] Moves AttachSharedMemoryAndSemaphores call for backends into
SubPostmasterMain

[win32] Implements reaper/waitpid by keeping an arrays of children
pids,handles in postmaster local mem
      - this item is largely untested, for reasons which should be
obvious, but appears sound

[win32/all] Added extern for pgpipe in Win32 case, and changed the second
pipe call (which seems to have been missed earlier) to pgpipe

[win32] #define'd ftruncate to chsize in the Win32 case

[win32] PG_USLEEP for Win32 has a misplaced paren. Fixed.

[win32] DLLIMPORT handling for MingW case

Claudio Natoli

20 years agoBack out win32 patch so we can apply it separately.
Bruce Momjian [Mon, 26 Jan 2004 22:54:58 +0000 (22:54 +0000)]
Back out win32 patch so we can apply it separately.

20 years agoAttached is a patch that fixes some trivial typos and alignment. Please
Bruce Momjian [Mon, 26 Jan 2004 22:51:56 +0000 (22:51 +0000)]
Attached is a patch that fixes some trivial typos and alignment.  Please
apply.

Alvaro Herrera

20 years agoAdd Name:
Bruce Momjian [Mon, 26 Jan 2004 22:38:42 +0000 (22:38 +0000)]
Add Name:

> * -Add checks for fclose() failure (Tom)

20 years agoDone:
Bruce Momjian [Mon, 26 Jan 2004 22:38:10 +0000 (22:38 +0000)]
Done:

> * -Add checks for fclose() failure (Tom)