]> granicus.if.org Git - postgresql/log
postgresql
15 years agoRe-enable the old code in xlog.c that tried to use posix_fadvise(), so that
Tom Lane [Sun, 11 Jan 2009 18:02:17 +0000 (18:02 +0000)]
Re-enable the old code in xlog.c that tried to use posix_fadvise(), so that
we can get some buildfarm feedback about whether that function is still
problematic.  (Note that the planned async-preread patch will not really
prove anything one way or the other in buildfarm testing, since it will
be inactive with default GUC settings.)

15 years agoMake tests pass with or without locale.
Peter Eisentraut [Sun, 11 Jan 2009 09:41:45 +0000 (09:41 +0000)]
Make tests pass with or without locale.

15 years agoRevise the TIDBitmap API to support multiple concurrent iterations over a
Tom Lane [Sat, 10 Jan 2009 21:08:36 +0000 (21:08 +0000)]
Revise the TIDBitmap API to support multiple concurrent iterations over a
bitmap.  This is extracted from Greg Stark's posix_fadvise patch; it seems
worth committing separately, since it's potentially useful independently of
posix_fadvise.

15 years agoModify libpq environment variable documentation to point to the relevant
Bruce Momjian [Sat, 10 Jan 2009 20:14:30 +0000 (20:14 +0000)]
Modify libpq environment variable documentation to point to the relevant
connection options documentation section, per idea from Magnus.

15 years agoUpdate link guidelines.
Bruce Momjian [Sat, 10 Jan 2009 16:58:39 +0000 (16:58 +0000)]
Update link guidelines.

15 years agoAdd guidelines section.
Bruce Momjian [Sat, 10 Jan 2009 16:03:15 +0000 (16:03 +0000)]
Add guidelines section.

15 years agoAdd file to explain SGML linking options, for use by SGML document
Bruce Momjian [Sat, 10 Jan 2009 04:40:08 +0000 (04:40 +0000)]
Add file to explain SGML linking options, for use by SGML document
writers.

15 years agoA further attempt at clarifying the \distv business.
Tom Lane [Fri, 9 Jan 2009 19:27:14 +0000 (19:27 +0000)]
A further attempt at clarifying the \distv business.

15 years agoFix libpq so that it reports PGRES_EMPTY_QUERY not PGRES_COMMAND_OK when an
Tom Lane [Fri, 9 Jan 2009 18:50:03 +0000 (18:50 +0000)]
Fix libpq so that it reports PGRES_EMPTY_QUERY not PGRES_COMMAND_OK when an
empty query string is passed to PQexecParams and related functions.  Its
handling of the NoData response to Describe messages was subtly incorrect.
Per my report of yesterday.

Although I consider this a bug, it's a behavioral change that might affect
applications, so not back-patched.

In passing fix a second issue in the same code: it didn't react well to an
out-of-memory failure while trying to make the PGresult object.

15 years agoArrange for function default arguments to be processed properly in expressions
Tom Lane [Fri, 9 Jan 2009 15:46:11 +0000 (15:46 +0000)]
Arrange for function default arguments to be processed properly in expressions
that are set up for execution with ExecPrepareExpr rather than going through
the full planner process.  By introducing an explicit notion of "expression
planning", this patch also lays a bit of groundwork for maybe someday
allowing sub-selects in standalone expressions.

15 years agoRemove tabs from SGML docs.
Bruce Momjian [Fri, 9 Jan 2009 15:02:22 +0000 (15:02 +0000)]
Remove tabs from SGML docs.

15 years agoRemove fairly useless mixed-case identifier test that causes locale
Peter Eisentraut [Fri, 9 Jan 2009 14:50:00 +0000 (14:50 +0000)]
Remove fairly useless mixed-case identifier test that causes locale
dependencies.

15 years agoCode review of strftime patch, per comments from Tom:
Magnus Hagander [Fri, 9 Jan 2009 14:07:00 +0000 (14:07 +0000)]
Code review of strftime patch, per comments from Tom:
* Use correct buffer size MAX_L10N_DATA
* Use strlcpy instead of StrNCpy

15 years agoChange chapter titles thus:
Peter Eisentraut [Fri, 9 Jan 2009 13:37:18 +0000 (13:37 +0000)]
Change chapter titles thus:

III. Server Administration
15. Installation from Source Code
16. Installation from Source Code on Windows
17. Server Setup and Operation

to give users of binary installations a better idea where to start reading.

suggested by Nikolay Samokhvalov

15 years agoFix strftime usage on Win32 when trying to fetch the locale-aware
Magnus Hagander [Fri, 9 Jan 2009 13:03:55 +0000 (13:03 +0000)]
Fix strftime usage on Win32 when trying to fetch the locale-aware
parts of a time string so it properly handles different encodings.

Original patch by Hiroshi Saito, heavily reworked by me and
ITAGAKI Takahiro.

15 years agoMore portable use of "find".
Peter Eisentraut [Fri, 9 Jan 2009 12:37:37 +0000 (12:37 +0000)]
More portable use of "find".

15 years agoRewrite update-po target, so that it works less like a shell script and more
Peter Eisentraut [Fri, 9 Jan 2009 10:54:08 +0000 (10:54 +0000)]
Rewrite update-po target, so that it works less like a shell script and more
like a makefile with real dependencies.

Instead of overwriting the old po file, write the new one to .po.new.  This is
less annoying and integrates better with the NLS web site.

Also, we can now merge languages that don't have a po file yet, by merging
against all other po files of that language, to pick up recurring translations
automatically.  This previously only worked when a po file already existed.

15 years agoMake krb_realm and krb_server_hostname be pg_hba options only, and remove
Magnus Hagander [Fri, 9 Jan 2009 10:13:19 +0000 (10:13 +0000)]
Make krb_realm and krb_server_hostname be pg_hba options only, and remove
their GUCs.

In passing, noted that the pg_hba options for krb5 authentication weren't
listed at all - so add this.

15 years agoDocument values for pg_constraint confupdtype, confdeltype and confmatchtype columns.
Andrew Dunstan [Fri, 9 Jan 2009 01:53:10 +0000 (01:53 +0000)]
Document values for pg_constraint confupdtype, confdeltype and confmatchtype columns.

15 years agoUpdate release notes for 8.3.5, 8.2.11, and 8.1.15 to mention the need
Bruce Momjian [Fri, 9 Jan 2009 01:47:02 +0000 (01:47 +0000)]
Update release notes for  8.3.5, 8.2.11, and 8.1.15 to mention the need
to reindex GiST indexes:

If you were running a previous 8.X.X release, REINDEX all GiST
indexes after the upgrade.

15 years agoFix memory leak for file name if expect file name contains a dot, per
Bruce Momjian [Thu, 8 Jan 2009 20:09:06 +0000 (20:09 +0000)]
Fix memory leak for file name if expect file name contains a dot, per
report from dvice_null@yahoo.com.

15 years agoA couple further reloptions improvements, per KaiGai Kohei: add a validation
Alvaro Herrera [Thu, 8 Jan 2009 19:34:41 +0000 (19:34 +0000)]
A couple further reloptions improvements, per KaiGai Kohei: add a validation
function to the string type and add a couple of macros for string handling.

In passing, fix an off-by-one bug of mine.

15 years agoDocument that txid_visible_in_snapshot() cannot be used with
Bruce Momjian [Thu, 8 Jan 2009 14:46:50 +0000 (14:46 +0000)]
Document that txid_visible_in_snapshot() cannot be used with
subtransaction ids.

15 years agoDefend against null input in analyze_requires_snapshot(), per report
Tom Lane [Thu, 8 Jan 2009 13:42:33 +0000 (13:42 +0000)]
Defend against null input in analyze_requires_snapshot(), per report
from Rushabh Lathia.

15 years agoAdd note that not all SQL commands support ONLY in the same way.
Peter Eisentraut [Thu, 8 Jan 2009 12:47:58 +0000 (12:47 +0000)]
Add note that not all SQL commands support ONLY in the same way.

15 years agoDocument current_query() as being the _client_ query.
Bruce Momjian [Thu, 8 Jan 2009 00:44:18 +0000 (00:44 +0000)]
Document current_query() as being the _client_ query.

15 years agoRevert current_query() change to use debug_query_string again; add comment.
Bruce Momjian [Thu, 8 Jan 2009 00:13:22 +0000 (00:13 +0000)]
Revert current_query() change to use debug_query_string  again;  add comment.

15 years agoAdd comment about why BETWEEN uses operator strings and not opclasses,
Bruce Momjian [Wed, 7 Jan 2009 22:54:45 +0000 (22:54 +0000)]
Add comment about why BETWEEN uses operator strings and not opclasses,
with URL pointing to email discussion.

15 years agoCreate a third option named "partition" for constraint_exclusion, and make it
Tom Lane [Wed, 7 Jan 2009 22:40:49 +0000 (22:40 +0000)]
Create a third option named "partition" for constraint_exclusion, and make it
the default.  This setting enables constraint exclusion checks only for
appendrel members (ie, inheritance children and UNION ALL arms), which are
the cases in which constraint exclusion is most likely to be useful.  Avoiding
the overhead for simple queries that are unlikely to benefit should bring
the cost down to the point where this is a reasonable default setting.
Per today's discussion.

15 years agoHave current_query() use ActivePortal->sourceText rather than
Bruce Momjian [Wed, 7 Jan 2009 21:48:15 +0000 (21:48 +0000)]
Have current_query() use ActivePortal->sourceText rather than
debug_query_string;  this allows current_query() to be more accurate;
docs updated;  per idea from Tom

15 years agoInsert conditional SPI_push/SPI_pop calls into InputFunctionCall,
Tom Lane [Wed, 7 Jan 2009 20:38:56 +0000 (20:38 +0000)]
Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,
OutputFunctionCall, and friends.  This allows SPI-using functions to invoke
datatype I/O without concern for the possibility that a SPI-using function
will be called (which could be either the I/O function itself, or a function
used in a domain check constraint).  It's a tad ugly, but not nearly as ugly
as what'd be needed to make this work via retail insertion of push/pop
operations in all the PLs.

This reverts my patch of 2007-01-30 that inserted some retail SPI_push/pop
calls into plpgsql; that approach only fixed plpgsql, and not any other PLs.
But the other PLs have the issue too, as illustrated by a recent gripe from
Christian Schröder.

Back-patch to 8.2, which is as far back as this solution will work.  It's
also as far back as we need to worry about the domain-constraint case, since
earlier versions did not attempt to check domain constraints within datatype
input.  I'm not aware of any old I/O functions that use SPI themselves, so
this should be sufficient for a back-patch.

15 years agoAdd comment that it is difficult to access the more accurate
Bruce Momjian [Wed, 7 Jan 2009 19:51:21 +0000 (19:51 +0000)]
Add comment that it is difficult to access the more accurate
'query_string' from current_query().

15 years agoUpdate comment associated with 'debug_query_string'.
Bruce Momjian [Wed, 7 Jan 2009 19:35:43 +0000 (19:35 +0000)]
Update comment associated with 'debug_query_string'.

15 years agodefine HAVE_FSEEKO for MSVC
Andrew Dunstan [Wed, 7 Jan 2009 13:51:04 +0000 (13:51 +0000)]
define HAVE_FSEEKO for MSVC

15 years agoFix executor/spi.h to follow our usual conventions for include files, ie,
Tom Lane [Wed, 7 Jan 2009 13:44:37 +0000 (13:44 +0000)]
Fix executor/spi.h to follow our usual conventions for include files, ie,
not include postgres.h nor anything else it doesn't directly need.  Add
#includes to calling files as needed to compensate.  Per my proposal of
yesterday.

This should be noted as a source code change in the 8.4 release notes,
since it's likely to require changes in add-on modules.

15 years agoAdd hba parameter include_realm to krb5, gss and sspi authentication, used
Magnus Hagander [Wed, 7 Jan 2009 13:09:21 +0000 (13:09 +0000)]
Add hba parameter include_realm to krb5, gss and sspi authentication, used
to pass the full username@realm string to the authentication instead of
just the username. This makes it possible to use pg_ident.conf to authenticate
users from multiple realms as different database users.

15 years agoAllow krb_realm (krb5, gssapi and sspi) and krb_server_hostname (krb5 only)
Magnus Hagander [Wed, 7 Jan 2009 12:38:11 +0000 (12:38 +0000)]
Allow krb_realm (krb5, gssapi and sspi) and krb_server_hostname (krb5 only)
authentication options to be set in pg_hba.conf on a per-line basis, to
override the defaults set in postgresql.conf.

15 years agoAdd appropriate text for SIGHUP parameters instead of just removing it
Magnus Hagander [Wed, 7 Jan 2009 12:21:47 +0000 (12:21 +0000)]
Add appropriate text for SIGHUP parameters instead of just removing it
like previous patch did.

Per note from Tom Lane

15 years agoDon't require pqGetHomeDirectory to succeed if the user has specified
Magnus Hagander [Wed, 7 Jan 2009 12:02:46 +0000 (12:02 +0000)]
Don't require pqGetHomeDirectory to succeed if the user has specified
hardcoded paths for SSL rootcert/crl/clientcert/key.

As noted by Andrew Chernow

15 years agoProduce a full version string for Sun Studio.
Peter Eisentraut [Wed, 7 Jan 2009 10:38:44 +0000 (10:38 +0000)]
Produce a full version string for Sun Studio.
from Zdenek

15 years agoBreak out \distv into four separate lines in the psql documentation, for
Bruce Momjian [Wed, 7 Jan 2009 04:51:34 +0000 (04:51 +0000)]
Break out \distv into four separate lines in the psql documentation, for
clarity.

15 years agoMake the log output of 'vxid' between csvlog and stderr/syslog
Bruce Momjian [Wed, 7 Jan 2009 04:26:46 +0000 (04:26 +0000)]
Make the log output of 'vxid' between csvlog and stderr/syslog
consistent. Currently, in csvlog, vxid of an auxiliary process isn't
displayed. On the other hand, in stderr/syslog, invalid vxid (-1/0) of
that is displayed.

Fujii Masao

15 years agoUpdate MinGW so it handles fseeko() similar to Unix.
Bruce Momjian [Wed, 7 Jan 2009 03:39:33 +0000 (03:39 +0000)]
Update MinGW so it handles fseeko() similar to Unix.

15 years agoRemoveduplicate \dd psql help mention.
Bruce Momjian [Wed, 7 Jan 2009 03:05:26 +0000 (03:05 +0000)]
Removeduplicate \dd psql help mention.

15 years agoAdd spaces around psql \d* columns, per idea from Joshua Drake.
Bruce Momjian [Wed, 7 Jan 2009 00:05:28 +0000 (00:05 +0000)]
Add spaces around psql \d* columns, per idea from Joshua Drake.

15 years agoClarify a confusing comment about MCVs vs histogram entries.
Tom Lane [Tue, 6 Jan 2009 23:46:06 +0000 (23:46 +0000)]
Clarify a confusing comment about MCVs vs histogram entries.
Per Nathan Boley.

15 years agoImprove \z psql \? help display.
Bruce Momjian [Tue, 6 Jan 2009 23:09:56 +0000 (23:09 +0000)]
Improve \z psql \? help display.

15 years agoAdd documentation for new \d*S* patch, and clean up some of the docs.
Bruce Momjian [Tue, 6 Jan 2009 23:01:57 +0000 (23:01 +0000)]
Add documentation for new \d*S* patch, and clean up some of the docs.
Fix \do and trigger display for the patch too.

15 years agoThis makes all the \dX commands (most importantly to most: \df) work
Bruce Momjian [Tue, 6 Jan 2009 21:10:30 +0000 (21:10 +0000)]
This makes all the \dX commands (most importantly to most: \df) work
like \dt does, in that it requires a \dXS to see system items.

Greg Sabino Mullane

15 years agoDocument that Cygwin does not support OpenSSL.
Bruce Momjian [Tue, 6 Jan 2009 19:42:57 +0000 (19:42 +0000)]
Document that Cygwin does not support OpenSSL.

15 years agoMake the MSVC build output "32-bit" at the end of the version string, the
Magnus Hagander [Tue, 6 Jan 2009 18:37:50 +0000 (18:37 +0000)]
Make the MSVC build output "32-bit" at the end of the version string, the
same way the unix build now does.

15 years agoMake pg_dump and pg_dumpall --clean options match the SGML docs, for consistency.
Bruce Momjian [Tue, 6 Jan 2009 18:01:57 +0000 (18:01 +0000)]
Make pg_dump and pg_dumpall --clean options match the SGML docs, for consistency.

15 years agoRemove references to pgsql-ports and pgsql-patches mailing lists from
Tom Lane [Tue, 6 Jan 2009 17:27:06 +0000 (17:27 +0000)]
Remove references to pgsql-ports and pgsql-patches mailing lists from
various documentation, since those lists are now dead/deprecated.
Point to pgsql-bugs and/or pgsql-hackers as appropriate.

15 years agoUpdate pg_restore --help text to match the SGML documentation.
Bruce Momjian [Tue, 6 Jan 2009 17:18:11 +0000 (17:18 +0000)]
Update pg_restore --help text to match the SGML documentation.

15 years agoChange a couple of ill-advised uses of INFO elog level to WARNINGs; in
Tom Lane [Tue, 6 Jan 2009 16:39:52 +0000 (16:39 +0000)]
Change a couple of ill-advised uses of INFO elog level to WARNINGs; in
particular this allows EmitWarningsOnPlaceholders messages to show up in the
postmaster log by default.  Update elog.h comment to make it clearer what INFO
is for, and fix one example in the SGML docs that was misusing it.  Per my
gripe of yesterday.

15 years agoRevert the default toast compression strategy to the former behavior
Tom Lane [Tue, 6 Jan 2009 15:51:38 +0000 (15:51 +0000)]
Revert the default toast compression strategy to the former behavior
where there's no limit on the size of datum we'll try to compress.
Other 8.4 tweaks to the behavior remain in place.  Per discussion.

15 years agoDoesn't seem like a good idea to be doing AC_CHECK_SIZEOF(void *) so much
Tom Lane [Tue, 6 Jan 2009 15:38:44 +0000 (15:38 +0000)]
Doesn't seem like a good idea to be doing AC_CHECK_SIZEOF(void *) so much
earlier than all the other sizeof checks, and it certainly fails to follow
the order suggested at the file head.  Rearrange.

15 years agoFix logic in lazy vacuum to decide if it's worth trying to truncate the heap.
Heikki Linnakangas [Tue, 6 Jan 2009 14:55:37 +0000 (14:55 +0000)]
Fix logic in lazy vacuum to decide if it's worth trying to truncate the heap.
If the table was smaller than REL_TRUNCATE_FRACTION (= 16) pages, we always
tried to acquire AccessExclusiveLock on it even if there was no empty pages
at the end.

Report by Simon Riggs. Back-patch all the way to 7.4.

15 years agoFix string reloption handling, per KaiGai Kohei.
Alvaro Herrera [Tue, 6 Jan 2009 14:47:37 +0000 (14:47 +0000)]
Fix string reloption handling, per KaiGai Kohei.

15 years agoRemove outdated Japanese README files per discussion.
Tatsuo Ishii [Tue, 6 Jan 2009 13:43:31 +0000 (13:43 +0000)]
Remove outdated Japanese README files per discussion.

15 years agoSuppress compiler warning in a different way, per Alvaro.
Bruce Momjian [Tue, 6 Jan 2009 03:15:51 +0000 (03:15 +0000)]
Suppress compiler warning in a different way, per Alvaro.

15 years agoUpdate SELECT version() to show whether it is a 32 or 64-bit backend binary.
Bruce Momjian [Tue, 6 Jan 2009 03:05:23 +0000 (03:05 +0000)]
Update SELECT version() to show whether it is a 32 or 64-bit backend binary.

15 years agoSupress compiler warning.
Bruce Momjian [Tue, 6 Jan 2009 02:44:17 +0000 (02:44 +0000)]
Supress compiler warning.

15 years agoFix new timezone cross-compile rule to avoid a bug in gmake 3.78.1;
Bruce Momjian [Tue, 6 Jan 2009 02:25:29 +0000 (02:25 +0000)]
Fix new timezone cross-compile rule to avoid a bug in gmake 3.78.1;
document change.

15 years agoAdd some comments about why function parameter default expressions are
Tom Lane [Tue, 6 Jan 2009 02:01:27 +0000 (02:01 +0000)]
Add some comments about why function parameter default expressions are
restricted.

15 years agoFix an oversight in the function-default-arguments patch: after adding some
Tom Lane [Tue, 6 Jan 2009 01:23:21 +0000 (01:23 +0000)]
Fix an oversight in the function-default-arguments patch: after adding some
default expressions to a function call, eval_const_expressions must recurse on
those expressions.  Else they don't get simplified, and in particular we fail
to insert additional default arguments if any functions needing defaults are
in there.  Per report from Rushabh Lathia.

15 years agoChange the reloptions machinery to use a table-based parser, and provide
Alvaro Herrera [Mon, 5 Jan 2009 17:14:28 +0000 (17:14 +0000)]
Change the reloptions machinery to use a table-based parser, and provide
a more complete framework for writing custom option processing routines
by user-defined access methods.

Catalog version bumped due to the general API changes, which are going to
affect user-defined "amoptions" routines.

15 years agoAdd a --role option to pg_dump, pg_dumpall, and pg_restore. This allows
Tom Lane [Mon, 5 Jan 2009 16:54:37 +0000 (16:54 +0000)]
Add a --role option to pg_dump, pg_dumpall, and pg_restore.  This allows
performing dumps and restores in accordance with a security policy that
forbids logging in directly as superuser, but instead specifies that you
should log into an admin account and then SET ROLE to the superuser.

In passing, clean up some ugly and mostly-broken code for quoting shell
arguments in pg_dumpall.

Benedek László, with some help from Tom Lane

15 years agoUpdate Japanese FAQ.
Bruce Momjian [Mon, 5 Jan 2009 15:04:59 +0000 (15:04 +0000)]
Update Japanese FAQ.

Jun Kuwamura

15 years agoQuiet repeated "loaded library" messages from child backends that are just
Tom Lane [Mon, 5 Jan 2009 13:57:12 +0000 (13:57 +0000)]
Quiet repeated "loaded library" messages from child backends that are just
re-loading a library already loaded into the postmaster.

ITAGAKI Takahiro

15 years agoAdd EmitWarningsOnPlaceholders calls to contrib modules that are likely to
Tom Lane [Mon, 5 Jan 2009 13:35:38 +0000 (13:35 +0000)]
Add EmitWarningsOnPlaceholders calls to contrib modules that are likely to
get listed in custom_variable_classes.

15 years agoFix define_custom_variable to preserve any sourcefile/sourceline information
Tom Lane [Mon, 5 Jan 2009 13:23:33 +0000 (13:23 +0000)]
Fix define_custom_variable to preserve any sourcefile/sourceline information
present in the placeholder.  Noted while testing pg_stat_statements.

15 years agoWhen cross-compiling, allow and require an external zic program to be used
Peter Eisentraut [Mon, 5 Jan 2009 10:25:59 +0000 (10:25 +0000)]
When cross-compiling, allow and require an external zic program to be used
when --with-system-tzdata is not used.

initial patch by Richard Evans

15 years agoFix for cross-compilation between mingw32 and something else. The choice
Peter Eisentraut [Mon, 5 Jan 2009 09:54:13 +0000 (09:54 +0000)]
Fix for cross-compilation between mingw32 and something else.  The choice
of pwd vs. pwd -W is correctly a function of the build system, not the
host system.

15 years agoAllow out-of-tree builds on mingw and cygwin
Peter Eisentraut [Mon, 5 Jan 2009 09:27:20 +0000 (09:27 +0000)]
Allow out-of-tree builds on mingw and cygwin

Author: Richard Evans <richard.evans@blueallegro.net>

15 years agoExport IsUnderPostmaster on win32.
Alvaro Herrera [Mon, 5 Jan 2009 02:27:45 +0000 (02:27 +0000)]
Export IsUnderPostmaster on win32.

ITAGAKI Takahiro

15 years agoAdd contrib/pg_stat_statements for server-wide tracking of statement execution
Tom Lane [Sun, 4 Jan 2009 22:19:59 +0000 (22:19 +0000)]
Add contrib/pg_stat_statements for server-wide tracking of statement execution
statistics.

Takahiro Itagaki

15 years agoAdd a pg_encoding_mbcliplen() function that is just like pg_mbcliplen()
Tom Lane [Sun, 4 Jan 2009 18:37:36 +0000 (18:37 +0000)]
Add a pg_encoding_mbcliplen() function that is just like pg_mbcliplen()
except the caller can specify the encoding to work in; this will be needed
for pg_stat_statements.  In passing, do some marginal efficiency hacking
and clean up some comments.  Also, prevent the single-byte-encoding code
path from fetching one byte past the stated length of the string (this
last is a bug that might need to be back-patched at some point).

15 years agoFix embarrassing bug in recent smgr refactoring patch: WAL records should
Heikki Linnakangas [Sun, 4 Jan 2009 14:59:22 +0000 (14:59 +0000)]
Fix embarrassing bug in recent smgr refactoring patch: WAL records should
be written for *non*-temp tables only. Report and test case by Mark
Kirkwood and Simon Riggs.

15 years agoAllow configure to deal with Python 3.0. Changes were:
Peter Eisentraut [Sun, 4 Jan 2009 00:54:15 +0000 (00:54 +0000)]
Allow configure to deal with Python 3.0.  Changes were:

print foo --> print(foo)
string.join(...) --> ' '.join(...)

These changes are backward compatible.

The actual plpython module appears to need significant updates to support
Python 3.0, though.  This change just relieves interested developers from
having to deal with Autoconf.

15 years agoAllow loadable modules to create PGC_POSTMASTER GUC variables, but only
Tom Lane [Sat, 3 Jan 2009 20:03:08 +0000 (20:03 +0000)]
Allow loadable modules to create PGC_POSTMASTER GUC variables, but only
when loaded via shared_preload_libraries.  Needed for support of
pg_stat_statements, or pretty much anything else that wants a GUC to
control size of a shared memory allocation.

15 years agoCreate a "shmem_startup_hook" to be called at the end of shared memory
Tom Lane [Sat, 3 Jan 2009 17:08:39 +0000 (17:08 +0000)]
Create a "shmem_startup_hook" to be called at the end of shared memory
initialization, to give loadable modules a reasonable place to perform
creation of any shared memory areas they need.  This is the logical conclusion
of our previous creation of RequestAddinShmemSpace() and RequestAddinLWLocks().
We don't need an explicit shmem_shutdown_hook, because the existing
on_shmem_exit and on_proc_exit mechanisms serve that need.

Also, adjust SubPostmasterMain so that libraries that got loaded into the
postmaster will be loaded into all child processes, not only regular backends.
This improves consistency with the non-EXEC_BACKEND behavior, and might be
necessary for functionality for some types of add-ons.

15 years agoInclude a pointer to the query's source text in QueryDesc structs. This is
Tom Lane [Fri, 2 Jan 2009 20:42:00 +0000 (20:42 +0000)]
Include a pointer to the query's source text in QueryDesc structs.  This is
practically free given prior 8.4 changes in plancache and portal management,
and it makes it a lot easier for ExecutorStart/Run/End hooks to get at the
query text.  Extracted from Itagaki Takahiro's pg_stat_statements patch,
with minor editorialization.

15 years agoInitialize .pot files with some useful default values.
Peter Eisentraut [Fri, 2 Jan 2009 15:15:42 +0000 (15:15 +0000)]
Initialize .pot files with some useful default values.

15 years agoSplit the ecpg translation support into a separate catalog for the ecpg
Peter Eisentraut [Fri, 2 Jan 2009 13:26:54 +0000 (13:26 +0000)]
Split the ecpg translation support into a separate catalog for the ecpg
preprocessor and the library.  This is useful for a number of reasons:

* The preprocessor and the library are in some cases installed in separate
packages and used by different classes of users.

* The library MO files need a different versioning scheme to account for the
soname.

* The makefiles are simpler, more robust, and easier to maintain this way.
(NLS web site was prone to break everytime a build rule changes.)

* Translators might choose to focus on the ecpglib, because that is more
user-facing.

* There was virtually no overlap, so nothing is lost.

15 years agoToday is find-typo-in-old-patches day. Fix wrong cut/paste in ident
Magnus Hagander [Fri, 2 Jan 2009 11:51:53 +0000 (11:51 +0000)]
Today is find-typo-in-old-patches day. Fix wrong cut/paste in ident
documentation.

15 years agoFix cut/paste error that caused all errors from REQUIRE_AUTH_OPTION to say
Magnus Hagander [Fri, 2 Jan 2009 11:34:03 +0000 (11:34 +0000)]
Fix cut/paste error that caused all errors from REQUIRE_AUTH_OPTION to say
it was the ldaptls parameter that was wrong...

15 years agoRemove comments that say restart is required for changing of Kerberos
Magnus Hagander [Fri, 2 Jan 2009 11:26:24 +0000 (11:26 +0000)]
Remove comments that say restart is required for changing of Kerberos
parameters.

15 years agoMake it possible to change Kerberos/GSSAPI parameters without restarting
Magnus Hagander [Fri, 2 Jan 2009 10:33:20 +0000 (10:33 +0000)]
Make it possible to change Kerberos/GSSAPI parameters without restarting
the postmaster. They are only used in backend processes, so it's just
a matter of re-labeling the GUCs.

15 years agowrite_nondefault_variables must take care to write custom_variable_classes
Tom Lane [Fri, 2 Jan 2009 02:02:10 +0000 (02:02 +0000)]
write_nondefault_variables must take care to write custom_variable_classes
first; otherwise backends reading the file might reject values of custom
variables.  Per experimentation with auto_explain.

15 years agoTweak guc.c to allow underscores in the names of custom variable classes,
Tom Lane [Fri, 2 Jan 2009 01:16:02 +0000 (01:16 +0000)]
Tweak guc.c to allow underscores in the names of custom variable classes,
and change auto_explain's custom GUC variables to be named auto_explain.xxx
not just explain.xxx.  Per discussion in connection with the
pg_stat_statements patch, it seems like a good idea to have the convention
that custom variable classes are named the same as their defining module.
Committing separately since this should happen regardless of what happens
with pg_stat_statements itself.

15 years agoBe smarter --- accept missing comma, and force comma if missing.
Bruce Momjian [Thu, 1 Jan 2009 18:31:55 +0000 (18:31 +0000)]
Be smarter --- accept missing comma, and force comma if missing.

15 years agoMention src/interfaces/libpq/libpq.rc.in needs to be updated for
Bruce Momjian [Thu, 1 Jan 2009 18:23:10 +0000 (18:23 +0000)]
Mention src/interfaces/libpq/libpq.rc.in needs to be updated for
copyright too.

15 years agoMake comma optional for copyright text change.
Bruce Momjian [Thu, 1 Jan 2009 18:21:56 +0000 (18:21 +0000)]
Make comma optional for copyright text change.

15 years agoAdd comma so this copyright notice is picked up in 2010.
Bruce Momjian [Thu, 1 Jan 2009 18:21:19 +0000 (18:21 +0000)]
Add comma so this copyright notice is picked up in 2010.

15 years agoFix a couple of missed copyright dates.
Tom Lane [Thu, 1 Jan 2009 17:59:40 +0000 (17:59 +0000)]
Fix a couple of missed copyright dates.

15 years agoUpdate copyright for 2009.
Bruce Momjian [Thu, 1 Jan 2009 17:24:05 +0000 (17:24 +0000)]
Update copyright for 2009.

15 years agoFix an oversight in my patch of a couple weeks ago that ensured a snapshot
Tom Lane [Thu, 1 Jan 2009 17:12:16 +0000 (17:12 +0000)]
Fix an oversight in my patch of a couple weeks ago that ensured a snapshot
is available during datatype input in Bind message processing.  I put the
PopActiveSnapshot() or equivalent just before PortalDefineQuery, which is
an unsafe spot for it (in 8.3 and later) because we are carrying a plancache
refcount that hasn't yet been assigned to the portal.  Any error thrown there
would result in leaking the refcount.  It's not exactly likely that
PopActiveSnapshot would throw an elog, perhaps, but it could happen.
Reorder the code and add another comment warning not to do that.

15 years agoThrow error if a <window definition> references a window that already has a
Tom Lane [Wed, 31 Dec 2008 23:42:56 +0000 (23:42 +0000)]
Throw error if a <window definition> references a window that already has a
frame clause, as appears to be required by the fine print in the SQL spec.
Per discussion with Pavel, not doing so risks user confusion.

15 years agoFix another problem in SQL-MED \d displays: should have a clean failure
Tom Lane [Wed, 31 Dec 2008 18:33:03 +0000 (18:33 +0000)]
Fix another problem in SQL-MED \d displays: should have a clean failure
report if the command is attempted against an old server.