Tom Lane [Sat, 13 Oct 2007 22:33:38 +0000 (22:33 +0000)]
Strengthen type_sanity's check on pg_type.typarray. It failed to
complain about types that didn't have typarray set. Noted while
working on txid patch.
Tom Lane [Sat, 13 Oct 2007 20:46:47 +0000 (20:46 +0000)]
Guard against possible double free during error escape from XML
functions. Patch for the reported issue from Kris Jurka, some
other potential trouble spots plugged by Tom.
Tom Lane [Sat, 13 Oct 2007 20:18:42 +0000 (20:18 +0000)]
Fix the inadvertent libpq ABI breakage discovered by Martin Pitt: the
renumbering of encoding IDs done between 8.2 and 8.3 turns out to break 8.2
initdb and psql if they are run with an 8.3beta1 libpq.so. For the moment
we can rearrange the order of enum pg_enc to keep the same number for
everything except PG_JOHAB, which isn't a problem since there are no direct
references to it in the 8.2 programs anyway. (This does force initdb
unfortunately.)
Going forward, we want to fix things so that encoding IDs can be changed
without an ABI break, and this commit includes the changes needed to allow
libpq's encoding IDs to be treated as fully independent of the backend's.
The main issue is that libpq clients should not include pg_wchar.h or
otherwise assume they know the specific values of libpq's encoding IDs,
since they might encounter version skew between pg_wchar.h and the libpq.so
they are using. To fix, have libpq officially export functions needed for
encoding name<=>ID conversion and validity checking; it was doing this
anyway unofficially.
It's still the case that we can't renumber backend encoding IDs until the
next bump in libpq's major version number, since doing so will break the
8.2-era client programs. However the code is now prepared to avoid this
type of problem in future.
Note that initdb is no longer a libpq client: we just pull in the two
source files we need directly. The patch also fixes a few places that
were being sloppy about checking for an unrecognized encoding name.
Tom Lane [Sat, 13 Oct 2007 15:55:40 +0000 (15:55 +0000)]
Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions of indexes
it affects. The original coding neglected tablespace entirely (causing
the indexes to move to the database's default tablespace) and for an index
belonging to a UNIQUE or PRIMARY KEY constraint, it would actually try to
assign the parent table's reloptions to the index :-(. Per bug #3672 and
subsequent investigation.
8.0 and 8.1 did not have reloptions, but the tablespace bug is present.
Tom Lane [Sat, 13 Oct 2007 00:58:03 +0000 (00:58 +0000)]
Teach planagg.c that partial indexes specifying WHERE foo IS NOT NULL can be
used to perform MIN(foo) or MAX(foo), since we want to discard null rows in
the indexscan anyway. (This would probably fall out for free if we were
injecting the IS NOT NULL clause somewhere earlier, but given the current
anatomy of the MIN/MAX optimization code we have to do it explicitly.
Fortunately, very little added code is needed.) Per a discussion with
Henk de Wit.
Tom Lane [Fri, 12 Oct 2007 19:39:59 +0000 (19:39 +0000)]
When telling the bgwriter that we need a checkpoint because too much xlog
has been consumed, recheck against the latest value of RedoRecPtr before
really sending the signal. This avoids useless checkpoint activity if
XLogWrite is executed when we have a very stale local copy of RedoRecPtr.
The potential for useless checkpoint is very much worse in 8.3 because of
the walwriter process (which never does XLogInsert), so while this behavior
was intentional, it needs to be changed. Per report from Itagaki Takahiro.
Tom Lane [Fri, 12 Oct 2007 18:55:12 +0000 (18:55 +0000)]
Remove hack in pg_tablespace_aclmask() that disallowed permissions
on pg_global even to superusers, and replace it with checks in various
other places to complain about invalid uses of pg_global. This ends
up being a bit more code but it allows a more specific error message
to be given, and it un-breaks pg_tablespace_size() on pg_global.
Per discussion.
Tom Lane [Thu, 11 Oct 2007 21:27:49 +0000 (21:27 +0000)]
Ensure that the result of evaluating a function during constant-expression
simplification gets detoasted before it is incorporated into a Const node.
Otherwise, if an immutable function were to return a TOAST pointer (an
unlikely case, but it can be made to happen), we would end up with a plan
that depends on the continued existence of the out-of-line toast datum.
Tom Lane [Thu, 11 Oct 2007 19:54:17 +0000 (19:54 +0000)]
Code review for txid patch: add binary I/O functions, avoid dependence
on SerializableSnapshot, minor other cleanup. Marko Kreen, some further
editorialization by me.
Tom Lane [Thu, 11 Oct 2007 18:19:58 +0000 (18:19 +0000)]
Remove incorrect use of VARSIZE() on a toasted datum. We can just remove it
instead of fix it, since once we've set toast_action[i] to 'p' it no longer
matters what toast_sizes[i] is. Greg Stark
Tom Lane [Thu, 11 Oct 2007 18:05:27 +0000 (18:05 +0000)]
Fix the plan-invalidation mechanism to treat regclass constants that refer to
a relation as a reason to invalidate a plan when the relation changes. This
handles scenarios such as dropping/recreating a sequence that is referenced by
nextval('seq') in a cached plan. Rather than teach plancache.c all about
digging through plan trees to find regclass Consts, we charge the planner's
setrefs.c with making a list of the relation OIDs on which each plan depends.
That way the list can be built cheaply during a plan tree traversal that has
to happen anyway. Per bug #3662 and subsequent discussion.
Bruce Momjian [Mon, 8 Oct 2007 18:01:17 +0000 (18:01 +0000)]
Add:
> o Have ALTER SEQUENCE RENAME rename the sequence name stored
> in the sequence table
>
> http://archives.postgresql.org/pgsql-bugs/2007-09/msg00092.php
> http://archives.postgresql.org/pgsql-bugs/2007-10/msg00007.php
>
Jan Wieck [Sun, 7 Oct 2007 23:32:19 +0000 (23:32 +0000)]
Added the Skytools extended transaction ID module to contrib as discussed
on CORE previously.
This module offers transaction ID's containing the original XID and the
transaction epoch as a bigint value to the user level. It also provides
a special txid_snapshot data type that contains an entire transactions
visibility snapshot information, which is useful to determine if a
particular txid was visible to a transaction or not.
The module has been tested by porting Slony-I from using its original
xxid data type.
Alvaro Herrera [Sun, 7 Oct 2007 01:16:42 +0000 (01:16 +0000)]
A few improvements to analyze and vacuum sections in documentation: add "see
also" entries for autovacuum in analyze and vacuum reference pages, and
enhance usage of cross-references in the maintenance page.
Alvaro Herrera [Sun, 7 Oct 2007 00:32:11 +0000 (00:32 +0000)]
Clean up the doc makefile for draft HTML generation. It no longer works
to do "make DRAFT=Y html"; you need to use "make draft" (which was also
supported previously).
Tom Lane [Sat, 6 Oct 2007 16:18:09 +0000 (16:18 +0000)]
Make dumpcolors() have tolerable performance when using 32-bit chr,
as we do (and upstream Tcl doesn't). The loop limit might be subject
to negotiation if anyone ever tries to do regex debugging in Far
Eastern languages, but for now 1000 seems plenty. CHR_MAX was right out :-(
Tom Lane [Sat, 6 Oct 2007 16:01:51 +0000 (16:01 +0000)]
Adjust regcustom.h so that all those assert() calls in the regex package
are converted to Postgres Assert() macros, instead of using <assert.h>
as formerly. No difference in production builds, but --enable-cassert
debug builds will get better coverage for regex testing.
Tom Lane [Fri, 5 Oct 2007 17:06:11 +0000 (17:06 +0000)]
Fix plperl and pltcl to include the name of the current function when
passing on errors from the language interpreter. (plpython seems
fairly OK about this already.) Per gripe from Robert Kleemann.
Bruce Momjian [Fri, 5 Oct 2007 16:42:32 +0000 (16:42 +0000)]
Add pgcvslog '-d' capability to allow stripping of commit messages that
have back branch activity. This will be useful for creating release
notes for major releases.
Tom Lane [Thu, 4 Oct 2007 20:44:47 +0000 (20:44 +0000)]
Keep the planner from failing on "WHERE false AND something IN (SELECT ...)".
eval_const_expressions simplifies this to just "WHERE false", but we have
already done pull_up_IN_clauses so the IN join will be done, or at least
planned, anyway. The trouble case comes when the sub-SELECT is itself a join
and we decide to implement the IN by unique-ifying the sub-SELECT outputs:
with no remaining reference to the output Vars in WHERE, we won't have
propagated the Vars up to the upper join point, leading to "variable not found
in subplan target lists" error. Fix by adding an extra scan of in_info_list
and forcing all Vars mentioned therein to be propagated up to the IN join
point. Per bug report from Miroslav Sulc.
Tom Lane [Wed, 3 Oct 2007 23:02:16 +0000 (23:02 +0000)]
Second pass at 8.3 release notes: put items in a bit more logical order
where possible, add overview and incompatibilities lists, minor cleanups.
The SGML-ification still leaves much to be desired.
Tom Lane [Wed, 3 Oct 2007 15:59:13 +0000 (15:59 +0000)]
Tweak recently-added tests to suppress scary-looking warnings on 64-bit
machines about casts between pointers and integers of different sizes.
While they're harmless, we shouldn't expect users to have to go through
and figure that out for themselves.
Magnus Hagander [Wed, 3 Oct 2007 13:57:52 +0000 (13:57 +0000)]
Attempt to open certificate file "manually" using fopen before
trying BIO functions.
Helps problem with older versions of OpenSSL that lacks error
stack functions and would show an incorrect error message for
file-not-found-or-not-openable. The problem may still exist for
other errors, but file open error is by far the most common one.
Tom Lane [Wed, 3 Oct 2007 03:32:31 +0000 (03:32 +0000)]
First cut at 8.3 release notes. SGML markup is nonexistent, and
the 'overview' and 'incompatibilities' summary lists remain to be
written. But I think all the raw info is there (indeed maybe too
verbose).
Tom Lane [Tue, 2 Oct 2007 00:25:20 +0000 (00:25 +0000)]
Cope with ERR_set_mark() and ERR_pop_to_mark() not existing in older
OpenSSL libraries --- just don't call them if they're not there. This
might possibly lead to misleading error messages, but we'll just have
to live with that.