Bruce Momjian [Fri, 8 Nov 2002 04:57:07 +0000 (04:57 +0000)]
I'm using libpgtcl with PostgreSQL-7.2.3. There is a discrepancy between
the documentation and behavior of "pg_result $res -oid" when $res is not
from an INSERT. The documentation says it should return an empty
string, but in fact it returns 0. I think it used to return an empty
string around PostgreSQL-7.1.3 when PQoidStatus() was used, but now it
uses PQoidValue() which returns InvalidOid, 0 in this case.
Assuming the current behavior is desired, here is a patch to the
documentation doc/src/sgml/libpgtcl.sgml to match what really happens:
Barry Lind [Mon, 4 Nov 2002 06:42:33 +0000 (06:42 +0000)]
Applied two patches from Kris Jurka.
- First fixes a problem with a recent patch allowing setNull on updateable
resultsets
- Second removed toLower() calls on database object names. Leave it to
the caller to correctly pass lower, upper or mixed case. The driver
already has methods that the caller can use to determine that postgres
stores identifiers in lowercase. (unless the identifier was quoted when
created).
Tom Lane [Sun, 3 Nov 2002 04:52:09 +0000 (04:52 +0000)]
Fix dblink regression test so that it works when repeated: don't
create a second database, just loop back to 'regression'. Patch
from Joe Conway 10/22/02.
Tom Lane [Sat, 2 Nov 2002 22:02:08 +0000 (22:02 +0000)]
Code review for recent patch to allow ALTER TABLE ADD COLUMN when
a child table already has a matching column. Acquire appropriate
lock on child table; do the right thing with any CHECK constraints
attached to the new parent column.
Tom Lane [Sat, 2 Nov 2002 21:20:40 +0000 (21:20 +0000)]
During swap_relfilenodes, swap relation size statistic fields along with
the relfilenode and toast fields. This ensures that the newly-computed
statistics will be available on completion of CLUSTER.
Tom Lane [Sat, 2 Nov 2002 18:41:22 +0000 (18:41 +0000)]
Remove encoding lookups from grammar stage, push them back to places
where it's safe to do database access. Along the way, fix core dump
for 'DEFAULT' parameters to CREATE DATABASE. initdb forced due to
change in pg_proc entry.
Tom Lane [Sat, 2 Nov 2002 02:33:03 +0000 (02:33 +0000)]
Fix permissions-checking bugs and namespace-search-path bugs in
CONVERSION code. Still need to figure out what to do about inappropriate
coding in parsing.
Tom Lane [Fri, 1 Nov 2002 22:52:34 +0000 (22:52 +0000)]
Arrange to compile flex output files as inclusions into other files
(usually bison output files), not as standalone files. This hack
works around flex's insistence on including <stdio.h> before we are
able to include postgres.h; postgres.h will already be read before
the compiler starts to read the flex output file. Needed for largefile
support on some platforms.
Tom Lane [Fri, 1 Nov 2002 17:55:23 +0000 (17:55 +0000)]
After elog(PANIC), exit with abort() not proc_exit(). This allows a
core file to be produced for debugging, and avoids trying to run the
normal proc-exit cleanup hooks, which are likely to cause additional
problems if the system is hosed.
Tom Lane [Thu, 31 Oct 2002 21:34:17 +0000 (21:34 +0000)]
Code review for statement_timeout patch. Fix some race conditions
between signal handler and enable/disable code, avoid accumulation of
timing error due to trying to maintain remaining-time instead of
absolute-end-time, disable timeout before commit not after.
Tom Lane [Thu, 31 Oct 2002 19:25:29 +0000 (19:25 +0000)]
Fix miscalculation of remaining free space during tuple chain moving.
Only affects machines where MAXALIGN > 4, and is a boundary-condition
case even there, but still surprising that it's not been identified
before. Also reduce tuple chain move give-up messages from WARNING
to DEBUG1, since they are not unexpected conditions.
Bruce Momjian [Mon, 28 Oct 2002 20:05:18 +0000 (20:05 +0000)]
Update from Neil Conway:
< * Add floor(float8) and other missing functions
> * -Add floor(float8) and other missing functions 174c174
< * Improve concurrency of hash indexes (Neil Conway)
> * Improve concurrency of hash indexes (Neil) 277c277
< o Allow array declarations and other data types in PL/PgSQl DECLARE
> o Allow array declarations and other data types in PL/PgSQL DECLARE 293c293
< * -Have pg_dump use ADD PRIMARY KEY after COPY, for performance (Neil Conway)
> * -Have pg_dump use ADD PRIMARY KEY after COPY, for performance (Neil) 474c474
< * Precompile SQL functions to avoid overhead (Neil Conway)
> * Precompile SQL functions to avoid overhead (Neil) 549c549
< * Neil is Neil Conway <nconway@klamath.dyndns.org>
> * Neil is Neil Conway <neilc@samurai.com>
projects / postgresql / log