]> granicus.if.org Git - postgresql/log
postgresql
21 years agoMake sure that -- comments extend to the end of the line. This fixes the
Peter Eisentraut [Thu, 9 Oct 2003 19:13:23 +0000 (19:13 +0000)]
Make sure that -- comments extend to the end of the line.  This fixes the
misscanning of this construct:

SELECT ''hello world''
-- SELECT ''goodbye world''
::text;

21 years agoSome updates
Peter Eisentraut [Thu, 9 Oct 2003 19:11:03 +0000 (19:11 +0000)]
Some updates

21 years agoAdd mention of logrotate for syslog, from Robert Treat
Bruce Momjian [Thu, 9 Oct 2003 19:05:09 +0000 (19:05 +0000)]
Add mention of logrotate for syslog, from Robert Treat

21 years agoUpdate Solaris FAQ to mention -fast.
Bruce Momjian [Thu, 9 Oct 2003 17:11:13 +0000 (17:11 +0000)]
Update Solaris FAQ to mention -fast.

21 years agoRemove -pipe on Linux, per reports from Peter.
Bruce Momjian [Thu, 9 Oct 2003 16:52:45 +0000 (16:52 +0000)]
Remove -pipe on Linux, per reports from Peter.

21 years agoAdd -pipe compile for Linux.
Bruce Momjian [Thu, 9 Oct 2003 14:47:59 +0000 (14:47 +0000)]
Add -pipe compile for Linux.

21 years agoMake template CFLAGS handling consistent.
Bruce Momjian [Thu, 9 Oct 2003 14:40:37 +0000 (14:40 +0000)]
Make template CFLAGS handling consistent.

21 years agoSomeone report me small bug in contrib/pg_dumplo today. It's problem
Bruce Momjian [Thu, 9 Oct 2003 13:38:05 +0000 (13:38 +0000)]
Someone report  me small  bug in contrib/pg_dumplo  today. It's problem
with a little dirty snprintf() usage which I used some years ago:

    snprintf(path, BUFSIZ, "%s/lo_dump.index", path);

Karel Zak

21 years agoRe-add -pipe compile flags for bsd's.
Bruce Momjian [Thu, 9 Oct 2003 04:34:02 +0000 (04:34 +0000)]
Re-add -pipe compile flags for bsd's.

21 years agoUpdate:
Bruce Momjian [Thu, 9 Oct 2003 04:29:40 +0000 (04:29 +0000)]
Update:

> * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
>   (Christopher)

21 years agoThis centralizes the optimization defaults into configure.in, rather
Bruce Momjian [Thu, 9 Oct 2003 03:20:34 +0000 (03:20 +0000)]
This centralizes the optimization defaults into configure.in, rather
than having CFLAGS= in the template files.

It uses -O2 for gcc (generated by autoconf), and -O for non-gcc, unless
the template overrides it.

21 years agoAdd:
Bruce Momjian [Thu, 9 Oct 2003 03:17:24 +0000 (03:17 +0000)]
Add:

> * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT ] (Christopher)

21 years agoChange "query:" to "statement:".
Bruce Momjian [Thu, 9 Oct 2003 02:40:18 +0000 (02:40 +0000)]
Change "query:" to "statement:".

Have log_duration print when log_min_duration_statement prints.

21 years agoAdd quotes to CFLAG define.
Bruce Momjian [Thu, 9 Oct 2003 02:37:09 +0000 (02:37 +0000)]
Add quotes to CFLAG define.

21 years agoProtected access to variable m_preparedCount via synchronized
Jan Wieck [Thu, 9 Oct 2003 01:17:07 +0000 (01:17 +0000)]
Protected access to variable m_preparedCount via synchronized
function to prevent multiple threads using automatic cursors on
the same connection from stomping over each others cursor.

Jan

21 years agoAdd:
Bruce Momjian [Wed, 8 Oct 2003 22:29:58 +0000 (22:29 +0000)]
Add:
<
346a346
> * Remove CREATE CONSTRAINT TRIGGER

21 years agoAdd 2-phase info, add Win32 URL:
Bruce Momjian [Wed, 8 Oct 2003 21:44:06 +0000 (21:44 +0000)]
Add 2-phase info, add Win32 URL:

<  o Sample implementation in contrib/rserv
29c28,29
< * Create native Win32 port [win32]
> * Create native Win32 port, http://momjian.postgresql.org/main/writings/pgsql/win32.html
>
367c367,368
< * Two-phase commit to implement distributed transactions
> * Add two-phase commit to all distributed transactions with
>   offline/readonly server status or administrator notification for failure

21 years agoNew translations
Peter Eisentraut [Wed, 8 Oct 2003 20:35:39 +0000 (20:35 +0000)]
New translations

21 years agoAdd:
Bruce Momjian [Wed, 8 Oct 2003 19:33:53 +0000 (19:33 +0000)]
Add:

> * Use background process to write dirty shared buffers to disk

21 years agoNew translations
Peter Eisentraut [Wed, 8 Oct 2003 18:38:49 +0000 (18:38 +0000)]
New translations

21 years agoAdd quotes around -O setting for consistency.
Bruce Momjian [Wed, 8 Oct 2003 18:23:08 +0000 (18:23 +0000)]
Add quotes around -O setting for consistency.

21 years agoChange some awkward wording in the pg_autovacuum README file. I really
Bruce Momjian [Wed, 8 Oct 2003 18:18:04 +0000 (18:18 +0000)]
Change some awkward wording in the pg_autovacuum README file. I really
only read this because of Niel :-)

Robert Treat

21 years agoRemoved my debug printf() call from numeric.c
Michael Meskes [Wed, 8 Oct 2003 08:28:57 +0000 (08:28 +0000)]
Removed my debug printf() call from numeric.c

21 years agoUse calloc() to allocate empty structures.
Bruce Momjian [Wed, 8 Oct 2003 03:52:32 +0000 (03:52 +0000)]
Use calloc() to allocate empty structures.

Fix pg_restore tar log output bug where Special flag wasn't being
initialized; bug seen on XP.

21 years agoHave log_min_duration_statement = 0 always print duration/statement.
Bruce Momjian [Wed, 8 Oct 2003 03:49:38 +0000 (03:49 +0000)]
Have log_min_duration_statement = 0 always print duration/statement.

Change log line to be "duration:  ms  query:"

Indent multi-line queries with a tab in the server logs.

21 years agoFixed floating point exception in long=>numeric conversion.
Michael Meskes [Tue, 7 Oct 2003 18:36:46 +0000 (18:36 +0000)]
Fixed floating point exception in long=>numeric conversion.

21 years agoFix include used by entab.
Bruce Momjian [Tue, 7 Oct 2003 17:40:09 +0000 (17:40 +0000)]
Fix include used by entab.

21 years agoAdd missing include file.
Peter Eisentraut [Tue, 7 Oct 2003 08:07:56 +0000 (08:07 +0000)]
Add missing include file.

21 years agoFixed error handling in Informix compat str to date conversion.
Michael Meskes [Tue, 7 Oct 2003 05:46:56 +0000 (05:46 +0000)]
Fixed error handling in Informix compat str to date conversion.

21 years agoNew Italian translation
Peter Eisentraut [Mon, 6 Oct 2003 21:50:45 +0000 (21:50 +0000)]
New Italian translation

21 years agoFix binary_oper_exact() so that the heuristic 'an unknown literal on
Tom Lane [Mon, 6 Oct 2003 20:09:47 +0000 (20:09 +0000)]
Fix binary_oper_exact() so that the heuristic 'an unknown literal on
one side of a binary operator is probably supposed to be the same type
as the other operand' will be applied for domain types.  This worked
in 7.3 but was broken in 7.4 due to code rearrangements.  Mea culpa.

21 years agoTranslation updates
Peter Eisentraut [Mon, 6 Oct 2003 17:37:39 +0000 (17:37 +0000)]
Translation updates

21 years agoDuring ALTER TABLE ADD FOREIGN KEY, try to check the existing rows using
Tom Lane [Mon, 6 Oct 2003 16:38:28 +0000 (16:38 +0000)]
During ALTER TABLE ADD FOREIGN KEY, try to check the existing rows using
a single LEFT JOIN query instead of firing the check trigger for each
row individually.  Stephan Szabo, with some kibitzing from Tom Lane and
Jan Wieck.

21 years agoNew Slovene translations
Peter Eisentraut [Mon, 6 Oct 2003 16:31:16 +0000 (16:31 +0000)]
New Slovene translations

21 years ago- Fixed constant listing in execute using clause.
Michael Meskes [Mon, 6 Oct 2003 06:44:55 +0000 (06:44 +0000)]
- Fixed constant listing in execute using clause.
- Fixed typo in ecpg for Informix dec_t type.
- Fixed precision handling in Informix compat funxtions.

21 years agoTranslation updates
Peter Eisentraut [Mon, 6 Oct 2003 06:20:11 +0000 (06:20 +0000)]
Translation updates

21 years agoModify COPY FROM to match the null-value string against the column value
Tom Lane [Mon, 6 Oct 2003 02:38:53 +0000 (02:38 +0000)]
Modify COPY FROM to match the null-value string against the column value
before it is de-backslashed, not after.  This allows the null string \N
to be reliably distinguished from the data value \N (which must be
represented as \\N).  Per bug report from Manfred Koizar ... but it's
amazing this hasn't been reported before ...
Also, be consistent about encoding conversion for null string: the form
specified in the command is in the server encoding, but what is sent
to/from client must be in client encoding.  This never worked quite
right before either.

21 years agoFix order of operations within SendQuery() so that the time spent in
Tom Lane [Mon, 6 Oct 2003 01:11:12 +0000 (01:11 +0000)]
Fix order of operations within SendQuery() so that the time spent in
data transfer during COPY is included in the \timing display.  Also
avoid portability problems if tv_usec is unsigned on some platform.

21 years agoAdd a little more smarts to estimate_hash_bucketsize(): if there's no
Tom Lane [Sun, 5 Oct 2003 22:44:25 +0000 (22:44 +0000)]
Add a little more smarts to estimate_hash_bucketsize(): if there's no
statistics, but there is a unique index on the column, we can safely
assume it's well-distributed.

21 years agoMake psql \timing show three digits.
Bruce Momjian [Sun, 5 Oct 2003 22:36:00 +0000 (22:36 +0000)]
Make psql \timing show three digits.

21 years agoTranslation updates
Peter Eisentraut [Sun, 5 Oct 2003 21:52:37 +0000 (21:52 +0000)]
Translation updates

21 years agoWhen revoking privileges from the owner, don't revoke the grant options,
Peter Eisentraut [Sun, 5 Oct 2003 21:49:12 +0000 (21:49 +0000)]
When revoking privileges from the owner, don't revoke the grant options,
to avoid recursively revoking everything from everyone.

21 years agoUpdate MySQL mention.
Bruce Momjian [Sun, 5 Oct 2003 14:25:29 +0000 (14:25 +0000)]
Update MySQL mention.

21 years agoFixed bug in day of week processing.
Michael Meskes [Sun, 5 Oct 2003 11:12:00 +0000 (11:12 +0000)]
Fixed bug in day of week processing.

21 years agoUpdate MySQL mention.
Bruce Momjian [Sun, 5 Oct 2003 03:52:08 +0000 (03:52 +0000)]
Update MySQL mention.

21 years agoTranslation update
Peter Eisentraut [Sat, 4 Oct 2003 22:50:20 +0000 (22:50 +0000)]
Translation update

21 years agoDocument the always-true-but-previously-undocumented fact that PQfnumber()
Tom Lane [Sat, 4 Oct 2003 21:05:21 +0000 (21:05 +0000)]
Document the always-true-but-previously-undocumented fact that PQfnumber()
will downcase the supplied field name unless it is double-quoted.  Also,
upgrade the routine's handling of double quotes to match the backend,
in particular support doubled double quotes within quoted identifiers.
Per pgsql-interfaces discussion a couple weeks ago.

21 years agoFix pg_get_constraintdef() to ensure CHECK constraints are always shown
Tom Lane [Sat, 4 Oct 2003 18:22:59 +0000 (18:22 +0000)]
Fix pg_get_constraintdef() to ensure CHECK constraints are always shown
with required outer parentheses.  Breakage seems to be leftover from
domain-constraint patches.  This could be smarter about suppressing
extra parens, but at this stage of the release cycle I want certainty
not cuteness.

21 years agoModify:
Bruce Momjian [Sat, 4 Oct 2003 18:19:57 +0000 (18:19 +0000)]
Modify:

< * Consider using MVCC to cache count(*) queries with no WHERE clause
> * Use a fixed row count and a +/- count with MVCC visibility rules
>   to allow fast COUNT(*) queries with no WHERE clause(?)

21 years agoTranslation updates
Peter Eisentraut [Sat, 4 Oct 2003 18:13:16 +0000 (18:13 +0000)]
Translation updates

21 years agoTranslation update
Peter Eisentraut [Sat, 4 Oct 2003 18:09:08 +0000 (18:09 +0000)]
Translation update

21 years agoUpdate INSTALL file for 7.4.
Bruce Momjian [Sat, 4 Oct 2003 03:14:13 +0000 (03:14 +0000)]
Update INSTALL file for 7.4.

21 years agoFix log_duration and log_min_duration_statement to print properly, as
Bruce Momjian [Sat, 4 Oct 2003 02:47:04 +0000 (02:47 +0000)]
Fix log_duration and log_min_duration_statement to print properly, as
pointed out by Peter.

21 years agoUpdate MySQL mention.
Bruce Momjian [Sat, 4 Oct 2003 02:37:05 +0000 (02:37 +0000)]
Update MySQL mention.

21 years agoUpdate MySQL mention.
Bruce Momjian [Sat, 4 Oct 2003 01:39:51 +0000 (01:39 +0000)]
Update MySQL mention.

21 years agoTranslation updates
Peter Eisentraut [Sat, 4 Oct 2003 01:07:05 +0000 (01:07 +0000)]
Translation updates

21 years agoFormat help message internally consistent.
Peter Eisentraut [Sat, 4 Oct 2003 01:06:38 +0000 (01:06 +0000)]
Format help message internally consistent.

21 years agoChange transaction status indicator in prompt from %T to %x.
Peter Eisentraut [Sat, 4 Oct 2003 01:04:46 +0000 (01:04 +0000)]
Change transaction status indicator in prompt from %T to %x.

21 years agoNew translation
Peter Eisentraut [Fri, 3 Oct 2003 22:39:34 +0000 (22:39 +0000)]
New translation

21 years agoIssue 'SET check_function_bodies = false' to suppress possible restore
Tom Lane [Fri, 3 Oct 2003 20:10:59 +0000 (20:10 +0000)]
Issue 'SET check_function_bodies = false' to suppress possible restore
failures in SQL functions, due to forward references or unqualified
references to objects in other schemas.  Per recent discussion.

21 years agoAdd GUC parameter check_function_bodies to control whether validation
Tom Lane [Fri, 3 Oct 2003 19:26:49 +0000 (19:26 +0000)]
Add GUC parameter check_function_bodies to control whether validation
of function bodies is done at CREATE FUNCTION time.  This is normally
true but can be set false to avoid problems with forward references,
wrong schema search path, etc.  This is just the backend patch, still
need to adjust pg_dump to make use of it.

21 years agoCause PQescapeString to stop processing at a null character, rather
Tom Lane [Fri, 3 Oct 2003 18:26:14 +0000 (18:26 +0000)]
Cause PQescapeString to stop processing at a null character, rather
than generating an invalid output string.  Per observation and patch
from Igor Shevchenko.  Further code cleanup and documentation by
Tom Lane.

21 years agoRemove assorted compilation failures introduced by latest ecpg changes.
Tom Lane [Fri, 3 Oct 2003 17:04:48 +0000 (17:04 +0000)]
Remove assorted compilation failures introduced by latest ecpg changes.
Also remove -g, which has no business in CPPFLAGS in the first place,
let alone being hardwired there by a sub-Makefile.

21 years agoHide Informix datatypes. They are not seen by our built process anymore.
Michael Meskes [Fri, 3 Oct 2003 10:07:28 +0000 (10:07 +0000)]
Hide Informix datatypes. They are not seen by our built process anymore.

21 years agobrand her beta4 REL7_4_BETA4
PostgreSQL Daemon [Fri, 3 Oct 2003 03:08:14 +0000 (03:08 +0000)]
brand her beta4

21 years agoAdd a bit more locking to vac_update_relstats and vac_update_dbstats
Tom Lane [Thu, 2 Oct 2003 23:19:44 +0000 (23:19 +0000)]
Add a bit more locking to vac_update_relstats and vac_update_dbstats
to make them comparable to what UpdateStats does in the same situation.
I'm not certain two instances of vac_update_relstats could run in
parallel for the same relation, but parallel invocations of vac_update_dbstats
do seem possible.

21 years agoWhen dumping CREATE INDEX, must show opclass name if the opclass isn't
Tom Lane [Thu, 2 Oct 2003 22:24:54 +0000 (22:24 +0000)]
When dumping CREATE INDEX, must show opclass name if the opclass isn't
in the schema search path.  Otherwise pg_dump doesn't correctly dump
scenarios where a custom opclass is created in 'public' and then used
by indexes in other schemas.

21 years agoDo not return from PQrequestCancel until postmaster has finished
Tom Lane [Thu, 2 Oct 2003 19:52:44 +0000 (19:52 +0000)]
Do not return from PQrequestCancel until postmaster has finished
processing the request; this ensures that the request won't be taken
to cancel a subsequently-issued query.  Race condition originally
noted by Oliver Jowett in the context of JDBC, but libpq has it too.

21 years agoDon't use 0 as a spelling of NULL.
Tom Lane [Thu, 2 Oct 2003 14:47:44 +0000 (14:47 +0000)]
Don't use 0 as a spelling of NULL.

21 years agoAdd documentation about \pset footer to \?.
Peter Eisentraut [Thu, 2 Oct 2003 06:39:31 +0000 (06:39 +0000)]
Add documentation about \pset footer to \?.

from Patrick Welche

21 years agoString fixes/improvements found by Alvaro Herrera
Peter Eisentraut [Thu, 2 Oct 2003 06:36:37 +0000 (06:36 +0000)]
String fixes/improvements found by Alvaro Herrera

21 years agoChange some notices to warnings and vice versa according to criteria
Peter Eisentraut [Thu, 2 Oct 2003 06:34:04 +0000 (06:34 +0000)]
Change some notices to warnings and vice versa according to criteria
developed on -hackers.

21 years agoRemove NOTICE about foreign key creating implicit triggers, because it no
Peter Eisentraut [Thu, 2 Oct 2003 06:32:46 +0000 (06:32 +0000)]
Remove NOTICE about foreign key creating implicit triggers, because it no
longer conveys useful information.

21 years agoAttached is a patch for contrib/tablefunc. It fixes two issues raised by
Tom Lane [Thu, 2 Oct 2003 03:51:40 +0000 (03:51 +0000)]
Attached is a patch for contrib/tablefunc. It fixes two issues raised by
Lars Boegild Thomsen (full email below) and also corrects the regression
expected output for a recent backend message adjustment. Please apply.

Joe Conway

21 years agoAdd code to check that IF/WHILE/EXIT test expressions are boolean,
Tom Lane [Wed, 1 Oct 2003 21:47:42 +0000 (21:47 +0000)]
Add code to check that IF/WHILE/EXIT test expressions are boolean,
and try to coerce the values to boolean if not.  Per recent discussions.

21 years agoRepair RI trigger visibility problems (this time for sure ;-)) per recent
Tom Lane [Wed, 1 Oct 2003 21:30:53 +0000 (21:30 +0000)]
Repair RI trigger visibility problems (this time for sure ;-)) per recent
discussion on pgsql-hackers: in READ COMMITTED mode we just have to force
a QuerySnapshot update in the trigger, but in SERIALIZABLE mode we have
to run the scan under a current snapshot and then complain if any rows
would be updated/deleted that are not visible in the transaction snapshot.

21 years agoAdjust documentation examples to match recent error message rewordings.
Tom Lane [Tue, 30 Sep 2003 03:22:33 +0000 (03:22 +0000)]
Adjust documentation examples to match recent error message rewordings.
A couple other minor fixes.

21 years agoMinor copy-editing.
Tom Lane [Tue, 30 Sep 2003 01:56:11 +0000 (01:56 +0000)]
Minor copy-editing.

21 years agoUse slightly less broken markup.
Tom Lane [Tue, 30 Sep 2003 01:26:29 +0000 (01:26 +0000)]
Use slightly less broken markup.

21 years agoheap_open => relation_open to avoid unwanted restriction on relkind.
Tom Lane [Tue, 30 Sep 2003 00:59:51 +0000 (00:59 +0000)]
heap_open => relation_open to avoid unwanted restriction on relkind.
Per gripe from Gaetano Mendola.

21 years agoAdjust btree index build procedure so that the btree metapage looks
Tom Lane [Mon, 29 Sep 2003 23:40:26 +0000 (23:40 +0000)]
Adjust btree index build procedure so that the btree metapage looks
invalid (has the wrong magic number) until the build is entirely
complete.  This turns out to cost no additional writes in the normal
case, since we were rewriting the metapage at the end of the process
anyway.  In normal scenarios there's no real gain in security, because
a failed index build would roll back the transaction leaving an unused
index file, but for rebuilding shared system indexes this seems to add
some useful protection.

21 years agoRelease updates by Tom.
Bruce Momjian [Mon, 29 Sep 2003 23:16:44 +0000 (23:16 +0000)]
Release updates by Tom.

21 years agoImprove context display for failures during COPY IN, as recently
Tom Lane [Mon, 29 Sep 2003 22:06:40 +0000 (22:06 +0000)]
Improve context display for failures during COPY IN, as recently
discussed on pghackers.

21 years agoUpdate Jan's completed item.
Bruce Momjian [Mon, 29 Sep 2003 21:42:04 +0000 (21:42 +0000)]
Update Jan's completed item.

21 years agoRemove, already done:
Bruce Momjian [Mon, 29 Sep 2003 21:41:29 +0000 (21:41 +0000)]
Remove, already done:

<  o Fixed PL/Tcl's spi_prepare to accept full qualified type names in
<    the parameter type list

21 years agoUpdate HISTORY for 7.4.
Bruce Momjian [Mon, 29 Sep 2003 21:25:43 +0000 (21:25 +0000)]
Update HISTORY for 7.4.

Neil Conway

21 years agoAdd:
Bruce Momjian [Mon, 29 Sep 2003 21:15:19 +0000 (21:15 +0000)]
Add:

>  o Fixed PL/Tcl's spi_prepare to accept full qualified type names in
>    the parameter type list

21 years agoFixed type lookup in spi_prepare for possible qualified
Jan Wieck [Mon, 29 Sep 2003 19:24:06 +0000 (19:24 +0000)]
Fixed type lookup in spi_prepare for possible qualified
type name specification.

Jan

21 years agoThe brackets aren't put on the CHECK constraints properly.
Bruce Momjian [Mon, 29 Sep 2003 18:55:56 +0000 (18:55 +0000)]
The brackets aren't put on the CHECK constraints properly.

Before patch:

test=# select pg_get_constraintdef(oid) from pg_constraint;
                                       pg_get_constraintdef
-------------------------------------------------------------------------------------------------
  CHECK (VALUE >= 0)
  CHECK ((((a)::text = 'asdf'::text) OR ((a)::text = 'fdsa'::text)) OR
((a)::text = 'dfd'::text))
  PRIMARY KEY (b)
  FOREIGN KEY (a) REFERENCES test2(b)
  UNIQUE (b)
(5 rows)

test=# select pg_get_constraintdef(oid, true) from pg_constraint;
                                pg_get_constraintdef
-----------------------------------------------------------------------------------
  CHECK VALUE >= 0
  CHECK a::text = 'asdf'::text OR a::text = 'fdsa'::text OR a::text =
'dfd'::text
  PRIMARY KEY (b)
  FOREIGN KEY (a) REFERENCES test2(b)
  UNIQUE (b)
(5 rows)

After patch:

test=# select pg_get_constraintdef(oid) from pg_constraint;
                                       pg_get_constraintdef
-------------------------------------------------------------------------------------------------
  CHECK (VALUE >= 0)
  CHECK ((((a)::text = 'asdf'::text) OR ((a)::text = 'fdsa'::text)) OR
((a)::text = 'dfd'::text))
  PRIMARY KEY (b)
  FOREIGN KEY (a) REFERENCES test2(b)
  UNIQUE (b)
(5 rows)

test=# select pg_get_constraintdef(oid, true) from pg_constraint;
                                pg_get_constraintdef
-----------------------------------------------------------------------------------
  CHECK (VALUE >= 0)

`  CHECK (a::text = 'asdf'::text OR a::text = 'fdsa'::text OR a::text =
'dfd'::text)
  PRIMARY KEY (b)
  FOREIGN KEY (a) REFERENCES test2(b)
  UNIQUE (b)
(5 rows)

It's important that those brackets are there to (a) match all other
constraints and (b) so that people can just copy and paste them and it
will work as SQL.

Christopher Kings-Lynne

21 years agoI've not changed any malloc/calloc to palloc. It looks to me that these memory
Bruce Momjian [Mon, 29 Sep 2003 18:54:38 +0000 (18:54 +0000)]
I've not changed any malloc/calloc to palloc. It looks to me that these memory
areas are for the lifetime of the backend and in the interests of not breaking
something that's not broken I left alone.

Note for anyone reading this and wanting it for tsearch-v2-stable (i.e. for 7.3
backend) this patch probably will not apply cleanly to that source. It should
be simple enough to see what's going on and apply the changes by hand if need
be.

--
Nigel J. Andrews

21 years agoThis patch fixes an obvious bug in the "should I print the duration of
Bruce Momjian [Mon, 29 Sep 2003 18:50:58 +0000 (18:50 +0000)]
This patch fixes an obvious bug in the "should I print the duration of
this query?" logic in postgres.c

Also, make it print "duration:" like log_duration.

Neil Conway

21 years agoI discovered that TupleDescGetAttInMetadata and BuildTupleFromCStrings
Bruce Momjian [Mon, 29 Sep 2003 18:22:48 +0000 (18:22 +0000)]
I discovered that TupleDescGetAttInMetadata and BuildTupleFromCStrings
don't deal well with tuples having dropped columns. The attached fixes
the issue. Please apply.

Joe Conway

21 years ago> >
Bruce Momjian [Mon, 29 Sep 2003 18:21:33 +0000 (18:21 +0000)]
> >
> >  a) Write documentation how the win32 console needs to be set up so that
> >     psql can handle 8-bit characters.
> >     Where should it be added? The Section "Installation on Windows" in the
> >     Administrator's Guide seems natural to me.
> >
> >  b) Add code to psql that prints a warning on startup of psql when the
> >     console codepage differs from the windows codepage, something like
> >
> >     Warning: Console codepage (850) differs from windows codepage (1252)
> >              8-bit characters will not work correctly. See PostgreSQL
> >              documentation "Installation on Windows" for details.
>
Attached are two patches:

 - installdoc.patch contains an additional paragraph on the win32 console
   codepage for the chapter "Installation on Windows"
   Due to a lack of SGML-tools, I have only edited the text and not tested
   the SGML code - please check it before merging into the CVS branch.

 - psqlcodepage.patch adds the warning about a problematic codepage to psql.

Christoph Dalitz

21 years agoThis patch makes a few incremental improvements to geqo.sgml and
Bruce Momjian [Mon, 29 Sep 2003 18:18:35 +0000 (18:18 +0000)]
This patch makes a few incremental improvements to geqo.sgml and
arch-dev.sgml

Neil Conway

21 years agoA) Fixes a bug that prevented mirroring of data on a table that has had
Bruce Momjian [Mon, 29 Sep 2003 18:16:48 +0000 (18:16 +0000)]
A) Fixes a bug that prevented mirroring of data on a table that has had
a column dropped.

B) Updated the documentation for the 7.4 release.

Steven Singer

21 years agoChange 7.3.4 release note format to match the rest of the 7.3.x
Bruce Momjian [Mon, 29 Sep 2003 18:15:12 +0000 (18:15 +0000)]
Change 7.3.4 release note format to match the rest of the 7.3.x
releases.

Rod Taylor

21 years agoUpdate release notes.
Bruce Momjian [Mon, 29 Sep 2003 18:06:48 +0000 (18:06 +0000)]
Update release notes.

21 years agoAdd:
Bruce Momjian [Mon, 29 Sep 2003 16:52:14 +0000 (16:52 +0000)]
Add:

> * Have SHOW ALL and pg_settings show descriptions for server-side variables(Joe)

21 years agoAdjust the new Norwegian translation for some of the easier message
Peter Eisentraut [Mon, 29 Sep 2003 16:41:33 +0000 (16:41 +0000)]
Adjust the new Norwegian translation for some of the easier message
changes between 7.3 and 7.4, for example quoting and function names.

21 years agoApparently, gettext doesn't like double parentheses around argument. What
Peter Eisentraut [Mon, 29 Sep 2003 16:39:18 +0000 (16:39 +0000)]
Apparently, gettext doesn't like double parentheses around argument.  What
were they doing here anyway?