]> granicus.if.org Git - taglib/log
taglib
21 years agoSeveral optimizations that came from KCacheGrind / calltree fun.
Scott Wheeler [Wed, 7 Apr 2004 06:00:05 +0000 (06:00 +0000)]
Several optimizations that came from KCacheGrind / calltree fun.
Basically they fall into the categories:
- Don't convert things before you need to
- When you do, use more effecient copy constructors / assignment operators
  (i.e. when copying prefer memcpy to a for loop and when that's not possible
  use an iterator instead of operator[])

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdding Ogg/FLAC support to TagLib
Allan Sandfeld Jensen [Tue, 6 Apr 2004 20:35:29 +0000 (20:35 +0000)]
Adding Ogg/FLAC support to TagLib

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301825 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoChanging the API to something more flexible (And needed for Ogg/FLAC)
Allan Sandfeld Jensen [Tue, 6 Apr 2004 20:34:28 +0000 (20:34 +0000)]
Changing the API to something more flexible (And needed for Ogg/FLAC)

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301824 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoversion 1.1
Scott Wheeler [Sun, 4 Apr 2004 21:36:38 +0000 (21:36 +0000)]
version 1.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd the ability to override the default ID3v1 string handling in TagLib by
Scott Wheeler [Sun, 4 Apr 2004 14:42:13 +0000 (14:42 +0000)]
Add the ability to override the default ID3v1 string handling in TagLib by
adding a ID3v1::StringHandler class that has render and parse methods.

By default this still makes the (correct) assumption that ID3v1 tags contain
ISO-8859-1 data, but this makes it easy for applications to override this to
allow user specified codecs.

CCMAIL:78428@bugs.kde.org
CCMAIL:77710@bugs.kde.org
CCMAIL:amarok-devel@lists.sourceforge.net
CCMAIL:Shlomi Loubaton <loubaton.shlomi@012.net.il>
CCMAIL:Nir Misgav <misgav@ee.bgu.ac.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301244 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAfter making a simple enough test-case for Scott I was able to find the bug
Allan Sandfeld Jensen [Sat, 3 Apr 2004 16:20:11 +0000 (16:20 +0000)]
After making a simple enough test-case for Scott I was able to find the bug
myself.

Beware of the presedence of & !!

CCMAIL:wheeler@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a constructor that takes an ID3v2::FrameFactory.
Scott Wheeler [Tue, 30 Mar 2004 13:50:26 +0000 (13:50 +0000)]
Add a constructor that takes an ID3v2::FrameFactory.

CCMAIL:Jonathan Giannuzzi <psyduck@altern.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299846 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT another nitpick
Scott Wheeler [Tue, 30 Mar 2004 13:45:24 +0000 (13:45 +0000)]
CVS_SILENT another nitpick

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299843 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoI like it more like this...
Scott Wheeler [Tue, 30 Mar 2004 13:12:18 +0000 (13:12 +0000)]
I like it more like this...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299835 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoThe explicit is silly here since it takes two arguments (it's leftover from
Scott Wheeler [Tue, 16 Mar 2004 18:51:16 +0000 (18:51 +0000)]
The explicit is silly here since it takes two arguments (it's leftover from
when this used to have a default argument).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@296374 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years ago- ByteVector::operator> seemed flawed to me
Frerich Raabe [Wed, 10 Mar 2004 13:06:14 +0000 (13:06 +0000)]
- ByteVector::operator> seemed flawed to me

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@294934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoUse memcmp() and memcpy() where appropriate rather than slower loop based
Scott Wheeler [Fri, 5 Mar 2004 15:59:00 +0000 (15:59 +0000)]
Use memcmp() and memcpy() where appropriate rather than slower loop based
methods.  Here this improves tag reading speed by about 50%.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@293774 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoHmm, not good -- missing "ref" here so that the reference count wasn't
Scott Wheeler [Sun, 29 Feb 2004 20:02:18 +0000 (20:02 +0000)]
Hmm, not good -- missing "ref" here so that the reference count wasn't
being incremented on copy.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@292618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoFix String::data() for UTF16 -- there was a missing break in the case
Scott Wheeler [Sun, 22 Feb 2004 12:51:32 +0000 (12:51 +0000)]
Fix String::data() for UTF16 -- there was a missing break in the case
statement, so both the UTF16 and the UTF16BE versions were being executed.

CCMAIL:Ilya Konstantinov <future@shiny.co.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@290210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops, forgot a break...
Scott Wheeler [Fri, 20 Feb 2004 11:42:14 +0000 (11:42 +0000)]
Oops, forgot a break...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdded a translation table between ID3v2.2 frame names and ID3v2.4. TagLib
Scott Wheeler [Fri, 20 Feb 2004 11:40:44 +0000 (11:40 +0000)]
Added a translation table between ID3v2.2 frame names and ID3v2.4.  TagLib
now supports ID3v2.2 through ID3v2.4.

CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289656 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT oops -- didn't mean to check this in
Scott Wheeler [Fri, 20 Feb 2004 01:42:10 +0000 (01:42 +0000)]
CVS_SILENT oops -- didn't mean to check this in

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289568 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoMostly get ID3v2.2 working. Sure, it's a standard from 1998 that was
Scott Wheeler [Fri, 20 Feb 2004 01:41:25 +0000 (01:41 +0000)]
Mostly get ID3v2.2 working.  Sure, it's a standard from 1998 that was
replaced in 1999, but apparently iTunes still uses it.

This gets the frame parsing code to support 2.2 and required deprecating
a couple of methods so that an ID3v2 version could be passed along.

There still needs to be a translation table added to handle converting
ID3v2.2 frame names to their ID3v2.4 equivalents, but that can come later.
For now the framelister program from the examples dir is able to read all
of the text frames.

CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289567 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a couple of testcases that point out UTF16 bugs.
Scott Wheeler [Tue, 17 Feb 2004 02:56:10 +0000 (02:56 +0000)]
Add a couple of testcases that point out UTF16 bugs.

CCMAIL:Ilya Konstantinov <future@shiny.co.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoFixed problem with TagLib reading 1 byte fields in ID3v2 tags.
Scott Wheeler [Tue, 17 Feb 2004 02:11:05 +0000 (02:11 +0000)]
Fixed problem with TagLib reading 1 byte fields in ID3v2 tags.

CCMAIL:Stefan Gehn <sgehn@gmx.net>
CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoThis commit was manufactured by cvs2svn to accommodate
Scott Wheeler [Tue, 17 Feb 2004 02:11:05 +0000 (02:11 +0000)]
This commit was manufactured by cvs2svn to accommodate
a server-side copy/move.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288617 283d02a7-25f6-0310-bc7c-ecb5cbfe19da