]>
granicus.if.org Git - llvm/log
Xin Tong [Tue, 21 Feb 2017 19:10:58 +0000 (19:10 +0000)]
[LoopSimplify] Simplify how we compute UniqueExit
Summary: Simplify how we compute UniqueExit. Reuse ExitBlockSet.
Reviewers: sanjoy, efriedma, hfinkel
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D30182
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295751
91177308 -0d34-0410-b5e6-
96231b3b80d8
Xin Tong [Tue, 21 Feb 2017 19:08:03 +0000 (19:08 +0000)]
More comments for getUniqueExitBlocks. NFCI
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295750
91177308 -0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Tue, 21 Feb 2017 19:03:15 +0000 (19:03 +0000)]
Teach the IR verifier to reject conflicting debug info for function arguments.
Conflicting debug info for function arguments causes hard-to-debug
assertions in the DWARF backend, so the Verifier should reject it.
For performance reasons this only checks function arguments from
non-inlined debug intrinsics for now.
rdar://problem/
30520286
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295749
91177308 -0d34-0410-b5e6-
96231b3b80d8
Geoff Berry [Tue, 21 Feb 2017 18:53:14 +0000 (18:53 +0000)]
[CodeGenPrepare] Sink and duplicate more 'and' instructions.
Summary:
Rework the code that was sinking/duplicating (icmp and, 0) sequences
into blocks where they were being used by conditional branches to form
more tbz instructions on AArch64. The new code is more general in that
it just looks for 'and's that have all icmp 0's as users, with a target
hook used to select which subset of 'and' instructions to consider.
This change also enables 'and' sinking for X86, where it is more widely
beneficial than on AArch64.
The 'and' sinking/duplicating code is moved into the optimizeInst phase
of CodeGenPrepare, where it can take advantage of the fact the
OptimizeCmpExpression has already sunk/duplicated any icmps into the
blocks where they are used. One minor complication from this change is
that optimizeLoadExt needed to be updated to always mark 'and's it has
determined should be in the same block as their feeding load in the
InsertedInsts set to avoid an infinite loop of hoisting and sinking the
same 'and'.
This change fixes a regression on X86 in the tsan runtime caused by
moving GVNHoist to a later place in the optimization pipeline (see
PR31382).
Reviewers: t.p.northover, qcolombet, MatzeB
Subscribers: aemerson, mcrosier, sebpop, llvm-commits
Differential Revision: https://reviews.llvm.org/D28813
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295746
91177308 -0d34-0410-b5e6-
96231b3b80d8
Wei Ding [Tue, 21 Feb 2017 18:48:01 +0000 (18:48 +0000)]
AMDGPU : AMDGPU : Update AMDGPU Trap Handler ABI.
Differential Revision: http://reviews.llvm.org/D29913
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295745
91177308 -0d34-0410-b5e6-
96231b3b80d8
Dmitry Preobrazhensky [Tue, 21 Feb 2017 18:07:07 +0000 (18:07 +0000)]
Test commit
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295740
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 17:42:28 +0000 (17:42 +0000)]
[X86] EltsFromConsecutiveLoads SDLoc argument should be const&.
There appears never to have been a time that the reference was updated.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295739
91177308 -0d34-0410-b5e6-
96231b3b80d8
Vassil Vassilev [Tue, 21 Feb 2017 17:30:43 +0000 (17:30 +0000)]
Do not leak OpenedHandles.
Reviewed by Vedant Kumar (D30178)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295737
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 17:04:11 +0000 (17:04 +0000)]
[X86][AVX512] Update VPBROADCASTQ test to combine from VPERMQ instead of VPERMI2Q.
VPERMI2Q doesn't have shuffle decoding from re-materializable constants.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295736
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 16:45:31 +0000 (16:45 +0000)]
[X86][AVX] Rename shuffle combine tests to show combined shuffle type. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295735
91177308 -0d34-0410-b5e6-
96231b3b80d8
John Brawn [Tue, 21 Feb 2017 16:45:04 +0000 (16:45 +0000)]
[ARM] Correct SP/PC handling in t2MOVr
Add a missing test that I forgot to svn add in my previous commit
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295734
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 16:41:44 +0000 (16:41 +0000)]
[X86][AVX2] Fix VPBROADCASTQ folding on 32-bit targets.
As i64 isn't a value type on 32-bit targets, we need to fold the VZEXT_LOAD into VPBROADCASTQ.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295733
91177308 -0d34-0410-b5e6-
96231b3b80d8
John Brawn [Tue, 21 Feb 2017 16:41:29 +0000 (16:41 +0000)]
[ARM] Correct SP/PC handling in t2MOVr
PC isn't allowed in the source operand of t2MOVr, so change the register class
to one without PC. SP handling is slightly trickier and changes depending on if
we're in ARMv8, so do that in checkTargetMatchPredicate.
Differential Revision: https://reviews.llvm.org/D30199
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295732
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 16:29:28 +0000 (16:29 +0000)]
[X86][AVX2] Add AVX512 test targets to AVX2 shuffle combines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295731
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 16:05:35 +0000 (16:05 +0000)]
[X86][AVX] Add tests showing missed VPBROADCASTQ folding on 32-bit targets.
As i64 isn't a value type on 32-bit targets, we fail to fold the VZEXT_LOAD into VPBROADCASTQ.
Also shows that we're not decoding VPERMIV3 shuffles very well....
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295729
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 15:09:00 +0000 (15:09 +0000)]
[X86][SSE] Prefer to combine shuffles to VZEXT over VZEXT_MOVL.
This matches what is already done during shuffle lowering and helps prevent the need for a zero-vector in cases where shuffles match both patterns.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295723
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 21 Feb 2017 14:51:15 +0000 (14:51 +0000)]
[X86][SSE] Added SSE41 shuffle combining test file.
Currently just contains one case where we combine to VZEXT_MOVL instead of VZEXT which would avoid the need for a zero vector to be generated
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295721
91177308 -0d34-0410-b5e6-
96231b3b80d8
Anna Thomas [Tue, 21 Feb 2017 14:40:28 +0000 (14:40 +0000)]
[InstCombine] Do not exercise nested max/min pattern on abs
Summary:
This is a fix for assertion failure in
`getInverseMinMaxSelectPattern` when ABS is passed in as a select pattern.
We should not be invoking the simplification rule for
ABS(MIN(~ x,y))) or ABS(MAX(~x,y)) combinations.
Added a test case which would cause an assertion failure without the patch.
Reviewers: sanjoy, majnemer
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D30051
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295719
91177308 -0d34-0410-b5e6-
96231b3b80d8
Igor Breger [Tue, 21 Feb 2017 14:01:25 +0000 (14:01 +0000)]
[AVX512] Fix EXTRACT_VECTOR_ELT for v2i1/v4i1/v32i1/v64i1 with variable index.
Differential Revision: https://reviews.llvm.org/D30189
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295718
91177308 -0d34-0410-b5e6-
96231b3b80d8
Alexey Bataev [Tue, 21 Feb 2017 13:40:55 +0000 (13:40 +0000)]
[SLP] Tests for shuffle/blending operations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295717
91177308 -0d34-0410-b5e6-
96231b3b80d8
Diana Picus [Tue, 21 Feb 2017 11:33:59 +0000 (11:33 +0000)]
[ARM] GlobalISel: Lower calls to void() functions
For now, we hardcode a BLX instruction, and generate an ADJCALLSTACKDOWN/UP pair
with amount 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295716
91177308 -0d34-0410-b5e6-
96231b3b80d8
Pavel Labath [Tue, 21 Feb 2017 09:19:41 +0000 (09:19 +0000)]
tablegen: Fix android build
use llvm::to_string instead of std:: version.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295711
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 08:06:08 +0000 (08:06 +0000)]
[X86] Remove ssse3 intrinsic tests from the avx intrinsics test file.
They are all covered by the SSSE3 intrinsics test with SSSE3, AVX, and AVX512 command lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295708
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 08:06:05 +0000 (08:06 +0000)]
[X86] Remove sse4.2 intrinsic tests from the avx intrinsics test file. Fix some other consistency issues.
They are all covered by the SSE4.2 intrinsics test with SSE4.2, AVX, and AVX512 command lines.
Merge sse42.ll into the other intrinsics test. Rename sse42_64.ll to be named like other intrinsic tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295707
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 08:06:02 +0000 (08:06 +0000)]
[X86] Remove sse4.1 intrinsic tests from the avx intrinsics test file.
They are all covered by the SSE4.1 intrinsics test with SSE4.1, AVX, and AVX512 command lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295706
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 08:05:59 +0000 (08:05 +0000)]
[X86] Remove sse3 intrinsic tests from the avx intrinsics test file.
They are all covered by the SSE3 intrinsics test with SSE2, AVX, and AVX512 command lines.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295705
91177308 -0d34-0410-b5e6-
96231b3b80d8
Evgeny Stupachenko [Tue, 21 Feb 2017 07:34:40 +0000 (07:34 +0000)]
The patch introduces new way of narrowing complex (>UINT16 variants) solutions.
The new method introduced under "-lsr-exp-narrow" option (currenlty set to true).
Summary:
The method is based on registers number mathematical expectation and should be
generally closer to optimal solution.
Please see details in comments to
"LSRInstance::NarrowSearchSpaceByDeletingCostlyFormulas()" function
(in lib/Transforms/Scalar/LoopStrengthReduce.cpp).
Reviewers: qcolombet
Differential Revision: http://reviews.llvm.org/D29862
From: Evgeny Stupachenko <evstupac@gmail.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295704
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 07:32:18 +0000 (07:32 +0000)]
[X86] Remove aes intrinsic tests from the avx intrinsics test file.
They are all covered by the AES intrinsics test with a legacy command line and an AVX command line.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295702
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 07:32:14 +0000 (07:32 +0000)]
[X86] Add an AVX command line and regenerate AES intrinsics test using the update_llc_test_checks.py
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295701
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 07:32:11 +0000 (07:32 +0000)]
[X86] Remove sse2 intrinsic tests from the avx intrinsics test file.
They are all covered by the SSE2 intrinsics test with SSE2, AVX, and AVX512 command lines.
Also remove an unneeded lfence intrinsic test since it was already covered.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295700
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 07:32:03 +0000 (07:32 +0000)]
[X86] Remove sse1 intrinsic tests from the avx intrinsics test file.
They are all covered by the SSE intrinsics test with SSE, AVX, and AVX512 command lines.
Also remove an unneeded sfence intrinsic test since it was already covered.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295699
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 06:39:13 +0000 (06:39 +0000)]
[X86] Use SHLD with both inputs from the same register to implement rotate on Sandy Bridge and later Intel CPUs
Summary:
Sandy Bridge and later CPUs have better throughput using a SHLD to implement rotate versus the normal rotate instructions. Additionally it saves one uop and avoids a partial flag update dependency.
This patch implements this change on any Sandy Bridge or later processor without BMI2 instructions. With BMI2 we will use RORX as we currently do.
Reviewers: zvi
Reviewed By: zvi
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D30181
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295697
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 06:27:13 +0000 (06:27 +0000)]
[X86] Fix formatting. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295695
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 04:26:10 +0000 (04:26 +0000)]
[AVX-512] Use sse_load_f32/f64 in place of scalar_to_vector and scalar load in some patterns.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295693
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 04:26:07 +0000 (04:26 +0000)]
[AVX-512] Add test cases showing failure to fold zero extending scalar loads in scalar intrinsics without the peephole pass.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295692
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 21 Feb 2017 04:26:04 +0000 (04:26 +0000)]
[AVX-512] Fix the ExeDomain for vcmpss/vcmpsd.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295691
91177308 -0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Tue, 21 Feb 2017 02:42:42 +0000 (02:42 +0000)]
[ValueTracking] clang-format a section I'm about to touch; NFC
(Whitespace only change)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295690
91177308 -0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Tue, 21 Feb 2017 01:27:33 +0000 (01:27 +0000)]
ScheduleDAG: Cleanup; NFC
- Fix doxygen comments (do not repeat documented name, remove definition
comment if there is already one at the declaration, add \p, ...)
- Add some const modifiers
- Use range based for
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295688
91177308 -0d34-0410-b5e6-
96231b3b80d8
Matthias Braun [Tue, 21 Feb 2017 01:27:29 +0000 (01:27 +0000)]
SubtargetFeature: Cleanup; NFC
- Fix doxygen comments
- Remove duplicated comments
- Remove section comments (which became wrong over time)
- Use more `const` and references but less `auto`
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295687
91177308 -0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Tue, 21 Feb 2017 00:38:44 +0000 (00:38 +0000)]
Add a wrapper around copy_if in STLExtras; NFC
I will add one more use for this in a later change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295685
91177308 -0d34-0410-b5e6-
96231b3b80d8
Taewook Oh [Tue, 21 Feb 2017 00:12:38 +0000 (00:12 +0000)]
[BranchFolding] Update debug location along with the update of branch instruction.
Summary:
Currently, BranchFolder drops DebugLoc for branch instructions in some places. For example, for the test code attached, the branch instruction of 'entry' block has a DILocation of
```
!12 = !DILocation(line: 6, column: 3, scope: !11)
```
, but this information is gone when then block is lowered because BranchFolder misses it. This patch is a fix for this issue.
Reviewers: qcolombet, aprantl, craig.topper, MatzeB
Reviewed By: aprantl
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D29902
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295684
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 23:38:51 +0000 (23:38 +0000)]
[X86] Add additonal check lines to one of the rotate tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295682
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 23:38:48 +0000 (23:38 +0000)]
[X86] FileCheckize one of the rotate tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295681
91177308 -0d34-0410-b5e6-
96231b3b80d8
Sanjoy Das [Mon, 20 Feb 2017 23:37:11 +0000 (23:37 +0000)]
[IndVars] Add an assert
We've already checked that the loop is in simplify form before, but a
little paranoia never hurt anyone.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295680
91177308 -0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Mon, 20 Feb 2017 22:51:42 +0000 (22:51 +0000)]
[IR/Verifier] List the CU we weren't able to find in `llvm.dbg.cu`.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295678
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Mon, 20 Feb 2017 22:26:03 +0000 (22:26 +0000)]
MemorySSA: Add support for renaming uses in the updater.
Summary:
This lets one add aliasing stores to the updater.
(i'm next going to move the creation/etc functions to the updater)
Reviewers: george.burgess.iv
Subscribers: llvm-commits, Prazek
Differential Revision: https://reviews.llvm.org/D30154
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295677
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 19:44:10 +0000 (19:44 +0000)]
[X86] FileCheckize one of the rotate tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295676
91177308 -0d34-0410-b5e6-
96231b3b80d8
Steven Wu [Mon, 20 Feb 2017 18:33:40 +0000 (18:33 +0000)]
Fix use-after-free found by ASAN
DenseMap::lookup returns copy of the value in the map. Returning the
address of the temporary return value will cause use-after-free.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295675
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 17:44:09 +0000 (17:44 +0000)]
[AVX-512] Add a few more patterns for selecting masked vpternlog with broadcast loads where the passthru operand is not operand 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295673
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 16:09:45 +0000 (16:09 +0000)]
[X86] Tidyup combineExtractVectorElt. NFCI.
Pull out repeated code for extraction index operand and source vector value type.
Use isNullConstant helper to check for zero extraction index.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295670
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 15:57:14 +0000 (15:57 +0000)]
[X86][SSE] Regenerate extracted bitcasted constant tests and add 32-bit test target
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295669
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 20 Feb 2017 15:30:43 +0000 (15:30 +0000)]
[globalisel] OperandPredicateMatcher's shouldn't need to generate the MachineOperand expr. NFC
Summary:
Each OperandPredicateMatcher shouldn't need to know how to generate the expression
to reference a MachineOperand. The OperandMatcher should provide it.
In addition to separating responsibilities, this also lays some groundwork for
decoupling source patterns from destination patterns to allow invented operands
or operands provided by GlobalISel's equivalent to the ComplexPattern<> class.
Depends on D29709
Reviewers: t.p.northover, ab, rovka, qcolombet, aditya_nandakumar
Reviewed By: ab
Subscribers: dberris, kristof.beyls, llvm-commits, igorb
Differential Revision: https://reviews.llvm.org/D29710
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295668
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 15:20:37 +0000 (15:20 +0000)]
[X86][SSE] Regenerate re-materialized store tests and add 64-bit test target
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295666
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 15:16:43 +0000 (15:16 +0000)]
[X86][SSE] Regenerate vselect widening tests and add 32-bit test target
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295665
91177308 -0d34-0410-b5e6-
96231b3b80d8
Diana Picus [Mon, 20 Feb 2017 14:45:58 +0000 (14:45 +0000)]
[ARM] GlobalISel: Don't select atomic loads
There used to be a check in the IRTranslator that prevented us from having to
deal with atomic loads/stores. That check has been removed in r294993 and the
AArch64 backend was updated accordingly. This commit does the same thing for the
ARM backend.
In general, in the ARM backend we introduce fences during the atomic expand
pass, so we don't have to worry about atomics, *except* for the 32-bit ARMv8
target, which handles atomics more like AArch64. Since we don't want to worry
about that yet, just bail out of instruction selection if we find any atomic
loads.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295662
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Sanders [Mon, 20 Feb 2017 14:31:27 +0000 (14:31 +0000)]
[globalisel] Separate the SelectionDAG importer from the emitter. NFC
Summary:
In the near future the rules will be sorted between these two steps to
ensure that more important rules are not prevented by less important ones.
Reviewers: t.p.northover, ab, rovka, qcolombet, aditya_nandakumar
Reviewed By: ab
Subscribers: dberris, kristof.beyls, llvm-commits
Differential Revision: https://reviews.llvm.org/D29709
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295661
91177308 -0d34-0410-b5e6-
96231b3b80d8
Igor Breger [Mon, 20 Feb 2017 14:16:29 +0000 (14:16 +0000)]
[X86] Fix EXTRACT_VECTOR_ELT with variable index from v32i16 and v64i8 vector.
Its more profitable to go through memory (1 cycles throughput)
than using VMOVD + VPERMV/PSHUFB sequence ( 2/3 cycles throughput) to implement EXTRACT_VECTOR_ELT with variable index.
IACA tool was used to get performace estimation (https://software.intel.com/en-us/articles/intel-architecture-code-analyzer)
For example for var_shuffle_v16i8_v16i8_xxxxxxxxxxxxxxxx_i8 test from vector-shuffle-variable-128.ll I get 26 cycles vs 79 cycles.
Removing the VINSERT node, we don't need it any more.
Differential Revision: https://reviews.llvm.org/D29690
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295660
91177308 -0d34-0410-b5e6-
96231b3b80d8
Alexey Bataev [Mon, 20 Feb 2017 12:41:16 +0000 (12:41 +0000)]
[SLP] Additional test for vectorization of cal/invoke args vectorization
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295657
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 12:16:38 +0000 (12:16 +0000)]
[X86][AVX512] Add support for ASHR v2i64/v4i64 support without VLX
Use v8i64 ASHR instructions if we don't have VLX.
Differential Revision: https://reviews.llvm.org/D28537
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295656
91177308 -0d34-0410-b5e6-
96231b3b80d8
Sanne Wouda [Mon, 20 Feb 2017 12:05:07 +0000 (12:05 +0000)]
[ARM] Add a div regression test for Cortex-M23
Summary:
This file was missed in the commit for Cortex-M23 and Cortex-M33
support. See https://reviews.llvm.org/D29073?id=85814 .
Reviewers: rengolin, javed.absar, samparker
Reviewed By: samparker
Subscribers: llvm-commits, aemerson
Differential Revision: https://reviews.llvm.org/D30162
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295655
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 11:56:43 +0000 (11:56 +0000)]
Strip trailing whitespace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295653
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Mon, 20 Feb 2017 11:55:58 +0000 (11:55 +0000)]
[SelectionDAG] Add scalarization support for ISD::*_EXTEND_VECTOR_INREG opcodes.
Thanks to Mikael Holmén for the initial test case
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295652
91177308 -0d34-0410-b5e6-
96231b3b80d8
Sjoerd Meijer [Mon, 20 Feb 2017 10:57:54 +0000 (10:57 +0000)]
AArch64AsmParser: tablegen the isBranchTarget helper functions
Use tablegen to autogenerate isBranchtarget helper functions. This is a cleanup
that removes almost identical functions that differ only in a few constants.
Differential Revision: https://reviews.llvm.org/D30160
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295649
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Dardis [Mon, 20 Feb 2017 10:53:03 +0000 (10:53 +0000)]
[mips] Add test for mul macro variants
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295648
91177308 -0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 20 Feb 2017 10:07:41 +0000 (10:07 +0000)]
llvm/examples/Kaleidoscope/BuildingAJIT: More fixup corresponding to r295636.
I missed updating them since I just ran check-llvm (with examples) in r295645.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295646
91177308 -0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Mon, 20 Feb 2017 09:56:24 +0000 (09:56 +0000)]
llvm/examples/Kaleidoscope/include/KaleidoscopeJIT.h: Fixup corresponding to r295636.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295645
91177308 -0d34-0410-b5e6-
96231b3b80d8
Ayman Musa [Mon, 20 Feb 2017 08:27:54 +0000 (08:27 +0000)]
[X86][AVX] Extend hasVEX_WPrefix bit to accept WIG value (W Ignore) + update all AVX instructions with the new value.
Add WIG value to all of AVX instructions which ignore the W-bit in their encoding, instead of giving them the default value of 0.
This patch is needed for a follow up work on EVEX2VEX pass (replacing EVEX encoded instructions with their corresponding VEX version when possible).
Differential Revision: https://reviews.llvm.org/D29876
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295643
91177308 -0d34-0410-b5e6-
96231b3b80d8
Alexey Bataev [Mon, 20 Feb 2017 08:04:11 +0000 (08:04 +0000)]
[SLP] nullptr'ize initial value in `findBuildAggregate()`, NFC.
Initial value of V is sett nullptr, as it is not used.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295642
91177308 -0d34-0410-b5e6-
96231b3b80d8
Alexey Bataev [Mon, 20 Feb 2017 07:49:39 +0000 (07:49 +0000)]
[SLP] Rework `findBuildAggregate()` from ercursive form to iterative, NFC.
Reviewers: mkuper
Subscribers: llvm-commits, mzolotukhin
Differential Revision: https://reviews.llvm.org/D30103
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295641
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 07:00:40 +0000 (07:00 +0000)]
[AVX-512] Add more patterns to fold masked VPTERNLOG with load when the passthru isn't operand 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295640
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 07:00:37 +0000 (07:00 +0000)]
[AVX-512] Add tests for missed opportunities to fold masked VPTERNLOG with load when the passthru op isn't operand 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295639
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 07:00:34 +0000 (07:00 +0000)]
[AVX-512] Fix mistake in the immediate swizzle for some of the VPTERNLOG patterns.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295638
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 07:00:31 +0000 (07:00 +0000)]
[AVX-512] Use a better immediate in the VPTERNLOG commuting tests so its easier to spot bad swizzling.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295637
91177308 -0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Mon, 20 Feb 2017 05:45:14 +0000 (05:45 +0000)]
[Orc] Rename ObjectLinkingLayer -> RTDyldObjectLinkingLayer.
The current ObjectLinkingLayer (now RTDyldObjectLinkingLayer) links objects
in-process using MCJIT's RuntimeDyld class. In the near future I hope to add new
object linking layers (e.g. a remote linking layer that links objects in the JIT
target process, rather than the client), so I'm renaming this class to be more
descriptive.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295636
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 02:47:42 +0000 (02:47 +0000)]
[AVX-512] Add more VPTERNLOG patterns to enable folding of broadcast loads that aren't in operand 2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295634
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 00:37:23 +0000 (00:37 +0000)]
[X86] Use memory form of shift right by 1 when the rotl immediate is one less than the operation size.
An earlier commit already did this for the register form.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295626
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 20 Feb 2017 00:37:20 +0000 (00:37 +0000)]
[X86] Add test cases showing missed opportunities to use rotate right by 1 instructions when operation reads/writes memory.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295625
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Sun, 19 Feb 2017 23:26:00 +0000 (23:26 +0000)]
s/REQUIRES: Asserts/REQUIRES: asserts/
Other than this, we consistently use lower case.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295623
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 21:44:35 +0000 (21:44 +0000)]
[AVX-512] Remove AddedComplexity from masked operations. The size of the patterns already increases their priority.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295619
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 21:40:51 +0000 (21:40 +0000)]
[X86] Use peekThroughOneUseBitcasts helper. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295618
91177308 -0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sun, 19 Feb 2017 21:35:41 +0000 (21:35 +0000)]
[X86] Prefer static_cast<> to C-style cast. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295617
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 21:32:15 +0000 (21:32 +0000)]
[AVX-512] Disable peephole optimizations on the VPTERNLOG commute test. Add new patterns to enable isel to fold the loads on it own.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295616
91177308 -0d34-0410-b5e6-
96231b3b80d8
Davide Italiano [Sun, 19 Feb 2017 21:31:14 +0000 (21:31 +0000)]
[AArch64] Prefer static_cast<> to C-style cast. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295615
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 19:40:31 +0000 (19:40 +0000)]
[X86][SSE] Use getTargetConstantBitsFromNode to find zeroable shuffle elements.
Replaces existing approach that could only search BUILD_VECTOR nodes.
Requires getTargetConstantBitsFromNode to discriminate cases with all/partial UNDEF bits in each element - this should also be useful when we get around to supporting getTargetShuffleMaskIndices with UNDEF elements.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295613
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 19:36:58 +0000 (19:36 +0000)]
[AVX-512] Add patterns to recognize masked vpternlog when the passthrough operand is not operand 0.
This uses a SDNodeXForm to swizzle the appropriate immediate bits to allow this to be matched.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295612
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 19:36:54 +0000 (19:36 +0000)]
[AVX-512] Add test cases that show failure to select masked VPTERNLOG when a select is used to force the passthru operand to be not operand 0.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295611
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 17:19:38 +0000 (17:19 +0000)]
[X86][SSE] Enable initial support for domain crossing at high shuffle combine depths.
As discussed on D27692, this permits another domain to be used to combine a shuffle at high depths.
We currently set the required depth at 4 or more combined shuffles, this is probably too high for most targets but is a good starting point and already helps avoid a number of costly variable shuffles.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295608
91177308 -0d34-0410-b5e6-
96231b3b80d8
Artyom Skrobov [Sun, 19 Feb 2017 16:56:18 +0000 (16:56 +0000)]
Remove redundant call to GluedNodes.back() [NFC]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295607
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 15:15:40 +0000 (15:15 +0000)]
[X86][SSE] Generalize INSERTPS/SHUFPS/SHUFPD combines across domains.
Relax the INSERTPS/SHUFPS/SHUFPD combines to support integer inputs if permitted.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295606
91177308 -0d34-0410-b5e6-
96231b3b80d8
Igor Kudrin [Sun, 19 Feb 2017 14:26:52 +0000 (14:26 +0000)]
[llvm-cov] Respect Windows line endings when parsing demangled symbols.
Differential Revision: https://reviews.llvm.org/D30096
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295605
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 14:12:25 +0000 (14:12 +0000)]
[X86][SSE] Add domain crossing support for target shuffle combines.
Add the infrastructure to flag whether float and/or int domains are permitable.
A future patch will enable domain crossing based off shuffle depth and the value types of the source vectors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295604
91177308 -0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Sun, 19 Feb 2017 12:32:44 +0000 (12:32 +0000)]
Removed extra ';'
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295603
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 08:03:26 +0000 (08:03 +0000)]
[AVX-512] Add broadcast VPTERNLOG instructions to special case commuting switch.
The instructions are marked commutable, but without special handling we don't get the immediate correct.
While here also remove the masked memory forms that aren't commutable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295602
91177308 -0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 19 Feb 2017 08:03:23 +0000 (08:03 +0000)]
[AVX-512] Add patterns to show missed opportunities for folding vpternlog with broadcast loads. Also demonstrates a bug in the commuting of broadcast vpternlog instructions when we are able to select them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295601
91177308 -0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sun, 19 Feb 2017 06:51:46 +0000 (06:51 +0000)]
Untabify.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295599
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Sun, 19 Feb 2017 06:45:02 +0000 (06:45 +0000)]
Re-add debugcounter.ll with Requires: Asserts so that it only triggers when asserts are on
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295598
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Sun, 19 Feb 2017 04:56:07 +0000 (04:56 +0000)]
Which, in turn, causes build bots to fail that have it unexpectedly passing. So remove debugcounter.ll for now
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295597
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Sun, 19 Feb 2017 04:55:02 +0000 (04:55 +0000)]
XFAIL this test until we figure out what to do here, since it will fail if NDEBUG defined
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295596
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Sun, 19 Feb 2017 04:29:50 +0000 (04:29 +0000)]
Add two files lost in rebase, causing build break
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295595
91177308 -0d34-0410-b5e6-
96231b3b80d8
Daniel Berlin [Sun, 19 Feb 2017 04:29:01 +0000 (04:29 +0000)]
Add a DebugCounter for PredicateInfo renaming, and an associated test
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295594
91177308 -0d34-0410-b5e6-
96231b3b80d8