]> granicus.if.org Git - sudo/log
sudo
10 years agoMention I/O plugin changes.
Todd C. Miller [Tue, 26 Aug 2014 19:41:32 +0000 (13:41 -0600)]
Mention I/O plugin changes.

10 years agoChange behavior when plugin I/O logging function returns 0 or -1.
Todd C. Miller [Tue, 26 Aug 2014 18:07:57 +0000 (12:07 -0600)]
Change behavior when plugin I/O logging function returns 0 or -1.
For -1 (error) return, we now kill the command and disable
the I/O logging function that returned the error.
For a 0 (reject) return, we no longer display the rejected
output to the user's terminal.  The plugin API revision is now 1.6.

10 years agoregen to fix version.
Todd C. Miller [Tue, 26 Aug 2014 18:05:09 +0000 (12:05 -0600)]
regen to fix version.

10 years agoAdd trivial dirty word check to the sample output logging function.
Todd C. Miller [Tue, 26 Aug 2014 18:04:25 +0000 (12:04 -0600)]
Add trivial dirty word check to the sample output logging function.

10 years agoUpdate for 1.8.11b2
Todd C. Miller [Mon, 25 Aug 2014 19:05:38 +0000 (13:05 -0600)]
Update for 1.8.11b2

10 years agoFix restoration of effective uid/gid in command_details.
Todd C. Miller [Mon, 25 Aug 2014 17:30:03 +0000 (11:30 -0600)]
Fix restoration of effective uid/gid in command_details.
This masked the effects an unset (really zero) egid.
Bug 656

10 years agoSet runas egid to the same value as runas gid if egid not specified
Todd C. Miller [Mon, 25 Aug 2014 17:27:30 +0000 (11:27 -0600)]
Set runas egid to the same value as runas gid if egid not specified
by the plugin.  Only affects new files created by sudoedit.  Bug #656

10 years agoDon't leak temp fd in sudo_edit_copy_tfiles().
Todd C. Miller [Mon, 25 Aug 2014 16:42:59 +0000 (10:42 -0600)]
Don't leak temp fd in sudo_edit_copy_tfiles().
Fix fd leak in error path in sudo_edit_copy_tfiles().

10 years agofix typo
Todd C. Miller [Fri, 22 Aug 2014 21:23:42 +0000 (15:23 -0600)]
fix typo

10 years agoWe write an unsigned char, not an int, to the signal pipe.
Todd C. Miller [Fri, 22 Aug 2014 17:06:05 +0000 (11:06 -0600)]
We write an unsigned char, not an int, to the signal pipe.

10 years agoSprinkle some debugging around uid/gid setting in sudoedit.
Todd C. Miller [Thu, 21 Aug 2014 21:42:35 +0000 (15:42 -0600)]
Sprinkle some debugging around uid/gid setting in sudoedit.

10 years agoMake sudoedit work with SELinux RBAC.
Todd C. Miller [Thu, 21 Aug 2014 21:28:36 +0000 (15:28 -0600)]
Make sudoedit work with SELinux RBAC.
Adapted from RedHat patches (Daniel Kopecek) but made to behave a
bit more like the non-SELinux bits.

10 years agoRefactor code that copies temp files into separate functions.
Todd C. Miller [Thu, 21 Aug 2014 21:28:35 +0000 (15:28 -0600)]
Refactor code that copies temp files into separate functions.

10 years agoFix typo, .em should be .Em
Todd C. Miller [Thu, 21 Aug 2014 15:23:34 +0000 (09:23 -0600)]
Fix typo, .em should be .Em

10 years agoAdd missing call to initprogname().
Todd C. Miller [Mon, 18 Aug 2014 22:46:55 +0000 (16:46 -0600)]
Add missing call to initprogname().

10 years agoDon't recurse infinitely until we blow the stack when the debug
Todd C. Miller [Mon, 18 Aug 2014 22:35:58 +0000 (16:35 -0600)]
Don't recurse infinitely until we blow the stack when the debug
file can't be opened in the front-end.  The conversation-type debug
mode will be removed in the future.

10 years agoOnly use the first two digits of the version number.
Todd C. Miller [Fri, 15 Aug 2014 22:46:24 +0000 (16:46 -0600)]
Only use the first two digits of the version number.
Fixes a problem on RHEL 7 which has version numbers like 7.0.1406

10 years agoFix return value when kernel has no audit support.
Todd C. Miller [Fri, 15 Aug 2014 21:56:25 +0000 (15:56 -0600)]
Fix return value when kernel has no audit support.

10 years agoremove unused label
Todd C. Miller [Fri, 15 Aug 2014 20:37:07 +0000 (14:37 -0600)]
remove unused label

10 years agoUpdate to automake 1.14 (no code changes).
Todd C. Miller [Thu, 14 Aug 2014 22:36:23 +0000 (16:36 -0600)]
Update to automake 1.14 (no code changes).

10 years agoDocument the interaction between sudoers environment handling and
Todd C. Miller [Mon, 11 Aug 2014 17:23:16 +0000 (11:23 -0600)]
Document the interaction between sudoers environment handling and
the pam_env module.

10 years agoDon't allow pam_env to overwrite existing variables when env_reset
Todd C. Miller [Mon, 11 Aug 2014 16:37:08 +0000 (10:37 -0600)]
Don't allow pam_env to overwrite existing variables when env_reset
is disabled unless the variables match the black list and would
normally be removed.  It may just be better to never overwrite when
env_reset is disabled.

10 years agoUpdate year range to include 2014
Todd C. Miller [Sun, 10 Aug 2014 02:46:21 +0000 (20:46 -0600)]
Update year range to include 2014

10 years agoRemove regress .err files in distclean target.
Todd C. Miller [Fri, 8 Aug 2014 20:53:14 +0000 (14:53 -0600)]
Remove regress .err files in distclean target.

10 years agoRemove generated files for linker as part of distclean.
Todd C. Miller [Fri, 8 Aug 2014 20:49:06 +0000 (14:49 -0600)]
Remove generated files for linker as part of distclean.

10 years agoIgnore .out and .err files in lib/util regress
Todd C. Miller [Fri, 8 Aug 2014 20:44:22 +0000 (14:44 -0600)]
Ignore .out and .err files in lib/util regress

10 years agoAdd additional 1.8.11 changes and fix typos.
Todd C. Miller [Fri, 8 Aug 2014 20:33:22 +0000 (14:33 -0600)]
Add additional 1.8.11 changes and fix typos.

10 years agoAvoid building/running the check_symbols test program unless we are
Todd C. Miller [Fri, 8 Aug 2014 17:19:20 +0000 (11:19 -0600)]
Avoid building/running the check_symbols test program unless we are
building a shared sudoers plugin.

10 years agoRemove two instances of -no-fast-install that were missed before.
Todd C. Miller [Fri, 8 Aug 2014 17:07:09 +0000 (11:07 -0600)]
Remove two instances of -no-fast-install that were missed before.

10 years agoAdd --disable-shared-libutil configure option. It may only be used
Todd C. Miller [Fri, 8 Aug 2014 17:03:24 +0000 (11:03 -0600)]
Add --disable-shared-libutil configure option.  It may only be used
in conjunction with the --enable-static-sudoers option.

10 years agoRemove noop man.sed files
Todd C. Miller [Thu, 7 Aug 2014 15:55:12 +0000 (09:55 -0600)]
Remove noop man.sed files
Use full path instead of $@.in when calling config.status with --file=-

10 years agoFix "sudo -C" when we have internal fds to preserve from closefrom().
Todd C. Miller [Thu, 7 Aug 2014 15:38:03 +0000 (09:38 -0600)]
Fix "sudo -C" when we have internal fds to preserve from closefrom().

10 years agoAdd explicit support for matching the full environment string
Todd C. Miller [Wed, 6 Aug 2014 22:45:57 +0000 (16:45 -0600)]
Add explicit support for matching the full environment string
(name=value).  Bash functions may now be preserved for full matches,
but not for name-only matches.

10 years agoIgnore lib/util/util.exp
Todd C. Miller [Tue, 5 Aug 2014 22:07:31 +0000 (16:07 -0600)]
Ignore lib/util/util.exp

10 years agoFix exporting of asprintf/vasprintf symbols.
Todd C. Miller [Wed, 30 Jul 2014 21:47:15 +0000 (15:47 -0600)]
Fix exporting of asprintf/vasprintf symbols.

10 years agoDon't export getaddrinfo symbols if we found the function in a library.
Todd C. Miller [Wed, 30 Jul 2014 21:08:05 +0000 (15:08 -0600)]
Don't export getaddrinfo symbols if we found the function in a library.

10 years agoIt is now sudo_efree() not efree().
Todd C. Miller [Wed, 30 Jul 2014 15:46:48 +0000 (09:46 -0600)]
It is now sudo_efree() not efree().
Don't try to free a pointer to garbage on error.

10 years agoRegen .pot files
Todd C. Miller [Wed, 30 Jul 2014 15:37:47 +0000 (09:37 -0600)]
Regen .pot files

10 years agoPlug memory leak, even though we are headed for exit.
Todd C. Miller [Wed, 30 Jul 2014 01:33:55 +0000 (19:33 -0600)]
Plug memory leak, even though we are headed for exit.

10 years agoIf getaddrinfo() is missing libsudoutil may need to pull in networking
Todd C. Miller [Tue, 29 Jul 2014 19:06:18 +0000 (13:06 -0600)]
If getaddrinfo() is missing libsudoutil may need to pull in networking
libraries.

10 years agoOnly include functions in util.exp that are actually in the library.
Todd C. Miller [Tue, 29 Jul 2014 16:52:43 +0000 (10:52 -0600)]
Only include functions in util.exp that are actually in the library.
Fixes a problem on Solaris where undefined functions that are listed
as exported in the map file result in a link error.
Also make sure we use our glob.c if the system is missing glob().

10 years agoMake sure shadow libs don't end up in LIBS, only SUDOERS_LIBS (and
Todd C. Miller [Tue, 29 Jul 2014 15:30:25 +0000 (09:30 -0600)]
Make sure shadow libs don't end up in LIBS, only SUDOERS_LIBS (and
SUDO_LIBS if set_auth_parameters() or initprivs() are present.

10 years agoNo need to AC_SUBST HAVE_BSM_AUDIT and HAVE_SOLARIS_AUDIT
Todd C. Miller [Tue, 29 Jul 2014 15:25:07 +0000 (09:25 -0600)]
No need to AC_SUBST HAVE_BSM_AUDIT and HAVE_SOLARIS_AUDIT

10 years agoAttempt to handle systems with SA_SIGINFO but that lack SI_USER.
Todd C. Miller [Tue, 29 Jul 2014 02:25:46 +0000 (20:25 -0600)]
Attempt to handle systems with SA_SIGINFO but that lack SI_USER.

10 years agoReplace use of HAVE_GETCWD with PREFER_PORTABLE_GETCWD.
Todd C. Miller [Mon, 28 Jul 2014 22:36:43 +0000 (16:36 -0600)]
Replace use of HAVE_GETCWD with PREFER_PORTABLE_GETCWD.
It is safe to assume getcwd() exists, we just need to handle broken ones.

10 years agoAdd check for inet_ntoa() since it may live in libnsl.
Todd C. Miller [Mon, 28 Jul 2014 22:11:39 +0000 (16:11 -0600)]
Add check for inet_ntoa() since it may live in libnsl.
Make getcwd() replacement private to the SunOS 4 section.

10 years agoAvoid mixing declarations and code for non-C99 compilers.
Todd C. Miller [Mon, 28 Jul 2014 21:21:44 +0000 (15:21 -0600)]
Avoid mixing declarations and code for non-C99 compilers.

10 years agoFor C89, use "const char __func__[]" instead of "const char *__func__".
Todd C. Miller [Mon, 28 Jul 2014 21:01:48 +0000 (15:01 -0600)]
For C89, use "const char __func__[]" instead of "const char *__func__".

10 years agoFix compilation on systems w/o netgroups.
Todd C. Miller [Mon, 28 Jul 2014 12:22:52 +0000 (06:22 -0600)]
Fix compilation on systems w/o netgroups.

10 years agoBack out old workaround for sudoedit hang when debugging was enabled.
Todd C. Miller [Sat, 26 Jul 2014 12:07:34 +0000 (06:07 -0600)]
Back out old workaround for sudoedit hang when debugging was enabled.

10 years agoDon't memcpy() the preserved_fds TAILQ as the pointers into the
Todd C. Miller [Sat, 26 Jul 2014 12:06:18 +0000 (06:06 -0600)]
Don't memcpy() the preserved_fds TAILQ as the pointers into the
head will be wrong.  All we need to do is save the old command
details and restore them after calling run_command().  Fixes a hang
with sudoedit when debugging is enabled.

10 years agoThe default policy close function should only print an error message
Todd C. Miller [Fri, 25 Jul 2014 23:07:23 +0000 (17:07 -0600)]
The default policy close function should only print an error message
if the error_code is non-zero.

10 years agoIf there the preserved fds list is empty, add a new element with
Todd C. Miller [Fri, 25 Jul 2014 23:00:10 +0000 (17:00 -0600)]
If there the preserved fds list is empty, add a new element with
TAILQ_INSERT_HEAD instead of TAILQ_INSERT_TAIL to avoid an infinite
loop on AIX, Solaris and possibly others when debug mode is active.

10 years agoRemove support for getting program name via /proc as pr_fname is
Todd C. Miller [Fri, 25 Jul 2014 20:08:59 +0000 (14:08 -0600)]
Remove support for getting program name via /proc as pr_fname is
usually filled in after symbolic links have been processed, even
on Solaris.

10 years agoUse shlib_enable instead of soext when determining whether to install
Todd C. Miller [Fri, 25 Jul 2014 20:08:50 +0000 (14:08 -0600)]
Use shlib_enable instead of soext when determining whether to install
the library.

10 years agoAvoid potential division by zero
Todd C. Miller [Fri, 25 Jul 2014 20:07:39 +0000 (14:07 -0600)]
Avoid potential division by zero

10 years agoDon't link progname test with libsudo_util, just link in progname.lo
Todd C. Miller [Fri, 25 Jul 2014 20:07:09 +0000 (14:07 -0600)]
Don't link progname test with libsudo_util, just link in progname.lo
directly since that is all we need.  Avoid a linker issue on darwin.

10 years agoRemove pstat_getproc() path as pst_ucomm on HP-UX will return the
Todd C. Miller [Fri, 25 Jul 2014 15:42:41 +0000 (09:42 -0600)]
Remove pstat_getproc() path as pst_ucomm on HP-UX will return the
target of a symbolic link and not the name of the link itself.
Avoid using pr_fname on AIX for the same reason.
Bug 654

10 years agoAdd test for getprogname() and symbolic links; bug 654
Todd C. Miller [Fri, 25 Jul 2014 15:37:58 +0000 (09:37 -0600)]
Add test for getprogname() and symbolic links; bug 654

10 years agoDocument tracing
Todd C. Miller [Thu, 24 Jul 2014 20:39:50 +0000 (14:39 -0600)]
Document tracing

10 years agosudo_term_{erase,kill} are regular symbols not functions.
Todd C. Miller [Wed, 23 Jul 2014 23:06:33 +0000 (17:06 -0600)]
sudo_term_{erase,kill} are regular symbols not functions.

10 years agoFix NULL deref if base64_decode returns -1.
Todd C. Miller [Tue, 22 Jul 2014 20:53:15 +0000 (14:53 -0600)]
Fix NULL deref if base64_decode returns -1.

10 years agoRename missing.h -> sudo_compat.h
Todd C. Miller [Tue, 22 Jul 2014 20:25:16 +0000 (14:25 -0600)]
Rename missing.h -> sudo_compat.h

10 years agoMerge secure_path.h -> sudo_util.h
Todd C. Miller [Tue, 22 Jul 2014 17:37:39 +0000 (11:37 -0600)]
Merge secure_path.h -> sudo_util.h

10 years agoVersion the functions in libsudo_util
Todd C. Miller [Tue, 22 Jul 2014 17:26:17 +0000 (11:26 -0600)]
Version the functions in libsudo_util

10 years agoRename gettext.h -> sudo_gettext.h
Todd C. Miller [Mon, 21 Jul 2014 20:49:43 +0000 (14:49 -0600)]
Rename gettext.h -> sudo_gettext.h

10 years agoRename fatal.h -> sudo_fatal.h
Todd C. Miller [Mon, 21 Jul 2014 20:40:18 +0000 (14:40 -0600)]
Rename fatal.h -> sudo_fatal.h

10 years agoRename queue.h -> sudo_queue.h to avoid collisions with the system
Todd C. Miller [Mon, 21 Jul 2014 20:37:27 +0000 (14:37 -0600)]
Rename queue.h -> sudo_queue.h to avoid collisions with the system
version.

10 years agoConver sudo_debug_write() to a macro
Todd C. Miller [Mon, 21 Jul 2014 15:13:47 +0000 (09:13 -0600)]
Conver sudo_debug_write() to a macro

10 years agoFix man page post-processing; it was deleting more than intended.
Todd C. Miller [Thu, 17 Jul 2014 14:40:26 +0000 (08:40 -0600)]
Fix man page post-processing; it was deleting more than intended.

10 years agoRemove double $(srcdir) when running sed scripts.
Todd C. Miller [Wed, 16 Jul 2014 22:37:16 +0000 (16:37 -0600)]
Remove double $(srcdir) when running sed scripts.

10 years ago"an EXEC tag" not "a EXEC tag"
Todd C. Miller [Wed, 16 Jul 2014 21:44:21 +0000 (15:44 -0600)]
"an EXEC tag" not "a EXEC tag"

10 years agoDocument that I/O logging is not enabled by default.
Todd C. Miller [Wed, 16 Jul 2014 21:38:52 +0000 (15:38 -0600)]
Document that I/O logging is not enabled by default.

10 years agoDocument that exec_background is off by default.
Todd C. Miller [Wed, 16 Jul 2014 21:25:41 +0000 (15:25 -0600)]
Document that exec_background is off by default.

10 years agoError out if sesh is run as a login shell but the shell it needs
Todd C. Miller [Mon, 14 Jul 2014 15:56:38 +0000 (09:56 -0600)]
Error out if sesh is run as a login shell but the shell it needs
to run has no slash.  This shouldn't happen in practice.

10 years agoMove mksiglist.h and mksigname.h to lib/util where they belong.
Todd C. Miller [Mon, 14 Jul 2014 15:46:17 +0000 (09:46 -0600)]
Move mksiglist.h and mksigname.h to lib/util where they belong.

10 years agoAvoid passing -no-fast-install to libtool as this results in the
Todd C. Miller [Mon, 14 Jul 2014 15:08:50 +0000 (09:08 -0600)]
Avoid passing -no-fast-install to libtool as this results in the
build dir being left in the library path of the installed executable.
Instead, we remove the "lt-" prefix from the program name in
initprogname() so that the regress test output is unaffected by
libtool's binary wrapper.

10 years agoFix syntax error with some shells.
Todd C. Miller [Mon, 14 Jul 2014 12:32:21 +0000 (06:32 -0600)]
Fix syntax error with some shells.

10 years agoForce libtool to use runtime linking on AIX so that it installs the
Todd C. Miller [Mon, 14 Jul 2014 02:14:02 +0000 (20:14 -0600)]
Force libtool to use runtime linking on AIX so that it installs the
plugins as .so files and not .a files.

10 years agoBe sure to NUL-terminate the decoded secret when converting from
Todd C. Miller [Sun, 13 Jul 2014 21:23:32 +0000 (15:23 -0600)]
Be sure to NUL-terminate the decoded secret when converting from
base64.

10 years agoFix a pointer signednes warning calling base64_decode().
Todd C. Miller [Sun, 13 Jul 2014 20:27:20 +0000 (14:27 -0600)]
Fix a pointer signednes warning calling base64_decode().

10 years agoUse sudo_strtoid() now that it is located in the same library.
Todd C. Miller [Sun, 13 Jul 2014 13:09:00 +0000 (07:09 -0600)]
Use sudo_strtoid() now that it is located in the same library.

10 years agoSkip leading space (ala strtol) so that we can pick up the sign
Todd C. Miller [Sun, 13 Jul 2014 13:08:12 +0000 (07:08 -0600)]
Skip leading space (ala strtol) so that we can pick up the sign
even if it is not the first character of the string.

10 years agoFor sudoedit, audit the actual editor being run, not just the
Todd C. Miller [Sat, 12 Jul 2014 16:35:00 +0000 (10:35 -0600)]
For sudoedit, audit the actual editor being run, not just the
sudoedit command.

10 years agoAudit failed user role changes. RedHat bz #665131
Todd C. Miller [Sat, 12 Jul 2014 16:04:19 +0000 (10:04 -0600)]
Audit failed user role changes.  RedHat bz #665131

10 years agoAvoid running check_symbols for static sudoers
Todd C. Miller [Sat, 12 Jul 2014 15:16:36 +0000 (09:16 -0600)]
Avoid running check_symbols for static sudoers

10 years agoAdapt to unused alias changes.
Todd C. Miller [Sat, 12 Jul 2014 14:54:52 +0000 (08:54 -0600)]
Adapt to unused alias changes.

10 years agoAn unused alias is not really an error, even in strict mode.
Todd C. Miller [Sat, 12 Jul 2014 13:30:18 +0000 (07:30 -0600)]
An unused alias is not really an error, even in strict mode.
RedHat bz #604297

10 years agoWhen running a login shell via sesh, make new argv[0] -shell, not
Todd C. Miller [Sat, 12 Jul 2014 12:51:00 +0000 (06:51 -0600)]
When running a login shell via sesh, make new argv[0] -shell, not
/path/to-shell.  RedHat bz #1065418

10 years agoThe RHEL sudo package allows users in group wheel to run sudo.
Todd C. Miller [Fri, 11 Jul 2014 21:42:01 +0000 (15:42 -0600)]
The RHEL sudo package allows users in group wheel to run sudo.

10 years agoAvoid packaging parent directories when they are system directories.
Todd C. Miller [Fri, 11 Jul 2014 21:32:17 +0000 (15:32 -0600)]
Avoid packaging parent directories when they are system directories.
Currently we just skip this when prefix is /usr

10 years agoFix typo: sudo.d -> sudoers.d. From RedHat bz #726634
Todd C. Miller [Fri, 11 Jul 2014 17:02:05 +0000 (11:02 -0600)]
Fix typo: sudo.d -> sudoers.d.  From RedHat bz #726634

10 years agoRHEL 6 and above use /etc/sudo-ldap.conf not /etc/ldap.conf
Todd C. Miller [Fri, 11 Jul 2014 16:58:20 +0000 (10:58 -0600)]
RHEL 6 and above use /etc/sudo-ldap.conf not /etc/ldap.conf

10 years agoFor rpm, do not specify a mode in %attr for symbolic links. Avoids
Todd C. Miller [Fri, 11 Jul 2014 16:27:23 +0000 (10:27 -0600)]
For rpm, do not specify a mode in %attr for symbolic links.  Avoids
the warning "Explicit %attr() mode not applicaple to symlink"

10 years agoefree -> sudo_efree for consistency
Todd C. Miller [Thu, 10 Jul 2014 21:35:04 +0000 (15:35 -0600)]
efree -> sudo_efree for consistency

10 years agoregen
Todd C. Miller [Thu, 10 Jul 2014 21:31:54 +0000 (15:31 -0600)]
regen

10 years agoAdd support for base64 secrets in ldap.conf and ldap.secret.
Todd C. Miller [Thu, 10 Jul 2014 21:31:11 +0000 (15:31 -0600)]
Add support for base64 secrets in ldap.conf and ldap.secret.
Based on an idea from anthony AT rlost DOT com

10 years agoDon't use the HP compiler in preference to gcc. Some versions have
Todd C. Miller [Wed, 9 Jul 2014 20:00:08 +0000 (14:00 -0600)]
Don't use the HP compiler in preference to gcc.  Some versions have
trouble compiling lbuf.c.

10 years agoRemove @SOEXT@ and @SHLIB_EXT@ now that we use libtool to install
Todd C. Miller [Wed, 9 Jul 2014 02:19:09 +0000 (20:19 -0600)]
Remove @SOEXT@ and @SHLIB_EXT@ now that we use libtool to install
shared objects.  Instead, use the new @SHLIB_ENABLE@ that is set
to the value of $enable_dlopen.  For sudo_noexec.so there is nothing
special to do since the install-noexec target is only called when
noexec is enabled by configure.

10 years agoMake dynamic shared objects non-writable on HP-UX. Using writable
Todd C. Miller [Tue, 8 Jul 2014 16:03:47 +0000 (10:03 -0600)]
Make dynamic shared objects non-writable on HP-UX.  Using writable
DSOs can substantially increase the load time.