]> granicus.if.org Git - postgresql/log
postgresql
13 years agoAdd collation support on Windows (MSVC build)
Peter Eisentraut [Sat, 9 Apr 2011 21:14:20 +0000 (00:14 +0300)]
Add collation support on Windows (MSVC build)

There is not yet support in initdb to populate the pg_collation
catalog, but if that is done manually, the rest should work.

13 years agoFix ILIKE to honor collation when working in single-byte encodings.
Tom Lane [Sat, 9 Apr 2011 21:12:39 +0000 (17:12 -0400)]
Fix ILIKE to honor collation when working in single-byte encodings.

The original collation patch only fixed the multi-byte code path.
This change also ensures that ILIKE's idea of the case-folding rules
is exactly the same as str_tolower's.

13 years agoRemove collate.linux.utf8.sql's assumptions about ".utf8" in locale names.
Tom Lane [Sat, 9 Apr 2011 20:24:36 +0000 (16:24 -0400)]
Remove collate.linux.utf8.sql's assumptions about ".utf8" in locale names.

Tweak the test so that it does not depend on the platform using ".utf8" as
the extension signifying that a locale uses UTF8 encoding.  For the most
part this just requires using the abbreviated collation names "en_US" etc,
though I had to work a bit harder on the collation creation tests.

This opens the door to using the test on platforms that spell locales
differently, for example ".utf-8" or ".UTF-8".  Also, the test is now
somewhat useful with server encodings other than UTF8; though depending on
which encoding is selected, different subsets of it will fail for lack of
character set support.

13 years agoAdjust collation determination rules as per discussion.
Tom Lane [Sat, 9 Apr 2011 18:40:09 +0000 (14:40 -0400)]
Adjust collation determination rules as per discussion.

Remove crude hack that tried to propagate collation through a
function-returning-record, ie, from the function's arguments to individual
fields selected from its result record.  That is just plain inconsistent,
because the function result is composite and cannot have a collation;
and there's no hope of making this kind of action-at-a-distance work
consistently.  Adjust regression test cases that expected this to happen.

Meanwhile, the behavior of casting to a domain with a declared collation
stays the same as it was, since that seemed to be the consensus.

13 years agoDon't show unusable collations in psql's \dO command.
Tom Lane [Sat, 9 Apr 2011 18:08:41 +0000 (14:08 -0400)]
Don't show unusable collations in psql's \dO command.

"Unusable" collations are those not matching the current database's
encoding.  The former behavior inconsistently showed such collations
some of the time, depending on the details of the pattern argument.

13 years agoLatest consolidated typedef list from buildfarm.
Andrew Dunstan [Sat, 9 Apr 2011 03:11:37 +0000 (23:11 -0400)]
Latest consolidated typedef list from buildfarm.

13 years agoClean up minor collation issues in indxpath.c.
Tom Lane [Fri, 8 Apr 2011 23:19:17 +0000 (19:19 -0400)]
Clean up minor collation issues in indxpath.c.

Get rid of bogus collation test in match_special_index_operator (even for
ILIKE, the pattern match operator's collation doesn't matter here, and even
if it did the test was testing the wrong thing).
Fix broken looping logic in expand_indexqual_rowcompare.
Add collation check in match_clause_to_ordering_op.
Make naming and argument ordering more consistent; improve comments.

13 years agoFix make_greater_string to not have an undocumented collation assumption.
Tom Lane [Fri, 8 Apr 2011 21:39:59 +0000 (17:39 -0400)]
Fix make_greater_string to not have an undocumented collation assumption.

The previous coding worked only if ltproc->fn_collation was always either
DEFAULT_COLLATION_OID or a C-compatible locale.  While that's true at the
moment, it wasn't documented (and in fact wasn't true when this code was
committed...).  But it only takes a couple more lines to make its internal
caching behavior locale-aware, so let's do that.

13 years agoTruncate the predicate lock SLRU to empty, instead of almost empty.
Robert Haas [Fri, 8 Apr 2011 20:51:45 +0000 (16:51 -0400)]
Truncate the predicate lock SLRU to empty, instead of almost empty.

Otherwise, the SLRU machinery can get confused and think that the SLRU
has wrapped around.  Along the way, regardless of whether we're
truncating all of the SLRU or just some of it, flush pages after
truncating, rather than before.

Kevin Grittner

13 years agoTweak collation setup for GIN index comparison functions.
Tom Lane [Fri, 8 Apr 2011 20:48:25 +0000 (16:48 -0400)]
Tweak collation setup for GIN index comparison functions.

Honor index column's collation spec if there is one, don't go to the
expense of calling get_typcollation when we can reasonably assume that
all GIN storage types will use default collation, and be sure to set
a collation for the comparePartialFn too.

13 years agoAvoid an unnecessary syscache lookup in parse_coerce.c.
Tom Lane [Fri, 8 Apr 2011 20:11:04 +0000 (16:11 -0400)]
Avoid an unnecessary syscache lookup in parse_coerce.c.

All the other fields of the constant are being extracted from the syscache
entry we already have, so handle collation similarly.  (There don't seem
to be any other uses for the new function at the moment.)

13 years agoMake psql use pg_table_size instead of pg_relation_size on 9.0+ servers.
Robert Haas [Fri, 8 Apr 2011 19:52:49 +0000 (15:52 -0400)]
Make psql use pg_table_size instead of pg_relation_size on 9.0+ servers.

Per discussion, pg_table_size() is a more helpful number than
pg_relation_size().

Bernd Helmle, reviewed by Susanne Ebrecht and me.

13 years agoFix bug in propagating ALTER TABLE actions to typed tables.
Robert Haas [Fri, 8 Apr 2011 19:44:50 +0000 (15:44 -0400)]
Fix bug in propagating ALTER TABLE actions to typed tables.

We need to propagate such actions to all typed table children of a
given type, not just the first one.

Noah Misch

13 years agoModify initdb to complain only when no usable system locales are found.
Tom Lane [Fri, 8 Apr 2011 19:38:57 +0000 (15:38 -0400)]
Modify initdb to complain only when no usable system locales are found.

Per discussion, the original behavior seems too noisy.  But if things
are so broken that none of the locales reported by "locale -a" are usable,
that's probably worth warning about.

13 years agoPartially roll back overenthusiastic SSI optimization.
Robert Haas [Fri, 8 Apr 2011 19:29:02 +0000 (15:29 -0400)]
Partially roll back overenthusiastic SSI optimization.

When a regular lock is held, SSI can use that in lieu of a predicate lock
to detect rw conflicts; but if the regular lock is being taken by a
subtransaction, we can't assume that it'll commit, so releasing the
parent transaction's lock in that case is a no-no.

Kevin Grittner

13 years agoHave pg_upgrade properly preserve relfrozenxid in toast tables.
Bruce Momjian [Fri, 8 Apr 2011 15:46:34 +0000 (11:46 -0400)]
Have pg_upgrade properly preserve relfrozenxid in toast tables.

This fixes a pg_upgrade bug that could lead to query errors when clog
files are improperly removed.

13 years agoAvoid extra whitespace in the arguments of <indexterm>.
Tom Lane [Fri, 8 Apr 2011 15:36:05 +0000 (11:36 -0400)]
Avoid extra whitespace in the arguments of <indexterm>.

As noted by Thom Brown, this confuses the DocBook index processor; it
fails to merge entries that differ only in whitespace, and sorts them
unexpectedly as well.  Seems like a toolchain bug, but I'm not going to
hold my breath waiting for a fix.

Note: easiest way to find these is to look for double spaces in HTML.index.

13 years agoAdd an example of WITH (UPDATE RETURNING) INSERT to the INSERT ref page.
Tom Lane [Fri, 8 Apr 2011 14:54:03 +0000 (10:54 -0400)]
Add an example of WITH (UPDATE RETURNING) INSERT to the INSERT ref page.

Per a discussion with Gavin Flower.  This barely scratches the surface
of potential WITH (something RETURNING) use cases, of course, but it's
one of the simplest compelling examples I can think of.

13 years agoFix some sloppiness in new PL/python get_source_line() function.
Robert Haas [Fri, 8 Apr 2011 04:30:54 +0000 (00:30 -0400)]
Fix some sloppiness in new PL/python get_source_line() function.

Jan Urbański

13 years agoAvoid use of mixed slash style paths in arguments to xcopy in MSVC builds.
Andrew Dunstan [Fri, 8 Apr 2011 02:17:06 +0000 (22:17 -0400)]
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds.

Some versions of xcopy, notably on Windows 7 don't like it. Backpatch
to 8.3, where we first used xcopy.

13 years agoTweaks for SSI out-of-shared memory behavior.
Robert Haas [Thu, 7 Apr 2011 20:43:39 +0000 (16:43 -0400)]
Tweaks for SSI out-of-shared memory behavior.

If we call hash_search() with HASH_ENTER, it will bail out rather than
return NULL, so it's redundant to check for NULL again in the caller.
Thus, in cases where we believe it's impossible for the hash table to run
out of slots anyway, we can simplify the code slightly.

On the flip side, in cases where it's theoretically possible to run out of
space, we don't want to rely on dynahash.c to throw an error; instead,
we pass HASH_ENTER_NULL and throw the error ourselves if a NULL comes
back, so that we can provide a more descriptive error message.

Kevin Grittner

13 years agoModernize dlopen interface code for FreeBSD and OpenBSD.
Tom Lane [Thu, 7 Apr 2011 19:14:39 +0000 (15:14 -0400)]
Modernize dlopen interface code for FreeBSD and OpenBSD.

Remove the hard-wired assumption that __mips__ (and only __mips__) lacks
dlopen in FreeBSD and OpenBSD.  This assumption is outdated at least for
OpenBSD, as per report from an anonymous 9.1 tester.  We can perfectly well
use HAVE_DLOPEN instead to decide which code to use.

Some other cosmetic adjustments to make freebsd.c, netbsd.c, and openbsd.c
exactly alike.

13 years agoAllow pg_upgrade with PGCLIENTENCODING set
Peter Eisentraut [Thu, 7 Apr 2011 16:22:34 +0000 (19:22 +0300)]
Allow pg_upgrade with PGCLIENTENCODING set

This used to work, but since PGCLIENTENCODING is now a connection
option variable, pg_upgrade would prevent it.

13 years agoFix SortTocFromFile() to cope with lines that are too long for its buffer.
Tom Lane [Thu, 7 Apr 2011 15:40:23 +0000 (11:40 -0400)]
Fix SortTocFromFile() to cope with lines that are too long for its buffer.

The original coding supposed that a dump TOC file could never contain lines
longer than 1K.  The folly of that was exposed by a recent report from
Per-Olov Esgard.  We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.

Back-patch to all supported branches, since it's always been like this.

13 years agoPreserve pg_largeobject_metadata.relfrozenxid in pg_upgrade.
Bruce Momjian [Thu, 7 Apr 2011 13:57:09 +0000 (09:57 -0400)]
Preserve pg_largeobject_metadata.relfrozenxid in pg_upgrade.

This is needed only in 9.1 because only 9.0 had this and no one is
upgrading from a 9.0 beta to 9.0 anymore.  We basically don't backpatch
9.0 beta fixes at this point.

13 years agoSimplify structure of query used to gather database object information
Bruce Momjian [Thu, 7 Apr 2011 10:22:40 +0000 (06:22 -0400)]
Simplify structure of query used to gather database object information
in pg_upgrade.

13 years agoFix collations when we call transformWhereClause from outside the parser.
Tom Lane [Thu, 7 Apr 2011 06:34:57 +0000 (02:34 -0400)]
Fix collations when we call transformWhereClause from outside the parser.

Previous patches took care of assorted places that call transformExpr from
outside the main parser, but I overlooked the fact that some places use
transformWhereClause as a shortcut for transformExpr + coerce_to_boolean.
In particular this broke collation-sensitive index WHERE clauses, as per
report from Thom Brown.  Trigger WHEN and rule WHERE clauses too.

I'm not forcing initdb for this fix, but any affected indexes, triggers,
or rules will need to be dropped and recreated.

13 years agoRevise the API for GUC variable assign hooks.
Tom Lane [Thu, 7 Apr 2011 04:11:01 +0000 (00:11 -0400)]
Revise the API for GUC variable assign hooks.

The previous functions of assign hooks are now split between check hooks
and assign hooks, where the former can fail but the latter shouldn't.
Aside from being conceptually clearer, this approach exposes the
"canonicalized" form of the variable value to guc.c without having to do
an actual assignment.  And that lets us fix the problem recently noted by
Bernd Helmle that the auto-tune patch for wal_buffers resulted in bogus
log messages about "parameter "wal_buffers" cannot be changed without
restarting the server".  There may be some speed advantage too, because
this design lets hook functions avoid re-parsing variable values when
restoring a previous state after a rollback (they can store a pre-parsed
representation of the value instead).  This patch also resolves a
longstanding annoyance about custom error messages from variable assign
hooks: they should modify, not appear separately from, guc.c's own message
about "invalid parameter value".

13 years agoUpdate regression test files for PL/Python traceback patch
Peter Eisentraut [Wed, 6 Apr 2011 20:19:00 +0000 (23:19 +0300)]
Update regression test files for PL/Python traceback patch

13 years agoReplace the confusing exit_nicely() by an atexit/on_exit hook
Peter Eisentraut [Wed, 6 Apr 2011 20:00:44 +0000 (23:00 +0300)]
Replace the confusing exit_nicely() by an atexit/on_exit hook

13 years agoAdd traceback information to PL/Python errors
Peter Eisentraut [Wed, 6 Apr 2011 19:36:06 +0000 (22:36 +0300)]
Add traceback information to PL/Python errors

This mimics the traceback information the Python interpreter prints
with exceptions.

Jan Urbański

13 years agoUpdate key words table for 9.1
Peter Eisentraut [Tue, 5 Apr 2011 21:16:13 +0000 (00:16 +0300)]
Update key words table for 9.1

13 years agoRepair some flakiness in CheckTargetForConflictsIn.
Robert Haas [Tue, 5 Apr 2011 19:16:59 +0000 (15:16 -0400)]
Repair some flakiness in CheckTargetForConflictsIn.

When we release and reacquire SerializableXactHashLock, we must recheck
whether an R/W conflict still needs to be flagged, because it could have
changed under us in the meantime.  And when we release the partition
lock, we must re-walk the list of predicate locks from the beginning,
because our pointer could get invalidated under us.

Bug report #5952 by Yamamoto Takashi.  Patch by Kevin Grittner.

13 years agoChange "Id" to "id" in some SGML tags
Alvaro Herrera [Tue, 5 Apr 2011 18:06:06 +0000 (15:06 -0300)]
Change "Id" to "id" in some SGML tags

Gabriele Bartolini

13 years agoTypo fixes.
Robert Haas [Tue, 5 Apr 2011 16:40:17 +0000 (12:40 -0400)]
Typo fixes.

Erik Rijkers

13 years agoAdd casts from int4 and int8 to numeric.
Robert Haas [Tue, 5 Apr 2011 13:35:43 +0000 (09:35 -0400)]
Add casts from int4 and int8 to numeric.

Joey Adams, per gripe from Ramanujam.  Review by myself and Tom Lane.

13 years agoAvoid assuming there will be only 3 states for synchronous_commit.
Simon Riggs [Mon, 4 Apr 2011 22:23:13 +0000 (23:23 +0100)]
Avoid assuming there will be only 3 states for synchronous_commit.
Also avoid hardcoding the current default state by giving it the name
"on" and replace with a meaningful name that reflects its behaviour.
Coding only, no change in behaviour.

13 years agoCentralise release note items related to recovery and replication
Simon Riggs [Mon, 4 Apr 2011 21:38:43 +0000 (22:38 +0100)]
Centralise release note items related to recovery and replication

13 years agoUpdate comments and credit doc proofreaders
Simon Riggs [Mon, 4 Apr 2011 21:36:09 +0000 (22:36 +0100)]
Update comments and credit doc proofreaders

13 years agoUpdate MSVC toolchain to match SGML entity uppercasing
Alvaro Herrera [Mon, 4 Apr 2011 20:42:42 +0000 (16:42 -0400)]
Update MSVC toolchain to match SGML entity uppercasing

Per Robert Haas

13 years agoMerge synchronous_replication setting into synchronous_commit.
Robert Haas [Mon, 4 Apr 2011 20:13:01 +0000 (16:13 -0400)]
Merge synchronous_replication setting into synchronous_commit.

This means one less thing to configure when setting up synchronous
replication, and also avoids some ambiguity around what the behavior
should be when the settings of these variables conflict.

Fujii Masao, with additional hacking by me.

13 years agoUppercase <!ENTITY> and <!DOCTYPE> tags in SGML source
Alvaro Herrera [Mon, 4 Apr 2011 20:07:53 +0000 (16:07 -0400)]
Uppercase <!ENTITY> and <!DOCTYPE> tags in SGML source

This improves compatibility with external toolchains, such as those used
by some documentation translation tools.

Gabriele Bartolini

13 years agoAdd missing check on invocation of trusted procedures.
Robert Haas [Mon, 4 Apr 2011 17:25:42 +0000 (13:25 -0400)]
Add missing check on invocation of trusted procedures.

KaiGai Kohei

13 years agoInclude pid in pg_lock_status() results even for SIREAD locks.
Robert Haas [Mon, 4 Apr 2011 17:20:18 +0000 (13:20 -0400)]
Include pid in pg_lock_status() results even for SIREAD locks.

Dan Ports

13 years agoDuplicate expansion of "direction" from FETCH's synopsis into MOVE
Alvaro Herrera [Mon, 4 Apr 2011 16:03:41 +0000 (12:03 -0400)]
Duplicate expansion of "direction" from FETCH's synopsis into MOVE

13 years agoRearrange "add column" logic to merge columns at exec time.
Robert Haas [Mon, 4 Apr 2011 01:52:47 +0000 (21:52 -0400)]
Rearrange "add column" logic to merge columns at exec time.

The previous coding set attinhcount too high in some cases, resulting in
an undumpable, undroppable column.  Per bug #5856, reported by Naoya
Anzai.  See also commit 31b6fc06d83c6de3644c8f2921eb7de0eb92fac3, which
fixes a similar bug in ALTER TABLE .. ADD CONSTRAINT.

Patch by Noah Misch.

13 years agoImprove documentation on the range of the numeric data type.
Robert Haas [Sun, 3 Apr 2011 23:56:22 +0000 (19:56 -0400)]
Improve documentation on the range of the numeric data type.

Gianni Ciolli, reviewed by Noah Misch

13 years agoRemove mention of using "man" from the tutorial.
Robert Haas [Sun, 3 Apr 2011 23:49:05 +0000 (19:49 -0400)]
Remove mention of using "man" from the tutorial.

This isn't applicable on Windows, and the internal link to the
psql documentation should be more than sufficient.

Susanne Ebrecht

13 years agoAvoid possible hang during smart shutdown.
Robert Haas [Sun, 3 Apr 2011 23:42:00 +0000 (19:42 -0400)]
Avoid possible hang during smart shutdown.

If a smart shutdown occurs just as a child is starting up, and the
child subsequently becomes a walsender, there is a race condition:
the postmaster might count the exstant backends, determine that there
is one normal backend, and wait for it to die off.  Had the walsender
transition already occurred before the postmaster counted, it would
have proceeded with the shutdown.

To fix this, have each child that transforms into a walsender kick
the postmaster just after doing so, so that the state machine is
certain to advance.

Fujii Masao

13 years agoFix typo in PQconnectStartParams().
Tom Lane [Sat, 2 Apr 2011 22:05:42 +0000 (18:05 -0400)]
Fix typo in PQconnectStartParams().

This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases.  Backpatch to 9.0 where the error was introduced.

Joseph Adams

13 years agoEscape greater than and less than characters in docs.
Heikki Linnakangas [Sat, 2 Apr 2011 14:06:43 +0000 (17:06 +0300)]
Escape greater than and less than characters in docs.

Susanne Ebrecht and me

13 years agoAvoid palloc before CurrentMemoryContext is set up on win32
Magnus Hagander [Fri, 1 Apr 2011 17:58:36 +0000 (19:58 +0200)]
Avoid palloc before CurrentMemoryContext is set up on win32

Instead, write the unconverted output - it will be in the wrong
encoding, but at least we don't crash.

Rushabh Lathia

13 years agoTab completion for COMMENT ON FOREIGN DATA WRAPPER / SERVER.
Robert Haas [Fri, 1 Apr 2011 17:15:49 +0000 (13:15 -0400)]
Tab completion for COMMENT ON FOREIGN DATA WRAPPER / SERVER.

13 years agopg_dump support for comments on FOREIGN DATA WRAPPER and SERVER objects.
Robert Haas [Fri, 1 Apr 2011 15:40:37 +0000 (11:40 -0400)]
pg_dump support for comments on FOREIGN DATA WRAPPER and SERVER objects.

Shigeru Hanada, with some corrections.

13 years agoSupport comments on FOREIGN DATA WRAPPER and SERVER objects.
Robert Haas [Fri, 1 Apr 2011 15:28:28 +0000 (11:28 -0400)]
Support comments on FOREIGN DATA WRAPPER and SERVER objects.

This mostly involves making it work with the objectaddress.c framework,
which does most of the heavy lifting.  In that vein, change
GetForeignDataWrapperOidByName to get_foreign_data_wrapper_oid and
GetForeignServerOidByName to get_foreign_server_oid, to match the
pattern we use for other object types.

Robert Haas and Shigeru Hanada

13 years agoFix compiler warning.
Robert Haas [Fri, 1 Apr 2011 14:35:52 +0000 (10:35 -0400)]
Fix compiler warning.

13 years agoFix two missing spaces in error messages.
Heikki Linnakangas [Fri, 1 Apr 2011 11:41:39 +0000 (14:41 +0300)]
Fix two missing spaces in error messages.

Josh Kupershmidt

13 years agoFix a tiny race condition in predicate locking. Need to hold the lock while
Heikki Linnakangas [Thu, 31 Mar 2011 15:43:23 +0000 (18:43 +0300)]
Fix a tiny race condition in predicate locking. Need to hold the lock while
examining the head of predicate locks list. Also, fix the comment of
RemoveTargetIfNoLongerUsed, it was neglected when we changed the way update
chains are handled.

Kevin Grittner

13 years agoIncrease SHMEM_INDEX_SIZE from 32 to 64. We're currently at 40 entries in
Heikki Linnakangas [Thu, 31 Mar 2011 10:37:01 +0000 (13:37 +0300)]
Increase SHMEM_INDEX_SIZE from 32 to 64. We're currently at 40 entries in
ShmemIndex, so 64 leaves some headroom.

Kevin Grittner

13 years agoDon't leak the temporary PLyProcedure struct we create for inline plpython
Heikki Linnakangas [Thu, 31 Mar 2011 09:37:11 +0000 (12:37 +0300)]
Don't leak the temporary PLyProcedure struct we create for inline plpython
blocks.

Investigation by Jan Urbański, though I didn't use his patch.

13 years agoReword the phrase on zero replication_timeout in the docs.
Heikki Linnakangas [Thu, 31 Mar 2011 07:19:29 +0000 (10:19 +0300)]
Reword the phrase on zero replication_timeout in the docs.

13 years agoImprove error message when WAL ends before reaching end of online backup.
Heikki Linnakangas [Thu, 31 Mar 2011 07:09:49 +0000 (10:09 +0300)]
Improve error message when WAL ends before reaching end of online backup.

13 years agoMention pg_upgrade sets autovacuum_freeze_max_age to maximum.
Bruce Momjian [Wed, 30 Mar 2011 21:45:54 +0000 (17:45 -0400)]
Mention pg_upgrade sets autovacuum_freeze_max_age to maximum.

13 years agoExpand comment on how pg_upgrade is turning off autovacuum.
Bruce Momjian [Wed, 30 Mar 2011 21:36:24 +0000 (17:36 -0400)]
Expand comment on how pg_upgrade is turning off autovacuum.

13 years agoAttempt to unbreak windows builds broken by commit 754baa2.
Andrew Dunstan [Wed, 30 Mar 2011 20:43:31 +0000 (16:43 -0400)]
Attempt to unbreak windows builds broken by commit 754baa2.

13 years agoCheck that we've reached end-of-backup also when we're not performing
Heikki Linnakangas [Wed, 30 Mar 2011 07:36:58 +0000 (10:36 +0300)]
Check that we've reached end-of-backup also when we're not performing
archive recovery.

It's possible to restore an online backup without recovery.conf, by simply
copying all the necessary WAL files to pg_xlog. "pg_basebackup -x" does that
too. That's the use case where this cross-check is useful.

Backpatch to 9.0. We used to do this in earlier versins, but in 9.0 the code
was inadvertently changed so that the check is only performed after archive
recovery.

Fujii Masao.

13 years agoAutomatically terminate replication connections that are idle for more
Heikki Linnakangas [Wed, 30 Mar 2011 07:10:32 +0000 (10:10 +0300)]
Automatically terminate replication connections that are idle for more
than replication_timeout (a new GUC) milliseconds. The TCP timeout is often
too long, you want the master to notice a dead connection much sooner.
People complained about that in 9.0 too, but with synchronous replication
it's even more important to notice dead connections promptly.

Fujii Masao and Heikki Linnakangas

13 years agoAdjust error message, now that we expect other message types than connection
Heikki Linnakangas [Wed, 30 Mar 2011 05:54:28 +0000 (08:54 +0300)]
Adjust error message, now that we expect other message types than connection
close at this point. Fix PQsetnonblocking() comment.

Fujii Masao

13 years agoUpdate SQL features list
Peter Eisentraut [Tue, 29 Mar 2011 20:23:50 +0000 (23:23 +0300)]
Update SQL features list

Feature F692 "Extended collation support" is now also supported.  This
refers to allowing the COLLATE clause anywhere in a column or domain
definition instead of just directly after the type.

Also correct the name of the feature in accordance with the latest SQL
standard.

13 years agoIn pg_upgrade, add C comment about how autovacuum is disabled.
Bruce Momjian [Tue, 29 Mar 2011 15:11:12 +0000 (11:11 -0400)]
In pg_upgrade, add C comment about how autovacuum is disabled.

13 years agoAdd maintainer-check target
Peter Eisentraut [Mon, 28 Mar 2011 19:53:55 +0000 (22:53 +0300)]
Add maintainer-check target

This can do various source code checks that are not appropriate for
either the build or the regression tests.  Currently: duplicate_oids,
SGML syntax and tabs check, NLS syntax check.

13 years agoMake duplicate_oids return nonzero exit status if duplicates were found
Peter Eisentraut [Mon, 28 Mar 2011 19:52:23 +0000 (22:52 +0300)]
Make duplicate_oids return nonzero exit status if duplicates were found

Automatic detection of errors is easier that way.

13 years agoPrevent a rowtype from being included in itself.
Tom Lane [Mon, 28 Mar 2011 19:44:54 +0000 (15:44 -0400)]
Prevent a rowtype from being included in itself.

Eventually we might be able to allow that, but it's not clear how many
places need to be fixed to prevent infinite recursion when there's a direct
or indirect inclusion of a rowtype in itself.  One such place is
CheckAttributeType(), which will recurse to stack overflow in cases such as
those exhibited in bug #5950 from Alex Perepelica.  If we were sure it was
the only such place, we could easily modify the code added by this patch to
stop the recursion without a complaint ... but it probably isn't the only
such place.  Hence, throw error until such time as someone is excited
enough about this type of usage to put work into making it safe.

Back-patch as far as 8.3.  8.2 doesn't have the recursive call in
CheckAttributeType in the first place, so I see no need to add code there
in the absence of clear evidence of a problem elsewhere.

13 years agoAdd 9.1 release note link for synchronous replication.
Bruce Momjian [Mon, 28 Mar 2011 18:50:08 +0000 (14:50 -0400)]
Add 9.1 release note link for synchronous replication.

We already had links to the GUC variables that control it.

13 years agoMark up release notes using <link>. REL9_1_ALPHA5
Robert Haas [Mon, 28 Mar 2011 13:42:09 +0000 (09:42 -0400)]
Mark up release notes using <link>.

Unlike <xref>, this actually works.

13 years agoAdd missing #include
Alvaro Herrera [Sat, 26 Mar 2011 03:09:17 +0000 (00:09 -0300)]
Add missing #include

13 years agoGet rid of links that don't work when building HISTORY.
Tom Lane [Mon, 28 Mar 2011 13:34:56 +0000 (09:34 -0400)]
Get rid of links that don't work when building HISTORY.

13 years agoTypo fix in SSI docs.
Robert Haas [Mon, 28 Mar 2011 01:35:15 +0000 (21:35 -0400)]
Typo fix in SSI docs.

Kevin Grittner

13 years agoCorrect "characters" to "bytes" in createdb docs.
Robert Haas [Mon, 28 Mar 2011 01:28:15 +0000 (21:28 -0400)]
Correct "characters" to "bytes" in createdb docs.

Susanne Ebrecht

13 years agofix up a couple non-prototypes of the form foo() to be foo(void) -- found using ...
Greg Stark [Sun, 27 Mar 2011 20:31:41 +0000 (21:31 +0100)]
fix up a couple non-prototypes of the form foo() to be foo(void) -- found using -Wstrict-prototypes

13 years agoFix check_exclusion_constraint() to insert correct collations in ScanKeys.
Tom Lane [Sun, 27 Mar 2011 17:29:52 +0000 (13:29 -0400)]
Fix check_exclusion_constraint() to insert correct collations in ScanKeys.

13 years agoFix plpgsql to release SPI plans when a function or DO block is freed.
Tom Lane [Sun, 27 Mar 2011 16:51:04 +0000 (12:51 -0400)]
Fix plpgsql to release SPI plans when a function or DO block is freed.

This fixes the gripe I made a few months ago about DO blocks getting
slower with repeated use.  At least, it fixes it for the case where
the DO block isn't aborted by an error.  We could try running
plpgsql_free_function_memory() even during error exit, but that seems
a bit scary since it makes a lot of presumptions about the data
structures being in good shape.  It's probably reasonable to assume
that repeated failures of DO blocks isn't a performance-critical case.

13 years agoRemove disclaimer stating that fsync=off slows down sync rep.
Robert Haas [Sun, 27 Mar 2011 01:18:53 +0000 (21:18 -0400)]
Remove disclaimer stating that fsync=off slows down sync rep.

The underlying problem that caused this phenomenon was fixed by commit
92f4786fa9b730fd12cbfe973eb96addc6e98924.

13 years agoUpdate release notes for latest commits.
Robert Haas [Sun, 27 Mar 2011 01:11:15 +0000 (21:11 -0400)]
Update release notes for latest commits.

In addition, correct the entry for pg_object_description, and some other
minor cleanup.

13 years agoClean up cruft around collation initialization for tupdescs and scankeys.
Tom Lane [Sat, 26 Mar 2011 22:28:40 +0000 (18:28 -0400)]
Clean up cruft around collation initialization for tupdescs and scankeys.

I found actual bugs in GiST and plpgsql; the rest of this is cosmetic
but meant to decrease the odds of future bugs of omission.

13 years agoMore collations cleanup, from trawling for missed collation assignments.
Tom Lane [Sat, 26 Mar 2011 20:35:25 +0000 (16:35 -0400)]
More collations cleanup, from trawling for missed collation assignments.

Mostly cosmetic, though I did find that generateClonedIndexStmt failed
to clone the index's collations.

13 years agoClean up a few failures to set collation fields in expression nodes.
Tom Lane [Sat, 26 Mar 2011 18:25:48 +0000 (14:25 -0400)]
Clean up a few failures to set collation fields in expression nodes.

I'm not sure these have any non-cosmetic implications, but I'm not sure
they don't, either.  In particular, ensure the CaseTestExpr generated
by transformAssignmentIndirection to represent the base target column
carries the correct collation, because parse_collate.c won't fix that.
Tweak lsyscache.c API so that we can get the appropriate collation
without an extra syscache lookup.

13 years agoAdditional test for each commit in sync rep path to plug minute
Simon Riggs [Sat, 26 Mar 2011 10:09:37 +0000 (10:09 +0000)]
Additional test for each commit in sync rep path to plug minute
possibility of race condition that would effect performance only.
Requested by Robert Haas. Re-arrange related comments.

13 years agoPass collation to makeConst() instead of looking it up internally.
Tom Lane [Sat, 26 Mar 2011 00:10:42 +0000 (20:10 -0400)]
Pass collation to makeConst() instead of looking it up internally.

In nearly all cases, the caller already knows the correct collation, and
in a number of places, the value the caller has handy is more correct than
the default for the type would be.  (In particular, this patch makes it
significantly less likely that eval_const_expressions will result in
changing the exposed collation of an expression.)  So an internal lookup
is both expensive and wrong.

13 years agoFix failure to propagate collation in negate_clause().
Tom Lane [Fri, 25 Mar 2011 22:44:47 +0000 (18:44 -0400)]
Fix failure to propagate collation in negate_clause().

Turns out it was this, and not so much plpgsql, that was at fault in Stefan
Huehner's collation-error-in-a-trigger bug report of a couple weeks ago.

13 years agoDocument collation handling in SQL and plpgsql functions.
Tom Lane [Fri, 25 Mar 2011 22:21:25 +0000 (18:21 -0400)]
Document collation handling in SQL and plpgsql functions.

This is pretty minimal but covers the bare facts.

13 years agoFix collation handling in plpgsql functions.
Tom Lane [Fri, 25 Mar 2011 19:06:36 +0000 (15:06 -0400)]
Fix collation handling in plpgsql functions.

Make plpgsql treat the input collation as a polymorphism variable, so
that we cache separate plans for each input collation that's used in a
particular session, as per recent discussion.  Propagate the input
collation to all collatable input parameters.

I chose to also propagate the input collation to all declared variables of
collatable types, which is a bit more debatable but seems to be necessary
for non-astonishing behavior.  (Copying a parameter into a separate local
variable shouldn't result in a change of behavior, for example.)  There is
enough infrastructure here to support declaring a collation for each local
variable to override that default, but I thought we should wait to see what
the field demand is before adding such a feature.

In passing, remove exec_get_rec_fieldtype(), which wasn't used anywhere.

Documentation patch to follow.

13 years agoRemove alpha release notes.
Robert Haas [Fri, 25 Mar 2011 15:52:11 +0000 (11:52 -0400)]
Remove alpha release notes.

Temporarily move some of the alpha release note disclaimers into the regular
release notes, for the sake of alpha5.

13 years agoMake walreceiver send a reply after receiving data but before flushing it.
Robert Haas [Fri, 25 Mar 2011 15:23:39 +0000 (11:23 -0400)]
Make walreceiver send a reply after receiving data but before flushing it.

It originally worked this way, but was changed by commit
a8a8a3e0965201df88bdfdff08f50e5c06c552b7, since which time it's been impossible
for walreceiver to ever send a reply with write_location and flush_location
set to different values.

13 years agoFix broken markup, and remove tabs
Alvaro Herrera [Fri, 25 Mar 2011 15:20:14 +0000 (12:20 -0300)]
Fix broken markup, and remove tabs

13 years agoDocumented some ecpg command line options that were missing:
Michael Meskes [Thu, 24 Mar 2011 21:18:11 +0000 (22:18 +0100)]
Documented some ecpg command line options that were missing:

-r no_indicator
-r prepare
-r questionsmarks

13 years agoFix handling of collation in SQL-language functions.
Tom Lane [Fri, 25 Mar 2011 00:30:14 +0000 (20:30 -0400)]
Fix handling of collation in SQL-language functions.

Ensure that parameter symbols receive collation from the function's
resolved input collation, and fix inlining to behave properly.

BTW, this commit lays about 90% of the infrastructure needed to support
use of argument names in SQL functions.  Parsing of parameters is now
done via the parser-hook infrastructure ... we'd just need to supply
a column-ref hook ...

13 years agoAdd post-creation hook for extensions, consistent with other object types.
Robert Haas [Thu, 24 Mar 2011 22:44:49 +0000 (18:44 -0400)]
Add post-creation hook for extensions, consistent with other object types.

KaiGai Kohei

13 years agoEdits to 9.1 release notes.
Robert Haas [Thu, 24 Mar 2011 20:57:12 +0000 (16:57 -0400)]
Edits to 9.1 release notes.

Add some new items and some additional details to existing items, mostly
by cribbing from the 9.1alpha notes.  Some additional clarifications and
corrections elsewhere, and a few typo fixes.

13 years agoClean up handling of COLLATE clauses in index column definitions.
Tom Lane [Thu, 24 Mar 2011 19:29:52 +0000 (15:29 -0400)]
Clean up handling of COLLATE clauses in index column definitions.

Ensure that COLLATE at the top level of an index expression is treated the
same as a grammatically separate COLLATE.  Fix bogus reverse-parsing logic
in pg_get_indexdef.