Azat Khuzhin [Fri, 20 Jan 2017 13:31:17 +0000 (16:31 +0300)]
Run tests in parallel (they are lightweight), on CI and vagrant boxes
By default 20 parllel jobs, but one caveat for travis-ci, osx boxes
there slower and have less resources then linux (discovered during
testing), so limit number of parallel jobs to 4 there, and also install
travis_wait, so that travis-ci will not fail the build when there is no
output for 10 minutes, since for osx boxes it is very likely.
Refs: travis-ci/travis-ci@7202
Azat Khuzhin [Fri, 20 Jan 2017 13:50:04 +0000 (16:50 +0300)]
travis-ci: install cmake from xenial (CTEST_PARALLEL_LEVEL support)
cmake supports it since 3.0 I guess.
And it must be trusty (not precise), otherwise it fails:
dpkg: error processing
/var/cache/apt/archives/ifupdown_0.8.10ubuntu1_amd64.deb (--unpack):
trying to overwrite '/etc/init.d/networking', which is also in package netbase 4.47ubuntu1
Link: https://travis-ci.org/azat/libevent/jobs/193744023
Azat Khuzhin [Fri, 20 Jan 2017 13:29:19 +0000 (16:29 +0300)]
test: register different tests in automake
Before this patch we have one test.sh (well test-script.sh), and tooks
very long to run it sequentially, but they are pretty lightweight, so we
should run then in parallel.
Azat Khuzhin [Fri, 20 Jan 2017 13:29:02 +0000 (16:29 +0300)]
test: run different tests under different options (in a wrapper)
Azat Khuzhin [Sun, 15 Jan 2017 09:31:27 +0000 (12:31 +0300)]
automake: do not use serial-tests if parallel-test-harness available
Revert:
61179dec7716975a151c6dae4524ae504d05780e ("automake: define
serial-tests only if automake have this option") Revert:
Revert:
44d755e00e249c09914cf35089c16735df82e270 ("test/automake: don't
use paralell test harness (since automake 1.12)")
Azat Khuzhin [Fri, 20 Jan 2017 18:24:54 +0000 (21:24 +0300)]
Bump VERSION_INFO so that libraries symlinks will have the same version
Fixes: f4489b8323cda0bf8eed7c1353911a852d7a947c ("Bump version to 2.1.7-beta
everywhere")
Azat Khuzhin [Thu, 19 Jan 2017 23:11:35 +0000 (02:11 +0300)]
test/dns: replace servname since solaris does not have "http"
Yes, by default solaris (solaris10.dev 5.10 Generic_147148-26 i86pc i386 i86pc)
does not have "http" in /etc/services
Azat Khuzhin [Thu, 19 Jan 2017 17:53:18 +0000 (20:53 +0300)]
Merge branch 'openssl-filter-fixes-v4'
* openssl-filter-fixes-v4:
be: fix with filtered bufferevents and connect() without EAGAIN
test/ssl: fix bufferevent_getfd() for bufferevent_openssl_filter_new()
be_openssl: Fix writing into filted openssl bufferevent after connected
test/https: separate cases for https client with filtered openssl bufferevent
test/ssl: cover case when we writing to be_openssl after connecting
Fixes: #428
Azat Khuzhin [Sun, 15 Jan 2017 23:31:54 +0000 (02:31 +0300)]
be: fix with filtered bufferevents and connect() without EAGAIN
With filtered bufferevents (i.e. not real one, that have socket), we can
trigger incorrect callback in this case. Let's look at example with http
and bufferevent_openssl_filter_new():
- bev = bufferevent_openssl_filter_new()
- http layer trying to connect() to localhost with bev
# at this time, bev have writecb/readcb NULL but ev_write/ev_read has
# timeout with 45 secs, default HTTP connect timeout
- and when connect() retruns without EAGAIN (BSD'ism) we called
event_active() before (with EV_WRITE), and this will call ev_write
timeout only, while it is more correct to act on bufferevent instead
of plain event, so let's trigger EV_WRITE for bufferevent which will
do the job (and let's do this deferred).
Fixes: http/https_simple # under solaris
Azat Khuzhin [Wed, 7 Dec 2016 23:11:22 +0000 (02:11 +0300)]
test/ssl: fix bufferevent_getfd() for bufferevent_openssl_filter_new()
Azat Khuzhin [Tue, 6 Dec 2016 23:53:07 +0000 (02:53 +0300)]
be_openssl: Fix writing into filted openssl bufferevent after connected
The main problems was due to when bufferevent_openssl has underlying (i.e.
created with bufferevent_openssl_filter_new()) some events was
disabled/suspended, while with openssl, READ can require WRITE and vice-versa
hence this issues.
The BEV_CTRL_GET_FD hunk to fix http subsystem, since it depends from what
bufferevent_getfd() returns.
Fixes: #428
Fixes: ssl/bufferevent_filter_write_after_connect
Fixes: http/https_filter_chunk_out
Fixes: da52933550fd4736aa1c213b6de497e2ffc31e34 ("be_openssl: don't call
do_write() directly from outbuf_cb")
Azat Khuzhin [Wed, 7 Dec 2016 00:07:59 +0000 (03:07 +0300)]
test/https: separate cases for https client with filtered openssl bufferevent
- http/https_filter_chunk_out # now hang
- http/https_filter_basic # works, since writes only before connect()
Azat Khuzhin [Fri, 2 Dec 2016 15:32:03 +0000 (18:32 +0300)]
test/ssl: cover case when we writing to be_openssl after connecting
Right now it fails because of regression for filtered openssl
bufferevent, and by it I mean ssl/bufferevent_filter_write_after_connect
test, and by fails - hang.
Regression-for:
da52933550fd4736aa1c213b6de497e2ffc31e34 ("be_openssl:
don't call do_write() directly from outbuf_cb")
Azat Khuzhin [Thu, 19 Jan 2017 17:51:38 +0000 (20:51 +0300)]
test/thread: netbsd is too slow, increase timeout for conditions_simple
Azat Khuzhin [Thu, 19 Jan 2017 17:34:41 +0000 (20:34 +0300)]
test/dns: run async resolving after sync one (to avoid timeouts)
If system resolver (sync one) will respond too slow, then we can fail async
request and evdns will retransmit tham again, but evdns server will accept that
failed requets, so we will have not 2 requests but 4.
Reproduced on centos box sometimes.
Azat Khuzhin [Wed, 18 Jan 2017 11:33:56 +0000 (14:33 +0300)]
Azat Khuzhin [Sat, 7 Jan 2017 08:48:28 +0000 (11:48 +0300)]
test/http: turn off some tests that based on backlog filling (falky)
Since this technique does not work well everywhere, anyway it fails from time
to time.
See: https://travis-ci.org/libevent/libevent/jobs/
186426446
Breaker [Fri, 23 Dec 2016 08:19:35 +0000 (16:19 +0800)]
Update README.md
The default option of EVENT__DISABLE_OPENSSL:BOOL is `OFF`
Azat Khuzhin [Thu, 22 Dec 2016 11:55:33 +0000 (14:55 +0300)]
test: fix util/date_rfc1123 under win32
Refs: #417
v2: check when gmtime() returns NULL
v3: fix overflow cases
Azat Khuzhin [Mon, 19 Dec 2016 07:22:51 +0000 (10:22 +0300)]
Fix UB in evutil_date_rfc1123()
As pointed in https://github.com/libevent/libevent/pull/417#issuecomment-
267860738
"code is unsafe because in evutil_date_rfc1123() the pointer to the
automatic variable struct tm cur is used outside the scope it defined."
Checked with `clang -fsanitize=address -fsanitize-address-use-after-scope`
and test that call evutil_date_rfc1123() with tm==NULL
Azat Khuzhin [Sun, 18 Dec 2016 22:26:43 +0000 (01:26 +0300)]
Merge branch 'date-rfc1123'
Follow RFC2616 (Date header should be in RFC1123 format).
But to reproduce this bug, program that uses libevent http-server should
call `setlocale(LC_ALL, "")` to properly initliaze locale, so that
strftime() retruns locale-specific dates.
* date-rfc1123:
add tests for evutil_date_rfc1123().
http: do not use local settings for Date header
Closes: #417
Vis Virial [Fri, 16 Dec 2016 05:49:59 +0000 (14:49 +0900)]
add tests for evutil_date_rfc1123().
Vis Virial [Thu, 10 Nov 2016 12:58:15 +0000 (21:58 +0900)]
http: do not use local settings for Date header
johnsonlee [Tue, 13 Dec 2016 03:54:09 +0000 (11:54 +0800)]
Fix incorrect MIME type
Azat Khuzhin [Tue, 6 Dec 2016 22:48:54 +0000 (01:48 +0300)]
be_openssl: make be_openssl_set_fd() static (no prototype required)
Azat Khuzhin [Tue, 6 Dec 2016 22:43:35 +0000 (01:43 +0300)]
Merge branch 'be-openssl-fd-reset-fix-v2'
Two issues:
- dirty_shutdown for openssl 1.1
- BEV_CTRL_SET_FD for bufferevent_openssl didn't reset state
* be-openssl-fd-reset-fix-v2:
Fix dirty_shutdown for openssl 1.1
Fix reusing bufferevent_openssl after fd was reseted (i.e. on new connection)
test/https: fix ssl dirty bypass for https_simple
test/https: cover multiple request over the same connection
test/http: sanity check for http_request_empty_done()
Reported-by: liutao74748@163.com
ML: http://archives.seul.org/libevent/users/Nov-2016/msg00041.html
Azat Khuzhin [Sat, 19 Nov 2016 15:00:36 +0000 (18:00 +0300)]
Fix dirty_shutdown for openssl 1.1
SSL_read() returns -1, even when underlying read() return 0
Azat Khuzhin [Sat, 19 Nov 2016 14:08:53 +0000 (17:08 +0300)]
Fix reusing bufferevent_openssl after fd was reseted (i.e. on new connection)
For example if you trying to issue multiple requests over the same
evhttp_conneciton, and if connection already closed (IOW it should be
re-connected), than you will get into trouble since it will got wrong
openssl state. This patch addresses this issue by restoring state to
initial if SETFD called with -1 fd.
Azat Khuzhin [Sat, 19 Nov 2016 14:53:38 +0000 (17:53 +0300)]
test/https: fix ssl dirty bypass for https_simple
Tests:
- http/https_simple_dirty # not affected, since dirty is the default
- http/https_simple # affected
v2: fix compilation with -DEVENT__DISABLE_OPENSSL=ON
Azat Khuzhin [Sat, 19 Nov 2016 12:54:52 +0000 (15:54 +0300)]
test/https: cover multiple request over the same connection
Introduce two new tests:
- http/https_connection # fail
- http/https_persist_connection # ok
Reported-by: liutao74748@163.com
Azat Khuzhin [Sat, 19 Nov 2016 14:11:35 +0000 (17:11 +0300)]
test/http: sanity check for http_request_empty_done()
Azat Khuzhin [Tue, 6 Dec 2016 22:14:24 +0000 (01:14 +0300)]
Merge branch 'openssl-1.1-init-fixes-v2'
* openssl-1.1-init-fixes-v2:
sample/le-proxy: use TLS_method instead of SSLv23_method (latest deprecated)
test: fix building under openssl 1.1 (init functions has been deprecated)
le-proxy: fix building under openssl 1.1 (init functions has been deprecated)
Reported-by: varun.net@gmail.com
ML: http://archives.seul.org/libevent/users/Nov-2016/msg00002.html
Azat Khuzhin [Tue, 15 Nov 2016 22:16:30 +0000 (01:16 +0300)]
sample/le-proxy: use TLS_method instead of SSLv23_method (latest deprecated)
Azat Khuzhin [Sun, 13 Nov 2016 23:17:51 +0000 (02:17 +0300)]
test: fix building under openssl 1.1 (init functions has been deprecated)
Refs: #397
Azat Khuzhin [Sun, 13 Nov 2016 23:17:38 +0000 (02:17 +0300)]
le-proxy: fix building under openssl 1.1 (init functions has been deprecated)
Refs: #397
Azat Khuzhin [Tue, 6 Dec 2016 10:26:09 +0000 (13:26 +0300)]
https-cilent: fix compilation warnings about unused vars/functions on win32
Azat Khuzhin [Tue, 6 Dec 2016 10:15:27 +0000 (13:15 +0300)]
Fix _FILE_OFFSET_BITS redinition (solaris/autotools)
So firstly include our header (config.h) -- <evconfig-private.h>, and
only after it <sys/types.h> since latest has #ifdef guard, while our
config.h is not inteded for this.
And besides all this thing with LARGE_FILE is a abit awkward, since we
don't nefine _LP64/_LP32 anyway, and so we have next error actually (64bit VS
32bit):
==> solaris: In file included from ./util-internal.h:30:0,
==> solaris: from test/regress_ssl.c:49:
==> solaris: ./evconfig-private.h:29:0: warning: "_FILE_OFFSET_BITS" redefined
==> solaris: #define _FILE_OFFSET_BITS 64
==> solaris: ^
==> solaris: In file included from /usr/include/sys/types.h:17:0,
==> solaris: from test/regress_ssl.c:38:
==> solaris: /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0: note: this is the location of the previous definition
==> solaris: #define _FILE_OFFSET_BITS 32
==> solaris: ^
For cmake it commented in:
8b228e27f57300be61b57a41a2ec8666b726dc34
("Lot's of cmake updates")
Azat Khuzhin [Tue, 6 Dec 2016 10:06:08 +0000 (13:06 +0300)]
vagrant/osx: use make instead of gmake (there is no gmake)
$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for i386-apple-darwin11.3.0
Azat Khuzhin [Tue, 6 Dec 2016 09:08:32 +0000 (12:08 +0300)]
util-internal: fix __func__ redefinition (netbsd)
==> netbsd: In file included from ../listener.c:57:0:
==> netbsd: ../util-internal.h:58:0: warning: "__func__" redefined [enabled by default]
==> netbsd: #define __func__ EVENT____func__
==> netbsd: ^
==> netbsd: In file included from /usr/include/amd64/types.h:39:0,
==> netbsd: from /usr/include/sys/types.h:45,
==> netbsd: from ../listener.c:30:
==> netbsd: /usr/include/sys/cdefs.h:394:0: note: this is the location of the previous definition
==> netbsd: #define __func__ __PRETTY_FUNCTION__
Azat Khuzhin [Tue, 6 Dec 2016 08:55:44 +0000 (11:55 +0300)]
Fix signedness differ for iov_base (solaris)
Azat Khuzhin [Tue, 6 Dec 2016 08:58:16 +0000 (11:58 +0300)]
evutil_time: include <unistd.h> when there is only sleep()/usleep()
Azat Khuzhin [Tue, 6 Dec 2016 08:51:18 +0000 (11:51 +0300)]
http: fix formatter for pritnf for req->ntoread (osx)
Azat Khuzhin [Tue, 6 Dec 2016 06:54:13 +0000 (09:54 +0300)]
sample/http-connect: fix compilation with VS2010
Fixes: nmathewson/Libevent#137
Philip Prindeville [Sat, 12 Nov 2016 00:51:37 +0000 (17:51 -0700)]
C90 doesn't like declarations intermingled with statements
So move all of the declarations to the top of the offending function.
This patch includes both of issues (Fixes:), from @jeking3 and
@pprindeville
Fixes: #418
Fixes: nmathewson/Libevent#136
Azat Khuzhin [Fri, 18 Nov 2016 17:27:49 +0000 (20:27 +0300)]
vagrant: add centos box
Packages list get from here:
https://pkgs.org/search/
Refs: #424
Azat Khuzhin [Fri, 4 Nov 2016 22:35:26 +0000 (01:35 +0300)]
Merge remote-tracking branch 'azat/release-2.1.7-rc-pull'
Finally 2.1 release candidate is out!
* azat/release-2.1.7-rc-pull:
Bump version to 2.1.7-beta everywhere
Update changelog for 2.1.7-rc
README: update AUTHORS
Azat Khuzhin [Tue, 1 Nov 2016 21:31:31 +0000 (00:31 +0300)]
Bump version to 2.1.7-beta everywhere
- cmake basic
- cmake detecting from git -- event_fuzzy_version_from_git()
- autotools
- win32
- appveyor
Azat Khuzhin [Tue, 1 Nov 2016 21:25:38 +0000 (00:25 +0300)]
Update changelog for 2.1.7-rc
Azat Khuzhin [Tue, 1 Nov 2016 21:16:54 +0000 (00:16 +0300)]
README: update AUTHORS
$ git log --format='%an' HEAD...refs/tags/release-2.1.6-beta | sort -u | xargs -n1 -i bash -c 'fgrep -q "{}" README.md || echo {}'
Azat Khuzhin [Thu, 3 Nov 2016 12:00:15 +0000 (15:00 +0300)]
travis-ci/osx: install lcov
Tim Hentenaar [Fri, 15 Jul 2016 00:27:23 +0000 (02:27 +0200)]
test/regress: cover a polling of invalid fd
Test that an event's callback is called if the fd is closed prior to being
polled for activity.
azat: make it run only for poll backend/method, and do not close fd
twice
Tim Hentenaar [Thu, 14 Jul 2016 13:45:01 +0000 (15:45 +0200)]
poll: Prevent libevent from spinning if POLLNVAL occurs
This can happen, for example if libevent is being used to poll fds given
by another library where the other library closes the fds without
notifying the program using it that said fds were closed. In this case,
libevent will simply spin on poll() since there are active fds, but
won't call any event callback to handle the condition.
In epoll case after socket closed it automatically removed from epfd, so
IOW it will not spin in epoll* API, just a timeout.
Fixes: #379
Azat Khuzhin [Tue, 1 Nov 2016 20:39:41 +0000 (23:39 +0300)]
Use coveralls.io via travis
Azat Khuzhin [Tue, 1 Nov 2016 20:33:11 +0000 (23:33 +0300)]
Fix cmake -DEVENT__COVERAGE=ON
- do not use compiler check from the root cmake rules with syntax error,
let CodeCoverage check it
- fix CodeCoverage to check C compiler not CXX
- case insensitive checking of CMAKE_BUILD_TYPE
- replace flags with --coverage, and fix flags with linking with
--coverate, otherwise it will not compile during checking flags and
fails.
Azat Khuzhin [Mon, 31 Oct 2016 16:33:28 +0000 (19:33 +0300)]
Testing with vagrant for 6 OS and cmake+autoconf
OS:
- linux
- freebsd
- osx
- netbsd
- solaris
- win
And mostly they all are more or less fine, except for timing issues
Also it supports next environment variables:
- NO_PKG
- NO_CMAKE
- NO_AUTOTOOLS
For instance if you run ubuntu box seocnd time, then you can run with:
$ NO_PKG=true vagrant provision ubuntu
Azat Khuzhin [Mon, 31 Oct 2016 19:37:16 +0000 (22:37 +0300)]
autogen.sh: learn about gmake
Fixes: 69cce257eb6183dda114d8f5b8ca0325cfabe2e1
("
69cce257eb6183dda114d8f5b8ca0325cfabe2e1")
Azat Khuzhin [Mon, 31 Oct 2016 09:01:20 +0000 (12:01 +0300)]
autogen.sh: remove all autoconf/automake caches, if any
Otherwise if you for example share root of libevent repository with some
vm (for example windows+cygwin) then if you try to build with configure
on host, and then on guest it will fail, so let's just ignore this since
autogen.sh is just for this -- cleaning all stuff.
Azat Khuzhin [Sun, 30 Oct 2016 08:19:43 +0000 (11:19 +0300)]
cmake: fix finding python2, and check that it is really 2
python version check removed in
a4d044c0cd97f68b4b3dde414b83d609719d33d7
("cmake: use PYTHON_EXECUTABLE to find python2"), but in
bcb990ab7cf4921c2c30a1aa4fcb4c0131fffe94 ("cmake/win32: fix running
regress, but fixing finding python2 interpreter") we set
PYTHON_EXECUTABLE only if it exists.
Azat Khuzhin [Sun, 30 Oct 2016 22:56:37 +0000 (01:56 +0300)]
Ignore temporary configure files
So if you kill configure, git still should ignore them.
Azat Khuzhin [Wed, 26 Oct 2016 15:04:07 +0000 (18:04 +0300)]
cmake: fix CheckFunctionExistsEx/CheckPrototypeDefinition (CMP0054)
Zonr Chang [Wed, 24 Aug 2016 08:19:01 +0000 (16:19 +0800)]
cmake: cleanup
- Remove a redundant check on netdb.h (EVENT__HAVE_NETDB_H).
- Properly setup EVENT__SIZEOF_SSIZE_T for the case where "ssize_t" is
not "int".
- Remove unused EVENT__HAVE_PTHREAD.
- Set EVENT__HAVE_LIBZ instead of EVENT__HAVE_ZLIB (and remove the
latter).
Closes: #391 (cherry-picked from PR)
Thomas Bernard [Sat, 13 Dec 2014 18:42:42 +0000 (19:42 +0100)]
use ev_uint16_t instead of unsigned short for port
Like in `sockaddr_in` structure in /usr/include/netinet/in.h
@azat: convert all other users (bench, compat, ..) and tweak message
Fixes: #178
Fixes: #196
Refs:
6bf1ca78
Link: https://codereview.appspot.com/156040043/#msg4
Azat Khuzhin [Tue, 25 Oct 2016 21:51:56 +0000 (00:51 +0300)]
cmake/win32: fix running regress, but fixing finding python2 interpreter
Could not find executable C:/projects/libevent/build/bin/regress
Looked in the following places:
C:/projects/libevent/build/bin/regress
C:/projects/libevent/build/bin/regress.exe
...
9/13 Test #9: regress__WIN32_debug ................***Not Run 0.00 sec
Link: https://ci.appveyor.com/project/nmathewson/libevent/build/2.1.6.271/job/wvy2jp7uojcut5cx#L1256
Fixes: #411
Simone Basso [Fri, 21 Oct 2016 08:49:22 +0000 (10:49 +0200)]
README.md: fix typo: ar -> are
Azat Khuzhin [Sun, 16 Oct 2016 22:05:38 +0000 (01:05 +0300)]
travis-ci: use container-based infrastructure
- by disabling sudo
- and since we use addons.apt.packages we don't need apt-get update, that requires sudo
Link: https://docs.travis-ci.com/user/migrating-from-legacy/
Azat Khuzhin [Sun, 16 Oct 2016 20:46:09 +0000 (23:46 +0300)]
travis-ci/osx: fix compiling/linking openssl libraries
And we need that $(echo /path/*) otherwise bash will expand it only during
assignment that variable to another one, and this doesn't work correctly.
Azat Khuzhin [Sun, 16 Oct 2016 18:48:59 +0000 (21:48 +0300)]
travis-ci: use gcc-5 (fixes osx|gcc failures)
Refs: travis-ci/travis-ci#4587
Kurt Roeckx [Mon, 19 Sep 2016 20:05:15 +0000 (22:05 +0200)]
Make it build using OpenSSL 1.1.0
Rebased (azat):
- tabs instead of whitespaces
- make openssl-compat.h safe for complex expressions
- do not call sk_SSL_COMP_free() in 1.1 (fixes double free)
TODO:
- clean methods_bufferevent
Closes: #397 (cherry-picked)
Adam Langley [Thu, 13 Oct 2016 00:49:17 +0000 (17:49 -0700)]
Don't call BIO_number_{read|written} on NULL BIOs.
OpenSSL doesn't document the behaviour of these functions when given a
NULL BIO, and it happens to return zero at the moment. But don't depend
on that.
Closes: #406 (cherry-picked)
Adam Langley [Thu, 13 Oct 2016 00:49:10 +0000 (17:49 -0700)]
Switch from a 512 to 2048-bit RSA key.
The 512 bit key is too small to sign larger hashes. This can cause the
regression tests to fail depending on the defaults in libssl.
Azat Khuzhin [Wed, 5 Oct 2016 12:52:41 +0000 (15:52 +0300)]
Merge branch 'contrib-guide-v2'
Something that should help with reviewing patches.
* contrib-guide-v2:
Add CONTRIBUTING.md (with checkpatch.sh examples)
Add checkpatch script
Add config for clang-format
Add config for uncrustify
Refs: #301
Azat Khuzhin [Mon, 15 Feb 2016 20:43:10 +0000 (23:43 +0300)]
Add CONTRIBUTING.md (with checkpatch.sh examples)
Azat Khuzhin [Wed, 5 Oct 2016 10:28:04 +0000 (13:28 +0300)]
Add checkpatch script
Support:
- files
- files-diffs
- patches
- git-refs
Azat Khuzhin [Wed, 5 Oct 2016 11:00:55 +0000 (14:00 +0300)]
Add config for clang-format
Azat Khuzhin [Wed, 5 Oct 2016 11:00:40 +0000 (14:00 +0300)]
Add config for uncrustify
Original: https://strcpy.net/mark/libevent-uncrustify.cfg (@ellzey)
Seven [Fri, 16 Sep 2016 08:37:59 +0000 (16:37 +0800)]
be: just a simple mistake, reinclude the <errno.h>
include the <errno.h> twice.
Azat Khuzhin [Tue, 4 Oct 2016 20:21:37 +0000 (23:21 +0300)]
cmake: use PYTHON_EXECUTABLE to find python2
Since most of the distros have symlinks for this.
Azat Khuzhin [Mon, 3 Oct 2016 00:24:28 +0000 (03:24 +0300)]
Merge branch 'force-disable-clockgettime'
* force-disable-clockgettime:
Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake
Adding option to ignore clock_gettime: --disable-clock-gettime
Azat Khuzhin [Mon, 3 Oct 2016 00:17:18 +0000 (03:17 +0300)]
Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake
See-also:
adc402ba5f0e15f4c77505852507f33b50f37ab6 ("Adding option to
ignore clock_gettime: --disable-clock-gettime")
Vlad Shcherban [Thu, 29 Sep 2016 22:31:53 +0000 (18:31 -0400)]
Adding option to ignore clock_gettime: --disable-clock-gettime
macOS 10.12 introduced `clock_gettime` to libsystem. This means, built
on OS X 10.12 application would crash on earlier versions of OS X
because it will try to call clock_gettime. This options is useful to
make backwards compatible macOS apps.
Fixes: #398
Fixes: #399
Fixes: #400
Azat Khuzhin [Fri, 26 Aug 2016 22:53:31 +0000 (01:53 +0300)]
Merge branch 'release-2.1.6-beta-pull'
* release-2.1.6-beta-pull:
Bump version to 2.1.6-beta everywhere
ChangeLog: Add brief notes
Update changelog for 2.1.6-beta (ugh, pretty huge)
Update AUTHORS section in README
Azat Khuzhin [Wed, 13 Jul 2016 14:40:48 +0000 (17:40 +0300)]
Bump version to 2.1.6-beta everywhere
- cmake basic
- cmake detecting from git -- event_fuzzy_version_from_git()
- autotools
- win32
- appveyor
Azat Khuzhin [Tue, 5 Jul 2016 13:17:38 +0000 (16:17 +0300)]
ChangeLog: Add brief notes
Azat Khuzhin [Mon, 4 Jul 2016 15:13:02 +0000 (18:13 +0300)]
Update changelog for 2.1.6-beta (ugh, pretty huge)
Changes for:
- 2.1.5-beta: 118
- 2.1.6-beta: 350
We should really hurry with the release!
Azat Khuzhin [Sun, 7 Aug 2016 20:27:22 +0000 (23:27 +0300)]
Update AUTHORS section in README
P.S. "Sebastian Hahn" was declared two times.
Zonr Chang [Wed, 24 Aug 2016 09:16:32 +0000 (17:16 +0800)]
Fix evhttp_uriencode() regression.
http_uriencode_test() (in test/regress_http.c) has been failed after
72afe4c as "hello\0world" is encoded to "hello" instead of
"hello%00world". This is because of a misplaced overflow check which
causes the non-negative "size" specified in parameter being ignored in
within-bound URI.
Fixes: #392
Mark Ellzey [Sun, 14 Aug 2016 21:03:56 +0000 (14:03 -0700)]
removed unused vars
Mark Ellzey [Sun, 14 Aug 2016 21:00:02 +0000 (14:00 -0700)]
pointer overflow checks for evhttp_uriencode
Check to make sure pointer math is all OK.
Azat Khuzhin [Thu, 11 Aug 2016 13:15:45 +0000 (16:15 +0300)]
tests: use waitpid(..., WNOWAIT) to fix failing of main/fork under solaris
According to solaris docs:
"One instance of a SIGCHLD signal is queued for each child process whose
status has changed. If waitpid() returns because the status of a child
process is available, and WNOWAIT was not specified in options, any pending
SIGCHLD signal associated with the process ID of that child process is
discarded. Any other pending SIGCHLD signals remain pending."
And interesting thing that it works if you add sleep(1) before waitpid(), and
also if you run with --verbose (some race or what).
But linux doesn't support WNOWAIT in waitpid() so add detection into
cmake/autotools.
Fixes: #387
Link: https://bugzilla.redhat.com/show_bug.cgi?id=840782
Azat Khuzhin [Thu, 11 Aug 2016 10:43:14 +0000 (13:43 +0300)]
test: replace sleeping with syncing pair in main/fork
About this syncing pair:
- read endpoint, must be blocked, to make it a checkpoint or smth like this
- write endpoint, must be nonblocking, to avoid readcb hung
Refs: #387
Azat Khuzhin [Thu, 11 Aug 2016 06:27:50 +0000 (09:27 +0300)]
travis: split long lines, and make it cleaner
Azat Khuzhin [Wed, 10 Aug 2016 21:18:04 +0000 (00:18 +0300)]
travis: fix autotools on osx by reinstalling libtool
Link: mkrufky/libdvbtee#22
Azat Khuzhin [Wed, 10 Aug 2016 13:04:33 +0000 (16:04 +0300)]
be_sock: handle readv() returns ECONNREFUSED (freebsd 9.2)
During testing sometimes bufferevent/bufferevent_connect_fail_eventcb fails,
and after some digging I found that this was the case when connect() doesn't
return ECONNREFUSED immediately, and instead next operation will return it (in
our case evbuffer_read()->readv(), needless to say that after this
bufferevent_writecb() called and it checks error with getsockopt() but of
course it doesn't return any error), so this patch checks "errno" after
"readv()" and installs "bufev::connection_refused" flag, to handle this from
writecb and only once.
Fixes: bufferevent/bufferevent_connect_fail_eventcb
Fixes: bufferevent/bufferevent_connect_fail_eventcb_defer
Refs: #388
Azat Khuzhin [Wed, 10 Aug 2016 13:50:19 +0000 (16:50 +0300)]
test/http: do not run tests that based on backlog filling (freebsd)
I cannot find any other solution for now, so simply ignore them for now, we
should think about normal fix for this.
Refs: #388
Azat Khuzhin [Wed, 10 Aug 2016 13:09:09 +0000 (16:09 +0300)]
evutil: mark ai_find_protocol() static (prototype-less)
Azat Khuzhin [Wed, 10 Aug 2016 09:07:32 +0000 (12:07 +0300)]
test/bufferevent/iocp: fix test name for "bufferevent_connect_fail_eventcb"
Azat Khuzhin [Mon, 9 May 2016 22:34:28 +0000 (22:34 +0000)]
Fix getaddrinfo under solaris (for multiprotocol case)
During testing on solaris 11.3, util/getaddrinfo failed at:
memset(&hints, 0, sizeof(hints));
hints.ai_flags = EVUTIL_AI_NUMERICHOST;
r = evutil_getaddrinfo("1.2.3.4", NULL, &hints, &ai);
tt_assert(ai_find_by_protocol(ai, IPPROTO_TCP));
And this is because solaris's getaddrinfo() returns:
$6 = {
ai_flags = 32,
ai_family = 2,
ai_socktype = 0,
ai_protocol = 0, <-- no proto
ai_addrlen = 16,
ai_canonname = 0x0,
ai_addr = 0x815d658,
ai_next = 0x0 <-- nothing else
}
So we should emulate this too.
Plus introduce helper that will search through all results, not only first one.
Fixes: util/getaddrinfo
Fixes: #354
Azat Khuzhin [Tue, 9 Aug 2016 21:27:59 +0000 (00:27 +0300)]
cmake/solaris: set CMAKE_REQUIRED_LIBRARIES to fix functions detections
Otherwise we will not detect next functions for instance:
- gethostbyname_r # and related
And now both autotools/cmake builds passes all regress tests in basic env (on
solaris of course).
Fixes: dns/client_fail_requests_getaddrinfo
Azat Khuzhin [Tue, 9 Aug 2016 21:16:48 +0000 (00:16 +0300)]
cmake/solaris: fix building (link with socket,nsl)
Azat Khuzhin [Tue, 9 Aug 2016 12:49:01 +0000 (15:49 +0300)]
Merge branch 'appveyor-cmake-v6'
This patch set introduces matrix for appveyor and fixes bugs related to win32,
during debugging this matrix. This should greatly reduce number of work for
making a release ('check under windows' part only).
Right now tests on appveyor still failes in summary, but we should dig into
problems, not hide them.
Test matrix looks like this:
- autotools
- autotools --disable-openssl
- autotools --disable-thread-support
- autotools --disable-debug-mode
- autotools --disable-malloc-replacement
- cmake
- cmake -DEVENT__DISABLE_OPENSSL=ON
- cmake -DEVENT__DISABLE_THREAD_SUPPORT=ON
- cmake -DEVENT__DISABLE_DEBUG_MODE=ON
- cmake -DEVENT__DISABLE_MM_REPLACEMENT=ON
- cmake -DEVENT__ENABLE_VERBOSE_DEBUG=ON
- cmake -DCMAKE_C_FLAGS='-DUNICODE -D_UNICODE'
And takes 90min (was 7min, and this is the sad part).
* appveyor-cmake-v6:
test/ssl: use send()/recv()/EVUTIL_ERR_RW_RETRIABLE()/EVUTIL_SOCKET_ERROR() to fix win32
test/https_basic: increase timeout for complete write (fixes win32)
cmake: check for ZLIB_INCLUDE_DIR, since we can have only library without headers
autotools/win32: fix searching ssl library
appveyor/autotools: link with openssl by passing LDFLAGS/CFLAGS
appveyor: image already had openssl installed
cmake/win32: do not compile regress_thread on -DEVENT__DISABLE_THREAD_SUPPORT=ON
cmake/win32: do not compile evthread_win32 on -DEVENT__DISABLE_THREAD_SUPPORT=ON
appveyor: check -DUNICODE -D_UNICODE according to ReleaseChecklist (cmake only)
cmake: fix -DEVENT__ENABLE_VERBOSE_DEBUG (typo on -DUSE_DEBUG)
test: fix building with --disable-thread-support under win32
cmake: do not use stderr for notifications/version-info
autoconf: fix --disable-thread-support build under win32
appveyor: ignore failure of mingw-get
appveyor: drop shallow_clone, since we use tags for detecting version in cmake
appveyor: support cmake & autotools using build matrix (like travis-ci has)
Fixes: #364