Adjust whitespaces.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56538 91177308-0d34-0410-b5e6-96231b3b80d8

s/ParamAttrsWithIndex/FnAttributeWithIndex/g

Rename to match changes done on llvm side.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56537 91177308-0d34-0410-b5e6-96231b3b80d8

For generated index.html, look for "scan-view.css", not "/scan-view.css"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56510 91177308-0d34-0410-b5e6-96231b3b80d8

Implement type checking of Objective-C property attributes.
 - readonly and readwrite are mutually exclusive.
 - assign, copy, and retain are mutually exclusive.
 - copy and retain are invalid on non-object types.
 - Warn about using default 'assign' property on object types
   (attempting to follow gcc behavior).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56507 91177308-0d34-0410-b5e6-96231b3b80d8

Fix <rdar://problem/6240065> clang: __BLOCKS__ should be defined.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56503 91177308-0d34-0410-b5e6-96231b3b80d8

RewriteBlocks::RewriteBlockPointerDecl(): Handle TypedefDecl's and VarDecl's uniformly.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56500 91177308-0d34-0410-b5e6-96231b3b80d8

Teach block rewriter to replace '^' with '*' in VarDecls.

Since we don't have DeclGroup's and location information for types, there is some fancy footwork to do this fairly reliably.

O.K...it's a kludge. One day, we can use this as motivation to do this more gracefully:-)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56499 91177308-0d34-0410-b5e6-96231b3b80d8

Added test case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56493 91177308-0d34-0410-b5e6-96231b3b80d8

Fix PR 2819: Compute dataflow values for all CFG blocks by not relying on having the "Exit" block being reachable by all (or any) of the blocks in the CFG.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56492 91177308-0d34-0410-b5e6-96231b3b80d8

Add x86_64 Linux target.
  - PR2824

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56491 91177308-0d34-0410-b5e6-96231b3b80d8

Updated checker build.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56484 91177308-0d34-0410-b5e6-96231b3b80d8

Bug fix, result of isIntegerConstantExpr could be of incorrect width
for type.
  - PR2817

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56482 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Add header and "report bug" links to report pages.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56470 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Add links to open files using default file handler.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56454 91177308-0d34-0410-b5e6-96231b3b80d8

Yank out special CSS for button rendering (not very portable or well tested, and we were encountering race conditions with CSS loading).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56449 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Update for "button" class change, drop magic resolution of
"scanview.css", start action for opening files.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56448 91177308-0d34-0410-b5e6-96231b3b80d8

Reintegrate Daniel's changes.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56447 91177308-0d34-0410-b5e6-96231b3b80d8

Removed scan-view's version of scanview.css.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56446 91177308-0d34-0410-b5e6-96231b3b80d8

Add "SUMMARYENDHEAD" tag.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56445 91177308-0d34-0410-b5e6-96231b3b80d8

Don't embed CSS inside scan-build script; use external scanview.css.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56444 91177308-0d34-0410-b5e6-96231b3b80d8

Don't emit link to source file.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56443 91177308-0d34-0410-b5e6-96231b3b80d8

Make "View Report" just a normal link again.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56442 91177308-0d34-0410-b5e6-96231b3b80d8

Don't print out the path length.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56441 91177308-0d34-0410-b5e6-96231b3b80d8

Output "REPORTHEADER" and "REPORTSUMMARYEXTRA" tags for use with scan-view.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56440 91177308-0d34-0410-b5e6-96231b3b80d8

not executable

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56439 91177308-0d34-0410-b5e6-96231b3b80d8

Remove unused slot/reference and update Sema::ActOnIdentifierExpr().

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56438 91177308-0d34-0410-b5e6-96231b3b80d8

Fix http://llvm.org/bugs/show_bug.cgi?id=2816.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56433 91177308-0d34-0410-b5e6-96231b3b80d8

Use scan-view to view reports.  Opening index.html is deprecated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56431 91177308-0d34-0410-b5e6-96231b3b80d8

Updated checker build

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56430 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Add links from bug reporting forms to report & summary pages.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56427 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Search for available port if default is unavailable.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56426 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Store bug reporter defaults in ~/.scanview.cfg

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56424 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view tweak
 - Require index.html in provided results directory.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56423 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view tweaks
 - Use more correct HTTP error codes on (unexpected) errors.

 - Use onLoad to set ensure bug submission method gets set correctly.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56422 91177308-0d34-0410-b5e6-96231b3b80d8

Patch from Richard Godbee:

Improve scan-build results to include the user's host name, the working
directory of the analyzed project, and the date the analysis run took place.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56421 91177308-0d34-0410-b5e6-96231b3b80d8

Improve scan-view report bug (submitted) interface.

Give more meaningful error messages / fail gracefully on bad form
input or SMTP errors.

Use button for Report Bug link (where available).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56420 91177308-0d34-0410-b5e6-96231b3b80d8

Improve scan-view report bug interface.
 - Pulled css out into Resources/scanview.css

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56416 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view tweaks:
 - Add simple favicon
 - Allow resolving source file paths (should be rethought)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56414 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view tweaks:
 - Update for scan-build table change.
 - Add --auto-reload option (for development, avoids need to restart
   server).
 - Always send Last-Modified, with a reasonable value for dynamic content.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56409 91177308-0d34-0410-b5e6-96231b3b80d8

Add webkit styles using Javascript (detect for AppleWebKit)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56408 91177308-0d34-0410-b5e6-96231b3b80d8

Unbreak using abs_path.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56407 91177308-0d34-0410-b5e6-96231b3b80d8

scan-view: Add more information to default bug description and use
iframe to embed bug view (for easy reference).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56406 91177308-0d34-0410-b5e6-96231b3b80d8

Change casing of bug type.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56405 91177308-0d34-0410-b5e6-96231b3b80d8

Don't add Bugzilla reporter (not yet implemented)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56404 91177308-0d34-0410-b5e6-96231b3b80d8

The checks in BasicObjCFoundationChecks now have a category: "API Misuse (Apple)"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56403 91177308-0d34-0410-b5e6-96231b3b80d8

The "unused ivar" check now has a category: "Optimization"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56402 91177308-0d34-0410-b5e6-96231b3b80d8

Built-in checks now have a category: "Logic Errors"

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56401 91177308-0d34-0410-b5e6-96231b3b80d8

Added experimental "intelligent-sizing" of HTML message bubbles based on the contents of the message.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56400 91177308-0d34-0410-b5e6-96231b3b80d8

Remove debugging message.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56398 91177308-0d34-0410-b5e6-96231b3b80d8

Unbreak ccc-analyzer: getcwd is from package Cwd

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56397 91177308-0d34-0410-b5e6-96231b3b80d8

Patch by Richard Godbee:

Output to .info files the absolute paths to files that were rejected by the
parser or crashed the analyzer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56396 91177308-0d34-0410-b5e6-96231b3b80d8

scan-build now prints out bug categories.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56395 91177308-0d34-0410-b5e6-96231b3b80d8

Add a bug category for NSError** checks.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56394 91177308-0d34-0410-b5e6-96231b3b80d8

Have ScanView.py generate a "<td></td>" pair in the output HTML instead of having scan-build output an empty (and possibly unused) <td>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56393 91177308-0d34-0410-b5e6-96231b3b80d8

Update VS projects.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56390 91177308-0d34-0410-b5e6-96231b3b80d8

Add "category" to BugTypes, allowing bugs to be grouped.
Changed casing of many bug names.  The convention will be to have bug names (mostly) lower cased, and categories use some capitalization.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56385 91177308-0d34-0410-b5e6-96231b3b80d8

Add PostStore, a new ProgramPoint to distinguish between 'stores' and other PostStmts.

GRExprEngine:
  Use PostStore in EvalStore.
  Use a second version of EvalStore in EvalBinaryOperator to associate the store with the expression on the LHS.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56383 91177308-0d34-0410-b5e6-96231b3b80d8

Make scan-view more robust / friendly when bug reporting fails.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56382 91177308-0d34-0410-b5e6-96231b3b80d8

Add initial implementation of scan-view
 - Web based interface to static analyzer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56375 91177308-0d34-0410-b5e6-96231b3b80d8

Add REPORTBUG marker to scan-build.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56373 91177308-0d34-0410-b5e6-96231b3b80d8

Test case for transfer function logic of const casts.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56369 91177308-0d34-0410-b5e6-96231b3b80d8

Bug fix: for the base transfer function logic for casts, handle const casts as just propagating the value.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56368 91177308-0d34-0410-b5e6-96231b3b80d8

Update checker build

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56367 91177308-0d34-0410-b5e6-96231b3b80d8

Fixed logic error in BasicConstraintManager pointed out by Zhongxing Xu.

For checking if a symbol >= value, we need to check if symbol == value || symbol
> value. When checking symbol > value and we know that symbol != value, the path
is infeasible only if value == maximum integer.

For checking if a symbol <= value, we need to check if symbol == value || symbol
< value. When checking symbol < value and we know that symbol != value, the path
is infeasible only if value == minimum integer.

Updated test case exercising this logic: we only prune paths if the values are
unsigned.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56354 91177308-0d34-0410-b5e6-96231b3b80d8

Fix rdar://6222856: the receiver of a message expr is an
arbitrary expr, not just a assign expr.  The grammar comment
was right, the code was just wrong.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56353 91177308-0d34-0410-b5e6-96231b3b80d8

When we have a binary expression 'int operator symbol', properly rewrite this as
'symbol operator-reverse int'. This patch is a combination of code from
Zhongxing Xu and myself (Zhongxing noticed this bug for the cases of
relational operators).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56351 91177308-0d34-0410-b5e6-96231b3b80d8

Add an omitted case for AssumeSymInt.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56334 91177308-0d34-0410-b5e6-96231b3b80d8

Updated checker build.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56333 91177308-0d34-0410-b5e6-96231b3b80d8

Added test case for PR 2600: proper use of NSError**

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56332 91177308-0d34-0410-b5e6-96231b3b80d8

Add panic function "__assert_fail".

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56327 91177308-0d34-0410-b5e6-96231b3b80d8

Register the implicit null-dereferenced object as a notable symbol.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56319 91177308-0d34-0410-b5e6-96231b3b80d8

Implement second part of PR 2600: NSError** parameter may be null, and should be checked before being dereferenced.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56318 91177308-0d34-0410-b5e6-96231b3b80d8

Update Xcode project.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56317 91177308-0d34-0410-b5e6-96231b3b80d8

Analysis option -warn-objc-nserror-methods is no longer available. (check is done automatically with -checker-cfref)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56313 91177308-0d34-0410-b5e6-96231b3b80d8

Change implementation of NSError** coding-style check to be invoked at the end of the retain/release analysis.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56312 91177308-0d34-0410-b5e6-96231b3b80d8

Finish pushing blocks attribute through the clang attribute machinery.
Also added a couple simple tests from the "gcc.apple" test suite.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56309 91177308-0d34-0410-b5e6-96231b3b80d8

Add driver support for invoking block rewriter.
Also tweaked the create function to take an explicit output file.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56305 91177308-0d34-0410-b5e6-96231b3b80d8

Enable '-warn-objc-nserror-methods' by default.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56298 91177308-0d34-0410-b5e6-96231b3b80d8

Implemented one of the checks requested in PR 2600:
"Method accepting NSError** argument should have non-void return value to indicate that an error occurred."

Test case written, but the header needs to be delta-debugged reduced.  Will commit shortly.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56297 91177308-0d34-0410-b5e6-96231b3b80d8

Added CFNumberCreate test case to illustrate a 32-bit/64-bit arch issue.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56295 91177308-0d34-0410-b5e6-96231b3b80d8

Add path-sensitivity test case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56294 91177308-0d34-0410-b5e6-96231b3b80d8

Improve x86 ABI compatibility.
 - Enables use of ABIArgInfo::Expand when needed. This greatly
   improves our x86 ABI compatibility.

 - As the infrastructure for target specific ABI handling isn't built
   yet, this change means ABI compatibility on other platforms is once
   again broken in a different way than before.

 - Upcoming: Figure out how to refactor ABI handling into
   targets. More documentation.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56293 91177308-0d34-0410-b5e6-96231b3b80d8

Print current function on verification failures.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56291 91177308-0d34-0410-b5e6-96231b3b80d8

Drop CodeGenTypes parameter to classifyArgumentType.

Ensure that ABIArgInfo::Default implementation for aggregrate types
is sensible (StructRet on return and ByVal on arguments).

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56289 91177308-0d34-0410-b5e6-96231b3b80d8

Remove BlockStmtExpr.
Block literals are now represented by the concrete BlockExpr class.
This is cleanup (removes a FIXME).
No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56288 91177308-0d34-0410-b5e6-96231b3b80d8

Another attempt to make test/Makefile return correct error code.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56285 91177308-0d34-0410-b5e6-96231b3b80d8

Fix http://llvm.org/bugs/show_bug.cgi?id=2760.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56280 91177308-0d34-0410-b5e6-96231b3b80d8

Updated checker build.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56274 91177308-0d34-0410-b5e6-96231b3b80d8

Fix comment typo.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56271 91177308-0d34-0410-b5e6-96231b3b80d8

Add support for ABIArgInfo::Expand
 - No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56269 91177308-0d34-0410-b5e6-96231b3b80d8

Add support for rewriting blocks...

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56266 91177308-0d34-0410-b5e6-96231b3b80d8

Ignore XFAIL tests when checking for make failure in test/

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56262 91177308-0d34-0410-b5e6-96231b3b80d8

Fix copy-paste error in test case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56261 91177308-0d34-0410-b5e6-96231b3b80d8

Minor pass-sensitivity improvement:
  if we know that 'len != 0' and know that 'i == 0' then we know that
  'i < len' must evaluate to true and cannot evaluate to false

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56260 91177308-0d34-0410-b5e6-96231b3b80d8

Update Xcode project.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56259 91177308-0d34-0410-b5e6-96231b3b80d8

Remove support for BlockExprExpr. For example...
 ^(expression) or ^(int arg1, float arg2)(expression)
...is no longer supported.
All block literals now require a compound statement.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56257 91177308-0d34-0410-b5e6-96231b3b80d8

Sema::ActOnBlockReturnStmt(): Need to perform the UsualUnaryConversions on the return type.
Sema::CheckReturnStackAddr(): Make sure we skip over implicit casts.
Added some more test cases...

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56254 91177308-0d34-0410-b5e6-96231b3b80d8

ProgramPoint now takes the space of two pointers instead of one. This change was
motivated because it became clear that the number of subclasses of ProgramPoint
would expand and we ran out of bits to represent a pointer variant. As a plus of
this change, BlockEdge program points can now be represented explicitly without
using a cache of CFGBlock* pairs in CFG.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56245 91177308-0d34-0410-b5e6-96231b3b80d8

Fixed an offset calculation error.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56242 91177308-0d34-0410-b5e6-96231b3b80d8

Patch by Csaba Hruska!

"Here is a patch what replaces std::ostream with llvm::raw_ostream. This patch
covers the AST library, but ignores Analysis lib."

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56185 91177308-0d34-0410-b5e6-96231b3b80d8